[jira] [Commented] (CB-14152) cordova-js tools patch release Jun 21, 2018

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520041#comment-16520041
 ] 

ASF GitHub Bot commented on CB-14152:
-

dpogue commented on a change in pull request #834: CB-14152 add 
cordova-js@4.2.4 blog post
URL: https://github.com/apache/cordova-docs/pull/834#discussion_r197348546
 
 

 ##
 File path: www/_posts/2018-06-22-cordova-js-release-4.2.4.md
 ##
 @@ -0,0 +1,24 @@
+---
+layout: post
+author:
+name: Chris Brody
+url: https://twitter.com/brodybits
+title:  "Cordova-JS release"
+categories: news
+tags: release tools
+---
+
+We are happy to announce that `cordova-js 4.2.4` has been released. This is 
the source of the JavaScript code in `cordova.js` used in each of the Cordova 
platform implementations.
+
+## Release Highlights
+
+The purpose of this release is to include a recent logging update with 
internal `npm audit` messages resolved in the package build. Here are the major 
changes:
+
+* [CB-9366](https://issues.apache.org/jira/browse/CB-9366) log `error.stack` 
data
+* [CB-14145](https://issues.apache.org/jira/browse/CB-14145) `package.json` 
resolve `npm audit` warnings in `devDependencies` (for build and test scripts)
+* [CB-14155](https://issues.apache.org/jira/browse/CB-14155) fix btest build 
target (by using `express` instead of `connect` in `devDependencies`)
+* Other internal test fixes
+
+## Deprecation Note
+
+As NodeJS 4.x support ended on April 30th, 2018, we are proceeding 
with our [previously 
announced](https://cordova.apache.org/news/2016/10/01/0.x-4.x-deprecation-timeline.html)
 deprecation timeline.  This is probably the last release that will support 
NodeJS 4.x.
 
 Review comment:
   cordova-js was never really compatible with node (it's a client-side 
library, effectively) so I'm not sure this notice makes sense on this post.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-js tools patch release Jun 21, 2018
> ---
>
> Key: CB-14152
> URL: https://issues.apache.org/jira/browse/CB-14152
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-js
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> Following steps at 
> [https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md]
>  (with some adaptations)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14154) Expose gradle configuration properties in config.xml to assist aligning Google Play Services / Firebase

[JIRA]

[ 
https://issues.apache.org/jira/browse/CB-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520015#comment-16520015
 ] 

Gearóid M commented on CB-14154:


I am not hugely familiar with the codebase, as I only started contributing 
recently. I think it's most likely in the `cordova-android` repository. If you 
can find what you're looking for there, it could be in `cordova-lib` or 
`cordova-common`.

> Expose gradle configuration properties in config.xml to assist aligning 
> Google Play Services / Firebase
> ---
>
> Key: CB-14154
> URL: https://issues.apache.org/jira/browse/CB-14154
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
>Reporter: Christopher Scott
>Assignee: Joe Bowser
>Priority: Major
>  Labels: build
>
> I am a full-time plugin developer.  Like many other plugins, I import Google 
> Play Services dependencies in addition to Android Support libraries 
> (appcompat-v7).
> By far the biggest problem I encounter with my users is [Gradle 
> conflicts|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues?utf8=%E2%9C%93&q=android+build+error]
>  due to multiple plugins importing different versions of 
> {color:#33}play-services / Firebase / com.android.support{color} 
> libraries.
> Many plugin authors do the wrong thing and simply use version ":+", eg: 
> [cordova-plugin-firebase|https://github.com/arnesson/cordova-plugin-firebase/blob/master/plugin.xml#L61-L67]].
> Quite often, my solution for these users is to [edit 
> platforms/android/project.properties|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues/699#issuecomment-396083457]*_,_*
>  which is not the best long-term solution, since this file is _volatile_.
> What I've been doing since cordova@7.1.0 is [expose custom config properties 
> in my plugins' 
> plugin.xml|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L98-L101].
>   This is nice, but users must align their google-play / Firebase / Support 
> dependencies [for each plugin that exposes 
> these|https://github.com/transistorsoft/cordova-background-geolocation-lt#configuring-play-services-version]
>  helpful properties (and not many plugins do).
>  
> What would *_really_* help, is if cordova-android could expose variables in 
> the app's config.xml in the same manner as:
>  * cdvCompileSdkVersion
>  * cdvBuildToolsVersion
>  * cdvMinSdkVersion
> I would like to see the following properties added:
>  * cdvGooglePlayServicesVersion
>  * cdvSupportLibVersion
> (Note:  cdvGooglePlayServicesVersion could be named cdvGoogleApiVersion as a 
> more common name, since both Firebase and Google Play Services dependencies 
> must be aligned to the same version.)
> I would like to be able to access these properties in my plugin's [plugin.xml 
> here|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L99]]
>  instead of using my plugin's custom $GOOGLE_API_VERSION variable.
> In a React Native app, which provides direct control over one's top-level 
> build.gradle, we do it [like 
> this|https://github.com/transistorsoft/rn-background-geolocation-demo/blob/master/android/build.gradle#L33-L38]].
>   3rd-party plugins then check for the existence of these Gradle Config 
> Properties when importing their Google dependencies, [like 
> this|https://github.com/transistorsoft/react-native-background-geolocation/blob/master/android/build.gradle#L33].
> This technique is also recommend at android.developer.com in the document 
> [Gradle Tips and 
> Tricks|https://developer.android.com/studio/build/gradle-tips] (search 
> "project-wide properties")
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14160) The project with cocoapods override the preprocessor macro.

[takuya (JIRA)]

takuya created CB-14160:
---

 Summary: The project with  cocoapods override the preprocessor 
macro.
 Key: CB-14160
 URL: https://issues.apache.org/jira/browse/CB-14160
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-ios
Reporter: takuya
Assignee: Suraj Pindoria


The preprocessor macro *DEBUG=1* defined in *build-debug.xcconfig* is 
overridden by *Pods-[project name].debug.xcconfig* when the project uses 
CocoaPods.

In a standard Cordova project *build-debug.xcconfig* defines the preprocessor 
macro *DEBUG=1* as follows:

*GCC_PREPROCESSOR_DEFINITIONS = DEBUG=1*

The *phonegap-plugin-push*, for example, override the 
GCC_PREPROCESSOR_DEFINITIONS with:

```
GCC_PREPROCESSOR_DEFINITIONS = $(inherited) COCOAPODS=1 $(inherited) 
GPB_USE_PROTOBUF_FRAMEWORK_IMPORTS=1 $(inherited) PB_FIELD_32BIT=1 
PB_NO_PACKED_STRUCTS=1
```

This issue can exist with other plugins that use CocoaPods.

*Reproduce Steps*

```
$ cordova create test
$ cd test
$ cordova platform add ios
$ cordova plugin add phonegap-plugin-push
```

The $(inherited) does not work when xcconfig file includes other xcconfig files.
See [https://github.com/CocoaPods/CocoaPods/issues/5785] .

As a result, the following code does not work in the debug build application.

```
#ifdef DEBUG
NSLog(@"debug step 1");
#endif
```

Note that this issue will be improved in Xcode 10 in which the function of 
$(inherited) is improved.
See also 
[https://stackoverflow.com/questions/1393987/how-to-append-values-in-xcconfig-variables]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14152) cordova-js tools patch release Jun 21, 2018

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520012#comment-16520012
 ] 

ASF GitHub Bot commented on CB-14152:
-

brodybits opened a new pull request #834: CB-14152 add cordova-js@4.2.4 blog 
post
URL: https://github.com/apache/cordova-docs/pull/834
 
 
   
   
   ### Platforms affected
   
   All
   
   ### What does this PR do?
   
   - cordova-js@4.2.4 blog post
   
   ### What testing has been done on this change?
   
   Author proofread
   
   ### Checklist
   
   - [x] __[Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database__
   - [x] Commit message follows the format: "GH-3232: (android) Fix bug with 
resolving file paths", where GH- is the GitHub issue ID & "android" is the 
platform affected.
   - ~~Added automated test coverage as appropriate for this change.~~
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-js tools patch release Jun 21, 2018
> ---
>
> Key: CB-14152
> URL: https://issues.apache.org/jira/browse/CB-14152
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-js
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> Following steps at 
> [https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md]
>  (with some adaptations)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14152) cordova-js tools patch release Jun 21, 2018

[Chris Brody (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519989#comment-16519989
 ] 

Chris Brody commented on CB-14152:
--

Also checked results of: {{coho audit-license-headers -r js}}

> cordova-js tools patch release Jun 21, 2018
> ---
>
> Key: CB-14152
> URL: https://issues.apache.org/jira/browse/CB-14152
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-js
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> Following steps at 
> [https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md]
>  (with some adaptations)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14152) cordova-js tools patch release Jun 21, 2018

[Chris Brody (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519987#comment-16519987
 ] 

Chris Brody commented on CB-14152:
--

cordova-js@4.2.4 tested as follows:

{code:bash}
$ (cd cordova-js; grunt test --platformVersion=4.0.0)
Running "compile:test" (compile) task
generated cordova.test.js @ e040d9e9343d5f27dd4f67616660b33b92a82ff7 in 33ms

Running "_test" task
starting node-based tests

Unit Tests:
Could not find cordova.js script tag. Plugin loading may fail.
.

Finished in 0.371 seconds
125 tests, 209 assertions, 0 failures, 0 skipped


Done.
{code}

Also test with {coho copy-js -r android} shows change from CB-9366 log 
error.stack included as expected in {templates/project/assets/www/cordova.js} 
on {cordova-android}.

> cordova-js tools patch release Jun 21, 2018
> ---
>
> Key: CB-14152
> URL: https://issues.apache.org/jira/browse/CB-14152
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-js
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> Following steps at 
> [https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md]
>  (with some adaptations)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14154) Expose gradle configuration properties in config.xml to assist aligning Google Play Services / Firebase

[Christopher Scott (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519981#comment-16519981
 ] 

Christopher Scott commented on CB-14154:


More and more plugins are requiring dependencies from play-services / Firebase 
these days.  After 4+ years as a full-time plugin author, this is by far the 
biggest generator of support issues.  It's a complete mess down here in the 
trenches with gradle build conflicts between plugins.

> Expose gradle configuration properties in config.xml to assist aligning 
> Google Play Services / Firebase
> ---
>
> Key: CB-14154
> URL: https://issues.apache.org/jira/browse/CB-14154
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
>Reporter: Christopher Scott
>Assignee: Joe Bowser
>Priority: Major
>  Labels: build
>
> I am a full-time plugin developer.  Like many other plugins, I import Google 
> Play Services dependencies in addition to Android Support libraries 
> (appcompat-v7).
> By far the biggest problem I encounter with my users is [Gradle 
> conflicts|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues?utf8=%E2%9C%93&q=android+build+error]
>  due to multiple plugins importing different versions of 
> {color:#33}play-services / Firebase / com.android.support{color} 
> libraries.
> Many plugin authors do the wrong thing and simply use version ":+", eg: 
> [cordova-plugin-firebase|https://github.com/arnesson/cordova-plugin-firebase/blob/master/plugin.xml#L61-L67]].
> Quite often, my solution for these users is to [edit 
> platforms/android/project.properties|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues/699#issuecomment-396083457]*_,_*
>  which is not the best long-term solution, since this file is _volatile_.
> What I've been doing since cordova@7.1.0 is [expose custom config properties 
> in my plugins' 
> plugin.xml|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L98-L101].
>   This is nice, but users must align their google-play / Firebase / Support 
> dependencies [for each plugin that exposes 
> these|https://github.com/transistorsoft/cordova-background-geolocation-lt#configuring-play-services-version]
>  helpful properties (and not many plugins do).
>  
> What would *_really_* help, is if cordova-android could expose variables in 
> the app's config.xml in the same manner as:
>  * cdvCompileSdkVersion
>  * cdvBuildToolsVersion
>  * cdvMinSdkVersion
> I would like to see the following properties added:
>  * cdvGooglePlayServicesVersion
>  * cdvSupportLibVersion
> (Note:  cdvGooglePlayServicesVersion could be named cdvGoogleApiVersion as a 
> more common name, since both Firebase and Google Play Services dependencies 
> must be aligned to the same version.)
> I would like to be able to access these properties in my plugin's [plugin.xml 
> here|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L99]]
>  instead of using my plugin's custom $GOOGLE_API_VERSION variable.
> In a React Native app, which provides direct control over one's top-level 
> build.gradle, we do it [like 
> this|https://github.com/transistorsoft/rn-background-geolocation-demo/blob/master/android/build.gradle#L33-L38]].
>   3rd-party plugins then check for the existence of these Gradle Config 
> Properties when importing their Google dependencies, [like 
> this|https://github.com/transistorsoft/react-native-background-geolocation/blob/master/android/build.gradle#L33].
> This technique is also recommend at android.developer.com in the document 
> [Gradle Tips and 
> Tricks|https://developer.android.com/studio/build/gradle-tips] (search 
> "project-wide properties")
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12849) Media Plugin: Saves file not in indicated directory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519978#comment-16519978
 ] 

ASF GitHub Bot commented on CB-12849:
-

knight commented on issue #168: CB-12849: checking mediaState in destroy 
method, and moving file by stream when renameTo failing
URL: 
https://github.com/apache/cordova-plugin-media/pull/168#issuecomment-399312189
 
 
   Ok, I have rebased master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Media Plugin: Saves file not in indicated directory
> ---
>
> Key: CB-12849
> URL: https://issues.apache.org/jira/browse/CB-12849
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-plugin-media
>Affects Versions: 6.5.0
> Environment: Device model: Nexus 5X
>  Android version of device: 8.1.0
>  Platform version: 7.1.0
>  Cordova version: 8.0.0
>  Cordova plugin media version: 5.0.1
>Reporter: Florian Pechwitz
>Priority: Major
>  Labels: cordova-plugin-media
>
> I tried to build an application which records, stops the recording and then 
> plays the recorded audio.
> The recording works fine but if I try to play the recorded audio I get error 
> code 1. I found out that the recorded audio file was not in the directory but 
> in a totally different directory 
> (/storage/emulated/0/(tmprecording-1495618229386.3gp) with a different file 
> name (tmprecording-1495618229386.3gp) and a different media type (video/3gpp) 
> as indicated.
> I created a repo with a example application for this issue: 
> https://github.com/Durzan666/cordova-plugin-media-demo



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14154) Expose gradle configuration properties in config.xml to assist aligning Google Play Services / Firebase

[Christopher Scott (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519976#comment-16519976
 ] 

Christopher Scott commented on CB-14154:


Ok, so I simply fork this?

https://github.com/apache/cordova-android

> Expose gradle configuration properties in config.xml to assist aligning 
> Google Play Services / Firebase
> ---
>
> Key: CB-14154
> URL: https://issues.apache.org/jira/browse/CB-14154
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
>Reporter: Christopher Scott
>Assignee: Joe Bowser
>Priority: Major
>  Labels: build
>
> I am a full-time plugin developer.  Like many other plugins, I import Google 
> Play Services dependencies in addition to Android Support libraries 
> (appcompat-v7).
> By far the biggest problem I encounter with my users is [Gradle 
> conflicts|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues?utf8=%E2%9C%93&q=android+build+error]
>  due to multiple plugins importing different versions of 
> {color:#33}play-services / Firebase / com.android.support{color} 
> libraries.
> Many plugin authors do the wrong thing and simply use version ":+", eg: 
> [cordova-plugin-firebase|https://github.com/arnesson/cordova-plugin-firebase/blob/master/plugin.xml#L61-L67]].
> Quite often, my solution for these users is to [edit 
> platforms/android/project.properties|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues/699#issuecomment-396083457]*_,_*
>  which is not the best long-term solution, since this file is _volatile_.
> What I've been doing since cordova@7.1.0 is [expose custom config properties 
> in my plugins' 
> plugin.xml|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L98-L101].
>   This is nice, but users must align their google-play / Firebase / Support 
> dependencies [for each plugin that exposes 
> these|https://github.com/transistorsoft/cordova-background-geolocation-lt#configuring-play-services-version]
>  helpful properties (and not many plugins do).
>  
> What would *_really_* help, is if cordova-android could expose variables in 
> the app's config.xml in the same manner as:
>  * cdvCompileSdkVersion
>  * cdvBuildToolsVersion
>  * cdvMinSdkVersion
> I would like to see the following properties added:
>  * cdvGooglePlayServicesVersion
>  * cdvSupportLibVersion
> (Note:  cdvGooglePlayServicesVersion could be named cdvGoogleApiVersion as a 
> more common name, since both Firebase and Google Play Services dependencies 
> must be aligned to the same version.)
> I would like to be able to access these properties in my plugin's [plugin.xml 
> here|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L99]]
>  instead of using my plugin's custom $GOOGLE_API_VERSION variable.
> In a React Native app, which provides direct control over one's top-level 
> build.gradle, we do it [like 
> this|https://github.com/transistorsoft/rn-background-geolocation-demo/blob/master/android/build.gradle#L33-L38]].
>   3rd-party plugins then check for the existence of these Gradle Config 
> Properties when importing their Google dependencies, [like 
> this|https://github.com/transistorsoft/react-native-background-geolocation/blob/master/android/build.gradle#L33].
> This technique is also recommend at android.developer.com in the document 
> [Gradle Tips and 
> Tricks|https://developer.android.com/studio/build/gradle-tips] (search 
> "project-wide properties")
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14154) Expose gradle configuration properties in config.xml to assist aligning Google Play Services / Firebase

[JIRA]

[ 
https://issues.apache.org/jira/browse/CB-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519973#comment-16519973
 ] 

Gearóid M commented on CB-14154:


Ah I see! I'm not too familiar with using Google Play Services, but had 
remembered reading that blog post. Perhaps you could create a PR to add these 
config properties? It sounds like you have a very good idea of how it would 
work.

> Expose gradle configuration properties in config.xml to assist aligning 
> Google Play Services / Firebase
> ---
>
> Key: CB-14154
> URL: https://issues.apache.org/jira/browse/CB-14154
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
>Reporter: Christopher Scott
>Assignee: Joe Bowser
>Priority: Major
>  Labels: build
>
> I am a full-time plugin developer.  Like many other plugins, I import Google 
> Play Services dependencies in addition to Android Support libraries 
> (appcompat-v7).
> By far the biggest problem I encounter with my users is [Gradle 
> conflicts|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues?utf8=%E2%9C%93&q=android+build+error]
>  due to multiple plugins importing different versions of 
> {color:#33}play-services / Firebase / com.android.support{color} 
> libraries.
> Many plugin authors do the wrong thing and simply use version ":+", eg: 
> [cordova-plugin-firebase|https://github.com/arnesson/cordova-plugin-firebase/blob/master/plugin.xml#L61-L67]].
> Quite often, my solution for these users is to [edit 
> platforms/android/project.properties|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues/699#issuecomment-396083457]*_,_*
>  which is not the best long-term solution, since this file is _volatile_.
> What I've been doing since cordova@7.1.0 is [expose custom config properties 
> in my plugins' 
> plugin.xml|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L98-L101].
>   This is nice, but users must align their google-play / Firebase / Support 
> dependencies [for each plugin that exposes 
> these|https://github.com/transistorsoft/cordova-background-geolocation-lt#configuring-play-services-version]
>  helpful properties (and not many plugins do).
>  
> What would *_really_* help, is if cordova-android could expose variables in 
> the app's config.xml in the same manner as:
>  * cdvCompileSdkVersion
>  * cdvBuildToolsVersion
>  * cdvMinSdkVersion
> I would like to see the following properties added:
>  * cdvGooglePlayServicesVersion
>  * cdvSupportLibVersion
> (Note:  cdvGooglePlayServicesVersion could be named cdvGoogleApiVersion as a 
> more common name, since both Firebase and Google Play Services dependencies 
> must be aligned to the same version.)
> I would like to be able to access these properties in my plugin's [plugin.xml 
> here|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L99]]
>  instead of using my plugin's custom $GOOGLE_API_VERSION variable.
> In a React Native app, which provides direct control over one's top-level 
> build.gradle, we do it [like 
> this|https://github.com/transistorsoft/rn-background-geolocation-demo/blob/master/android/build.gradle#L33-L38]].
>   3rd-party plugins then check for the existence of these Gradle Config 
> Properties when importing their Google dependencies, [like 
> this|https://github.com/transistorsoft/react-native-background-geolocation/blob/master/android/build.gradle#L33].
> This technique is also recommend at android.developer.com in the document 
> [Gradle Tips and 
> Tricks|https://developer.android.com/studio/build/gradle-tips] (search 
> "project-wide properties")
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-14154) Expose gradle configuration properties in config.xml to assist aligning Google Play Services / Firebase

[Christopher Scott (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519952#comment-16519952
 ] 

Christopher Scott edited comment on CB-14154 at 6/22/18 3:31 AM:
-

As I mentioned above, I'm _already_ doing that, implementing a custom variable 
GOOGLE_API_VERSION in my plugin.xml.

Some other plugin, eg phonegap-plugin-push calls their variable FCM_VERSION.  
Some other plugin might call theirs FIREBASE_VERSION.  Yet another will call 
theirs GOOGLE_PLAY_SERVICES_VERSION.  And another plugin might call theirs 
PLAY_SERVICES_VERSION.  All these variables doing the same thing and plugin 
consumers are baffled by all these different variables with no idea that they 
all have to align to the same version (eg: 15.0.1)

What's required here is a global config property provided by the cordova 
framework itself.
 * cdvGoogleApiVersion
 * cdvSupportLibVersion

For *all* plugin authors to align their dependencies to.


was (Author: christocracy):
As I mentioned above, I'm _already_ doing that, implementing a custom variable 
GOOGLE_API_VERSION in my plugin.xml.

Some other plugin, eg phonegap-plugin-push calls their variable FCM_VERSION.  
Some other plugin might call theirs FIREBASE_VERSION.  Yet another will call 
theirs GOOGLE_PLAY_SERVICES_VERSION.  And another plugin might call theirs 
PLAY_SERVICES_VERSION.  All these variables doing the same thing and plugin 
consumers are baffled by all these different variables with no idea that they 
all have to align to the same version.

What's required here is a global config property provided by the cordova 
framework itself.
 * cdvGoogleApiVersion
 * cdvSupportLibVersion

For *all* plugin authors to align their dependencies to.

> Expose gradle configuration properties in config.xml to assist aligning 
> Google Play Services / Firebase
> ---
>
> Key: CB-14154
> URL: https://issues.apache.org/jira/browse/CB-14154
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
>Reporter: Christopher Scott
>Assignee: Joe Bowser
>Priority: Major
>  Labels: build
>
> I am a full-time plugin developer.  Like many other plugins, I import Google 
> Play Services dependencies in addition to Android Support libraries 
> (appcompat-v7).
> By far the biggest problem I encounter with my users is [Gradle 
> conflicts|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues?utf8=%E2%9C%93&q=android+build+error]
>  due to multiple plugins importing different versions of 
> {color:#33}play-services / Firebase / com.android.support{color} 
> libraries.
> Many plugin authors do the wrong thing and simply use version ":+", eg: 
> [cordova-plugin-firebase|https://github.com/arnesson/cordova-plugin-firebase/blob/master/plugin.xml#L61-L67]].
> Quite often, my solution for these users is to [edit 
> platforms/android/project.properties|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues/699#issuecomment-396083457]*_,_*
>  which is not the best long-term solution, since this file is _volatile_.
> What I've been doing since cordova@7.1.0 is [expose custom config properties 
> in my plugins' 
> plugin.xml|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L98-L101].
>   This is nice, but users must align their google-play / Firebase / Support 
> dependencies [for each plugin that exposes 
> these|https://github.com/transistorsoft/cordova-background-geolocation-lt#configuring-play-services-version]
>  helpful properties (and not many plugins do).
>  
> What would *_really_* help, is if cordova-android could expose variables in 
> the app's config.xml in the same manner as:
>  * cdvCompileSdkVersion
>  * cdvBuildToolsVersion
>  * cdvMinSdkVersion
> I would like to see the following properties added:
>  * cdvGooglePlayServicesVersion
>  * cdvSupportLibVersion
> (Note:  cdvGooglePlayServicesVersion could be named cdvGoogleApiVersion as a 
> more common name, since both Firebase and Google Play Services dependencies 
> must be aligned to the same version.)
> I would like to be able to access these properties in my plugin's [plugin.xml 
> here|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L99]]
>  instead of using my plugin's custom $GOOGLE_API_VERSION variable.
> In a React Native app, which provides direct control over one's top-level 
> build.gradle, we do it [like 
> this|https://github.com/transistorsoft/rn-background-geolocation-demo/blob/master/android/build.gradle#L33-L38]].
>   3rd-party plugins then check for the existence of these Gradle Config 
> Properti

[jira] [Commented] (CB-14154) Expose gradle configuration properties in config.xml to assist aligning Google Play Services / Firebase

[Christopher Scott (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519952#comment-16519952
 ] 

Christopher Scott commented on CB-14154:


As I mentioned above, I'm _already_ doing that, implementing a custom variable 
GOOGLE_API_VERSION in my plugin.xml.

Some other plugin, eg phonegap-plugin-push calls their variable FCM_VERSION.  
Some other plugin might call theirs FIREBASE_VERSION.  Yet another will call 
theirs GOOGLE_PLAY_SERVICES_VERSION.  And another plugin might call theirs 
PLAY_SERVICES_VERSION.  All these variables doing the same thing and plugin 
consumers are baffled by all these different variables with no idea that they 
all have to align to the same version.

What's required here is a global config property provided by the cordova 
framework itself.
 * cdvGoogleApiVersion
 * cdvSupportLibVersion

For *all* plugin authors to align their dependencies to.

> Expose gradle configuration properties in config.xml to assist aligning 
> Google Play Services / Firebase
> ---
>
> Key: CB-14154
> URL: https://issues.apache.org/jira/browse/CB-14154
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
>Reporter: Christopher Scott
>Assignee: Joe Bowser
>Priority: Major
>  Labels: build
>
> I am a full-time plugin developer.  Like many other plugins, I import Google 
> Play Services dependencies in addition to Android Support libraries 
> (appcompat-v7).
> By far the biggest problem I encounter with my users is [Gradle 
> conflicts|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues?utf8=%E2%9C%93&q=android+build+error]
>  due to multiple plugins importing different versions of 
> {color:#33}play-services / Firebase / com.android.support{color} 
> libraries.
> Many plugin authors do the wrong thing and simply use version ":+", eg: 
> [cordova-plugin-firebase|https://github.com/arnesson/cordova-plugin-firebase/blob/master/plugin.xml#L61-L67]].
> Quite often, my solution for these users is to [edit 
> platforms/android/project.properties|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues/699#issuecomment-396083457]*_,_*
>  which is not the best long-term solution, since this file is _volatile_.
> What I've been doing since cordova@7.1.0 is [expose custom config properties 
> in my plugins' 
> plugin.xml|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L98-L101].
>   This is nice, but users must align their google-play / Firebase / Support 
> dependencies [for each plugin that exposes 
> these|https://github.com/transistorsoft/cordova-background-geolocation-lt#configuring-play-services-version]
>  helpful properties (and not many plugins do).
>  
> What would *_really_* help, is if cordova-android could expose variables in 
> the app's config.xml in the same manner as:
>  * cdvCompileSdkVersion
>  * cdvBuildToolsVersion
>  * cdvMinSdkVersion
> I would like to see the following properties added:
>  * cdvGooglePlayServicesVersion
>  * cdvSupportLibVersion
> (Note:  cdvGooglePlayServicesVersion could be named cdvGoogleApiVersion as a 
> more common name, since both Firebase and Google Play Services dependencies 
> must be aligned to the same version.)
> I would like to be able to access these properties in my plugin's [plugin.xml 
> here|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L99]]
>  instead of using my plugin's custom $GOOGLE_API_VERSION variable.
> In a React Native app, which provides direct control over one's top-level 
> build.gradle, we do it [like 
> this|https://github.com/transistorsoft/rn-background-geolocation-demo/blob/master/android/build.gradle#L33-L38]].
>   3rd-party plugins then check for the existence of these Gradle Config 
> Properties when importing their Google dependencies, [like 
> this|https://github.com/transistorsoft/react-native-background-geolocation/blob/master/android/build.gradle#L33].
> This technique is also recommend at android.developer.com in the document 
> [Gradle Tips and 
> Tricks|https://developer.android.com/studio/build/gradle-tips] (search 
> "project-wide properties")
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12849) Media Plugin: Saves file not in indicated directory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519948#comment-16519948
 ] 

ASF GitHub Bot commented on CB-12849:
-

shazron commented on issue #168: CB-12849: checking mediaState in destroy 
method, and moving file by stream when renameTo failing
URL: 
https://github.com/apache/cordova-plugin-media/pull/168#issuecomment-399309428
 
 
   Looks like commit from master has passed, so feel free to rebase/merge this 
PR


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Media Plugin: Saves file not in indicated directory
> ---
>
> Key: CB-12849
> URL: https://issues.apache.org/jira/browse/CB-12849
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-plugin-media
>Affects Versions: 6.5.0
> Environment: Device model: Nexus 5X
>  Android version of device: 8.1.0
>  Platform version: 7.1.0
>  Cordova version: 8.0.0
>  Cordova plugin media version: 5.0.1
>Reporter: Florian Pechwitz
>Priority: Major
>  Labels: cordova-plugin-media
>
> I tried to build an application which records, stops the recording and then 
> plays the recorded audio.
> The recording works fine but if I try to play the recorded audio I get error 
> code 1. I found out that the recorded audio file was not in the directory but 
> in a totally different directory 
> (/storage/emulated/0/(tmprecording-1495618229386.3gp) with a different file 
> name (tmprecording-1495618229386.3gp) and a different media type (video/3gpp) 
> as indicated.
> I created a repo with a example application for this issue: 
> https://github.com/Durzan666/cordova-plugin-media-demo



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14154) Expose gradle configuration properties in config.xml to assist aligning Google Play Services / Firebase

[JIRA]

[ 
https://issues.apache.org/jira/browse/CB-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519943#comment-16519943
 ] 

Gearóid M commented on CB-14154:


There was a post about this quite recently on the Phonegap Blog actually. I'm 
not sure if the changes documented there fix your issue?

https://blog.phonegap.com/the-play-services-problem-with-cordova-applications-489c9aeb2e89

> Expose gradle configuration properties in config.xml to assist aligning 
> Google Play Services / Firebase
> ---
>
> Key: CB-14154
> URL: https://issues.apache.org/jira/browse/CB-14154
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
>Reporter: Christopher Scott
>Assignee: Joe Bowser
>Priority: Major
>  Labels: build
>
> I am a full-time plugin developer.  Like many other plugins, I import Google 
> Play Services dependencies in addition to Android Support libraries 
> (appcompat-v7).
> By far the biggest problem I encounter with my users is [Gradle 
> conflicts|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues?utf8=%E2%9C%93&q=android+build+error]
>  due to multiple plugins importing different versions of 
> {color:#33}play-services / Firebase / com.android.support{color} 
> libraries.
> Many plugin authors do the wrong thing and simply use version ":+", eg: 
> [cordova-plugin-firebase|https://github.com/arnesson/cordova-plugin-firebase/blob/master/plugin.xml#L61-L67]].
> Quite often, my solution for these users is to [edit 
> platforms/android/project.properties|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues/699#issuecomment-396083457]*_,_*
>  which is not the best long-term solution, since this file is _volatile_.
> What I've been doing since cordova@7.1.0 is [expose custom config properties 
> in my plugins' 
> plugin.xml|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L98-L101].
>   This is nice, but users must align their google-play / Firebase / Support 
> dependencies [for each plugin that exposes 
> these|https://github.com/transistorsoft/cordova-background-geolocation-lt#configuring-play-services-version]
>  helpful properties (and not many plugins do).
>  
> What would *_really_* help, is if cordova-android could expose variables in 
> the app's config.xml in the same manner as:
>  * cdvCompileSdkVersion
>  * cdvBuildToolsVersion
>  * cdvMinSdkVersion
> I would like to see the following properties added:
>  * cdvGooglePlayServicesVersion
>  * cdvSupportLibVersion
> (Note:  cdvGooglePlayServicesVersion could be named cdvGoogleApiVersion as a 
> more common name, since both Firebase and Google Play Services dependencies 
> must be aligned to the same version.)
> I would like to be able to access these properties in my plugin's [plugin.xml 
> here|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L99]]
>  instead of using my plugin's custom $GOOGLE_API_VERSION variable.
> In a React Native app, which provides direct control over one's top-level 
> build.gradle, we do it [like 
> this|https://github.com/transistorsoft/rn-background-geolocation-demo/blob/master/android/build.gradle#L33-L38]].
>   3rd-party plugins then check for the existence of these Gradle Config 
> Properties when importing their Google dependencies, [like 
> this|https://github.com/transistorsoft/react-native-background-geolocation/blob/master/android/build.gradle#L33].
> This technique is also recommend at android.developer.com in the document 
> [Gradle Tips and 
> Tricks|https://developer.android.com/studio/build/gradle-tips] (search 
> "project-wide properties")
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12849) Media Plugin: Saves file not in indicated directory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519941#comment-16519941
 ] 

ASF GitHub Bot commented on CB-12849:
-

shazron commented on issue #168: CB-12849: checking mediaState in destroy 
method, and moving file by stream when renameTo failing
URL: 
https://github.com/apache/cordova-plugin-media/pull/168#issuecomment-399308180
 
 
   I've pulled in #166. Once https://travis-ci.org/apache/cordova-plugin-media 
passes can you rebase/merge from master to get the latest changes and push this 
up so the CI can re-run?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Media Plugin: Saves file not in indicated directory
> ---
>
> Key: CB-12849
> URL: https://issues.apache.org/jira/browse/CB-12849
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-plugin-media
>Affects Versions: 6.5.0
> Environment: Device model: Nexus 5X
>  Android version of device: 8.1.0
>  Platform version: 7.1.0
>  Cordova version: 8.0.0
>  Cordova plugin media version: 5.0.1
>Reporter: Florian Pechwitz
>Priority: Major
>  Labels: cordova-plugin-media
>
> I tried to build an application which records, stops the recording and then 
> plays the recorded audio.
> The recording works fine but if I try to play the recorded audio I get error 
> code 1. I found out that the recorded audio file was not in the directory but 
> in a totally different directory 
> (/storage/emulated/0/(tmprecording-1495618229386.3gp) with a different file 
> name (tmprecording-1495618229386.3gp) and a different media type (video/3gpp) 
> as indicated.
> I created a repo with a example application for this issue: 
> https://github.com/Durzan666/cordova-plugin-media-demo



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519937#comment-16519937
 ] 

ASF GitHub Bot commented on CB-14091:
-

shazron closed pull request #166: CB-14091: fix tests code for stream url and 
remove browser
URL: https://github.com/apache/cordova-plugin-media/pull/166
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index 9e7438f0..f39fe518 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,35 +5,35 @@ addons:
 env:
   global:
   - SAUCE_USERNAME=snay
-  - TRAVIS_NODE_VERSION="4.2"
+  - TRAVIS_NODE_VERSION="6.14.2"
 matrix:
   include:
   - env: PLATFORM=browser-chrome
 os: linux
 language: node_js
-node_js: '4.2'
+node_js: '6.14.2'
   - env: PLATFORM=browser-firefox
 os: linux
 language: node_js
-node_js: '4.2'
+node_js: '6.14.2'
   - env: PLATFORM=browser-safari
 os: linux
 language: node_js
-node_js: '4.2'
+node_js: '6.14.2'
   - env: PLATFORM=browser-edge
 os: linux
 language: node_js
-node_js: '4.2'
+node_js: '6.14.2'
   - env: PLATFORM=ios-9.3
 os: osx
 osx_image: xcode7.3
 language: node_js
-node_js: '4.2'
+node_js: '6.14.2'
   - env: PLATFORM=ios-10.0
 os: osx
 osx_image: xcode7.3
 language: node_js
-node_js: '4.2'
+node_js: '6.14.2'
   - env: PLATFORM=android-4.4
 os: linux
 language: android
diff --git a/tests/tests.js b/tests/tests.js
index 218f2a95..953b9547 100644
--- a/tests/tests.js
+++ b/tests/tests.js
@@ -27,7 +27,7 @@
 var ACTUAL_PLAYBACK_TEST_TIMEOUT = 2 * 60 * 1000;
 
 var WEB_MP3_FILE = 'https://cordova.apache.org/downloads/BlueZedEx.mp3';
-var WEB_MP3_STREAM = 
'http://c22033-l.i.core.cdn.streamfarm.net/22033mdr/live/3087mdr_figaro/ch_classic_128.mp3';
+var WEB_MP3_STREAM = 'https://cordova.apache.org/downloads/BlueZedEx.mp3';
 
 var isWindows = cordova.platformId === 'windows8' || cordova.platformId === 
'windows';
 var isBrowser = cordova.platformId === 'browser';
@@ -37,6 +37,8 @@ var isBrowser = cordova.platformId === 'browser';
 var isAudioSupported = isWindows ? 
!!Windows.Media.Devices.MediaDevice.getDefaultAudioRenderId(Windows.Media.Devices.AudioDeviceRole.default)
 :
 cordova.platformId === 'ios' ? !window.SAUCELABS_ENV : true;
 
+var isKitKat = cordova.platformId === 'android' && 
/Android\s4\.4/.test(window.navigator.userAgent);
+
 exports.defineAutoTests = function () {
 var failed = function (done, msg, context) {
 if (context && context.done) return;
@@ -233,7 +235,7 @@ exports.defineAutoTests = function () {
 
 it("media.spec.19 position should be set properly", function 
(done) {
 // no audio hardware available
-if (!isAudioSupported) {
+if (!isAudioSupported || isBrowser || isKitKat) {
 pending();
 }
 
@@ -262,7 +264,7 @@ exports.defineAutoTests = function () {
 }, ACTUAL_PLAYBACK_TEST_TIMEOUT);
 
 it("media.spec.20 duration should be set properly", function 
(done) {
-if (!isAudioSupported || cordova.platformId === 
'blackberry10') {
+if (!isAudioSupported || cordova.platformId === 'blackberry10' 
|| isBrowser || isKitKat) {
 pending();
 }
 
@@ -291,7 +293,7 @@ exports.defineAutoTests = function () {
 }, ACTUAL_PLAYBACK_TEST_TIMEOUT);
 
 it("media.spec.21 should be able to resume playback after pause", 
function (done) {
-if (!isAudioSupported || cordova.platformId === 
'blackberry10') {
+if (!isAudioSupported || cordova.platformId === 'blackberry10' 
|| isKitKat) {
 pending();
 }
 
@@ -335,7 +337,7 @@ exports.defineAutoTests = function () {
 }, ACTUAL_PLAYBACK_TEST_TIMEOUT);
 
 it("media.spec.22 should be able to seek through file", function 
(done) {
-if (!isAudioSupported || cordova.platformId === 
'blackberry10') {
+if (!isAudioSupported || cordova.platformId === 'blackberry10' 
|| isKitKat) {
 pending();
 }
 
@@ -421,7 +423,7 @@ exports.defineAutoTests = function () {
 it("media.spec.25 should be able to play an audio stream", function 
(done) {
 // no audio hardware available, OR
 // O_o Safari can't play the stream, so we're skipping this test 
on all browsers o_O
-if (!isAudioSupported || isBrowser) {
+if (!isAudioSupported || isBrowser || isKitKat) {
 pending();
 }
 


 

--

[jira] [Commented] (CB-12849) Media Plugin: Saves file not in indicated directory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519929#comment-16519929
 ] 

ASF GitHub Bot commented on CB-12849:
-

knight commented on issue #168: CB-12849: checking mediaState in destroy 
method, and moving file by stream when renameTo failing
URL: 
https://github.com/apache/cordova-plugin-media/pull/168#issuecomment-399305568
 
 
   The travis CI errors are resolved by other PR 
https://github.com/apache/cordova-plugin-media/pull/166 .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Media Plugin: Saves file not in indicated directory
> ---
>
> Key: CB-12849
> URL: https://issues.apache.org/jira/browse/CB-12849
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-plugin-media
>Affects Versions: 6.5.0
> Environment: Device model: Nexus 5X
>  Android version of device: 8.1.0
>  Platform version: 7.1.0
>  Cordova version: 8.0.0
>  Cordova plugin media version: 5.0.1
>Reporter: Florian Pechwitz
>Priority: Major
>  Labels: cordova-plugin-media
>
> I tried to build an application which records, stops the recording and then 
> plays the recorded audio.
> The recording works fine but if I try to play the recorded audio I get error 
> code 1. I found out that the recorded audio file was not in the directory but 
> in a totally different directory 
> (/storage/emulated/0/(tmprecording-1495618229386.3gp) with a different file 
> name (tmprecording-1495618229386.3gp) and a different media type (video/3gpp) 
> as indicated.
> I created a repo with a example application for this issue: 
> https://github.com/Durzan666/cordova-plugin-media-demo



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14027) cordova-plugin-statusbar default style isn't work in Huawei and 360 and some android phone

[JIRA]

[ 
https://issues.apache.org/jira/browse/CB-14027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519926#comment-16519926
 ] 

Gearóid M commented on CB-14027:


I think this is working as expected, though the behaviour is a little bit 
confusing. What you're seeing isn't technically an empty status bar, but a 
black status bar with black text.

The docs describe `styleDefault` as "Use the default statusbar (dark text, for 
light backgrounds)." So it actually only sets the text colour, and does not 
change the status bar's background colour. If you want a black status bar with 
light text (the Android "default"), you need to first set the colour manually, 
and then set the text to be light.

{code:javascript}
StatusBar.backgroundColorByHexString('#00');
StatusBar.styleLightContent();
{code}

> cordova-plugin-statusbar default style isn't work in Huawei and 360 and some 
> android phone
> --
>
> Key: CB-14027
> URL: https://issues.apache.org/jira/browse/CB-14027
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: 2.4.1
>Reporter: miao
>Priority: Major
> Attachments: image-2018-04-12-12-18-38-075.png, 
> image-2018-04-16-10-25-40-198.png
>
>
> I used the latest version of cordova-plugin-statusbar with the default style, 
> but the in HuaWei, 360 and some android phone, the status bar's information 
> disappeared, only the black background bar here.
> !image-2018-04-12-12-18-38-075.png|width=199,height=363!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13774) cordova-plugin-media broken recording and playback functionality

[Ken Naito (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519912#comment-16519912
 ] 

Ken Naito commented on CB-13774:


Thanks Mark.
I could reproduce this issue by using Android 4.4 / 5.0.

Indeed, the https://github.com/apache/cordova-plugin-media/pull/164 can resolve 
this issue.
However I think DEFAULT encoding/format is low quality and may not be played in 
iOS devices.

 I think it is better that the developer can choose Encoder and/or OutputFormat 
by his own settings.


> cordova-plugin-media broken recording and playback functionality 
> -
>
> Key: CB-13774
> URL: https://issues.apache.org/jira/browse/CB-13774
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-media
> Environment: Android
>Reporter: Mark Mitchell
>Priority: Blocker
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The problem seems to be that somehow the encoder and decoder are set to 
> different encoding types and are not compatible. Additionally its assuming an 
> encoder is available on the platform and since the interface to the this 
> object does not allow a way to specifying encoding I feel like the default 
> may have been more appropriate. 
> Currently the code is as follows 
> {code:java}
> this.recorder.setOutputFormat(MediaRecorder.OutputFormat.AAC_ADTS); // 
> RAW_AMR);
> this.recorder.setAudioEncoder(MediaRecorder.AudioEncoder.AAC); //AMR_NB);
> {code}
> But trying to play back the recorded audio fails with a decoder error



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14107) StatusBar Plugin does not work correctly on Samsung S9

[JIRA]

[ 
https://issues.apache.org/jira/browse/CB-14107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519906#comment-16519906
 ] 

Gearóid M commented on CB-14107:


[~brian.g.gri...@gmail.com] The `meta-data` tag needs to be inside an 
`application` tag for it to work according to the docs. Try that and see if it 
works.

> StatusBar Plugin does not work correctly on Samsung S9
> --
>
> Key: CB-14107
> URL: https://issues.apache.org/jira/browse/CB-14107
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-plugin-statusbar
>Affects Versions: 8.0.0
>Reporter: Brian Grieco
>Assignee: Joe Bowser
>Priority: Major
>  Labels: features, plug-in, plugin
> Attachments: pic1.png, pic2.jpg, pic3.jpg
>
>
> I have a cordova project and I installed the StatusBar plugin to color the 
> status bar of the device in the Android platform. The plugin displays the 
> correct status bar color if I run the project on an AVD (pic1), but when I 
> run it on the device it does not appear to work.
> I also noticed that when I run the project on device with the plug in 
> uninstalled the view takes up the entire screen, but if I run it with the 
> plugin installed there is black space between the app view and the top and 
> bottom of the phone's nav bar and status bar (pic2).
> Update:
> When turned to portrait mode, the coloured status bar appears, but 
> incorrectly (pic3).
> Device: Samsung S9 running Android 8.0.0 (Oreo)
>  Cordova version: 8.0.0
>  StatusBar plugin version: 2.4.2
>  Cordova whitelist plugin: 1.3.3
>  
> Index.js code:
> {code:java}
> var app = {
> initialize: function() { 
> document.addEventListener('deviceready', 
> this.onDeviceReady.bind(this), false); 
> },
> onDeviceReady: function() { 
> this.receivedEvent('deviceready'); 
> StatusBar.backgroundColorByHexString("#CF4D4D"); 
> },
> receivedEvent: function(id) { } 
> }; 
> app.initialize();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14159) Use native Promises instead of Q in cordova-lib

[Raphael (JIRA)]

Raphael created CB-14159:


 Summary: Use native Promises instead of Q in cordova-lib
 Key: CB-14159
 URL: https://issues.apache.org/jira/browse/CB-14159
 Project: Apache Cordova
  Issue Type: Sub-task
  Components: cordova-lib
Reporter: Raphael






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-14158) Use native Promises instead of Q

[Raphael (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raphael reassigned CB-14158:


Assignee: Raphael

> Use native Promises instead of Q
> 
>
> Key: CB-14158
> URL: https://issues.apache.org/jira/browse/CB-14158
> Project: Apache Cordova
>  Issue Type: Task
>Reporter: Raphael
>Assignee: Raphael
>Priority: Minor
>
> For fun and profit.
> (to be expanded)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14158) Use native Promises instead of Q

[Raphael (JIRA)]

Raphael created CB-14158:


 Summary: Use native Promises instead of Q
 Key: CB-14158
 URL: https://issues.apache.org/jira/browse/CB-14158
 Project: Apache Cordova
  Issue Type: Task
Reporter: Raphael


For fun and profit.

(to be expanded)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-14157) cordova-js update devDependencies in package.json

[Chris Brody (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Brody reassigned CB-14157:


Assignee: Chris Brody

> cordova-js update devDependencies in package.json
> -
>
> Key: CB-14157
> URL: https://issues.apache.org/jira/browse/CB-14157
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-js
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Minor
>
> {{npm outdated}} shows some eslint {{devDependencies}} items that are out of 
> date (along with {{browserify}} item which is covered by CB-14156, outside 
> the scope of this issue):
> {code}
> Package Current  Wanted  Latest  Location
> browserify   14.4.0  14.4.0  16.2.2  cordova-js
> eslint-config-semistandard   11.0.0  11.0.0  12.0.1  cordova-js
> eslint-config-standard   10.2.1  10.2.1  11.0.0  cordova-js
> eslint-plugin-node5.2.1   5.2.1   6.0.1  cordova-js
> {code}
> {{npm check}} shows how to update the dependencies (extra messages such as 
> cordova & system package missing messages omitted here):
> {code}
> browserify   😎  MAJOR UP  Major update available. 
> https://github.com/browserify/browserify#readme
>   npm install --save 
> browserify@16.2.2 to go from 14.4.0 to 16.2.2
> eslint-config-semistandard   😎  MAJOR UP  Major update available. 
> https://github.com/Flet/eslint-config-semistandard
>   npm install --save-dev 
> eslint-config-semistandard@12.0.1 to go from 11.0.0 to 12.0.1
> eslint-config-standard   😎  MAJOR UP  Major update available. 
> https://github.com/standard/eslint-config-standard
>   npm install --save-dev 
> eslint-config-standard@11.0.0 to go from 10.2.1 to 11.0.0
> eslint-plugin-node   😎  MAJOR UP  Major update available. 
> https://github.com/mysticatea/eslint-plugin-node#readme
>   npm install --save-dev 
> eslint-plugin-node@6.0.1 to go from 5.2.1 to 6.0.1
> {code}
> {{npm-check}} can even do the updates automatically (in interactive or 
> non-interactive mode).
> Should be straightforward to resolve. As stated above the issue with 
> {{browserify}} is already covered by CB-14156, to be outside the scope of 
> this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14157) cordova-js update devDependencies in package.json

[Chris Brody (JIRA)]

Chris Brody created CB-14157:


 Summary: cordova-js update devDependencies in package.json
 Key: CB-14157
 URL: https://issues.apache.org/jira/browse/CB-14157
 Project: Apache Cordova
  Issue Type: Task
  Components: cordova-js
Reporter: Chris Brody


{{npm outdated}} shows some eslint {{devDependencies}} items that are out of 
date (along with {{browserify}} item which is covered by CB-14156, outside the 
scope of this issue):

{code}
Package Current  Wanted  Latest  Location
browserify   14.4.0  14.4.0  16.2.2  cordova-js
eslint-config-semistandard   11.0.0  11.0.0  12.0.1  cordova-js
eslint-config-standard   10.2.1  10.2.1  11.0.0  cordova-js
eslint-plugin-node5.2.1   5.2.1   6.0.1  cordova-js
{code}

{{npm check}} shows how to update the dependencies (extra messages such as 
cordova & system package missing messages omitted here):

{code}
browserify   😎  MAJOR UP  Major update available. 
https://github.com/browserify/browserify#readme
  npm install --save browserify@16.2.2 
to go from 14.4.0 to 16.2.2

eslint-config-semistandard   😎  MAJOR UP  Major update available. 
https://github.com/Flet/eslint-config-semistandard
  npm install --save-dev 
eslint-config-semistandard@12.0.1 to go from 11.0.0 to 12.0.1

eslint-config-standard   😎  MAJOR UP  Major update available. 
https://github.com/standard/eslint-config-standard
  npm install --save-dev 
eslint-config-standard@11.0.0 to go from 10.2.1 to 11.0.0

eslint-plugin-node   😎  MAJOR UP  Major update available. 
https://github.com/mysticatea/eslint-plugin-node#readme
  npm install --save-dev 
eslint-plugin-node@6.0.1 to go from 5.2.1 to 6.0.1
{code}

{{npm-check}} can even do the updates automatically (in interactive or 
non-interactive mode).

Should be straightforward to resolve. As stated above the issue with 
{{browserify}} is already covered by CB-14156, to be outside the scope of this 
issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14156) cordova-js browserify issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519705#comment-16519705
 ] 

ASF GitHub Bot commented on CB-14156:
-

brodybits commented on issue #162: [CB-14156 WIP] Remove browserify - WIP NOT 
TESTED
URL: https://github.com/apache/cordova-js/pull/162#issuecomment-399216641
 
 
   I just raised [CB-14156](https://issues.apache.org/jira/browse/CB-14156) to 
report the problems with `browserify` in general, marking this as the easiest 
alternative solution.
   
   > Why?
   
   Problems now listed in CB-14156, biggest concern is with duplicated code.
   
   > Do you know the reason why this was there and what it was used for in the 
first place?
   
   Using `grunt` and `browserify` was more popular 3-4 years ago. Considering 
it doesn't work for me I suspect the `browserify` target has not been used for 
quite a while.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-js browserify issues
> 
>
> Key: CB-14156
> URL: https://issues.apache.org/jira/browse/CB-14156
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-js
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> I spotted the following issues with the way {{cordova-js}} uses 
> {{browserify}}:
> * 1: duplicate source files in {{src}}: {{src/cordova_b.js}}, 
> {{src/common/modulemapper_b.js}},
>  {{src/common/pluginloader_b.js}}, {{src/common/init_b.js}}, which only seem 
> to be used by {{tasks/lib/bundle-browserify.js}}
> * 2: I have not been able to make a working {{browserify}} build.
> * 3: {{npm outdated}} shows {{browserify}} as outdated
> Another possible issue that I am not 100% sure about:
> * 4: {{browserify}} is listed as a {{dependencies}} item in {{package.json}} 
> while I think it should have been listed as a {{devDependencies}} item
> I am very concerned that keeping duplicated source files may lead to old bugs 
> including possible security issues leaking through the maintenance process in 
> the future. The changes between the duplicated source files and the 
> non-browserify versions are very limited so it should be possible to resolve 
> this issue using very basic code techniques.
> I think the easiest solution would be to drop the browserify build/test 
> target and remove the duplicated source files. I suspect that the browserify 
> target has not been used for years.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14156) cordova-js browserify issues

[Chris Brody (JIRA)]

Chris Brody created CB-14156:


 Summary: cordova-js browserify issues
 Key: CB-14156
 URL: https://issues.apache.org/jira/browse/CB-14156
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-js
Reporter: Chris Brody
Assignee: Chris Brody


I spotted the following issues with the way {{cordova-js}} uses {{browserify}}:
* 1: duplicate source files in {{src}}: {{src/cordova_b.js}}, 
{{src/common/modulemapper_b.js}},
 {{src/common/pluginloader_b.js}}, {{src/common/init_b.js}}, which only seem to 
be used by {{tasks/lib/bundle-browserify.js}}
* 2: I have not been able to make a working {{browserify}} build.
* 3: {{npm outdated}} shows {{browserify}} as outdated

Another possible issue that I am not 100% sure about:
* 4: {{browserify}} is listed as a {{dependencies}} item in {{package.json}} 
while I think it should have been listed as a {{devDependencies}} item

I am very concerned that keeping duplicated source files may lead to old bugs 
including possible security issues leaking through the maintenance process in 
the future. The changes between the duplicated source files and the 
non-browserify versions are very limited so it should be possible to resolve 
this issue using very basic code techniques.

I think the easiest solution would be to drop the browserify build/test target 
and remove the duplicated source files. I suspect that the browserify target 
has not been used for years.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-14145) Resolve npm audit issues

[Chris Brody (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Brody updated CB-14145:
-
Component/s: cordova-plugman

> Resolve npm audit issues
> 
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-app-hello-world, 
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, 
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-plugman, 
> cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number 
> of components would report dependencies with security issues. While we could 
> not see any {{npm audit}} issues that may affect applications built using 
> Cordova I think it is extremely important to resolve these issues as soon as 
> possible. Most affect devDependencies used for testing of Cordova itself; a 
> minority seem to affect Cordova scripts that may be run by Cordova 
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, 
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova 
> platform implementations, major plugins, etc. (expected to be fixed in minor 
> release branch; do not want to pollute the master branch with extra reverts, 
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, 
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-14155) Fix & export cordova-js btest script

[Chris Brody (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Brody resolved CB-14155.
--
Resolution: Fixed

> Fix & export cordova-js btest script
> 
>
> Key: CB-14155
> URL: https://issues.apache.org/jira/browse/CB-14155
> Project: Apache Cordova
>  Issue Type: Test
>  Components: cordova-js
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> The {{grunt btest}} task (which means "run tests in the browser" ref: 
> [tasks/test.js#L32-L35|https://github.com/apache/cordova-js/blob/master/tasks/test.js#L32-L35])
>  did not seem to work on my machine for some reason. I am raising this issue 
> to fix and export this task.
> As I general principle I would rather fix and revive existing test targets if 
> possible (and practical).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14155) Fix & export cordova-js btest script

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519526#comment-16519526
 ] 

ASF GitHub Bot commented on CB-14155:
-

brodybits closed pull request #164: CB-14155 fix btest part 2: export npm script
URL: https://github.com/apache/cordova-js/pull/164
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/package.json b/package.json
index 3f986a9f..67b2dde6 100644
--- a/package.json
+++ b/package.json
@@ -17,6 +17,7 @@
   "scripts": {
 "eslint": "eslint src test pkg",
 "test": "grunt test && npm run eslint",
+"btest": "grunt btest && npm run eslint",
 "build": "grunt compile",
 "build-browserify": "grunt compile-browserify"
   },


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix & export cordova-js btest script
> 
>
> Key: CB-14155
> URL: https://issues.apache.org/jira/browse/CB-14155
> Project: Apache Cordova
>  Issue Type: Test
>  Components: cordova-js
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> The {{grunt btest}} task (which means "run tests in the browser" ref: 
> [tasks/test.js#L32-L35|https://github.com/apache/cordova-js/blob/master/tasks/test.js#L32-L35])
>  did not seem to work on my machine for some reason. I am raising this issue 
> to fix and export this task.
> As I general principle I would rather fix and revive existing test targets if 
> possible (and practical).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14155) Fix & export cordova-js btest script

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519476#comment-16519476
 ] 

ASF GitHub Bot commented on CB-14155:
-

brodybits opened a new pull request #164: CB-14155 fix btest part 2: export npm 
script
URL: https://github.com/apache/cordova-js/pull/164
 
 
   
   
   ### Platforms affected
   
   All
   
   ### What does this PR do?
   
   Followup to btest fix in PR #160: export npm script in package.json
   
   ### What testing has been done on this change?
   
   `npm run btest` works as intended
   
   ### Checklist
   
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - ~~Added automated test coverage as appropriate for this change.~~


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix & export cordova-js btest script
> 
>
> Key: CB-14155
> URL: https://issues.apache.org/jira/browse/CB-14155
> Project: Apache Cordova
>  Issue Type: Test
>  Components: cordova-js
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> The {{grunt btest}} task (which means "run tests in the browser" ref: 
> [tasks/test.js#L32-L35|https://github.com/apache/cordova-js/blob/master/tasks/test.js#L32-L35])
>  did not seem to work on my machine for some reason. I am raising this issue 
> to fix and export this task.
> As I general principle I would rather fix and revive existing test targets if 
> possible (and practical).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14155) Fix & export cordova-js btest script

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519465#comment-16519465
 ] 

ASF GitHub Bot commented on CB-14155:
-

brodybits commented on issue #160: CB-14155: Fix btest by using express 
(instead of connect, etc.)
URL: https://github.com/apache/cordova-js/pull/160#issuecomment-399135610
 
 
   Just raised Apache CB-14155 
() to track these changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix & export cordova-js btest script
> 
>
> Key: CB-14155
> URL: https://issues.apache.org/jira/browse/CB-14155
> Project: Apache Cordova
>  Issue Type: Test
>  Components: cordova-js
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> The {{grunt btest}} task (which means "run tests in the browser" ref: 
> [tasks/test.js#L32-L35|https://github.com/apache/cordova-js/blob/master/tasks/test.js#L32-L35])
>  did not seem to work on my machine for some reason. I am raising this issue 
> to fix and export this task.
> As I general principle I would rather fix and revive existing test targets if 
> possible (and practical).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-14152) cordova-js tools patch release Jun 21, 2018

[Chris Brody (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Brody updated CB-14152:
-
Summary: cordova-js tools patch release Jun 21, 2018  (was: cordova-js 
tools patch release Jun 20, 2018)

> cordova-js tools patch release Jun 21, 2018
> ---
>
> Key: CB-14152
> URL: https://issues.apache.org/jira/browse/CB-14152
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-js
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> Following steps at 
> [https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md]
>  (with some adaptations)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14155) Fix & export cordova-js btest script

[Chris Brody (JIRA)]

Chris Brody created CB-14155:


 Summary: Fix & export cordova-js btest script
 Key: CB-14155
 URL: https://issues.apache.org/jira/browse/CB-14155
 Project: Apache Cordova
  Issue Type: Test
  Components: cordova-js
Reporter: Chris Brody
Assignee: Chris Brody


The {{grunt btest}} task (which means "run tests in the browser" ref: 
[tasks/test.js#L32-L35|https://github.com/apache/cordova-js/blob/master/tasks/test.js#L32-L35])
 did not seem to work on my machine for some reason. I am raising this issue to 
fix and export this task.

As I general principle I would rather fix and revive existing test targets if 
possible (and practical).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14038) cordova-android false positive detecting project type

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519461#comment-16519461
 ] 

ASF GitHub Bot commented on CB-14038:
-

raphinesse commented on issue #437: CB-14038 (android): fix false positive 
detecting project type
URL: https://github.com/apache/cordova-android/pull/437#issuecomment-399133263
 
 
   Thanks for your answer.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-android false positive detecting project type
> -
>
> Key: CB-14038
> URL: https://issues.apache.org/jira/browse/CB-14038
> Project: Apache Cordova
>  Issue Type: Bug
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>
> It sometimes thinks the project has Eclipse format, but all the projects are 
> Android Studio projects now



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-14154) Expose gradle configuration properties in config.xml to assist aligning Google Play Services / Firebase

[Christopher Scott (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher Scott updated CB-14154:
---
Description: 
I am a full-time plugin developer.  Like many other plugins, I import Google 
Play Services dependencies in addition to Android Support libraries 
(appcompat-v7).

By far the biggest problem I encounter with my users is [Gradle 
conflicts|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues?utf8=%E2%9C%93&q=android+build+error]
 due to multiple plugins importing different versions of 
{color:#33}play-services / Firebase / com.android.support{color} libraries.

Many plugin authors do the wrong thing and simply use version ":+", eg: 
[cordova-plugin-firebase|https://github.com/arnesson/cordova-plugin-firebase/blob/master/plugin.xml#L61-L67]].

Quite often, my solution for these users is to [edit 
platforms/android/project.properties|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues/699#issuecomment-396083457]*_,_*
 which is not the best long-term solution, since this file is _volatile_.

What I've been doing since cordova@7.1.0 is [expose custom config properties in 
my plugins' 
plugin.xml|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L98-L101].
  This is nice, but users must align their google-play / Firebase / Support 
dependencies [for each plugin that exposes 
these|https://github.com/transistorsoft/cordova-background-geolocation-lt#configuring-play-services-version]
 helpful properties (and not many plugins do).

 

What would *_really_* help, is if cordova-android could expose variables in the 
app's config.xml in the same manner as:
 * cdvCompileSdkVersion
 * cdvBuildToolsVersion
 * cdvMinSdkVersion

I would like to see the following properties added:
 * cdvGooglePlayServicesVersion
 * cdvSupportLibVersion

(Note:  cdvGooglePlayServicesVersion could be named cdvGoogleApiVersion as a 
more common name, since both Firebase and Google Play Services dependencies 
must be aligned to the same version.)

I would like to be able to access these properties in my plugin's [plugin.xml 
here|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L99]]
 instead of using my plugin's custom $GOOGLE_API_VERSION variable.

In a React Native app, which provides direct control over one's top-level 
build.gradle, we do it [like 
this|https://github.com/transistorsoft/rn-background-geolocation-demo/blob/master/android/build.gradle#L33-L38]].
  3rd-party plugins then check for the existence of these Gradle Config 
Properties when importing their Google dependencies, [like 
this|https://github.com/transistorsoft/react-native-background-geolocation/blob/master/android/build.gradle#L33].

This technique is also recommend at android.developer.com in the document 
[Gradle Tips and Tricks|https://developer.android.com/studio/build/gradle-tips] 
(search "project-wide properties")

 

  was:
I am a full-time plugin developer.  Like many other plugins, I import Google 
Play Services dependencies in addition to Android Support libraries 
(appcompat-v7).

By far the biggest problem I encounter with my users is [Gradle 
conflicts|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues?utf8=%E2%9C%93&q=android+build+error]
 due to multiple plugins importing different versions of 
{color:#33}play-services / Firebase / com.android.support{color} libraries.

Many plugin authors do the wrong thing and simply use version ":+", eg: 
[cordova-plugin-firebase|https://github.com/arnesson/cordova-plugin-firebase/blob/master/plugin.xml#L61-L67]].

Quite often, my solution for these users is to [edit 
platforms/android/project.properties|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues/699#issuecomment-396083457]*_,_*
 which is not the best long-term solution, since this file is _volatile_.

What I've been doing since cordova@7.1.0 is [expose custom config properties in 
my plugins' 
plugin.xml|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L98-L101].
  This is nice, but users must align their google-play / Firebase / Support 
dependencies [for each plugin that exposes 
these|https://github.com/transistorsoft/cordova-background-geolocation-lt#configuring-play-services-version]
 helpful properties (and not many plugins do).

 

What would *_really_* help, is if cordova-android could expose variables in the 
app's config.xml in the same manner as:
 * cdvCompileSdkVersion
 * cdvBuildToolsVersion
 * cdvMinSdkVersion

I would like to see the following properties added:
 * cdvGooglePlayServicesVersion
 * cdvSupportLibVersion

(Note:  cdvGooglePlayServicesVersion could be named cdvGoogleApiVersion as a 
more common name, since both Firebase and Google Play Services dependencies 
must be aligned to the same version.)

I 

[jira] [Created] (CB-14154) Expose gradle configuration properties in config.xml to assist aligning Google Play Services / Firebase

[Christopher Scott (JIRA)]

Christopher Scott created CB-14154:
--

 Summary: Expose gradle configuration properties in config.xml to 
assist aligning Google Play Services / Firebase
 Key: CB-14154
 URL: https://issues.apache.org/jira/browse/CB-14154
 Project: Apache Cordova
  Issue Type: Improvement
  Components: cordova-android
Affects Versions: cordova-android-7.0.0
Reporter: Christopher Scott
Assignee: Joe Bowser


I am a full-time plugin developer.  Like many other plugins, I import Google 
Play Services dependencies in addition to Android Support libraries 
(appcompat-v7).

By far the biggest problem I encounter with my users is [Gradle 
conflicts|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues?utf8=%E2%9C%93&q=android+build+error]
 due to multiple plugins importing different versions of 
{color:#33}play-services / Firebase / com.android.support{color} libraries.

Many plugin authors do the wrong thing and simply use version ":+", eg: 
[cordova-plugin-firebase|https://github.com/arnesson/cordova-plugin-firebase/blob/master/plugin.xml#L61-L67]].

Quite often, my solution for these users is to [edit 
platforms/android/project.properties|https://github.com/transistorsoft/cordova-background-geolocation-lt/issues/699#issuecomment-396083457]*_,_*
 which is not the best long-term solution, since this file is _volatile_.

What I've been doing since cordova@7.1.0 is [expose custom config properties in 
my plugins' 
plugin.xml|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L98-L101].
  This is nice, but users must align their google-play / Firebase / Support 
dependencies [for each plugin that exposes 
these|https://github.com/transistorsoft/cordova-background-geolocation-lt#configuring-play-services-version]
 helpful properties (and not many plugins do).

 

What would *_really_* help, is if cordova-android could expose variables in the 
app's config.xml in the same manner as:
 * cdvCompileSdkVersion
 * cdvBuildToolsVersion
 * cdvMinSdkVersion

I would like to see the following properties added:
 * cdvGooglePlayServicesVersion
 * cdvSupportLibVersion

(Note:  cdvGooglePlayServicesVersion could be named cdvGoogleApiVersion as a 
more common name, since both Firebase and Google Play Services dependencies 
must be aligned to the same version.)

I would like to be able to access these properties in my plugin's [plugin.xml 
here|https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/plugin.xml#L99]]
 instead of using my plugin's custom $GOOGLE_API_VERSION variable.

In a React Native app, which provides direct control over one's top-level 
build.gradle, we do it [like 
this|https://github.com/transistorsoft/rn-background-geolocation-demo/blob/master/android/build.gradle#L33-L38]].
  3rd-party plugins then check for the existence of these Gradle Config 
Properties when importing their Google dependencies, [like 
this|https://github.com/transistorsoft/react-native-background-geolocation/blob/master/android/build.gradle#L33].

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14103) Audio not playing when play() called from push notification on ios devices with closed app

[Ken Naito (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519265#comment-16519265
 ] 

Ken Naito commented on CB-14103:


Where is mp3 file?
My mp3 file is www/res/jazz.mp3.
It looks like working.

I use 'silent' push.  i.e. 'content-available=1'.
The active (foreground) application plays mp3 when receiving the push 
notification.
Even if the device is locked, the application plays mp3 when receiving the push 
notification.

My environment is
{code}
Installed platforms:
  ios 4.5.4
cordova-plugin-background-mode 0.7.2 "BackgroundMode"
cordova-plugin-device 2.0.2 "Device"
cordova-plugin-file 6.0.1 "File"
cordova-plugin-media 5.0.2 "Media"
cordova-plugin-whitelist 1.3.3 "Whitelist"
phonegap-plugin-push 2.2.3 "PushPlugin"
{code}
My node version is 9.5.0.
iOS version is 11.4.

The part of my codes is
{code}
push.on('notification', (data) => {
var additionalData = data["additionalData"];
playAudio();
...
};

var media = null;

function playAudio () {
  if (media != null) {
alert("Busy !");
return;
  }
  var successCallback = function () { console.log("success"); alert('success'); 
};
  var failureCallback = function () { console.log("failure"); alert('failure'); 
};
  var statusChange = function (statusCode) {
if (statusCode == Media.MEDIA_STOPPED) {
  media.release();
  media = null;
}
  };
  var mediaFile = "res/jazz_funk_01.mp3";
  media = new Media(mediaFile, successCallback, failureCallback, statusChange);
  media.play();
}

function stopAudio () {
  if (media != null) {
media.stop();
  }
}
{code}


> Audio not playing when play() called from push notification on ios devices 
> with closed app
> --
>
> Key: CB-14103
> URL: https://issues.apache.org/jira/browse/CB-14103
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-media
>Affects Versions: cordova-ios@4.5.4
> Environment: cli packages: 
> (/Users/eugene/.npm-global/lib/node_modules)
>  
>     @ionic/cli-utils  : 1.19.2
>     ionic (Ionic CLI) : 3.20.0
>  
> global packages:
>  
>     cordova (Cordova CLI) : 8.0.0 
>  
> local packages:
>  
>     @ionic/app-scripts : 3.1.8
>     Cordova Platforms  : ios 4.5.4
>     Ionic Framework    : ionic-angular 3.9.2
>  
> System:
>  
>     Android SDK Tools : 26.1.1
>     ios-deploy        : 1.9.2 
>     Node              : v9.6.1
>     npm               : 5.8.0 
>     OS                : macOS High Sierra
>     Xcode             : Xcode 9.3 Build version 9E145 
>  
> Environment Variables:
>  
>     ANDROID_HOME : /Users/eugene/Library/Android/sdk
>Reporter: Eugene Snihovsky
>Priority: Major
>
> # When I call `media.play()` manually from app - audio play works.
>  # When I call `media.play()` from push notification (app is in background) - 
> audio play works.
>  # When I call `media.play()` from push notification (app is not in 
> background and device is not locked) - audio play not works and I receive 
> data in error callback `\{"message":"","code":4}` (see it in Xcode device 
> logs)
>  # When I call `media.play()` from push notification (app is not in 
> background and device is locked) - audio play not works and I receive data in 
> error callback `\{"message":"","code":4}` (see it in Xcode device logs)
> I use real device iPad with ios 10.3.3
>  
> cordova-plugin-media 5.0.2 with KEEP_AVAUDIOSESSION_ALWAYS_ACTIVE = true
>  
> phonegap-plugin-push 2.2.2
>  
> cordova-plugin-background-mode from master (also try to enable background on 
> push notification receive before start audio)
>  
> Is there any chance to make it work?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14145) Resolve npm audit issues

[Jan Piotrowski (Sujan) (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519226#comment-16519226
 ] 

Jan Piotrowski (Sujan) commented on CB-14145:
-

Why is `npm audit` an important thing to consider all of a sudden? Is this a 
new thing?

> Resolve npm audit issues
> 
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-app-hello-world, 
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, 
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number 
> of components would report dependencies with security issues. While we could 
> not see any {{npm audit}} issues that may affect applications built using 
> Cordova I think it is extremely important to resolve these issues as soon as 
> possible. Most affect devDependencies used for testing of Cordova itself; a 
> minority seem to affect Cordova scripts that may be run by Cordova 
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, 
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova 
> platform implementations, major plugins, etc. (expected to be fixed in minor 
> release branch; do not want to pollute the master branch with extra reverts, 
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, 
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14038) cordova-android false positive detecting project type

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519221#comment-16519221
 ] 

ASF GitHub Bot commented on CB-14038:
-

jcesarmobile commented on issue #437: CB-14038 (android): fix false positive 
detecting project type
URL: https://github.com/apache/cordova-android/pull/437#issuecomment-399060126
 
 
   No, there is no work about it because the idea was to do a patch or minor 
release with this changes to unblock people with plugin problems, and the 
refactor was supposed to be done for next major release. But right now it's not 
clear to me if we are going to do a patch, minor or major release.
   
   Anyway, the refactor is not a breaking change, so it can be done at any time.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-android false positive detecting project type
> -
>
> Key: CB-14038
> URL: https://issues.apache.org/jira/browse/CB-14038
> Project: Apache Cordova
>  Issue Type: Bug
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>
> It sometimes thinks the project has Eclipse format, but all the projects are 
> Android Studio projects now



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14038) cordova-android false positive detecting project type

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519220#comment-16519220
 ] 

ASF GitHub Bot commented on CB-14038:
-

raphinesse commented on issue #437: CB-14038 (android): fix false positive 
detecting project type
URL: https://github.com/apache/cordova-android/pull/437#issuecomment-399058403
 
 
   @jcesarmobile Is there any WIP for the aforementioned refactor? Losing some 
dead weight would definitely be good. Furthermore, before I discovered this PR 
by accident, I already thought about starting to DRY the two very similar 
Builders, not knowing that removal of one of them is due.
   
   BTW: GradleBuilder is used by the Java unit test runner. Just to create a 
Gradle wrapper, so the dependency could be easily removed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-android false positive detecting project type
> -
>
> Key: CB-14038
> URL: https://issues.apache.org/jira/browse/CB-14038
> Project: Apache Cordova
>  Issue Type: Bug
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>
> It sometimes thinks the project has Eclipse format, but all the projects are 
> Android Studio projects now



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14145) Resolve npm audit issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519210#comment-16519210
 ] 

ASF GitHub Bot commented on CB-14145:
-

raphinesse commented on issue #451: CB-14145: update to cordova-common@2.2.4 to 
resolve npm audit & other issues in patch release
URL: https://github.com/apache/cordova-android/pull/451#issuecomment-399056204
 
 
   I'd be happy to see these fixes in the upcoming release. I don't see why 
these changes should break anything. If things break, we'll fix them. I think 
you need to worry a bit less :blush: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Resolve npm audit issues
> 
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android, cordova-app-hello-world, 
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, 
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number 
> of components would report dependencies with security issues. While we could 
> not see any {{npm audit}} issues that may affect applications built using 
> Cordova I think it is extremely important to resolve these issues as soon as 
> possible. Most affect devDependencies used for testing of Cordova itself; a 
> minority seem to affect Cordova scripts that may be run by Cordova 
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}}, 
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova 
> platform implementations, major plugins, etc. (expected to be fixed in minor 
> release branch; do not want to pollute the master branch with extra reverts, 
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release, 
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14153) overwrite mode for edit-config in plist-helper.js

[Uday Kiran (JIRA)]

Uday Kiran created CB-14153:
---

 Summary: overwrite mode for edit-config in plist-helper.js
 Key: CB-14153
 URL: https://issues.apache.org/jira/browse/CB-14153
 Project: Apache Cordova
  Issue Type: Improvement
  Components: cordova-cli, cordova-common
Affects Versions: cordova-common@2.2.3
Reporter: Uday Kiran


overwrite mode for *-Info.plist, as part of edit-config configuration, is not 
implemented in plist-helper.js file. 

I want to override certain elments in the plist file. I added edit-config for 
the element. Instead of overriding it is merging the children.

I am using cordova@8.0

I have given a temporary fix in my local system.

 
function graftPLIST (doc, xml, selector, mode) {
varobj=plist.parse(''+xml+'');
{code:java}
varnode=doc[selector];
if (node&&Array.isArray(node) &&Array.isArray(obj)) {
//temporary fix
  (mode == 'overwrite') ? (node = obj) : (node = node.concat(obj));
for (vari=0; i. If we have two dicts we merge them instead of
// overriding the old one. See CB-6472
if (node&&__.isObject(node) &&__.isObject(obj) &&!__.isDate(node) 
&&!__.isDate(obj)) { // arrays checked above
__.extend(obj, node);
}
doc[selector] =obj;
}

returntrue;
}
Thanks{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14151) Device Camera is not opening in samsung j7

[Sandip Gadekar (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519170#comment-16519170
 ] 

Sandip Gadekar commented on CB-14151:
-

No error in console..

> Device Camera is not opening in samsung j7
> --
>
> Key: CB-14151
> URL: https://issues.apache.org/jira/browse/CB-14151
> Project: Apache Cordova
>  Issue Type: Bug
>Reporter: Sandip Gadekar
>Priority: Major
>
> I am using
> [https://ionicframework.com/docs/native/media-capture/] 
> this plugin to select images from device camera and gallery.
> but camera seems not working when I do
> this.mediaCapture.captureImage(imagesOptions).then((media: MediaFile[]) => {
> }), and application gets crashed
>  
> It seems device specific since it is working on other device but not in 
> samsung j7 since it has duel camera sensors



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14151) Device Camera is not opening in samsung j7

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519137#comment-16519137
 ] 

jcesarmobile commented on CB-14151:
---

If you open logcat, do you see some exception or error?

> Device Camera is not opening in samsung j7
> --
>
> Key: CB-14151
> URL: https://issues.apache.org/jira/browse/CB-14151
> Project: Apache Cordova
>  Issue Type: Bug
>Reporter: Sandip Gadekar
>Priority: Major
>
> I am using
> [https://ionicframework.com/docs/native/media-capture/] 
> this plugin to select images from device camera and gallery.
> but camera seems not working when I do
> this.mediaCapture.captureImage(imagesOptions).then((media: MediaFile[]) => {
> }), and application gets crashed
>  
> It seems device specific since it is working on other device but not in 
> samsung j7 since it has duel camera sensors



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14144) BackButton Event Listeners do not fire on Android API 23 or below

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519134#comment-16519134
 ] 

jcesarmobile commented on CB-14144:
---

I know you don't want to mislead me, but when I ask for a sample project, I 
expect a sample project where I can reproduce the bug. 
I wasted a lot of time installing all your required dependencies and trying to 
see what's going on and I found the problem in Quasar, and turns out you 
already knew about it and didn't mention it.

I've commented navigator.app.exitApp(); on quasar.mat.esm.js (line 315 in my 
case) and the app no longer exits.

So I'm sorry but I can't help you anymore, I sent you a regular Cordova project 
where you saw that you couldn't reproduce, and you sent me a sample project 
where I could reproduce until I removed the navigator.app.exitApp();.
If by removing it you still face the problem, then it must be another thing in 
your project, but you'll have to figure out yourself.

> BackButton Event Listeners do not fire on Android API 23 or below
> -
>
> Key: CB-14144
> URL: https://issues.apache.org/jira/browse/CB-14144
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Using Android Studio emulators Galaxy, Pixel, Nexus 5... 
> all exhibit this behaviour. 
> Quasar Framework is building my project a long with webpack but I've no 
> reason to suspect Quasar as the cause, they only register a single 
> eventListener for backbutton and I've manually gone in and edited the source 
> code for this listener and it never fires leading me to believe the problem 
> is with Cordova.
>Reporter: altShiftDev
>Assignee: Joe Bowser
>Priority: Major
>
> App exits immediately on back button press without ever firing the 
> eventListener designed to capture and reroute it.
> There is nothing wrong with my eventListener code, it's been tested on Api 25 
> and higher and is very stable:
> `document.addEventListener('backbutton', this.onBackButton, false)`
> I have not yet tested to confirm if API 24 has this bug or not.
> This affects many of my users, including myself as I've got a phone running 
> Android at these versions. The app is completely killed with every tap of the 
> back button (new launches of the app cold boot with splashscreen) making it 
> impossible to properly navigate the app: closing modals, moving backwards in 
> operations, etc...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13685) Android Adaptive Icons

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519066#comment-16519066
 ] 

ASF GitHub Bot commented on CB-13685:
-

codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon 
Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=h1) 
Report
   > Merging 
[#448](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/559b0833b42402a2b0fba6d6369fbc713e1063c1?src=pr&el=desc)
 will **decrease** coverage by `3.79%`.
   > The diff coverage is `66.92%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/448/graphs/tree.svg?src=pr&width=650&height=150&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master #448 +/-   ##
   =
   - Coverage   47.63%   43.84%   -3.8% 
   =
 Files  17   18  +1 
 Lines1694 2023+329 
 Branches  311  383 +72 
   =
   + Hits  807  887 +80 
   - Misses887 1136+249
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=)
 | `35.44% <40%> (+0.3%)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz)
 | `41.66% <68%> (ø)` | |
   | 
[bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==)
 | `15.38% <0%> (-84.62%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=)
 | `26.98% <0%> (-73.02%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=footer).
 Last update 
[559b083...22bb844](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to 
> create app icons using a background and a foreground image file. This feature 
> is called "adaptive icons". One major change that goes with this feature is 
> that icons get now clipped into a shape by the system. This leads to a very 
> uniform and clean design like on iOS where all icons are a rounded rectangle. 
> The other advantage is that visual effects can be applied to the icon by the 
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon 
> resources because it creates backwards compatible icons for older devices 
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │   ├── ic_launcher_background.xml
> │   └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │   ├── ic_launcher.xml
> │   └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │   ├── ic_launcher.png
> │   └── ic_launcher_round.png
> ├── mipmap-mdpi
> │   ├── ic_launcher.

[jira] [Commented] (CB-13685) Android Adaptive Icons

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519065#comment-16519065
 ] 

ASF GitHub Bot commented on CB-13685:
-

codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon 
Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=h1) 
Report
   > Merging 
[#448](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/559b0833b42402a2b0fba6d6369fbc713e1063c1?src=pr&el=desc)
 will **decrease** coverage by `3.79%`.
   > The diff coverage is `66.92%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/448/graphs/tree.svg?height=150&src=pr&width=650&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master #448 +/-   ##
   =
   - Coverage   47.63%   43.84%   -3.8% 
   =
 Files  17   18  +1 
 Lines1694 2023+329 
 Branches  311  383 +72 
   =
   + Hits  807  887 +80 
   - Misses887 1136+249
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=)
 | `35.44% <40%> (+0.3%)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz)
 | `41.66% <68%> (ø)` | |
   | 
[bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==)
 | `15.38% <0%> (-84.62%)` | :arrow_down: |
   | 
[bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=)
 | `26.98% <0%> (-73.02%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=footer).
 Last update 
[559b083...22bb844](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to 
> create app icons using a background and a foreground image file. This feature 
> is called "adaptive icons". One major change that goes with this feature is 
> that icons get now clipped into a shape by the system. This leads to a very 
> uniform and clean design like on iOS where all icons are a rounded rectangle. 
> The other advantage is that visual effects can be applied to the icon by the 
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon 
> resources because it creates backwards compatible icons for older devices 
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │   ├── ic_launcher_background.xml
> │   └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │   ├── ic_launcher.xml
> │   └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │   ├── ic_launcher.png
> │   └── ic_launcher_round.png
> ├── mipmap-mdpi
> │   ├── ic_launcher.