[jira] [Commented] (CB-14263) Makes all of cordova plugins compatible with cordova-android 7
[
https://issues.apache.org/jira/browse/CB-14263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577060#comment-16577060
]
ASF GitHub Bot commented on CB-14263:
-
leo6104 commented on issue #35: CB-14263: (android) make cordova plugin
compatible with cordova-android 7
URL: https://github.com/apache/cordova-common/pull/35#issuecomment-412253281
After i remove `shell.cp('-f', locations.defaultConfigXml,
locations.configXml);` in restore-util.ts file,
it work.
### Working version
1. cordova 8.0
2. cordova-android https://github.com/apache/cordova-android
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Makes all of cordova plugins compatible with cordova-android 7
> --
>
> Key: CB-14263
> URL: https://issues.apache.org/jira/browse/CB-14263
> Project: Apache Cordova
> Issue Type: Improvement
> Components: AllPlugins, cordova-android, cordova-common
>Affects Versions: cordova-common@2.2.3
>Reporter: Heo
>Priority: Major
> Fix For: Master
>
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> Cordova common's ConfigParser supports alias such as config.xml,
> AndroidManifest.xml paths.
> [https://github.com/apache/cordova-common/blob/7bf9627f0135c6b3518292660b6e07e6f5815926/src/ConfigChanges/ConfigFile.js#L192]
> But In PluginInfo parser, there is no alias rules for compatibility.
> There is lots of cordova plugins still not upgrade to cordova-android 7
> syntax (plugin.xml)
> So i did some changes to cordova-common which will make cordova cli parsing
> some plugins which not support cordova-android 7 yet.
> [https://github.com/apache/cordova-cli/compare/master...leo6104:master]
> Here is my changes.
>
>
> I spent lots of times to fix this. I test it via my cutsom cordova-cli
> repository [https://github.com/leo6104/cordova-cli/] and i fix it in my
> cordova project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[ https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576999#comment-16576999 ] ASF GitHub Bot commented on CB-13685: - codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=h1) Report > Merging [#448](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/ebbd91f87dfb088fb69dfbeb300753bf7d19a194?src=pr=desc) will **decrease** coverage by `19.06%`. > The diff coverage is `66.92%`. [](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #448 +/- ## === - Coverage62.9% 43.84% -19.07% === Files 15 18+3 Lines1650 2023 +373 Branches 308 383 +75 === - Hits 1038 887 -151 - Misses612 1136 +524 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=) | `35.44% <40%> (-64.56%)` | :arrow_down: | | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `41.66% <68%> (ø)` | | | [bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==) | `15.38% <0%> (-84.62%)` | :arrow_down: | | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `22.44% <0%> (-77.56%)` | :arrow_down: | | [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `26.98% <0%> (-73.02%)` | :arrow_down: | | [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `34.14% <0%> (-65.86%)` | :arrow_down: | | [bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==) | `37.5% <0%> (-62.5%)` | :arrow_down: | | [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `48.64% <0%> (-40.97%)` | :arrow_down: | | [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | | | | ... and [6 more](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=footer). Last update [ebbd91f...821038e](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android Adaptive Icons > -- > > Key: CB-13685 > URL: https://issues.apache.org/jira/browse/CB-13685 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android > Environment: All >Reporter: Josef Brandl >Assignee: Joe Bowser >Priority:
[jira] [Commented] (CB-13685) Android Adaptive Icons
[ https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576998#comment-16576998 ] ASF GitHub Bot commented on CB-13685: - codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=h1) Report > Merging [#448](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/ebbd91f87dfb088fb69dfbeb300753bf7d19a194?src=pr=desc) will **decrease** coverage by `19.06%`. > The diff coverage is `66.92%`. [](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #448 +/- ## === - Coverage62.9% 43.84% -19.07% === Files 15 18+3 Lines1650 2023 +373 Branches 308 383 +75 === - Hits 1038 887 -151 - Misses612 1136 +524 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=) | `35.44% <40%> (-64.56%)` | :arrow_down: | | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `41.66% <68%> (ø)` | | | [bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==) | `15.38% <0%> (-84.62%)` | :arrow_down: | | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `22.44% <0%> (-77.56%)` | :arrow_down: | | [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `26.98% <0%> (-73.02%)` | :arrow_down: | | [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `34.14% <0%> (-65.86%)` | :arrow_down: | | [bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==) | `37.5% <0%> (-62.5%)` | :arrow_down: | | [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `48.64% <0%> (-40.97%)` | :arrow_down: | | [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | | | | ... and [6 more](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=footer). Last update [ebbd91f...821038e](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android Adaptive Icons > -- > > Key: CB-13685 > URL: https://issues.apache.org/jira/browse/CB-13685 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android > Environment: All >Reporter: Josef Brandl >Assignee: Joe Bowser >Priority:
[jira] [Commented] (CB-14234) InAppBrowser iOS calls handleOpenURL in same app for _system URLs
[ https://issues.apache.org/jira/browse/CB-14234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576940#comment-16576940 ] ASF GitHub Bot commented on CB-14234: - dpolivy opened a new pull request #278: CB-14234: (ios) Don't call handleOpenURL for system URLs URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/278 When calling `.open()` with a target of `_system`, the InAppBrowser on iOS is both launching the URL in the system browser AND also broadcasting to open the URL within the app (calling handleOpenURL). The latter behavior is problematic in many circumstances (e.g. when you want to explicitly open a link in a browser which is a universal link handled by the app). This commit attempts to address this by checking the return value from openURL -- if it does not open the URL successfully, then (and only then) the code falls back to broadcasting the event within the app to handleOpenURL. ### Platforms affected iOS ### What does this PR do? Fixes CB-14234; it checks the return value of the call to `openURL`, and only broadcasts the `handleOpenURL` event within the app if `openURL` fails to open the URL in the system. ### What testing has been done on this change? I've done manual testing on iOS ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser iOS calls handleOpenURL in same app for _system URLs > - > > Key: CB-14234 > URL: https://issues.apache.org/jira/browse/CB-14234 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: Dan Polivy >Priority: Minor > > The change to fix CB-11178 has caused some undesirable behavior with > InAppBrowser on iOS. Now, whenever you try to open a URL in the system > browser, by calling `cordova.InAppBrowser.open(url, "_system")`, it opens the > system browser AND calls `handleOpenURL` _in your app_ with the same URL. > In my case, my app is a URL handler for a corresponding web domain (app > links). I am trying to open a page on this web domain in the system browser > from within my app. If my app's handleOpenURL is called with a URL also on > the domain, then my handler thinks it is handling an app link and it causes > the app to navigate to another URL, which in this case is not desired or > expected. > Prior to the fix for CB-11178, this worked perfectly. Is there any other way > to address the fix for CB-11178 without inheriting this incorrect and > undesirable behavior? > [~jcesarmobile]: FYI as you committed the fix in question. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12623) Android: device plugin should access Context through webView.getContext()
[ https://issues.apache.org/jira/browse/CB-12623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576756#comment-16576756 ] ASF GitHub Bot commented on CB-12623: - janpio commented on issue #62: CB-12623: (android) access Context through webView.getContext() URL: https://github.com/apache/cordova-plugin-device/pull/62#issuecomment-412180179 @dreifachstein, could you elaborate please? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android: device plugin should access Context through webView.getContext() > - > > Key: CB-12623 > URL: https://issues.apache.org/jira/browse/CB-12623 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-plugin-device >Reporter: Xiaolei Yu >Priority: Minor > Labels: android-next > Fix For: cordova-android-7.0.0 > > > The device plugin only requires a valid Context but currently depends on an > active Activity, and does not work when the WebView is created in a service. > CB-7976 is a similar issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576639#comment-16576639
]
ASF GitHub Bot commented on CB-13685:
-
erisu edited a comment on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-412155209
@janpio I rebased with the latest master. I also did the same for
`cordova-common`'s PR that is associated with this PR.
The downside, both `cordova-common` and `cordova-android` have
`jasmine@^3.1.0` as the dep. Both will update to `3.2.0`, and It seems the
`cordova-common` tests already failed for what I believe is the same
side-effect of the latest Jasmine's release.
https://github.com/apache/cordova-common/pull/26
I am expecting these tests may show similar side-effects. We might need to
update both repo's with the temp fix...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576637#comment-16576637
]
ASF GitHub Bot commented on CB-13685:
-
dpogue commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-412156046
The changes in this PR look fine to me. I had held off on merging due to
some of the questions on the cordova-common side about where the
Android-specific handling code should live, especially with @erisu's proposed
refactoring.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576634#comment-16576634
]
ASF GitHub Bot commented on CB-13685:
-
erisu commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-412155209
@janpio I rebased with the latest master. I also did the same for
`cordova-common`'s PR that is associated with this PR.
The downside, both `cordova-common` and `cordova-android` have
`jasmine@^3.1.0` as the dep. Both will update to `3.2.0`, and It seems the
`cordova-common` tests already failed for what I believe is the same
side-effect of the latest Jasmine's release.
https://github.com/apache/cordova-common/pull/26
I am expecting these tests might have an issue too. We might need to update
both repo's with the temp fix...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576630#comment-16576630
]
ASF GitHub Bot commented on CB-13685:
-
janpio commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-412154134
Thanks @raphinesse! Same for me... hope someone with actual Android
experience turns up.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576609#comment-16576609
]
ASF GitHub Bot commented on CB-13685:
-
raphinesse edited a comment on issue #448: CB-13685 android: Adaptive Icon
Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-412149049
@janpio Unfortunately I am on a very tight schedule right now. The only
thing I had reviewed were the specs. I glanced over them again and they do look
much better. I still saw a few things that could be improved, but I don't have
time to tackle that right now.
Since it's "only the specs", I would not want to block this PR because of
this. However, I can neither give my approval for the rest of this PR since I
know too little of the subject at hand.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576608#comment-16576608
]
ASF GitHub Bot commented on CB-13685:
-
raphinesse commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-412149049
@janpio Unfortunately I am on a very tight schedule right now. The only
thing I did review were the specs. I glanced over them again and they do look
much better. I still saw a few things that could be improved, but I don't have
time to tackle that right now.
Since it's "only the specs", I would not want to block this PR because of
this. However, I can neither give my approval for the rest of this PR since I
know too little of the subject at hand.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14219) LG Phones saving images on saveToPhotoAlbum: false
[ https://issues.apache.org/jira/browse/CB-14219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576594#comment-16576594 ] sravan commented on CB-14219: - Hi all, Is there any update to this issue? Thank you > LG Phones saving images on saveToPhotoAlbum: false > -- > > Key: CB-14219 > URL: https://issues.apache.org/jira/browse/CB-14219 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: sravan >Priority: Major > Labels: LG, LG-K3, android6.0 > > Despite of options set to `*saveToPhotoAlbum: false*`, I'm able to save the > images on my phone by executing in following steps. > *Steps to reproduce:* > # open camera app > # capture photo > # Captured Image is shown (preview) with the option to cancel or accept the > image. > # Select Cancel on preview of image > # capture photo again > # accept the image on the preview screen > # Notice that both the cancelled and accepted images are saved in the photo > album. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13772) CLI `cordova requirements` printing out [object Object] in place of some version numbers
[
https://issues.apache.org/jira/browse/CB-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576580#comment-16576580
]
ASF GitHub Bot commented on CB-13772:
-
janpio closed pull request #291: CB-13772: print version numbers correctly in
"cordova requirements"
URL: https://github.com/apache/cordova-cli/pull/291
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/cli.js b/src/cli.js
index 7791b303..865231c7 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -397,7 +397,7 @@ function cli (inputArgs) {
platformCheck.forEach(function (checkItem) {
var checkSummary = checkItem.name + ': ' +
(checkItem.installed ? 'installed ' : 'not
installed ') +
-(checkItem.metadata.version || '');
+(checkItem.installed ?
checkItem.metadata.version.version || checkItem.metadata.version : '');
events.emit('log', checkSummary);
if (!checkItem.installed) {
someChecksFailed = true;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CLI `cordova requirements` printing out [object Object] in place of some
> version numbers
>
>
> Key: CB-13772
> URL: https://issues.apache.org/jira/browse/CB-13772
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova@8.0.0
> Environment: macOS High Sierra 10.13.2
> npm v5.6.0
> node v9.4.0
> cordova CLI v8.0.0
>Reporter: Darcy Meyer
>Priority: Minor
>
> When `cordova requirements` is executed, the output prints [object Object]
> in place of some of the version numbers.
> e.g.
> {code}
> $ cordova requirements
> Android Studio project detected
> Requirements check results for android:
> Java JDK: installed 1.8.0
> Android SDK: installed true
> Android target: not installed
> avdmanager: Command failed with exit code 1
> Gradle: not installed
> Could not find an installed version of Gradle either in Android Studio,
> or on your system to install the gradle wrapper. Please include gradle
> in your path, or install Android Studio
> Requirements check results for ios:
> Apple macOS: installed darwin
> Xcode: installed [object Object]
> ios-deploy: installed [object Object]
> CocoaPods: installed [object Object]
> {code}
> Here, the versions of the ios requirements are not displayed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13772) CLI `cordova requirements` printing out [object Object] in place of some version numbers
[
https://issues.apache.org/jira/browse/CB-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576579#comment-16576579
]
ASF GitHub Bot commented on CB-13772:
-
janpio commented on issue #291: CB-13772: print version numbers correctly in
"cordova requirements"
URL: https://github.com/apache/cordova-cli/pull/291#issuecomment-412145239
After looking at the code again, I am pretty confident this won't break
anything.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CLI `cordova requirements` printing out [object Object] in place of some
> version numbers
>
>
> Key: CB-13772
> URL: https://issues.apache.org/jira/browse/CB-13772
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova@8.0.0
> Environment: macOS High Sierra 10.13.2
> npm v5.6.0
> node v9.4.0
> cordova CLI v8.0.0
>Reporter: Darcy Meyer
>Priority: Minor
>
> When `cordova requirements` is executed, the output prints [object Object]
> in place of some of the version numbers.
> e.g.
> {code}
> $ cordova requirements
> Android Studio project detected
> Requirements check results for android:
> Java JDK: installed 1.8.0
> Android SDK: installed true
> Android target: not installed
> avdmanager: Command failed with exit code 1
> Gradle: not installed
> Could not find an installed version of Gradle either in Android Studio,
> or on your system to install the gradle wrapper. Please include gradle
> in your path, or install Android Studio
> Requirements check results for ios:
> Apple macOS: installed darwin
> Xcode: installed [object Object]
> ios-deploy: installed [object Object]
> CocoaPods: installed [object Object]
> {code}
> Here, the versions of the ios requirements are not displayed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13772) CLI `cordova requirements` printing out [object Object] in place of some version numbers
[
https://issues.apache.org/jira/browse/CB-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576581#comment-16576581
]
ASF subversion and git services commented on CB-13772:
--
Commit dca0e5b5c2ec8d203ec28ce90476459534e10f8d in cordova-cli's branch
refs/heads/master from [~darcymeyer]
[ https://gitbox.apache.org/repos/asf?p=cordova-cli.git;h=dca0e5b ]
CB-13772: print version numbers correctly in cordova requirements (#291)
Fixes a bug where "cordova requirements" printed out
[object Object] in place of the version number.
> CLI `cordova requirements` printing out [object Object] in place of some
> version numbers
>
>
> Key: CB-13772
> URL: https://issues.apache.org/jira/browse/CB-13772
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova@8.0.0
> Environment: macOS High Sierra 10.13.2
> npm v5.6.0
> node v9.4.0
> cordova CLI v8.0.0
>Reporter: Darcy Meyer
>Priority: Minor
>
> When `cordova requirements` is executed, the output prints [object Object]
> in place of some of the version numbers.
> e.g.
> {code}
> $ cordova requirements
> Android Studio project detected
> Requirements check results for android:
> Java JDK: installed 1.8.0
> Android SDK: installed true
> Android target: not installed
> avdmanager: Command failed with exit code 1
> Gradle: not installed
> Could not find an installed version of Gradle either in Android Studio,
> or on your system to install the gradle wrapper. Please include gradle
> in your path, or install Android Studio
> Requirements check results for ios:
> Apple macOS: installed darwin
> Xcode: installed [object Object]
> ios-deploy: installed [object Object]
> CocoaPods: installed [object Object]
> {code}
> Here, the versions of the ios requirements are not displayed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576574#comment-16576574
]
ASF GitHub Bot commented on CB-13685:
-
janpio commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-412144263
@raphinesse Could you have a look again and redo your review please?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14075) Remove Node 4 from CI - cordova-windows
[ https://issues.apache.org/jira/browse/CB-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576552#comment-16576552 ] ASF subversion and git services commented on CB-14075: -- Commit 4a1ae0cc9122edb279e347271c6ecc6bc0407ab8 in cordova-windows's branch refs/heads/master from エリス [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=4a1ae0c ] CB-14075: (windows) Remove Node 4 from CI - cordova-windows (#289) > Remove Node 4 from CI - cordova-windows > --- > > Key: CB-14075 > URL: https://issues.apache.org/jira/browse/CB-14075 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-windows >Reporter: Darryl Pogue >Assignee: Darryl Pogue >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14075) Remove Node 4 from CI - cordova-windows
[
https://issues.apache.org/jira/browse/CB-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576551#comment-16576551
]
ASF GitHub Bot commented on CB-14075:
-
janpio closed pull request #289: CB-14075: (windows) Remove Node 4 from CI -
cordova-windows
URL: https://github.com/apache/cordova-windows/pull/289
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 119ba5eb..7e44fef2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,15 +1,21 @@
language: node_js
sudo: false
+
git:
depth: 10
+
node_js:
- - "4"
- "6"
+ - "8"
+ - "10"
+
install:
-- npm install
-- npm install -g codecov
+ - npm install
+ - npm install -g codecov
+
script:
-- npm run eslint
-- npm run cover
+ - npm run eslint
+ - npm run cover
+
after_script:
-- codecov
+ - codecov
diff --git a/appveyor.yml b/appveyor.yml
index 3eb61947..94a8d4c0 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -31,12 +31,6 @@ environment:
- nodejs_version: "6"
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
-- nodejs_version: "4"
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
-
-- nodejs_version: "4"
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
-
matrix:
allow_failures:
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
diff --git a/package.json b/package.json
index 42d87689..eb3c9aac 100644
--- a/package.json
+++ b/package.json
@@ -45,6 +45,10 @@
"jasmine": "^2.99.0",
"rewire": "^2.5.1"
},
+ "engines": {
+"node": ">=6.0.0"
+ },
+ "engineStrict": true,
"bundledDependencies": [
"cordova-common",
"elementtree",
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove Node 4 from CI - cordova-windows
> ---
>
> Key: CB-14075
> URL: https://issues.apache.org/jira/browse/CB-14075
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-windows
>Reporter: Darryl Pogue
>Assignee: Darryl Pogue
>Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-14230) cordova-browser patch release August 2018
[ https://issues.apache.org/jira/browse/CB-14230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Brody resolved CB-14230. -- Resolution: Fixed > cordova-browser patch release August 2018 > - > > Key: CB-14230 > URL: https://issues.apache.org/jira/browse/CB-14230 > Project: Apache Cordova > Issue Type: Task > Components: cordova-browser >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > Patch release of cordova-browser package with CB-14145 (npm audit issues) > resolved. > Following steps at > [https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md](with > some modifications) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
