[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-28 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121284#comment-15121284
 ] 

ASF subversion and git services commented on CB-10440:
--

Commit 35f48b4ea005b92a8b956f313a66ca3beabc82a9 in cordova-windows's branch 
refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=35f48b4 ]

CB-10440 Add CSS color names support for BackgroundColor on Windows


> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121286#comment-15121286
 ] 

ASF GitHub Bot commented on CB-10440:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/142


> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-28 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121423#comment-15121423
 ] 

ASF subversion and git services commented on CB-10440:
--

Commit b292ae8c96cab47d6600a8840d9d695b7ea2b732 in cordova-docs's branch 
refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=b292ae8 ]

CB-10440 Add CSS color names support for BackgroundColor on Windows


> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121425#comment-15121425
 ] 

ASF GitHub Bot commented on CB-10440:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/466


> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120406#comment-15120406
 ] 

ASF GitHub Bot commented on CB-10440:
-

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-windows/pull/142#issuecomment-175909840
  
LGTM.


> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119615#comment-15119615
 ] 

ASF GitHub Bot commented on CB-10440:
-

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/466#discussion_r51000111
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -167,6 +167,17 @@ all of them:
 
 
 
+  Applies to Windows.
+  
+- CSS Color names are also supported:
+
+```
+
+
+
+```
+  __NOTE__: `transparent` value will cause black/white background color in 
case of Dark/Light theme accordingly.
+
   Applies to Android and BlackBerry. Overrides CSS otherwise available
--- End diff --

Yes, thanks, I've just confused this notation with the plugin docs one 
where we have a supported platforms list in the start and Quirks in the end.


> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119614#comment-15119614
 ] 

ASF GitHub Bot commented on CB-10440:
-

Github user daserge commented on the pull request:

https://github.com/apache/cordova-windows/pull/142#issuecomment-175691473
  
@nikhilkh, @dblotsky, thanks for review, I've addressed the notes.


> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119640#comment-15119640
 ] 

ASF GitHub Bot commented on CB-10440:
-

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/466#discussion_r51001854
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -167,6 +167,17 @@ all of them:
 
 
 
+  Applies to Windows.
+  
+- CSS Color names are also supported:
+
+```
+
+
+
+```
+  __NOTE__: `transparent` value will cause black/white background color in 
case of Dark/Light theme accordingly.
+
   Applies to Android and BlackBerry. Overrides CSS otherwise available
--- End diff --

@nikhilkh, Actually I believe the phrase `Applies to Android and 
BlackBerry. Overrides CSS otherwise available across _all_ platforms, for 
example: `body{background-color:blue}`.` says about page style taken from 
`BackgroundColor` preference, which is not supported on Windows.
I will update `Applies to Windows.` to `Windows Quirk` to avoid confusing 
with the rest of the doc though.


> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118703#comment-15118703
 ] 

ASF GitHub Bot commented on CB-10440:
-

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/142#discussion_r50944308
  
--- Diff: template/cordova/lib/AppxManifest.js ---
@@ -374,6 +374,11 @@ AppxManifest.prototype.getCapabilities = function () {
 };
 
 function refineColor(color) {
+if (color.indexOf('0x') === -1 && color.indexOf('#') === -1) {
--- End diff --

WIndows SDK will do the validation and omit errors for invalid values and 
it's not for us to validate here.


> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116929#comment-15116929
 ] 

ASF GitHub Bot commented on CB-10440:
-

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-docs/pull/466

CB-10440 Add CSS color names support for BackgroundColor on Windows

[Jira issue](https://issues.apache.org/jira/browse/CB-10440)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-10440

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #466


commit 00a7bfb5d800d29566c7a24d92f8d793582f9218
Author: daserge 
Date:   2016-01-26T08:30:29Z

CB-10440 Add CSS color names support for BackgroundColor on Windows




> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116927#comment-15116927
 ] 

ASF GitHub Bot commented on CB-10440:
-

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-windows/pull/142

CB-10440 Add CSS color names support for BackgroundColor on Windows

[Jira issue](https://issues.apache.org/jira/browse/CB-10440)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-10440

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #142


commit 7134e23633bc0c18b4df31f688098c656c0b1648
Author: daserge 
Date:   2016-01-26T08:32:16Z

CB-10440 Add CSS color names support for BackgroundColor on Windows




> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117632#comment-15117632
 ] 

ASF GitHub Bot commented on CB-10440:
-

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-windows/pull/142#issuecomment-175139980
  
Could you add a unit test for this?


> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117637#comment-15117637
 ] 

ASF GitHub Bot commented on CB-10440:
-

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/466#discussion_r50872339
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -167,6 +167,17 @@ all of them:
 
 
 
+  Applies to Windows.
+  
+- CSS Color names are also supported:
+
+```
+
+
+
+```
+  __NOTE__: `transparent` value will cause black/white background color in 
case of Dark/Light theme accordingly.
+
   Applies to Android and BlackBerry. Overrides CSS otherwise available
--- End diff --

Does the 'applies to Android & Blackberry' needs to be fixed?


> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118494#comment-15118494
 ] 

ASF GitHub Bot commented on CB-10440:
-

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/142#discussion_r50934535
  
--- Diff: template/cordova/lib/AppxManifest.js ---
@@ -374,6 +374,11 @@ AppxManifest.prototype.getCapabilities = function () {
 };
 
 function refineColor(color) {
+if (color.indexOf('0x') === -1 && color.indexOf('#') === -1) {
--- End diff --

Please put this condition into a function; that way it will be easier to 
debug and read in the future.


> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows

2016-01-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118499#comment-15118499
 ] 

ASF GitHub Bot commented on CB-10440:
-

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/142#discussion_r50934617
  
--- Diff: template/cordova/lib/AppxManifest.js ---
@@ -374,6 +374,11 @@ AppxManifest.prototype.getCapabilities = function () {
 };
 
 function refineColor(color) {
+if (color.indexOf('0x') === -1 && color.indexOf('#') === -1) {
--- End diff --

Is there a list of valid CSS colours? For example, `meow` and `12345` and 
are not colours, but they will get accepted here.


> Add CSS color names support for BackgroundColor on Windows
> --
>
> Key: CB-10440
> URL: https://issues.apache.org/jira/browse/CB-10440
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add  to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute 
> '/Package/Applications/Application/m3:VisualElements/@BackgroundColor' is not 
> a valid color name or color hexadecimal identifier.
>   
> This is because the generated appmanifest has this line :
> 
> where it doesn't expect the value to be a named color value other than a 
> hexadecimal color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> 
> or
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org