[jira] [Commented] (CB-10465) cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130450#comment-15130450
 ] 

ASF GitHub Bot commented on CB-10465:
-

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/374#issuecomment-179262628
  
@sgrebnov, PTAL


> cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments
> 
>
> Key: CB-10465
> URL: https://issues.apache.org/jira/browse/CB-10465
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.1
>Reporter: Manuel Martiarena
>Assignee: Vladimir Kotikov
>  Labels: cordova-lib, triaged
>
> All cordova.raw command now need to be called with arguments like this ticket 
> expains: https://issues.apache.org/jira/browse/CB-9987.
> Unfortunately the raw emulate command executes the raw prepare with the wrong 
> structure of arguments, with the side effect that if you want to emulate only 
> iOS, the other configured projects will also be add/checked/prepared.
> emulate.js calls it like this: 
> return require('./cordova').raw.prepare(options.platforms);
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/emulate.js
>  line 36
> But the argument should be an object with a key named platforms. like so:
> return require('./cordova').raw.prepare({platforms: options.platforms}); 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10465) cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130468#comment-15130468
 ] 

ASF subversion and git services commented on CB-10465:
--

Commit b1bdd55690165ea75e0217c9ebf78b6e41257aad in cordova-lib's branch 
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=b1bdd55 ]

CB-10465 Pass correct options to prepare from compile


> cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments
> 
>
> Key: CB-10465
> URL: https://issues.apache.org/jira/browse/CB-10465
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.1
>Reporter: Manuel Martiarena
>Assignee: Vladimir Kotikov
>  Labels: cordova-lib, reproduced, triaged
>
> All cordova.raw command now need to be called with arguments like this ticket 
> expains: https://issues.apache.org/jira/browse/CB-9987.
> Unfortunately the raw emulate command executes the raw prepare with the wrong 
> structure of arguments, with the side effect that if you want to emulate only 
> iOS, the other configured projects will also be add/checked/prepared.
> emulate.js calls it like this: 
> return require('./cordova').raw.prepare(options.platforms);
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/emulate.js
>  line 36
> But the argument should be an object with a key named platforms. like so:
> return require('./cordova').raw.prepare({platforms: options.platforms}); 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10465) cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130435#comment-15130435
 ] 

ASF GitHub Bot commented on CB-10465:
-

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/374

CB-10465 Pass correct options to prepare from compile

This fixes incorrect behaviour of `cordova emulate` command, which results 
in restoring all saved platforms even when only particular platform specified.

See [CB-10465](https://issues.apache.org/jira/browse/CB-10465) for details

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-10465

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #374


commit ff89da1de181f870c2461b1502d207a668c9b648
Author: Vladimir Kotikov 
Date:   2016-02-03T13:55:31Z

CB-10465 Pass correct options to prepare from compile




> cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments
> 
>
> Key: CB-10465
> URL: https://issues.apache.org/jira/browse/CB-10465
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.1
>Reporter: Manuel Martiarena
>Assignee: Vladimir Kotikov
>  Labels: cordova-lib, regression, triaged
>
> All cordova.raw command now need to be called with arguments like this ticket 
> expains: https://issues.apache.org/jira/browse/CB-9987.
> Unfortunately the raw emulate command executes the raw prepare with the wrong 
> structure of arguments, with the side effect that if you want to emulate only 
> iOS, the other configured projects will also be add/checked/prepared.
> emulate.js calls it like this: 
> return require('./cordova').raw.prepare(options.platforms);
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/emulate.js
>  line 36
> But the argument should be an object with a key named platforms. like so:
> return require('./cordova').raw.prepare({platforms: options.platforms}); 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10465) cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments

[Vladimir Kotikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130433#comment-15130433
 ] 

Vladimir Kotikov commented on CB-10465:
---

I can see this issue even with cordova@5.3.3, so this is not related to 
CB-9987. It seems for me that this behaviour has been there from the beginning 
of 'restore' feature (see 
[8a313a0|https://github.com/apache/cordova-lib/commit/8a313a083bb2c4e39d3230ecbe090d7852bf5454],
 notice that {{cordova_util.preProcessOptions}} is now called after platforms 
restore).

> cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments
> 
>
> Key: CB-10465
> URL: https://issues.apache.org/jira/browse/CB-10465
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.1
>Reporter: Manuel Martiarena
>Assignee: Vladimir Kotikov
>  Labels: cordova-lib, regression, triaged
>
> All cordova.raw command now need to be called with arguments like this ticket 
> expains: https://issues.apache.org/jira/browse/CB-9987.
> Unfortunately the raw emulate command executes the raw prepare with the wrong 
> structure of arguments, with the side effect that if you want to emulate only 
> iOS, the other configured projects will also be add/checked/prepared.
> emulate.js calls it like this: 
> return require('./cordova').raw.prepare(options.platforms);
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/emulate.js
>  line 36
> But the argument should be an object with a key named platforms. like so:
> return require('./cordova').raw.prepare({platforms: options.platforms}); 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10465) cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130469#comment-15130469
 ] 

ASF GitHub Bot commented on CB-10465:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/374


> cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments
> 
>
> Key: CB-10465
> URL: https://issues.apache.org/jira/browse/CB-10465
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.1
>Reporter: Manuel Martiarena
>Assignee: Vladimir Kotikov
>  Labels: cordova-lib, reproduced, triaged
>
> All cordova.raw command now need to be called with arguments like this ticket 
> expains: https://issues.apache.org/jira/browse/CB-9987.
> Unfortunately the raw emulate command executes the raw prepare with the wrong 
> structure of arguments, with the side effect that if you want to emulate only 
> iOS, the other configured projects will also be add/checked/prepared.
> emulate.js calls it like this: 
> return require('./cordova').raw.prepare(options.platforms);
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/emulate.js
>  line 36
> But the argument should be an object with a key named platforms. like so:
> return require('./cordova').raw.prepare({platforms: options.platforms}); 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10465) cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130454#comment-15130454
 ] 

ASF GitHub Bot commented on CB-10465:
-

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-lib/pull/374#issuecomment-179263903
  
LGTM


> cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments
> 
>
> Key: CB-10465
> URL: https://issues.apache.org/jira/browse/CB-10465
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.4.1
>Reporter: Manuel Martiarena
>Assignee: Vladimir Kotikov
>  Labels: cordova-lib, reproduced, triaged
>
> All cordova.raw command now need to be called with arguments like this ticket 
> expains: https://issues.apache.org/jira/browse/CB-9987.
> Unfortunately the raw emulate command executes the raw prepare with the wrong 
> structure of arguments, with the side effect that if you want to emulate only 
> iOS, the other configured projects will also be add/checked/prepared.
> emulate.js calls it like this: 
> return require('./cordova').raw.prepare(options.platforms);
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/emulate.js
>  line 36
> But the argument should be an object with a key named platforms. like so:
> return require('./cordova').raw.prepare({platforms: options.platforms}); 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org