[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[
https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637219#comment-16637219
]
ASF GitHub Bot commented on CB-12468:
-
janpio closed pull request #213: CB-12468 added ability to set|get default
options;
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitignore b/.gitignore
index f63dbbf71..ebfceb4b9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -14,7 +14,7 @@ Thumbs.db
*.idea
node_modules
-
+.idea/
diff --git a/README.md b/README.md
index eade58a37..00140e627 100644
--- a/README.md
+++ b/README.md
@@ -81,12 +81,12 @@ Report issues with this plugin on the [Apache Cordova issue
tracker](https://iss
If you want all page loads in your app to go through the InAppBrowser, you can
simply hook `window.open` during initialization. For example:
-
+```javascript
document.addEventListener("deviceready", onDeviceReady, false);
function onDeviceReady() {
window.open = cordova.InAppBrowser.open;
}
-
+```
## cordova.InAppBrowser.open
Opens a URL in a new `InAppBrowser` instance, the current browser
@@ -203,6 +203,27 @@ The object returned from a call to
`cordova.InAppBrowser.open` when the target i
- executeScript
- insertCSS
+## cordova.InAppBrowser.setDefaultOptions
+
+> Set default options for all instances of InAppBrowser;
+
+cordova.InAppBrowser.setDefaultOptions(options);
+
+## Example
+All options that have required attrinbute will be used even if another options
will be provided in window.open.
+In other cases new and default will merge together
+
+```javascript
+
cordova.InAppBrowser.setDefaultOptions('location=no(required),toolbar=yes(required),closebuttoncaption=Close');
+```
+
+## cordova.InAppBrowser.setDefaultOptions
+
+> Get default options for all instances of InAppBrowser;
+
+cordova.InAppBrowser.getDefaultOptions();
+
+
## InAppBrowser.addEventListener
> Adds a listener for an event from the `InAppBrowser`. (Only available when
> the target is set to `'_blank'`)
diff --git a/plugin.xml b/plugin.xml
index 4a820ddc4..bdde94a83 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -30,15 +30,21 @@
https://issues.apache.org/jira/browse/CB/component/12320641
-
+
+
+
+
+
+
+
@@ -70,9 +76,15 @@
+
+
+
+
+
+
@@ -80,9 +92,9 @@
-
+
-
+
@@ -107,6 +119,13 @@
+
+
+
+
+
+
+
@@ -116,9 +135,15 @@
+
+
+
+
+
+
diff --git a/types/index.d.ts b/types/index.d.ts
index 3bac6707b..ea428a0dc 100644
--- a/types/index.d.ts
+++ b/types/index.d.ts
@@ -25,6 +25,11 @@ interface Window {
* NOTE: The InAppBrowser window behaves like a standard web browser, and
can't access Cordova APIs.
*/
interface InAppBrowser extends Window {
+
+options: string;
+setDefaultOptions(opts: string): void;
+getDefaultOptions(): string;
+
onloadstart(type: Event): void;
onloadstop(type: InAppBrowserEvent): void;
onloaderror(type: InAppBrowserEvent): void;
diff --git a/www/inappbrowser.js b/www/inappbrowser.js
index 3619f173f..512e03242 100644
--- a/www/inappbrowser.js
+++ b/www/inappbrowser.js
@@ -28,8 +28,6 @@
var exec = require('cordova/exec');
var channel = require('cordova/channel');
-var modulemapper = require('cordova/modulemapper');
-var urlutil = require('cordova/urlutil');
function InAppBrowser () {
this.channels = {
@@ -41,6 +39,16 @@
};
}
+InAppBrowser.options = '';
+
+InAppBrowser.setDefaultOptions = function (str) {
+InAppBrowser.options = str || '';
+};
+
+InAppBrowser.getDefaultOptions = function () {
+return InAppBrowser.options || '';
+};
+
InAppBrowser.prototype = {
_eventHandler: function (event) {
if (event && (event.type in this.channels)) {
@@ -88,28 +96,7 @@
}
};
-module.exports = function (strUrl, strWindowName, strWindowFeatures,
callbacks) {
-// Don't catch calls
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637218#comment-16637218 ] ASF GitHub Bot commented on CB-12468: - janpio commented on issue #213: CB-12468 added ability to set|get default options; URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213#issuecomment-426718606 Closing and re-opening to trigger a new CI/test run with new PR merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-lib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko >Priority: Major > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637220#comment-16637220 ] ASF GitHub Bot commented on CB-12468: - IvanProdaiko94 opened a new pull request #213: CB-12468 added ability to set|get default options; URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213 While using plugin I must set popup features only when calling window.open method. But a lot of libraries (firebase, openFB) use window.open inside their own code where I can't directly menage the features of window to be opened, and on IOS, where we do not a have a 'back' button we could have a problem. For example window, opened with 'toolbar=no' will make app to stack with no ability to close the window. Another thing to be mentioned is when on IOS you use attribute, after opening a new window without setting 'allowInlineMediaPlayback=yes' all inline attributes will stop working properly and video will start to open in a fullscreen mode. So, my proposal is to provide an ability to setDefaultOptions method that will help to prevent external libraries to manage the options of of window to be opened directly. If pass a '(required)' in option like that 'location=no(required)' than any option provided in window.open method will not affect on the default settings. I tested it in my projects (IOS|Android), and everything works fine; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-lib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko >Priority: Major > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636023#comment-16636023 ] ASF GitHub Bot commented on CB-12468: - janpio commented on issue #213: CB-12468 added ability to set|get default options; URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213#issuecomment-426405042 One last rebase on `master` should get the tests passing now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-lib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko >Priority: Major > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618794#comment-16618794 ] ASF GitHub Bot commented on CB-12468: - IvanProdaiko94 commented on issue #213: CB-12468 added ability to set|get default options; URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213#issuecomment-422329562 @janpio ok This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-lib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko >Priority: Major > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616838#comment-16616838 ] ASF GitHub Bot commented on CB-12468: - janpio commented on issue #213: CB-12468 added ability to set|get default options; URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213#issuecomment-421807520 @IvanProdaiko94 could you please rebase onto `master` once more? Maybe this will reset and fix the tests. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-lib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko >Priority: Major > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412303#comment-16412303 ] ASF GitHub Bot commented on CB-12468: - nosovk commented on issue #213: CB-12468 added ability to set|get default options; URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213#issuecomment-375830953 Some CI check seems to be broken :( This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-lib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko >Priority: Major > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411759#comment-16411759 ] ASF GitHub Bot commented on CB-12468: - IvanProdaiko94 commented on issue #213: CB-12468 added ability to set|get default options; URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213#issuecomment-375743615 Give this PR one more try, please) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-lib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko >Priority: Major > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329366#comment-16329366 ] ASF GitHub Bot commented on CB-12468: - infil00p commented on issue #213: CB-12468 added ability to set|get default options; URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213#issuecomment-358427527 We don't merge if it doesn't merge cleanly, that's why it didn't get merged most likely. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-lib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko >Priority: Major > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000362#comment-16000362 ] ASF GitHub Bot commented on CB-12468: - Github user olgakozoriz commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/213 Have the same issue on IOS. Probably fixing ios is needed to, but seems that it's good workaround compatible with all systems. Why not merge? > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlatforms, cordova-lib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944668#comment-15944668 ] ASF GitHub Bot commented on CB-12468: - Github user IvanProdaiko94 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/213 Any changes to be rebased to master? What shell I do to improve pull in order to get this done? > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlatforms, CordovaLib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926021#comment-15926021 ] ASF GitHub Bot commented on CB-12468: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/213 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/213/commits/32d84a2fa12ff326a7d9f1cd290ec25322e7229a) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=windows-10-store/artifact/) | | [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=ios-9.3/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=ios-9.3/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=ios-9.3/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=ios-9.3/artifact/) | | [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=ios-10.0/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=ios-10.0/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=ios-10.0/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=ios-10.0/artifact/) | | [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=android-4.4/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=android-4.4/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=android-4.4/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=android-4.4/artifact/) | | [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=android-5.1/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=android-5.1/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=android-5.1/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/133//PLATFORM=android-5.1/artifact/) | > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlatforms, CordovaLib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897163#comment-15897163 ] ASF GitHub Bot commented on CB-12468: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/213 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/213/commits/9d5edd9c831c5862ede14850e7b7988437752966) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=windows-10-store/artifact/) | | [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=ios-9.3/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=ios-9.3/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=ios-9.3/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=ios-9.3/artifact/) | | [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=ios-10.0/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=ios-10.0/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=ios-10.0/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=ios-10.0/artifact/) | | [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=android-4.4/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=android-4.4/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=android-4.4/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=android-4.4/artifact/) | | [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=android-5.1/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=android-5.1/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=android-5.1/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/130//PLATFORM=android-5.1/artifact/) | > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlatforms, CordovaLib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897152#comment-15897152 ] ASF GitHub Bot commented on CB-12468: - Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/213 Let there be tests > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlatforms, CordovaLib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896895#comment-15896895 ] ASF GitHub Bot commented on CB-12468: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/213 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/213/commits/2626cf0f968e6234c2f8991be5af1254ec71c399) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=windows-10-store/artifact/) | | [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=ios-9.3/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=ios-9.3/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=ios-9.3/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=ios-9.3/artifact/) | | [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=ios-10.0/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=ios-10.0/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=ios-10.0/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=ios-10.0/artifact/) | | [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=android-4.4/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=android-4.4/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=android-4.4/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=android-4.4/artifact/) | | [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=android-5.1/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=android-5.1/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=android-5.1/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/129//PLATFORM=android-5.1/artifact/) | > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlatforms, CordovaLib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873211#comment-15873211 ] ASF GitHub Bot commented on CB-12468: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/213 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/213/commits/2b9f341d07f93efed817b9382c1d8c584b02f976) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=windows-10-store/artifact/) | | [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=ios-9.3/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=ios-9.3/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=ios-9.3/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=ios-9.3/artifact/) | | [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=ios-10.0/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=ios-10.0/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=ios-10.0/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=ios-10.0/artifact/) | | [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=android-4.4/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=android-4.4/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=android-4.4/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=android-4.4/artifact/) | | [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=android-5.1/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=android-5.1/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=android-5.1/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/127//PLATFORM=android-5.1/artifact/) | > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlatforms, CordovaLib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873097#comment-15873097 ] ASF GitHub Bot commented on CB-12468: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/213 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/213/commits/19a08ab332cd12e79cdeb88c04fd0827fa31c8a7) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=windows-10-store/artifact/) | | [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=ios-9.3/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=ios-9.3/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=ios-9.3/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=ios-9.3/artifact/) | | [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=ios-10.0/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=ios-10.0/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=ios-10.0/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=ios-10.0/artifact/) | | [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=android-4.4/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=android-4.4/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=android-4.4/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=android-4.4/artifact/) | | [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=android-5.1/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=android-5.1/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=android-5.1/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/126//PLATFORM=android-5.1/artifact/) | > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlatforms, CordovaLib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871926#comment-15871926 ] ASF GitHub Bot commented on CB-12468: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/213 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/213/commits/b2ca311b587af5d2168873f49a86d6cc67b67789) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=windows-10-store/artifact/) | | [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-9.3/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-9.3/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-9.3/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-9.3/artifact/) | | [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-10.0/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-10.0/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-10.0/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=ios-10.0/artifact/) | | [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-4.4/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-4.4/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-4.4/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-4.4/artifact/) | | [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-5.1/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-5.1/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-5.1/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/125//PLATFORM=android-5.1/artifact/) | > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlatforms, CordovaLib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
