[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291668#comment-16291668 ] ASF subversion and git services commented on CB-12895: -- Commit b5877e51c160f5df5518151a806a6a0481137902 in cordova-create's branch refs/heads/1.1.x from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-create.git;h=b5877e5 ] CB-12895 : setup eslint and remove jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206716#comment-16206716 ] ASF subversion and git services commented on CB-12895: -- Commit 9826610d0f910fd2acc2143ce87b51ede6890743 in cordova-browser's branch refs/heads/5.0.x from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=9826610 ] Merge pull request #45 from audreyso/CB-12895-eslint CB-12895 : ignoring cordova.js for eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206717#comment-16206717 ] ASF subversion and git services commented on CB-12895: -- Commit 9826610d0f910fd2acc2143ce87b51ede6890743 in cordova-browser's branch refs/heads/5.0.x from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=9826610 ] Merge pull request #45 from audreyso/CB-12895-eslint CB-12895 : ignoring cordova.js for eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206715#comment-16206715 ] ASF subversion and git services commented on CB-12895: -- Commit e1cbe0e689f3c4a99abd96c333e68c89e424d446 in cordova-browser's branch refs/heads/5.0.x from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=e1cbe0e ] CB-12895 : ignoring cordova.js for eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197714#comment-16197714 ] ASF subversion and git services commented on CB-12895: -- Commit 93ff171027bd2d0bb3590cf70ecc8277d347c1fa in cordova-ios's branch refs/heads/4.5.x from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=93ff171 ] CB-12895 : ignoring cordova.js file > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195342#comment-16195342 ] ASF subversion and git services commented on CB-12895: -- Commit 20c2f03ba55663dd3aebecb8558b8f2c36e1651f in cordova-plugman's branch refs/heads/1.5.x from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=20c2f03 ] CB-12895 : setup eslint and remove jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184359#comment-16184359 ] ASF subversion and git services commented on CB-12895: -- Commit a91783715d1c221283d055ccb709c18f215c4fc7 in cordova-windows's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=a917837 ] CB-12895: ignoring cordova.js for eslint & removing comments and references to jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184357#comment-16184357 ] ASF subversion and git services commented on CB-12895: -- Commit 9826610d0f910fd2acc2143ce87b51ede6890743 in cordova-browser's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=9826610 ] Merge pull request #45 from audreyso/CB-12895-eslint CB-12895 : ignoring cordova.js for eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184355#comment-16184355 ] ASF subversion and git services commented on CB-12895: -- Commit e1cbe0e689f3c4a99abd96c333e68c89e424d446 in cordova-browser's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=e1cbe0e ] CB-12895 : ignoring cordova.js for eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184356#comment-16184356 ] ASF subversion and git services commented on CB-12895: -- Commit 9826610d0f910fd2acc2143ce87b51ede6890743 in cordova-browser's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=9826610 ] Merge pull request #45 from audreyso/CB-12895-eslint CB-12895 : ignoring cordova.js for eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184353#comment-16184353 ] ASF subversion and git services commented on CB-12895: -- Commit b162750893ec7e5abb0590e90ff95d4939178391 in cordova-ios's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=b162750 ] Merge pull request #339 from audreyso/CB-12895-eslint CB-12895 : ignoring cordova.js file > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184351#comment-16184351 ] ASF subversion and git services commented on CB-12895: -- Commit 523f7182453f555b17d4f649927c3931f4a4fac9 in cordova-ios's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=523f718 ] CB-12895 : ignoring cordova.js file > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184352#comment-16184352 ] ASF subversion and git services commented on CB-12895: -- Commit b162750893ec7e5abb0590e90ff95d4939178391 in cordova-ios's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=b162750 ] Merge pull request #339 from audreyso/CB-12895-eslint CB-12895 : ignoring cordova.js file > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184346#comment-16184346 ] ASF subversion and git services commented on CB-12895: -- Commit e5c90badbaf0c8c6fca52731b216f993ed1029ec in cordova-android's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=e5c90ba ] CB-12895 : eslint ignoring cordova.js > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184348#comment-16184348 ] ASF subversion and git services commented on CB-12895: -- Commit 6fa16b615b8383dbdbc6defa43d7e17a9a1f3697 in cordova-android's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=6fa16b6 ] Merge pull request #408 from audreyso/CB-12895-eslint CB-12895 : eslint ignoring cordova.js > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184347#comment-16184347 ] ASF subversion and git services commented on CB-12895: -- Commit 6fa16b615b8383dbdbc6defa43d7e17a9a1f3697 in cordova-android's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=6fa16b6 ] Merge pull request #408 from audreyso/CB-12895-eslint CB-12895 : eslint ignoring cordova.js > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183469#comment-16183469 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/149 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183468#comment-16183468 ] ASF subversion and git services commented on CB-12895: -- Commit c75e8059114255d1dbae1ede398e6626708ee9f3 in cordova-js's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=c75e805 ] CB-12895 : added eslint to repo > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181774#comment-16181774 ] Audrey So commented on CB-12895: Will be adding eslint to cordova-js and also ignoring pkg/ directory. Also, will need to ignore cordova.js files in android, ios, windows, and browser. This is to address a problem was uncovered while adding eslint to cordova-js repo. Issue was: The pkg/ directory is ignored by github so it doesn’t get checked in b/c the files are newly generated every time we run grunt compile. They get overwritten next time grunt compile is run. When grunt is called and compiled, it calls a generate function, which calls a bundle function. Here --> https://github.com/apache/cordova-js/blob/master/tasks/lib/bundle.js#L80 All of the output.push stuff is not compliant with eslint because of the indenting. For instance, here in line 80, eslint does not like that (1) there is a semi-colon in front of function and (2) `var PLATFORM_VERSION_BUILD_LABEL = '" + platformVersion + "';");` is not indented. and everything after that is not indented properly then. Solution: add cordova.js to all the platform repos eslintignore file and ignore pkg directory for eslint in cordova-js repo > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181232#comment-16181232 ] ASF GitHub Bot commented on CB-12895: - Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/149#discussion_r141135727 --- Diff: package.json --- @@ -15,6 +15,7 @@ "url": "https://issues.apache.org/jira/browse/CB"; }, "scripts": { +"eslint": "eslint src test", --- End diff -- If I do `npm run eslint pkg/`, it will reveal all of the pkg/ errors. I can reduce some errors using --fix (mostly indenting errors) but the rest would have to be fixed manually. I won't be able to change/fix anything, however, unless I can check in the pkg/ directory though. If I run `npm run eslint` without specifying pkg, it will just ignore it. Hmm... > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181222#comment-16181222 ] ASF GitHub Bot commented on CB-12895: - Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/149#discussion_r141133636 --- Diff: package.json --- @@ -15,6 +15,7 @@ "url": "https://issues.apache.org/jira/browse/CB"; }, "scripts": { +"eslint": "eslint src test", --- End diff -- we want to keep `pkg` in `.gitignore`. What happens if we run `eslint` on a folder that doesn't exist? We need to figure out how to fix those errors. Grr. I can take a look with you. Manually fixing those errors is not an option. Are they all fixable with `eslint --fix`? > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181048#comment-16181048 ] ASF GitHub Bot commented on CB-12895: - Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/149#discussion_r141107663 --- Diff: package.json --- @@ -15,6 +15,7 @@ "url": "https://issues.apache.org/jira/browse/CB"; }, "scripts": { +"eslint": "eslint src test", --- End diff -- But yes running eslint on pkg results in many errors. Mostly indentation errors. > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181035#comment-16181035 ] ASF GitHub Bot commented on CB-12895: - Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/149#discussion_r141106590 --- Diff: package.json --- @@ -15,6 +15,7 @@ "url": "https://issues.apache.org/jira/browse/CB"; }, "scripts": { +"eslint": "eslint src test", --- End diff -- Hmm so if we add in pkg here, there may be an issue because pkg is in the .gitignore. Should I remove pkg from .gitignore so eslint can test it? > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179968#comment-16179968 ] ASF GitHub Bot commented on CB-12895: - Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/149#discussion_r140927689 --- Diff: package.json --- @@ -15,6 +15,7 @@ "url": "https://issues.apache.org/jira/browse/CB"; }, "scripts": { +"eslint": "eslint src test", --- End diff -- can you also get it to run on `pkg` `"eslint src test pkg"` > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179969#comment-16179969 ] ASF GitHub Bot commented on CB-12895: - Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/149#discussion_r140927739 --- Diff: package.json --- @@ -15,6 +15,7 @@ "url": "https://issues.apache.org/jira/browse/CB"; }, "scripts": { +"eslint": "eslint src test", "test": "grunt test", --- End diff -- can you add `npm run eslint` to the test script here > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179954#comment-16179954 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-js/pull/149 CB-12895 : added eslint to repo ### Platforms affected ### What does this PR do? Added eslint to repo ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-js CB-12895-eslint Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/149.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #149 commit b26580bf5cf4705c19ee00783f462e8fc4d3c958 Author: Audrey So Date: 2017-09-25T21:06:08Z CB-12895 : added eslint to repo > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179767#comment-16179767 ] ASF subversion and git services commented on CB-12895: -- Commit be6c6ba9764ac812bddefc8c588c55774a65187f in cordova-android's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=be6c6ba ] CB-12895: Temporarily disabling eslint since cordova-js does not have eslint yet. > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179766#comment-16179766 ] ASF subversion and git services commented on CB-12895: -- Commit 021c9c19e83694a12985ba46e0f1ac5981848a16 in cordova-android's branch refs/heads/6.3.x from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=021c9c1 ] CB-12895: Temporarily disabling eslint since cordova-js does not have eslint yet. > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172480#comment-16172480 ] ASF subversion and git services commented on CB-12895: -- Commit 06441bb531e6bddd2f8f2517fb21de2e0ea4c9b3 in cordova-fetch's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-fetch.git;h=06441bb ] CB-12895 : setting up eslint and removing jshint This closes #2 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146337#comment-16146337 ] ASF subversion and git services commented on CB-12895: -- Commit 07557e02a6ae58cf54d4c96e5ea89d6180ab7782 in cordova-plugin-file's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=07557e0 ] CB-12895 : setup eslint and took out jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146338#comment-16146338 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/214 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146327#comment-16146327 ] ASF subversion and git services commented on CB-12895: -- Commit 902427525f896ae80b11cc0061a9e2420a00662d in cordova-plugin-inappbrowser's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=9024275 ] CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146328#comment-16146328 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/236 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137309#comment-16137309 ] ASF subversion and git services commented on CB-12895: -- Commit 34ae0bbbe9657bac15ebeda87f2c8a8560fa83b0 in cordova-coho's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-coho.git;h=34ae0bb ] CB-12895 : added eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137311#comment-16137311 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/154 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131240#comment-16131240 ] Audrey So commented on CB-12895: These are the completed repos --> Cordova-android Cordova-browser Cordova-cli (remove old jshint files) Cordova-common Cordova-create Cordova-ios Cordova-js Cordova-lib Cordova-osx Cordova-plugin-battery-status Cordova-plugin-camera Cordova-plugin-device Cordova-plugin-dialogs Cordova-plugin-geolocation Cordova-plugin-globalization Cordova-plugin-media-capture (error on Travis?) Cordova-plugin-network-information Cordova-plugin-test-framework (remove old jshint files) Cordova-plugin-vibration (remove old jshint files) Cordova-plugin-wkwebview-engine Cordova-plugman Cordova-serve Cordova-windows These are the ones that are left to be merged in & may have some failing CI tests. I can double check --> cordova-coho Cordova-fetch Cordova-plugin-file cordova-plugin-inappbrowser Did I miss any repos? > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130986#comment-16130986 ] Steve Gill commented on CB-12895: - Anything else left here to do? > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130957#comment-16130957 ] ASF subversion and git services commented on CB-12895: -- Commit ca785332619a223eba59c5b9ed3e81eaf63ef00c in cordova-discuss's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-discuss.git;h=ca78533 ] CB-12895 : proposal for jshint to eslint changes > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130958#comment-16130958 ] ASF subversion and git services commented on CB-12895: -- Commit 5b2dafdc37510bfe1da5b809667e5e2500e7bf1e in cordova-discuss's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-discuss.git;h=5b2dafd ] Merge pull request #71 from audreyso/CB-12895_proposal CB-12895proposal : jshint to eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130959#comment-16130959 ] ASF subversion and git services commented on CB-12895: -- Commit 5b2dafdc37510bfe1da5b809667e5e2500e7bf1e in cordova-discuss's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-discuss.git;h=5b2dafd ] Merge pull request #71 from audreyso/CB-12895_proposal CB-12895proposal : jshint to eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120834#comment-16120834 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-coho/pull/154 CB-12895 : Added eslint ### Platforms affected ### What does this PR do? Added eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-coho CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/154.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #154 commit dfe6f40058b1eafc48cd00eb3876853fc28a7cf3 Author: Audrey So Date: 2017-06-09T18:40:05Z CB-12895 : added eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120667#comment-16120667 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/236 CB-12895 : Added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-inappbrowser CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/236.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #236 commit db6072abe512b9a63ba8d568e98d8dfb23bddc73 Author: Audrey So Date: 2017-06-12T17:34:08Z CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120658#comment-16120658 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/60 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120656#comment-16120656 ] ASF subversion and git services commented on CB-12895: -- Commit 77894697a1931eece7cca33d39def94a096632f0 in cordova-plugin-globalization's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-globalization.git;h=7789469 ] CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120461#comment-16120461 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/60 CB-12895 : added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-globalization CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-globalization/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 commit 77894697a1931eece7cca33d39def94a096632f0 Author: Audrey So Date: 2017-06-12T17:26:46Z CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120454#comment-16120454 ] ASF subversion and git services commented on CB-12895: -- Commit 3dfbb7826fff868179dcc5e028992eedf9cb7121 in cordova-plugin-device's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device.git;h=3dfbb78 ] CB-12895 : setup eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120456#comment-16120456 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/70 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120443#comment-16120443 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/92 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120442#comment-16120442 ] ASF subversion and git services commented on CB-12895: -- Commit 69eb5ba5b5e801c55661dd277a2dd6997ff19c4d in cordova-plugin-geolocation's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-geolocation.git;h=69eb5ba ] CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116878#comment-16116878 ] ASF subversion and git services commented on CB-12895: -- Commit b2b121b856d0ea92fadca6cae5d8ff283c68f40f in cordova-plugin-wkwebview-engine's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=b2b121b ] CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116879#comment-16116879 ] ASF subversion and git services commented on CB-12895: -- Commit 919dbcec374b3a7ebab0131da9870ec25cb10db2 in cordova-plugin-wkwebview-engine's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=919dbce ] CB-12895 : rebased and updated files > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116880#comment-16116880 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/41 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116870#comment-16116870 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/59 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116869#comment-16116869 ] ASF subversion and git services commented on CB-12895: -- Commit d23d7a870ed9fcfe6df076fe1ec49d4a71780d8d in cordova-plugin-vibration's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=d23d7a8 ] CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116866#comment-16116866 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/58 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116864#comment-16116864 ] ASF subversion and git services commented on CB-12895: -- Commit 78691e43e16d753603f41d646ca7e71b3212c282 in cordova-plugin-network-information's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-network-information.git;h=78691e4 ] CB-12895 : added eslint and removed eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116831#comment-16116831 ] ASF subversion and git services commented on CB-12895: -- Commit 9cf0c65e49ec483585cd3c9c08d16676bff7334e in cordova-plugin-globalization's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-globalization.git;h=9cf0c65 ] Merge branch 'CB-12895' > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116830#comment-16116830 ] ASF subversion and git services commented on CB-12895: -- Commit f8e7fcd4b3acc6afbfe704a1591839971cd33025 in cordova-plugin-globalization's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-globalization.git;h=f8e7fcd ] CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116810#comment-16116810 ] ASF subversion and git services commented on CB-12895: -- Commit 86e33d3f7fe3c65ff14711f36d2ab1443279a191 in cordova-plugin-globalization's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-globalization.git;h=86e33d3 ] CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116793#comment-16116793 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/96 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116792#comment-16116792 ] ASF subversion and git services commented on CB-12895: -- Commit 0b532b6eeb04c6adbccfea60f132f88de0c14755 in cordova-plugin-dialogs's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-dialogs.git;h=0b532b6 ] CB-12895 : setup eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116786#comment-16116786 ] ASF subversion and git services commented on CB-12895: -- Commit 16c4325fef80327bceccedb491e29064da79b556 in cordova-plugin-camera's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=16c4325 ] CB-12895 : updated src files to use eslint format > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116787#comment-16116787 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/281 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114505#comment-16114505 ] ASF subversion and git services commented on CB-12895: -- Commit 835acc8d4daf4693d21c4be086fb06d1bdf9fc81 in cordova-plugin-battery-status's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=835acc8 ] CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114506#comment-16114506 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/58 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114498#comment-16114498 ] ASF subversion and git services commented on CB-12895: -- Commit 1694228a2cd01bdea8b15fb0d6b6f8d4dbcb091f in cordova-plugin-media-capture's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=1694228 ] CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114499#comment-16114499 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/82 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113057#comment-16113057 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-file/pull/214 CB-12895 : Setup eslint and removed jshint ### Platforms affected ### What does this PR do? Setup eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-file CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/214.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #214 commit c307226bb317f69a8df93688a6c2d71aa53fe37f Author: Audrey So Date: 2017-06-09T23:06:08Z CB-12895 : setup eslint and took out jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112874#comment-16112874 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/92 CB-12895 : Added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-geolocation CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-geolocation/pull/92.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #92 commit 69eb5ba5b5e801c55661dd277a2dd6997ff19c4d Author: Audrey So Date: 2017-06-12T17:18:43Z CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111909#comment-16111909 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/96 CB-12895 : setup eslint and removed jshint ### Platforms affected ### What does this PR do? Setup eslint and removed jshint. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-dialogs CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/96.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #96 commit 0b532b6eeb04c6adbccfea60f132f88de0c14755 Author: Audrey So Date: 2017-06-09T23:01:13Z CB-12895 : setup eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111795#comment-16111795 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-device/pull/70 CB-12895 : Setup eslint and removed jshint ### Platforms affected ### What does this PR do? Setup eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-device CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 commit 042ce62ed25d9e2fa7c5b8295a426c622ebe5654 Author: Audrey So Date: 2017-06-09T22:27:27Z CB-12895 : setup eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111654#comment-16111654 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/82 CB-12895 : Added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-media-capture CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media-capture/pull/82.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #82 commit 1694228a2cd01bdea8b15fb0d6b6f8d4dbcb091f Author: Audrey So Date: 2017-06-12T18:03:09Z CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111505#comment-16111505 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/58 CB-12895 : Added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-battery-status CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-battery-status/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit 835acc8d4daf4693d21c4be086fb06d1bdf9fc81 Author: Audrey So Date: 2017-06-09T21:41:05Z CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111426#comment-16111426 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/58 CB-12895 : added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-network-information CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit 78691e43e16d753603f41d646ca7e71b3212c282 Author: Audrey So Date: 2017-06-12T18:15:35Z CB-12895 : added eslint and removed eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111399#comment-16111399 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/59 CB-12895 : added eslint and removed jshint ### Platforms affected ### What does this PR do? ### What testing has been done on this change? Added eslint and removed jshint ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-vibration CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-vibration/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit d23d7a870ed9fcfe6df076fe1ec49d4a71780d8d Author: Audrey So Date: 2017-06-12T18:43:21Z CB-12895 : added eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109255#comment-16109255 ] ASF subversion and git services commented on CB-12895: -- Commit 37acdf6074e05a27768e02ab892782f97fedee24 in cordova-plugin-test-framework's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-test-framework.git;h=37acdf6 ] CB-12895 : replaced jshint with eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109258#comment-16109258 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/26 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109248#comment-16109248 ] ASF GitHub Bot commented on CB-12895: - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/26 Yep! LGTM > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109236#comment-16109236 ] ASF GitHub Bot commented on CB-12895: - Github user audreyso commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/26 Thanks for the review! Okay to merge @filmaj? > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109187#comment-16109187 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/26 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-test-framework CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 commit 37acdf6074e05a27768e02ab892782f97fedee24 Author: Audrey So Date: 2017-08-01T00:00:17Z CB-12895 : replaced jshint with eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108148#comment-16108148 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/41 CB-12895: replaced jshint with eslint ### Platforms affected ### What does this PR do? replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-wkwebview-engine CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/41.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #41 commit b2b121b856d0ea92fadca6cae5d8ff283c68f40f Author: Audrey So Date: 2017-06-12T18:59:35Z CB-12895 : added eslint and removed jshint commit 919dbcec374b3a7ebab0131da9870ec25cb10db2 Author: Audrey So Date: 2017-07-31T20:52:59Z CB-12895 : rebased and updated files > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105442#comment-16105442 ] ASF subversion and git services commented on CB-12895: -- Commit 17be6c6845d4adc7ab96a93364f0c83f8853cfeb in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=17be6c6 ] CB-12895 : set up eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105443#comment-16105443 ] ASF subversion and git services commented on CB-12895: -- Commit 17438d2b51b6db6f09f66c04d07a2d6b36079323 in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=17438d2 ] CB-12895 : ran eslint --fix on cordova-lib > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105445#comment-16105445 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/580 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105444#comment-16105444 ] ASF subversion and git services commented on CB-12895: -- Commit d19951b3e37239f699c4f304c0fee8407d89d9c2 in cordova-lib's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=d19951b ] CB-12895 : updated integration tests with eslint format and rebased > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104075#comment-16104075 ] ASF GitHub Bot commented on CB-12895: - Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/580 Huge PR! haha LGTM. I did a quick scan. Looks like spacing formatting for the most part. A few unused vars that you added exceptions for. Merge it > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095166#comment-16095166 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/580 CB-12895 : Replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12895-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/580.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #580 commit 4cb49cf58523d0ef8039cba6b2d3d6a7ebc260a9 Author: Audrey So Date: 2017-07-19T16:51:05Z CB-12895 : set up eslint commit 25c80f56f2697f6f359669eb8e150b208e2cd9f2 Author: Audrey So Date: 2017-07-19T16:54:49Z CB-12895 : ran eslint --fix on cordova-lib commit 55a3eccf913ac0cee11633718a11748a43e8cb88 Author: Audrey So Date: 2017-07-20T16:41:06Z CB-12895 : updated integration tests with eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091818#comment-16091818 ] ASF subversion and git services commented on CB-12895: -- Commit 54450166db4c7facc785064ee5104cad5702faa8 in cordova-common's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-common.git;h=5445016 ] CB-12895 : set up eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091815#comment-16091815 ] ASF subversion and git services commented on CB-12895: -- Commit 1119b5eb9d2f44379aa7763a35c199327f5ad99f in cordova-serve's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-serve.git;h=1119b5e ] CB-12895 : setup eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091805#comment-16091805 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-browser/pull/37 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091804#comment-16091804 ] ASF subversion and git services commented on CB-12895: -- Commit 804f37b7139772a466f56c8d8e366b183d93010d in cordova-browser's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-browser.git;h=804f37b ] CB-12895 : set up eslint and remove jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088301#comment-16088301 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/327 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088300#comment-16088300 ] ASF subversion and git services commented on CB-12895: -- Commit 83435d56d0e7e71a5bbb744cf93684b7e42997f7 in cordova-ios's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=83435d5 ] CB-12895 : removed jshint and added eslint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088281#comment-16088281 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/38 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088249#comment-16088249 ] ASF subversion and git services commented on CB-12895: -- Commit a869223824f6ee1a6fc515d4b4aaafc2d8cfba93 in cordova-windows's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=a869223 ] CB-12895 : setup eslint and removed jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088234#comment-16088234 ] ASF GitHub Bot commented on CB-12895: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/90 > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088233#comment-16088233 ] ASF subversion and git services commented on CB-12895: -- Commit 20c2f03ba55663dd3aebecb8558b8f2c36e1651f in cordova-plugman's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=20c2f03 ] CB-12895 : setup eslint and remove jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088231#comment-16088231 ] ASF subversion and git services commented on CB-12895: -- Commit b5877e51c160f5df5518151a806a6a0481137902 in cordova-create's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-create.git;h=b5877e5 ] CB-12895 : setup eslint and remove jshint > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088163#comment-16088163 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-osx/pull/38 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-osx CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-osx/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 commit 031e2c2c99af24dd3d5de3c69a369814da6a6716 Author: Audrey So Date: 2017-06-01T18:41:28Z CB-12762 : point package.json repo items to github mirrors instead of apache repos site This closes #37 commit e6ff572ccc752817f989a5e29840da134c320cba Author: Audrey So Date: 2017-07-14T18:14:04Z CB-12985 : updated to use eslint format > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088160#comment-16088160 ] ASF GitHub Bot commented on CB-12895: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/281 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-camera CB-12895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/281.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #281 commit e2a27e6679585b0e4931b68dcf0b389014d877f2 Author: Audrey So Date: 2017-06-09T21:51:30Z CB-12985 : setup eslint and removed jshint commit f6a2fec1844b00ab6f1caf3e066c13817c9b4e70 Author: Audrey So Date: 2017-07-14T21:19:05Z CB-12895 : updated src files to use eslint format > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org