[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375111#comment-16375111 ] Jan Piotrowski (Sujan) commented on CB-13543: - Is this all done and can be resolved? > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So >Priority: Major > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291366#comment-16291366 ] ASF subversion and git services commented on CB-13543: -- Commit a907fe2fd9f803f74a83d4bd2c29c92bf95dcdb1 in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=a907fe2 ] CB-13543: updated shell script and travis.yml > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273563#comment-16273563 ] ASF subversion and git services commented on CB-13543: -- Commit 4fd14a7d509dd0ad5889bf4dfb63b07b436d900c in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=4fd14a7 ] CB-13543: added shell script and check for master > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273565#comment-16273565 ] ASF subversion and git services commented on CB-13543: -- Commit 1d29c8c017fe66627838872a383093e7a842d600 in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=1d29c8c ] Merge pull request #772 from audreyso/CB-13543_travisfix CB-13543: fixing the check for travis master branch > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273564#comment-16273564 ] ASF subversion and git services commented on CB-13543: -- Commit 1d29c8c017fe66627838872a383093e7a842d600 in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=1d29c8c ] Merge pull request #772 from audreyso/CB-13543_travisfix CB-13543: fixing the check for travis master branch > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273562#comment-16273562 ] ASF GitHub Bot commented on CB-13543: - audreyso closed pull request #772: CB-13543: fixing check for travis master branch URL: https://github.com/apache/cordova-docs/pull/772 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 0a823a1d9..f378aa6d9 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,17 +7,5 @@ before_install: install: - npm install script: -- 'if [ $TRAVIS_BRANCH === "master" && $svn_pass ]; then -travis_wait 30 npm run-script build; -cd ..; -svn checkout --non-interactive --no-auth-cache --username=$svn_username --password=$svn_pass https://svn.apache.org/repos/asf/cordova/site cordova-website; -cp -R cordova-docs/build-prod/. cordova-website/public/; -cd cordova-website; -svn status | grep "?"; -svn add --force .; -svn --non-interactive --no-auth-cache --username=$svn_username --password=$svn_pass commit -m "Updated docs"; -cd ../cordova-docs; -npm test; - else -npm test; - fi' \ No newline at end of file + - chmod 755 buildAndDeploy.sh + - travis_wait 30 sleep infinity & ./buildAndDeploy.sh diff --git a/buildAndDeploy.sh b/buildAndDeploy.sh new file mode 100755 index 0..58d9a419f --- /dev/null +++ b/buildAndDeploy.sh @@ -0,0 +1,16 @@ +#!/bin/sh +if [ $svn_pass ] && [ $TRAVIS_BRANCH = "master" ] +then +npm run-script build; +cd ..; +svn checkout --non-interactive --no-auth-cache --username=$svn_username --password=$svn_pass https://svn.apache.org/repos/asf/cordova/site cordova-website; +cp -R cordova-docs/build-prod/. cordova-website/public/; +cd cordova-website || return; +svn status | grep "?"; +svn add --force .; +svn --non-interactive --no-auth-cache --username=$svn_username --password=$svn_pass commit -m "Updated docs"; +cd ../cordova-docs || return; +npm test; +else +npm test; +fi This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273560#comment-16273560 ] ASF GitHub Bot commented on CB-13543: - audreyso commented on issue #772: CB-13543: fixing check for travis master branch URL: https://github.com/apache/cordova-docs/pull/772#issuecomment-348336716 Thanks! going to merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273420#comment-16273420 ] ASF GitHub Bot commented on CB-13543: - audreyso commented on a change in pull request #772: CB-13543: fixing check for travis master branch URL: https://github.com/apache/cordova-docs/pull/772#discussion_r154200529 ## File path: .travis.yml ## @@ -7,17 +7,5 @@ before_install: install: - npm install script: -- 'if [ $TRAVIS_BRANCH === "master" && $svn_pass ]; then -travis_wait 30 npm run-script build; -cd ..; -svn checkout --non-interactive --no-auth-cache --username=$svn_username --password=$svn_pass https://svn.apache.org/repos/asf/cordova/site cordova-website; -cp -R cordova-docs/build-prod/. cordova-website/public/; -cd cordova-website; -svn status | grep "?"; -svn add --force .; -svn --non-interactive --no-auth-cache --username=$svn_username --password=$svn_pass commit -m "Updated docs"; -cd ../cordova-docs; -npm test; - else -npm test; - fi' \ No newline at end of file + - chmod 755 buildAndDeploy.sh + - travis_wait 120 sleep infinity & ./buildAndDeploy.sh Review comment: fixed! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273352#comment-16273352 ] ASF GitHub Bot commented on CB-13543: - stevengill commented on a change in pull request #772: CB-13543: fixing check for travis master branch URL: https://github.com/apache/cordova-docs/pull/772#discussion_r154190759 ## File path: .travis.yml ## @@ -7,17 +7,5 @@ before_install: install: - npm install script: -- 'if [ $TRAVIS_BRANCH === "master" && $svn_pass ]; then -travis_wait 30 npm run-script build; -cd ..; -svn checkout --non-interactive --no-auth-cache --username=$svn_username --password=$svn_pass https://svn.apache.org/repos/asf/cordova/site cordova-website; -cp -R cordova-docs/build-prod/. cordova-website/public/; -cd cordova-website; -svn status | grep "?"; -svn add --force .; -svn --non-interactive --no-auth-cache --username=$svn_username --password=$svn_pass commit -m "Updated docs"; -cd ../cordova-docs; -npm test; - else -npm test; - fi' \ No newline at end of file + - chmod 755 buildAndDeploy.sh + - travis_wait 120 sleep infinity & ./buildAndDeploy.sh Review comment: might want to change the 120 to 30 i think This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273189#comment-16273189 ] ASF GitHub Bot commented on CB-13543: - audreyso commented on issue #772: CB-13543: fixing check for travis master branch URL: https://github.com/apache/cordova-docs/pull/772#issuecomment-348287840 The only thing I wasn't sure about is if we need `#!/bin/bash` at the top of the travis.yml file. I think we only need it in the .sh file. https://docs.travis-ci.com/user/customizing-the-build/#Implementing-Complex-Build-Steps This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267370#comment-16267370 ] ASF GitHub Bot commented on CB-13543: - audreyso opened a new pull request #772: CB-13543: fixing check for travis master branch URL: https://github.com/apache/cordova-docs/pull/772 ### Platforms affected ### What does this PR do? fixing check for travis master branch ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267163#comment-16267163 ] ASF subversion and git services commented on CB-13543: -- Commit adade18b8a14d8eeb2f9d7fb95707264b83cb11f in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=adade18 ] CB-13543: updated docs to include automated steps w/ Travis > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267165#comment-16267165 ] ASF subversion and git services commented on CB-13543: -- Commit 4d290208fb1b88625d4c9428ec7bc8cf686ddfe8 in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=4d29020 ] Merge pull request #760 from audreyso/CB-13543 CB-13543 : updated instructions/documentation around travis build/dep… > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267162#comment-16267162 ] ASF GitHub Bot commented on CB-13543: - audreyso closed pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/doc/building-and-deploying-the-website.md b/doc/building-and-deploying-the-website.md new file mode 100644 index 0..571c0071d --- /dev/null +++ b/doc/building-and-deploying-the-website.md @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. + +**NOTE**: Committing to Travis might take a while (up to 1 hour), depending on the number of files changed. + +[Travis]: https://travis-ci.org/ +[eslint]: https://eslint.org/ +[mocha]: https://mochajs.org/ +[SVN]: http://svnbook.red-bean.com/en/1.7/svn.intro.quickstart.html \ No newline at end of file diff --git a/doc/developing-the-website.md b/doc/developing-the-website.md index 46f0e4e20..dbe98f734 100644 --- a/doc/developing-the-website.md +++ b/doc/developing-the-website.md @@ -13,5 +13,13 @@ Alternatively, to dynamically rebuild the site and refresh the browser _when cha node_modules/.bin/gulp watch ### Next steps +When you are done with developing, you can [build and deploy](building-and-deploying-the-website.md) using the automated steps. -When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md). \ No newline at end of file +You can also [build](building-the-website.md) and [deploy](deploying-the-website.md) manually. In case Travis build breaks, you may want to build and deploy manually. + +### Not covered by automated build and deploy +* Travis doesn't auto pull in translation changes. Read more [here](translate.md). +* Travis doesn't update latest (7.x) from dev version of docs. You will need to do this manually using `gulp snapshot`. Read more [here](https://github.com/apache/cordova-docs/blob/master/gulpfile.js#L212). +* Travis doesn't create a new version of the docs (future 8.x). Read more [here](https://github.com/apache/cordova-docs/tree/master/doc/README/en#generating-a-version-release). + +Of course, you could do all three of the above as commits. After you commit them, then Travis will do the deploy. \ No newline at end of file This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267166#comment-16267166 ] ASF subversion and git services commented on CB-13543: -- Commit 4d290208fb1b88625d4c9428ec7bc8cf686ddfe8 in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=4d29020 ] Merge pull request #760 from audreyso/CB-13543 CB-13543 : updated instructions/documentation around travis build/dep… > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267164#comment-16267164 ] ASF subversion and git services commented on CB-13543: -- Commit a763917d3a2688a0fe16268c881ac31a7342efd0 in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=a763917 ] CB-13543: updated based on feedback > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267099#comment-16267099 ] ASF GitHub Bot commented on CB-13543: - audreyso commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#issuecomment-347258427 okay great i'll merge it in. thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261708#comment-16261708 ] ASF GitHub Bot commented on CB-13543: - stevengill commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#issuecomment-346200511 Lets merge this in. Travis build + deploy looks like it isn't working properly on master since the inclusion of `TRAVIS_BRAHCN`. We can fix that up in a separate pr next week. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259626#comment-16259626 ] ASF subversion and git services commented on CB-13543: -- Commit 47db9445bb48876a144560d1cbc661f3929d55dd in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=47db944 ] Merge pull request #766 from audreyso/CB-13543_master_check CB-13543 : add check for master branch on travis > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259625#comment-16259625 ] ASF subversion and git services commented on CB-13543: -- Commit 47db9445bb48876a144560d1cbc661f3929d55dd in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=47db944 ] Merge pull request #766 from audreyso/CB-13543_master_check CB-13543 : add check for master branch on travis > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259623#comment-16259623 ] ASF subversion and git services commented on CB-13543: -- Commit fa4c00c1e0283b6886a6e469963f6b4b736fdd68 in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=fa4c00c ] CB-13543 : add check for master branch > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259621#comment-16259621 ] ASF GitHub Bot commented on CB-13543: - audreyso closed pull request #766: CB-13543 : add check for master branch on travis URL: https://github.com/apache/cordova-docs/pull/766 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index bf3367099..0a823a1d9 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,7 +7,7 @@ before_install: install: - npm install script: -- 'if [ $svn_pass ]; then +- 'if [ $TRAVIS_BRANCH === "master" && $svn_pass ]; then travis_wait 30 npm run-script build; cd ..; svn checkout --non-interactive --no-auth-cache --username=$svn_username --password=$svn_pass https://svn.apache.org/repos/asf/cordova/site cordova-website; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259451#comment-16259451 ] ASF GitHub Bot commented on CB-13543: - audreyso opened a new pull request #766: CB-13543 : add check for master branch on travis URL: https://github.com/apache/cordova-docs/pull/766 ### Platforms affected ### What does this PR do? Add check for master branch on travis ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255014#comment-16255014 ] ASF GitHub Bot commented on CB-13543: - janpio commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#issuecomment-344867258 @audreyso Last commit https://github.com/apache/cordova-docs/pull/760/commits/0c88aee30c7b574a35d26fa0b1fe52fe724dd297 looks unwanted/broken. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254087#comment-16254087 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151238364 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: @stevengill What about forks in the apache repo? I did create one of those by accident instead of forking on my user for #761 - there probably has to be a real check for `master`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254034#comment-16254034 ] ASF GitHub Bot commented on CB-13543: - stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151231646 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: Travis checks for the variable `svn_pass`. If one exists, it uses that to try and commit to svn. `svn_pass` is set as an encrypted variable on travis for github.com/apache. Encrypted variables aren't available for PRs, only master. So the deploy can only happen on master. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254016#comment-16254016 ] ASF GitHub Bot commented on CB-13543: - dblotsky commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151229142 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: @stevengill what ensures that deploy happens only on master? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254014#comment-16254014 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151228684 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: Ok, maybe this should be explain a bit here and the workflow clarified? You fork, commit your changes to your fork, wait for the test result via Travis. If green, you can send the PR which will trigger Travis again. If (green and) merged, it will trigger a deploy. Correct? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254012#comment-16254012 ] ASF GitHub Bot commented on CB-13543: - dblotsky commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#issuecomment-344702130 @audreyso yep, the question about infra still remains open. Are Apache Infra OK with us having SVN credentials in Travis? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253993#comment-16253993 ] ASF GitHub Bot commented on CB-13543: - stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r151225869 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: yes. Tests will run on branches/prs. Deploy only happens on master This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252523#comment-16252523 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150976912 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: Ok, thought about that a bit. I assume now Travis works on all repos where it has access (so branches and also my forks with its branches) if a `travis.yml` exists, which it does. So Travis can be used both for branches and forks to see if the tests pass, and on `master` to do the same and also automatically deploy. Did I get this right? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252511#comment-16252511 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150976912 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: Ok, thought about that a bit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252120#comment-16252120 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950467 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: > When Travis is done building and deploying, send a pull request and ask for a review. Huh wait. Does Travis also work on my fork? I thought only on `master`. I am confused now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252114#comment-16252114 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950467 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: > When Travis is done building and deploying, send a pull request and ask for a review. Huh wait. Does Travis also work on my Fork? I thought only on `master`. I am confused now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252113#comment-16252113 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950467 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: > When Travis is done building and deploying, send a pull request and ask for a review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252111#comment-16252111 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950232 ## File path: doc/developing-the-website.md ## @@ -13,5 +13,14 @@ Alternatively, to dynamically rebuild the site and refresh the browser _when cha node_modules/.bin/gulp watch ### Next steps +When you are done with developing, you can [build and deploy](building-and-deploying-the-website.md) using the automated steps. -When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md). \ No newline at end of file +You can also [build](building-the-website.md) and [deploy](deploying-the-website.md) manually. In case Travis build breaks, you may want to build and deploy manually. + +Here are a few use cases that Travis auto build and deploy doesn't cover: Review comment: Are these "developnig the website" tasks? Could move this over to `building-and-deploying-the-website.md` in a new subheadline "Not covered by automated build and deploy" (or similar) if not... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252109#comment-16252109 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950232 ## File path: doc/developing-the-website.md ## @@ -13,5 +13,14 @@ Alternatively, to dynamically rebuild the site and refresh the browser _when cha node_modules/.bin/gulp watch ### Next steps +When you are done with developing, you can [build and deploy](building-and-deploying-the-website.md) using the automated steps. -When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md). \ No newline at end of file +You can also [build](building-the-website.md) and [deploy](deploying-the-website.md) manually. In case Travis build breaks, you may want to build and deploy manually. + +Here are a few use cases that Travis auto build and deploy doesn't cover: Review comment: Are these "developnig the website" tasks?I suggest to move this over to `building-and-deploying-the-website.md` in a new subheadline "Not covered by automated build and deploy" (or similar). Here this is a This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252101#comment-16252101 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150949639 ## File path: doc/developing-the-website.md ## @@ -14,4 +14,8 @@ Alternatively, to dynamically rebuild the site and refresh the browser _when cha ### Next steps -When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md). \ No newline at end of file +When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md) manually. + +OR Review comment: Got it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252097#comment-16252097 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150949639 ## File path: doc/developing-the-website.md ## @@ -14,4 +14,8 @@ Alternatively, to dynamically rebuild the site and refresh the browser _when cha ### Next steps -When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md). \ No newline at end of file +When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md) manually. + +OR Review comment: Got it. 1,2,3 should definitely be added to the autmated deploy documentation then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251999#comment-16251999 ] ASF GitHub Bot commented on CB-13543: - audreyso commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#issuecomment-344366275 Thanks for your feedback @stevengill @dblotsky @janpio ... made a few updates. Let me know if there's anything else! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251861#comment-16251861 ] ASF GitHub Bot commented on CB-13543: - stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150916965 ## File path: doc/developing-the-website.md ## @@ -14,4 +14,8 @@ Alternatively, to dynamically rebuild the site and refresh the browser _when cha ### Next steps -When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md). \ No newline at end of file +When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md) manually. + +OR Review comment: You can! Incase travis builds break you may want to build + deploy manually. A few usecases that this travis auto build + deploy doesn't cover 1) Doesn't auto pull in translation changes 2) Doesn't update latest (7.x) from dev version of docs. Need to do this manually 3) Doesn't create a new version of the docs (future 8.x). Of course, you could do all 3 as commits and commit them and then travis will do the deploy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251214#comment-16251214 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150795138 ## File path: doc/developing-the-website.md ## @@ -14,4 +14,8 @@ Alternatively, to dynamically rebuild the site and refresh the browser _when cha ### Next steps -When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md). \ No newline at end of file +When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md) manually. + +OR Review comment: Is the manual deploy still an option at all? If Travis builds on every commit, you can't really deploy manually any more, right? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251213#comment-16251213 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150795285 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,22 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. + +Lastly, Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: Why the seperate "Testing" paragraph if Travis automatically runs the tests? Is this a safeguard somehow? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251215#comment-16251215 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150795585 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,22 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. Review comment: Maybe add some information how Travis is setup and configured (after the first sentence maybe?). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251216#comment-16251216 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150795585 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,22 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. Review comment: Maybe add some information how Travis is setup and configured (after the first sentence maybe?). This paragraph could also link to the old, manual steps to document what exactly happens under the hood (with SVN). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250878#comment-16250878 ] ASF GitHub Bot commented on CB-13543: - stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150739381 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,22 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. Review comment: Right now it is using my creds. The password is stored as an encrypted variable on travis. We haven't chatted with Infra yet. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250754#comment-16250754 ] ASF GitHub Bot commented on CB-13543: - dblotsky commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150727825 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,22 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test Review comment: You probably also want to run `gulp build` locally before committing, or have `npm test` run it for you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250753#comment-16250753 ] ASF GitHub Bot commented on CB-13543: - dblotsky commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150728151 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,22 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. Review comment: Whose SVN account is on Travis, and is it ok with infra that it's there? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250750#comment-16250750 ] ASF GitHub Bot commented on CB-13543: - dblotsky commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#issuecomment-344132720 @janpio @stevengill is Infra ok with an SVN password being on Travis? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250380#comment-16250380 ] ASF GitHub Bot commented on CB-13543: - audreyso opened a new pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760 …loy changes ### Platforms affected ### What does this PR do? Updated instructions/documentation around travis build/deploy ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246841#comment-16246841 ] ASF subversion and git services commented on CB-13543: -- Commit 2ea959eeb4a28fcc41091035306d2c773f03d586 in cordova-docs's branch refs/heads/master from [~auso] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=2ea959e ] CB-13543 : adding travis file to build and deploy docs > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Update README.md > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
