[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050976#comment-14050976 ] ASF subversion and git services commented on CB-6357: - Commit a18029fe893a14416be78eaf2d2a3ac8c20c3016 in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=a18029f ] CB-6357 (fix latent bug) platform check should install each platform to determine if they're functional and their version number --- Key: CB-6357 URL: https://issues.apache.org/jira/browse/CB-6357 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently `cordova platform check` has a few behaviors which are not necessarily ideal: 1. It relies on the platforms.js file to have valid versions which match what is actually in the cached ~/.cordova/lib space. 2. If a platform is installed for which there's a newer version which won't install (e.g. you're on Windows and you have iOS installed), it could tell you that there's an upgrade available, however, you won't be able to install it. We'd like to fix these limitations by having platform check actually run the version script against a live project. This should mean that there will not be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949995#comment-13949995 ] ASF subversion and git services commented on CB-6357: - Commit 4bc9e7017d61a5c3e02ba7a2d2037a5e4f21e38c in cordova-cli's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=4bc9e70 ] CB-6357 platform check - install each platform to determine working + version number platform check should install each platform to determine if they're functional and their version number --- Key: CB-6357 URL: https://issues.apache.org/jira/browse/CB-6357 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently `cordova platform check` has a few behaviors which are not necessarily ideal: 1. It relies on the platforms.js file to have valid versions which match what is actually in the cached ~/.cordova/lib space. 2. If a platform is installed for which there's a newer version which won't install (e.g. you're on Windows and you have iOS installed), it could tell you that there's an upgrade available, however, you won't be able to install it. We'd like to fix these limitations by having platform check actually run the version script against a live project. This should mean that there will not be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950002#comment-13950002 ] ASF GitHub Bot commented on CB-6357: Github user stevengill commented on the pull request: https://github.com/apache/cordova-cli/pull/153#issuecomment-38866049 I've merged this in. Hopefully this gets closed in a few minutes by asf script platform check should install each platform to determine if they're functional and their version number --- Key: CB-6357 URL: https://issues.apache.org/jira/browse/CB-6357 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently `cordova platform check` has a few behaviors which are not necessarily ideal: 1. It relies on the platforms.js file to have valid versions which match what is actually in the cached ~/.cordova/lib space. 2. If a platform is installed for which there's a newer version which won't install (e.g. you're on Windows and you have iOS installed), it could tell you that there's an upgrade available, however, you won't be able to install it. We'd like to fix these limitations by having platform check actually run the version script against a live project. This should mean that there will not be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949996#comment-13949996 ] ASF subversion and git services commented on CB-6357: - Commit 69856ced27c10a89c82392b3226e84976cfaf73f in cordova-cli's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=69856ce ] CB-6357 platform check: sort output platform check should install each platform to determine if they're functional and their version number --- Key: CB-6357 URL: https://issues.apache.org/jira/browse/CB-6357 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently `cordova platform check` has a few behaviors which are not necessarily ideal: 1. It relies on the platforms.js file to have valid versions which match what is actually in the cached ~/.cordova/lib space. 2. If a platform is installed for which there's a newer version which won't install (e.g. you're on Windows and you have iOS installed), it could tell you that there's an upgrade available, however, you won't be able to install it. We'd like to fix these limitations by having platform check actually run the version script against a live project. This should mean that there will not be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1394#comment-1394 ] ASF subversion and git services commented on CB-6357: - Commit 22e5826a3c780f2b6cfcd4dfc6cf624e1073a2be in cordova-cli's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=22e5826 ] CB-6357 minor style changes platform check should install each platform to determine if they're functional and their version number --- Key: CB-6357 URL: https://issues.apache.org/jira/browse/CB-6357 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently `cordova platform check` has a few behaviors which are not necessarily ideal: 1. It relies on the platforms.js file to have valid versions which match what is actually in the cached ~/.cordova/lib space. 2. If a platform is installed for which there's a newer version which won't install (e.g. you're on Windows and you have iOS installed), it could tell you that there's an upgrade available, however, you won't be able to install it. We'd like to fix these limitations by having platform check actually run the version script against a live project. This should mean that there will not be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949998#comment-13949998 ] ASF subversion and git services commented on CB-6357: - Commit bdb34e6b9a430536e1b4777f271349175f890491 in cordova-cli's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=bdb34e6 ] CB-6357 platform: fix indentation platform check should install each platform to determine if they're functional and their version number --- Key: CB-6357 URL: https://issues.apache.org/jira/browse/CB-6357 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently `cordova platform check` has a few behaviors which are not necessarily ideal: 1. It relies on the platforms.js file to have valid versions which match what is actually in the cached ~/.cordova/lib space. 2. If a platform is installed for which there's a newer version which won't install (e.g. you're on Windows and you have iOS installed), it could tell you that there's an upgrade available, however, you won't be able to install it. We'd like to fix these limitations by having platform check actually run the version script against a live project. This should mean that there will not be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950008#comment-13950008 ] ASF GitHub Bot commented on CB-6357: Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/153 platform check should install each platform to determine if they're functional and their version number --- Key: CB-6357 URL: https://issues.apache.org/jira/browse/CB-6357 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently `cordova platform check` has a few behaviors which are not necessarily ideal: 1. It relies on the platforms.js file to have valid versions which match what is actually in the cached ~/.cordova/lib space. 2. If a platform is installed for which there's a newer version which won't install (e.g. you're on Windows and you have iOS installed), it could tell you that there's an upgrade available, however, you won't be able to install it. We'd like to fix these limitations by having platform check actually run the version script against a live project. This should mean that there will not be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948764#comment-13948764 ] ASF GitHub Bot commented on CB-6357: GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/153 CB-6357 platform check - install each platform to determine working + version number The other changesets (Refactor, exports, silence output, sort output, fix indentation) are split because it's a lot easier to understand things individually. The evolution here is partially w/ an eye to eventually have these functions be usable by other entities too. You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry/cordova-cli cb_6357 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/153.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #153 commit b5d8ce7915e3875d427acb1583cb46fd046f238e Author: Josh Soref jso...@blackberry.com Date: 2014-03-24T21:29:57Z CB-6357 platform: Refactor into distinct functions commit bca4b6fef31364cbb4d8977a52881316a30321b9 Author: Josh Soref jso...@blackberry.com Date: 2014-03-24T21:30:46Z CB-6357 platform: provide exports for functions commit 5911893d8f29e0d8341583c075b8152d359e428b Author: Josh Soref jso...@blackberry.com Date: 2014-03-27T01:49:03Z CB-6357 call_into_create: support no output commit a67a478ec7dcff6c93bcf1c42d30e3d6653cd00b Author: Josh Soref jso...@blackberry.com Date: 2014-03-26T14:43:21Z CB-6357 platform check - install each platform to determine working + version number commit 66cb9612a98df47d82ce6bc123be3ce4fca855a3 Author: Josh Soref jso...@blackberry.com Date: 2014-03-27T01:55:14Z CB-6357 platform check: sort output commit 6000ba91151a2ef1bc465b97f6e8fda20e660b45 Author: Josh Soref jso...@blackberry.com Date: 2014-03-27T01:56:44Z CB-6357 platform: fix indentation platform check should install each platform to determine if they're functional and their version number --- Key: CB-6357 URL: https://issues.apache.org/jira/browse/CB-6357 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently `cordova platform check` has a few behaviors which are not necessarily ideal: 1. It relies on the platforms.js file to have valid versions which match what is actually in the cached ~/.cordova/lib space. 2. If a platform is installed for which there's a newer version which won't install (e.g. you're on Windows and you have iOS installed), it could tell you that there's an upgrade available, however, you won't be able to install it. We'd like to fix these limitations by having platform check actually run the version script against a live project. This should mean that there will not be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948767#comment-13948767 ] ASF GitHub Bot commented on CB-6357: Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/153#issuecomment-38762210 Sigh, and now i need to deal w/ `npm test` platform check should install each platform to determine if they're functional and their version number --- Key: CB-6357 URL: https://issues.apache.org/jira/browse/CB-6357 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently `cordova platform check` has a few behaviors which are not necessarily ideal: 1. It relies on the platforms.js file to have valid versions which match what is actually in the cached ~/.cordova/lib space. 2. If a platform is installed for which there's a newer version which won't install (e.g. you're on Windows and you have iOS installed), it could tell you that there's an upgrade available, however, you won't be able to install it. We'd like to fix these limitations by having platform check actually run the version script against a live project. This should mean that there will not be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948860#comment-13948860 ] ASF GitHub Bot commented on CB-6357: Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/153#issuecomment-38767269 ok, with #150 applied, this set of changes applies cleanly and doesn't introduce any new `npm test` failures. platform check should install each platform to determine if they're functional and their version number --- Key: CB-6357 URL: https://issues.apache.org/jira/browse/CB-6357 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently `cordova platform check` has a few behaviors which are not necessarily ideal: 1. It relies on the platforms.js file to have valid versions which match what is actually in the cached ~/.cordova/lib space. 2. If a platform is installed for which there's a newer version which won't install (e.g. you're on Windows and you have iOS installed), it could tell you that there's an upgrade available, however, you won't be able to install it. We'd like to fix these limitations by having platform check actually run the version script against a live project. This should mean that there will not be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
