[jira] [Commented] (CB-6396) inappbrowser
[ https://issues.apache.org/jira/browse/CB-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018735#comment-14018735 ] ASF GitHub Bot commented on CB-6396: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/47 > inappbrowser > > > Key: CB-6396 > URL: https://issues.apache.org/jira/browse/CB-6396 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin InAppBrowser >Affects Versions: 3.6.0 >Reporter: Piotr Zalewa >Assignee: Piotr Zalewa > > Add InAppBrowser for firefoxos -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6396) inappbrowser
[
https://issues.apache.org/jira/browse/CB-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017935#comment-14017935
]
ASF GitHub Bot commented on CB-6396:
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/47#discussion_r13400634
--- Diff: doc/index.md ---
@@ -99,6 +100,39 @@ instance, or the system browser.
var ref = window.open('http://apache.org', '_blank', 'location=yes');
var ref2 =
window.open(encodeURI('http://ja.m.wikipedia.org/wiki/ハングル'), '_blank',
'location=yes');
+### Firefox OS Quirks
+
+As plugin doesn't enforce any design there is a need to add some CSS rules
if
+opened with `target` `'_blank'`. The rules might look like these
+
+``` css
+.inAppBrowserWrap {
+ background-color: rgba(0,0,0,0.75);
+ color: rgba(235,235,235,1.0);
+}
+.inAppBrowserWrap menu {
+ overflow: auto;
+ list-style-type: none;
+ padding-left: 0;
+}
+.inAppBrowserWrap menu li {
+ font-size: 25px;
+ height: 25px;
+ float: left;
+ margin-right: 0px;
--- End diff --
You're overwriting the right margin with the property below. Either remove
or change the `margin` below accordingly.
> inappbrowser
>
>
> Key: CB-6396
> URL: https://issues.apache.org/jira/browse/CB-6396
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Plugin InAppBrowser
>Affects Versions: 3.6.0
>Reporter: Piotr Zalewa
>Assignee: Piotr Zalewa
>
> Add InAppBrowser for firefoxos
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6396) inappbrowser
[
https://issues.apache.org/jira/browse/CB-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017927#comment-14017927
]
ASF GitHub Bot commented on CB-6396:
Github user zalun commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/47#discussion_r13400172
--- Diff: src/firefoxos/InAppBrowserProxy.js ---
@@ -47,10 +47,34 @@ var IABExecs = {
open: function (win, lose, args) {
var strUrl = args[0],
target = args[1],
-features = args[2],
+features_string = args[2],
+features = {},
url,
elem;
+var features_list = features_string.split(',');
+features_list.forEach(function(feature) {
+var tup = feature.split('=');
+if (tup[1] == 'yes') {
+tup[1] = true;
+} else if (tup[1] == 'no') {
+tup[1] = false;
+} else {
+var number = parseInt(tup[1]);
+if (!isNaN(number)) {
+tup[1] = number;
+}
+}
+features[tup[0]] = tup[1];
+});
+
+function updateIframeSizeNoLocation() {
+browserWrap.style.width = window.innerWidth + 'px';
+browserWrap.style.height = window.innerHeight + 'px';
+browserWrap.browser.style.height = (window.innerHeight - 60) +
'px';
--- End diff --
Yes
> inappbrowser
>
>
> Key: CB-6396
> URL: https://issues.apache.org/jira/browse/CB-6396
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Plugin InAppBrowser
>Affects Versions: 3.6.0
>Reporter: Piotr Zalewa
>Assignee: Piotr Zalewa
>
> Add InAppBrowser for firefoxos
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6396) inappbrowser
[
https://issues.apache.org/jira/browse/CB-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017926#comment-14017926
]
ASF GitHub Bot commented on CB-6396:
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/47#discussion_r13400162
--- Diff: src/firefoxos/InAppBrowserProxy.js ---
@@ -47,10 +47,34 @@ var IABExecs = {
open: function (win, lose, args) {
var strUrl = args[0],
target = args[1],
-features = args[2],
+features_string = args[2],
+features = {},
url,
elem;
+var features_list = features_string.split(',');
+features_list.forEach(function(feature) {
+var tup = feature.split('=');
+if (tup[1] == 'yes') {
+tup[1] = true;
+} else if (tup[1] == 'no') {
+tup[1] = false;
+} else {
+var number = parseInt(tup[1]);
+if (!isNaN(number)) {
+tup[1] = number;
+}
+}
+features[tup[0]] = tup[1];
+});
+
+function updateIframeSizeNoLocation() {
+browserWrap.style.width = window.innerWidth + 'px';
+browserWrap.style.height = window.innerHeight + 'px';
+browserWrap.browser.style.height = (window.innerHeight - 60) +
'px';
--- End diff --
What is the `60` here? Is it url bar size?
> inappbrowser
>
>
> Key: CB-6396
> URL: https://issues.apache.org/jira/browse/CB-6396
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Plugin InAppBrowser
>Affects Versions: 3.6.0
>Reporter: Piotr Zalewa
>Assignee: Piotr Zalewa
>
> Add InAppBrowser for firefoxos
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6396) inappbrowser
[
https://issues.apache.org/jira/browse/CB-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017919#comment-14017919
]
ASF GitHub Bot commented on CB-6396:
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/47#discussion_r13399892
--- Diff: doc/index.md ---
@@ -99,6 +100,39 @@ instance, or the system browser.
var ref = window.open('http://apache.org', '_blank', 'location=yes');
var ref2 =
window.open(encodeURI('http://ja.m.wikipedia.org/wiki/ハングル'), '_blank',
'location=yes');
+### Firefox OS Quirks
+
+As plugin doesn't enforce any design there is a need to add some CSS rules
if
+opened with `target` `'_blank'`. The rules might look like these
--- End diff --
nit: `target` and `_blank` could be in a single block like:
`target='_blank' `
> inappbrowser
>
>
> Key: CB-6396
> URL: https://issues.apache.org/jira/browse/CB-6396
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Plugin InAppBrowser
>Affects Versions: 3.6.0
>Reporter: Piotr Zalewa
>Assignee: Piotr Zalewa
>
> Add InAppBrowser for firefoxos
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6396) inappbrowser
[ https://issues.apache.org/jira/browse/CB-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017689#comment-14017689 ] ASF GitHub Bot commented on CB-6396: GitHub user zalun opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/47 CB-6396 Menu added You can merge this pull request into a Git repository by running: $ git pull https://github.com/zalun/cordova-plugin-inappbrowser react_on_features Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/47.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #47 commit 282fdb7a400176c8b89fa85a5a7148f7d229b021 Author: Piotr Zalewa Date: 2014-04-24T14:51:06Z not forcing the look of the inAppBrowserWrap and buttons commit 7b24dcb3ddf86bb3dd4423ed7d0904aa786abe03 Author: Piotr Zalewa Date: 2014-04-24T18:14:41Z back/forward buttons added, iframe has no border commit a6cd0a16ba034cda28c93dafa01c45929bef8eb1 Author: Piotr Zalewa Date: 2014-04-24T19:01:09Z console.log removed commit 527046261134c15007a6c3268e0789d1edce5cbc Author: Piotr Zalewa Date: 2014-04-24T19:03:33Z doc updated > inappbrowser > > > Key: CB-6396 > URL: https://issues.apache.org/jira/browse/CB-6396 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin InAppBrowser >Affects Versions: 3.6.0 >Reporter: Piotr Zalewa >Assignee: Piotr Zalewa > > Add InAppBrowser for firefoxos -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6396) inappbrowser
[ https://issues.apache.org/jira/browse/CB-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017684#comment-14017684 ] ASF GitHub Bot commented on CB-6396: Github user zalun closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/35 > inappbrowser > > > Key: CB-6396 > URL: https://issues.apache.org/jira/browse/CB-6396 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin InAppBrowser >Affects Versions: 3.6.0 >Reporter: Piotr Zalewa >Assignee: Piotr Zalewa > > Add InAppBrowser for firefoxos -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6396) inappbrowser
[ https://issues.apache.org/jira/browse/CB-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017683#comment-14017683 ] ASF GitHub Bot commented on CB-6396: Github user zalun commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/35#issuecomment-45089654 old pull request > inappbrowser > > > Key: CB-6396 > URL: https://issues.apache.org/jira/browse/CB-6396 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin InAppBrowser >Affects Versions: 3.6.0 >Reporter: Piotr Zalewa >Assignee: Piotr Zalewa > > Add InAppBrowser for firefoxos -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6396) inappbrowser
[ https://issues.apache.org/jira/browse/CB-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981537#comment-13981537 ] ASF subversion and git services commented on CB-6396: - Commit cc5b0ce5a38105b21703b245c890ebe277f8752a in cordova-plugin-inappbrowser's branch refs/heads/master from [~zalun] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=cc5b0ce ] Merge pull request #2 from zalun/close-button-fix CB-6396 Fix refactoring typo > inappbrowser > > > Key: CB-6396 > URL: https://issues.apache.org/jira/browse/CB-6396 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin InAppBrowser >Affects Versions: 3.6.0 >Reporter: Piotr Zalewa > > Add InAppBrowser for firefoxos -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6396) inappbrowser
[ https://issues.apache.org/jira/browse/CB-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981536#comment-13981536 ] ASF subversion and git services commented on CB-6396: - Commit c14871da953e399eec1cffe27fe750041df8c683 in cordova-plugin-inappbrowser's branch refs/heads/master from [~Steckelfisch] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=c14871d ] Merge pull request #1 from zalun/add-firefoxos-plugin CB-6396 [Firefox OS] Adding basic support > inappbrowser > > > Key: CB-6396 > URL: https://issues.apache.org/jira/browse/CB-6396 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin InAppBrowser >Affects Versions: 3.6.0 >Reporter: Piotr Zalewa > > Add InAppBrowser for firefoxos -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6396) inappbrowser
[ https://issues.apache.org/jira/browse/CB-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981535#comment-13981535 ] ASF subversion and git services commented on CB-6396: - Commit 51879d8e2f2a9b9209022774ada265164abdc620 in cordova-plugin-inappbrowser's branch refs/heads/master from [~zalun] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=51879d8 ] CB-6396 [Firefox OS] Adding basic support > inappbrowser > > > Key: CB-6396 > URL: https://issues.apache.org/jira/browse/CB-6396 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin InAppBrowser >Affects Versions: 3.6.0 >Reporter: Piotr Zalewa > > Add InAppBrowser for firefoxos -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6396) inappbrowser
[ https://issues.apache.org/jira/browse/CB-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961908#comment-13961908 ] ASF GitHub Bot commented on CB-6396: GitHub user zalun opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/35 CB-6396 [Firefox OS] Adding basic support You can merge this pull request into a Git repository by running: $ git pull https://github.com/mozilla-cordova/cordova-plugin-inappbrowser dev Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/35.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #35 commit 51879d8e2f2a9b9209022774ada265164abdc620 Author: Piotr Zalewa Date: 2014-04-04T10:16:01Z CB-6396 [Firefox OS] Adding basic support commit c14871da953e399eec1cffe27fe750041df8c683 Author: Gert-Jan Braas Date: 2014-04-07T15:06:54Z Merge pull request #1 from zalun/add-firefoxos-plugin CB-6396 [Firefox OS] Adding basic support > inappbrowser > > > Key: CB-6396 > URL: https://issues.apache.org/jira/browse/CB-6396 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin InAppBrowser >Affects Versions: 3.6.0 >Reporter: Piotr Zalewa > > Add InAppBrowser for firefoxos -- This message was sent by Atlassian JIRA (v6.2#6252)
