[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2017-03-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939770#comment-15939770
 ] 

ASF GitHub Bot commented on CB-9371:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/260


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>Assignee: Shazron Abdullah
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2017-03-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905990#comment-15905990
 ] 

ASF GitHub Bot commented on CB-9371:


Github user shazron commented on the issue:

https://github.com/apache/cordova-lib/pull/260
  
I think we can close this since its already in the Platform API for 
cordova-ios, and users will have to upgrade if they want this fix for 
cordova-ios < 4.


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>Assignee: Shazron Abdullah
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2017-03-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904195#comment-15904195
 ] 

ASF GitHub Bot commented on CB-9371:


Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/260
  
I believe we are deleting ios_parser.js for cordova@7 since that 
functionality has all been moved into  cordova-ios platform now. This would 
only be useful for older versions of cordova-ios (pre-API.js) now and we are 
dropping support for those older versions in cordova-7. I think this PR can be 
closed.

Thoughts @shazron?


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>Assignee: Shazron Abdullah
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2016-07-26 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394883#comment-15394883
 ] 

ASF subversion and git services commented on CB-9371:
-

Commit c17ed6fdc39c61d83985433221e822592f8fbf69 in cordova-ios's branch 
refs/heads/4.2.x from [~cjpearson]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=c17ed6f ]

CB-9371: Fix how prepare handles orientation on ios

Update unit tests. This closes #233

Signed-off-by: Shazron Abdullah 


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>Assignee: Shazron Abdullah
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2016-07-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359554#comment-15359554
 ] 

ASF GitHub Bot commented on CB-9371:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/233


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>Assignee: Shazron Abdullah
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2016-07-01 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359553#comment-15359553
 ] 

ASF subversion and git services commented on CB-9371:
-

Commit 5c3885b807f4c9556bf350c72400827a333f78d3 in cordova-ios's branch 
refs/heads/master from [~cjpearson]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=5c3885b ]

CB-9371: Fix how prepare handles orientation on ios

Update unit tests. This closes #233

Signed-off-by: Shazron Abdullah 


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>Assignee: Shazron Abdullah
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2016-07-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359543#comment-15359543
 ] 

ASF GitHub Bot commented on CB-9371:


Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/233
  
Confirmed that Xcode uses the new defaults. Pulling this in and testing.


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>Assignee: Shazron Abdullah
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2016-06-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358201#comment-15358201
 ] 

ASF GitHub Bot commented on CB-9371:


Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/233
  
## [Current coverage][cc-pull] is **51.81%**
> Merging [#233][cc-pull] into [master][cc-base-branch] will not change 
coverage

```diff
@@ master   #233   diff @@
==
  Files11 11  
  Lines   882882  
  Methods 132132  
  Messages  0  0  
  Branches143143  
==
  Hits457457  
  Misses  425425  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[3d80c24...4d792db][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-ios/compare/3d80c24a594b4d43a368fa278a23218a3f17310f...4d792dba84a23866b2ab1850e49a921bacf82ba0
[cc-pull]: https://codecov.io/gh/apache/cordova-ios/pull/233?src=pr


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>Assignee: Shazron Abdullah
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2016-06-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358197#comment-15358197
 ] 

ASF GitHub Bot commented on CB-9371:


Github user cjpearson commented on the issue:

https://github.com/apache/cordova-lib/pull/260
  
Thanks, @shazron. I've rebased this pr and opened a new one here 
https://github.com/apache/cordova-ios/pull/233


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>Assignee: Shazron Abdullah
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2016-06-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358181#comment-15358181
 ] 

ASF GitHub Bot commented on CB-9371:


Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/260
  
## [Current coverage][cc-pull] is **80.58%**
> Merging [#260][cc-pull] into [master][cc-base-branch] will decrease 
coverage by **0.01%**

```diff
@@ master   #260   diff @@
==
  Files68 68  
  Lines  5380   5377 -3   
  Methods 851851  
  Messages  0  0  
  Branches   1038   1038  
==
- Hits   4336   4333 -3   
  Misses 1044   1044  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[e810685...e9261e4][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-lib/compare/e810685ce42a6615d62117f026316c9931ad8707...e9261e4cf2a9db0820f9a7667d8639c4bbb47fd8
[cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/260?src=pr


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>Assignee: Shazron Abdullah
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2016-06-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358111#comment-15358111
 ] 

ASF GitHub Bot commented on CB-9371:


GitHub user cjpearson opened a pull request:

https://github.com/apache/cordova-ios/pull/233

CB-9371, CB-9703: Fix how prepare handles orientation on ios

Relates to https://github.com/apache/cordova-lib/pull/260

This changes the behavior of the default orientation preference to match 
the default orientation settings for new native iOS projects.

It also no longer modifies the orientation settings if the user does not 
specify an orientation preference.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cjpearson/cordova-ios CB-9371

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/233.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #233


commit 55b0a26fb2ba4186273d98fb3adcee205b2fb632
Author: Connor Pearson 
Date:   2016-07-01T00:27:12Z

CB-9371: Fix how prepare handles orientation on ios




> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>Assignee: Shazron Abdullah
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2016-06-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347111#comment-15347111
 ] 

ASF GitHub Bot commented on CB-9371:


Github user shazron commented on the issue:

https://github.com/apache/cordova-lib/pull/260
  
@cjpearson unfortunately this patch can't be applied since the code has 
changed. Can you re-work it based on the master code? Also, the code you are 
trying to patch is the default fallback if a platform does not conform to the 
Platform API (older platforms). For newer platforms that do, like 
cordova-ios@4.x, they have their own Platform API implementations -- so the 
corresponding code would exist here: 
https://github.com/apache/cordova-ios/blob/08e00b68efbf2bfee21866f0bedd9c01ee8255e5/bin/templates/scripts/cordova/lib/prepare.js#L252-L275


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2016-06-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335900#comment-15335900
 ] 

ASF GitHub Bot commented on CB-9371:


Github user cjpearson commented on the issue:

https://github.com/apache/cordova-lib/pull/260
  
@shazron, could you please take a look at this PR?


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2016-06-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335840#comment-15335840
 ] 

ASF GitHub Bot commented on CB-9371:


Github user mattrayner commented on the issue:

https://github.com/apache/cordova-lib/pull/260
  
I'm guessing there's no news on this?


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2015-12-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071197#comment-15071197
 ] 

ASF GitHub Bot commented on CB-9371:


Github user chrskrchr commented on the pull request:

https://github.com/apache/cordova-lib/pull/260#issuecomment-167151080
  
Agreed - this is a useful change.  I want to be able to specify different 
orientation settings for iPhone vs. iPad at the Xcode project level, and this 
change would allow me to do that without Cordova clobbering my project-level 
settings.


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2015-09-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906999#comment-14906999
 ] 

ASF GitHub Bot commented on CB-9371:


Github user christoph-neumann commented on the pull request:

https://github.com/apache/cordova-lib/pull/260#issuecomment-143048429
  
This is a needed fix! Why has this not been merged?


> Prepare deletes orientation preferences
> ---
>
> Key: CB-9371
> URL: https://issues.apache.org/jira/browse/CB-9371
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.1.1
>Reporter: Connor Pearson
>
> If a user does not have a orientation preference defined in config.xml then 
> running prepare will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation 
> preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9371) Prepare deletes orientation preferences

2015-07-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628229#comment-14628229
 ] 

ASF GitHub Bot commented on CB-9371:


GitHub user cjpearson opened a pull request:

https://github.com/apache/cordova-lib/pull/260

CB-9371: Don't delete orientation preferences by default



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cjpearson/cordova-lib orientation-bug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/260.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #260


commit a3c86157dd5354db26ba18eabc40cb8eaa8e0351
Author: Connor Pearson cjp...@gmail.com
Date:   2015-07-15T15:06:09Z

Don't delete orientation preferences by default




 Prepare deletes orientation preferences
 ---

 Key: CB-9371
 URL: https://issues.apache.org/jira/browse/CB-9371
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaLib
Affects Versions: 5.1.1
Reporter: Connor Pearson

 If a user does not have a orientation preference defined in config.xml then 
 running prepare will delete all orientation preferences in their info.plist.
 I'd expect prepare to overwrite the values if the user chose an orientation 
 preferences, otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org