[jira] [Commented] (DRILL-6817) Update to_number function to be consistent with CAST function
[
https://issues.apache.org/jira/browse/DRILL-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692760#comment-16692760
]
Bohdan Kazydub commented on DRILL-6817:
---
[~vvysotskyi], yes it was fixed in the scope of DRILL-6768. Marked this one as
resolved.
Thank you for pointing this out.
> Update to_number function to be consistent with CAST function
> -
>
> Key: DRILL-6817
> URL: https://issues.apache.org/jira/browse/DRILL-6817
> Project: Apache Drill
> Issue Type: Improvement
>Reporter: Bohdan Kazydub
>Assignee: Bohdan Kazydub
>Priority: Major
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> {{In case when `drill.exec.functions.cast_empty_string_to_null` is enabled
> casting empty string ('') to numeric types will return NULL. If `to_number`
> is used to convert empty string to a number, UnsupportedOperationException
> will be thrown.}}
> The aim is to make these functions (CASTs and `to_number`) work consistently
> as is done for date/time functions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6861) Hash-Join: Spilled partitions are skipped following an empty probe side
[
https://issues.apache.org/jira/browse/DRILL-6861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692603#comment-16692603
]
ASF GitHub Bot commented on DRILL-6861:
---
Ben-Zvi opened a new pull request #1546: DRILL-6861: Hash-Join should not exit
after an empty probe-side spilled partition
URL: https://github.com/apache/drill/pull/1546
(The DIFF below is excessive due to indentation; but only two "lines" where
actually changed).
The original code below handles the spilled partitions by getting the next
one (as build+probe "incoming"), and then recursively calling *innerNext()*.
Each recursive call would end by (recursively) processing the next spilled
partition.
The DRILL-6755 change (line 556) caused an early exit when the probe side
was empty. Thus in special cases when a probe-side of a spilled partition was
empty, this change would terminate the recursive chain early, thus not
processing the remaining partitions.
The fix: When an empty probe-side spilled partition is seen - skip and
process the next partition. A new check was added (line 624), and the code was
altered into a "while" loop (line 618) to allow skipping.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Hash-Join: Spilled partitions are skipped following an empty probe side
> ---
>
> Key: DRILL-6861
> URL: https://issues.apache.org/jira/browse/DRILL-6861
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Relational Operators
>Affects Versions: 1.14.0
>Reporter: Boaz Ben-Zvi
>Assignee: Boaz Ben-Zvi
>Priority: Blocker
> Fix For: 1.15.0
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> Following DRILL-6755 (_Avoid building a hash table when the probe side
> is empty_) - The special case of an empty spilled probe-partition was not
> handled. When such a case happens, the Hash-Join terminates early (returns
> NONE) and the remaining partitions are not processed/returned (which may lead
> to incorrect results).
> A test case - force tpcds/query95 to spill (sf1) :
> {code:java}
> 0: jdbc:drill:zk=local> alter system set
> `exec.hashjoin.max_batches_in_memory` = 40;
> +---+---+
> | ok |summary|
> +---+---+
> | true | exec.hashjoin.max_batches_in_memory updated. |
> +---+---+
> 1 row selected (1.325 seconds)
> 0: jdbc:drill:zk=local> WITH ws_wh AS
> . . . . . . . . . . . > (
> . . . . . . . . . . . >SELECT ws1.ws_order_number,
> . . . . . . . . . . . > ws1.ws_warehouse_sk wh1,
> . . . . . . . . . . . > ws2.ws_warehouse_sk wh2
> . . . . . . . . . . . >FROM dfs.`/data/tpcds/sf1/parquet/web_sales`
> ws1,
> . . . . . . . . . . . > dfs.`/data/tpcds/sf1/parquet/web_sales`
> ws2
> . . . . . . . . . . . >WHERE ws1.ws_order_number =
> ws2.ws_order_number
> . . . . . . . . . . . >ANDws1.ws_warehouse_sk <>
> ws2.ws_warehouse_sk)
> . . . . . . . . . . . > SELECT
> . . . . . . . . . . . > Count(DISTINCT ws1.ws_order_number) AS
> `order count` ,
> . . . . . . . . . . . > Sum(ws1.ws_ext_ship_cost) AS
> `total shipping cost` ,
> . . . . . . . . . . . > Sum(ws1.ws_net_profit) AS
> `total net profit`
> . . . . . . . . . . . > FROM dfs.`/data/tpcds/sf1/parquet/web_sales` ws1 ,
> . . . . . . . . . . . > dfs.`/data/tpcds/sf1/parquet/date_dim` dd,
> . . . . . . . . . . . >
> dfs.`/data/tpcds/sf1/parquet/customer_address` ca,
> . . . . . . . . . . . > dfs.`/data/tpcds/sf1/parquet/web_site` wbst
> . . . . . . . . . . . > WHEREdd.d_date BETWEEN '2000-04-01' AND (
> . . . . . . . . . . . > Cast('2000-04-01' AS DATE) +
> INTERVAL '60' day)
> . . . . . . . . . . . > AND ws1.ws_ship_date_sk = dd.d_date_sk
> . . . . . . . . . . . > AND ws1.ws_ship_addr_sk = ca.ca_address_sk
> . . . . . . . . . . . > AND ca.ca_state = 'IN'
> . . . . . . . . . . . > AND ws1.ws_web_site_sk = wbst.web_site_sk
> . . . . . . . . . . . > AND wbst.web_company_name = 'pri'
> . . . . . . . . . . . > AND ws1.ws_order_number IN
> . . . . . . . . . . . > (
> . . . . . . . . . . . > SELECT ws_wh.ws_order_number
> . . . . . . . . . . . >
[jira] [Updated] (DRILL-6861) Hash-Join: Spilled partitions are skipped following an empty probe side
[
https://issues.apache.org/jira/browse/DRILL-6861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boaz Ben-Zvi updated DRILL-6861:
Description:
Following DRILL-6755 (_Avoid building a hash table when the probe side is
empty_) - The special case of an empty spilled probe-partition was not handled.
When such a case happens, the Hash-Join terminates early (returns NONE) and
the remaining partitions are not processed/returned (which may lead to
incorrect results).
A test case - force tpcds/query95 to spill (sf1) :
{code:java}
0: jdbc:drill:zk=local> alter system set `exec.hashjoin.max_batches_in_memory`
= 40;
+---+---+
| ok |summary|
+---+---+
| true | exec.hashjoin.max_batches_in_memory updated. |
+---+---+
1 row selected (1.325 seconds)
0: jdbc:drill:zk=local> WITH ws_wh AS
. . . . . . . . . . . > (
. . . . . . . . . . . >SELECT ws1.ws_order_number,
. . . . . . . . . . . > ws1.ws_warehouse_sk wh1,
. . . . . . . . . . . > ws2.ws_warehouse_sk wh2
. . . . . . . . . . . >FROM dfs.`/data/tpcds/sf1/parquet/web_sales`
ws1,
. . . . . . . . . . . > dfs.`/data/tpcds/sf1/parquet/web_sales`
ws2
. . . . . . . . . . . >WHERE ws1.ws_order_number = ws2.ws_order_number
. . . . . . . . . . . >ANDws1.ws_warehouse_sk <>
ws2.ws_warehouse_sk)
. . . . . . . . . . . > SELECT
. . . . . . . . . . . > Count(DISTINCT ws1.ws_order_number) AS `order
count` ,
. . . . . . . . . . . > Sum(ws1.ws_ext_ship_cost) AS `total
shipping cost` ,
. . . . . . . . . . . > Sum(ws1.ws_net_profit) AS `total
net profit`
. . . . . . . . . . . > FROM dfs.`/data/tpcds/sf1/parquet/web_sales` ws1 ,
. . . . . . . . . . . > dfs.`/data/tpcds/sf1/parquet/date_dim` dd,
. . . . . . . . . . . > dfs.`/data/tpcds/sf1/parquet/customer_address`
ca,
. . . . . . . . . . . > dfs.`/data/tpcds/sf1/parquet/web_site` wbst
. . . . . . . . . . . > WHEREdd.d_date BETWEEN '2000-04-01' AND (
. . . . . . . . . . . > Cast('2000-04-01' AS DATE) + INTERVAL
'60' day)
. . . . . . . . . . . > AND ws1.ws_ship_date_sk = dd.d_date_sk
. . . . . . . . . . . > AND ws1.ws_ship_addr_sk = ca.ca_address_sk
. . . . . . . . . . . > AND ca.ca_state = 'IN'
. . . . . . . . . . . > AND ws1.ws_web_site_sk = wbst.web_site_sk
. . . . . . . . . . . > AND wbst.web_company_name = 'pri'
. . . . . . . . . . . > AND ws1.ws_order_number IN
. . . . . . . . . . . > (
. . . . . . . . . . . > SELECT ws_wh.ws_order_number
. . . . . . . . . . . > FROM ws_wh)
. . . . . . . . . . . > AND ws1.ws_order_number IN
. . . . . . . . . . . > (
. . . . . . . . . . . > SELECT wr.wr_order_number
. . . . . . . . . . . > FROM
dfs.`/data/tpcds/sf1/parquet/web_returns` wr,
. . . . . . . . . . . >ws_wh
. . . . . . . . . . . > WHERE wr.wr_order_number =
ws_wh.ws_order_number)
. . . . . . . . . . . > ORDER BY count(DISTINCT ws1.ws_order_number)
. . . . . . . . . . . > LIMIT 100;
+--+--+-+
| order count | total shipping cost | total net profit |
+--+--+-+
| 17 | 38508.1305 | 20822.3 |
+--+--+-+
1 row selected (105.621 seconds)
{code}
The correct results should be:
{code:java}
+--+--+-+
| order count | total shipping cost | total net profit |
+--+--+-+
| 34 | 63754.72 | 15919.0098 |
+--+--+-+
{code}
was:
Following DRILL-6755 (_Avoid building a hash table when the probe side is
empty_) - The special case of an empty spilled probe-partition was not handled.
When such a case happens, the Hash-Join terminates early (returns NONE) and
the remaining partitions are not processed/returned (which may lead to
incorrect results).
A test case - force tpcds/query95 to spill :
{code:java}
0: jdbc:drill:zk=local> alter system set `exec.hashjoin.max_batches_in_memory`
= 40;
+---+---+
| ok |summary|
+---+---+
| true | exec.hashjoin.max_batches_in_memory updated. |
+---+---+
1 row selected (1.325 seconds)
0: jdbc:drill:zk=local> WITH ws_wh AS
. . . . . . . . . .
[jira] [Created] (DRILL-6861) Hash-Join: Spilled partitions are skipped following an empty probe side
Boaz Ben-Zvi created DRILL-6861:
---
Summary: Hash-Join: Spilled partitions are skipped following an
empty probe side
Key: DRILL-6861
URL: https://issues.apache.org/jira/browse/DRILL-6861
Project: Apache Drill
Issue Type: Bug
Components: Execution - Relational Operators
Affects Versions: 1.14.0
Reporter: Boaz Ben-Zvi
Assignee: Boaz Ben-Zvi
Fix For: 1.15.0
Following DRILL-6755 (_Avoid building a hash table when the probe side is
empty_) - The special case of an empty spilled probe-partition was not handled.
When such a case happens, the Hash-Join terminates early (returns NONE) and
the remaining partitions are not processed/returned (which may lead to
incorrect results).
A test case - force tpcds/query95 to spill :
{code:java}
0: jdbc:drill:zk=local> alter system set `exec.hashjoin.max_batches_in_memory`
= 40;
+---+---+
| ok |summary|
+---+---+
| true | exec.hashjoin.max_batches_in_memory updated. |
+---+---+
1 row selected (1.325 seconds)
0: jdbc:drill:zk=local> WITH ws_wh AS
. . . . . . . . . . . > (
. . . . . . . . . . . >SELECT ws1.ws_order_number,
. . . . . . . . . . . > ws1.ws_warehouse_sk wh1,
. . . . . . . . . . . > ws2.ws_warehouse_sk wh2
. . . . . . . . . . . >FROM dfs.`/data/tpcds/sf1/parquet/web_sales`
ws1,
. . . . . . . . . . . > dfs.`/data/tpcds/sf1/parquet/web_sales`
ws2
. . . . . . . . . . . >WHERE ws1.ws_order_number = ws2.ws_order_number
. . . . . . . . . . . >ANDws1.ws_warehouse_sk <>
ws2.ws_warehouse_sk)
. . . . . . . . . . . > SELECT
. . . . . . . . . . . > Count(DISTINCT ws1.ws_order_number) AS `order
count` ,
. . . . . . . . . . . > Sum(ws1.ws_ext_ship_cost) AS `total
shipping cost` ,
. . . . . . . . . . . > Sum(ws1.ws_net_profit) AS `total
net profit`
. . . . . . . . . . . > FROM dfs.`/data/tpcds/sf1/parquet/web_sales` ws1 ,
. . . . . . . . . . . > dfs.`/data/tpcds/sf1/parquet/date_dim` dd,
. . . . . . . . . . . > dfs.`/data/tpcds/sf1/parquet/customer_address`
ca,
. . . . . . . . . . . > dfs.`/data/tpcds/sf1/parquet/web_site` wbst
. . . . . . . . . . . > WHEREdd.d_date BETWEEN '2000-04-01' AND (
. . . . . . . . . . . > Cast('2000-04-01' AS DATE) + INTERVAL
'60' day)
. . . . . . . . . . . > AND ws1.ws_ship_date_sk = dd.d_date_sk
. . . . . . . . . . . > AND ws1.ws_ship_addr_sk = ca.ca_address_sk
. . . . . . . . . . . > AND ca.ca_state = 'IN'
. . . . . . . . . . . > AND ws1.ws_web_site_sk = wbst.web_site_sk
. . . . . . . . . . . > AND wbst.web_company_name = 'pri'
. . . . . . . . . . . > AND ws1.ws_order_number IN
. . . . . . . . . . . > (
. . . . . . . . . . . > SELECT ws_wh.ws_order_number
. . . . . . . . . . . > FROM ws_wh)
. . . . . . . . . . . > AND ws1.ws_order_number IN
. . . . . . . . . . . > (
. . . . . . . . . . . > SELECT wr.wr_order_number
. . . . . . . . . . . > FROM
dfs.`/data/tpcds/sf1/parquet/web_returns` wr,
. . . . . . . . . . . >ws_wh
. . . . . . . . . . . > WHERE wr.wr_order_number =
ws_wh.ws_order_number)
. . . . . . . . . . . > ORDER BY count(DISTINCT ws1.ws_order_number)
. . . . . . . . . . . > LIMIT 100;
+--+--+-+
| order count | total shipping cost | total net profit |
+--+--+-+
| 17 | 38508.1305 | 20822.3 |
+--+--+-+
1 row selected (105.621 seconds)
{code}
The correct results should be:
{code:java}
+--+--+-+
| order count | total shipping cost | total net profit |
+--+--+-+
| 34 | 63754.72 | 15919.0098 |
+--+--+-+
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (DRILL-6076) Reduce the default memory from a total of 13GB to 5GB
[ https://issues.apache.org/jira/browse/DRILL-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritesh Maker updated DRILL-6076: - Fix Version/s: (was: 1.15.0) Future > Reduce the default memory from a total of 13GB to 5GB > - > > Key: DRILL-6076 > URL: https://issues.apache.org/jira/browse/DRILL-6076 > Project: Apache Drill > Issue Type: Task >Reporter: Kunal Khatua >Assignee: Kunal Khatua >Priority: Critical > Fix For: Future > > Original Estimate: 24h > Remaining Estimate: 24h > > Currently, the default memory requirements for Drill are about 13GB, with the > following allocations: > * 4GB Heap > * 8GB Direct Memory > * 1GB CodeCache > * 512MB MaxPermSize > Also, with Drill 1.12.0, the recommendation is to move to JDK8, which makes > the MaxPermSize as irrelevant. > With that, the default requirements total to 13GB, which is rather high. This > is especially a problem for scenarios where people are trying out Drill and > might be using this in a development environment where 13GB is too high. > When using the public [test > framework|https://github.com/mapr/drill-test-framework/] for Apache Drill, it > was observed that the framework's functional and unit tests passed > successfully with memory as little as 5GB; based on the following allocation: > * 1GB Heap > * 3GB Direct Memory > * 512MB CodeCache > * 512MB MaxPermSize > Based on this finding, the proposal is to reduce the defaults from the > current settings to the values just mentioned above. The drill-env.sh file > already has details in the comments, along with the recommended values that > reflect the original 13GB defaults. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6855) Query from non-existent proxy user fails with "No default schema selected" when impersonation is enabled
[
https://issues.apache.org/jira/browse/DRILL-6855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692375#comment-16692375
]
Abhishek Ravi commented on DRILL-6855:
--
The {{IOException }}message is as follows
{noformat}
java.io.IOException: Error getting user info for current user,
{noformat}
I think the changes for this bug should be something very similar to
https://issues.apache.org/jira/browse/DRILL-5704, PR ->
https://github.com/apache/drill/pull/895/files
> Query from non-existent proxy user fails with "No default schema selected"
> when impersonation is enabled
>
>
> Key: DRILL-6855
> URL: https://issues.apache.org/jira/browse/DRILL-6855
> Project: Apache Drill
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Abhishek Ravi
>Priority: Major
>
> Query from a *proxy user* fails with following error when *impersonation* is
> *enabled* but user does not exist. This behaviour was discovered when running
> Drill on MapR.
> {noformat}
> Error: VALIDATION ERROR: Schema [[dfs]] is not valid with respect to either
> root schema or current default schema.
> Current default schema: No default schema selected
> {noformat}
> The above error is very confusing and made it very hard to relate to proxy
> user does not exist + impersonation issue.
> The {{fs.access(wsPath, FsAction.READ)}} in
> {{WorkspaceSchemaFactory.accessible fails with IOException,}} which is not
> handled in {{accessible}} but in {{DynamicRootSchema.loadSchemaFactory}}. At
> this point none of the schemas are registered and hence the root schema will
> be registered as default schema.
> The query execution continues and fails much ahead at
> {{DrillSqlWorker.getQueryPlan}} where the {{SqlConverter.validate}}
> eventually throws {{SchemaUtilites.throwSchemaNotFoundException}}.
> One possible fix could be to handle {{IOException}} similar to
> {{FileNotFoundException}} in {{WorkspaceSchemaFactory.accessible}}.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (DRILL-6855) Query from non-existent proxy user fails with "No default schema selected" when impersonation is enabled
[
https://issues.apache.org/jira/browse/DRILL-6855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692375#comment-16692375
]
Abhishek Ravi edited comment on DRILL-6855 at 11/19/18 10:38 PM:
-
The {{IOException}} message is as follows
{noformat}
java.io.IOException: Error getting user info for current user,
{noformat}
I think the changes for this bug should be something very similar to
https://issues.apache.org/jira/browse/DRILL-5704, PR ->
[https://github.com/apache/drill/pull/895/files]
was (Author: aravi5):
The {{IOException }}message is as follows
{noformat}
java.io.IOException: Error getting user info for current user,
{noformat}
I think the changes for this bug should be something very similar to
https://issues.apache.org/jira/browse/DRILL-5704, PR ->
https://github.com/apache/drill/pull/895/files
> Query from non-existent proxy user fails with "No default schema selected"
> when impersonation is enabled
>
>
> Key: DRILL-6855
> URL: https://issues.apache.org/jira/browse/DRILL-6855
> Project: Apache Drill
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Abhishek Ravi
>Priority: Major
>
> Query from a *proxy user* fails with following error when *impersonation* is
> *enabled* but user does not exist. This behaviour was discovered when running
> Drill on MapR.
> {noformat}
> Error: VALIDATION ERROR: Schema [[dfs]] is not valid with respect to either
> root schema or current default schema.
> Current default schema: No default schema selected
> {noformat}
> The above error is very confusing and made it very hard to relate to proxy
> user does not exist + impersonation issue.
> The {{fs.access(wsPath, FsAction.READ)}} in
> {{WorkspaceSchemaFactory.accessible fails with IOException,}} which is not
> handled in {{accessible}} but in {{DynamicRootSchema.loadSchemaFactory}}. At
> this point none of the schemas are registered and hence the root schema will
> be registered as default schema.
> The query execution continues and fails much ahead at
> {{DrillSqlWorker.getQueryPlan}} where the {{SqlConverter.validate}}
> eventually throws {{SchemaUtilites.throwSchemaNotFoundException}}.
> One possible fix could be to handle {{IOException}} similar to
> {{FileNotFoundException}} in {{WorkspaceSchemaFactory.accessible}}.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (DRILL-6767) Simplify transfer of information from the planner to the operators
[ https://issues.apache.org/jira/browse/DRILL-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Khatua updated DRILL-6767: Fix Version/s: (was: 1.15.0) 1.16.0 > Simplify transfer of information from the planner to the operators > -- > > Key: DRILL-6767 > URL: https://issues.apache.org/jira/browse/DRILL-6767 > Project: Apache Drill > Issue Type: Improvement > Components: Execution - Relational Operators, Query Planning & > Optimization >Affects Versions: 1.14.0 >Reporter: Boaz Ben-Zvi >Assignee: Boaz Ben-Zvi >Priority: Minor > Fix For: 1.16.0 > > > Currently little specific information known to the planner is passed to the > operators. For example, see the `joinType` parameter passed to the Join > operators (specifying whether this is a LEFT, RIGHT, INNER of FULL join). > The relevant code passes this information explicitly via the constructors' > signature (e.g., see HashJoinPOP, AbstractJoinPop, etc), and uses specific > fields for this information, and affects all the test code using it, etc. > In the near future many more such "pieces of information" will possibly be > added to Drill, including: > (1) Is this a Semi (or Anti-Semi) join. > (2) `joinControl` > (3) `isRowKeyJoin` > (4) `isBroadcastJoin` > (5) Which join columns are not needed (DRILL-6758) > (6) Is this operator positioned between Lateral and UnNest. > (7) For Hash-Agg: Which phase (already implemented). > Each addition of such information would require a significant code change, > and add some code clutter. > *Suggestion*: Instead pass a single object containing all the needed planner > information. So the next time another field is added, only that object needs > to be changed. (Ideally the whole plan could be passed, and then each > operator could poke and pick its needed fields) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6818) Add descriptions to secondary index options
[ https://issues.apache.org/jira/browse/DRILL-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692279#comment-16692279 ] ASF GitHub Bot commented on DRILL-6818: --- kkhatua commented on issue #1545: DRILL-6818: Add descriptions to secondary index options. URL: https://github.com/apache/drill/pull/1545#issuecomment-440040899 I've asked @bbevens to review this instead. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add descriptions to secondary index options > --- > > Key: DRILL-6818 > URL: https://issues.apache.org/jira/browse/DRILL-6818 > Project: Apache Drill > Issue Type: Task >Affects Versions: 1.15.0 >Reporter: Arina Ielchiieva >Assignee: Aman Sinha >Priority: Major > Labels: doc-impacting > Fix For: 1.15.0 > > > Add descriptions to secondary index options in ExecConstants and > PlannerSettings: > index plan related options == > planner.use_simple_optimizer: false, > planner.enable_index_planning: true, > planner.enable_statistics: true, > planner.disable_full_table_scan: false, > planner.index.max_chosen_indexes_per_table: 5, > planner.index.force_sort_noncovering: false, > planner.index.use_hashjoin_noncovering: false, > planner.index.covering_selectivity_threshold: 1.0, > planner.index.noncovering_selectivity_threshold: 0.025, > planner.index.rowkeyjoin_cost_factor: 0.1, > planner.index.statistics_rowcount_scaling_factor: 0.1, > planner.index.prefer_intersect_plans: false, > planner.index.max_indexes_to_intersect: 5, > exec.query.rowkeyjoin_batchsize: 128, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6818) Add descriptions to secondary index options
[ https://issues.apache.org/jira/browse/DRILL-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692203#comment-16692203 ] ASF GitHub Bot commented on DRILL-6818: --- amansinha100 commented on issue #1545: DRILL-6818: Add descriptions to secondary index options. URL: https://github.com/apache/drill/pull/1545#issuecomment-440026974 @kkhatua could you pls review ? Thx. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add descriptions to secondary index options > --- > > Key: DRILL-6818 > URL: https://issues.apache.org/jira/browse/DRILL-6818 > Project: Apache Drill > Issue Type: Task >Affects Versions: 1.15.0 >Reporter: Arina Ielchiieva >Assignee: Aman Sinha >Priority: Major > Labels: doc-impacting > Fix For: 1.15.0 > > > Add descriptions to secondary index options in ExecConstants and > PlannerSettings: > index plan related options == > planner.use_simple_optimizer: false, > planner.enable_index_planning: true, > planner.enable_statistics: true, > planner.disable_full_table_scan: false, > planner.index.max_chosen_indexes_per_table: 5, > planner.index.force_sort_noncovering: false, > planner.index.use_hashjoin_noncovering: false, > planner.index.covering_selectivity_threshold: 1.0, > planner.index.noncovering_selectivity_threshold: 0.025, > planner.index.rowkeyjoin_cost_factor: 0.1, > planner.index.statistics_rowcount_scaling_factor: 0.1, > planner.index.prefer_intersect_plans: false, > planner.index.max_indexes_to_intersect: 5, > exec.query.rowkeyjoin_batchsize: 128, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6818) Add descriptions to secondary index options
[ https://issues.apache.org/jira/browse/DRILL-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692202#comment-16692202 ] ASF GitHub Bot commented on DRILL-6818: --- amansinha100 opened a new pull request #1545: DRILL-6818: Add descriptions to secondary index options. URL: https://github.com/apache/drill/pull/1545 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add descriptions to secondary index options > --- > > Key: DRILL-6818 > URL: https://issues.apache.org/jira/browse/DRILL-6818 > Project: Apache Drill > Issue Type: Task >Affects Versions: 1.15.0 >Reporter: Arina Ielchiieva >Assignee: Aman Sinha >Priority: Major > Labels: doc-impacting > Fix For: 1.15.0 > > > Add descriptions to secondary index options in ExecConstants and > PlannerSettings: > index plan related options == > planner.use_simple_optimizer: false, > planner.enable_index_planning: true, > planner.enable_statistics: true, > planner.disable_full_table_scan: false, > planner.index.max_chosen_indexes_per_table: 5, > planner.index.force_sort_noncovering: false, > planner.index.use_hashjoin_noncovering: false, > planner.index.covering_selectivity_threshold: 1.0, > planner.index.noncovering_selectivity_threshold: 0.025, > planner.index.rowkeyjoin_cost_factor: 0.1, > planner.index.statistics_rowcount_scaling_factor: 0.1, > planner.index.prefer_intersect_plans: false, > planner.index.max_indexes_to_intersect: 5, > exec.query.rowkeyjoin_batchsize: 128, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6691) Unify checkstyle-config.xml files
[
https://issues.apache.org/jira/browse/DRILL-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692073#comment-16692073
]
Volodymyr Vysotskyi commented on DRILL-6691:
Besides the removing {{checkstyle-config.xml}}, should be fixed checkstyle
issues which will be discovered.
> Unify checkstyle-config.xml files
> -
>
> Key: DRILL-6691
> URL: https://issues.apache.org/jira/browse/DRILL-6691
> Project: Apache Drill
> Issue Type: Task
>Reporter: Volodymyr Vysotskyi
>Assignee: Hanumath Rao Maduri
>Priority: Minor
> Fix For: 1.15.0
>
>
> Currently, `drill-root` and `format-maprdb` modules contain
> `checkstyle-config.xml` own files.
> They should be unified to apply the same checkstyle rules for all modules.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6817) Update to_number function to be consistent with CAST function
[
https://issues.apache.org/jira/browse/DRILL-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692069#comment-16692069
]
Volodymyr Vysotskyi commented on DRILL-6817:
[~KazydubB], was this issue fixed in the scope of DRILL-6768? If so, we resolve
close this Jira.
> Update to_number function to be consistent with CAST function
> -
>
> Key: DRILL-6817
> URL: https://issues.apache.org/jira/browse/DRILL-6817
> Project: Apache Drill
> Issue Type: Improvement
>Reporter: Bohdan Kazydub
>Assignee: Bohdan Kazydub
>Priority: Major
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> {{In case when `drill.exec.functions.cast_empty_string_to_null` is enabled
> casting empty string ('') to numeric types will return NULL. If `to_number`
> is used to convert empty string to a number, UnsupportedOperationException
> will be thrown.}}
> The aim is to make these functions (CASTs and `to_number`) work consistently
> as is done for date/time functions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6830) Hook.REL_BUILDER_SIMPLIFY handler didn't removed cause performance degression
[ https://issues.apache.org/jira/browse/DRILL-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692032#comment-16692032 ] ASF GitHub Bot commented on DRILL-6830: --- ihuzenko commented on issue #1524: DRILL-6830: Remove Hook.REL_BUILDER_SIMPLIFY handler after use URL: https://github.com/apache/drill/pull/1524#issuecomment-439974830 @vvysotskyi ok, will do. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Hook.REL_BUILDER_SIMPLIFY handler didn't removed cause performance degression > - > > Key: DRILL-6830 > URL: https://issues.apache.org/jira/browse/DRILL-6830 > Project: Apache Drill > Issue Type: Bug > Components: Query Planning & Optimization >Affects Versions: 1.14.0 >Reporter: shuifeng lu >Assignee: shuifeng lu >Priority: Major > Fix For: 1.15.0 > > Attachments: Screen Shot 2018-11-06 at 16.14.16.png > > > Planning performance degression has been observed that the duration of > planning increased from 30ms to 160ms after running drill a long period of > time(say a month). > RelBuilder.simplify never becomes true if Hook.REL_BUILDER_SIMPLIFY handlers > are not removed. > Here is some clue (after running 40 days): > Hook.get takes 8ms per-invocation, it may be called serveral times per query. > ---[8.816063ms] org.apache.calcite.tools.RelBuilder:() > +---[0.020218ms] java.util.ArrayDeque:() > +---[0.018493ms] java.lang.Boolean:valueOf() > +---[8.341566ms] org.apache.calcite.runtime.Hook:get() > +---[0.008489ms] java.lang.Boolean:booleanValue() > +---[min=5.21E-4ms,max=0.015832ms,total=0.025233ms,count=12] > org.apache.calcite.plan.Context:unwrap() > +---[min=3.83E-4ms,max=0.009494ms,total=0.014516ms,count=13] > org.apache.calcite.util.Util:first() > +---[0.006892ms] org.apache.calcite.plan.RelOptCluster:getPlanner() > +---[0.009104ms] org.apache.calcite.plan.RelOptPlanner:getExecutor() > +---[min=4.8E-4ms,max=0.002277ms,total=0.002757ms,count=2] > org.apache.calcite.plan.RelOptCluster:getRexBuilder() > ---[min=4.91E-4ms,max=0.004586ms,total=0.005077ms,count=2] > org.apache.calcite.rex.RexSimplify:() > The top instances in JVM > num #instances #bytes class name > -- > 1: 116333 116250440 [B > 2: 890126 105084536 [C > 3: 338062 37415944 [Ljava.lang.Object; > 4: 1715004 27440064 org.apache.calcite.runtime.Hook$4 > 5: 803909 19293816 java.lang.String > !Screen Shot 2018-11-06 at 16.14.16.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-6850) JDBC integration tests failures
[
https://issues.apache.org/jira/browse/DRILL-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva updated DRILL-6850:
Labels: ready-to-commit (was: )
> JDBC integration tests failures
> ---
>
> Key: DRILL-6850
> URL: https://issues.apache.org/jira/browse/DRILL-6850
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - JDBC
>Affects Versions: 1.14.0
>Reporter: Vitalii Diravka
>Assignee: Volodymyr Vysotskyi
>Priority: Major
> Labels: ready-to-commit
> Fix For: 1.15.0
>
>
> The following command will run Drill integratiom tests for RDBMS (Derby and
> MySQL):
> _mvn integration-test failsafe:integration-test -pl contrib/storage-jdbc_
> Currently some drill/exec/store/jdbc TestJdbcPluginWithDerbyIT and
> TestJdbcPluginWithMySQLIT tests fail:
> {code}
> Results :
> Failed tests:
> TestJdbcPluginWithDerbyIT.showTablesDefaultSchema:117 expected:<1> but
> was:<0>
> Tests in error:
> TestJdbcPluginWithDerbyIT.describe » UserRemote VALIDATION ERROR: Unknown
> tabl...
>
> TestJdbcPluginWithDerbyIT.pushdownDoubleJoinAndFilter:111->PlanTestBase.testPlanMatchingPatterns:84->PlanTestBase.testPlanMatchingPatterns:89->PlanTestBase.getPlanInString:369->BaseTestQuery.testSqlWithResults:322->BaseTestQuery.testRunAndReturn:341
> » Rpc
> TestJdbcPluginWithDerbyIT.testCrossSourceMultiFragmentJoin » UserRemote
> VALIDA...
> TestJdbcPluginWithDerbyIT.validateResult:71 » at position 0 column
> '`NUMERIC_...
> TestJdbcPluginWithMySQLIT.validateResult:108 » at position 0 column
> '`numeric...
> Tests run: 14, Failures: 1, Errors: 5, Skipped: 0
> {code}
> Most likely these are old regressions.
> Additionally NPE for empty result is resolved:
> http://drill.apache.org/blog/2018/08/05/drill-1.14-released/#comment-4082559169
> Also, in the scope of this Jira will be allowed configuring table names case
> sensitivity for JDBC storage plugin. Some databases, like derby or postgres
> are case insensitive regarding table names, but other databases like
> mySQL(depending on its configuration) may be case sensitive regarding table
> names. Therefore will be provided a parameter for storage plugin
> {{caseInsensitiveTableNames}} which determines whether table names should be
> handled considering case sensitivity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (DRILL-6858) INFORMATION_SCHEMA.`FILES` table not show any files if storage contains "write only" folder
[
https://issues.apache.org/jira/browse/DRILL-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva updated DRILL-6858:
Reviewer: Volodymyr Vysotskyi
> INFORMATION_SCHEMA.`FILES` table not show any files if storage contains
> "write only" folder
> ---
>
> Key: DRILL-6858
> URL: https://issues.apache.org/jira/browse/DRILL-6858
> Project: Apache Drill
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Denys Ordynskiy
>Assignee: Arina Ielchiieva
>Priority: Major
> Fix For: 1.15.0
>
>
> *Steps to reproduce bug:*
> * storage contains folder with "write only" permission;
> * Drill option "storage.list_files_recursively" is false;
> * query result for "SELECT * FROM INFORMATION_SCHEMA.`FILES`;" shows the
> list of the files and folders for every workspace for each storage plugin;
> * set Drill option "storage.list_files_recursively" to true;
> * run query "SELECT * FROM INFORMATION_SCHEMA.`FILES`;"
> *Actual result:*
> Drill returns empty results table if workspace has a folder with "write only"
> permission. Even if this workspace contains files and folders, that have
> "read" access right.
> *Expected result:*
> Drill returns list of files for each folder with "read" permission and hide
> files list for "write only" folders. Showing only folders name when
> permission is "write only".
>
> This bug can be reproduced on "Amazon S3" and "File System" Drill storage
> plugins.
>
> In "drillbit.log" for "*File System*" Drill storage plugin:
> {code:java}
> 2018-11-15 20:20:19,760 [2412471b-a4f5-d247-0db6-5d50cdcef634:frag:0:0] WARN
> o.a.d.e.s.i.InfoSchemaRecordGenerator - Failure while trying to list files
> java.io.FileNotFoundException: file:///home/mapr/test/writeonly: null file
> list{code}
>
> In "drillbit.log" for "*Amazon S3*" Drill storage plugin:
> {code:java}
> 2018-11-15 16:50:04,735 [24127862-a0e3-02ad-6b66-d649a62e8b8a:frag:0:0] WARN
> o.a.d.e.s.i.InfoSchemaRecordGenerator - Failure while trying to list files
> java.io.FileNotFoundException: No such file or directory:
> s3a://bucket/writeonly{code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (DRILL-6850) JDBC integration tests failures
[
https://issues.apache.org/jira/browse/DRILL-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva updated DRILL-6850:
Reviewer: Arina Ielchiieva
> JDBC integration tests failures
> ---
>
> Key: DRILL-6850
> URL: https://issues.apache.org/jira/browse/DRILL-6850
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - JDBC
>Affects Versions: 1.14.0
>Reporter: Vitalii Diravka
>Assignee: Volodymyr Vysotskyi
>Priority: Major
> Labels: ready-to-commit
> Fix For: 1.15.0
>
>
> The following command will run Drill integratiom tests for RDBMS (Derby and
> MySQL):
> _mvn integration-test failsafe:integration-test -pl contrib/storage-jdbc_
> Currently some drill/exec/store/jdbc TestJdbcPluginWithDerbyIT and
> TestJdbcPluginWithMySQLIT tests fail:
> {code}
> Results :
> Failed tests:
> TestJdbcPluginWithDerbyIT.showTablesDefaultSchema:117 expected:<1> but
> was:<0>
> Tests in error:
> TestJdbcPluginWithDerbyIT.describe » UserRemote VALIDATION ERROR: Unknown
> tabl...
>
> TestJdbcPluginWithDerbyIT.pushdownDoubleJoinAndFilter:111->PlanTestBase.testPlanMatchingPatterns:84->PlanTestBase.testPlanMatchingPatterns:89->PlanTestBase.getPlanInString:369->BaseTestQuery.testSqlWithResults:322->BaseTestQuery.testRunAndReturn:341
> » Rpc
> TestJdbcPluginWithDerbyIT.testCrossSourceMultiFragmentJoin » UserRemote
> VALIDA...
> TestJdbcPluginWithDerbyIT.validateResult:71 » at position 0 column
> '`NUMERIC_...
> TestJdbcPluginWithMySQLIT.validateResult:108 » at position 0 column
> '`numeric...
> Tests run: 14, Failures: 1, Errors: 5, Skipped: 0
> {code}
> Most likely these are old regressions.
> Additionally NPE for empty result is resolved:
> http://drill.apache.org/blog/2018/08/05/drill-1.14-released/#comment-4082559169
> Also, in the scope of this Jira will be allowed configuring table names case
> sensitivity for JDBC storage plugin. Some databases, like derby or postgres
> are case insensitive regarding table names, but other databases like
> mySQL(depending on its configuration) may be case sensitive regarding table
> names. Therefore will be provided a parameter for storage plugin
> {{caseInsensitiveTableNames}} which determines whether table names should be
> handled considering case sensitivity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6850) JDBC integration tests failures
[
https://issues.apache.org/jira/browse/DRILL-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692015#comment-16692015
]
ASF GitHub Bot commented on DRILL-6850:
---
arina-ielchiieva commented on issue #1542: DRILL-6850: JDBC integration tests
failures
URL: https://github.com/apache/drill/pull/1542#issuecomment-439969878
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JDBC integration tests failures
> ---
>
> Key: DRILL-6850
> URL: https://issues.apache.org/jira/browse/DRILL-6850
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - JDBC
>Affects Versions: 1.14.0
>Reporter: Vitalii Diravka
>Assignee: Volodymyr Vysotskyi
>Priority: Major
> Labels: ready-to-commit
> Fix For: 1.15.0
>
>
> The following command will run Drill integratiom tests for RDBMS (Derby and
> MySQL):
> _mvn integration-test failsafe:integration-test -pl contrib/storage-jdbc_
> Currently some drill/exec/store/jdbc TestJdbcPluginWithDerbyIT and
> TestJdbcPluginWithMySQLIT tests fail:
> {code}
> Results :
> Failed tests:
> TestJdbcPluginWithDerbyIT.showTablesDefaultSchema:117 expected:<1> but
> was:<0>
> Tests in error:
> TestJdbcPluginWithDerbyIT.describe » UserRemote VALIDATION ERROR: Unknown
> tabl...
>
> TestJdbcPluginWithDerbyIT.pushdownDoubleJoinAndFilter:111->PlanTestBase.testPlanMatchingPatterns:84->PlanTestBase.testPlanMatchingPatterns:89->PlanTestBase.getPlanInString:369->BaseTestQuery.testSqlWithResults:322->BaseTestQuery.testRunAndReturn:341
> » Rpc
> TestJdbcPluginWithDerbyIT.testCrossSourceMultiFragmentJoin » UserRemote
> VALIDA...
> TestJdbcPluginWithDerbyIT.validateResult:71 » at position 0 column
> '`NUMERIC_...
> TestJdbcPluginWithMySQLIT.validateResult:108 » at position 0 column
> '`numeric...
> Tests run: 14, Failures: 1, Errors: 5, Skipped: 0
> {code}
> Most likely these are old regressions.
> Additionally NPE for empty result is resolved:
> http://drill.apache.org/blog/2018/08/05/drill-1.14-released/#comment-4082559169
> Also, in the scope of this Jira will be allowed configuring table names case
> sensitivity for JDBC storage plugin. Some databases, like derby or postgres
> are case insensitive regarding table names, but other databases like
> mySQL(depending on its configuration) may be case sensitive regarding table
> names. Therefore will be provided a parameter for storage plugin
> {{caseInsensitiveTableNames}} which determines whether table names should be
> handled considering case sensitivity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6847) Add Query Metadata to RESTful Interface
[
https://issues.apache.org/jira/browse/DRILL-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691886#comment-16691886
]
ASF GitHub Bot commented on DRILL-6847:
---
arina-ielchiieva commented on issue #1539: DRILL-6847: Add Query Metadata to
RESTful Interface
URL: https://github.com/apache/drill/pull/1539#issuecomment-439937553
@cgivre submitting core reformatting without significant reason is not
encouraged. Please use Drill dev guidelines to ensure you use the formatting
accepted in Drill project. The same with star imports, this also can be
configured in Intellij.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Query Metadata to RESTful Interface
> ---
>
> Key: DRILL-6847
> URL: https://issues.apache.org/jira/browse/DRILL-6847
> Project: Apache Drill
> Issue Type: Improvement
> Components: Metadata
>Reporter: Charles Givre
>Assignee: Charles Givre
>Priority: Minor
>
> The Drill RESTful interface does not return the structure of the query
> results. This makes integrating Drill with other BI tools difficult because
> they do not know what kind of data to expect.
> This PR adds a new section to the results called Metadata which contains a
> list of the minor types of all the columns returned.
> The query below will now return the following in the RESTful interface:
> {code:sql}
> SELECT CAST( employee_id AS INT) AS employee_id,
> full_name,
> first_name,
> last_name,
> CAST( position_id AS BIGINT) AS position_id,
> position_title
> FROM cp.`employee.json` LIMIT 2
> {code}
> {code}
> {
> "queryId": "2414bf3f-b4f4-d4df-825f-73dfb3a56681",
> "columns": [
> "employee_id",
> "full_name",
> "first_name",
> "last_name",
> "position_id",
> "position_title"
> ],
> "metadata": [
> "INT",
> "VARCHAR",
> "VARCHAR",
> "VARCHAR",
> "BIGINT",
> "VARCHAR"
> ],
> "rows": [
> {
> "full_name": "Sheri Nowmer",
> "employee_id": "1",
> "last_name": "Nowmer",
> "position_title": "President",
> "first_name": "Sheri",
> "position_id": "1"
> },
> {
> "full_name": "Derrick Whelply",
> "employee_id": "2",
> "last_name": "Whelply",
> "position_title": "VP Country Manager",
> "first_name": "Derrick",
> "position_id": "2"
> }
> ]
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6847) Add Query Metadata to RESTful Interface
[
https://issues.apache.org/jira/browse/DRILL-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691883#comment-16691883
]
ASF GitHub Bot commented on DRILL-6847:
---
cgivre commented on issue #1539: DRILL-6847: Add Query Metadata to RESTful
Interface
URL: https://github.com/apache/drill/pull/1539#issuecomment-439936137
Hi @arina-ielchiieva
Can you just hide the non-whitespace changes in GitHub for the review? I
think when I ran the code-formatter in IntelliJ it reformatted those files.
If not, I'll revert and resubmit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Query Metadata to RESTful Interface
> ---
>
> Key: DRILL-6847
> URL: https://issues.apache.org/jira/browse/DRILL-6847
> Project: Apache Drill
> Issue Type: Improvement
> Components: Metadata
>Reporter: Charles Givre
>Assignee: Charles Givre
>Priority: Minor
>
> The Drill RESTful interface does not return the structure of the query
> results. This makes integrating Drill with other BI tools difficult because
> they do not know what kind of data to expect.
> This PR adds a new section to the results called Metadata which contains a
> list of the minor types of all the columns returned.
> The query below will now return the following in the RESTful interface:
> {code:sql}
> SELECT CAST( employee_id AS INT) AS employee_id,
> full_name,
> first_name,
> last_name,
> CAST( position_id AS BIGINT) AS position_id,
> position_title
> FROM cp.`employee.json` LIMIT 2
> {code}
> {code}
> {
> "queryId": "2414bf3f-b4f4-d4df-825f-73dfb3a56681",
> "columns": [
> "employee_id",
> "full_name",
> "first_name",
> "last_name",
> "position_id",
> "position_title"
> ],
> "metadata": [
> "INT",
> "VARCHAR",
> "VARCHAR",
> "VARCHAR",
> "BIGINT",
> "VARCHAR"
> ],
> "rows": [
> {
> "full_name": "Sheri Nowmer",
> "employee_id": "1",
> "last_name": "Nowmer",
> "position_title": "President",
> "first_name": "Sheri",
> "position_id": "1"
> },
> {
> "full_name": "Derrick Whelply",
> "employee_id": "2",
> "last_name": "Whelply",
> "position_title": "VP Country Manager",
> "first_name": "Derrick",
> "position_id": "2"
> }
> ]
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6850) JDBC integration tests failures
[
https://issues.apache.org/jira/browse/DRILL-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691878#comment-16691878
]
ASF GitHub Bot commented on DRILL-6850:
---
vvysotskyi commented on a change in pull request #1542: DRILL-6850: JDBC
integration tests failures
URL: https://github.com/apache/drill/pull/1542#discussion_r234632039
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStoragePlugin.java
##
@@ -291,27 +292,41 @@ public Table getTable(String name) {
if (table != null) {
return table;
}
- return inner.getTable(name.toUpperCase());
+ if (!areTableNamesCaseSensitive()) {
Review comment:
We can obtain `SqlDialect` for used DB, or use driver, specified in the
config to determine the DB. But the behavior for some BDs may be configured
[1], and I'm not sure that we can receive its values.
I think it will be better to leave it as it is.
[1] https://dev.mysql.com/doc/refman/8.0/en/identifier-case-sensitivity.html
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JDBC integration tests failures
> ---
>
> Key: DRILL-6850
> URL: https://issues.apache.org/jira/browse/DRILL-6850
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - JDBC
>Affects Versions: 1.14.0
>Reporter: Vitalii Diravka
>Assignee: Volodymyr Vysotskyi
>Priority: Major
> Fix For: 1.15.0
>
>
> The following command will run Drill integratiom tests for RDBMS (Derby and
> MySQL):
> _mvn integration-test failsafe:integration-test -pl contrib/storage-jdbc_
> Currently some drill/exec/store/jdbc TestJdbcPluginWithDerbyIT and
> TestJdbcPluginWithMySQLIT tests fail:
> {code}
> Results :
> Failed tests:
> TestJdbcPluginWithDerbyIT.showTablesDefaultSchema:117 expected:<1> but
> was:<0>
> Tests in error:
> TestJdbcPluginWithDerbyIT.describe » UserRemote VALIDATION ERROR: Unknown
> tabl...
>
> TestJdbcPluginWithDerbyIT.pushdownDoubleJoinAndFilter:111->PlanTestBase.testPlanMatchingPatterns:84->PlanTestBase.testPlanMatchingPatterns:89->PlanTestBase.getPlanInString:369->BaseTestQuery.testSqlWithResults:322->BaseTestQuery.testRunAndReturn:341
> » Rpc
> TestJdbcPluginWithDerbyIT.testCrossSourceMultiFragmentJoin » UserRemote
> VALIDA...
> TestJdbcPluginWithDerbyIT.validateResult:71 » at position 0 column
> '`NUMERIC_...
> TestJdbcPluginWithMySQLIT.validateResult:108 » at position 0 column
> '`numeric...
> Tests run: 14, Failures: 1, Errors: 5, Skipped: 0
> {code}
> Most likely these are old regressions.
> Additionally NPE for empty result is resolved:
> http://drill.apache.org/blog/2018/08/05/drill-1.14-released/#comment-4082559169
> Also, in the scope of this Jira will be allowed configuring table names case
> sensitivity for JDBC storage plugin. Some databases, like derby or postgres
> are case insensitive regarding table names, but other databases like
> mySQL(depending on its configuration) may be case sensitive regarding table
> names. Therefore will be provided a parameter for storage plugin
> {{caseInsensitiveTableNames}} which determines whether table names should be
> handled considering case sensitivity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6850) JDBC integration tests failures
[
https://issues.apache.org/jira/browse/DRILL-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691877#comment-16691877
]
ASF GitHub Bot commented on DRILL-6850:
---
vvysotskyi commented on a change in pull request #1542: DRILL-6850: JDBC
integration tests failures
URL: https://github.com/apache/drill/pull/1542#discussion_r234626481
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStorageConfig.java
##
@@ -64,6 +67,10 @@ public String getPassword() {
return password;
}
+ public boolean areTableNamesCaseInsensitive() {
Review comment:
Thanks for pointing this. I have added
`@JsonProperty("caseInsensitiveTableNames")` and added a test
`TestJdbcPluginWithDerbyIT.testJdbcStoragePluginSerDe()` to verify that all
storage plugin configs are stored correctly into the physical plan.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JDBC integration tests failures
> ---
>
> Key: DRILL-6850
> URL: https://issues.apache.org/jira/browse/DRILL-6850
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - JDBC
>Affects Versions: 1.14.0
>Reporter: Vitalii Diravka
>Assignee: Volodymyr Vysotskyi
>Priority: Major
> Fix For: 1.15.0
>
>
> The following command will run Drill integratiom tests for RDBMS (Derby and
> MySQL):
> _mvn integration-test failsafe:integration-test -pl contrib/storage-jdbc_
> Currently some drill/exec/store/jdbc TestJdbcPluginWithDerbyIT and
> TestJdbcPluginWithMySQLIT tests fail:
> {code}
> Results :
> Failed tests:
> TestJdbcPluginWithDerbyIT.showTablesDefaultSchema:117 expected:<1> but
> was:<0>
> Tests in error:
> TestJdbcPluginWithDerbyIT.describe » UserRemote VALIDATION ERROR: Unknown
> tabl...
>
> TestJdbcPluginWithDerbyIT.pushdownDoubleJoinAndFilter:111->PlanTestBase.testPlanMatchingPatterns:84->PlanTestBase.testPlanMatchingPatterns:89->PlanTestBase.getPlanInString:369->BaseTestQuery.testSqlWithResults:322->BaseTestQuery.testRunAndReturn:341
> » Rpc
> TestJdbcPluginWithDerbyIT.testCrossSourceMultiFragmentJoin » UserRemote
> VALIDA...
> TestJdbcPluginWithDerbyIT.validateResult:71 » at position 0 column
> '`NUMERIC_...
> TestJdbcPluginWithMySQLIT.validateResult:108 » at position 0 column
> '`numeric...
> Tests run: 14, Failures: 1, Errors: 5, Skipped: 0
> {code}
> Most likely these are old regressions.
> Additionally NPE for empty result is resolved:
> http://drill.apache.org/blog/2018/08/05/drill-1.14-released/#comment-4082559169
> Also, in the scope of this Jira will be allowed configuring table names case
> sensitivity for JDBC storage plugin. Some databases, like derby or postgres
> are case insensitive regarding table names, but other databases like
> mySQL(depending on its configuration) may be case sensitive regarding table
> names. Therefore will be provided a parameter for storage plugin
> {{caseInsensitiveTableNames}} which determines whether table names should be
> handled considering case sensitivity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (DRILL-6858) INFORMATION_SCHEMA.`FILES` table not show any files if storage contains "write only" folder
[
https://issues.apache.org/jira/browse/DRILL-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva reassigned DRILL-6858:
---
Assignee: Arina Ielchiieva
> INFORMATION_SCHEMA.`FILES` table not show any files if storage contains
> "write only" folder
> ---
>
> Key: DRILL-6858
> URL: https://issues.apache.org/jira/browse/DRILL-6858
> Project: Apache Drill
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Denys Ordynskiy
>Assignee: Arina Ielchiieva
>Priority: Major
>
> *Steps to reproduce bug:*
> * storage contains folder with "write only" permission;
> * Drill option "storage.list_files_recursively" is false;
> * query result for "SELECT * FROM INFORMATION_SCHEMA.`FILES`;" shows the
> list of the files and folders for every workspace for each storage plugin;
> * set Drill option "storage.list_files_recursively" to true;
> * run query "SELECT * FROM INFORMATION_SCHEMA.`FILES`;"
> *Actual result:*
> Drill returns empty results table if workspace has a folder with "write only"
> permission. Even if this workspace contains files and folders, that have
> "read" access right.
> *Expected result:*
> Drill returns list of files for each folder with "read" permission and hide
> files list for "write only" folders. Showing only folders name when
> permission is "write only".
>
> This bug can be reproduced on "Amazon S3" and "File System" Drill storage
> plugins.
>
> In "drillbit.log" for "*File System*" Drill storage plugin:
> {code:java}
> 2018-11-15 20:20:19,760 [2412471b-a4f5-d247-0db6-5d50cdcef634:frag:0:0] WARN
> o.a.d.e.s.i.InfoSchemaRecordGenerator - Failure while trying to list files
> java.io.FileNotFoundException: file:///home/mapr/test/writeonly: null file
> list{code}
>
> In "drillbit.log" for "*Amazon S3*" Drill storage plugin:
> {code:java}
> 2018-11-15 16:50:04,735 [24127862-a0e3-02ad-6b66-d649a62e8b8a:frag:0:0] WARN
> o.a.d.e.s.i.InfoSchemaRecordGenerator - Failure while trying to list files
> java.io.FileNotFoundException: No such file or directory:
> s3a://bucket/writeonly{code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (DRILL-6860) SqlLine: EXPLAIN produces very long header lines
[
https://issues.apache.org/jira/browse/DRILL-6860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691842#comment-16691842
]
Arina Ielchiieva edited comment on DRILL-6860 at 11/19/18 3:22 PM:
---
@Boaz this duplicates DRILL-6769 and will be fixed after SqlLine 1.6.0 upgrade,
mostly like in the next Drill version (i.e. 1.16.0) since SqlLine 1.6.0 is not
out yet.
was (Author: arina):
@Boaz this duplicates DRILL-6769 and will be fixed after SqlLine 1.6.0 upgrade.
> SqlLine: EXPLAIN produces very long header lines
>
>
> Key: DRILL-6860
> URL: https://issues.apache.org/jira/browse/DRILL-6860
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - CLI
>Affects Versions: 1.14.0
>Reporter: Boaz Ben-Zvi
>Assignee: Arina Ielchiieva
>Priority: Minor
>
> Maybe a result of upgrading to SqlLine 1.5.0 (DRILL-3853 - PR #1462), the
> header dividing lines displayed when using EXPLAIN became very long:
> {code}
> 0: jdbc:drill:zk=local> explain plan for select count(*) from
> dfs.`/data/tpcds/sf1/parquet/date_dim`;
> +-+---+
> |
>text
> |
>
>
>
>
>
> json
>
>
>
>
>
> |
> +-+---+
> | 00-00Screen
> 00-01 Project(EXPR$0=[$0])
> 00-02DirectScan(groupscan=[files =
> [/data/tpcds/sf1/parquet/date_dim/0_0_0.parquet], numFiles = 1,
> DynamicPojoRecordReader{records = [[73049]]}])
> | {
> "head" : {
>
[jira] [Commented] (DRILL-6860) SqlLine: EXPLAIN produces very long header lines
[
https://issues.apache.org/jira/browse/DRILL-6860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691842#comment-16691842
]
Arina Ielchiieva commented on DRILL-6860:
-
@Boaz this duplicates DRILL-6769 and will be fixed after SqlLine 1.6.0 upgrade.
> SqlLine: EXPLAIN produces very long header lines
>
>
> Key: DRILL-6860
> URL: https://issues.apache.org/jira/browse/DRILL-6860
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - CLI
>Affects Versions: 1.14.0
>Reporter: Boaz Ben-Zvi
>Assignee: Arina Ielchiieva
>Priority: Minor
>
> Maybe a result of upgrading to SqlLine 1.5.0 (DRILL-3853 - PR #1462), the
> header dividing lines displayed when using EXPLAIN became very long:
> {code}
> 0: jdbc:drill:zk=local> explain plan for select count(*) from
> dfs.`/data/tpcds/sf1/parquet/date_dim`;
> +-+---+
> |
>text
> |
>
>
>
>
>
> json
>
>
>
>
>
> |
> +-+---+
> | 00-00Screen
> 00-01 Project(EXPR$0=[$0])
> 00-02DirectScan(groupscan=[files =
> [/data/tpcds/sf1/parquet/date_dim/0_0_0.parquet], numFiles = 1,
> DynamicPojoRecordReader{records = [[73049]]}])
> | {
> "head" : {
> "version" : 1,
> "generator" : {
> "type" : "ExplainHandler",
> "info" : ""
> },
> "type" : "APACHE_DRILL_PHYSICAL",
> "options" : [ {
> "kind" : "BOOLEAN",
> "accessibleScopes" : "ALL",
> "name"
[jira] [Resolved] (DRILL-6860) SqlLine: EXPLAIN produces very long header lines
[
https://issues.apache.org/jira/browse/DRILL-6860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva resolved DRILL-6860.
-
Resolution: Duplicate
> SqlLine: EXPLAIN produces very long header lines
>
>
> Key: DRILL-6860
> URL: https://issues.apache.org/jira/browse/DRILL-6860
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - CLI
>Affects Versions: 1.14.0
>Reporter: Boaz Ben-Zvi
>Assignee: Arina Ielchiieva
>Priority: Minor
>
> Maybe a result of upgrading to SqlLine 1.5.0 (DRILL-3853 - PR #1462), the
> header dividing lines displayed when using EXPLAIN became very long:
> {code}
> 0: jdbc:drill:zk=local> explain plan for select count(*) from
> dfs.`/data/tpcds/sf1/parquet/date_dim`;
> +-+---+
> |
>text
> |
>
>
>
>
>
> json
>
>
>
>
>
> |
> +-+---+
> | 00-00Screen
> 00-01 Project(EXPR$0=[$0])
> 00-02DirectScan(groupscan=[files =
> [/data/tpcds/sf1/parquet/date_dim/0_0_0.parquet], numFiles = 1,
> DynamicPojoRecordReader{records = [[73049]]}])
> | {
> "head" : {
> "version" : 1,
> "generator" : {
> "type" : "ExplainHandler",
> "info" : ""
> },
> "type" : "APACHE_DRILL_PHYSICAL",
> "options" : [ {
> "kind" : "BOOLEAN",
> "accessibleScopes" : "ALL",
> "name" : "planner.enable_nljoin_for_scalar_only",
> "bool_val" : true,
> "scope" : "SESSION"
> } ],
>
[jira] [Updated] (DRILL-6860) SqlLine: EXPLAIN produces very long header lines
[
https://issues.apache.org/jira/browse/DRILL-6860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva updated DRILL-6860:
Fix Version/s: (was: 1.15.0)
> SqlLine: EXPLAIN produces very long header lines
>
>
> Key: DRILL-6860
> URL: https://issues.apache.org/jira/browse/DRILL-6860
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - CLI
>Affects Versions: 1.14.0
>Reporter: Boaz Ben-Zvi
>Assignee: Arina Ielchiieva
>Priority: Minor
>
> Maybe a result of upgrading to SqlLine 1.5.0 (DRILL-3853 - PR #1462), the
> header dividing lines displayed when using EXPLAIN became very long:
> {code}
> 0: jdbc:drill:zk=local> explain plan for select count(*) from
> dfs.`/data/tpcds/sf1/parquet/date_dim`;
> +-+---+
> |
>text
> |
>
>
>
>
>
> json
>
>
>
>
>
> |
> +-+---+
> | 00-00Screen
> 00-01 Project(EXPR$0=[$0])
> 00-02DirectScan(groupscan=[files =
> [/data/tpcds/sf1/parquet/date_dim/0_0_0.parquet], numFiles = 1,
> DynamicPojoRecordReader{records = [[73049]]}])
> | {
> "head" : {
> "version" : 1,
> "generator" : {
> "type" : "ExplainHandler",
> "info" : ""
> },
> "type" : "APACHE_DRILL_PHYSICAL",
> "options" : [ {
> "kind" : "BOOLEAN",
> "accessibleScopes" : "ALL",
> "name" : "planner.enable_nljoin_for_scalar_only",
> "bool_val" : true,
> "scope" : "SESSION"
>
[jira] [Updated] (DRILL-6858) INFORMATION_SCHEMA.`FILES` table not show any files if storage contains "write only" folder
[
https://issues.apache.org/jira/browse/DRILL-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva updated DRILL-6858:
Fix Version/s: 1.15.0
> INFORMATION_SCHEMA.`FILES` table not show any files if storage contains
> "write only" folder
> ---
>
> Key: DRILL-6858
> URL: https://issues.apache.org/jira/browse/DRILL-6858
> Project: Apache Drill
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Denys Ordynskiy
>Assignee: Arina Ielchiieva
>Priority: Major
> Fix For: 1.15.0
>
>
> *Steps to reproduce bug:*
> * storage contains folder with "write only" permission;
> * Drill option "storage.list_files_recursively" is false;
> * query result for "SELECT * FROM INFORMATION_SCHEMA.`FILES`;" shows the
> list of the files and folders for every workspace for each storage plugin;
> * set Drill option "storage.list_files_recursively" to true;
> * run query "SELECT * FROM INFORMATION_SCHEMA.`FILES`;"
> *Actual result:*
> Drill returns empty results table if workspace has a folder with "write only"
> permission. Even if this workspace contains files and folders, that have
> "read" access right.
> *Expected result:*
> Drill returns list of files for each folder with "read" permission and hide
> files list for "write only" folders. Showing only folders name when
> permission is "write only".
>
> This bug can be reproduced on "Amazon S3" and "File System" Drill storage
> plugins.
>
> In "drillbit.log" for "*File System*" Drill storage plugin:
> {code:java}
> 2018-11-15 20:20:19,760 [2412471b-a4f5-d247-0db6-5d50cdcef634:frag:0:0] WARN
> o.a.d.e.s.i.InfoSchemaRecordGenerator - Failure while trying to list files
> java.io.FileNotFoundException: file:///home/mapr/test/writeonly: null file
> list{code}
>
> In "drillbit.log" for "*Amazon S3*" Drill storage plugin:
> {code:java}
> 2018-11-15 16:50:04,735 [24127862-a0e3-02ad-6b66-d649a62e8b8a:frag:0:0] WARN
> o.a.d.e.s.i.InfoSchemaRecordGenerator - Failure while trying to list files
> java.io.FileNotFoundException: No such file or directory:
> s3a://bucket/writeonly{code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6850) JDBC integration tests failures
[
https://issues.apache.org/jira/browse/DRILL-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691507#comment-16691507
]
ASF GitHub Bot commented on DRILL-6850:
---
arina-ielchiieva commented on a change in pull request #1542: DRILL-6850: JDBC
integration tests failures
URL: https://github.com/apache/drill/pull/1542#discussion_r234525776
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStorageConfig.java
##
@@ -64,6 +67,10 @@ public String getPassword() {
return password;
}
+ public boolean areTableNamesCaseInsensitive() {
Review comment:
Please check ser / de. Maybe you need to specify
`@JsonProperty("caseInsensitiveTableNames")` over getter?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JDBC integration tests failures
> ---
>
> Key: DRILL-6850
> URL: https://issues.apache.org/jira/browse/DRILL-6850
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - JDBC
>Affects Versions: 1.14.0
>Reporter: Vitalii Diravka
>Assignee: Volodymyr Vysotskyi
>Priority: Major
> Fix For: 1.15.0
>
>
> The following command will run Drill integratiom tests for RDBMS (Derby and
> MySQL):
> _mvn integration-test failsafe:integration-test -pl contrib/storage-jdbc_
> Currently some drill/exec/store/jdbc TestJdbcPluginWithDerbyIT and
> TestJdbcPluginWithMySQLIT tests fail:
> {code}
> Results :
> Failed tests:
> TestJdbcPluginWithDerbyIT.showTablesDefaultSchema:117 expected:<1> but
> was:<0>
> Tests in error:
> TestJdbcPluginWithDerbyIT.describe » UserRemote VALIDATION ERROR: Unknown
> tabl...
>
> TestJdbcPluginWithDerbyIT.pushdownDoubleJoinAndFilter:111->PlanTestBase.testPlanMatchingPatterns:84->PlanTestBase.testPlanMatchingPatterns:89->PlanTestBase.getPlanInString:369->BaseTestQuery.testSqlWithResults:322->BaseTestQuery.testRunAndReturn:341
> » Rpc
> TestJdbcPluginWithDerbyIT.testCrossSourceMultiFragmentJoin » UserRemote
> VALIDA...
> TestJdbcPluginWithDerbyIT.validateResult:71 » at position 0 column
> '`NUMERIC_...
> TestJdbcPluginWithMySQLIT.validateResult:108 » at position 0 column
> '`numeric...
> Tests run: 14, Failures: 1, Errors: 5, Skipped: 0
> {code}
> Most likely these are old regressions.
> Additionally NPE for empty result is resolved:
> http://drill.apache.org/blog/2018/08/05/drill-1.14-released/#comment-4082559169
> Also, in the scope of this Jira will be allowed configuring table names case
> sensitivity for JDBC storage plugin. Some databases, like derby or postgres
> are case insensitive regarding table names, but other databases like
> mySQL(depending on its configuration) may be case sensitive regarding table
> names. Therefore will be provided a parameter for storage plugin
> {{caseInsensitiveTableNames}} which determines whether table names should be
> handled considering case sensitivity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6830) Hook.REL_BUILDER_SIMPLIFY handler didn't removed cause performance degression
[ https://issues.apache.org/jira/browse/DRILL-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691420#comment-16691420 ] ASF GitHub Bot commented on DRILL-6830: --- lushuifeng commented on issue #1524: DRILL-6830: Remove Hook.REL_BUILDER_SIMPLIFY handler after use URL: https://github.com/apache/drill/pull/1524#issuecomment-439817245 @vvysotskyi thanks, that's great if calcite has fixed this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Hook.REL_BUILDER_SIMPLIFY handler didn't removed cause performance degression > - > > Key: DRILL-6830 > URL: https://issues.apache.org/jira/browse/DRILL-6830 > Project: Apache Drill > Issue Type: Bug > Components: Query Planning & Optimization >Affects Versions: 1.14.0 >Reporter: shuifeng lu >Assignee: shuifeng lu >Priority: Major > Fix For: 1.15.0 > > Attachments: Screen Shot 2018-11-06 at 16.14.16.png > > > Planning performance degression has been observed that the duration of > planning increased from 30ms to 160ms after running drill a long period of > time(say a month). > RelBuilder.simplify never becomes true if Hook.REL_BUILDER_SIMPLIFY handlers > are not removed. > Here is some clue (after running 40 days): > Hook.get takes 8ms per-invocation, it may be called serveral times per query. > ---[8.816063ms] org.apache.calcite.tools.RelBuilder:() > +---[0.020218ms] java.util.ArrayDeque:() > +---[0.018493ms] java.lang.Boolean:valueOf() > +---[8.341566ms] org.apache.calcite.runtime.Hook:get() > +---[0.008489ms] java.lang.Boolean:booleanValue() > +---[min=5.21E-4ms,max=0.015832ms,total=0.025233ms,count=12] > org.apache.calcite.plan.Context:unwrap() > +---[min=3.83E-4ms,max=0.009494ms,total=0.014516ms,count=13] > org.apache.calcite.util.Util:first() > +---[0.006892ms] org.apache.calcite.plan.RelOptCluster:getPlanner() > +---[0.009104ms] org.apache.calcite.plan.RelOptPlanner:getExecutor() > +---[min=4.8E-4ms,max=0.002277ms,total=0.002757ms,count=2] > org.apache.calcite.plan.RelOptCluster:getRexBuilder() > ---[min=4.91E-4ms,max=0.004586ms,total=0.005077ms,count=2] > org.apache.calcite.rex.RexSimplify:() > The top instances in JVM > num #instances #bytes class name > -- > 1: 116333 116250440 [B > 2: 890126 105084536 [C > 3: 338062 37415944 [Ljava.lang.Object; > 4: 1715004 27440064 org.apache.calcite.runtime.Hook$4 > 5: 803909 19293816 java.lang.String > !Screen Shot 2018-11-06 at 16.14.16.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6850) JDBC integration tests failures
[
https://issues.apache.org/jira/browse/DRILL-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691392#comment-16691392
]
ASF GitHub Bot commented on DRILL-6850:
---
arina-ielchiieva commented on a change in pull request #1542: DRILL-6850: JDBC
integration tests failures
URL: https://github.com/apache/drill/pull/1542#discussion_r234526375
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStoragePlugin.java
##
@@ -291,27 +292,41 @@ public Table getTable(String name) {
if (table != null) {
return table;
}
- return inner.getTable(name.toUpperCase());
+ if (!areTableNamesCaseSensitive()) {
Review comment:
Do we know which db we are using in the plugin? Maybe we can do table search
via switch by db name rather than via if's with comments above?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JDBC integration tests failures
> ---
>
> Key: DRILL-6850
> URL: https://issues.apache.org/jira/browse/DRILL-6850
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - JDBC
>Affects Versions: 1.14.0
>Reporter: Vitalii Diravka
>Assignee: Volodymyr Vysotskyi
>Priority: Major
> Fix For: 1.15.0
>
>
> The following command will run Drill integratiom tests for RDBMS (Derby and
> MySQL):
> _mvn integration-test failsafe:integration-test -pl contrib/storage-jdbc_
> Currently some drill/exec/store/jdbc TestJdbcPluginWithDerbyIT and
> TestJdbcPluginWithMySQLIT tests fail:
> {code}
> Results :
> Failed tests:
> TestJdbcPluginWithDerbyIT.showTablesDefaultSchema:117 expected:<1> but
> was:<0>
> Tests in error:
> TestJdbcPluginWithDerbyIT.describe » UserRemote VALIDATION ERROR: Unknown
> tabl...
>
> TestJdbcPluginWithDerbyIT.pushdownDoubleJoinAndFilter:111->PlanTestBase.testPlanMatchingPatterns:84->PlanTestBase.testPlanMatchingPatterns:89->PlanTestBase.getPlanInString:369->BaseTestQuery.testSqlWithResults:322->BaseTestQuery.testRunAndReturn:341
> » Rpc
> TestJdbcPluginWithDerbyIT.testCrossSourceMultiFragmentJoin » UserRemote
> VALIDA...
> TestJdbcPluginWithDerbyIT.validateResult:71 » at position 0 column
> '`NUMERIC_...
> TestJdbcPluginWithMySQLIT.validateResult:108 » at position 0 column
> '`numeric...
> Tests run: 14, Failures: 1, Errors: 5, Skipped: 0
> {code}
> Most likely these are old regressions.
> Additionally NPE for empty result is resolved:
> http://drill.apache.org/blog/2018/08/05/drill-1.14-released/#comment-4082559169
> Also, in the scope of this Jira will be allowed configuring table names case
> sensitivity for JDBC storage plugin. Some databases, like derby or postgres
> are case insensitive regarding table names, but other databases like
> mySQL(depending on its configuration) may be case sensitive regarding table
> names. Therefore will be provided a parameter for storage plugin
> {{caseInsensitiveTableNames}} which determines whether table names should be
> handled considering case sensitivity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6850) JDBC integration tests failures
[
https://issues.apache.org/jira/browse/DRILL-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691391#comment-16691391
]
ASF GitHub Bot commented on DRILL-6850:
---
arina-ielchiieva commented on a change in pull request #1542: DRILL-6850: JDBC
integration tests failures
URL: https://github.com/apache/drill/pull/1542#discussion_r234527280
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/FindHardDistributionScans.java
##
@@ -52,7 +52,12 @@ public RelNode visit(TableScan scan) {
DrillTable unwrap;
unwrap = scan.getTable().unwrap(DrillTable.class);
if (unwrap == null) {
- unwrap =
scan.getTable().unwrap(DrillTranslatableTable.class).getDrillTable();
+ DrillTranslatableTable drillTranslatableTable =
scan.getTable().unwrap(DrillTranslatableTable.class);
+ if (drillTranslatableTable == null) {
+contains = true; // it rejects single mode.
Review comment:
Please add explanation why...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JDBC integration tests failures
> ---
>
> Key: DRILL-6850
> URL: https://issues.apache.org/jira/browse/DRILL-6850
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - JDBC
>Affects Versions: 1.14.0
>Reporter: Vitalii Diravka
>Assignee: Volodymyr Vysotskyi
>Priority: Major
> Fix For: 1.15.0
>
>
> The following command will run Drill integratiom tests for RDBMS (Derby and
> MySQL):
> _mvn integration-test failsafe:integration-test -pl contrib/storage-jdbc_
> Currently some drill/exec/store/jdbc TestJdbcPluginWithDerbyIT and
> TestJdbcPluginWithMySQLIT tests fail:
> {code}
> Results :
> Failed tests:
> TestJdbcPluginWithDerbyIT.showTablesDefaultSchema:117 expected:<1> but
> was:<0>
> Tests in error:
> TestJdbcPluginWithDerbyIT.describe » UserRemote VALIDATION ERROR: Unknown
> tabl...
>
> TestJdbcPluginWithDerbyIT.pushdownDoubleJoinAndFilter:111->PlanTestBase.testPlanMatchingPatterns:84->PlanTestBase.testPlanMatchingPatterns:89->PlanTestBase.getPlanInString:369->BaseTestQuery.testSqlWithResults:322->BaseTestQuery.testRunAndReturn:341
> » Rpc
> TestJdbcPluginWithDerbyIT.testCrossSourceMultiFragmentJoin » UserRemote
> VALIDA...
> TestJdbcPluginWithDerbyIT.validateResult:71 » at position 0 column
> '`NUMERIC_...
> TestJdbcPluginWithMySQLIT.validateResult:108 » at position 0 column
> '`numeric...
> Tests run: 14, Failures: 1, Errors: 5, Skipped: 0
> {code}
> Most likely these are old regressions.
> Additionally NPE for empty result is resolved:
> http://drill.apache.org/blog/2018/08/05/drill-1.14-released/#comment-4082559169
> Also, in the scope of this Jira will be allowed configuring table names case
> sensitivity for JDBC storage plugin. Some databases, like derby or postgres
> are case insensitive regarding table names, but other databases like
> mySQL(depending on its configuration) may be case sensitive regarding table
> names. Therefore will be provided a parameter for storage plugin
> {{caseInsensitiveTableNames}} which determines whether table names should be
> handled considering case sensitivity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6850) JDBC integration tests failures
[
https://issues.apache.org/jira/browse/DRILL-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691390#comment-16691390
]
ASF GitHub Bot commented on DRILL-6850:
---
arina-ielchiieva commented on a change in pull request #1542: DRILL-6850: JDBC
integration tests failures
URL: https://github.com/apache/drill/pull/1542#discussion_r234525776
##
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStorageConfig.java
##
@@ -64,6 +67,10 @@ public String getPassword() {
return password;
}
+ public boolean areTableNamesCaseInsensitive() {
Review comment:
Please check ser / de. Maybe you need to specify
`@JsonProperty('caseInsensitiveTableNames')` over getter?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JDBC integration tests failures
> ---
>
> Key: DRILL-6850
> URL: https://issues.apache.org/jira/browse/DRILL-6850
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - JDBC
>Affects Versions: 1.14.0
>Reporter: Vitalii Diravka
>Assignee: Volodymyr Vysotskyi
>Priority: Major
> Fix For: 1.15.0
>
>
> The following command will run Drill integratiom tests for RDBMS (Derby and
> MySQL):
> _mvn integration-test failsafe:integration-test -pl contrib/storage-jdbc_
> Currently some drill/exec/store/jdbc TestJdbcPluginWithDerbyIT and
> TestJdbcPluginWithMySQLIT tests fail:
> {code}
> Results :
> Failed tests:
> TestJdbcPluginWithDerbyIT.showTablesDefaultSchema:117 expected:<1> but
> was:<0>
> Tests in error:
> TestJdbcPluginWithDerbyIT.describe » UserRemote VALIDATION ERROR: Unknown
> tabl...
>
> TestJdbcPluginWithDerbyIT.pushdownDoubleJoinAndFilter:111->PlanTestBase.testPlanMatchingPatterns:84->PlanTestBase.testPlanMatchingPatterns:89->PlanTestBase.getPlanInString:369->BaseTestQuery.testSqlWithResults:322->BaseTestQuery.testRunAndReturn:341
> » Rpc
> TestJdbcPluginWithDerbyIT.testCrossSourceMultiFragmentJoin » UserRemote
> VALIDA...
> TestJdbcPluginWithDerbyIT.validateResult:71 » at position 0 column
> '`NUMERIC_...
> TestJdbcPluginWithMySQLIT.validateResult:108 » at position 0 column
> '`numeric...
> Tests run: 14, Failures: 1, Errors: 5, Skipped: 0
> {code}
> Most likely these are old regressions.
> Additionally NPE for empty result is resolved:
> http://drill.apache.org/blog/2018/08/05/drill-1.14-released/#comment-4082559169
> Also, in the scope of this Jira will be allowed configuring table names case
> sensitivity for JDBC storage plugin. Some databases, like derby or postgres
> are case insensitive regarding table names, but other databases like
> mySQL(depending on its configuration) may be case sensitive regarding table
> names. Therefore will be provided a parameter for storage plugin
> {{caseInsensitiveTableNames}} which determines whether table names should be
> handled considering case sensitivity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (DRILL-6668) In Web Console, highlight options that are different from default values
[
https://issues.apache.org/jira/browse/DRILL-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva updated DRILL-6668:
Labels: ready-to-commit (was: )
> In Web Console, highlight options that are different from default values
>
>
> Key: DRILL-6668
> URL: https://issues.apache.org/jira/browse/DRILL-6668
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
>Affects Versions: 1.14.0
>Reporter: Paul Rogers
>Assignee: Kunal Khatua
>Priority: Minor
> Labels: doc-impacting, ready-to-commit
> Fix For: 1.15.0
>
> Attachments: screenshot-1.png
>
>
> Suppose you inherit a Drill setup created by someone else (or by you, some
> time in the past). Or, suppose you are a support person. You want to know
> which Drill options have been changed from the defaults.
> The Web UI conveniently displays all options. But, there is no indication of
> which might have non-default values.
> After the improvements of the last year, the information needed to detect
> non-default values is now available. Would be great to mark these values.
> Perhaps using colors, perhaps with words.
> For example:
> *planner.width.max_per_node* 200 \[Update]
> Or
> planner.width.max_per_node (system) 200 \[Update]
> (The Web UI does not, I believe, show session settings, since the Web UI has
> no sessions. I believe the custom values are all set by {{ALTER SYSTEM}}.
> Otherwise, we could also have a "(session)" suffix above.)
> Then, in addition to the {{[Update]}} button, for non default values, also
> provide a {{[Reset]}} button that does the same as {{ALTER SESSION RESET}}.
> planner.width.max_per_node (session) 200 \[Update] \[Reset]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6847) Add Query Metadata to RESTful Interface
[
https://issues.apache.org/jira/browse/DRILL-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691376#comment-16691376
]
ASF GitHub Bot commented on DRILL-6847:
---
arina-ielchiieva commented on issue #1539: DRILL-6847: Add Query Metadata to
RESTful Interface
URL: https://github.com/apache/drill/pull/1539#issuecomment-439807745
@cgivre GitHub diff show lots of changes which clearly unrelated to your
changes. Please revert all unrelated formatting changes that might have caused
it since it's hard to review what has been done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Query Metadata to RESTful Interface
> ---
>
> Key: DRILL-6847
> URL: https://issues.apache.org/jira/browse/DRILL-6847
> Project: Apache Drill
> Issue Type: Improvement
> Components: Metadata
>Reporter: Charles Givre
>Assignee: Charles Givre
>Priority: Minor
>
> The Drill RESTful interface does not return the structure of the query
> results. This makes integrating Drill with other BI tools difficult because
> they do not know what kind of data to expect.
> This PR adds a new section to the results called Metadata which contains a
> list of the minor types of all the columns returned.
> The query below will now return the following in the RESTful interface:
> {code:sql}
> SELECT CAST( employee_id AS INT) AS employee_id,
> full_name,
> first_name,
> last_name,
> CAST( position_id AS BIGINT) AS position_id,
> position_title
> FROM cp.`employee.json` LIMIT 2
> {code}
> {code}
> {
> "queryId": "2414bf3f-b4f4-d4df-825f-73dfb3a56681",
> "columns": [
> "employee_id",
> "full_name",
> "first_name",
> "last_name",
> "position_id",
> "position_title"
> ],
> "metadata": [
> "INT",
> "VARCHAR",
> "VARCHAR",
> "VARCHAR",
> "BIGINT",
> "VARCHAR"
> ],
> "rows": [
> {
> "full_name": "Sheri Nowmer",
> "employee_id": "1",
> "last_name": "Nowmer",
> "position_title": "President",
> "first_name": "Sheri",
> "position_id": "1"
> },
> {
> "full_name": "Derrick Whelply",
> "employee_id": "2",
> "last_name": "Whelply",
> "position_title": "VP Country Manager",
> "first_name": "Derrick",
> "position_id": "2"
> }
> ]
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6039) drillbit.sh graceful_stop does not wait for fragments to complete before stopping the drillbit
[
https://issues.apache.org/jira/browse/DRILL-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691369#comment-16691369
]
ASF GitHub Bot commented on DRILL-6039:
---
arina-ielchiieva commented on a change in pull request #1536: DRILL-6039: Fixed
drillbit.sh script to do graceful shutdown
URL: https://github.com/apache/drill/pull/1536#discussion_r234524071
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java
##
@@ -442,6 +467,14 @@ public void run() {
// StatusThread is started
final Controller controller = dContext.getController();
final DrillbitEndpoint localBitEndPoint = dContext.getEndpoint();
+ try {
+pollShutdown(drillbit);
+ } catch (IOException e) {
+e.printStackTrace();
Review comment:
I think we should not use `e.printStackTrace();` but rather do proper error
handling or logging.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> drillbit.sh graceful_stop does not wait for fragments to complete before
> stopping the drillbit
> --
>
> Key: DRILL-6039
> URL: https://issues.apache.org/jira/browse/DRILL-6039
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Flow
>Affects Versions: 1.3.0
>Reporter: Krystal
>Assignee: Venkata Jyothsna Donapati
>Priority: Major
> Fix For: 1.15.0
>
>
> git.commit.id.abbrev=eb0c403
> I have 3-nodes cluster with drillbits running on each node. I kicked off a
> long running query. In the middle of the query, I did a "./drillbit.sh
> graceful_stop" on one of the non-foreman node. The node was stopped within a
> few seconds and the query failed with error:
> Error: SYSTEM ERROR: IOException: Filesystem closed
> Fragment 4:15
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (DRILL-6668) In Web Console, highlight options that are different from default values
[
https://issues.apache.org/jira/browse/DRILL-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva updated DRILL-6668:
Labels: doc-impacting ready-to-commit (was: ready-to-commit)
> In Web Console, highlight options that are different from default values
>
>
> Key: DRILL-6668
> URL: https://issues.apache.org/jira/browse/DRILL-6668
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
>Affects Versions: 1.14.0
>Reporter: Paul Rogers
>Assignee: Kunal Khatua
>Priority: Minor
> Labels: doc-impacting, ready-to-commit
> Fix For: 1.15.0
>
> Attachments: screenshot-1.png
>
>
> Suppose you inherit a Drill setup created by someone else (or by you, some
> time in the past). Or, suppose you are a support person. You want to know
> which Drill options have been changed from the defaults.
> The Web UI conveniently displays all options. But, there is no indication of
> which might have non-default values.
> After the improvements of the last year, the information needed to detect
> non-default values is now available. Would be great to mark these values.
> Perhaps using colors, perhaps with words.
> For example:
> *planner.width.max_per_node* 200 \[Update]
> Or
> planner.width.max_per_node (system) 200 \[Update]
> (The Web UI does not, I believe, show session settings, since the Web UI has
> no sessions. I believe the custom values are all set by {{ALTER SYSTEM}}.
> Otherwise, we could also have a "(session)" suffix above.)
> Then, in addition to the {{[Update]}} button, for non default values, also
> provide a {{[Reset]}} button that does the same as {{ALTER SESSION RESET}}.
> planner.width.max_per_node (session) 200 \[Update] \[Reset]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (DRILL-6668) In Web Console, highlight options that are different from default values
[
https://issues.apache.org/jira/browse/DRILL-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva updated DRILL-6668:
Reviewer: Arina Ielchiieva (was: Paul Rogers)
> In Web Console, highlight options that are different from default values
>
>
> Key: DRILL-6668
> URL: https://issues.apache.org/jira/browse/DRILL-6668
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
>Affects Versions: 1.14.0
>Reporter: Paul Rogers
>Assignee: Kunal Khatua
>Priority: Minor
> Labels: doc-impacting, ready-to-commit
> Fix For: 1.15.0
>
> Attachments: screenshot-1.png
>
>
> Suppose you inherit a Drill setup created by someone else (or by you, some
> time in the past). Or, suppose you are a support person. You want to know
> which Drill options have been changed from the defaults.
> The Web UI conveniently displays all options. But, there is no indication of
> which might have non-default values.
> After the improvements of the last year, the information needed to detect
> non-default values is now available. Would be great to mark these values.
> Perhaps using colors, perhaps with words.
> For example:
> *planner.width.max_per_node* 200 \[Update]
> Or
> planner.width.max_per_node (system) 200 \[Update]
> (The Web UI does not, I believe, show session settings, since the Web UI has
> no sessions. I believe the custom values are all set by {{ALTER SYSTEM}}.
> Otherwise, we could also have a "(session)" suffix above.)
> Then, in addition to the {{[Update]}} button, for non default values, also
> provide a {{[Reset]}} button that does the same as {{ALTER SESSION RESET}}.
> planner.width.max_per_node (session) 200 \[Update] \[Reset]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (DRILL-6668) In Web Console, highlight options that are different from default values
[
https://issues.apache.org/jira/browse/DRILL-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva updated DRILL-6668:
Fix Version/s: (was: 1.16.0)
> In Web Console, highlight options that are different from default values
>
>
> Key: DRILL-6668
> URL: https://issues.apache.org/jira/browse/DRILL-6668
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
>Affects Versions: 1.14.0
>Reporter: Paul Rogers
>Assignee: Kunal Khatua
>Priority: Minor
> Labels: doc-impacting, ready-to-commit
> Fix For: 1.15.0
>
> Attachments: screenshot-1.png
>
>
> Suppose you inherit a Drill setup created by someone else (or by you, some
> time in the past). Or, suppose you are a support person. You want to know
> which Drill options have been changed from the defaults.
> The Web UI conveniently displays all options. But, there is no indication of
> which might have non-default values.
> After the improvements of the last year, the information needed to detect
> non-default values is now available. Would be great to mark these values.
> Perhaps using colors, perhaps with words.
> For example:
> *planner.width.max_per_node* 200 \[Update]
> Or
> planner.width.max_per_node (system) 200 \[Update]
> (The Web UI does not, I believe, show session settings, since the Web UI has
> no sessions. I believe the custom values are all set by {{ALTER SYSTEM}}.
> Otherwise, we could also have a "(session)" suffix above.)
> Then, in addition to the {{[Update]}} button, for non default values, also
> provide a {{[Reset]}} button that does the same as {{ALTER SESSION RESET}}.
> planner.width.max_per_node (session) 200 \[Update] \[Reset]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6668) In Web Console, highlight options that are different from default values
[
https://issues.apache.org/jira/browse/DRILL-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691365#comment-16691365
]
ASF GitHub Bot commented on DRILL-6668:
---
arina-ielchiieva commented on issue #1543: DRILL-6668: In Web UI, highlight
options that are not default values
URL: https://github.com/apache/drill/pull/1543#issuecomment-439805851
Overall, looks good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> In Web Console, highlight options that are different from default values
>
>
> Key: DRILL-6668
> URL: https://issues.apache.org/jira/browse/DRILL-6668
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
>Affects Versions: 1.14.0
>Reporter: Paul Rogers
>Assignee: Kunal Khatua
>Priority: Minor
> Fix For: 1.15.0, 1.16.0
>
> Attachments: screenshot-1.png
>
>
> Suppose you inherit a Drill setup created by someone else (or by you, some
> time in the past). Or, suppose you are a support person. You want to know
> which Drill options have been changed from the defaults.
> The Web UI conveniently displays all options. But, there is no indication of
> which might have non-default values.
> After the improvements of the last year, the information needed to detect
> non-default values is now available. Would be great to mark these values.
> Perhaps using colors, perhaps with words.
> For example:
> *planner.width.max_per_node* 200 \[Update]
> Or
> planner.width.max_per_node (system) 200 \[Update]
> (The Web UI does not, I believe, show session settings, since the Web UI has
> no sessions. I believe the custom values are all set by {{ALTER SYSTEM}}.
> Otherwise, we could also have a "(session)" suffix above.)
> Then, in addition to the {{[Update]}} button, for non default values, also
> provide a {{[Reset]}} button that does the same as {{ALTER SESSION RESET}}.
> planner.width.max_per_node (session) 200 \[Update] \[Reset]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
