[jira] [Assigned] (DRILL-7050) RexNode convert exception in subquery
[ https://issues.apache.org/jira/browse/DRILL-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva reassigned DRILL-7050: --- Assignee: Arina Ielchiieva (was: Hanumath Rao Maduri) > RexNode convert exception in subquery > - > > Key: DRILL-7050 > URL: https://issues.apache.org/jira/browse/DRILL-7050 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0, 1.15.0 >Reporter: Oleg Zinoviev >Assignee: Arina Ielchiieva >Priority: Major > > If the query contains a subquery whose filters are associated with the main > query, an error occurs: *PLAN ERROR: Cannot convert RexNode to equivalent > Drill expression. RexNode Class: org.apache.calcite.rex.RexCorrelVariable* > Steps to reproduce: > 1) Create source table (or view, doesn't matter) > {code:sql} > create table dfs.root.source as ( > select 1 as id union all select 2 as id > ) > {code} > 2) Execute query > {code:sql} > select t1.id, > (select count(t2.id) > from dfs.root.source t2 where t2.id = t1.id) > from dfs.root.source t1 > {code} > Reason: > Method > {code:java}org.apache.calcite.sql2rel.SqlToRelConverter.Blackboard.lookupExp{code} > call {code:java}RexBuilder.makeCorrel{code} in some cases -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7050) RexNode convert exception in subquery
[ https://issues.apache.org/jira/browse/DRILL-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva updated DRILL-7050: Reviewer: Volodymyr Vysotskyi > RexNode convert exception in subquery > - > > Key: DRILL-7050 > URL: https://issues.apache.org/jira/browse/DRILL-7050 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0, 1.15.0 >Reporter: Oleg Zinoviev >Assignee: Arina Ielchiieva >Priority: Major > > If the query contains a subquery whose filters are associated with the main > query, an error occurs: *PLAN ERROR: Cannot convert RexNode to equivalent > Drill expression. RexNode Class: org.apache.calcite.rex.RexCorrelVariable* > Steps to reproduce: > 1) Create source table (or view, doesn't matter) > {code:sql} > create table dfs.root.source as ( > select 1 as id union all select 2 as id > ) > {code} > 2) Execute query > {code:sql} > select t1.id, > (select count(t2.id) > from dfs.root.source t2 where t2.id = t1.id) > from dfs.root.source t1 > {code} > Reason: > Method > {code:java}org.apache.calcite.sql2rel.SqlToRelConverter.Blackboard.lookupExp{code} > call {code:java}RexBuilder.makeCorrel{code} in some cases -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7050) RexNode convert exception in subquery
[ https://issues.apache.org/jira/browse/DRILL-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva updated DRILL-7050: Fix Version/s: 1.17.0 > RexNode convert exception in subquery > - > > Key: DRILL-7050 > URL: https://issues.apache.org/jira/browse/DRILL-7050 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.14.0, 1.15.0 >Reporter: Oleg Zinoviev >Assignee: Arina Ielchiieva >Priority: Major > Fix For: 1.17.0 > > > If the query contains a subquery whose filters are associated with the main > query, an error occurs: *PLAN ERROR: Cannot convert RexNode to equivalent > Drill expression. RexNode Class: org.apache.calcite.rex.RexCorrelVariable* > Steps to reproduce: > 1) Create source table (or view, doesn't matter) > {code:sql} > create table dfs.root.source as ( > select 1 as id union all select 2 as id > ) > {code} > 2) Execute query > {code:sql} > select t1.id, > (select count(t2.id) > from dfs.root.source t2 where t2.id = t1.id) > from dfs.root.source t1 > {code} > Reason: > Method > {code:java}org.apache.calcite.sql2rel.SqlToRelConverter.Blackboard.lookupExp{code} > call {code:java}RexBuilder.makeCorrel{code} in some cases -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (DRILL-7186) Missing storage.json REST endpoint.
Anton Gozhiy created DRILL-7186: --- Summary: Missing storage.json REST endpoint. Key: DRILL-7186 URL: https://issues.apache.org/jira/browse/DRILL-7186 Project: Apache Drill Issue Type: Bug Affects Versions: 1.16.0 Reporter: Anton Gozhiy *Steps:* 1. Open page: http://:8047/storage.json *Expected result:* storage.json is opened *Actual result:* {noformat} { "errorMessage" : "HTTP 404 Not Found" } {noformat} *Note:* Works fine for individual plugin pages, like: /storage/dfs.json -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva reassigned DRILL-7186: --- Assignee: Arina Ielchiieva > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Arina Ielchiieva >Priority: Blocker > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened > *Actual result:* > {noformat} > { > "errorMessage" : "HTTP 404 Not Found" > } > {noformat} > *Note:* Works fine for individual plugin pages, like: /storage/dfs.json -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva updated DRILL-7186: Priority: Blocker (was: Major) > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Priority: Blocker > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened > *Actual result:* > {noformat} > { > "errorMessage" : "HTTP 404 Not Found" > } > {noformat} > *Note:* Works fine for individual plugin pages, like: /storage/dfs.json -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva updated DRILL-7186: Fix Version/s: 1.16.0 > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Priority: Blocker > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened > *Actual result:* > {noformat} > { > "errorMessage" : "HTTP 404 Not Found" > } > {noformat} > *Note:* Works fine for individual plugin pages, like: /storage/dfs.json -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva updated DRILL-7186: Description: *Steps:* 1. Open page: http://:8047/storage.json *Expected result:* storage.json is opened *Actual result:* {noformat} { "errorMessage" : "HTTP 404 Not Found" } {noformat} *Note:* Works fine for individual plugin pages, like: /storage/dfs.json Regression after DRILL-6562. was: *Steps:* 1. Open page: http://:8047/storage.json *Expected result:* storage.json is opened *Actual result:* {noformat} { "errorMessage" : "HTTP 404 Not Found" } {noformat} *Note:* Works fine for individual plugin pages, like: /storage/dfs.json > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Arina Ielchiieva >Priority: Blocker > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened > *Actual result:* > {noformat} > { > "errorMessage" : "HTTP 404 Not Found" > } > {noformat} > *Note:* Works fine for individual plugin pages, like: /storage/dfs.json > Regression after DRILL-6562. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Gozhiy updated DRILL-7186: Description: *Steps:* 1. Open page: http://:8047/storage.json *Expected result:* storage.json is opened: {noformat} [ { "name" : "cp", "config" : { "type" : "file", "connection" : "classpath:///", "config" : null, "workspaces" : { }, "formats" : { "csv" : { "type" : "text", "extensions" : [ "csv" ], "delimiter" : "," }, "tsv" : { "type" : "text", "extensions" : [ "tsv" ], "delimiter" : "\t" }, "json" : { "type" : "json", "extensions" : [ "json" ] }, "parquet" : { "type" : "parquet" }, "avro" : { "type" : "avro" }, "csvh" : { "type" : "text", "extensions" : [ "csvh" ], "extractHeader" : true, "delimiter" : "," }, "image" : { "type" : "image", "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", "x3f" ] } }, "enabled" : true } }, { "name" : "dfs", "config" : { "type" : "file", "connection" : "file:///", "config" : null, "workspaces" : { "tmp" : { "location" : "/tmp", "writable" : true, "defaultInputFormat" : null, "allowAccessOutsideWorkspace" : false }, "root" : { "location" : "/", "writable" : false, "defaultInputFormat" : null, "allowAccessOutsideWorkspace" : false } }, "formats" : { "psv" : { "type" : "text", "extensions" : [ "tbl" ], "delimiter" : "|" }, "csv" : { "type" : "text", "extensions" : [ "csv" ], "delimiter" : "," }, "tsv" : { "type" : "text", "extensions" : [ "tsv" ], "delimiter" : "\t" }, "httpd" : { "type" : "httpd", "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" }, "parquet" : { "type" : "parquet" }, "json" : { "type" : "json", "extensions" : [ "json" ] }, "pcap" : { "type" : "pcap" }, "pcapng" : { "type" : "pcapng", "extensions" : [ "pcapng" ] }, "avro" : { "type" : "avro" }, "sequencefile" : { "type" : "sequencefile", "extensions" : [ "seq" ] }, "csvh" : { "type" : "text", "extensions" : [ "csvh" ], "extractHeader" : true, "delimiter" : "," }, "image" : { "type" : "image", "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", "x3f" ] } }, "enabled" : true } }, { "name" : "hbase", "config" : { "type" : "hbase", "config" : { "hbase.zookeeper.quorum" : "localhost", "hbase.zookeeper.property.clientPort" : "2181" }, "size.calculator.enabled" : false, "enabled" : false } }, { "name" : "hive", "config" : { "type" : "hive", "configProps" : { "hive.metastore.uris" : "", "javax.jdo.option.ConnectionURL" : "jdbc:derby:;databaseName=../sample-data/drill_hive_db;create=true", "hive.metastore.warehouse.dir" : "/tmp/drill_hive_wh", "fs.default.name" : "file:///", "hive.metastore.sasl.enabled" : "false", "hive.metastore.schema.verification" : "false", "datanucleus.schema.autoCreateAll" : "true" }, "enabled" : false } }, { "name" : "kafka", "config" : { "type" : "kafka", "kafkaConsumerProps" : { "bootstrap.servers" : "localhost:9092", "group.id" : "drill-consumer" }, "enabled" : false } }, { "name" : "kudu", "config" : { "type" : "kudu", "masterAddresses" : "1.2.3.4", "enabled" : false } }, { "name" : "mongo", "config" : { "type" : "mongo", "connection" : "mongodb://localhost:27017/", "enabled" : false } }, { "name" : "opentsdb", "config" : { "type" : "openTSDB", "connection" : "http://localhost:1";, "enabled" : false } }, { "name" : "s3", "config" : { "type" : "file", "connection" : "s3a://my.bucket.location.com", "config" : { "fs.s3a.access.key" : "ID", "fs.s3a.secret.key" : "SECRET" }, "workspaces" : { "tmp" : { "location" : "/tmp", "writable" : true, "defaultInputFor
[jira] [Updated] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva updated DRILL-7186: Description: *Steps:* 1. Open page: http://:8047/storage.json *Expected result:* storage.json is opened: {noformat} [ { "name" : "cp", "config" : { "type" : "file", "connection" : "classpath:///", "config" : null, "workspaces" : { }, "formats" : { "csv" : { "type" : "text", "extensions" : [ "csv" ], "delimiter" : "," }, "tsv" : { "type" : "text", "extensions" : [ "tsv" ], "delimiter" : "\t" }, "json" : { "type" : "json", "extensions" : [ "json" ] }, "parquet" : { "type" : "parquet" }, "avro" : { "type" : "avro" }, "csvh" : { "type" : "text", "extensions" : [ "csvh" ], "extractHeader" : true, "delimiter" : "," }, "image" : { "type" : "image", "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", "x3f" ] } }, "enabled" : true } }, { "name" : "dfs", "config" : { "type" : "file", "connection" : "file:///", "config" : null, "workspaces" : { "tmp" : { "location" : "/tmp", "writable" : true, "defaultInputFormat" : null, "allowAccessOutsideWorkspace" : false }, "root" : { "location" : "/", "writable" : false, "defaultInputFormat" : null, "allowAccessOutsideWorkspace" : false } }, "formats" : { "psv" : { "type" : "text", "extensions" : [ "tbl" ], "delimiter" : "|" }, "csv" : { "type" : "text", "extensions" : [ "csv" ], "delimiter" : "," }, "tsv" : { "type" : "text", "extensions" : [ "tsv" ], "delimiter" : "\t" }, "httpd" : { "type" : "httpd", "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" }, "parquet" : { "type" : "parquet" }, "json" : { "type" : "json", "extensions" : [ "json" ] }, "pcap" : { "type" : "pcap" }, "pcapng" : { "type" : "pcapng", "extensions" : [ "pcapng" ] }, "avro" : { "type" : "avro" }, "sequencefile" : { "type" : "sequencefile", "extensions" : [ "seq" ] }, "csvh" : { "type" : "text", "extensions" : [ "csvh" ], "extractHeader" : true, "delimiter" : "," }, "image" : { "type" : "image", "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", "x3f" ] } }, "enabled" : true } }, { "name" : "hbase", "config" : { "type" : "hbase", "config" : { "hbase.zookeeper.quorum" : "localhost", "hbase.zookeeper.property.clientPort" : "2181" }, "size.calculator.enabled" : false, "enabled" : false } }, { "name" : "hive", "config" : { "type" : "hive", "configProps" : { "hive.metastore.uris" : "", "javax.jdo.option.ConnectionURL" : "jdbc:derby:;databaseName=../sample-data/drill_hive_db;create=true", "hive.metastore.warehouse.dir" : "/tmp/drill_hive_wh", "fs.default.name" : "file:///", "hive.metastore.sasl.enabled" : "false", "hive.metastore.schema.verification" : "false", "datanucleus.schema.autoCreateAll" : "true" }, "enabled" : false } }, { "name" : "kafka", "config" : { "type" : "kafka", "kafkaConsumerProps" : { "bootstrap.servers" : "localhost:9092", "group.id" : "drill-consumer" }, "enabled" : false } }, { "name" : "kudu", "config" : { "type" : "kudu", "masterAddresses" : "1.2.3.4", "enabled" : false } }, { "name" : "mongo", "config" : { "type" : "mongo", "connection" : "mongodb://localhost:27017/", "enabled" : false } }, { "name" : "opentsdb", "config" : { "type" : "openTSDB", "connection" : "http://localhost:1";, "enabled" : false } }, { "name" : "s3", "config" : { "type" : "file", "connection" : "s3a://my.bucket.location.com", "config" : { "fs.s3a.access.key" : "ID", "fs.s3a.secret.key" : "SECRET" }, "workspaces" : { "tmp" : { "location" : "/tmp", "writable" : true, "default
[jira] [Updated] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva updated DRILL-7186: Reviewer: Vitalii Diravka > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Arina Ielchiieva >Priority: Blocker > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened: > {noformat} > [ { > "name" : "cp", > "config" : { > "type" : "file", > "connection" : "classpath:///", > "config" : null, > "workspaces" : { }, > "formats" : { > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "parquet" : { > "type" : "parquet" > }, > "avro" : { > "type" : "avro" > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "dfs", > "config" : { > "type" : "file", > "connection" : "file:///", > "config" : null, > "workspaces" : { > "tmp" : { > "location" : "/tmp", > "writable" : true, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > }, > "root" : { > "location" : "/", > "writable" : false, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > } > }, > "formats" : { > "psv" : { > "type" : "text", > "extensions" : [ "tbl" ], > "delimiter" : "|" > }, > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "httpd" : { > "type" : "httpd", > "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" > }, > "parquet" : { > "type" : "parquet" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "pcap" : { > "type" : "pcap" > }, > "pcapng" : { > "type" : "pcapng", > "extensions" : [ "pcapng" ] > }, > "avro" : { > "type" : "avro" > }, > "sequencefile" : { > "type" : "sequencefile", > "extensions" : [ "seq" ] > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "hbase", > "config" : { > "type" : "hbase", > "config" : { > "hbase.zookeeper.quorum" : "localhost", > "hbase.zookeeper.property.clientPort" : "2181" > }, > "size.calculator.enabled" : false, > "enabled" : false > } > }, { > "name" : "hive", > "config" : { > "type" : "hive", > "configProps" : { > "hive.metastore.uris" : "", > "javax.jdo.option.ConnectionURL" : > "jdbc:derby:;databaseName=../sample-data/drill_hive_db;create=true", > "hive.metastore.warehouse.dir" : "/tmp/drill_hive_wh", > "fs.default.name" : "file:///", > "hive.metastore.sasl.enabled" : "false", > "hive.metastore.schema.verification" : "false", > "datanucleus.schema.autoCreateAll" : "true" > }, > "enabled" : false > } > }, { > "name" : "kafka", > "config" : { > "type" : "kafka", > "kafkaConsumerProps" : { > "bootstrap.servers" : "localhost:9092", > "group.id" : "dril
[jira] [Commented] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821908#comment-16821908 ] ASF GitHub Bot commented on DRILL-7186: --- arina-ielchiieva commented on pull request #1757: DRILL-7186: Add back storage.json REST endpoint (regression after DRILL-6562) URL: https://github.com/apache/drill/pull/1757 Details - [DRILL-7186](https://issues.apache.org/jira/browse/DRILL-7186). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Arina Ielchiieva >Priority: Blocker > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened: > {noformat} > [ { > "name" : "cp", > "config" : { > "type" : "file", > "connection" : "classpath:///", > "config" : null, > "workspaces" : { }, > "formats" : { > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "parquet" : { > "type" : "parquet" > }, > "avro" : { > "type" : "avro" > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "dfs", > "config" : { > "type" : "file", > "connection" : "file:///", > "config" : null, > "workspaces" : { > "tmp" : { > "location" : "/tmp", > "writable" : true, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > }, > "root" : { > "location" : "/", > "writable" : false, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > } > }, > "formats" : { > "psv" : { > "type" : "text", > "extensions" : [ "tbl" ], > "delimiter" : "|" > }, > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "httpd" : { > "type" : "httpd", > "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" > }, > "parquet" : { > "type" : "parquet" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "pcap" : { > "type" : "pcap" > }, > "pcapng" : { > "type" : "pcapng", > "extensions" : [ "pcapng" ] > }, > "avro" : { > "type" : "avro" > }, > "sequencefile" : { > "type" : "sequencefile", > "extensions" : [ "seq" ] > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "hbase", > "config" : { > "type" : "hbase", > "config" : { > "hbase.zookeeper.quorum" : "localhost", > "hbase.zookeeper.property.clientPort" : "2181" > }, > "size.calculator.enabled" : false, > "enabled" : false > } > }, { > "name" : "hive", > "config" : { > "type" : "hive", > "configProps" : { > "hive.metastore
[jira] [Commented] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821909#comment-16821909 ] ASF GitHub Bot commented on DRILL-7186: --- arina-ielchiieva commented on issue #1757: DRILL-7186: Add back storage.json REST endpoint (regression after DRILL-6562) URL: https://github.com/apache/drill/pull/1757#issuecomment-484892041 @vdiravka please review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Arina Ielchiieva >Priority: Blocker > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened: > {noformat} > [ { > "name" : "cp", > "config" : { > "type" : "file", > "connection" : "classpath:///", > "config" : null, > "workspaces" : { }, > "formats" : { > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "parquet" : { > "type" : "parquet" > }, > "avro" : { > "type" : "avro" > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "dfs", > "config" : { > "type" : "file", > "connection" : "file:///", > "config" : null, > "workspaces" : { > "tmp" : { > "location" : "/tmp", > "writable" : true, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > }, > "root" : { > "location" : "/", > "writable" : false, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > } > }, > "formats" : { > "psv" : { > "type" : "text", > "extensions" : [ "tbl" ], > "delimiter" : "|" > }, > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "httpd" : { > "type" : "httpd", > "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" > }, > "parquet" : { > "type" : "parquet" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "pcap" : { > "type" : "pcap" > }, > "pcapng" : { > "type" : "pcapng", > "extensions" : [ "pcapng" ] > }, > "avro" : { > "type" : "avro" > }, > "sequencefile" : { > "type" : "sequencefile", > "extensions" : [ "seq" ] > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "hbase", > "config" : { > "type" : "hbase", > "config" : { > "hbase.zookeeper.quorum" : "localhost", > "hbase.zookeeper.property.clientPort" : "2181" > }, > "size.calculator.enabled" : false, > "enabled" : false > } > }, { > "name" : "hive", > "config" : { > "type" : "hive", > "configProps" : { > "hive.metastore.uris" : "", > "javax.jdo.o
[jira] [Updated] (DRILL-7185) Drill Fails to Read Large Packets
[ https://issues.apache.org/jira/browse/DRILL-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sorabh Hamirwasia updated DRILL-7185: - Labels: ready-to-commit (was: ) > Drill Fails to Read Large Packets > - > > Key: DRILL-7185 > URL: https://issues.apache.org/jira/browse/DRILL-7185 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.11.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Major > Labels: ready-to-commit > Fix For: 1.17.0 > > > Drill fails to read large packets and crashes. This small fix corrects that > issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7185) Drill Fails to Read Large Packets
[ https://issues.apache.org/jira/browse/DRILL-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sorabh Hamirwasia updated DRILL-7185: - Reviewer: Sorabh Hamirwasia > Drill Fails to Read Large Packets > - > > Key: DRILL-7185 > URL: https://issues.apache.org/jira/browse/DRILL-7185 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.11.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Major > Labels: ready-to-commit > Fix For: 1.17.0 > > > Drill fails to read large packets and crashes. This small fix corrects that > issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7185) Drill Fails to Read Large Packets
[ https://issues.apache.org/jira/browse/DRILL-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822012#comment-16822012 ] Sorabh Hamirwasia commented on DRILL-7185: -- [~cgivre] - Please move the Jira to Reviewable state > Drill Fails to Read Large Packets > - > > Key: DRILL-7185 > URL: https://issues.apache.org/jira/browse/DRILL-7185 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.11.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Major > Labels: ready-to-commit > Fix For: 1.17.0 > > > Drill fails to read large packets and crashes. This small fix corrects that > issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (DRILL-3929) Support the ability to query database tables using external indices
[ https://issues.apache.org/jira/browse/DRILL-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Sinha resolved DRILL-3929. --- Resolution: Fixed Fix Version/s: 1.15.0 This feature was done in the scope of DRILL-6381. > Support the ability to query database tables using external indices > -- > > Key: DRILL-3929 > URL: https://issues.apache.org/jira/browse/DRILL-3929 > Project: Apache Drill > Issue Type: New Feature > Components: Execution - Relational Operators, Query Planning & > Optimization >Reporter: Aman Sinha >Assignee: Aman Sinha >Priority: Major > Fix For: 1.15.0 > > > This is a placeholder for adding support in Drill to query database tables > using external indices. I will add more details about the use case and a > preliminary design proposal. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (DRILL-7187) Improve selectivity estimates for range predicates when using histogram
Aman Sinha created DRILL-7187: - Summary: Improve selectivity estimates for range predicates when using histogram Key: DRILL-7187 URL: https://issues.apache.org/jira/browse/DRILL-7187 Project: Apache Drill Issue Type: Bug Reporter: Aman Sinha Assignee: Aman Sinha 2 types of selectivity estimation improvements need to be done: 1. For range predicates on the same column, we need to collect all such predicates in 1 group and do a histogram lookup for them together. For instance: {noformat} WHERE a > 10 AND b < 20 AND c = 100 AND a <= 50 AND b < 50 {noformat} Currently, the Drill behavior is to treat each of the conjuncts independently and multiply the individual selectivities. However, that will not give the accurate estimates. Here, we want to group the predicates on 'a' together and do a single lookup. Similarly for 'b'. 2. NULLs are not maintained by the histogram but when doing the selectivity calculations, the histogram should use the totalRowCount as the denominator rather than the non-null count. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7187) Improve selectivity estimates for range predicates when using histogram
[ https://issues.apache.org/jira/browse/DRILL-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Sinha updated DRILL-7187: -- Fix Version/s: 1.17.0 > Improve selectivity estimates for range predicates when using histogram > --- > > Key: DRILL-7187 > URL: https://issues.apache.org/jira/browse/DRILL-7187 > Project: Apache Drill > Issue Type: Bug >Reporter: Aman Sinha >Assignee: Aman Sinha >Priority: Major > Fix For: 1.17.0 > > > 2 types of selectivity estimation improvements need to be done: > 1. For range predicates on the same column, we need to collect all such > predicates in 1 group and do a histogram lookup for them together. > For instance: > {noformat} > WHERE a > 10 AND b < 20 AND c = 100 AND a <= 50 AND b < 50 > {noformat} > Currently, the Drill behavior is to treat each of the conjuncts > independently and multiply the individual selectivities. However, that will > not give the accurate estimates. Here, we want to group the predicates on 'a' > together and do a single lookup. Similarly for 'b'. > 2. NULLs are not maintained by the histogram but when doing the selectivity > calculations, the histogram should use the totalRowCount as the denominator > rather than the non-null count. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva updated DRILL-7186: Labels: ready-to-commit (was: ) > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Arina Ielchiieva >Priority: Blocker > Labels: ready-to-commit > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened: > {noformat} > [ { > "name" : "cp", > "config" : { > "type" : "file", > "connection" : "classpath:///", > "config" : null, > "workspaces" : { }, > "formats" : { > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "parquet" : { > "type" : "parquet" > }, > "avro" : { > "type" : "avro" > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "dfs", > "config" : { > "type" : "file", > "connection" : "file:///", > "config" : null, > "workspaces" : { > "tmp" : { > "location" : "/tmp", > "writable" : true, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > }, > "root" : { > "location" : "/", > "writable" : false, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > } > }, > "formats" : { > "psv" : { > "type" : "text", > "extensions" : [ "tbl" ], > "delimiter" : "|" > }, > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "httpd" : { > "type" : "httpd", > "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" > }, > "parquet" : { > "type" : "parquet" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "pcap" : { > "type" : "pcap" > }, > "pcapng" : { > "type" : "pcapng", > "extensions" : [ "pcapng" ] > }, > "avro" : { > "type" : "avro" > }, > "sequencefile" : { > "type" : "sequencefile", > "extensions" : [ "seq" ] > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "hbase", > "config" : { > "type" : "hbase", > "config" : { > "hbase.zookeeper.quorum" : "localhost", > "hbase.zookeeper.property.clientPort" : "2181" > }, > "size.calculator.enabled" : false, > "enabled" : false > } > }, { > "name" : "hive", > "config" : { > "type" : "hive", > "configProps" : { > "hive.metastore.uris" : "", > "javax.jdo.option.ConnectionURL" : > "jdbc:derby:;databaseName=../sample-data/drill_hive_db;create=true", > "hive.metastore.warehouse.dir" : "/tmp/drill_hive_wh", > "fs.default.name" : "file:///", > "hive.metastore.sasl.enabled" : "false", > "hive.metastore.schema.verification" : "false", > "datanucleus.schema.autoCreateAll" : "true" > }, > "enabled" : false > } > }, { > "name" : "kafka", > "config" : { > "type" : "kafka", > "kafkaConsumerProps" : { > "bootstrap.servers"
[jira] [Commented] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822052#comment-16822052 ] Sorabh Hamirwasia commented on DRILL-7186: -- @vdiravka / [~arina] With DRILL-6562 I am seeing additional changes which is not supporting older requests URL. For example: 1) Earlier export of plugin config was done for json format by default using URL: */storage/\{name}/export* and now the new URL is */storage/\{name}/export/\{format}*. This means the older one is not supported anymore. Is it intended or should we treat the format as JSON by default if not provided ? 2) The POST URL to create and update plugin is changed from */storage/\{name}* to */storage/create_update* > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Arina Ielchiieva >Priority: Blocker > Labels: ready-to-commit > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened: > {noformat} > [ { > "name" : "cp", > "config" : { > "type" : "file", > "connection" : "classpath:///", > "config" : null, > "workspaces" : { }, > "formats" : { > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "parquet" : { > "type" : "parquet" > }, > "avro" : { > "type" : "avro" > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "dfs", > "config" : { > "type" : "file", > "connection" : "file:///", > "config" : null, > "workspaces" : { > "tmp" : { > "location" : "/tmp", > "writable" : true, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > }, > "root" : { > "location" : "/", > "writable" : false, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > } > }, > "formats" : { > "psv" : { > "type" : "text", > "extensions" : [ "tbl" ], > "delimiter" : "|" > }, > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "httpd" : { > "type" : "httpd", > "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" > }, > "parquet" : { > "type" : "parquet" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "pcap" : { > "type" : "pcap" > }, > "pcapng" : { > "type" : "pcapng", > "extensions" : [ "pcapng" ] > }, > "avro" : { > "type" : "avro" > }, > "sequencefile" : { > "type" : "sequencefile", > "extensions" : [ "seq" ] > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "hbase", > "config" : { > "type" : "hbase", > "config" : { > "hbase.zookeeper.quorum" : "localhost", > "hbase.zookeeper.property.clientPort" : "2181" > }, > "size.calculator.enabled" : false, > "enabled" : false > } > }, { > "name" : "hive", > "config" : { > "type" : "hive", > "configProps" : { > "hive
[jira] [Comment Edited] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822052#comment-16822052 ] Sorabh Hamirwasia edited comment on DRILL-7186 at 4/19/19 5:02 PM: --- @vdiravka / [~arina] With DRILL-6562 I am seeing additional changes which is not supporting older requests URL. For example: 1) Earlier export of plugin config was done for json format by default using URL: */storage/\{name}/export* and now the new URL is */storage/\{name}/export/\{format}*. This means the older one is not supported anymore. Is it intended or should we treat the format as JSON by default if not provided ? 2) The POST URL to create and update plugin is changed from */storage/\{name}* to */storage/create_update* 3) Once a storage plugin is deleted it is not redirected to */storage* anymore, which it was in 1.15. Because of this line change: [https://github.com/apache/drill/commit/5fff1d8bff899e1af551c16f26a58b6b1d033ffb#diff-274673e64e6f54be595a8703753123b0R115] was (Author: shamirwasia): @vdiravka / [~arina] With DRILL-6562 I am seeing additional changes which is not supporting older requests URL. For example: 1) Earlier export of plugin config was done for json format by default using URL: */storage/\{name}/export* and now the new URL is */storage/\{name}/export/\{format}*. This means the older one is not supported anymore. Is it intended or should we treat the format as JSON by default if not provided ? 2) The POST URL to create and update plugin is changed from */storage/\{name}* to */storage/create_update* > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Arina Ielchiieva >Priority: Blocker > Labels: ready-to-commit > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened: > {noformat} > [ { > "name" : "cp", > "config" : { > "type" : "file", > "connection" : "classpath:///", > "config" : null, > "workspaces" : { }, > "formats" : { > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "parquet" : { > "type" : "parquet" > }, > "avro" : { > "type" : "avro" > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "dfs", > "config" : { > "type" : "file", > "connection" : "file:///", > "config" : null, > "workspaces" : { > "tmp" : { > "location" : "/tmp", > "writable" : true, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > }, > "root" : { > "location" : "/", > "writable" : false, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > } > }, > "formats" : { > "psv" : { > "type" : "text", > "extensions" : [ "tbl" ], > "delimiter" : "|" > }, > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "httpd" : { > "type" : "httpd", > "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" > }, > "parquet" : { > "type" : "parquet" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "pcap" : { > "type" : "pcap" > }, > "pcapng" : { > "type" : "pcapng", > "extensions" : [ "pcapng" ] > }, > "avro" : { > "type" : "avro" > }, > "sequencefile" : { > "type" : "sequencefile", > "extensions" : [ "seq" ] > }, > "csvh" : { > "type" : "text", > "extensions"
[jira] [Updated] (DRILL-7185) Drill Fails to Read Large Packets
[ https://issues.apache.org/jira/browse/DRILL-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sorabh Hamirwasia updated DRILL-7185: - Fix Version/s: (was: 1.17.0) 1.16.0 > Drill Fails to Read Large Packets > - > > Key: DRILL-7185 > URL: https://issues.apache.org/jira/browse/DRILL-7185 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.11.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Major > Labels: ready-to-commit > Fix For: 1.16.0 > > > Drill fails to read large packets and crashes. This small fix corrects that > issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (DRILL-7188) Revert DRILL-6642: Update protocol-buffers version
Sorabh Hamirwasia created DRILL-7188: Summary: Revert DRILL-6642: Update protocol-buffers version Key: DRILL-7188 URL: https://issues.apache.org/jira/browse/DRILL-7188 Project: Apache Drill Issue Type: Task Components: Tools, Build & Test Affects Versions: 1.16.0 Reporter: Sorabh Hamirwasia Assignee: Sorabh Hamirwasia Fix For: 1.16.0 Revert the protobuf changes for 1.16 branch only. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7164) KafkaFilterPushdownTest is sometimes failing to pattern match correctly.
[ https://issues.apache.org/jira/browse/DRILL-7164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822083#comment-16822083 ] ASF GitHub Bot commented on DRILL-7164: --- aravi5 commented on issue #1751: DRILL-7164: KafkaFilterPushdownTest is sometimes failing to pattern match correctly URL: https://github.com/apache/drill/pull/1751#issuecomment-484965559 @sohami has the proposed changes ready that addresses his review comments and will open another PR for it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > KafkaFilterPushdownTest is sometimes failing to pattern match correctly. > > > Key: DRILL-7164 > URL: https://issues.apache.org/jira/browse/DRILL-7164 > Project: Apache Drill > Issue Type: Bug > Components: Storage - Kafka >Affects Versions: 1.16.0 >Reporter: Hanumath Rao Maduri >Assignee: Abhishek Ravi >Priority: Major > Fix For: 1.17.0 > > > On my private build I am hitting kafka storage tests issue intermittently. > Here is the issue which I came across. > {code} > at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_91] > 15:01:39.852 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: > -292 B(75.4 KiB), h: -391.1 MiB(240.7 MiB), nh: 824.5 KiB(129.0 MiB)): > testPushdownOffsetOneRecordReturnedWithBoundaryConditions(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest) > java.lang.AssertionError: Unable to find expected string "kafkaScanSpec" > : { > "topicName" : "drill-pushdown-topic" > }, > "cost" in plan: { > "head" : { > "version" : 1, > "generator" : { > "type" : "ExplainHandler", > "info" : "" > }, > "type" : "APACHE_DRILL_PHYSICAL", > "options" : [ { > "kind" : "STRING", > "accessibleScopes" : "ALL", > "name" : "store.kafka.record.reader", > "string_val" : > "org.apache.drill.exec.store.kafka.decoders.JsonMessageReader", > "scope" : "SESSION" > }, { > "kind" : "BOOLEAN", > "accessibleScopes" : "ALL", > "name" : "exec.errors.verbose", > "bool_val" : true, > "scope" : "SESSION" > }, { > "kind" : "LONG", > "accessibleScopes" : "ALL", > "name" : "store.kafka.poll.timeout", > "num_val" : 5000, > "scope" : "SESSION" > }, { > "kind" : "LONG", > "accessibleScopes" : "ALL", > "name" : "planner.width.max_per_node", > "num_val" : 2, > "scope" : "SESSION" > } ], > "queue" : 0, > "hasResourcePlan" : false, > "resultMode" : "EXEC" > }, > "graph" : [ { > "pop" : "kafka-scan", > "@id" : 6, > "userName" : "", > "kafkaStoragePluginConfig" : { > "type" : "kafka", > "kafkaConsumerProps" : { > "bootstrap.servers" : "127.0.0.1:56524", > "group.id" : "drill-test-consumer" > }, > "enabled" : true > }, > "columns" : [ "`**`", "`kafkaMsgOffset`" ], > "kafkaScanSpec" : { > "topicName" : "drill-pushdown-topic" > }, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 5.0 > } > }, { > "pop" : "project", > "@id" : 5, > "exprs" : [ { > "ref" : "`T23¦¦**`", > "expr" : "`**`" > }, { > "ref" : "`kafkaMsgOffset`", > "expr" : "`kafkaMsgOffset`" > } ], > "child" : 6, > "outputProj" : false, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 5.0 > } > }, { > "pop" : "filter", > "@id" : 4, > "child" : 5, > "expr" : "equal(`kafkaMsgOffset`, 9) ", > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 0.75 > } > }, { > "pop" : "selection-vector-remover", > "@id" : 3, > "child" : 4, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 1.0 > } > }, { > "pop" : "project", > "@id" : 2, > "exprs" : [ { > "ref" : "`T23¦¦**`", > "expr" : "`T23¦¦**`" > } ], > "child" : 3, > "outputProj" : false, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 1.0 > } >
[jira] [Commented] (DRILL-7164) KafkaFilterPushdownTest is sometimes failing to pattern match correctly.
[ https://issues.apache.org/jira/browse/DRILL-7164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822084#comment-16822084 ] ASF GitHub Bot commented on DRILL-7164: --- aravi5 commented on pull request #1751: DRILL-7164: KafkaFilterPushdownTest is sometimes failing to pattern match correctly URL: https://github.com/apache/drill/pull/1751 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > KafkaFilterPushdownTest is sometimes failing to pattern match correctly. > > > Key: DRILL-7164 > URL: https://issues.apache.org/jira/browse/DRILL-7164 > Project: Apache Drill > Issue Type: Bug > Components: Storage - Kafka >Affects Versions: 1.16.0 >Reporter: Hanumath Rao Maduri >Assignee: Abhishek Ravi >Priority: Major > Fix For: 1.17.0 > > > On my private build I am hitting kafka storage tests issue intermittently. > Here is the issue which I came across. > {code} > at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_91] > 15:01:39.852 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: > -292 B(75.4 KiB), h: -391.1 MiB(240.7 MiB), nh: 824.5 KiB(129.0 MiB)): > testPushdownOffsetOneRecordReturnedWithBoundaryConditions(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest) > java.lang.AssertionError: Unable to find expected string "kafkaScanSpec" > : { > "topicName" : "drill-pushdown-topic" > }, > "cost" in plan: { > "head" : { > "version" : 1, > "generator" : { > "type" : "ExplainHandler", > "info" : "" > }, > "type" : "APACHE_DRILL_PHYSICAL", > "options" : [ { > "kind" : "STRING", > "accessibleScopes" : "ALL", > "name" : "store.kafka.record.reader", > "string_val" : > "org.apache.drill.exec.store.kafka.decoders.JsonMessageReader", > "scope" : "SESSION" > }, { > "kind" : "BOOLEAN", > "accessibleScopes" : "ALL", > "name" : "exec.errors.verbose", > "bool_val" : true, > "scope" : "SESSION" > }, { > "kind" : "LONG", > "accessibleScopes" : "ALL", > "name" : "store.kafka.poll.timeout", > "num_val" : 5000, > "scope" : "SESSION" > }, { > "kind" : "LONG", > "accessibleScopes" : "ALL", > "name" : "planner.width.max_per_node", > "num_val" : 2, > "scope" : "SESSION" > } ], > "queue" : 0, > "hasResourcePlan" : false, > "resultMode" : "EXEC" > }, > "graph" : [ { > "pop" : "kafka-scan", > "@id" : 6, > "userName" : "", > "kafkaStoragePluginConfig" : { > "type" : "kafka", > "kafkaConsumerProps" : { > "bootstrap.servers" : "127.0.0.1:56524", > "group.id" : "drill-test-consumer" > }, > "enabled" : true > }, > "columns" : [ "`**`", "`kafkaMsgOffset`" ], > "kafkaScanSpec" : { > "topicName" : "drill-pushdown-topic" > }, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 5.0 > } > }, { > "pop" : "project", > "@id" : 5, > "exprs" : [ { > "ref" : "`T23¦¦**`", > "expr" : "`**`" > }, { > "ref" : "`kafkaMsgOffset`", > "expr" : "`kafkaMsgOffset`" > } ], > "child" : 6, > "outputProj" : false, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 5.0 > } > }, { > "pop" : "filter", > "@id" : 4, > "child" : 5, > "expr" : "equal(`kafkaMsgOffset`, 9) ", > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 0.75 > } > }, { > "pop" : "selection-vector-remover", > "@id" : 3, > "child" : 4, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 1.0 > } > }, { > "pop" : "project", > "@id" : 2, > "exprs" : [ { > "ref" : "`T23¦¦**`", > "expr" : "`T23¦¦**`" > } ], > "child" : 3, > "outputProj" : false, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 1.0 > } > }, { > "pop" : "project", > "@id" : 1, > "exprs" : [ { > "ref" : "`**`", > "expr" : "`T23¦¦**`"
[jira] [Created] (DRILL-7189) Revert DRILL-7105 Error while building the Drill native client
Sorabh Hamirwasia created DRILL-7189: Summary: Revert DRILL-7105 Error while building the Drill native client Key: DRILL-7189 URL: https://issues.apache.org/jira/browse/DRILL-7189 Project: Apache Drill Issue Type: Task Components: Client - C++ Affects Versions: 1.16.0 Reporter: Sorabh Hamirwasia Assignee: Sorabh Hamirwasia Fix For: 1.16.0 Revert the change in 1.16 branch only since protobuf upgrade change is also reverted using DRILL-7188 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7188) Revert DRILL-6642: Update protocol-buffers version
[ https://issues.apache.org/jira/browse/DRILL-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822086#comment-16822086 ] ASF GitHub Bot commented on DRILL-7188: --- sohami commented on pull request #1758: DRILL-7188: Revert DRILL-6642: Update protocol-buffers version URL: https://github.com/apache/drill/pull/1758 1. Updated protobuf to version 3.6.1 2. Added protobuf to the root pom dependency management 3. Added classes BoundedByteString and LiteralByteString for compatibility with HBase 4. Added ProtobufPatcher to provide compatibility with MapR-DB and HBase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Revert DRILL-6642: Update protocol-buffers version > -- > > Key: DRILL-7188 > URL: https://issues.apache.org/jira/browse/DRILL-7188 > Project: Apache Drill > Issue Type: Task > Components: Tools, Build & Test >Affects Versions: 1.16.0 >Reporter: Sorabh Hamirwasia >Assignee: Sorabh Hamirwasia >Priority: Major > Fix For: 1.16.0 > > > Revert the protobuf changes for 1.16 branch only. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7189) Revert DRILL-7105 Error while building the Drill native client
[ https://issues.apache.org/jira/browse/DRILL-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822087#comment-16822087 ] ASF GitHub Bot commented on DRILL-7189: --- sohami commented on pull request #1759: DRILL-7189: Revert DRILL-7105 Error while building the Drill native c… URL: https://github.com/apache/drill/pull/1759 …lient This reverts commit a72f1700a8d260a2f92ba8955c77df6428feb919. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Revert DRILL-7105 Error while building the Drill native client > -- > > Key: DRILL-7189 > URL: https://issues.apache.org/jira/browse/DRILL-7189 > Project: Apache Drill > Issue Type: Task > Components: Client - C++ >Affects Versions: 1.16.0 >Reporter: Sorabh Hamirwasia >Assignee: Sorabh Hamirwasia >Priority: Major > Fix For: 1.16.0 > > > Revert the change in 1.16 branch only since protobuf upgrade change is also > reverted using DRILL-7188 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-6642) Update protocol-buffers version
[ https://issues.apache.org/jira/browse/DRILL-6642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sorabh Hamirwasia updated DRILL-6642: - Fix Version/s: (was: 1.16.0) > Update protocol-buffers version > --- > > Key: DRILL-6642 > URL: https://issues.apache.org/jira/browse/DRILL-6642 > Project: Apache Drill > Issue Type: Task > Components: Tools, Build & Test >Affects Versions: 1.14.0 >Reporter: Vitalii Diravka >Assignee: Anton Gozhiy >Priority: Major > Fix For: 1.17.0 > > > Currently Drill uses 2.5.0 {{protocol-buffers}} version. > The last version is 3.6.0 in maven repo: > [https://mvnrepository.com/artifact/com.google.protobuf/protobuf-java] > The new version has a lot of useful enhancements, which can be used in Drill. > One of them is using {{UNRECOGNIZED Enum NullValue}}, which can help to > handle them in place of null values for {{ProtocolMessageEnum}} - DRILL-6639. > Looks like the NullValue can be used instead of null returned from > {{valueOf()}} (_or {{forNumber()}}, since {{valueOf()}} is deprecated in the > newer protobuf version_): > > [https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/NullValue] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (DRILL-6642) Update protocol-buffers version
[ https://issues.apache.org/jira/browse/DRILL-6642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821422#comment-16821422 ] Sorabh Hamirwasia edited comment on DRILL-6642 at 4/19/19 5:47 PM: --- This change is reverted into 1.16 version and tracked by DRILL-7188 was (Author: shamirwasia): This change is reverted into 1.16 version > Update protocol-buffers version > --- > > Key: DRILL-6642 > URL: https://issues.apache.org/jira/browse/DRILL-6642 > Project: Apache Drill > Issue Type: Task > Components: Tools, Build & Test >Affects Versions: 1.14.0 >Reporter: Vitalii Diravka >Assignee: Anton Gozhiy >Priority: Major > Fix For: 1.17.0 > > > Currently Drill uses 2.5.0 {{protocol-buffers}} version. > The last version is 3.6.0 in maven repo: > [https://mvnrepository.com/artifact/com.google.protobuf/protobuf-java] > The new version has a lot of useful enhancements, which can be used in Drill. > One of them is using {{UNRECOGNIZED Enum NullValue}}, which can help to > handle them in place of null values for {{ProtocolMessageEnum}} - DRILL-6639. > Looks like the NullValue can be used instead of null returned from > {{valueOf()}} (_or {{forNumber()}}, since {{valueOf()}} is deprecated in the > newer protobuf version_): > > [https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/NullValue] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (DRILL-7105) Error while building the Drill native client
[ https://issues.apache.org/jira/browse/DRILL-7105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821423#comment-16821423 ] Sorabh Hamirwasia edited comment on DRILL-7105 at 4/19/19 5:47 PM: --- This change is reverted in 1.16.0 branch and tracked by DRILL-7189 was (Author: shamirwasia): This change is reverted in 1.16.0 branch > Error while building the Drill native client > > > Key: DRILL-7105 > URL: https://issues.apache.org/jira/browse/DRILL-7105 > Project: Apache Drill > Issue Type: Bug > Components: Client - C++ >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Anton Gozhiy >Priority: Major > Labels: ready-to-commit > Fix For: 1.17.0 > > > *Steps:* > # cd contrib/native/client > # mkdir build > # cd build && cmake -std=c++11 -G "Unix Makefiles" -D CMAKE_BUILD_TYPE=Debug > .. > # make > *Expected result:* > The native client is built successfully. > *Actual result:* > Error happens: > {noformat} > [ 4%] Built target y2038 > [ 7%] Building CXX object > src/protobuf/CMakeFiles/protomsgs.dir/BitControl.pb.cc.o > In file included from /usr/include/c++/5/mutex:35:0, > from /usr/local/include/google/protobuf/stubs/mutex.h:33, > from /usr/local/include/google/protobuf/stubs/common.h:52, > from > /home/agozhiy/git_repo/drill/contrib/native/client/src/protobuf/BitControl.pb.h:9, > from > /home/agozhiy/git_repo/drill/contrib/native/client/src/protobuf/BitControl.pb.cc:4: > /usr/include/c++/5/bits/c++0x_warning.h:32:2: error: #error This file > requires compiler and library support for the ISO C++ 2011 standard. This > support must be enabled with the -std=c++11 or -std=gnu++11 compiler options. > #error This file requires compiler and library support \ > ^ > In file included from /usr/local/include/google/protobuf/stubs/common.h:52:0, > from > /home/agozhiy/git_repo/drill/contrib/native/client/src/protobuf/BitControl.pb.h:9, > from > /home/agozhiy/git_repo/drill/contrib/native/client/src/protobuf/BitControl.pb.cc:4: > /usr/local/include/google/protobuf/stubs/mutex.h:58:8: error: 'mutex' in > namespace 'std' does not name a type >std::mutex mu_; > ^ > /usr/local/include/google/protobuf/stubs/mutex.h: In member function 'void > google::protobuf::internal::WrappedMutex::Lock()': > /usr/local/include/google/protobuf/stubs/mutex.h:51:17: error: 'mu_' was not > declared in this scope >void Lock() { mu_.lock(); } > ^ > /usr/local/include/google/protobuf/stubs/mutex.h: In member function 'void > google::protobuf::internal::WrappedMutex::Unlock()': > /usr/local/include/google/protobuf/stubs/mutex.h:52:19: error: 'mu_' was not > declared in this scope >void Unlock() { mu_.unlock(); } >^ > /usr/local/include/google/protobuf/stubs/mutex.h: At global scope: > /usr/local/include/google/protobuf/stubs/mutex.h:61:7: error: expected > nested-name-specifier before 'Mutex' > using Mutex = WrappedMutex; >^ > /usr/local/include/google/protobuf/stubs/mutex.h:66:28: error: expected ')' > before '*' token >explicit MutexLock(Mutex *mu) : mu_(mu) { this->mu_->Lock(); } > ^ > /usr/local/include/google/protobuf/stubs/mutex.h:69:3: error: 'Mutex' does > not name a type >Mutex *const mu_; >^ > /usr/local/include/google/protobuf/stubs/mutex.h: In destructor > 'google::protobuf::internal::MutexLock::~MutexLock()': > /usr/local/include/google/protobuf/stubs/mutex.h:67:24: error: 'class > google::protobuf::internal::MutexLock' has no member named 'mu_' >~MutexLock() { this->mu_->Unlock(); } > ^ > /usr/local/include/google/protobuf/stubs/mutex.h: At global scope: > /usr/local/include/google/protobuf/stubs/mutex.h:80:33: error: expected ')' > before '*' token >explicit MutexLockMaybe(Mutex *mu) : > ^ > In file included from /usr/local/include/google/protobuf/arena.h:48:0, > from > /home/agozhiy/git_repo/drill/contrib/native/client/src/protobuf/BitControl.pb.h:23, > from > /home/agozhiy/git_repo/drill/contrib/native/client/src/protobuf/BitControl.pb.cc:4: > /usr/include/c++/5/typeinfo:39:37: error: expected '}' before end of line > /usr/include/c++/5/typeinfo:39:37: error: expected unqualified-id before end > of line > /usr/include/c++/5/typeinfo:39:37: error: expected '}' before end of line > /usr/include/c++/5/typeinfo:39:37: error: expected '}' before end of line > /usr/include/c++/5/typeinfo:39:37: error: expected '}' before end of line > /usr/include/c++/5/typeinfo:39:37: error: expected declaration before end
[jira] [Updated] (DRILL-7105) Error while building the Drill native client
[ https://issues.apache.org/jira/browse/DRILL-7105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sorabh Hamirwasia updated DRILL-7105: - Fix Version/s: (was: 1.16.0) > Error while building the Drill native client > > > Key: DRILL-7105 > URL: https://issues.apache.org/jira/browse/DRILL-7105 > Project: Apache Drill > Issue Type: Bug > Components: Client - C++ >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Anton Gozhiy >Priority: Major > Labels: ready-to-commit > Fix For: 1.17.0 > > > *Steps:* > # cd contrib/native/client > # mkdir build > # cd build && cmake -std=c++11 -G "Unix Makefiles" -D CMAKE_BUILD_TYPE=Debug > .. > # make > *Expected result:* > The native client is built successfully. > *Actual result:* > Error happens: > {noformat} > [ 4%] Built target y2038 > [ 7%] Building CXX object > src/protobuf/CMakeFiles/protomsgs.dir/BitControl.pb.cc.o > In file included from /usr/include/c++/5/mutex:35:0, > from /usr/local/include/google/protobuf/stubs/mutex.h:33, > from /usr/local/include/google/protobuf/stubs/common.h:52, > from > /home/agozhiy/git_repo/drill/contrib/native/client/src/protobuf/BitControl.pb.h:9, > from > /home/agozhiy/git_repo/drill/contrib/native/client/src/protobuf/BitControl.pb.cc:4: > /usr/include/c++/5/bits/c++0x_warning.h:32:2: error: #error This file > requires compiler and library support for the ISO C++ 2011 standard. This > support must be enabled with the -std=c++11 or -std=gnu++11 compiler options. > #error This file requires compiler and library support \ > ^ > In file included from /usr/local/include/google/protobuf/stubs/common.h:52:0, > from > /home/agozhiy/git_repo/drill/contrib/native/client/src/protobuf/BitControl.pb.h:9, > from > /home/agozhiy/git_repo/drill/contrib/native/client/src/protobuf/BitControl.pb.cc:4: > /usr/local/include/google/protobuf/stubs/mutex.h:58:8: error: 'mutex' in > namespace 'std' does not name a type >std::mutex mu_; > ^ > /usr/local/include/google/protobuf/stubs/mutex.h: In member function 'void > google::protobuf::internal::WrappedMutex::Lock()': > /usr/local/include/google/protobuf/stubs/mutex.h:51:17: error: 'mu_' was not > declared in this scope >void Lock() { mu_.lock(); } > ^ > /usr/local/include/google/protobuf/stubs/mutex.h: In member function 'void > google::protobuf::internal::WrappedMutex::Unlock()': > /usr/local/include/google/protobuf/stubs/mutex.h:52:19: error: 'mu_' was not > declared in this scope >void Unlock() { mu_.unlock(); } >^ > /usr/local/include/google/protobuf/stubs/mutex.h: At global scope: > /usr/local/include/google/protobuf/stubs/mutex.h:61:7: error: expected > nested-name-specifier before 'Mutex' > using Mutex = WrappedMutex; >^ > /usr/local/include/google/protobuf/stubs/mutex.h:66:28: error: expected ')' > before '*' token >explicit MutexLock(Mutex *mu) : mu_(mu) { this->mu_->Lock(); } > ^ > /usr/local/include/google/protobuf/stubs/mutex.h:69:3: error: 'Mutex' does > not name a type >Mutex *const mu_; >^ > /usr/local/include/google/protobuf/stubs/mutex.h: In destructor > 'google::protobuf::internal::MutexLock::~MutexLock()': > /usr/local/include/google/protobuf/stubs/mutex.h:67:24: error: 'class > google::protobuf::internal::MutexLock' has no member named 'mu_' >~MutexLock() { this->mu_->Unlock(); } > ^ > /usr/local/include/google/protobuf/stubs/mutex.h: At global scope: > /usr/local/include/google/protobuf/stubs/mutex.h:80:33: error: expected ')' > before '*' token >explicit MutexLockMaybe(Mutex *mu) : > ^ > In file included from /usr/local/include/google/protobuf/arena.h:48:0, > from > /home/agozhiy/git_repo/drill/contrib/native/client/src/protobuf/BitControl.pb.h:23, > from > /home/agozhiy/git_repo/drill/contrib/native/client/src/protobuf/BitControl.pb.cc:4: > /usr/include/c++/5/typeinfo:39:37: error: expected '}' before end of line > /usr/include/c++/5/typeinfo:39:37: error: expected unqualified-id before end > of line > /usr/include/c++/5/typeinfo:39:37: error: expected '}' before end of line > /usr/include/c++/5/typeinfo:39:37: error: expected '}' before end of line > /usr/include/c++/5/typeinfo:39:37: error: expected '}' before end of line > /usr/include/c++/5/typeinfo:39:37: error: expected declaration before end of > line > src/protobuf/CMakeFiles/protomsgs.dir/build.make:62: recipe for target > 'src/protobuf/CMakeFiles/protomsgs.dir/BitControl.pb.cc.o' failed > make[2]: *** [src/protobuf/CMakeFiles/protomsgs.dir/
[jira] [Commented] (DRILL-7188) Revert DRILL-6642: Update protocol-buffers version
[ https://issues.apache.org/jira/browse/DRILL-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822091#comment-16822091 ] ASF GitHub Bot commented on DRILL-7188: --- amansinha100 commented on issue #1758: DRILL-7188: Revert DRILL-6642: Update protocol-buffers version URL: https://github.com/apache/drill/pull/1758#issuecomment-484971486 lgtm. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Revert DRILL-6642: Update protocol-buffers version > -- > > Key: DRILL-7188 > URL: https://issues.apache.org/jira/browse/DRILL-7188 > Project: Apache Drill > Issue Type: Task > Components: Tools, Build & Test >Affects Versions: 1.16.0 >Reporter: Sorabh Hamirwasia >Assignee: Sorabh Hamirwasia >Priority: Major > Fix For: 1.16.0 > > > Revert the protobuf changes for 1.16 branch only. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7188) Revert DRILL-6642: Update protocol-buffers version
[ https://issues.apache.org/jira/browse/DRILL-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Vysotskyi updated DRILL-7188: --- Labels: ready-to-commit (was: ) > Revert DRILL-6642: Update protocol-buffers version > -- > > Key: DRILL-7188 > URL: https://issues.apache.org/jira/browse/DRILL-7188 > Project: Apache Drill > Issue Type: Task > Components: Tools, Build & Test >Affects Versions: 1.16.0 >Reporter: Sorabh Hamirwasia >Assignee: Sorabh Hamirwasia >Priority: Major > Labels: ready-to-commit > Fix For: 1.16.0 > > > Revert the protobuf changes for 1.16 branch only. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7189) Revert DRILL-7105 Error while building the Drill native client
[ https://issues.apache.org/jira/browse/DRILL-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Vysotskyi updated DRILL-7189: --- Labels: ready-to-commit (was: ) > Revert DRILL-7105 Error while building the Drill native client > -- > > Key: DRILL-7189 > URL: https://issues.apache.org/jira/browse/DRILL-7189 > Project: Apache Drill > Issue Type: Task > Components: Client - C++ >Affects Versions: 1.16.0 >Reporter: Sorabh Hamirwasia >Assignee: Sorabh Hamirwasia >Priority: Major > Labels: ready-to-commit > Fix For: 1.16.0 > > > Revert the change in 1.16 branch only since protobuf upgrade change is also > reverted using DRILL-7188 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822098#comment-16822098 ] ASF GitHub Bot commented on DRILL-7186: --- sohami commented on pull request #1757: DRILL-7186: Add back storage.json REST endpoint (regression after DRILL-6562) URL: https://github.com/apache/drill/pull/1757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Arina Ielchiieva >Priority: Blocker > Labels: ready-to-commit > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened: > {noformat} > [ { > "name" : "cp", > "config" : { > "type" : "file", > "connection" : "classpath:///", > "config" : null, > "workspaces" : { }, > "formats" : { > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "parquet" : { > "type" : "parquet" > }, > "avro" : { > "type" : "avro" > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "dfs", > "config" : { > "type" : "file", > "connection" : "file:///", > "config" : null, > "workspaces" : { > "tmp" : { > "location" : "/tmp", > "writable" : true, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > }, > "root" : { > "location" : "/", > "writable" : false, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > } > }, > "formats" : { > "psv" : { > "type" : "text", > "extensions" : [ "tbl" ], > "delimiter" : "|" > }, > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "httpd" : { > "type" : "httpd", > "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" > }, > "parquet" : { > "type" : "parquet" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "pcap" : { > "type" : "pcap" > }, > "pcapng" : { > "type" : "pcapng", > "extensions" : [ "pcapng" ] > }, > "avro" : { > "type" : "avro" > }, > "sequencefile" : { > "type" : "sequencefile", > "extensions" : [ "seq" ] > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "hbase", > "config" : { > "type" : "hbase", > "config" : { > "hbase.zookeeper.quorum" : "localhost", > "hbase.zookeeper.property.clientPort" : "2181" > }, > "size.calculator.enabled" : false, > "enabled" : false > } > }, { > "name" : "hive", > "config" : { > "type" : "hive", > "configProps" : { > "hive.metastore.uris" : "", > "javax.jdo.option.Conne
[jira] [Commented] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822099#comment-16822099 ] Vitalii Diravka commented on DRILL-7186: [~shamirwasia] Hi Sorabh, Thanks for finding these! That changes were made intentionally, but I agree the old behavior should be preserved for backward compatibility. I think additional methods can be added, which follows an old API and declared as deprecated. If you agree, I will write an email to \{{[VOTE] Apache Drill Release 1.16.0 - RC0}} about blocker for RC0 and will prepare the PR. Thanks > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Arina Ielchiieva >Priority: Blocker > Labels: ready-to-commit > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened: > {noformat} > [ { > "name" : "cp", > "config" : { > "type" : "file", > "connection" : "classpath:///", > "config" : null, > "workspaces" : { }, > "formats" : { > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "parquet" : { > "type" : "parquet" > }, > "avro" : { > "type" : "avro" > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "dfs", > "config" : { > "type" : "file", > "connection" : "file:///", > "config" : null, > "workspaces" : { > "tmp" : { > "location" : "/tmp", > "writable" : true, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > }, > "root" : { > "location" : "/", > "writable" : false, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > } > }, > "formats" : { > "psv" : { > "type" : "text", > "extensions" : [ "tbl" ], > "delimiter" : "|" > }, > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "httpd" : { > "type" : "httpd", > "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" > }, > "parquet" : { > "type" : "parquet" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "pcap" : { > "type" : "pcap" > }, > "pcapng" : { > "type" : "pcapng", > "extensions" : [ "pcapng" ] > }, > "avro" : { > "type" : "avro" > }, > "sequencefile" : { > "type" : "sequencefile", > "extensions" : [ "seq" ] > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "hbase", > "config" : { > "type" : "hbase", > "config" : { > "hbase.zookeeper.quorum" : "localhost", > "hbase.zookeeper.property.clientPort" : "2181" > }, > "size.calculator.enabled" : false, > "enabled" : false > } > }, { > "name" : "hive", > "config" : { > "type" : "hive", > "configProps" : { > "hive.metastore.uris" : "", > "javax.jdo.option.ConnectionURL" : > "jdbc:derby:;databaseName=../sample-data/drill_hive_db;create=true", >
[jira] [Commented] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822107#comment-16822107 ] Sorabh Hamirwasia commented on DRILL-7186: -- [~vitalii] - Given the changes are small, I would say for better user experience let's provide those. So just to clarify you will open PR for all 3 issues. 1 and 2 are related to backward compatibility and specially 3 is user experience which definitely should be fixed. > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Arina Ielchiieva >Priority: Blocker > Labels: ready-to-commit > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened: > {noformat} > [ { > "name" : "cp", > "config" : { > "type" : "file", > "connection" : "classpath:///", > "config" : null, > "workspaces" : { }, > "formats" : { > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "parquet" : { > "type" : "parquet" > }, > "avro" : { > "type" : "avro" > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "dfs", > "config" : { > "type" : "file", > "connection" : "file:///", > "config" : null, > "workspaces" : { > "tmp" : { > "location" : "/tmp", > "writable" : true, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > }, > "root" : { > "location" : "/", > "writable" : false, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > } > }, > "formats" : { > "psv" : { > "type" : "text", > "extensions" : [ "tbl" ], > "delimiter" : "|" > }, > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "httpd" : { > "type" : "httpd", > "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" > }, > "parquet" : { > "type" : "parquet" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "pcap" : { > "type" : "pcap" > }, > "pcapng" : { > "type" : "pcapng", > "extensions" : [ "pcapng" ] > }, > "avro" : { > "type" : "avro" > }, > "sequencefile" : { > "type" : "sequencefile", > "extensions" : [ "seq" ] > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "hbase", > "config" : { > "type" : "hbase", > "config" : { > "hbase.zookeeper.quorum" : "localhost", > "hbase.zookeeper.property.clientPort" : "2181" > }, > "size.calculator.enabled" : false, > "enabled" : false > } > }, { > "name" : "hive", > "config" : { > "type" : "hive", > "configProps" : { > "hive.metastore.uris" : "", > "javax.jdo.option.ConnectionURL" : > "jdbc:derby:;databaseName=../sample-data/drill_hive_db;create=true", > "hive.metastore.warehouse.dir" : "/tmp/drill_hive_wh", > "fs.default.name" : "file:///", > "hive.metastore.sasl
[jira] [Created] (DRILL-7190) Missing backward compatibility for REST API with DRILL-6562
Sorabh Hamirwasia created DRILL-7190: Summary: Missing backward compatibility for REST API with DRILL-6562 Key: DRILL-7190 URL: https://issues.apache.org/jira/browse/DRILL-7190 Project: Apache Drill Issue Type: Bug Components: Web Server Affects Versions: 1.16.0 Reporter: Sorabh Hamirwasia Assignee: Vitalii Diravka Fix For: 1.16.0 With DRILL-6562 I am seeing additional changes which is not supporting older requests URL. For example: 1) Earlier export of plugin config was done for json format by default using URL: */storage/\{name}/export* and now the new URL is */storage/\{name}/export/\{format}*. This means the older one is not supported anymore. Is it intended or should we treat the format as JSON by default if not provided ? 2) The POST URL to create and update plugin is changed from */storage/\{name}* to */storage/create_update* 3) Once a storage plugin is deleted it is not redirected to */storage* anymore, which it was in 1.15. Because of this line change: [https://github.com/apache/drill/commit/5fff1d8bff899e1af551c16f26a58b6b1d033ffb#diff-274673e64e6f54be595a8703753123b0R115] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822107#comment-16822107 ] Sorabh Hamirwasia edited comment on DRILL-7186 at 4/19/19 6:20 PM: --- [~vitalii] - Given the changes are small, I would say for better user experience let's provide those. So just to clarify you will open PR for all 3 issues. 1 and 2 are related to backward compatibility and specially 3 is user experience which definitely should be fixed. Opened https://issues.apache.org/jira/browse/DRILL-7190 to track the fixes was (Author: shamirwasia): [~vitalii] - Given the changes are small, I would say for better user experience let's provide those. So just to clarify you will open PR for all 3 issues. 1 and 2 are related to backward compatibility and specially 3 is user experience which definitely should be fixed. > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Arina Ielchiieva >Priority: Blocker > Labels: ready-to-commit > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened: > {noformat} > [ { > "name" : "cp", > "config" : { > "type" : "file", > "connection" : "classpath:///", > "config" : null, > "workspaces" : { }, > "formats" : { > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "parquet" : { > "type" : "parquet" > }, > "avro" : { > "type" : "avro" > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "dfs", > "config" : { > "type" : "file", > "connection" : "file:///", > "config" : null, > "workspaces" : { > "tmp" : { > "location" : "/tmp", > "writable" : true, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > }, > "root" : { > "location" : "/", > "writable" : false, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > } > }, > "formats" : { > "psv" : { > "type" : "text", > "extensions" : [ "tbl" ], > "delimiter" : "|" > }, > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "httpd" : { > "type" : "httpd", > "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" > }, > "parquet" : { > "type" : "parquet" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "pcap" : { > "type" : "pcap" > }, > "pcapng" : { > "type" : "pcapng", > "extensions" : [ "pcapng" ] > }, > "avro" : { > "type" : "avro" > }, > "sequencefile" : { > "type" : "sequencefile", > "extensions" : [ "seq" ] > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "hbase", > "config" : { > "type" : "hbase", > "config" : { > "hbase.zookeeper.quorum" : "localhost", > "hbase.zookeeper.property.clientPort" : "2181" > }, > "size.calcu
[jira] [Updated] (DRILL-7186) Missing storage.json REST endpoint.
[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sorabh Hamirwasia updated DRILL-7186: - Component/s: Web Server > Missing storage.json REST endpoint. > --- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug > Components: Web Server >Affects Versions: 1.16.0 >Reporter: Anton Gozhiy >Assignee: Arina Ielchiieva >Priority: Blocker > Labels: ready-to-commit > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://:8047/storage.json > *Expected result:* > storage.json is opened: > {noformat} > [ { > "name" : "cp", > "config" : { > "type" : "file", > "connection" : "classpath:///", > "config" : null, > "workspaces" : { }, > "formats" : { > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "parquet" : { > "type" : "parquet" > }, > "avro" : { > "type" : "avro" > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "dfs", > "config" : { > "type" : "file", > "connection" : "file:///", > "config" : null, > "workspaces" : { > "tmp" : { > "location" : "/tmp", > "writable" : true, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > }, > "root" : { > "location" : "/", > "writable" : false, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > } > }, > "formats" : { > "psv" : { > "type" : "text", > "extensions" : [ "tbl" ], > "delimiter" : "|" > }, > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "httpd" : { > "type" : "httpd", > "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" > }, > "parquet" : { > "type" : "parquet" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "pcap" : { > "type" : "pcap" > }, > "pcapng" : { > "type" : "pcapng", > "extensions" : [ "pcapng" ] > }, > "avro" : { > "type" : "avro" > }, > "sequencefile" : { > "type" : "sequencefile", > "extensions" : [ "seq" ] > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "hbase", > "config" : { > "type" : "hbase", > "config" : { > "hbase.zookeeper.quorum" : "localhost", > "hbase.zookeeper.property.clientPort" : "2181" > }, > "size.calculator.enabled" : false, > "enabled" : false > } > }, { > "name" : "hive", > "config" : { > "type" : "hive", > "configProps" : { > "hive.metastore.uris" : "", > "javax.jdo.option.ConnectionURL" : > "jdbc:derby:;databaseName=../sample-data/drill_hive_db;create=true", > "hive.metastore.warehouse.dir" : "/tmp/drill_hive_wh", > "fs.default.name" : "file:///", > "hive.metastore.sasl.enabled" : "false", > "hive.metastore.schema.verification" : "false", > "datanucleus.schema.autoCreateAll" : "true" > }, > "enabled" : false > } > }, { > "name" : "kafka", > "config" : { > "type" : "kafka", > "kafkaConsumerProps" : { >
[jira] [Commented] (DRILL-7189) Revert DRILL-7105 Error while building the Drill native client
[ https://issues.apache.org/jira/browse/DRILL-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822121#comment-16822121 ] ASF GitHub Bot commented on DRILL-7189: --- sohami commented on pull request #1759: DRILL-7189: Revert DRILL-7105 Error while building the Drill native c… URL: https://github.com/apache/drill/pull/1759 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Revert DRILL-7105 Error while building the Drill native client > -- > > Key: DRILL-7189 > URL: https://issues.apache.org/jira/browse/DRILL-7189 > Project: Apache Drill > Issue Type: Task > Components: Client - C++ >Affects Versions: 1.16.0 >Reporter: Sorabh Hamirwasia >Assignee: Sorabh Hamirwasia >Priority: Major > Labels: ready-to-commit > Fix For: 1.16.0 > > > Revert the change in 1.16 branch only since protobuf upgrade change is also > reverted using DRILL-7188 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7189) Revert DRILL-7105 Error while building the Drill native client
[ https://issues.apache.org/jira/browse/DRILL-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822120#comment-16822120 ] ASF GitHub Bot commented on DRILL-7189: --- sohami commented on issue #1759: DRILL-7189: Revert DRILL-7105 Error while building the Drill native c… URL: https://github.com/apache/drill/pull/1759#issuecomment-484979692 Closing this PR and will cherry-pick these changes to 1.16. branch since it's not intended for master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Revert DRILL-7105 Error while building the Drill native client > -- > > Key: DRILL-7189 > URL: https://issues.apache.org/jira/browse/DRILL-7189 > Project: Apache Drill > Issue Type: Task > Components: Client - C++ >Affects Versions: 1.16.0 >Reporter: Sorabh Hamirwasia >Assignee: Sorabh Hamirwasia >Priority: Major > Labels: ready-to-commit > Fix For: 1.16.0 > > > Revert the change in 1.16 branch only since protobuf upgrade change is also > reverted using DRILL-7188 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7188) Revert DRILL-6642: Update protocol-buffers version
[ https://issues.apache.org/jira/browse/DRILL-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822118#comment-16822118 ] ASF GitHub Bot commented on DRILL-7188: --- sohami commented on issue #1758: DRILL-7188: Revert DRILL-6642: Update protocol-buffers version URL: https://github.com/apache/drill/pull/1758#issuecomment-484979592 Closing this PR and will cherry-pick these changes to 1.16. branch since it's not intended for master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Revert DRILL-6642: Update protocol-buffers version > -- > > Key: DRILL-7188 > URL: https://issues.apache.org/jira/browse/DRILL-7188 > Project: Apache Drill > Issue Type: Task > Components: Tools, Build & Test >Affects Versions: 1.16.0 >Reporter: Sorabh Hamirwasia >Assignee: Sorabh Hamirwasia >Priority: Major > Labels: ready-to-commit > Fix For: 1.16.0 > > > Revert the protobuf changes for 1.16 branch only. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7188) Revert DRILL-6642: Update protocol-buffers version
[ https://issues.apache.org/jira/browse/DRILL-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822119#comment-16822119 ] ASF GitHub Bot commented on DRILL-7188: --- sohami commented on pull request #1758: DRILL-7188: Revert DRILL-6642: Update protocol-buffers version URL: https://github.com/apache/drill/pull/1758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Revert DRILL-6642: Update protocol-buffers version > -- > > Key: DRILL-7188 > URL: https://issues.apache.org/jira/browse/DRILL-7188 > Project: Apache Drill > Issue Type: Task > Components: Tools, Build & Test >Affects Versions: 1.16.0 >Reporter: Sorabh Hamirwasia >Assignee: Sorabh Hamirwasia >Priority: Major > Labels: ready-to-commit > Fix For: 1.16.0 > > > Revert the protobuf changes for 1.16 branch only. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6562) Plugin Management improvements
[ https://issues.apache.org/jira/browse/DRILL-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822149#comment-16822149 ] Khurram Faraaz commented on DRILL-6562: --- [~vitalii] Please add unit tests, there are no unit tests here [https://github.com/apache/drill/pull/1692] We will also have to add Functional tests to the test framework to test this. > Plugin Management improvements > -- > > Key: DRILL-6562 > URL: https://issues.apache.org/jira/browse/DRILL-6562 > Project: Apache Drill > Issue Type: Improvement > Components: Client - HTTP, Web Server >Affects Versions: 1.14.0 >Reporter: Abhishek Girish >Assignee: Vitalii Diravka >Priority: Major > Labels: doc-complete, ready-to-commit > Fix For: 1.16.0 > > Attachments: Export.png, ExportAll.png, Screenshot from 2019-03-21 > 01-18-17.png, Screenshot from 2019-03-21 02-52-50.png, Storage.png, > UpdateExport.png, create.png, image-2018-07-23-02-55-02-024.png, > image-2018-10-22-20-20-24-658.png, image-2018-10-22-20-20-59-105.png > > > Follow-up to DRILL-4580. > Provide ability to export all storage plugin configurations at once, with a > new "Export All" option on the Storage page of the Drill web UI -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7164) KafkaFilterPushdownTest is sometimes failing to pattern match correctly.
[ https://issues.apache.org/jira/browse/DRILL-7164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822184#comment-16822184 ] ASF GitHub Bot commented on DRILL-7164: --- sohami commented on issue #1760: DRILL-7164: KafkaFilterPushdownTest is sometimes failing to pattern m… URL: https://github.com/apache/drill/pull/1760#issuecomment-485014371 @aravi5 / @HanumathRao - Please review this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > KafkaFilterPushdownTest is sometimes failing to pattern match correctly. > > > Key: DRILL-7164 > URL: https://issues.apache.org/jira/browse/DRILL-7164 > Project: Apache Drill > Issue Type: Bug > Components: Storage - Kafka >Affects Versions: 1.16.0 >Reporter: Hanumath Rao Maduri >Assignee: Abhishek Ravi >Priority: Major > Fix For: 1.17.0 > > > On my private build I am hitting kafka storage tests issue intermittently. > Here is the issue which I came across. > {code} > at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_91] > 15:01:39.852 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: > -292 B(75.4 KiB), h: -391.1 MiB(240.7 MiB), nh: 824.5 KiB(129.0 MiB)): > testPushdownOffsetOneRecordReturnedWithBoundaryConditions(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest) > java.lang.AssertionError: Unable to find expected string "kafkaScanSpec" > : { > "topicName" : "drill-pushdown-topic" > }, > "cost" in plan: { > "head" : { > "version" : 1, > "generator" : { > "type" : "ExplainHandler", > "info" : "" > }, > "type" : "APACHE_DRILL_PHYSICAL", > "options" : [ { > "kind" : "STRING", > "accessibleScopes" : "ALL", > "name" : "store.kafka.record.reader", > "string_val" : > "org.apache.drill.exec.store.kafka.decoders.JsonMessageReader", > "scope" : "SESSION" > }, { > "kind" : "BOOLEAN", > "accessibleScopes" : "ALL", > "name" : "exec.errors.verbose", > "bool_val" : true, > "scope" : "SESSION" > }, { > "kind" : "LONG", > "accessibleScopes" : "ALL", > "name" : "store.kafka.poll.timeout", > "num_val" : 5000, > "scope" : "SESSION" > }, { > "kind" : "LONG", > "accessibleScopes" : "ALL", > "name" : "planner.width.max_per_node", > "num_val" : 2, > "scope" : "SESSION" > } ], > "queue" : 0, > "hasResourcePlan" : false, > "resultMode" : "EXEC" > }, > "graph" : [ { > "pop" : "kafka-scan", > "@id" : 6, > "userName" : "", > "kafkaStoragePluginConfig" : { > "type" : "kafka", > "kafkaConsumerProps" : { > "bootstrap.servers" : "127.0.0.1:56524", > "group.id" : "drill-test-consumer" > }, > "enabled" : true > }, > "columns" : [ "`**`", "`kafkaMsgOffset`" ], > "kafkaScanSpec" : { > "topicName" : "drill-pushdown-topic" > }, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 5.0 > } > }, { > "pop" : "project", > "@id" : 5, > "exprs" : [ { > "ref" : "`T23¦¦**`", > "expr" : "`**`" > }, { > "ref" : "`kafkaMsgOffset`", > "expr" : "`kafkaMsgOffset`" > } ], > "child" : 6, > "outputProj" : false, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 5.0 > } > }, { > "pop" : "filter", > "@id" : 4, > "child" : 5, > "expr" : "equal(`kafkaMsgOffset`, 9) ", > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 0.75 > } > }, { > "pop" : "selection-vector-remover", > "@id" : 3, > "child" : 4, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 1.0 > } > }, { > "pop" : "project", > "@id" : 2, > "exprs" : [ { > "ref" : "`T23¦¦**`", > "expr" : "`T23¦¦**`" > } ], > "child" : 3, > "outputProj" : false, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 1.0 > } > }, { > "pop" : "project", > "@id" : 1, > "exprs" : [ { >
[jira] [Commented] (DRILL-7164) KafkaFilterPushdownTest is sometimes failing to pattern match correctly.
[ https://issues.apache.org/jira/browse/DRILL-7164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822183#comment-16822183 ] ASF GitHub Bot commented on DRILL-7164: --- sohami commented on pull request #1760: DRILL-7164: KafkaFilterPushdownTest is sometimes failing to pattern m… URL: https://github.com/apache/drill/pull/1760 …atch correctly This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > KafkaFilterPushdownTest is sometimes failing to pattern match correctly. > > > Key: DRILL-7164 > URL: https://issues.apache.org/jira/browse/DRILL-7164 > Project: Apache Drill > Issue Type: Bug > Components: Storage - Kafka >Affects Versions: 1.16.0 >Reporter: Hanumath Rao Maduri >Assignee: Abhishek Ravi >Priority: Major > Fix For: 1.17.0 > > > On my private build I am hitting kafka storage tests issue intermittently. > Here is the issue which I came across. > {code} > at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_91] > 15:01:39.852 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: > -292 B(75.4 KiB), h: -391.1 MiB(240.7 MiB), nh: 824.5 KiB(129.0 MiB)): > testPushdownOffsetOneRecordReturnedWithBoundaryConditions(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest) > java.lang.AssertionError: Unable to find expected string "kafkaScanSpec" > : { > "topicName" : "drill-pushdown-topic" > }, > "cost" in plan: { > "head" : { > "version" : 1, > "generator" : { > "type" : "ExplainHandler", > "info" : "" > }, > "type" : "APACHE_DRILL_PHYSICAL", > "options" : [ { > "kind" : "STRING", > "accessibleScopes" : "ALL", > "name" : "store.kafka.record.reader", > "string_val" : > "org.apache.drill.exec.store.kafka.decoders.JsonMessageReader", > "scope" : "SESSION" > }, { > "kind" : "BOOLEAN", > "accessibleScopes" : "ALL", > "name" : "exec.errors.verbose", > "bool_val" : true, > "scope" : "SESSION" > }, { > "kind" : "LONG", > "accessibleScopes" : "ALL", > "name" : "store.kafka.poll.timeout", > "num_val" : 5000, > "scope" : "SESSION" > }, { > "kind" : "LONG", > "accessibleScopes" : "ALL", > "name" : "planner.width.max_per_node", > "num_val" : 2, > "scope" : "SESSION" > } ], > "queue" : 0, > "hasResourcePlan" : false, > "resultMode" : "EXEC" > }, > "graph" : [ { > "pop" : "kafka-scan", > "@id" : 6, > "userName" : "", > "kafkaStoragePluginConfig" : { > "type" : "kafka", > "kafkaConsumerProps" : { > "bootstrap.servers" : "127.0.0.1:56524", > "group.id" : "drill-test-consumer" > }, > "enabled" : true > }, > "columns" : [ "`**`", "`kafkaMsgOffset`" ], > "kafkaScanSpec" : { > "topicName" : "drill-pushdown-topic" > }, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 5.0 > } > }, { > "pop" : "project", > "@id" : 5, > "exprs" : [ { > "ref" : "`T23¦¦**`", > "expr" : "`**`" > }, { > "ref" : "`kafkaMsgOffset`", > "expr" : "`kafkaMsgOffset`" > } ], > "child" : 6, > "outputProj" : false, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 5.0 > } > }, { > "pop" : "filter", > "@id" : 4, > "child" : 5, > "expr" : "equal(`kafkaMsgOffset`, 9) ", > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 0.75 > } > }, { > "pop" : "selection-vector-remover", > "@id" : 3, > "child" : 4, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 1.0 > } > }, { > "pop" : "project", > "@id" : 2, > "exprs" : [ { > "ref" : "`T23¦¦**`", > "expr" : "`T23¦¦**`" > } ], > "child" : 3, > "outputProj" : false, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 1.0 > } > }, { > "pop" : "project", > "@id" : 1, > "exprs" : [ { > "ref" : "`**`", > "expr" : "`T23¦¦**
[jira] [Assigned] (DRILL-7164) KafkaFilterPushdownTest is sometimes failing to pattern match correctly.
[ https://issues.apache.org/jira/browse/DRILL-7164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sorabh Hamirwasia reassigned DRILL-7164: Assignee: Sorabh Hamirwasia (was: Abhishek Ravi) > KafkaFilterPushdownTest is sometimes failing to pattern match correctly. > > > Key: DRILL-7164 > URL: https://issues.apache.org/jira/browse/DRILL-7164 > Project: Apache Drill > Issue Type: Bug > Components: Storage - Kafka >Affects Versions: 1.16.0 >Reporter: Hanumath Rao Maduri >Assignee: Sorabh Hamirwasia >Priority: Major > Fix For: 1.17.0 > > > On my private build I am hitting kafka storage tests issue intermittently. > Here is the issue which I came across. > {code} > at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_91] > 15:01:39.852 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: > -292 B(75.4 KiB), h: -391.1 MiB(240.7 MiB), nh: 824.5 KiB(129.0 MiB)): > testPushdownOffsetOneRecordReturnedWithBoundaryConditions(org.apache.drill.exec.store.kafka.KafkaFilterPushdownTest) > java.lang.AssertionError: Unable to find expected string "kafkaScanSpec" > : { > "topicName" : "drill-pushdown-topic" > }, > "cost" in plan: { > "head" : { > "version" : 1, > "generator" : { > "type" : "ExplainHandler", > "info" : "" > }, > "type" : "APACHE_DRILL_PHYSICAL", > "options" : [ { > "kind" : "STRING", > "accessibleScopes" : "ALL", > "name" : "store.kafka.record.reader", > "string_val" : > "org.apache.drill.exec.store.kafka.decoders.JsonMessageReader", > "scope" : "SESSION" > }, { > "kind" : "BOOLEAN", > "accessibleScopes" : "ALL", > "name" : "exec.errors.verbose", > "bool_val" : true, > "scope" : "SESSION" > }, { > "kind" : "LONG", > "accessibleScopes" : "ALL", > "name" : "store.kafka.poll.timeout", > "num_val" : 5000, > "scope" : "SESSION" > }, { > "kind" : "LONG", > "accessibleScopes" : "ALL", > "name" : "planner.width.max_per_node", > "num_val" : 2, > "scope" : "SESSION" > } ], > "queue" : 0, > "hasResourcePlan" : false, > "resultMode" : "EXEC" > }, > "graph" : [ { > "pop" : "kafka-scan", > "@id" : 6, > "userName" : "", > "kafkaStoragePluginConfig" : { > "type" : "kafka", > "kafkaConsumerProps" : { > "bootstrap.servers" : "127.0.0.1:56524", > "group.id" : "drill-test-consumer" > }, > "enabled" : true > }, > "columns" : [ "`**`", "`kafkaMsgOffset`" ], > "kafkaScanSpec" : { > "topicName" : "drill-pushdown-topic" > }, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 5.0 > } > }, { > "pop" : "project", > "@id" : 5, > "exprs" : [ { > "ref" : "`T23¦¦**`", > "expr" : "`**`" > }, { > "ref" : "`kafkaMsgOffset`", > "expr" : "`kafkaMsgOffset`" > } ], > "child" : 6, > "outputProj" : false, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 5.0 > } > }, { > "pop" : "filter", > "@id" : 4, > "child" : 5, > "expr" : "equal(`kafkaMsgOffset`, 9) ", > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 0.75 > } > }, { > "pop" : "selection-vector-remover", > "@id" : 3, > "child" : 4, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 1.0 > } > }, { > "pop" : "project", > "@id" : 2, > "exprs" : [ { > "ref" : "`T23¦¦**`", > "expr" : "`T23¦¦**`" > } ], > "child" : 3, > "outputProj" : false, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 1.0 > } > }, { > "pop" : "project", > "@id" : 1, > "exprs" : [ { > "ref" : "`**`", > "expr" : "`T23¦¦**`" > } ], > "child" : 2, > "outputProj" : true, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 1.0 > } > }, { > "pop" : "screen", > "@id" : 0, > "child" : 1, > "initialAllocation" : 100, > "maxAllocation" : 100, > "cost" : { > "memoryCost" : 1.6777216E7, > "outputRowCount" : 1.0 > } > } ] > }! > {code} > In th
[jira] [Commented] (DRILL-7062) Run-time row group pruning
[ https://issues.apache.org/jira/browse/DRILL-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822279#comment-16822279 ] ASF GitHub Bot commented on DRILL-7062: --- amansinha100 commented on pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning URL: https://github.com/apache/drill/pull/1738#discussion_r277116139 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/AbstractParquetScanBatchCreator.java ## @@ -68,76 +84,144 @@ protected ScanBatch getBatch(ExecutorFragmentContext context, AbstractParquetRow List readers = new LinkedList<>(); List> implicitColumns = new ArrayList<>(); Map mapWithMaxColumns = new LinkedHashMap<>(); -for (RowGroupReadEntry rowGroup : rowGroupScan.getRowGroupReadEntries()) { - /* - Here we could store a map from file names to footers, to prevent re-reading the footer for each row group in a file - TODO - to prevent reading the footer again in the parquet record reader (it is read earlier in the ParquetStorageEngine) - we should add more information to the RowGroupInfo that will be populated upon the first read to - provide the reader with all of th file meta-data it needs - These fields will be added to the constructor below - */ - try { -Stopwatch timer = logger.isTraceEnabled() ? Stopwatch.createUnstarted() : null; -DrillFileSystem fs = fsManager.get(rowGroupScan.getFsConf(rowGroup), rowGroup.getPath()); -ParquetReaderConfig readerConfig = rowGroupScan.getReaderConfig(); -if (!footers.containsKey(rowGroup.getPath())) { - if (timer != null) { -timer.start(); - } +ParquetReaderConfig readerConfig = rowGroupScan.getReaderConfig(); +RowGroupReadEntry firstRowGroup = null; // to be scanned in case ALL row groups are pruned out +ParquetMetadata firstFooter = null; +long rowgroupsPruned = 0; // for stats +TupleSchema tupleSchema = rowGroupScan.getTupleSchema(); + +try { + + LogicalExpression filterExpr = rowGroupScan.getFilter(); + boolean doRuntimePruning = filterExpr != null && // was a filter given ? And it is not just a "TRUE" predicate +! ((filterExpr instanceof ValueExpressions.BooleanExpression) && ((ValueExpressions.BooleanExpression) filterExpr).getBoolean() ); - ParquetMetadata footer = readFooter(fs.getConf(), rowGroup.getPath(), readerConfig); - if (timer != null) { -long timeToRead = timer.elapsed(TimeUnit.MICROSECONDS); -logger.trace("ParquetTrace,Read Footer,{},{},{},{},{},{},{}", "", rowGroup.getPath(), "", 0, 0, 0, timeToRead); + // Runtime pruning: Avoid recomputing metadata objects for each row-group in case they use the same file + // by keeping the following objects computed earlier (relies on same file being in consecutive rowgroups) + Path prevRowGroupPath = null; + Metadata_V4.ParquetTableMetadata_v4 tableMetadataV4 = null; + Metadata_V4.ParquetFileAndRowCountMetadata fileMetadataV4 = null; + FileSelection fileSelection = null; + FilterPredicate filterPredicate = null; + Set schemaPathsInExpr = null; + Set columnsInExpr = null; + + // If pruning - Prepare the predicate and the columns before the FOR LOOP + if ( doRuntimePruning ) { +filterPredicate = AbstractGroupScanWithMetadata.getFilterPredicate(filterExpr, context, + (FunctionImplementationRegistry) context.getFunctionRegistry(), context.getOptions(), true, + true /* supports file implicit columns */, + tupleSchema); +// Extract only the relevant columns from the filter (sans implicit columns, if any) +schemaPathsInExpr = filterExpr.accept(new FilterEvaluatorUtils.FieldReferenceFinder(), null); +columnsInExpr = new HashSet<>(); +String partitionColumnLabel = context.getOptions().getOption(ExecConstants.FILESYSTEM_PARTITION_COLUMN_LABEL).string_val; +for (SchemaPath path : schemaPathsInExpr) { + if (rowGroupScan.supportsFileImplicitColumns() && +path.toString().matches(partitionColumnLabel+"\\d+")) { +continue; // skip implicit columns like dir0, dir1 } - footers.put(rowGroup.getPath(), footer); -} -ParquetMetadata footer = footers.get(rowGroup.getPath()); - -ParquetReaderUtility.DateCorruptionStatus containsCorruptDates = ParquetReaderUtility.detectCorruptDates(footer, - rowGroupScan.getColumns(), readerConfig.autoCorrectCorruptedDates()); -logger.debug("Contains corrupt dates: {}.", containsCorruptDates); - -boolean useNewReader = context.getOptions().getBoolean(ExecConstants.PARQUET_NEW_RECORD_READER); -boolean containsComplexColumn = ParquetReaderUtility.containsComplexC
[jira] [Commented] (DRILL-7190) Missing backward compatibility for REST API with DRILL-6562
[ https://issues.apache.org/jira/browse/DRILL-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822315#comment-16822315 ] Vitalii Diravka commented on DRILL-7190: 1. It is changed, because one more file format for Drill Storage Plugins is added and specifying this is necessary to distinguish file formats. But the old behavior can be preserved and JSON format can be chosen for the URL without file format string. 2. Looks like */storage/\{name}* isn't default way to update/create Storage Plugins. According to [Drill documentation|https://drill.apache.org/docs/rest-api-introduction/#post-storage-name-json] it is POST /storage/\{name}.json. And it wasn't changed and works fine. {code:java} vitalii@vitalii-UX331UN:~$ curl -X POST -H "Content-Type: application/json" -d '{"name":"kudu", "config": {"type": "kudu", "masterAddrsses": "1.2.3.5", "enabled": true}}' http://localhost:8047/storage/kudu.json { "result" : "Success" }{code} But I will add the functionality, which existed earlier in case somebody uses that approach for some reason. 3. It was removed occasionally. I will return this change Additionally I will returned DELETE request, since according [Drill documentation|https://drill.apache.org/docs/rest-api-introduction/#delete-storage-name-json] this is the default way to remove Storage Plugins by REST API. But also improved it by allowing to omit file format in the DELETE request Path. I will let Bridget know to update the doc. > Missing backward compatibility for REST API with DRILL-6562 > --- > > Key: DRILL-7190 > URL: https://issues.apache.org/jira/browse/DRILL-7190 > Project: Apache Drill > Issue Type: Bug > Components: Web Server >Affects Versions: 1.16.0 >Reporter: Sorabh Hamirwasia >Assignee: Vitalii Diravka >Priority: Blocker > Fix For: 1.16.0 > > > With DRILL-6562 I am seeing additional changes which is not supporting older > requests URL. For example: > 1) Earlier export of plugin config was done for json format by default using > URL: */storage/\{name}/export* and now the new URL is > */storage/\{name}/export/\{format}*. This means the older one is not > supported anymore. Is it intended or should we treat the format as JSON by > default if not provided ? > 2) The POST URL to create and update plugin is changed from > */storage/\{name}* to */storage/create_update* > 3) Once a storage plugin is deleted it is not redirected to */storage* > anymore, which it was in 1.15. Because of this line change: > [https://github.com/apache/drill/commit/5fff1d8bff899e1af551c16f26a58b6b1d033ffb#diff-274673e64e6f54be595a8703753123b0R115] -- This message was sent by Atlassian JIRA (v7.6.3#76005)