[jira] [Commented] (DRILL-6611) Add [meta]-[Enter] js handler for query form submission
[
https://issues.apache.org/jira/browse/DRILL-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552834#comment-16552834
]
Bob Rudis commented on DRILL-6611:
--
Done. (Added it below the initial description.)
> Add [meta]-[Enter] js handler for query form submission
> ---
>
> Key: DRILL-6611
> URL: https://issues.apache.org/jira/browse/DRILL-6611
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
>Affects Versions: 1.14.0
>Reporter: Bob Rudis
>Assignee: Bob Rudis
>Priority: Minor
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> The new ACE-based SQL query editor is great. Being able to submit the form
> without using a mouse would be even better.
> Adding:
>
> {noformat}
> document.getElementById('queryForm')
> .addEventListener('keydown', function(e) {
> if (!(e.keyCode == 13 && e.metaKey)) return;
> if (e.target.form) doSubmitQueryWithUserName();
> });
> {noformat}
> {{to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such
> support.}}
> I can file a PR with the code if desired.
> --
> Functionality (for the documentation):
> This JIRA's commit introduces the following to Drill:
> When composing queries in the web query editor it is now possible to submit
> the query text by using the {{Meta+Enter}} key combination. This will trigger
> the same action as pressing the {{Submit}} button. On Mac keyboards
> {{Meta+Enter}} is {{Cmd+Enter}}. On Windows or Linux is {{Ctrl+Enter}} though
> Linux users may have keymapped the {{Meta}} key to another physical keyboard
> key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (DRILL-6611) Add [meta]-[Enter] js handler for query form submission
[
https://issues.apache.org/jira/browse/DRILL-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Rudis updated DRILL-6611:
-
Description:
The new ACE-based SQL query editor is great. Being able to submit the form
without using a mouse would be even better.
Adding:
{noformat}
document.getElementById('queryForm')
.addEventListener('keydown', function(e) {
if (!(e.keyCode == 13 && e.metaKey)) return;
if (e.target.form) doSubmitQueryWithUserName();
});
{noformat}
{{to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such
support.}}
I can file a PR with the code if desired.
--
Functionality (for the documentation):
This JIRA's commit introduces the following to Drill:
When composing queries in the web query editor it is now possible to submit the
query text by using the {{Meta+Enter}} key combination. This will trigger the
same action as pressing the {{Submit}} button. On Mac keyboards {{Meta+Enter}}
is {{Cmd+Enter}}. On Windows or Linux is {{Ctrl+Enter}} though Linux users may
have keymapped the {{Meta}} key to another physical keyboard key.
was:
The new ACE-based SQL query editor is great. Being able to submit the form
without using a mouse would be even better.
Adding:
{noformat}
document.getElementById('queryForm')
.addEventListener('keydown', function(e) {
if (!(e.keyCode == 13 && e.metaKey)) return;
if (e.target.form) doSubmitQueryWithUserName();
});
{noformat}
{{to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such
support.}}
I can file a PR with the code if desired.
> Add [meta]-[Enter] js handler for query form submission
> ---
>
> Key: DRILL-6611
> URL: https://issues.apache.org/jira/browse/DRILL-6611
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
>Affects Versions: 1.14.0
>Reporter: Bob Rudis
>Assignee: Bob Rudis
>Priority: Minor
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> The new ACE-based SQL query editor is great. Being able to submit the form
> without using a mouse would be even better.
> Adding:
>
> {noformat}
> document.getElementById('queryForm')
> .addEventListener('keydown', function(e) {
> if (!(e.keyCode == 13 && e.metaKey)) return;
> if (e.target.form) doSubmitQueryWithUserName();
> });
> {noformat}
> {{to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such
> support.}}
> I can file a PR with the code if desired.
> --
> Functionality (for the documentation):
> This JIRA's commit introduces the following to Drill:
> When composing queries in the web query editor it is now possible to submit
> the query text by using the {{Meta+Enter}} key combination. This will trigger
> the same action as pressing the {{Submit}} button. On Mac keyboards
> {{Meta+Enter}} is {{Cmd+Enter}}. On Windows or Linux is {{Ctrl+Enter}} though
> Linux users may have keymapped the {{Meta}} key to another physical keyboard
> key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (DRILL-6628) Possible incorporation of Twitter text processing UDFs into Drill-proper
Bob Rudis created DRILL-6628: Summary: Possible incorporation of Twitter text processing UDFs into Drill-proper Key: DRILL-6628 URL: https://issues.apache.org/jira/browse/DRILL-6628 Project: Apache Drill Issue Type: Improvement Components: Functions - Drill Reporter: Bob Rudis Per the User mailing list thread — [https://mail-archives.apache.org/mod_mbox/drill-user/201807.mbox/%3Caef1979d-f454-4691-8607-8267adf2ac1e%40getmailbird.com%3E] — submitting the possibility for the inclusion of drill-twitter-text — [https://github.com/hrbrmstr/drill-twitter-text] — into Drill-proper. Shifting the conversation here since it's more appropriate and CC'ing [~cgivre] who posited the idea. On the one hand, there are function groups such as "Phonetic" and "String Distance" so there's precedent for inclusion of "non-boring-SQL"-like functions into Drill-proper. On the other hand, this is a small addition of a handful of functions for Twitter text so would this be to niche for a "Twitter" function group? As noted in the mailing list thread, there are more "cyber"-ish UDFs on the way (still kinda hoping for that guava upgrade that I saw mentioned in various places in jira), so would the Twitter components be in a "Cyber" group? Regardless, I'll take a look at how the functions are structured in the Drill source tree and gladly machinate the necessary changes/inclusions if the result of this discussion results in that decision. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-6611) Add [meta]-[Enter] js handler for query form submission
[
https://issues.apache.org/jira/browse/DRILL-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552743#comment-16552743
]
Bob Rudis commented on DRILL-6611:
--
Per code review requirement #4 I suspect I should ask [~kkhatua] (who is
already in-thread) or [~sudheeshkatkam] to review the PR before I then do #5
which is set the reviewer field. (first contribution so am meticulously working
through the steps in the docs…apologies for any verbosity as a result).
> Add [meta]-[Enter] js handler for query form submission
> ---
>
> Key: DRILL-6611
> URL: https://issues.apache.org/jira/browse/DRILL-6611
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
>Affects Versions: 1.14.0
>Reporter: Bob Rudis
>Assignee: Bob Rudis
>Priority: Minor
> Fix For: 1.15.0
>
>
> The new ACE-based SQL query editor is great. Being able to submit the form
> without using a mouse would be even better.
> Adding:
>
> {noformat}
> document.getElementById('queryForm')
> .addEventListener('keydown', function(e) {
> if (!(e.keyCode == 13 && e.metaKey)) return;
> if (e.target.form) doSubmitQueryWithUserName();
> });
> {noformat}
> {{to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such
> support.}}
> I can file a PR with the code if desired.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-6611) Add [meta]-[Enter] js handler for query form submission
[
https://issues.apache.org/jira/browse/DRILL-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551810#comment-16551810
]
Bob Rudis commented on DRILL-6611:
--
Cool. I'll re-sync my fork and submit a PR this weekend.
> Add [meta]-[Enter] js handler for query form submission
> ---
>
> Key: DRILL-6611
> URL: https://issues.apache.org/jira/browse/DRILL-6611
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
>Affects Versions: 1.14.0
>Reporter: Bob Rudis
>Priority: Minor
>
> The new ACE-based SQL query editor is great. Being able to submit the form
> without using a mouse would be even better.
> Adding:
>
> {noformat}
> document.getElementById('queryForm')
> .addEventListener('keydown', function(e) {
> if (!(e.keyCode == 13 && e.metaKey)) return;
> if (e.target.form) doSubmitQueryWithUserName();
> });
> {noformat}
> {{to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such
> support.}}
> I can file a PR with the code if desired.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (DRILL-6611) Add [meta]-[Enter] js handler for query form submission
Bob Rudis created DRILL-6611:
Summary: Add [meta]-[Enter] js handler for query form submission
Key: DRILL-6611
URL: https://issues.apache.org/jira/browse/DRILL-6611
Project: Apache Drill
Issue Type: Improvement
Components: Web Server
Affects Versions: 1.14.0
Reporter: Bob Rudis
The new ACE-based SQL query editor is great. Being able to submit the form
without using a mouse would be even better.
Adding:
{noformat}
document.getElementById('queryForm')
.addEventListener('keydown', function(e) {
if (!(e.keyCode == 13 && e.metaKey)) return;
if (e.target.form) doSubmitQueryWithUserName();
});
{noformat}
{{to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such
support.}}
I can file a PR with the code if desired.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (DRILL-5693) SYSTEM ERROR: IllegalStateException: Packet too long
[
https://issues.apache.org/jira/browse/DRILL-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Rudis updated DRILL-5693:
-
Description:
I was testing out the new ++amazingly helpful PCAP functionality and hit an
exception.
the query was basic, on the order of:
{{select * from dfs.captures.`capture.pcap`}}
And, it generated an error:
{{Error: SYSTEM ERROR: IllegalStateException: Packet too long (%d bytes)
[1506]}}
{{Fragment 0:0}}
{{[Error Id: bc4f1505-5689-4cb8-ad3b-8af934ebf318 on ##.##.##.##:31010]
(state=,code=0)}}
tcpdump reads the file fine but there are likely some "interesting" packets in
there since it's from one of our network honeypot sensors.
I can't post the file here but can share it privately with someone if it's
required for testing.
A similar issue occurs when it comes across IPv6 packets:
You can test that with
http://panda.gtisc.gatech.edu/malrec/pcap/07939e77-7c7d-4ddf-9a99-85b4edf349ba.pcap
It returns:
{{Error: SYSTEM ERROR: IllegalStateException: Unknown V6 extension or protocol:
[58]}}
I'm not suggesting that Drill should be able to turn "abnormal" packets into
data or necessarioy support v6 out of the box but it would be helpful if it
either didn't terminate the query. At the very least, it would be helpful if
the error included the filename so it can be moved/excluded from the directory
of files.
I'll try to poke around the 1.11.0 PCAP code to see if I might be able to work
on this but it'll likely be a while before I can get to it.
was:
I was testing out the new ++amazingly helpful PCAP functionality and hit an
exception.
the query was basic, on the order of:
{{select * from dfs.captures.`capture.pcap`}}
And, it generated an error:
{{Error: SYSTEM ERROR: IllegalStateException: Packet too long (%d bytes)
[1506]}}
{{Fragment 0:0}}
{{[Error Id: bc4f1505-5689-4cb8-ad3b-8af934ebf318 on ##.##.##.##:31010]
(state=,code=0)}}
tcpdump reads the file fine but there are likely some "interesting" packets in
there since it's from one of our network honeypot sensors.
I can't post the file here but can share it privately with someone if it's
required for testing.
I'm not suggesting that Drill should be able to turn "abnormal" packets into
data but it would be helpful if it either didn't terminate the query. At the
very least, it would be helpful if the error included the filename so it can be
moved/excluded from the directory of files.
I'll try to poke around the 1.11.0 PCAP code to see if I might be able to work
on this but it'll likely be a while before I can get to it.
> SYSTEM ERROR: IllegalStateException: Packet too long
>
>
> Key: DRILL-5693
> URL: https://issues.apache.org/jira/browse/DRILL-5693
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - Other
>Affects Versions: 1.11.0
> Environment: macOS 10.12 / 2017 13" MacBook Pro 16GB RAM
>Reporter: Bob Rudis
>Priority: Minor
>
> I was testing out the new ++amazingly helpful PCAP functionality and hit an
> exception.
> the query was basic, on the order of:
> {{select * from dfs.captures.`capture.pcap`}}
> And, it generated an error:
> {{Error: SYSTEM ERROR: IllegalStateException: Packet too long (%d bytes)
> [1506]}}
> {{Fragment 0:0}}
> {{[Error Id: bc4f1505-5689-4cb8-ad3b-8af934ebf318 on ##.##.##.##:31010]
> (state=,code=0)}}
> tcpdump reads the file fine but there are likely some "interesting" packets
> in there since it's from one of our network honeypot sensors.
> I can't post the file here but can share it privately with someone if it's
> required for testing.
> A similar issue occurs when it comes across IPv6 packets:
> You can test that with
> http://panda.gtisc.gatech.edu/malrec/pcap/07939e77-7c7d-4ddf-9a99-85b4edf349ba.pcap
> It returns:
> {{Error: SYSTEM ERROR: IllegalStateException: Unknown V6 extension or
> protocol: [58]}}
> I'm not suggesting that Drill should be able to turn "abnormal" packets into
> data or necessarioy support v6 out of the box but it would be helpful if it
> either didn't terminate the query. At the very least, it would be helpful if
> the error included the filename so it can be moved/excluded from the
> directory of files.
> I'll try to poke around the 1.11.0 PCAP code to see if I might be able to
> work on this but it'll likely be a while before I can get to it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (DRILL-5693) SYSTEM ERROR: IllegalStateException: Packet too long
Bob Rudis created DRILL-5693:
Summary: SYSTEM ERROR: IllegalStateException: Packet too long
Key: DRILL-5693
URL: https://issues.apache.org/jira/browse/DRILL-5693
Project: Apache Drill
Issue Type: Bug
Components: Storage - Other
Affects Versions: 1.11.0
Environment: macOS 10.12 / 2017 13" MacBook Pro 16GB RAM
Reporter: Bob Rudis
Priority: Minor
I was testing out the new ++amazingly helpful PCAP functionality and hit an
exception.
the query was basic, on the order of:
{{select * from dfs.captures.`capture.pcap`}}
And, it generated an error:
{{Error: SYSTEM ERROR: IllegalStateException: Packet too long (%d bytes)
[1506]}}
{{Fragment 0:0}}
{{[Error Id: bc4f1505-5689-4cb8-ad3b-8af934ebf318 on ##.##.##.##:31010]
(state=,code=0)}}
tcpdump reads the file fine but there are likely some "interesting" packets in
there since it's from one of our network honeypot sensors.
I can't post the file here but can share it privately with someone if it's
required for testing.
I'm not suggesting that Drill should be able to turn "abnormal" packets into
data but it would be helpful if it either didn't terminate the query. At the
very least, it would be helpful if the error included the filename so it can be
moved/excluded from the directory of files.
I'll try to poke around the 1.11.0 PCAP code to see if I might be able to work
on this but it'll likely be a while before I can get to it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
