[jira] [Comment Edited] (DRILL-7186) Missing storage.json REST endpoint.
[
https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822107#comment-16822107
]
Sorabh Hamirwasia edited comment on DRILL-7186 at 4/19/19 6:20 PM:
---
[~vitalii] - Given the changes are small, I would say for better user
experience let's provide those. So just to clarify you will open PR for all 3
issues. 1 and 2 are related to backward compatibility and specially 3 is user
experience which definitely should be fixed. Opened
https://issues.apache.org/jira/browse/DRILL-7190 to track the fixes
was (Author: shamirwasia):
[~vitalii] - Given the changes are small, I would say for better user
experience let's provide those. So just to clarify you will open PR for all 3
issues. 1 and 2 are related to backward compatibility and specially 3 is user
experience which definitely should be fixed.
> Missing storage.json REST endpoint.
> ---
>
> Key: DRILL-7186
> URL: https://issues.apache.org/jira/browse/DRILL-7186
> Project: Apache Drill
> Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Anton Gozhiy
>Assignee: Arina Ielchiieva
>Priority: Blocker
> Labels: ready-to-commit
> Fix For: 1.16.0
>
>
> *Steps:*
> 1. Open page: http://:8047/storage.json
> *Expected result:*
> storage.json is opened:
> {noformat}
> [ {
> "name" : "cp",
> "config" : {
> "type" : "file",
> "connection" : "classpath:///",
> "config" : null,
> "workspaces" : { },
> "formats" : {
> "csv" : {
> "type" : "text",
> "extensions" : [ "csv" ],
> "delimiter" : ","
> },
> "tsv" : {
> "type" : "text",
> "extensions" : [ "tsv" ],
> "delimiter" : "\t"
> },
> "json" : {
> "type" : "json",
> "extensions" : [ "json" ]
> },
> "parquet" : {
> "type" : "parquet"
> },
> "avro" : {
> "type" : "avro"
> },
> "csvh" : {
> "type" : "text",
> "extensions" : [ "csvh" ],
> "extractHeader" : true,
> "delimiter" : ","
> },
> "image" : {
> "type" : "image",
> "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd",
> "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov",
> "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf",
> "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw",
> "x3f" ]
> }
> },
> "enabled" : true
> }
> }, {
> "name" : "dfs",
> "config" : {
> "type" : "file",
> "connection" : "file:///",
> "config" : null,
> "workspaces" : {
> "tmp" : {
> "location" : "/tmp",
> "writable" : true,
> "defaultInputFormat" : null,
> "allowAccessOutsideWorkspace" : false
> },
> "root" : {
> "location" : "/",
> "writable" : false,
> "defaultInputFormat" : null,
> "allowAccessOutsideWorkspace" : false
> }
> },
> "formats" : {
> "psv" : {
> "type" : "text",
> "extensions" : [ "tbl" ],
> "delimiter" : "|"
> },
> "csv" : {
> "type" : "text",
> "extensions" : [ "csv" ],
> "delimiter" : ","
> },
> "tsv" : {
> "type" : "text",
> "extensions" : [ "tsv" ],
> "delimiter" : "\t"
> },
> "httpd" : {
> "type" : "httpd",
> "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\""
> },
> "parquet" : {
> "type" : "parquet"
> },
> "json" : {
> "type" : "json",
> "extensions" : [ "json" ]
> },
> "pcap" : {
> "type" : "pcap"
> },
> "pcapng" : {
> "type" : "pcapng",
> "extensions" : [ "pcapng" ]
> },
> "avro" : {
> "type" : "avro"
> },
> "sequencefile" : {
> "type" : "sequencefile",
> "extensions" : [ "seq" ]
> },
> "csvh" : {
> "type" : "text",
> "extensions" : [ "csvh" ],
> "extractHeader" : true,
> "delimiter" : ","
> },
> "image" : {
> "type" : "image",
> "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd",
> "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov",
> "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf",
> "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw",
> "x3f" ]
> }
> },
> "enabled" : true
> }
> }, {
> "name" : "hbase",
> "config" : {
> "type" : "hbase",
> "config" : {
> "hbase.zookeeper.quorum" : "localhost",
> "hbase.zookeeper.property.clientPort" : "2181"
> },
> "size.calcu
[jira] [Comment Edited] (DRILL-7186) Missing storage.json REST endpoint.
[
https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822052#comment-16822052
]
Sorabh Hamirwasia edited comment on DRILL-7186 at 4/19/19 5:02 PM:
---
@vdiravka / [~arina]
With DRILL-6562 I am seeing additional changes which is not supporting older
requests URL. For example:
1) Earlier export of plugin config was done for json format by default using
URL: */storage/\{name}/export* and now the new URL is
*/storage/\{name}/export/\{format}*. This means the older one is not supported
anymore. Is it intended or should we treat the format as JSON by default if not
provided ?
2) The POST URL to create and update plugin is changed from */storage/\{name}*
to */storage/create_update*
3) Once a storage plugin is deleted it is not redirected to */storage* anymore,
which it was in 1.15. Because of this line change:
[https://github.com/apache/drill/commit/5fff1d8bff899e1af551c16f26a58b6b1d033ffb#diff-274673e64e6f54be595a8703753123b0R115]
was (Author: shamirwasia):
@vdiravka / [~arina]
With DRILL-6562 I am seeing additional changes which is not supporting older
requests URL. For example:
1) Earlier export of plugin config was done for json format by default using
URL: */storage/\{name}/export* and now the new URL is
*/storage/\{name}/export/\{format}*. This means the older one is not supported
anymore. Is it intended or should we treat the format as JSON by default if not
provided ?
2) The POST URL to create and update plugin is changed from */storage/\{name}*
to */storage/create_update*
> Missing storage.json REST endpoint.
> ---
>
> Key: DRILL-7186
> URL: https://issues.apache.org/jira/browse/DRILL-7186
> Project: Apache Drill
> Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Anton Gozhiy
>Assignee: Arina Ielchiieva
>Priority: Blocker
> Labels: ready-to-commit
> Fix For: 1.16.0
>
>
> *Steps:*
> 1. Open page: http://:8047/storage.json
> *Expected result:*
> storage.json is opened:
> {noformat}
> [ {
> "name" : "cp",
> "config" : {
> "type" : "file",
> "connection" : "classpath:///",
> "config" : null,
> "workspaces" : { },
> "formats" : {
> "csv" : {
> "type" : "text",
> "extensions" : [ "csv" ],
> "delimiter" : ","
> },
> "tsv" : {
> "type" : "text",
> "extensions" : [ "tsv" ],
> "delimiter" : "\t"
> },
> "json" : {
> "type" : "json",
> "extensions" : [ "json" ]
> },
> "parquet" : {
> "type" : "parquet"
> },
> "avro" : {
> "type" : "avro"
> },
> "csvh" : {
> "type" : "text",
> "extensions" : [ "csvh" ],
> "extractHeader" : true,
> "delimiter" : ","
> },
> "image" : {
> "type" : "image",
> "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd",
> "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov",
> "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf",
> "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw",
> "x3f" ]
> }
> },
> "enabled" : true
> }
> }, {
> "name" : "dfs",
> "config" : {
> "type" : "file",
> "connection" : "file:///",
> "config" : null,
> "workspaces" : {
> "tmp" : {
> "location" : "/tmp",
> "writable" : true,
> "defaultInputFormat" : null,
> "allowAccessOutsideWorkspace" : false
> },
> "root" : {
> "location" : "/",
> "writable" : false,
> "defaultInputFormat" : null,
> "allowAccessOutsideWorkspace" : false
> }
> },
> "formats" : {
> "psv" : {
> "type" : "text",
> "extensions" : [ "tbl" ],
> "delimiter" : "|"
> },
> "csv" : {
> "type" : "text",
> "extensions" : [ "csv" ],
> "delimiter" : ","
> },
> "tsv" : {
> "type" : "text",
> "extensions" : [ "tsv" ],
> "delimiter" : "\t"
> },
> "httpd" : {
> "type" : "httpd",
> "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\""
> },
> "parquet" : {
> "type" : "parquet"
> },
> "json" : {
> "type" : "json",
> "extensions" : [ "json" ]
> },
> "pcap" : {
> "type" : "pcap"
> },
> "pcapng" : {
> "type" : "pcapng",
> "extensions" : [ "pcapng" ]
> },
> "avro" : {
> "type" : "avro"
> },
> "sequencefile" : {
> "type" : "sequencefile",
> "extensions" : [ "seq" ]
> },
> "csvh" : {
> "type" : "text",
> "extensions"
