[jira] [Commented] (DRILL-2691) Source files with Windows line endings
[
https://issues.apache.org/jira/browse/DRILL-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534865#comment-14534865
]
Jason Altekruse commented on DRILL-2691:
The patch is not applying cleanly, it doesn't look like git works well trying
to track line ending changes with patch files. I might be doing something
wrong, but I think whoever commits this is going to have to just manually make
the change and commit it from their repo. I am +1 on the change and I will try
to make this change myself soon and commit it.
Source files with Windows line endings
--
Key: DRILL-2691
URL: https://issues.apache.org/jira/browse/DRILL-2691
Project: Apache Drill
Issue Type: Bug
Components: Tools, Build Test
Affects Versions: 0.6.0
Reporter: Deneche A. Hakim
Assignee: Jason Altekruse
Fix For: 1.0.0
Attachments: DRILL-2691.1.patch.txt
The following files:
{noformat}
common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java
contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseCFAsJSONString.java
{noformat}
Have Windows line endings in them. Trying to apply a patch that contains
changes in one of those files will fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-2691) Source files with Windows line endings
[
https://issues.apache.org/jira/browse/DRILL-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528571#comment-14528571
]
Jacques Nadeau commented on DRILL-2691:
---
[~venki387], can you see if you can resolve?
Source files with Windows line endings
--
Key: DRILL-2691
URL: https://issues.apache.org/jira/browse/DRILL-2691
Project: Apache Drill
Issue Type: Bug
Components: Tools, Build Test
Affects Versions: 0.6.0
Reporter: Deneche A. Hakim
Assignee: Venki Korukanti
Fix For: 1.0.0
Attachments: DRILL-2691.1.patch.txt
The following files:
{noformat}
common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java
contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseCFAsJSONString.java
{noformat}
Have Windows line endings in them. Trying to apply a patch that contains
changes in one of those files will fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DRILL-2691) Source files with Windows line endings
[
https://issues.apache.org/jira/browse/DRILL-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481324#comment-14481324
]
Deneche A. Hakim commented on DRILL-2691:
-
I couldn't apply the patch on top of master. Here is a link to [my branch on
github|https://github.com/adeneche/incubator-drill/tree/DRILL-2691]
Source files with Windows line endings
--
Key: DRILL-2691
URL: https://issues.apache.org/jira/browse/DRILL-2691
Project: Apache Drill
Issue Type: Bug
Affects Versions: 0.6.0
Reporter: Deneche A. Hakim
Assignee: Deneche A. Hakim
Fix For: 0.9.0
Attachments: DRILL-2691.1.patch.txt
The following files:
{noformat}
common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java
contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseCFAsJSONString.java
{noformat}
Have Windows line endings in them. Trying to apply a patch that contains
changes in one of those files will fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
