[jira] [Commented] (FINERACT-1129) Gradle task to create release package
[ https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185580#comment-17185580 ] Chinmay Kulkarni commented on FINERACT-1129: Hi! Need a little feedback here. The documentation fix PR is merged into *develop* [https://github.com/apache/fineract/pull/1293] I was wondering, how do we plan to have these changes in *1.4.0*? Are we planning to sync develop with 1.4.0 later as *1.4.0 <- develop* or should I create a backport PR for *1.4.0*? Also, if I want to send any more fixes for the library generation part (to be released in 1.4.0), to which branch should I raise a PR? > Gradle task to create release package > - > > Key: FINERACT-1129 > URL: https://issues.apache.org/jira/browse/FINERACT-1129 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Minor > Fix For: 1.4.0 > > > Add Gradle task to create release package with following artifacts: > * WAR > * server JAR > * client JAR > * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1135) Error at Loan Repayments - SQLSyntaxErrorException
Francis Guchie created FINERACT-1135: Summary: Error at Loan Repayments - SQLSyntaxErrorException Key: FINERACT-1135 URL: https://issues.apache.org/jira/browse/FINERACT-1135 Project: Apache Fineract Issue Type: Bug Components: Loan Affects Versions: 1.4.0 Reporter: Francis Guchie Fix For: 1.4.0 org.springframework.jdbc.BadSqlGrammarException: PreparedStatementCallback; bad SQL grammar - Caused by: java.sql.SQLSyntaxErrorException: Image is hear below !image-2020-08-27-02-59-38-802.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1135) Error at Loan Repayments - SQLSyntaxErrorException
[ https://issues.apache.org/jira/browse/FINERACT-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Guchie reassigned FINERACT-1135: Assignee: Francis Guchie > Error at Loan Repayments - SQLSyntaxErrorException > -- > > Key: FINERACT-1135 > URL: https://issues.apache.org/jira/browse/FINERACT-1135 > Project: Apache Fineract > Issue Type: Bug > Components: Loan >Affects Versions: 1.4.0 >Reporter: Francis Guchie >Assignee: Francis Guchie >Priority: Critical > Labels: beginner > Fix For: 1.4.0 > > > org.springframework.jdbc.BadSqlGrammarException: PreparedStatementCallback; > bad SQL grammar - Caused by: java.sql.SQLSyntaxErrorException: > Image is hear below > !image-2020-08-27-02-59-38-802.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1129) Gradle task to create release package
[ https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185564#comment-17185564 ] Chinmay Kulkarni commented on FINERACT-1129: [~aleks] That's great! Let me know if there's anything else I can do here. > Gradle task to create release package > - > > Key: FINERACT-1129 > URL: https://issues.apache.org/jira/browse/FINERACT-1129 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Minor > Fix For: 1.4.0 > > > Add Gradle task to create release package with following artifacts: > * WAR > * server JAR > * client JAR > * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-629) Authentication API endpoint forces username and password as URL params
[
https://issues.apache.org/jira/browse/FINERACT-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandar Vidakovic updated FINERACT-629:
--
Fix Version/s: (was: 1.5.0)
1.4.0
> Authentication API endpoint forces username and password as URL params
> --
>
> Key: FINERACT-629
> URL: https://issues.apache.org/jira/browse/FINERACT-629
> Project: Apache Fineract
> Issue Type: Improvement
> Components: System
>Reporter: Jose A. Franco
>Priority: Critical
> Labels: security, technical
> Fix For: 1.4.0
>
>
> As documented in the live API documentation available here:
> [https://demo.openmf.org/api-docs/apiLive.htm#authentication]
> Clients must send username and password as URL params of the API endpoint
> {code:java}
> ...
> function setBasicAuthKey(username, password) { var jqxhr = $.ajax({ url :
> "authentication?username=" + username + "=" + password, type :
> 'POST',
> ...
> {code}
> This could cause issues with credentials leakage if the platform is deployed
> in an environment where there is server-side URL logging. Access to those
> logs would expose passwords.
> Proposed solution is to alternatively allow sending username and password as
> request body or as a header.
>
> Something similar happens with the OAuth endpoint:
> {code:java}
> var jqxhr = $.ajax({ url : "/fineract-provider/api/oauth/token?username=" +
> credentials.username + "=" + credentials.password
> +"_id=community-app_type=password_secret=123
> {code}
> *Solution proposal*
> Alternatively, allow credentials to be sent as part of the request payload.
> It would be less prone to leakage in case there is server-side URL logging.
> For the /authentication endpoint it might make sense as well to support the
> standard Basic Http Auth header already base64-encoded.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1120) Two Factor Auth Filter Type Cast Error
[
https://issues.apache.org/jira/browse/FINERACT-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandar Vidakovic updated FINERACT-1120:
---
Fix Version/s: (was: 1.5.0)
1.4.0
> Two Factor Auth Filter Type Cast Error
> --
>
> Key: FINERACT-1120
> URL: https://issues.apache.org/jira/browse/FINERACT-1120
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: Saransh Sharma
>Priority: Major
> Fix For: 1.4.0
>
>
> Error :
> java.lang.ClassCastException: class java.lang.String cannot be cast to class
> org.springframework.security.authentication.AnonymousAuthenticationToken
> {code:java}
> // AppUser user = (AppUser) authentication.getPrincipal();
> {code}
> This line has some type casting error exception when running the two factor
> mode.
> To enable two factor mode you need to run with -Psecurity=twofactor
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1120) Two Factor Auth Filter Type Cast Error
[
https://issues.apache.org/jira/browse/FINERACT-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ed Cable updated FINERACT-1120:
---
Fix Version/s: 1.5.0
> Two Factor Auth Filter Type Cast Error
> --
>
> Key: FINERACT-1120
> URL: https://issues.apache.org/jira/browse/FINERACT-1120
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: Saransh Sharma
>Priority: Major
> Fix For: 1.5.0
>
>
> Error :
> java.lang.ClassCastException: class java.lang.String cannot be cast to class
> org.springframework.security.authentication.AnonymousAuthenticationToken
> {code:java}
> // AppUser user = (AppUser) authentication.getPrincipal();
> {code}
> This line has some type casting error exception when running the two factor
> mode.
> To enable two factor mode you need to run with -Psecurity=twofactor
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FINERACT-1101) Swagger CodeGen Test Build using Gradle instead of Maven
[
https://issues.apache.org/jira/browse/FINERACT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandar Vidakovic reassigned FINERACT-1101:
--
Assignee: Aleksandar Vidakovic (was: Chinmay Kulkarni)
> Swagger CodeGen Test Build using Gradle instead of Maven
>
>
> Key: FINERACT-1101
> URL: https://issues.apache.org/jira/browse/FINERACT-1101
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Aleksandar Vidakovic
>Priority: Minor
> Fix For: 1.4.0
>
>
> Looking at [https://travis-ci.org/github/apache/fineract/builds/714158191]
> for [https://github.com/apache/fineract/pull/1228] for FINERACT-838, I've
> noticed that the Swagger Client Code Generation seems to be built using
> Maven {{mvn}}... but on {{docs/developers/swagger/client.md}} we document the
> use of Gradle. This seems inconsistent, and requiring Fineract developers to
> have Maven installed just for this may be unnecessary?
> [~Grandolf49] was there a particular reason why you chose to build the client
> using Maven instead of Gradle on Travis in your PR? If none, would you be
> willing to raise a PR to change that?
> If that is not possible, the Travis CI should should at least use the Maven
> Wrapper {{./mvnw}} instead of {{mvn}}. And we should add Caching of Maven
> artifacts in addition to Gradle to the Travis CI configuration, to make it a
> bit faster.
> [~Manthan] [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FINERACT-1133) Swagger generated library incorrect documentation
[ https://issues.apache.org/jira/browse/FINERACT-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandar Vidakovic reassigned FINERACT-1133: -- Assignee: Aleksandar Vidakovic (was: Chinmay Kulkarni) > Swagger generated library incorrect documentation > - > > Key: FINERACT-1133 > URL: https://issues.apache.org/jira/browse/FINERACT-1133 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.3.0 >Reporter: Chinmay Kulkarni >Assignee: Aleksandar Vidakovic >Priority: Major > Fix For: 1.4.0 > > > Client library generated by Swagger Codegen provides poor documentation of > how to use the library. It definitely does a great job at generating all the > documentation using Mustache templates but if a user uses that code, it would > probably fail. > *Resolution:* > 1. Create Mustache templates for improving the documentation of the generated > library -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1134) Backport FINERACT-1129 to release branch 1.4.0
[ https://issues.apache.org/jira/browse/FINERACT-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandar Vidakovic updated FINERACT-1134: --- Parent: FINERACT-1129 Issue Type: Sub-task (was: Task) > Backport FINERACT-1129 to release branch 1.4.0 > -- > > Key: FINERACT-1134 > URL: https://issues.apache.org/jira/browse/FINERACT-1134 > Project: Apache Fineract > Issue Type: Sub-task > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Blocker > Fix For: 1.4.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1134) Backport FINERACT-1129 to release branch 1.4.0
Aleksandar Vidakovic created FINERACT-1134: -- Summary: Backport FINERACT-1129 to release branch 1.4.0 Key: FINERACT-1134 URL: https://issues.apache.org/jira/browse/FINERACT-1134 Project: Apache Fineract Issue Type: Task Components: Build Affects Versions: 1.4.0 Reporter: Aleksandar Vidakovic Assignee: Aleksandar Vidakovic Fix For: 1.4.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-876) Automate Fineract release process
[ https://issues.apache.org/jira/browse/FINERACT-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandar Vidakovic reassigned FINERACT-876: - Assignee: Aleksandar Vidakovic > Automate Fineract release process > - > > Key: FINERACT-876 > URL: https://issues.apache.org/jira/browse/FINERACT-876 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > > While I was making some minor edits to improve our [How to Release Apache > Fineract|https://cwiki.apache.org/confluence/x/DRwIB] page on the Wiki for a > possible upcoming Fineract 1.4.0 release in FINERACT-873, I was wondering if > much of what is listed on that page, like all the git operations, email > sending, verification, GPG stuff, even Wiki page creation (Confluence has a > REST API...) could not just be fully automated and scripted... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1129) Gradle task to create release package
[ https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185496#comment-17185496 ] Aleksandar Vidakovic commented on FINERACT-1129: [~Grandolf49] I've re-activated the client code generation and build as part of the release process (following your instructions in the README concerning client build). The client jar artifact is now included in the release distribution. Works as advertised. Changes are pushed. > Gradle task to create release package > - > > Key: FINERACT-1129 > URL: https://issues.apache.org/jira/browse/FINERACT-1129 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Minor > Fix For: 1.4.0 > > > Add Gradle task to create release package with following artifacts: > * WAR > * server JAR > * client JAR > * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1129) Gradle task to create release package
[ https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185483#comment-17185483 ] Chinmay Kulkarni commented on FINERACT-1129: [~aleks] I think we can release the client library in 1.4.0 itself. I have fixed the improper documentation and tested the library against *demo.fineract.dev* platform. It is working fine! The PR for the documentation fix is [PR-1293|https://github.com/apache/fineract/pull/1293] which directly depends on [PR-1285|https://github.com/apache/fineract/pull/1285]. I have requested [PR-1293|https://github.com/apache/fineract/pull/1293] to be merged into the *develop* branch as [PR-1285|https://github.com/apache/fineract/pull/1285] is not yet merged in *1.4.0*. > Gradle task to create release package > - > > Key: FINERACT-1129 > URL: https://issues.apache.org/jira/browse/FINERACT-1129 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Minor > Fix For: 1.4.0 > > > Add Gradle task to create release package with following artifacts: > * WAR > * server JAR > * client JAR > * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1133) Swagger generated library incorrect documentation
[ https://issues.apache.org/jira/browse/FINERACT-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Kulkarni updated FINERACT-1133: --- Description: Client library generated by Swagger Codegen provides poor documentation of how to use the library. It definitely does a great job at generating all the documentation using Mustache templates but if a user uses that code, it would probably fail. *Resolution:* 1. Create Mustache templates for improving the documentation of the generated library was:Client library generated by Swagger Codegen is not able to authenticate the user. Implementation of API Client in the generated library is missing the *fineract-platform-tenantid : default* header. Currently it only adds the header but doesn't set it's value to default. This is causing the API to return *Error 400 Bad Request* error when executed. > Swagger generated library incorrect documentation > - > > Key: FINERACT-1133 > URL: https://issues.apache.org/jira/browse/FINERACT-1133 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.3.0 >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Fix For: 1.4.0 > > > Client library generated by Swagger Codegen provides poor documentation of > how to use the library. It definitely does a great job at generating all the > documentation using Mustache templates but if a user uses that code, it would > probably fail. > *Resolution:* > 1. Create Mustache templates for improving the documentation of the generated > library -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1133) Swagger generated library incorrect documentation
[ https://issues.apache.org/jira/browse/FINERACT-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Kulkarni updated FINERACT-1133: --- Summary: Swagger generated library incorrect documentation (was: Swagger generated library not able to authenticate user) > Swagger generated library incorrect documentation > - > > Key: FINERACT-1133 > URL: https://issues.apache.org/jira/browse/FINERACT-1133 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.3.0 >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Fix For: 1.4.0 > > > Client library generated by Swagger Codegen is not able to authenticate the > user. Implementation of API Client in the generated library is missing the > *fineract-platform-tenantid : default* header. Currently it only adds the > header but doesn't set it's value to default. This is causing the API to > return *Error 400 Bad Request* error when executed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1103) Resolve org.eclipse.persistence.exceptions.EntityManagerSetupException
[
https://issues.apache.org/jira/browse/FINERACT-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185353#comment-17185353
]
Yemdjih Kaze Nasser commented on FINERACT-1103:
---
(y)
> Resolve org.eclipse.persistence.exceptions.EntityManagerSetupException
> --
>
> Key: FINERACT-1103
> URL: https://issues.apache.org/jira/browse/FINERACT-1103
> Project: Apache Fineract
> Issue Type: Sub-task
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Assignee: Yemdjih Kaze Nasser
>Priority: Blocker
> Fix For: 1.4.0
>
>
> {code:java}
> Caused by: org.eclipse.persistence.exceptions.IntegrityException:
> Descriptor Exceptions:
> -
>
> Exception [EclipseLink-93] (Eclipse Persistence Services -
> 2.7.7.v20200504-69f2c2b80d):
> org.eclipse.persistence.exceptions.DescriptorException
> Exception Description: The table [m_organisation_creditbureau] is not present
> in this descriptor.
> Descriptor:
> RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
> --> [DatabaseTable(m_creditbureau)])
>
> Exception [EclipseLink-41] (Eclipse Persistence Services -
> 2.7.7.v20200504-69f2c2b80d):
> org.eclipse.persistence.exceptions.DescriptorException
> Exception Description: A non-read-only mapping must be defined for the
> sequence number field.
> Descriptor:
> RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
> --> [DatabaseTable(m_creditbureau)]){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1129) Gradle task to create release package
[ https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185288#comment-17185288 ] Aleksandar Vidakovic commented on FINERACT-1129: [~vorburger] please have a look at the sources again (or just clone and try it out). I think this is ready for prime time. Following fixes: * added detailed instructions how to setup your environment in README.md * fixed a minor issue related to duplicate file entries in tar.gz file * no separate task required anymore, i. e. "fineractRelease" is gone * create a release with a simple command line flag: ./gradlew -Pfineract.release clean build * ASCII armored signature created * SHA512 checksum created (was not present in previous releases, but is actually required by Apache) * by default signatures and checksums are disabled, i. e. ./gradlew clean build can be executed by normal devs without errors I think this is as good as it gets > Gradle task to create release package > - > > Key: FINERACT-1129 > URL: https://issues.apache.org/jira/browse/FINERACT-1129 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Minor > Fix For: 1.4.0 > > > Add Gradle task to create release package with following artifacts: > * WAR > * server JAR > * client JAR > * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1133) Swagger generated library not able to authenticate user
Chinmay Kulkarni created FINERACT-1133: -- Summary: Swagger generated library not able to authenticate user Key: FINERACT-1133 URL: https://issues.apache.org/jira/browse/FINERACT-1133 Project: Apache Fineract Issue Type: Bug Affects Versions: 1.3.0 Reporter: Chinmay Kulkarni Assignee: Chinmay Kulkarni Fix For: 1.4.0 Client library generated by Swagger Codegen is not able to authenticate the user. Implementation of API Client in the generated library is missing the *fineract-platform-tenantid : default* header. Currently it only adds the header but doesn't set it's value to default. This is causing the API to return *Error 400 Bad Request* error when executed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1096) Clients: unable to upload a client profile image
[ https://issues.apache.org/jira/browse/FINERACT-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185154#comment-17185154 ] Petri Tuomola commented on FINERACT-1096: - This works for me at least on my local installation as well as on demo.fineract.dev. I think this is related to the installation / configuration of Fineract on dev.mifos.io rather than on the software itself. > Clients: unable to upload a client profile image > > > Key: FINERACT-1096 > URL: https://issues.apache.org/jira/browse/FINERACT-1096 > Project: Apache Fineract > Issue Type: Bug >Reporter: Karan >Priority: Minor > Attachments: Screenshot from 2020-07-25 22-21-15.png, Screenshot from > 2020-07-25 22-22-34.png > > > A client should be able to upload an image by POST request on the endpoint > [https://dev.mifos.io/fineract-provider/api/v1/clients/1/images] > Request Payload is a data URL > !Screenshot from 2020-07-25 22-21-15.png! > Error message: > !Screenshot from 2020-07-25 22-22-34.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1088) ResourceAccessException at SmsCampaignDropdownReadPlatformServiceImpl
[
https://issues.apache.org/jira/browse/FINERACT-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185136#comment-17185136
]
Petri Tuomola commented on FINERACT-1088:
-
[~vorburger] I just tried this out, and unfortunately the caller does not get a
PlatformDataIntegrityException: the exception thrown by Spring means the line
checking the status code never gets executed.
So we can catch the exception and then throw our own, so that the client gets a
sensible error message.
> ResourceAccessException at SmsCampaignDropdownReadPlatformServiceImpl
> -
>
> Key: FINERACT-1088
> URL: https://issues.apache.org/jira/browse/FINERACT-1088
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Minor
>
> See FINERACT-932 for general background; I've found this in logs of
> https://www.fineract.dev:
> {noformat}org.springframework.web.client.ResourceAccessException: I/O error
> on GET request for "http://localhost:9191/smsbridges": Connection refused
> (Connection refused); nested exception is java.net.ConnectException:
> Connection refused (Connection refused)
> at org.springframework.web.client.RestTemplate.doExecute
> (RestTemplate.java:748)
> at org.springframework.web.client.RestTemplate.execute
> (RestTemplate.java:714)
> at org.springframework.web.client.RestTemplate.exchange
> (RestTemplate.java:632)
> at
> org.apache.fineract.infrastructure.campaigns.sms.service.SmsCampaignDropdownReadPlatformServiceImpl.retrieveSmsProviders
> (SmsCampaignDropdownReadPlatformServiceImpl.java:80)
> at
> org.apache.fineract.infrastructure.campaigns.sms.service.SmsCampaignReadPlatformServiceImpl.retrieveTemplate
> (SmsCampaignReadPlatformServiceImpl.java:111)
> at
> org.apache.fineract.infrastructure.campaigns.sms.api.SmsCampaignApiResource.template
> (SmsCampaignApiResource.java:107)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native
> Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke
> (JavaMethodInvokerFactory.java:60)
> at
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch
> (AbstractResourceMethodDispatchProvider.java:185)
> at
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch
> (ResourceJavaMethodDispatcher.java:75)
> at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept
> (HttpMethodRule.java:302)
> at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept
> (RightHandPathRule.java:147)
> at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept
> (ResourceClassRule.java:108)
> at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept
> (RightHandPathRule.java:147)
> at
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept
> (RootResourceClassesRule.java:84)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest
> (WebApplicationImpl.java:1542)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest
> (WebApplicationImpl.java:1473)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest
> (WebApplicationImpl.java:1419)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest
> (WebApplicationImpl.java:1409)
> at com.sun.jersey.spi.container.servlet.WebComponent.service
> (WebComponent.java:409)
> at com.sun.jersey.spi.container.servlet.ServletContainer.service
> (ServletContainer.java:558)
> at com.sun.jersey.spi.container.servlet.ServletContainer.service
> (ServletContainer.java:733)
> at javax.servlet.http.HttpServlet.service (HttpServlet.java:741)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter
> (ApplicationFilterChain.java:231)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter
> (ApplicationFilterChain.java:166)
> at org.apache.tomcat.websocket.server.WsFilter.doFilter
> (WsFilter.java:53)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter
> (ApplicationFilterChain.java:193)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter
> (ApplicationFilterChain.java:166)
> at
>
[jira] [Commented] (FINERACT-1129) Gradle task to create release package
[ https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185129#comment-17185129 ] Aleksandar Vidakovic commented on FINERACT-1129: So... almost got the client JAR included. But having tried I'd suggest to move the client JAR to 1.5.0. Here are the problems that still prevent us from including it in the release: * generated client project uses Gradle 2.6; this introduces a requirement to JDK 8 again (won't run and compile with JDK 11 or 12 installed * client version information is not up to date; indicates that it's a 1.3.0 snapshot version (there seems to be some auto-versioning plugin active) * to build the client JAR I'm executing "gradlew" in "build/swagger-code-fineract"; that's a bit clunky from my perspective; instead we could make the whole project a multi-module project with client being one module and fineract-provider another; that way we can generate the client code without any gradle stuff and just build it as a "normal" module inside the Fineract project; I have refactored version that does something like this already laying around; let's discuss this The tasks for building the client JAR are commented out in build.gradle for safety. > Gradle task to create release package > - > > Key: FINERACT-1129 > URL: https://issues.apache.org/jira/browse/FINERACT-1129 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Minor > Fix For: 1.4.0 > > > Add Gradle task to create release package with following artifacts: > * WAR > * server JAR > * client JAR > * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1088) ResourceAccessException at SmsCampaignDropdownReadPlatformServiceImpl
[
https://issues.apache.org/jira/browse/FINERACT-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola reassigned FINERACT-1088:
---
Assignee: Petri Tuomola
> ResourceAccessException at SmsCampaignDropdownReadPlatformServiceImpl
> -
>
> Key: FINERACT-1088
> URL: https://issues.apache.org/jira/browse/FINERACT-1088
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Minor
>
> See FINERACT-932 for general background; I've found this in logs of
> https://www.fineract.dev:
> {noformat}org.springframework.web.client.ResourceAccessException: I/O error
> on GET request for "http://localhost:9191/smsbridges": Connection refused
> (Connection refused); nested exception is java.net.ConnectException:
> Connection refused (Connection refused)
> at org.springframework.web.client.RestTemplate.doExecute
> (RestTemplate.java:748)
> at org.springframework.web.client.RestTemplate.execute
> (RestTemplate.java:714)
> at org.springframework.web.client.RestTemplate.exchange
> (RestTemplate.java:632)
> at
> org.apache.fineract.infrastructure.campaigns.sms.service.SmsCampaignDropdownReadPlatformServiceImpl.retrieveSmsProviders
> (SmsCampaignDropdownReadPlatformServiceImpl.java:80)
> at
> org.apache.fineract.infrastructure.campaigns.sms.service.SmsCampaignReadPlatformServiceImpl.retrieveTemplate
> (SmsCampaignReadPlatformServiceImpl.java:111)
> at
> org.apache.fineract.infrastructure.campaigns.sms.api.SmsCampaignApiResource.template
> (SmsCampaignApiResource.java:107)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native
> Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke
> (JavaMethodInvokerFactory.java:60)
> at
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch
> (AbstractResourceMethodDispatchProvider.java:185)
> at
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch
> (ResourceJavaMethodDispatcher.java:75)
> at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept
> (HttpMethodRule.java:302)
> at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept
> (RightHandPathRule.java:147)
> at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept
> (ResourceClassRule.java:108)
> at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept
> (RightHandPathRule.java:147)
> at
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept
> (RootResourceClassesRule.java:84)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest
> (WebApplicationImpl.java:1542)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest
> (WebApplicationImpl.java:1473)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest
> (WebApplicationImpl.java:1419)
> at
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest
> (WebApplicationImpl.java:1409)
> at com.sun.jersey.spi.container.servlet.WebComponent.service
> (WebComponent.java:409)
> at com.sun.jersey.spi.container.servlet.ServletContainer.service
> (ServletContainer.java:558)
> at com.sun.jersey.spi.container.servlet.ServletContainer.service
> (ServletContainer.java:733)
> at javax.servlet.http.HttpServlet.service (HttpServlet.java:741)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter
> (ApplicationFilterChain.java:231)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter
> (ApplicationFilterChain.java:166)
> at org.apache.tomcat.websocket.server.WsFilter.doFilter
> (WsFilter.java:53)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter
> (ApplicationFilterChain.java:193)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter
> (ApplicationFilterChain.java:166)
> at
> org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke
> (FilterSecurityInterceptor.java:115)
> at
> org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter
> (FilterSecurityInterceptor.java:90)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter
> (ApplicationFilterChain.java:193)
> at
[jira] [Assigned] (FINERACT-1128) Travis build fails with connection refused
[
https://issues.apache.org/jira/browse/FINERACT-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola reassigned FINERACT-1128:
---
Assignee: Petri Tuomola
> Travis build fails with connection refused
> --
>
> Key: FINERACT-1128
> URL: https://issues.apache.org/jira/browse/FINERACT-1128
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Petri Tuomola
>Assignee: Petri Tuomola
>Priority: Major
>
> Travis build often fails with the following error when trying to check that
> the Docker container has come up as expected:
> http: error: ConnectionError: HTTPSConnectionPool(host='localhost',
> port=8443): Max retries exceeded with url: /fineract-provider/actuator/health
> (Caused by NewConnectionError(' object at 0x7fd6051a9c18>: Failed to establish a new connection: [Errno 111]
> Connection refused',)) while doing GET request to URL:
> [https://localhost:8443/fineract-provider/actuator/health]
> Retrying the build works so this is an issue with infra rather than code -
> may just be due to the Docker container taking longer than expected in coming
> up?
> One possible solution could be to switch from http to curl and then use
> curl's facility for retries - i.e. try the connection 5 times with 30 second
> breaks between retries to see if the container comes up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1129) Gradle task to create release package
[ https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185084#comment-17185084 ] Michael Vorburger commented on FINERACT-1129: - > and maybe we can publish it also to Maven Central. [~aleks] engage on FINERACT-1102 re. that - help over there most welcome! > Gradle task to create release package > - > > Key: FINERACT-1129 > URL: https://issues.apache.org/jira/browse/FINERACT-1129 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Minor > Fix For: 1.4.0 > > > Add Gradle task to create release package with following artifacts: > * WAR > * server JAR > * client JAR > * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FINERACT-1129) Gradle task to create release package
[ https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185084#comment-17185084 ] Michael Vorburger edited comment on FINERACT-1129 at 8/26/20, 10:22 AM: > and maybe we can publish it also to Maven Central. [~aleks] watch and engage on FINERACT-1102 re. that - help over there most welcome! was (Author: vorburger): > and maybe we can publish it also to Maven Central. [~aleks] engage on FINERACT-1102 re. that - help over there most welcome! > Gradle task to create release package > - > > Key: FINERACT-1129 > URL: https://issues.apache.org/jira/browse/FINERACT-1129 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Minor > Fix For: 1.4.0 > > > Add Gradle task to create release package with following artifacts: > * WAR > * server JAR > * client JAR > * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1105) Swagger generates invalid Open API Specification file
[
https://issues.apache.org/jira/browse/FINERACT-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger resolved FINERACT-1105.
-
Resolution: Fixed
> Swagger generates invalid Open API Specification file
> -
>
> Key: FINERACT-1105
> URL: https://issues.apache.org/jira/browse/FINERACT-1105
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Chinmay Kulkarni
>Assignee: Chinmay Kulkarni
>Priority: Minor
> Fix For: 1.4.0
>
>
> The Open API Specification file produced by Swagger Gradle Plugin is invalid.
> # Run *./gradlew build*
> # Use the contents of the generated Open API Spec file
> *build/classes/java/main/static/swagger-ui/fineract.yaml* to debug/validate
> spec file from here: [https://validator.swagger.io/] - Use Debug POST
> request to validate
> The validator returns the following:
> {code:yaml}
> ---
> messages: - "attribute paths.'/glclosures'(get).responses.200.description is
> missing"
> - "attribute paths.'/glclosures'(post).responses.200.description is missing"
> - "attribute paths.'/glclosures/{glClosureId}'(get).responses.200.description
> is missing"
> - "attribute paths.'/glclosures/{glClosureId}'(put).responses.200.description
> is missing"
> - "attribute
> paths.'/glclosures/{glClosureId}'(delete).responses.200.description is\
> \ missing"
> - "attribute
> paths.'/financialactivityaccounts'(get).responses.200.description is\
> \ missing"
> - "attribute
> paths.'/financialactivityaccounts'(post).responses.200.description is\
> \ missing"
> - "attribute
> paths.'/financialactivityaccounts/{mappingId}'(get).responses.200.description\
> \ is missing"
> - "attribute
> paths.'/financialactivityaccounts/{mappingId}'(put).responses.200.description\
> \ is missing"
> - "attribute paths.'/glaccounts/template'(get).responses.200.description is
> missing"
> - "attribute paths.'/glaccounts'(get).responses.200.description is missing"
> - "attribute paths.'/glaccounts'(post).responses.200.description is missing"
> - "attribute paths.'/glaccounts/{glAccountId}'(get).responses.200.description
> is missing"
> - "attribute paths.'/glaccounts/{glAccountId}'(put).responses.200.description
> is missing"
> - "attribute
> paths.'/glaccounts/{glAccountId}'(delete).responses.200.description is\
> \ missing"
> - "attribute
> paths.'/journalentries/{transactionId}'(post).responses.200.description\
> \ is missing"
> - "attribute
> paths.'/journalentries/{journalEntryId}'(get).responses.200.description\
> \ is missing"
> - "attribute paths.'/journalentries'(get).responses.200.description is
> missing"
> - "attribute paths.'/journalentries'(post).responses.200.description is
> missing"
> - "attribute paths.'/provisioningentries'(get).responses.200.description is
> missing"
> - "attribute paths.'/provisioningentries'(post).responses.200.description is
> missing"
> - "attribute
> paths.'/provisioningentries/entries'(get).responses.200.description is\
> \ missing"
> - "attribute
> paths.'/provisioningentries/{entryId}'(get).responses.200.description\
> \ is missing"
> - "attribute
> paths.'/provisioningentries/{entryId}'(post).responses.200.description\
> \ is missing"
> - "attribute paths.'/accountingrules'(get).responses.200.description is
> missing"
> - "attribute paths.'/accountingrules'(post).responses.200.description is
> missing"
> - "attribute
> paths.'/accountingrules/{accountingRuleId}'(get).responses.200.description\
> \ is missing"
> - "attribute
> paths.'/accountingrules/{accountingRuleId}'(put).responses.200.description\
> \ is missing"
> - "attribute
> paths.'/accountingrules/{accountingRuleId}'(delete).responses.200.description\
> \ is missing"
> - "attribute paths.'/accountingrules/template'(get).responses.200.description
> is missing"
> - "attribute paths.'/audits/searchtemplate'(get).responses.200.description is
> missing"
> - "attribute paths.'/audits'(get).responses.200.description is missing"
> - "attribute paths.'/audits/{auditId}'(get).responses.200.description is
> missing"
> - "attribute
> paths.'/makercheckers/searchtemplate'(get).responses.200.description\
> \ is missing"
> - "attribute paths.'/makercheckers/{auditId}'(post).responses.200.description
> is missing"
> - "attribute
> paths.'/makercheckers/{auditId}'(delete).responses.200.description is\
> \ missing"
> - "attribute paths.'/makercheckers'(get).responses.200.description is missing"
> - "attribute paths.'/accountnumberformats'(get).responses.200.description is
> missing"
> - "attribute paths.'/accountnumberformats'(post).responses.200.description is
> missing"
> - "attribute
> paths.'/accountnumberformats/template'(get).responses.200.description\
> \ is missing"
> - "attribute
>
[jira] [Commented] (FINERACT-1102) Swagger Codegen Client JAR should be available on a Maven repo
[ https://issues.apache.org/jira/browse/FINERACT-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185082#comment-17185082 ] Michael Vorburger commented on FINERACT-1102: - > I'm not actually sure how we'd do this at ASF. Is anyone motivate to research > this a bit more, and/or open an INFRA issue for ASF staff to advise on this? I spent a moment researching this further, and found and read https://infra.apache.org/publishing-maven-artifacts.html (and https://maven.apache.org/pom/asf/), noticed on https://repository.apache.org/#nexus-search;quick~fineract that we weren't there yet, and thus raised the linked INFRA-20768, and INFRA-20769. (To clarify, I'm just trying to get this started, I would very much welcome others jumping and taking this further.) > Swagger Codegen Client JAR should be available on a Maven repo > -- > > Key: FINERACT-1102 > URL: https://issues.apache.org/jira/browse/FINERACT-1102 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Chinmay Kulkarni >Priority: Major > > FINERACT-838 contributed Swagger Codegen Client generation. > In order for the JAR built from that to actually be easily usable, we should > "distribute" it... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1129) Gradle task to create release package
[ https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185072#comment-17185072 ] Chinmay Kulkarni commented on FINERACT-1129: Sure [~aleks] I'll ket you know if we can have this released in *1.4.0*. I'm currently testing the generated code and checking if it is ready to be released or requires any modifications. The main issue I'm facing is with the generated documentation. Swagger Codegen automatically generates the documentation for API Client usage. And in our case, if a user follows that documentation to consume API, it is not working. So 2 steps here: # Find out how one can actually use the library # Create a Mustache Template for ApiDoc so that generated docs are updated with this usage examples. Currently, I'm not sure how easy or tedious this is. I'll confirm with you in some time whether we can have this in the current release or not. > Gradle task to create release package > - > > Key: FINERACT-1129 > URL: https://issues.apache.org/jira/browse/FINERACT-1129 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Minor > Fix For: 1.4.0 > > > Add Gradle task to create release package with following artifacts: > * WAR > * server JAR > * client JAR > * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1129) Gradle task to create release package
[ https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185064#comment-17185064 ] Aleksandar Vidakovic commented on FINERACT-1129: [~vorburger] thanks for the pointers... agree with all of them. No problem at to do feedback before the PR... that way we have a clean PR. Adding a source distribution should not be too much of a problem, will add this shortly. Initially I named the task "release", but then thought it might clash with some built in task (the name is quite generic). But wiring this to the distribution lifecycle appears to be the best solution here... then we don't have to invent something. Documentation for running a release will be added with references to the GPG setup that is already documented. Gradle signing setup is easy, just a handful of properties in your ~/.gradle/gradle.properties, nevertheless there's one detail that took me a moment to figure out (signing key). Will write this up as soon as I can. And finally: [~Grandolf49] please let me know if we can add the compiled client library to this release and if you need a helping hand. If it's too much of a stress then there's next release... and maybe we can publish it also to Maven Central. > Gradle task to create release package > - > > Key: FINERACT-1129 > URL: https://issues.apache.org/jira/browse/FINERACT-1129 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Minor > Fix For: 1.4.0 > > > Add Gradle task to create release package with following artifacts: > * WAR > * server JAR > * client JAR > * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1132) Notifications functionality needs to be updated
Karan created FINERACT-1132: --- Summary: Notifications functionality needs to be updated Key: FINERACT-1132 URL: https://issues.apache.org/jira/browse/FINERACT-1132 Project: Apache Fineract Issue Type: Bug Reporter: Karan Connected with: [https://github.com/openMF/web-app/issues/1228] I am facing the following issues: * API doesn't return appropriate notifications for `isRead` parameter ie: setting it to false still returns notifs with `isRead=true` * With the present structure of routing in web app we need parent Id attribute to come along with notifications data for eg: for "loan created" notification we need client Id as well. * Cannot confirm whether notifications update with a `PUT` request on /notifications. * Please see this file for API calls: https://github.com/openMF/web-app/blob/master/src/app/notifications/notifications.service.ts -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-838) Swagger generated client libraries
[
https://issues.apache.org/jira/browse/FINERACT-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185054#comment-17185054
]
Michael Vorburger commented on FINERACT-838:
PS, just for the future record and to anyone looking at this issue later: The
doc for this is now on
https://github.com/apache/fineract/#apache-fineract-platform-api =>
https://github.com/apache/fineract/blob/develop/docs/developers/swagger/client.md
(and may still be updated and improved there in the future).
> Swagger generated client libraries
> --
>
> Key: FINERACT-838
> URL: https://issues.apache.org/jira/browse/FINERACT-838
> Project: Apache Fineract
> Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Major
> Fix For: 1.4.0
>
>
> In the review discussion of the first Swagger PR
> https://github.com/apache/fineract/pull/629 (which got superseded by
> https://github.com/apache/fineract/pull/695), this came up:
> {quote}The other plugin org.hidetake.swagger.generator is used to generate
> code from the openAPI spec file using swagger-codegen. So this does not
> generate response.json. It rather uses response.json to generate client
> code.{quote}
> and {quote} think i had explained the usage of this in my gist
> https://gist.github.com/kangbreder/034f47e2e8015cee10b48b7c5f1b8df1,
> generating client libraries and language-specific SDKs in languages such as
> java and angular from swagger specification file. This was part of the goals
> of the project listed in
> https://mifosforge.jira.com/wiki/spaces/RES/pages/812810251/Google+Summer+of+Code+2019+Ideas.{quote}
> Having (Swagger automatically generate!) client libraries in Java (and even
> other languages?!) seems like a cool idea. It's also something that perhaps
> needs a bit more investigation than only adding the respective Gradle plugin.
> If we actually do do this, after having done all of the work in the other
> Sub Tasks, then I think we would have to include sample code in the repo
> building against the generated client libraries to test and illustrate their
> usage. We would also have to publish those client libraries, e.g. as
> downloadable JAR from the release page (or later even made available on Maven
> central). It would perhaps be clearest if there was another directory in the
> Fineract source tree, next to and outside of not inside, the
> fineract-provider (which is the "server") for this purpose.
> [~kangbreder] [~awasum] [~sanyam] ([~sanyam96] ?) FYI
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1101) Swagger CodeGen Test Build using Gradle instead of Maven
[
https://issues.apache.org/jira/browse/FINERACT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185053#comment-17185053
]
Chinmay Kulkarni commented on FINERACT-1101:
Okay. I have raised a backport PR:
[https://github.com/apache/fineract/pull/1283] for this.
> Swagger CodeGen Test Build using Gradle instead of Maven
>
>
> Key: FINERACT-1101
> URL: https://issues.apache.org/jira/browse/FINERACT-1101
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Minor
> Fix For: 1.4.0
>
>
> Looking at [https://travis-ci.org/github/apache/fineract/builds/714158191]
> for [https://github.com/apache/fineract/pull/1228] for FINERACT-838, I've
> noticed that the Swagger Client Code Generation seems to be built using
> Maven {{mvn}}... but on {{docs/developers/swagger/client.md}} we document the
> use of Gradle. This seems inconsistent, and requiring Fineract developers to
> have Maven installed just for this may be unnecessary?
> [~Grandolf49] was there a particular reason why you chose to build the client
> using Maven instead of Gradle on Travis in your PR? If none, would you be
> willing to raise a PR to change that?
> If that is not possible, the Travis CI should should at least use the Maven
> Wrapper {{./mvnw}} instead of {{mvn}}. And we should add Caching of Maven
> artifacts in addition to Gradle to the Travis CI configuration, to make it a
> bit faster.
> [~Manthan] [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1103) Resolve org.eclipse.persistence.exceptions.EntityManagerSetupException
[
https://issues.apache.org/jira/browse/FINERACT-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185052#comment-17185052
]
Michael Vorburger commented on FINERACT-1103:
-
[~kaze] oh I see; yes, makes sense - thanks for clarifying.
> Resolve org.eclipse.persistence.exceptions.EntityManagerSetupException
> --
>
> Key: FINERACT-1103
> URL: https://issues.apache.org/jira/browse/FINERACT-1103
> Project: Apache Fineract
> Issue Type: Sub-task
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Assignee: Yemdjih Kaze Nasser
>Priority: Blocker
> Fix For: 1.4.0
>
>
> {code:java}
> Caused by: org.eclipse.persistence.exceptions.IntegrityException:
> Descriptor Exceptions:
> -
>
> Exception [EclipseLink-93] (Eclipse Persistence Services -
> 2.7.7.v20200504-69f2c2b80d):
> org.eclipse.persistence.exceptions.DescriptorException
> Exception Description: The table [m_organisation_creditbureau] is not present
> in this descriptor.
> Descriptor:
> RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
> --> [DatabaseTable(m_creditbureau)])
>
> Exception [EclipseLink-41] (Eclipse Persistence Services -
> 2.7.7.v20200504-69f2c2b80d):
> org.eclipse.persistence.exceptions.DescriptorException
> Exception Description: A non-read-only mapping must be defined for the
> sequence number field.
> Descriptor:
> RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
> --> [DatabaseTable(m_creditbureau)]){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1101) Swagger CodeGen Test Build using Gradle instead of Maven
[
https://issues.apache.org/jira/browse/FINERACT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185049#comment-17185049
]
Michael Vorburger commented on FINERACT-1101:
-
[~Grandolf49] yeah sure, sounds good to me. It's really more your call than
mine what you want to contribute and for which release. But if this helps for
FINERACT-1129, probably a good idea for you to back-port this to 1.4.0.
[~aleks] FYI.
> Swagger CodeGen Test Build using Gradle instead of Maven
>
>
> Key: FINERACT-1101
> URL: https://issues.apache.org/jira/browse/FINERACT-1101
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Minor
> Fix For: 1.4.0
>
>
> Looking at [https://travis-ci.org/github/apache/fineract/builds/714158191]
> for [https://github.com/apache/fineract/pull/1228] for FINERACT-838, I've
> noticed that the Swagger Client Code Generation seems to be built using
> Maven {{mvn}}... but on {{docs/developers/swagger/client.md}} we document the
> use of Gradle. This seems inconsistent, and requiring Fineract developers to
> have Maven installed just for this may be unnecessary?
> [~Grandolf49] was there a particular reason why you chose to build the client
> using Maven instead of Gradle on Travis in your PR? If none, would you be
> willing to raise a PR to change that?
> If that is not possible, the Travis CI should should at least use the Maven
> Wrapper {{./mvnw}} instead of {{mvn}}. And we should add Caching of Maven
> artifacts in addition to Gradle to the Travis CI configuration, to make it a
> bit faster.
> [~Manthan] [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1101) Swagger CodeGen Test Build using Gradle instead of Maven
[
https://issues.apache.org/jira/browse/FINERACT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184976#comment-17184976
]
Chinmay Kulkarni commented on FINERACT-1101:
[~vorburger] Since this PR
[PR-1271|https://github.com/apache/fineract/pull/1271] fixes the issue of
"*Build Failed due to maven-javadoc-plugin"* along with allowing user to build
using *Gradle*, I think we should have this in 1.4.0 (if that's possible).
Without this, in order for the user to build the generated code, he/she will
manually have to edit the *pom.xml* and *gradle-wrapper.properties* file of the
generated code and adjust the versions.
Should I raise a backport PR for this as well?
> Swagger CodeGen Test Build using Gradle instead of Maven
>
>
> Key: FINERACT-1101
> URL: https://issues.apache.org/jira/browse/FINERACT-1101
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Minor
> Fix For: 1.4.0
>
>
> Looking at [https://travis-ci.org/github/apache/fineract/builds/714158191]
> for [https://github.com/apache/fineract/pull/1228] for FINERACT-838, I've
> noticed that the Swagger Client Code Generation seems to be built using
> Maven {{mvn}}... but on {{docs/developers/swagger/client.md}} we document the
> use of Gradle. This seems inconsistent, and requiring Fineract developers to
> have Maven installed just for this may be unnecessary?
> [~Grandolf49] was there a particular reason why you chose to build the client
> using Maven instead of Gradle on Travis in your PR? If none, would you be
> willing to raise a PR to change that?
> If that is not possible, the Travis CI should should at least use the Maven
> Wrapper {{./mvnw}} instead of {{mvn}}. And we should add Caching of Maven
> artifacts in addition to Gradle to the Travis CI configuration, to make it a
> bit faster.
> [~Manthan] [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
