[jira] [Commented] (FINERACT-494) Issue when selecting savings account on client creation page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169678#comment-16169678
 ] 

ASF GitHub Bot commented on FINERACT-494:
-

Github user myrlen commented on the issue:

https://github.com/apache/fineract/pull/411
  
TEST MESSAGE

testing mailing list integration


> Issue when selecting savings account on client creation page
> 
>
> Key: FINERACT-494
> URL: https://issues.apache.org/jira/browse/FINERACT-494
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Client, Savings
>Reporter: Chanda Aparna
>Assignee: Shaik Nazeer Hussain
>  Labels: p1
> Attachments: client page.jpg
>
>
> When user checks open savings account on the client creation page, the 
> savings product dropdown is enabled. All the savings product irrespective of 
> Recurring or Saving deposits will be displayed in that. Once the saving 
> product(recurring product with ismandatory checked) is selected and submitted 
> the client page, the selected savings product which is recurring with 
> ismandatory flag true is saved as saving deposit(deposit_type_enum: 100) 
> instead of recurring deposit(deposit_type_enum: 300) in savings table 
> (m_savings_account) with the created client id, which is a bug. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-494) Issue when selecting savings account on client creation page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176106#comment-16176106
 ] 

ASF GitHub Bot commented on FINERACT-494:
-

Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/411


> Issue when selecting savings account on client creation page
> 
>
> Key: FINERACT-494
> URL: https://issues.apache.org/jira/browse/FINERACT-494
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Client, Savings
>Reporter: Chanda Aparna
>Assignee: Shaik Nazeer Hussain
>  Labels: p1
> Attachments: client page.jpg
>
>
> When user checks open savings account on the client creation page, the 
> savings product dropdown is enabled. All the savings product irrespective of 
> Recurring or Saving deposits will be displayed in that. Once the saving 
> product(recurring product with ismandatory checked) is selected and submitted 
> the client page, the selected savings product which is recurring with 
> ismandatory flag true is saved as saving deposit(deposit_type_enum: 100) 
> instead of recurring deposit(deposit_type_enum: 300) in savings table 
> (m_savings_account) with the created client id, which is a bug. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-527) Enhancing Notification Framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178064#comment-16178064
 ] 

ASF GitHub Bot commented on FINERACT-527:
-

Github user Anh3h commented on the issue:

https://github.com/apache/fineract/pull/405
  
Hi @nazeer1100126 sorry for the delayed reply, my computer crashed so I 
needed some time to bring back to life :). Here is the issue I created 
https://issues.apache.org/jira/browse/FINERACT-527


> Enhancing Notification Framework
> 
>
> Key: FINERACT-527
> URL: https://issues.apache.org/jira/browse/FINERACT-527
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Organization, User Management
>Reporter: Courage Angeh
>Assignee: Markus Geiss
>
> *Requirements*
> * User subscription to topic when user account is created
> * Create topics for an organization based on roles in that organization, when 
> the organization is created
> *  Upgrade process of user notification
> *  Migration script - topic, topic subscription models for new and already 
> existing users and organizations
> * Update user subscription on user transfer and/or update of user's permission
> *  Update topic details when entity details updates
> *  Update topic details when member type are updated at the system level
> *  Unit test topic-subscriber model



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-241) Include "Add Note" to Deposit and Withdrawal screen in savings account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198895#comment-16198895
 ] 

ASF GitHub Bot commented on FINERACT-241:
-

Github user avikganguly01 commented on the issue:

https://github.com/apache/fineract/pull/380
  
@Ippezrobert : Would you be able to make the suggested changes?


> Include "Add Note" to Deposit and Withdrawal screen in savings account
> --
>
> Key: FINERACT-241
> URL: https://issues.apache.org/jira/browse/FINERACT-241
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Dayna Harp
>Assignee: Markus Geiss
>  Labels: beginner, p3
>
> https://mifosforge.jira.com/browse/MIFOSX-2620
> Refer to MIFOSX for images
> Include "Add Note" to Deposit and Withdrawal screen in savings account so 
> that narration can be added especially name of the person who has deposited 
> which may not be necessarily the account holder. Its good for controls and 
> follow ups.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-243) Constitution Type Required Field

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198928#comment-16198928
 ] 

ASF GitHub Bot commented on FINERACT-243:
-

Github user avikganguly01 commented on the issue:

https://github.com/apache/fineract/pull/315
  
@tonic889 - The right way to avoid this duplication of effort would be to 
assign the issue to yourself and mark it as in progress so that someone else 
does not pick it up. Apologies for the inconvenience cause.


> Constitution Type Required Field
> 
>
> Key: FINERACT-243
> URL: https://issues.apache.org/jira/browse/FINERACT-243
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Dayna Harp
>Assignee: Santosh Math
>Priority: Critical
>  Labels: p2
> Fix For: 1.0.0
>
>
> when creating a client with Legal Form "Entity", Constitution is a required 
> field.  This does not need to be required.  It is an optional field for those 
> financial institutions serving groups that have a constitution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-384) Product Mix - for Saving Accounts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198934#comment-16198934
 ] 

ASF GitHub Bot commented on FINERACT-384:
-

Github user avikganguly01 commented on the issue:

https://github.com/apache/fineract/pull/314
  
@Ippezrobert : Thank you for the contribution. Would you be able to extend 
the existing implementation to remove the duplicate code?


> Product Mix - for Saving Accounts
> -
>
> Key: FINERACT-384
> URL: https://issues.apache.org/jira/browse/FINERACT-384
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Ippez Roberts
>Assignee: Markus Geiss
>  Labels: p2
>
> The Product mix for Loan Accounts needs to be added to cater for Savings 
> Products as some MFI have a policy to restrict a client from opening some 
> savings product together by the same client.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198980#comment-16198980
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

Github user avikganguly01 commented on the issue:

https://github.com/apache/fineract/pull/256
  
@abdulazizali77 : I know this is a bit late but if you can confirm that the 
integration tests are not failing with your code after rebasing, then it will 
be great.


> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-72) Speed up the retrieval of journal entries when "transactionDetails" is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198988#comment-16198988
 ] 

ASF GitHub Bot commented on FINERACT-72:


Github user avikganguly01 commented on the issue:

https://github.com/apache/fineract/pull/208
  
@nazeer1100126 : I don't think it makes sense to add payment detail to JE 
table.



> Speed up the retrieval of journal entries when "transactionDetails" is set to 
> true
> --
>
> Key: FINERACT-72
> URL: https://issues.apache.org/jira/browse/FINERACT-72
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>
> It takes a little over 3 minutes to retrieve about 360 journal entries if the 
> "transactionDetails" parameter is set to true.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-46) Throw an exception if staff to be deactivated is attached to an entity with status enum id not equal to 600

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199066#comment-16199066
 ] 

ASF GitHub Bot commented on FINERACT-46:


Github user avikganguly01 commented on a diff in the pull request:

https://github.com/apache/fineract/pull/170#discussion_r143803020
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/organisation/staff/domain/StaffRepository.java
 ---
@@ -27,10 +27,36 @@
 
 public final static String FIND_BY_OFFICE_QUERY = "select s from Staff 
s where s.id = :id AND s.office.id = :officeId";
 
+public final static String 
IS_ANY_ACTIVE_ENTITY_ASSOCIATED_WITH_STAFF_QUERY = "select " +
+"case when (sum(total) > 0) then true else false end " +
+"from (" +
+"(select count(mg.id) as total " +
+"from m_staff ms " +
+"join m_group mg on mg.staff_id = ms.id " +
+"where ms.id = :staffId " +
+"and mg.status_enum in (100,300)) " +
+"union all " +
+"(select count(ml.id) as total " +
+"from m_loan ml " +
+"join m_staff ms on ml.loan_officer_id = ms.id " +
+"where ms.id = :staffId " +
+"and ml.loan_status_id in (100,200,300,700)) " +
+"union all " +
+"(select count(msa.id) as total " +
+"from m_savings_account msa " +
+"join m_staff ms on msa.field_officer_id = ms.id " +
+"where ms.id = :staffId and " +
+"msa.status_enum in (100,300))) as t1 ";
+
--- End diff --

Client and share accounts not checked.


> Throw an exception if staff to be deactivated is attached to an entity with 
> status enum id not equal to 600
> ---
>
> Key: FINERACT-46
> URL: https://issues.apache.org/jira/browse/FINERACT-46
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>
> Throw an exception if staff to be deactivated is attached to an entity with 
> status enum id not equal to 600.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200147#comment-16200147
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

Github user abdulazizali77 commented on the issue:

https://github.com/apache/fineract/pull/256
  
@avikganguly01 Apologies, would take a bit of effort to reverify this, 
potentially code has diverged a lot in the time when this PR had been submitted


> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200159#comment-16200159
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

Github user abdulazizali77 commented on the issue:

https://github.com/apache/fineract/pull/256
  
@avikganguly01 Looking at the conflicts, it looks like the issue could have 
already been fixed, as i remember it all i did was make the list comparable and 
then sort it, it seems like `develop` already has such code and typed properly 
too ! I think your effort is just to reverify the issue, because it looks 
likely fixed


> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-467) Request for equal installment (with equal principal and equal interest) loan schedule

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226823#comment-16226823
 ] 

ASF GitHub Bot commented on FINERACT-467:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/fineract/pull/420

FINERACT-467 : equal amortization



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-467

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/420.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #420


commit 2e00bff5575053ca3953bd0d23dc4ae680118fc9
Author: nazeer shaik 
Date:   2017-10-31T13:40:14Z

FINERACT-467 : equal amortization




> Request for equal installment (with equal principal and equal interest) loan 
> schedule
> -
>
> Key: FINERACT-467
> URL: https://issues.apache.org/jira/browse/FINERACT-467
> Project: Apache Fineract
>  Issue Type: New Feature
>  Components: Loan
> Environment: Windows
>Reporter: thynn win
>Assignee: Shaik Nazeer Hussain
>Priority: Critical
>  Labels: p2
> Attachments: InterestRateCalculation-Mifos.xlsx, Request for equal 
> installment with equal interest and equal principal.jpg
>
>
> For loan repayment schedule, we would like to have an option for equal 
> installment with equal interest and equal principal option.  Please see the 
> attachment (left grid) for the sample schedule requested.
> Currently if we make equal installment, either principal or interest will be 
> varying. We will arrive at the same interest total interest at the end but 
> our MFIs would like to have flat interest and equal principal at the same 
> time. 
> It's be immensely helpful for their borrowers to remember their balances and 
> interest as they are all the same every time.
> Please refer to the spreadsheet.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-491) Savings annual compound doesn't respect Fiscal month (in April)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241944#comment-16241944
 ] 

ASF GitHub Bot commented on FINERACT-491:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/fineract/pull/423

FINERACT-491 :fiscal month compounding



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract fiscal_month

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/423.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #423


commit 630c942fa386944c8d9d886ade41edb934971bf5
Author: nazeer shaik 
Date:   2017-11-07T12:42:07Z

FINERACT-491 :fiscal month compounding




> Savings annual compound doesn't respect Fiscal month (in April)
> ---
>
> Key: FINERACT-491
> URL: https://issues.apache.org/jira/browse/FINERACT-491
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Savings
>Affects Versions: 1.0.0
> Environment: Windows
>Reporter: thynn win
>Assignee: Shaik Nazeer Hussain
>Priority: Critical
>  Labels: p1
> Attachments: sample.jpg
>
>
> We are observing that Mifos doesn’t respect the fiscal month in calculating 
> interest for savings.
>  
> For instance: we configured the fiscal year to start in April. The saving 
> product is annual interest with 15% and 365 days. Compounding is set to 
> annual with daily balance.
> If we make a saving deposit of $1000 on June 23, 2016 and trying to post on 
> April 1 2017, our expectation is that the interest will be $115.89 
> (1000*282*0.0004109589).  
> There are a total of 282 days with daily interest rate of 0.0004109589 
> (1/365*0.15). 
>  
> In Mifos, we are getting $118.81 instead. What we learned is that there is a 
> compounding happening on Dec 31, 2016 even though it’s not a fiscal year end. 
> From June 23 to Dec 31, there are 192 days and it’s getting a new available 
> balance on Jan 1. It’s compounding from Jan 1, 2017.
> https://demo.openmf.org/#/viewsavingaccount/887 (see screenshot)
>  
>  
> When digging through the code, even though Fiscal month is passed around in 
> the interest calculation, it wasn’t used when determining compounding 
> periods. 
>
> File: PostingPeriod.java
> Method: determineInterestPeriodEndDateFrom
> case ANNUAL:
> periodEndDate = 
> periodStartDate.monthOfYear().withMaximumValue(); //This is causing to 
> default the compound period to Dec as period start year is 2016.
> periodEndDate = periodEndDate.dayOfMonth().withMaximumValue();
>  We are still trying to go through the logic and we’d greatly appreciate your 
> help.
> This will become an issue in Jan 2018 as it's compounding when it's not 
> supposed to be.
>  
> Thank you.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-554) The ledger entry for allocate cash transaction to cashier has USD as hard coded curreny

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248373#comment-16248373
 ] 

ASF GitHub Bot commented on FINERACT-554:
-

GitHub user nikpawar89 opened a pull request:

https://github.com/apache/fineract/pull/425

FINERACT-554

When cash is allocated to cashier, its corresponding GL entry has currency 
as USD, no matter what currency is configured for the organisation. 
On further debugging it was found that the USD was hard coded in the code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nikpawar89/incubator-fineract FINERACT-554

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/425.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #425


commit f1e6716f76bd30b007504373f34ba054e9d0bb5c
Author: nikpawar89 
Date:   2017-11-11T06:57:51Z

FINERACT-554




> The ledger entry for allocate cash transaction to cashier has USD as hard 
> coded curreny
> ---
>
> Key: FINERACT-554
> URL: https://issues.apache.org/jira/browse/FINERACT-554
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Organization
>Reporter: Nikhil Pawar
>Assignee: Markus Geiss
>
> When cash is allocated to cashier, its corresponding GL entry has currency as 
> USD, no matter what currency is configured for the organisation. 
> On further debugging it was found that the USD was hard coded in the code.
> Refer line 443 and 452 of TellerWritePlatformServiceJpaImpl.java:
> https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerWritePlatformServiceJpaImpl.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-556) Email Campaign

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251345#comment-16251345
 ] 

ASF GitHub Bot commented on FINERACT-556:
-

GitHub user Ippezrobert opened a pull request:

https://github.com/apache/fineract/pull/428

Email Campaigns PR

@avikganguly01 , Could you please review this PR as all conflicts are 
resolved and the Jira Ticket is 
https://issues.apache.org/jira/browse/FINERACT-556

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Ippezrobert/fineract develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #428






> Email Campaign
> --
>
> Key: FINERACT-556
> URL: https://issues.apache.org/jira/browse/FINERACT-556
> Project: Apache Fineract
>  Issue Type: New Feature
>Reporter: Ippez Roberts
>Assignee: Markus Geiss
>
> There should be an alternative email campaign type besides sms campaign



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-51) Add the "is_reversed" property of the loan transaction entity to the "LoanTransactionData" object

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254611#comment-16254611
 ] 

ASF GitHub Bot commented on FINERACT-51:


Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/175


> Add the "is_reversed" property of the loan transaction entity to the 
> "LoanTransactionData" object
> -
>
> Key: FINERACT-51
> URL: https://issues.apache.org/jira/browse/FINERACT-51
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>Priority: Minor
>
> Add the "is_reversed" property of the loan transaction entity to the 
> "LoanTransactionData" object.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-46) Throw an exception if staff to be deactivated is attached to an entity with status enum id not equal to 600

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254610#comment-16254610
 ] 

ASF GitHub Bot commented on FINERACT-46:


Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/170


> Throw an exception if staff to be deactivated is attached to an entity with 
> status enum id not equal to 600
> ---
>
> Key: FINERACT-46
> URL: https://issues.apache.org/jira/browse/FINERACT-46
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>
> Throw an exception if staff to be deactivated is attached to an entity with 
> status enum id not equal to 600.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-72) Speed up the retrieval of journal entries when "transactionDetails" is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254612#comment-16254612
 ] 

ASF GitHub Bot commented on FINERACT-72:


Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/208


> Speed up the retrieval of journal entries when "transactionDetails" is set to 
> true
> --
>
> Key: FINERACT-72
> URL: https://issues.apache.org/jira/browse/FINERACT-72
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>
> It takes a little over 3 minutes to retrieve about 360 journal entries if the 
> "transactionDetails" parameter is set to true.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-241) Include "Add Note" to Deposit and Withdrawal screen in savings account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254613#comment-16254613
 ] 

ASF GitHub Bot commented on FINERACT-241:
-

Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/341


> Include "Add Note" to Deposit and Withdrawal screen in savings account
> --
>
> Key: FINERACT-241
> URL: https://issues.apache.org/jira/browse/FINERACT-241
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Dayna Harp
>Assignee: Markus Geiss
>  Labels: beginner, p3
>
> https://mifosforge.jira.com/browse/MIFOSX-2620
> Refer to MIFOSX for images
> Include "Add Note" to Deposit and Withdrawal screen in savings account so 
> that narration can be added especially name of the person who has deposited 
> which may not be necessarily the account holder. Its good for controls and 
> follow ups.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-243) Constitution Type Required Field

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254614#comment-16254614
 ] 

ASF GitHub Bot commented on FINERACT-243:
-

Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/315


> Constitution Type Required Field
> 
>
> Key: FINERACT-243
> URL: https://issues.apache.org/jira/browse/FINERACT-243
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Dayna Harp
>Assignee: Santosh Math
>Priority: Critical
>  Labels: p2
> Fix For: 1.0.0
>
>
> when creating a client with Legal Form "Entity", Constitution is a required 
> field.  This does not need to be required.  It is an optional field for those 
> financial institutions serving groups that have a constitution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-49) Waived charges and zero installment charges amounts not excluded from total charges amount on reschedule loan preview

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254609#comment-16254609
 ] 

ASF GitHub Bot commented on FINERACT-49:


Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/172


> Waived charges and zero installment charges amounts not excluded from total 
> charges amount on reschedule loan preview
> -
>
> Key: FINERACT-49
> URL: https://issues.apache.org/jira/browse/FINERACT-49
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>Priority: Minor
>
> Waived charges and zero installment (installment with zero principle and 
> interest) charges amounts not excluded from total charges amount on 
> reschedule loan preview.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-38) Period Close feature where inc & exp booked to retained earnings account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258982#comment-16258982
 ] 

ASF GitHub Bot commented on FINERACT-38:


GitHub user Ippezrobert opened a pull request:

https://github.com/apache/fineract/pull/429

EOY-Closure: FINERACT-38

@nazeer1100126 Could you please review this and @avikganguly01 or @edcable 
Could you please have the community-app side implementation for this or you 
could identify someone good at the front end implementation to have this done 
so that it could be shipped with the next release.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Ippezrobert/fineract EOY_Closure

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/429.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #429


commit 075d412b7825d2568d67c18a3bc60b0c10d97b60
Author: Ippez Robert 
Date:   2017-11-20T09:06:02Z

FINERACT-38




> Period Close feature where inc & exp booked to retained earnings account
> 
>
> Key: FINERACT-38
> URL: https://issues.apache.org/jira/browse/FINERACT-38
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Accounting
>Reporter: Dayna Harp
>Assignee: Markus Geiss
>
> https://mifosforge.jira.com/browse/MIFOSX-2337 
> Relates to:  https://mifosforge.jira.com/browse/MIFOSX-2288 (see attachments 
> and narrative)
> financial year end to be user definable and to have the full effect of 
> closing off the year with initialization of the profit and loss account. Year 
> end process should be run as/when the institution is ready to close their 
> books and may not necessarily happen exactly 
> Musoni is implementing and sharing the following:
> Ability to close a financial year from an accounting perspective (booking off 
> income and expense accounts against your retained earnings equity account).  
> The high-level spec of this feature is:
> * When a user performs a financial close period (existing feature) we have 
> added various parameters to the call that allow you to also book off the 
> income and expenses generated in that period.
> * Once you submit this request the various balances will be pulled out and 
> the difference between all expenses and income accounts will be booked off 
> against a (specified) equity account.
> * The journal entry that is generated to perform this booking will be stored 
> with the close period so that it can be reversed again if a close period is 
> reopened.
> * There is a preview/template API endpoint that allows you to preview the 
> booking that is going to be performed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-467) Request for equal installment (with equal principal and equal interest) loan schedule

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259061#comment-16259061
 ] 

ASF GitHub Bot commented on FINERACT-467:
-

Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/420


> Request for equal installment (with equal principal and equal interest) loan 
> schedule
> -
>
> Key: FINERACT-467
> URL: https://issues.apache.org/jira/browse/FINERACT-467
> Project: Apache Fineract
>  Issue Type: New Feature
>  Components: Loan
> Environment: Windows
>Reporter: thynn win
>Assignee: Shaik Nazeer Hussain
>Priority: Critical
>  Labels: p2
> Attachments: InterestRateCalculation-Mifos.xlsx, Request for equal 
> installment with equal interest and equal principal.jpg
>
>
> For loan repayment schedule, we would like to have an option for equal 
> installment with equal interest and equal principal option.  Please see the 
> attachment (left grid) for the sample schedule requested.
> Currently if we make equal installment, either principal or interest will be 
> varying. We will arrive at the same interest total interest at the end but 
> our MFIs would like to have flat interest and equal principal at the same 
> time. 
> It's be immensely helpful for their borrowers to remember their balances and 
> interest as they are all the same every time.
> Please refer to the spreadsheet.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-491) Savings annual compound doesn't respect Fiscal month (in April)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259065#comment-16259065
 ] 

ASF GitHub Bot commented on FINERACT-491:
-

Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/423


> Savings annual compound doesn't respect Fiscal month (in April)
> ---
>
> Key: FINERACT-491
> URL: https://issues.apache.org/jira/browse/FINERACT-491
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Savings
>Affects Versions: 1.0.0
> Environment: Windows
>Reporter: thynn win
>Assignee: Shaik Nazeer Hussain
>Priority: Critical
>  Labels: p1
> Attachments: sample.jpg
>
>
> We are observing that Mifos doesn’t respect the fiscal month in calculating 
> interest for savings.
>  
> For instance: we configured the fiscal year to start in April. The saving 
> product is annual interest with 15% and 365 days. Compounding is set to 
> annual with daily balance.
> If we make a saving deposit of $1000 on June 23, 2016 and trying to post on 
> April 1 2017, our expectation is that the interest will be $115.89 
> (1000*282*0.0004109589).  
> There are a total of 282 days with daily interest rate of 0.0004109589 
> (1/365*0.15). 
>  
> In Mifos, we are getting $118.81 instead. What we learned is that there is a 
> compounding happening on Dec 31, 2016 even though it’s not a fiscal year end. 
> From June 23 to Dec 31, there are 192 days and it’s getting a new available 
> balance on Jan 1. It’s compounding from Jan 1, 2017.
> https://demo.openmf.org/#/viewsavingaccount/887 (see screenshot)
>  
>  
> When digging through the code, even though Fiscal month is passed around in 
> the interest calculation, it wasn’t used when determining compounding 
> periods. 
>
> File: PostingPeriod.java
> Method: determineInterestPeriodEndDateFrom
> case ANNUAL:
> periodEndDate = 
> periodStartDate.monthOfYear().withMaximumValue(); //This is causing to 
> default the compound period to Dec as period start year is 2016.
> periodEndDate = periodEndDate.dayOfMonth().withMaximumValue();
>  We are still trying to go through the logic and we’d greatly appreciate your 
> help.
> This will become an issue in Jan 2018 as it's compounding when it's not 
> supposed to be.
>  
> Thank you.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-554) The ledger entry for allocate cash transaction to cashier has USD as hard coded currency

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259073#comment-16259073
 ] 

ASF GitHub Bot commented on FINERACT-554:
-

Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/425


> The ledger entry for allocate cash transaction to cashier has USD as hard 
> coded currency
> 
>
> Key: FINERACT-554
> URL: https://issues.apache.org/jira/browse/FINERACT-554
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Organization
>Reporter: Nikhil Pawar
>Assignee: Markus Geiss
>
> When cash is allocated to cashier, its corresponding GL entry has currency as 
> USD, no matter what currency is configured for the organisation. 
> On further debugging it was found that the USD was hard coded in the code.
> Refer line 443 and 452 of TellerWritePlatformServiceJpaImpl.java:
> https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerWritePlatformServiceJpaImpl.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-556) Email Campaign

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259246#comment-16259246
 ] 

ASF GitHub Bot commented on FINERACT-556:
-

Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/428


> Email Campaign
> --
>
> Key: FINERACT-556
> URL: https://issues.apache.org/jira/browse/FINERACT-556
> Project: Apache Fineract
>  Issue Type: New Feature
>Reporter: Ippez Roberts
>Assignee: Markus Geiss
>
> There should be an alternative email campaign type besides sms campaign



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-38) Period Close feature where inc & exp booked to retained earnings account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262604#comment-16262604
 ] 

ASF GitHub Bot commented on FINERACT-38:


Github user Ippezrobert closed the pull request at:

https://github.com/apache/fineract/pull/429


> Period Close feature where inc & exp booked to retained earnings account
> 
>
> Key: FINERACT-38
> URL: https://issues.apache.org/jira/browse/FINERACT-38
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Accounting
>Reporter: Dayna Harp
>Assignee: Markus Geiss
>
> https://mifosforge.jira.com/browse/MIFOSX-2337 
> Relates to:  https://mifosforge.jira.com/browse/MIFOSX-2288 (see attachments 
> and narrative)
> financial year end to be user definable and to have the full effect of 
> closing off the year with initialization of the profit and loss account. Year 
> end process should be run as/when the institution is ready to close their 
> books and may not necessarily happen exactly 
> Musoni is implementing and sharing the following:
> Ability to close a financial year from an accounting perspective (booking off 
> income and expense accounts against your retained earnings equity account).  
> The high-level spec of this feature is:
> * When a user performs a financial close period (existing feature) we have 
> added various parameters to the call that allow you to also book off the 
> income and expenses generated in that period.
> * Once you submit this request the various balances will be pulled out and 
> the difference between all expenses and income accounts will be booked off 
> against a (specified) equity account.
> * The journal entry that is generated to perform this booking will be stored 
> with the close period so that it can be reversed again if a close period is 
> reopened.
> * There is a preview/template API endpoint that allows you to preview the 
> booking that is going to be performed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-38) Period Close feature where inc & exp booked to retained earnings account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262612#comment-16262612
 ] 

ASF GitHub Bot commented on FINERACT-38:


GitHub user Ippezrobert reopened a pull request:

https://github.com/apache/fineract/pull/429

EOY-Closure: FINERACT-38

@nazeer1100126 Could you please review this and @avikganguly01 or @edcable 
Could you please have the community-app side implementation for this or you 
could identify someone good at the front end implementation to have this done 
so that it could be shipped with the next release.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Ippezrobert/fineract EOY_Closure

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/429.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #429






> Period Close feature where inc & exp booked to retained earnings account
> 
>
> Key: FINERACT-38
> URL: https://issues.apache.org/jira/browse/FINERACT-38
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Accounting
>Reporter: Dayna Harp
>Assignee: Markus Geiss
>
> https://mifosforge.jira.com/browse/MIFOSX-2337 
> Relates to:  https://mifosforge.jira.com/browse/MIFOSX-2288 (see attachments 
> and narrative)
> financial year end to be user definable and to have the full effect of 
> closing off the year with initialization of the profit and loss account. Year 
> end process should be run as/when the institution is ready to close their 
> books and may not necessarily happen exactly 
> Musoni is implementing and sharing the following:
> Ability to close a financial year from an accounting perspective (booking off 
> income and expense accounts against your retained earnings equity account).  
> The high-level spec of this feature is:
> * When a user performs a financial close period (existing feature) we have 
> added various parameters to the call that allow you to also book off the 
> income and expenses generated in that period.
> * Once you submit this request the various balances will be pulled out and 
> the difference between all expenses and income accounts will be booked off 
> against a (specified) equity account.
> * The journal entry that is generated to perform this booking will be stored 
> with the close period so that it can be reversed again if a close period is 
> reopened.
> * There is a preview/template API endpoint that allows you to preview the 
> booking that is going to be performed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-38) Period Close feature where inc & exp booked to retained earnings account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262614#comment-16262614
 ] 

ASF GitHub Bot commented on FINERACT-38:


Github user Ippezrobert commented on the issue:

https://github.com/apache/fineract/pull/429
  
I accidentally deleted my branch and didn't know it affects PR too but PR 
is re-opened so review can go on.


> Period Close feature where inc & exp booked to retained earnings account
> 
>
> Key: FINERACT-38
> URL: https://issues.apache.org/jira/browse/FINERACT-38
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Accounting
>Reporter: Dayna Harp
>Assignee: Markus Geiss
>
> https://mifosforge.jira.com/browse/MIFOSX-2337 
> Relates to:  https://mifosforge.jira.com/browse/MIFOSX-2288 (see attachments 
> and narrative)
> financial year end to be user definable and to have the full effect of 
> closing off the year with initialization of the profit and loss account. Year 
> end process should be run as/when the institution is ready to close their 
> books and may not necessarily happen exactly 
> Musoni is implementing and sharing the following:
> Ability to close a financial year from an accounting perspective (booking off 
> income and expense accounts against your retained earnings equity account).  
> The high-level spec of this feature is:
> * When a user performs a financial close period (existing feature) we have 
> added various parameters to the call that allow you to also book off the 
> income and expenses generated in that period.
> * Once you submit this request the various balances will be pulled out and 
> the difference between all expenses and income accounts will be booked off 
> against a (specified) equity account.
> * The journal entry that is generated to perform this booking will be stored 
> with the close period so that it can be reversed again if a close period is 
> reopened.
> * There is a preview/template API endpoint that allows you to preview the 
> booking that is going to be performed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-38) Period Close feature where inc & exp booked to retained earnings account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288952#comment-16288952
 ] 

ASF GitHub Bot commented on FINERACT-38:


Github user avikganguly01 commented on the issue:

https://github.com/apache/fineract/pull/429
  
@Ippezrobert : Can you fix the conflict and share the link regarding which 
ticket in JIRA this PR addresses?


> Period Close feature where inc & exp booked to retained earnings account
> 
>
> Key: FINERACT-38
> URL: https://issues.apache.org/jira/browse/FINERACT-38
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Accounting
>Reporter: Dayna Harp
>Assignee: Markus Geiss
>
> https://mifosforge.jira.com/browse/MIFOSX-2337 
> Relates to:  https://mifosforge.jira.com/browse/MIFOSX-2288 (see attachments 
> and narrative)
> financial year end to be user definable and to have the full effect of 
> closing off the year with initialization of the profit and loss account. Year 
> end process should be run as/when the institution is ready to close their 
> books and may not necessarily happen exactly 
> Musoni is implementing and sharing the following:
> Ability to close a financial year from an accounting perspective (booking off 
> income and expense accounts against your retained earnings equity account).  
> The high-level spec of this feature is:
> * When a user performs a financial close period (existing feature) we have 
> added various parameters to the call that allow you to also book off the 
> income and expenses generated in that period.
> * Once you submit this request the various balances will be pulled out and 
> the difference between all expenses and income accounts will be booked off 
> against a (specified) equity account.
> * The journal entry that is generated to perform this booking will be stored 
> with the close period so that it can be reversed again if a close period is 
> reopened.
> * There is a preview/template API endpoint that allows you to preview the 
> booking that is going to be performed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-186) optimising the Post Interest For Savings batch job using pagination

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288956#comment-16288956
 ] 

ASF GitHub Bot commented on FINERACT-186:
-

Github user avikganguly01 commented on the issue:

https://github.com/apache/fineract/pull/152
  
@nazeer1100126 : I am fine with this change. Should I go ahead, resolve the 
conflict and merge it?


> optimising the Post Interest For Savings batch job using pagination
> ---
>
> Key: FINERACT-186
> URL: https://issues.apache.org/jira/browse/FINERACT-186
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Savings
>Reporter: venkat Ganesh
>Assignee: Markus Geiss
>Priority: Minor
>  Labels: p1
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-38) Period Close feature where inc & exp booked to retained earnings account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288986#comment-16288986
 ] 

ASF GitHub Bot commented on FINERACT-38:


Github user Ippezrobert commented on the issue:

https://github.com/apache/fineract/pull/429
  
@avikganguly01 , Conflict Resolved so you can review and the ticket is 
https://issues.apache.org/jira/browse/FINERACT-38


> Period Close feature where inc & exp booked to retained earnings account
> 
>
> Key: FINERACT-38
> URL: https://issues.apache.org/jira/browse/FINERACT-38
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Accounting
>Reporter: Dayna Harp
>Assignee: Markus Geiss
>
> https://mifosforge.jira.com/browse/MIFOSX-2337 
> Relates to:  https://mifosforge.jira.com/browse/MIFOSX-2288 (see attachments 
> and narrative)
> financial year end to be user definable and to have the full effect of 
> closing off the year with initialization of the profit and loss account. Year 
> end process should be run as/when the institution is ready to close their 
> books and may not necessarily happen exactly 
> Musoni is implementing and sharing the following:
> Ability to close a financial year from an accounting perspective (booking off 
> income and expense accounts against your retained earnings equity account).  
> The high-level spec of this feature is:
> * When a user performs a financial close period (existing feature) we have 
> added various parameters to the call that allow you to also book off the 
> income and expenses generated in that period.
> * Once you submit this request the various balances will be pulled out and 
> the difference between all expenses and income accounts will be booked off 
> against a (specified) equity account.
> * The journal entry that is generated to perform this booking will be stored 
> with the close period so that it can be reversed again if a close period is 
> reopened.
> * There is a preview/template API endpoint that allows you to preview the 
> booking that is going to be performed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289024#comment-16289024
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/256


> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-241) Include "Add Note" to Deposit and Withdrawal screen in savings account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289048#comment-16289048
 ] 

ASF GitHub Bot commented on FINERACT-241:
-

Github user nazeer1100126 commented on the issue:

https://github.com/apache/fineract/pull/380
  
@myrle-krantz please close this PR. I have already implemented this feature 
and it is merged recently


> Include "Add Note" to Deposit and Withdrawal screen in savings account
> --
>
> Key: FINERACT-241
> URL: https://issues.apache.org/jira/browse/FINERACT-241
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Dayna Harp
>Assignee: Santosh Math
>  Labels: beginner, p3
> Fix For: 1.1.0
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2620
> Refer to MIFOSX for images
> Include "Add Note" to Deposit and Withdrawal screen in savings account so 
> that narration can be added especially name of the person who has deposited 
> which may not be necessarily the account holder. Its good for controls and 
> follow ups.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-241) Include "Add Note" to Deposit and Withdrawal screen in savings account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289055#comment-16289055
 ] 

ASF GitHub Bot commented on FINERACT-241:
-

Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/380


> Include "Add Note" to Deposit and Withdrawal screen in savings account
> --
>
> Key: FINERACT-241
> URL: https://issues.apache.org/jira/browse/FINERACT-241
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Dayna Harp
>Assignee: Santosh Math
>  Labels: beginner, p3
> Fix For: 1.1.0
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2620
> Refer to MIFOSX for images
> Include "Add Note" to Deposit and Withdrawal screen in savings account so 
> that narration can be added especially name of the person who has deposited 
> which may not be necessarily the account holder. Its good for controls and 
> follow ups.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-241) Include "Add Note" to Deposit and Withdrawal screen in savings account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289057#comment-16289057
 ] 

ASF GitHub Bot commented on FINERACT-241:
-

Github user myrle-krantz commented on the issue:

https://github.com/apache/fineract/pull/380
  
Have closed.  For future reference, you can close a PR with an empty commit 
message as explained here:


https://cwiki.apache.org/confluence/display/FINERACT/Merge+a+pull+request+to+a+mirrored+Apache+repo


> Include "Add Note" to Deposit and Withdrawal screen in savings account
> --
>
> Key: FINERACT-241
> URL: https://issues.apache.org/jira/browse/FINERACT-241
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Dayna Harp
>Assignee: Santosh Math
>  Labels: beginner, p3
> Fix For: 1.1.0
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2620
> Refer to MIFOSX for images
> Include "Add Note" to Deposit and Withdrawal screen in savings account so 
> that narration can be added especially name of the person who has deposited 
> which may not be necessarily the account holder. Its good for controls and 
> follow ups.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-241) Include "Add Note" to Deposit and Withdrawal screen in savings account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289061#comment-16289061
 ] 

ASF GitHub Bot commented on FINERACT-241:
-

Github user nazeer1100126 commented on the issue:

https://github.com/apache/fineract/pull/380
  
@myrle-krantz Thank you :-)


> Include "Add Note" to Deposit and Withdrawal screen in savings account
> --
>
> Key: FINERACT-241
> URL: https://issues.apache.org/jira/browse/FINERACT-241
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Dayna Harp
>Assignee: Santosh Math
>  Labels: beginner, p3
> Fix For: 1.1.0
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2620
> Refer to MIFOSX for images
> Include "Add Note" to Deposit and Withdrawal screen in savings account so 
> that narration can be added especially name of the person who has deposited 
> which may not be necessarily the account holder. Its good for controls and 
> follow ups.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-593) Issue in migration file V145 relate to default value of DATE type field

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301245#comment-16301245
 ] 

ASF GitHub Bot commented on FINERACT-593:
-

GitHub user heritechie opened a pull request:

https://github.com/apache/fineract/pull/433

[FINERACT-593] Fix migration file V145 relate to default value of DATE type 
field

Issue is occuring in mysql 5.7

As per latest MYSQL 5.7 documentation
If strict mode is enabled, '-00-00' is not permitted and produce an 
error

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/heritechie/incubator-fineract bugfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/433.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #433


commit df8ef2e8b6c50846e58b3fc01cffe6d27a987cc1
Author: pramod 
Date:   2016-02-08T12:47:46Z

added Pentaho reports

commit 85a80b5e2e467f0d3cb663604efebd21f034c64d
Author: Adi Narayana Raju 
Date:   2016-02-10T07:47:11Z

Pentaho reports changes to work with Drizzle driver

commit e97719d8f92f9aeef644e57f4cf6a64c9ed25e3b
Author: unknown 
Date:   2016-02-17T05:46:30Z

Merge branch 'jdbcdriver' into openmf_develop

Conflicts:
fineract-provider/src/main/resources/application.properties

commit 4ed7692a00909c5b5cf8dc6838659aebe2b7eb42
Author: unknown 
Date:   2016-02-17T07:02:19Z

no message

commit 7e8c166c02b4b2c5e1cb7e0dc68d8b87b4fa7067
Author: unknown 
Date:   2016-02-22T12:24:29Z

Merge branch 'noticeupdate' into openmf_develop

commit fc96989bc20f9ee4745e97bc07fb2daac289c549
Author: Nazeer Hussain Shaik 
Date:   2016-02-24T06:37:53Z

Merge branch 'develop' into openmf_develop

commit f4e9467683d127b3246328ae7bae465dec0dc16b
Author: Adi Narayana Raju 
Date:   2016-03-02T08:57:14Z

Correction in interest recalculation scheduler job to avoid infinite loop

commit f52336427679df170027aabcf7bc4f15f0f7e37b
Author: Nazeer Hussain Shaik 
Date:   2016-03-09T13:24:17Z

Merge branch 'latest' into develop_openmf

commit c4ce6b0727ebc4842eb86cd20c45d58905587b8a
Author: Nazeer Hussain Shaik 
Date:   2016-03-09T16:25:02Z

Adding 16.03.01.RELEASE

commit 1a1b3087fc13d8b964f758643e3814dcd9e29b94
Author: Nazeer Hussain Shaik 
Date:   2016-03-14T06:42:28Z

Merge branch 'develop' into develop_openmf

commit 58c5c705fcbef25ca62a3b803009248eb6e70d4d
Author: Adi Narayana Raju 
Date:   2016-03-16T07:36:34Z

Merge branch 'ssloanapplication' into openmfdevelop

commit c1cdcb9c5f2080c1e8d28c3f5d69b59b48eac12b
Author: Adi Narayana Raju 
Date:   2016-03-16T07:47:40Z

Updating release notes for 16.03.02.RELEASE

commit ee4b7908cf5be1322f1417ac814cab0fc3798f27
Author: Adi Narayana Raju 
Date:   2016-03-23T09:19:45Z

Merge commit 'c1af84dd4b951c8fed3b365ae906c06d9c0de4e7' into openmfdevelop

commit e5c03c2547bf8655a669bcc0d63b121e5687fa3b
Author: Adi Narayana Raju 
Date:   2016-03-23T09:50:33Z

Updating release notes for 16.03.03.RELEASE

commit 25f51dff262e2c42d8d643b1194e0e9a0bcda9d3
Author: Adi Narayana Raju 
Date:   2016-04-13T14:37:40Z

Merge branch 'develop' into openmfdevelop

commit e965c7fe6b6a174010d3cd65ff97cf048dc84f88
Author: Adi Narayana Raju 
Date:   2016-04-13T14:54:12Z

Updating release notes for 16.04.01.RELEASE

commit fe46da3023ea7578859a4c4b2fa29df4fd4c1151
Author: Adi Narayana Raju 
Date:   2016-04-14T08:33:56Z

Merge branch 'develop' into openmfdevelop

commit 633737020d63fcfdb5ef72adad1b54adb7a7e032
Author: Nazeer Hussain Shaik 
Date:   2016-04-20T07:15:56Z

Merge branch 'sharesFixes' into openmf_develop

commit 1ec3ec281c306fe016a9bc65f24319fcb7003797
Author: Adi Narayana Raju 
Date:   2016-04-21T15:22:47Z

Merge branch 'develop' into openmfdevelop

commit 348fffdce2b83e67eb6afe2e81acdb988e94031f
Author: Adi Narayana Raju 
Date:   2016-05-03T11:44:36Z

Adding MIFOS-INSTALL.md

commit eaca8e2cff0587a6936abe48929678e44b17f5c0
Author: Adi Narayana Raju 
Date:   2016-05-04T14:28:38Z

Merge branch 'develop' into openmfdevelop

commit 69d1e62736f0bce3c2bbc7132625b3c731156286
Author: Adi Narayana Raju 
Date:   2016-05-04T15:14:44Z

Updating release notes for 16.05.01.RELEASE

commit 27b4f0881f269516d25315d8b1ffa27132d02252
Author: Adi Narayana Raju 
Date:   2016-05-04T16:22:48Z

Merge remote-tracking branch 'upstream/develop' into openmfdevelop

commit 82b9690f00f9f9fe549146425eff6186b9ffbeea
Author: Adi Narayana Raju 
Date:   2016-05-06T11:52:10Z

Merge branch 'develop' into openmfdevelop

commit 35039f7cdb01b019dc57ac3671aaf8c0fb317328
Author: Adi Narayana Raju 
Date:   2016-05-10T12:42:28Z

Merge branch 'develop' into openmfdevelop

commit bca23d1bea6a18826d9eca87710dc7abfa227315
Author: A

[jira] [Commented] (FINERACT-593) Issue in migration file V145 relate to default value of DATE type field

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301362#comment-16301362
 ] 

ASF GitHub Bot commented on FINERACT-593:
-

Github user heritechie closed the pull request at:

https://github.com/apache/fineract/pull/433


> Issue in migration file V145 relate to default value of DATE type field
> ---
>
> Key: FINERACT-593
> URL: https://issues.apache.org/jira/browse/FINERACT-593
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Migration Scripts
>Reporter: Heriyanto
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: beginner, easyfix, patch
>
> Issue is occuring in mysql 5.7, causing migrate process error
> As per latest MYSQL 5.7 
> [documentation|https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sql-mode-strict]
> If strict mode is enabled, '-00-00' is not permitted and produce an error



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-593) Issue in migration file V145 relate to default value of DATE type field

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301420#comment-16301420
 ] 

ASF GitHub Bot commented on FINERACT-593:
-

GitHub user heritechie opened a pull request:

https://github.com/apache/fineract/pull/434

[FINERACT-593] Fix Issue in migration file V145 relate to default value of 
DATE type field

Issue is occuring in mysql 5.7, causing migrate process error

As per latest MYSQL 5.7 
[documentation](https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sql-mode-strict)
If strict mode is enabled, '-00-00' is not permitted and produce an 
error



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/heritechie/incubator-fineract bugfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/434.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #434


commit df8ef2e8b6c50846e58b3fc01cffe6d27a987cc1
Author: pramod 
Date:   2016-02-08T12:47:46Z

added Pentaho reports

commit 85a80b5e2e467f0d3cb663604efebd21f034c64d
Author: Adi Narayana Raju 
Date:   2016-02-10T07:47:11Z

Pentaho reports changes to work with Drizzle driver

commit e97719d8f92f9aeef644e57f4cf6a64c9ed25e3b
Author: unknown 
Date:   2016-02-17T05:46:30Z

Merge branch 'jdbcdriver' into openmf_develop

Conflicts:
fineract-provider/src/main/resources/application.properties

commit 4ed7692a00909c5b5cf8dc6838659aebe2b7eb42
Author: unknown 
Date:   2016-02-17T07:02:19Z

no message

commit 7e8c166c02b4b2c5e1cb7e0dc68d8b87b4fa7067
Author: unknown 
Date:   2016-02-22T12:24:29Z

Merge branch 'noticeupdate' into openmf_develop

commit fc96989bc20f9ee4745e97bc07fb2daac289c549
Author: Nazeer Hussain Shaik 
Date:   2016-02-24T06:37:53Z

Merge branch 'develop' into openmf_develop

commit f4e9467683d127b3246328ae7bae465dec0dc16b
Author: Adi Narayana Raju 
Date:   2016-03-02T08:57:14Z

Correction in interest recalculation scheduler job to avoid infinite loop

commit f52336427679df170027aabcf7bc4f15f0f7e37b
Author: Nazeer Hussain Shaik 
Date:   2016-03-09T13:24:17Z

Merge branch 'latest' into develop_openmf

commit c4ce6b0727ebc4842eb86cd20c45d58905587b8a
Author: Nazeer Hussain Shaik 
Date:   2016-03-09T16:25:02Z

Adding 16.03.01.RELEASE

commit 1a1b3087fc13d8b964f758643e3814dcd9e29b94
Author: Nazeer Hussain Shaik 
Date:   2016-03-14T06:42:28Z

Merge branch 'develop' into develop_openmf

commit 58c5c705fcbef25ca62a3b803009248eb6e70d4d
Author: Adi Narayana Raju 
Date:   2016-03-16T07:36:34Z

Merge branch 'ssloanapplication' into openmfdevelop

commit c1cdcb9c5f2080c1e8d28c3f5d69b59b48eac12b
Author: Adi Narayana Raju 
Date:   2016-03-16T07:47:40Z

Updating release notes for 16.03.02.RELEASE

commit ee4b7908cf5be1322f1417ac814cab0fc3798f27
Author: Adi Narayana Raju 
Date:   2016-03-23T09:19:45Z

Merge commit 'c1af84dd4b951c8fed3b365ae906c06d9c0de4e7' into openmfdevelop

commit e5c03c2547bf8655a669bcc0d63b121e5687fa3b
Author: Adi Narayana Raju 
Date:   2016-03-23T09:50:33Z

Updating release notes for 16.03.03.RELEASE

commit 25f51dff262e2c42d8d643b1194e0e9a0bcda9d3
Author: Adi Narayana Raju 
Date:   2016-04-13T14:37:40Z

Merge branch 'develop' into openmfdevelop

commit e965c7fe6b6a174010d3cd65ff97cf048dc84f88
Author: Adi Narayana Raju 
Date:   2016-04-13T14:54:12Z

Updating release notes for 16.04.01.RELEASE

commit fe46da3023ea7578859a4c4b2fa29df4fd4c1151
Author: Adi Narayana Raju 
Date:   2016-04-14T08:33:56Z

Merge branch 'develop' into openmfdevelop

commit 633737020d63fcfdb5ef72adad1b54adb7a7e032
Author: Nazeer Hussain Shaik 
Date:   2016-04-20T07:15:56Z

Merge branch 'sharesFixes' into openmf_develop

commit 1ec3ec281c306fe016a9bc65f24319fcb7003797
Author: Adi Narayana Raju 
Date:   2016-04-21T15:22:47Z

Merge branch 'develop' into openmfdevelop

commit 348fffdce2b83e67eb6afe2e81acdb988e94031f
Author: Adi Narayana Raju 
Date:   2016-05-03T11:44:36Z

Adding MIFOS-INSTALL.md

commit eaca8e2cff0587a6936abe48929678e44b17f5c0
Author: Adi Narayana Raju 
Date:   2016-05-04T14:28:38Z

Merge branch 'develop' into openmfdevelop

commit 69d1e62736f0bce3c2bbc7132625b3c731156286
Author: Adi Narayana Raju 
Date:   2016-05-04T15:14:44Z

Updating release notes for 16.05.01.RELEASE

commit 27b4f0881f269516d25315d8b1ffa27132d02252
Author: Adi Narayana Raju 
Date:   2016-05-04T16:22:48Z

Merge remote-tracking branch 'upstream/develop' into openmfdevelop

commit 82b9690f00f9f9fe549146425eff6186b9ffbeea
Author: Adi Narayana Raju 
Date:   2016-05-06T11:52:10Z

Merge branch 'develop' into openmfdevelop

commit 35039f7cdb01b019dc57ac3671aaf8c0fb317328
Author: Adi Narayana Raju 
Date:   2016-0

[jira] [Commented] (FINERACT-593) Issue in migration file V145 relate to default value of DATE type field

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301440#comment-16301440
 ] 

ASF GitHub Bot commented on FINERACT-593:
-

Github user heritechie closed the pull request at:

https://github.com/apache/fineract/pull/434


> Issue in migration file V145 relate to default value of DATE type field
> ---
>
> Key: FINERACT-593
> URL: https://issues.apache.org/jira/browse/FINERACT-593
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Migration Scripts
>Reporter: Heriyanto
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: beginner, easyfix, patch
>
> Issue is occuring in mysql 5.7, causing migrate process error
> As per latest MYSQL 5.7 
> [documentation|https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sql-mode-strict]
> If strict mode is enabled, '-00-00' is not permitted and produce an error



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-593) Issue in migration file V145 relate to default value of DATE type field

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301457#comment-16301457
 ] 

ASF GitHub Bot commented on FINERACT-593:
-

GitHub user heritechie opened a pull request:

https://github.com/apache/fineract/pull/435

[FINERACT-593] Fix migration file V145 relate to DATE field by change 
default value

Issue is occuring in mysql 5.7, causing migrate process error

As per latest MYSQL 5.7 
[documentation](https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sql-mode-strict)
If strict mode is enabled, '-00-00' is not permitted and produce an 
error

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/heritechie/incubator-fineract bugfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #435


commit 18b31ffd7091ba2b774d734c8856b4949ddc4d39
Author: Heriyanto 
Date:   2017-12-22T13:36:31Z

Fix migration file V145 relate to DATE field by change default value




> Issue in migration file V145 relate to default value of DATE type field
> ---
>
> Key: FINERACT-593
> URL: https://issues.apache.org/jira/browse/FINERACT-593
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Migration Scripts
>Reporter: Heriyanto
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: beginner, easyfix, patch
>
> Issue is occuring in mysql 5.7, causing migrate process error
> As per latest MYSQL 5.7 
> [documentation|https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sql-mode-strict]
> If strict mode is enabled, '-00-00' is not permitted and produce an error



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-416) Interest to be calculated for the whole loan term given

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306258#comment-16306258
 ] 

ASF GitHub Bot commented on FINERACT-416:
-

GitHub user MexinaD opened a pull request:

https://github.com/apache/fineract/pull/436

FINERACT-416 Interest of the whole term



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MexinaD/incubator-fineract FINERACT-416

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #436


commit 5235b7ebc9a7d0a6df9b7e6bd485720af041a575
Author: Mexina M Daniel 
Date:   2017-12-29T12:37:19Z

FINERACT-416 Interest of the whole term




> Interest to be calculated for the whole loan term given
> ---
>
> Key: FINERACT-416
> URL: https://issues.apache.org/jira/browse/FINERACT-416
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Mexina Daniel
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: gsoc2017, p1
>
> As for some of the MFI practise here in our country, they specify the 
> interest for the whole loan term given, i.e their loan product have the 
> interest for the whole loan term regardless of the frequency of repayment ()
> To accomplish this in mifos, a user has to do calculation of finding an 
> interest of a month/year with respect of the loan term of that specific 
> client. This is a very tiresome work as for a day a user can have apply many 
> loans and the task of calculation make the work even harder.
> I was suggesting improvement in the loan product, to be able to allow the 
> interest rate of the whole loan term.
> Example:
> Loan product -  Development Loan
> Amount -  Min: 100,000, Max:1,000,000
> Interest - 20%
> Loan term - From 3months to 6months
> -- This means the interest given is for any loan term the client will want to 
> take the loan.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-431) Should not allow more than expected loan term based on 'number of repayments' and 'Repaid every' values.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309339#comment-16309339
 ] 

ASF GitHub Bot commented on FINERACT-431:
-

GitHub user MexinaD opened a pull request:

https://github.com/apache/fineract/pull/437

FINERACT-431 - Loan term greater than expected



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MexinaD/incubator-fineract FINERACT-431

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/437.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #437


commit dc430723620097f4c69af2adeff6a6777e5a7361
Author: Mexina M Daniel 
Date:   2018-01-03T09:00:50Z

FINERACT-431 - Loan term greater than expected




> Should not allow more than expected  loan term based on 'number of 
> repayments' and 'Repaid every' values.
> -
>
> Key: FINERACT-431
> URL: https://issues.apache.org/jira/browse/FINERACT-431
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Mexina Daniel
>Assignee: Markus Geiss
>Priority: Minor
>  Labels: p2
>
> In loan application, the frequency of the loan term has to be the same with 
> the frequency of repaid every (days/weeks/months/years), by this : loan term 
> = number of repayment x repaid every.
> e.g 
> 1. Create a loan product and fill the necessary requirements (put default 
> number of repayment = 6, repaid every = 1 month)
> 2. Create a loan account to an active client and fill all necessary 
> requirement ( put loan term = 8 months), leave the number of repayment to 6.
> The system is allowing the loan term to be greater than (number of repayments 
> x repaid every) and provide the repayment schedule based on 'number of 
> repayments' and 'repaid every' values
> It should deny the submission and through an error like when you provide loan 
> term less than (number of repayments x repaid every)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-416) Interest to be calculated for the whole loan term given

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316158#comment-16316158
 ] 

ASF GitHub Bot commented on FINERACT-416:
-

Github user MexinaD commented on the issue:

https://github.com/apache/fineract/pull/436
  
@nazeer1100126  Can you check this


> Interest to be calculated for the whole loan term given
> ---
>
> Key: FINERACT-416
> URL: https://issues.apache.org/jira/browse/FINERACT-416
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Mexina Daniel
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: gsoc2017, p1
>
> As for some of the MFI practise here in our country, they specify the 
> interest for the whole loan term given, i.e their loan product have the 
> interest for the whole loan term regardless of the frequency of repayment ()
> To accomplish this in mifos, a user has to do calculation of finding an 
> interest of a month/year with respect of the loan term of that specific 
> client. This is a very tiresome work as for a day a user can have apply many 
> loans and the task of calculation make the work even harder.
> I was suggesting improvement in the loan product, to be able to allow the 
> interest rate of the whole loan term.
> Example:
> Loan product -  Development Loan
> Amount -  Min: 100,000, Max:1,000,000
> Interest - 20%
> Loan term - From 3months to 6months
> -- This means the interest given is for any loan term the client will want to 
> take the loan.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-416) Interest to be calculated for the whole loan term given

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320098#comment-16320098
 ] 

ASF GitHub Bot commented on FINERACT-416:
-

Github user avikganguly01 commented on a diff in the pull request:

https://github.com/apache/fineract/pull/436#discussion_r160647416
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AprCalculator.java
 ---
@@ -41,10 +41,29 @@ public BigDecimal calculateFrom(final 
PeriodFrequencyType interestPeriodFrequenc
 case YEARS:
 defaultAnnualNominalInterestRate = 
interestRatePerPeriod.multiply(BigDecimal.valueOf(1));
 break;
+case WHOLE_TERM:
+final BigDecimal ratePerPeriod = 
interestRatePerPeriod.divide(BigDecimal.valueOf(numberOfRepayments*repaymentEvery),
 8, RoundingMode.HALF_UP);
--- End diff --

Why divide by 8?


> Interest to be calculated for the whole loan term given
> ---
>
> Key: FINERACT-416
> URL: https://issues.apache.org/jira/browse/FINERACT-416
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Mexina Daniel
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: gsoc2017, p1
>
> As for some of the MFI practise here in our country, they specify the 
> interest for the whole loan term given, i.e their loan product have the 
> interest for the whole loan term regardless of the frequency of repayment ()
> To accomplish this in mifos, a user has to do calculation of finding an 
> interest of a month/year with respect of the loan term of that specific 
> client. This is a very tiresome work as for a day a user can have apply many 
> loans and the task of calculation make the work even harder.
> I was suggesting improvement in the loan product, to be able to allow the 
> interest rate of the whole loan term.
> Example:
> Loan product -  Development Loan
> Amount -  Min: 100,000, Max:1,000,000
> Interest - 20%
> Loan term - From 3months to 6months
> -- This means the interest given is for any loan term the client will want to 
> take the loan.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-416) Interest to be calculated for the whole loan term given

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320099#comment-16320099
 ] 

ASF GitHub Bot commented on FINERACT-416:
-

Github user avikganguly01 commented on a diff in the pull request:

https://github.com/apache/fineract/pull/436#discussion_r160646405
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AprCalculator.java
 ---
@@ -41,10 +41,29 @@ public BigDecimal calculateFrom(final 
PeriodFrequencyType interestPeriodFrequenc
 case YEARS:
 defaultAnnualNominalInterestRate = 
interestRatePerPeriod.multiply(BigDecimal.valueOf(1));
 break;
+case WHOLE_TERM:
+final BigDecimal ratePerPeriod = 
interestRatePerPeriod.divide(BigDecimal.valueOf(numberOfRepayments*repaymentEvery),
 8, RoundingMode.HALF_UP);
+ 
+ switch (repaymentPeriodFrequencyType) {
+ case DAYS:
+ defaultAnnualNominalInterestRate = 
ratePerPeriod.multiply(BigDecimal.valueOf(365));
--- End diff --

Shoudn't this consider the no. of days in a year as per product 
configuration instead of 365?


> Interest to be calculated for the whole loan term given
> ---
>
> Key: FINERACT-416
> URL: https://issues.apache.org/jira/browse/FINERACT-416
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Mexina Daniel
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: gsoc2017, p1
>
> As for some of the MFI practise here in our country, they specify the 
> interest for the whole loan term given, i.e their loan product have the 
> interest for the whole loan term regardless of the frequency of repayment ()
> To accomplish this in mifos, a user has to do calculation of finding an 
> interest of a month/year with respect of the loan term of that specific 
> client. This is a very tiresome work as for a day a user can have apply many 
> loans and the task of calculation make the work even harder.
> I was suggesting improvement in the loan product, to be able to allow the 
> interest rate of the whole loan term.
> Example:
> Loan product -  Development Loan
> Amount -  Min: 100,000, Max:1,000,000
> Interest - 20%
> Loan term - From 3months to 6months
> -- This means the interest given is for any loan term the client will want to 
> take the loan.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-416) Interest to be calculated for the whole loan term given

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320253#comment-16320253
 ] 

ASF GitHub Bot commented on FINERACT-416:
-

Github user MexinaD commented on a diff in the pull request:

https://github.com/apache/fineract/pull/436#discussion_r160679575
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AprCalculator.java
 ---
@@ -41,10 +41,29 @@ public BigDecimal calculateFrom(final 
PeriodFrequencyType interestPeriodFrequenc
 case YEARS:
 defaultAnnualNominalInterestRate = 
interestRatePerPeriod.multiply(BigDecimal.valueOf(1));
 break;
+case WHOLE_TERM:
+final BigDecimal ratePerPeriod = 
interestRatePerPeriod.divide(BigDecimal.valueOf(numberOfRepayments*repaymentEvery),
 8, RoundingMode.HALF_UP);
--- End diff --

Its not divided by 8 but i rounded off the result of InterestRatePerPeriod 
divide by (numberOfRepayment*repayedEvery) to 8 us it was applied in another 
code in Loan.java "final MathContext mc = new MathContext(8, roundingMode);" So 
i assumed the roundoff that the system is using is 8.


> Interest to be calculated for the whole loan term given
> ---
>
> Key: FINERACT-416
> URL: https://issues.apache.org/jira/browse/FINERACT-416
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Mexina Daniel
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: gsoc2017, p1
>
> As for some of the MFI practise here in our country, they specify the 
> interest for the whole loan term given, i.e their loan product have the 
> interest for the whole loan term regardless of the frequency of repayment ()
> To accomplish this in mifos, a user has to do calculation of finding an 
> interest of a month/year with respect of the loan term of that specific 
> client. This is a very tiresome work as for a day a user can have apply many 
> loans and the task of calculation make the work even harder.
> I was suggesting improvement in the loan product, to be able to allow the 
> interest rate of the whole loan term.
> Example:
> Loan product -  Development Loan
> Amount -  Min: 100,000, Max:1,000,000
> Interest - 20%
> Loan term - From 3months to 6months
> -- This means the interest given is for any loan term the client will want to 
> take the loan.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-416) Interest to be calculated for the whole loan term given

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320271#comment-16320271
 ] 

ASF GitHub Bot commented on FINERACT-416:
-

Github user MexinaD commented on a diff in the pull request:

https://github.com/apache/fineract/pull/436#discussion_r160683568
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AprCalculator.java
 ---
@@ -41,10 +41,29 @@ public BigDecimal calculateFrom(final 
PeriodFrequencyType interestPeriodFrequenc
 case YEARS:
 defaultAnnualNominalInterestRate = 
interestRatePerPeriod.multiply(BigDecimal.valueOf(1));
 break;
+case WHOLE_TERM:
+final BigDecimal ratePerPeriod = 
interestRatePerPeriod.divide(BigDecimal.valueOf(numberOfRepayments*repaymentEvery),
 8, RoundingMode.HALF_UP);
+ 
+ switch (repaymentPeriodFrequencyType) {
+ case DAYS:
+ defaultAnnualNominalInterestRate = 
ratePerPeriod.multiply(BigDecimal.valueOf(365));
--- End diff --

I followed what was already implemented for "DAYS" frequency from the first 
switch loop.


> Interest to be calculated for the whole loan term given
> ---
>
> Key: FINERACT-416
> URL: https://issues.apache.org/jira/browse/FINERACT-416
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Mexina Daniel
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: gsoc2017, p1
>
> As for some of the MFI practise here in our country, they specify the 
> interest for the whole loan term given, i.e their loan product have the 
> interest for the whole loan term regardless of the frequency of repayment ()
> To accomplish this in mifos, a user has to do calculation of finding an 
> interest of a month/year with respect of the loan term of that specific 
> client. This is a very tiresome work as for a day a user can have apply many 
> loans and the task of calculation make the work even harder.
> I was suggesting improvement in the loan product, to be able to allow the 
> interest rate of the whole loan term.
> Example:
> Loan product -  Development Loan
> Amount -  Min: 100,000, Max:1,000,000
> Interest - 20%
> Loan term - From 3months to 6months
> -- This means the interest given is for any loan term the client will want to 
> take the loan.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-416) Interest to be calculated for the whole loan term given

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320343#comment-16320343
 ] 

ASF GitHub Bot commented on FINERACT-416:
-

Github user MexinaD commented on the issue:

https://github.com/apache/fineract/pull/436
  
@avikganguly01  Regarding the above cases
1. The feature is to add another interest method, and since the interest 
method is primary configured in loan product and that's why the changes are 
made in loan product level, like any other interest methods 

2. I didn't check the use of PeriodFrequencyType to another product 
settings at the beginning thinking it wasn't necessary as the feature is only 
applicable to loan product. if the new change will not apply to other product, 
is there need to deal with other combinations?

3. I don't have a knowledge of LMS integrations but when i run that command 
there are some tests failing and other skipped.


> Interest to be calculated for the whole loan term given
> ---
>
> Key: FINERACT-416
> URL: https://issues.apache.org/jira/browse/FINERACT-416
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Mexina Daniel
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: gsoc2017, p1
>
> As for some of the MFI practise here in our country, they specify the 
> interest for the whole loan term given, i.e their loan product have the 
> interest for the whole loan term regardless of the frequency of repayment ()
> To accomplish this in mifos, a user has to do calculation of finding an 
> interest of a month/year with respect of the loan term of that specific 
> client. This is a very tiresome work as for a day a user can have apply many 
> loans and the task of calculation make the work even harder.
> I was suggesting improvement in the loan product, to be able to allow the 
> interest rate of the whole loan term.
> Example:
> Loan product -  Development Loan
> Amount -  Min: 100,000, Max:1,000,000
> Interest - 20%
> Loan term - From 3months to 6months
> -- This means the interest given is for any loan term the client will want to 
> take the loan.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-416) Interest to be calculated for the whole loan term given

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320370#comment-16320370
 ] 

ASF GitHub Bot commented on FINERACT-416:
-

Github user MexinaD commented on the issue:

https://github.com/apache/fineract/pull/436
  
@avikganguly01 Note: This is an improvement


> Interest to be calculated for the whole loan term given
> ---
>
> Key: FINERACT-416
> URL: https://issues.apache.org/jira/browse/FINERACT-416
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Mexina Daniel
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: gsoc2017, p1
>
> As for some of the MFI practise here in our country, they specify the 
> interest for the whole loan term given, i.e their loan product have the 
> interest for the whole loan term regardless of the frequency of repayment ()
> To accomplish this in mifos, a user has to do calculation of finding an 
> interest of a month/year with respect of the loan term of that specific 
> client. This is a very tiresome work as for a day a user can have apply many 
> loans and the task of calculation make the work even harder.
> I was suggesting improvement in the loan product, to be able to allow the 
> interest rate of the whole loan term.
> Example:
> Loan product -  Development Loan
> Amount -  Min: 100,000, Max:1,000,000
> Interest - 20%
> Loan term - From 3months to 6months
> -- This means the interest given is for any loan term the client will want to 
> take the loan.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FINERACT-416) Interest to be calculated for the whole loan term given

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338843#comment-16338843
 ] 

ASF GitHub Bot commented on FINERACT-416:
-

Github user MexinaD commented on the issue:

https://github.com/apache/fineract/pull/436
  
@avikganguly01 Is there anything to modify?


> Interest to be calculated for the whole loan term given
> ---
>
> Key: FINERACT-416
> URL: https://issues.apache.org/jira/browse/FINERACT-416
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Mexina Daniel
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: gsoc2017, p1
>
> As for some of the MFI practise here in our country, they specify the 
> interest for the whole loan term given, i.e their loan product have the 
> interest for the whole loan term regardless of the frequency of repayment ()
> To accomplish this in mifos, a user has to do calculation of finding an 
> interest of a month/year with respect of the loan term of that specific 
> client. This is a very tiresome work as for a day a user can have apply many 
> loans and the task of calculation make the work even harder.
> I was suggesting improvement in the loan product, to be able to allow the 
> interest rate of the whole loan term.
> Example:
> Loan product -  Development Loan
> Amount -  Min: 100,000, Max:1,000,000
> Interest - 20%
> Loan term - From 3months to 6months
> -- This means the interest given is for any loan term the client will want to 
> take the loan.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-590) Unable to create client under any office except Head office: Throwing 500 Internal Server Error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351517#comment-16351517
 ] 

ASF GitHub Bot commented on FINERACT-590:
-

GitHub user conradsp opened a pull request:

https://github.com/apache/fineract/pull/439

FINERACT-590

When adding prefix to account number, limit to 10 characters so that the 
account number is not longer than the database field (20 chars).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/conradsp/fineract develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/439.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #439


commit 8e7bd01ed46021d09a80b1a427cf7e65564d26d1
Author: conradsp 
Date:   2018-02-03T20:29:02Z

FINERACT-590




> Unable to create client under any office except Head office: Throwing 500 
> Internal Server Error
> ---
>
> Key: FINERACT-590
> URL: https://issues.apache.org/jira/browse/FINERACT-590
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.0.0
>Reporter: Santosh Math
>Assignee: Shaik Nazeer Hussain
>Priority: Blocker
>  Labels: blocker, p1
> Fix For: 1.1.0
>
> Attachments: Screenshot from 2018-01-17 19-54-57.png, Screenshot from 
> 2018-01-17 19-55-52.png
>
>
> Go to https://demo.openmf.org
> Go  to Clients and click on 'Create Client'.
> Provide all necesary or mandatory inputs  and select any office except Head 
> Office.
> >The application is throwing 500:internal server error. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-590) Unable to create client under any office except Head office: Throwing 500 Internal Server Error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351857#comment-16351857
 ] 

ASF GitHub Bot commented on FINERACT-590:
-

Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/439


> Unable to create client under any office except Head office: Throwing 500 
> Internal Server Error
> ---
>
> Key: FINERACT-590
> URL: https://issues.apache.org/jira/browse/FINERACT-590
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.0.0
>Reporter: Santosh Math
>Assignee: Shaik Nazeer Hussain
>Priority: Blocker
>  Labels: blocker, p1
> Fix For: 1.1.0
>
> Attachments: Screenshot from 2018-01-17 19-54-57.png, Screenshot from 
> 2018-01-17 19-55-52.png
>
>
> Go to https://demo.openmf.org
> Go  to Clients and click on 'Create Client'.
> Provide all necesary or mandatory inputs  and select any office except Head 
> Office.
> >The application is throwing 500:internal server error. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-558) Download page must link to ASF mirrors

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353627#comment-16353627
 ] 

ASF GitHub Bot commented on FINERACT-558:
-

GitHub user myrle-krantz opened a pull request:

https://github.com/apache/fineract-site/pull/11

FINERACT-558: linking to mirrors rather than linking directly to apac…

https://issues.apache.org/jira/browse/FINERACT-558

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myrle-krantz/fineract-site master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract-site/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11


commit 46dd41b73b21b8f9a1415b1752daa25e02092975
Author: Myrle Krantz 
Date:   2018-02-06T09:13:30Z

FINERACT-558: linking to mirrors rather than linking directly to apache 
download.  Linking check hashes and signatures too.




> Download page must link to ASF mirrors
> --
>
> Key: FINERACT-558
> URL: https://issues.apache.org/jira/browse/FINERACT-558
> Project: Apache Fineract
>  Issue Type: Bug
> Environment: http://fineract.apache.org/
>Reporter: Sebb
>Assignee: Myrle Krantz
>Priority: Critical
>
> Download pages must link to ASF mirror system.
> They must not use dist.apache.org for anything.
> See:
> http://www.apache.org/dev/release-download-pages#links
> Note the download page should also provide instructions for how to check 
> hashes and signatures.
> The links to the hashes, signatures and KEYS file must be to the ASF server 
> and should use https.
> However the links to the source and binary bundles must use the mirror system.
> Likewise, announcement mails must not direct downloaders to the 
> dist.apache.org host.
> Please fix the next announce email



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-558) Download page must link to ASF mirrors

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353637#comment-16353637
 ] 

ASF GitHub Bot commented on FINERACT-558:
-

Github user asfgit closed the pull request at:

https://github.com/apache/fineract-site/pull/11


> Download page must link to ASF mirrors
> --
>
> Key: FINERACT-558
> URL: https://issues.apache.org/jira/browse/FINERACT-558
> Project: Apache Fineract
>  Issue Type: Bug
> Environment: http://fineract.apache.org/
>Reporter: Sebb
>Assignee: Myrle Krantz
>Priority: Critical
>
> Download pages must link to ASF mirror system.
> They must not use dist.apache.org for anything.
> See:
> http://www.apache.org/dev/release-download-pages#links
> Note the download page should also provide instructions for how to check 
> hashes and signatures.
> The links to the hashes, signatures and KEYS file must be to the ASF server 
> and should use https.
> However the links to the source and binary bundles must use the mirror system.
> Likewise, announcement mails must not direct downloaders to the 
> dist.apache.org host.
> Please fix the next announce email



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-601) Create Cashier for Teller: error when Teller End Date is null

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354050#comment-16354050
 ] 

ASF GitHub Bot commented on FINERACT-601:
-

GitHub user terencemo opened a pull request:

https://github.com/apache/fineract/pull/440

FINERACT-601 Create Cashier for Teller: when Teller End Date is null



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/terencemo/incubator-fineract 
i601-create-cashier-teller-end-date

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #440


commit e13616b0e9c9232cd044bdf12bf41f225c76cbb3
Author: Terence Denzil Monteiro 
Date:   2018-02-06T15:12:32Z

Only compare Teller and Cashier endDate if its not null




> Create Cashier for Teller: error when Teller End Date is null
> -
>
> Key: FINERACT-601
> URL: https://issues.apache.org/jira/browse/FINERACT-601
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Organization
>Affects Versions: 1.0.0
>Reporter: Terence Denzil Monteiro
>Assignee: Myrle Krantz
>Priority: Minor
>
> Create a Teller with From date but no End date. Then fill Cashier for Teller 
> form entering some from date and to date. The platform returns 500:"Internal 
> Server Error"
> {{exception:"java.lang.IllegalArgumentException"}}
> {{message:"Partial cannot be null"}}
> {{status:500}}
> {{timestamp:1517925605157}}
> To reproduce this, see "Perpetual Teller" in 
> [https://demo.openmf.org|https://demo.openmf.org/] which has no end date and 
> try to add a cashier with some valid from and to date. Or follow the above 
> steps.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-601) Create Cashier for Teller: error when Teller End Date is null

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354156#comment-16354156
 ] 

ASF GitHub Bot commented on FINERACT-601:
-

Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/440


> Create Cashier for Teller: error when Teller End Date is null
> -
>
> Key: FINERACT-601
> URL: https://issues.apache.org/jira/browse/FINERACT-601
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Organization
>Affects Versions: 1.0.0
>Reporter: Terence Denzil Monteiro
>Assignee: Terence Denzil Monteiro
>Priority: Minor
>
> Create a Teller with From date but no End date. Then fill Cashier for Teller 
> form entering some from date and to date. The platform returns 500:"Internal 
> Server Error"
> {{exception:"java.lang.IllegalArgumentException"}}
> {{message:"Partial cannot be null"}}
> {{status:500}}
> {{timestamp:1517925605157}}
> To reproduce this, see "Perpetual Teller" in 
> [https://demo.openmf.org|https://demo.openmf.org/] which has no end date and 
> try to add a cashier with some valid from and to date. Or follow the above 
> steps.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-574) Issues related to share Account Creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357089#comment-16357089
 ] 

ASF GitHub Bot commented on FINERACT-574:
-

GitHub user Nenge1 opened a pull request:

https://github.com/apache/fineract/pull/441

FINERACT-574 

This pull request fix the bug of duplicate posting in journal entries when 
share account is rejected

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Nenge1/fineract FINERACT-574

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #441


commit 613b802c0d410e9fc74b1268c222d3b9d48bf6d4
Author: Nenge 
Date:   2018-02-08T12:05:39Z

FINERACT-574




> Issues related to share Account Creation
> 
>
> Key: FINERACT-574
> URL: https://issues.apache.org/jira/browse/FINERACT-574
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Shares
>Reporter: Santosh Math
>Assignee: Shaik Nazeer Hussain
>Priority: Critical
>  Labels: p1
> Attachments: Screenshot from 2017-12-12 21-05-47.png
>
>
> 1. Create Share  Product with Accounting Enabled 
> 2. Create a share charge with type 'Share Purchase' ,'Flat' amount $2.
> 3. Create and activate savings account for client which is needed to link 
> with share account
> 4.  Create a share Account application for current date using above product 
> and charge and number of shares issued as 10 , each share price as $0.5.
> > Once you 'Submit' the share application journal entries are created 
> > (including charge) even though share account is not yet approved/activated.
> >Approve the share account and again duplicate jounal entries are created. 
> >If share account application is attached with 'Share Activation Fee' , upon 
> >submission of share account application, if we check 'Transaction Overview' 
> >tab, it shows 'Activation Fee' is received even though share account is not 
> >activated. Same is updated in the database 
> >table,"m_share_account_charge_paid_by". But under the 'Charges' tab, it 
> >shows Outstanding(which is correct).
> The all scenarios can be tested here by modifying application and using the 
> charges 
> 'Share Purchase Fee'  or  'Share Activation Fee'
> https://staging.openmf.org/#/viewshareaccount/5



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-546) Cannot remove Group from Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376235#comment-16376235
 ] 

ASF GitHub Bot commented on FINERACT-546:
-

GitHub user viswaramamoorthy opened a pull request:

https://github.com/apache/fineract/pull/446

FINERACT-546 - remove group from center fix

1. Center from which group being disassociated is really stored as parent 
of the group. Introduced a parent check method to fix disassociation of groups

2. Originally disassociateGroups command was returning result as 
'clientMembers' - assuming this is typo. Fixed to return result as groupMembers
3. Updated test case CenterIntegrationTest to validate

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/viswaramamoorthy/fineract 
FINERACT-546-rm-group-from-center-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/446.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #446


commit 93ee044b5f1fd6b70500b4ef8de142e954df69b7
Author: Viswa Ramamoorthy 
Date:   2018-02-25T20:31:53Z

1. Center from which group being disassociated is really stored as parent 
of the group. Introduced a parent check method to fix disassociation of groups
2. Originally disassociateGroups command was returning result as 
'clientMembers' - assuming this is typo. Fixed to return result as groupMembers
3. Updated test case CenterIntegrationTest to validate




> Cannot remove Group from Center
> ---
>
> Key: FINERACT-546
> URL: https://issues.apache.org/jira/browse/FINERACT-546
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Groups
>Reporter: May Myint
>Assignee: Shaik Nazeer Hussain
>Priority: Major
>  Labels: gci2017, group, p1
>
> Unable to remove Group from Center.
> Error message "field is required. error.msg.group.not.in.center"
> https://demo.openmf.org/#/viewcenter/1175



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-426) Filter to optionally compress response with gzip

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429324#comment-16429324
 ] 

ASF GitHub Bot commented on FINERACT-426:
-

GitHub user wkk91193 opened a pull request:

https://github.com/apache/fineract/pull/450

Adding a compress response filter,registering filter

Adding a filter to support response compression. This will ensure less 
bandwidth usage for field officer apps
Related Jira issue 
[FINERACT-426](https://issues.apache.org/jira/browse/FINERACT-426?jql=reporter%20in%20(avikganguly%2C%20avikganguly010))

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wkk91193/incubator-fineract 
fineract-426-filter-to-optionally-compress-response-with-gzip

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/450.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #450


commit c0042e393fa3f41608b6c9da189f685499a0a926
Author: unknown 
Date:   2018-04-07T11:52:11Z

Adding a compress response filter,registering filter




> Filter to optionally compress response with gzip
> 
>
> Key: FINERACT-426
> URL: https://issues.apache.org/jira/browse/FINERACT-426
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Avik Ganguly
>Assignee: Markus Geiss
>Priority: Minor
>  Labels: easyfix, gsoc, newbie, p2, performance
>
> Accept a query parameter like isCompressionRequired. If this query param is 
> present, compress the response using gzip. This will ensure less bandwidth 
> usage if field apps are using mobile data.
> Sample Code for response filter :-
> Inside filter method :-
> if 
> (request.getRequestHeaders().getFirst(HttpHeaders.ACCEPT_ENCODING).contains("gzip"))
>  {
>   
> response.getHttpHeaders().add(HttpHeaders.CONTENT_ENCODING, "gzip");
>   response.setContainerResponseWriter(
>   new 
> Adapter(response.getContainerResponseWriter()));
>   }
>   private static final class Adapter implements ContainerResponseWriter {
> private final ContainerResponseWriter crw;
> private GZIPOutputStream gos;
> Adapter(ContainerResponseWriter crw) {
> this.crw = crw;
> }
> 
> public OutputStream writeStatusAndHeaders(long contentLength, 
> ContainerResponse response) throws IOException {
>gos = new GZIPOutputStream(crw.writeStatusAndHeaders(-1, 
> response));
>return gos;
> }
> public void finish() throws IOException {
> gos.finish();
> crw.finish();
> }
> }
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-613) 500 Internal Server Errors on Data Tables

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433411#comment-16433411
 ] 

ASF GitHub Bot commented on FINERACT-613:
-

GitHub user lingalamadhukar opened a pull request:

https://github.com/apache/fineract/pull/451

FINERACT-613:500 Internal Server Errors on Data Tables



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lingalamadhukar/incubator-fineract 
FINERACT-613

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/451.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #451


commit a847b81792e94137455710e1d21e09cea60bee5c
Author: Madhukar 
Date:   2018-04-11T05:11:53Z

FINERACT-613:500 Internal Server Errors on Data Tables




> 500 Internal Server Errors on Data Tables
> -
>
> Key: FINERACT-613
> URL: https://issues.apache.org/jira/browse/FINERACT-613
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Data Tables
>Affects Versions: 1.1.0
>Reporter: Edward Cable
>Priority: Blocker
> Attachments: Screen Shot 2018-04-08 at 19.35.16.png
>
>
> After the release of Apache Fineract 1.1, users have reported the following 
> errors related to data tables:
>  * A logged in user will receive an empty ‘error’ alert when they click on 
> any data tables that were previously set. 
>  * On close inspection with Firefox debugger, the GET request to retrieve 
> datatables data is returning with an internal server error (500)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-613) 500 Internal Server Errors on Data Tables

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468480#comment-16468480
 ] 

ASF GitHub Bot commented on FINERACT-613:
-

Github user wkk91193 commented on the issue:

https://github.com/apache/fineract/pull/451
  
@lingalamadhukar  when this was merged to develop, pentaho reports keep 
failing with the following [stacktrace](https://pastebin.com/2ku8GEe7)


> 500 Internal Server Errors on Data Tables
> -
>
> Key: FINERACT-613
> URL: https://issues.apache.org/jira/browse/FINERACT-613
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Data Tables
>Affects Versions: 1.1.0
>Reporter: Edward Cable
>Priority: Blocker
> Attachments: Screen Shot 2018-04-08 at 19.35.16.png
>
>
> After the release of Apache Fineract 1.1, users have reported the following 
> errors related to data tables:
>  * A logged in user will receive an empty ‘error’ alert when they click on 
> any data tables that were previously set. 
>  * On close inspection with Firefox debugger, the GET request to retrieve 
> datatables data is returning with an internal server error (500)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-613) 500 Internal Server Errors on Data Tables

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468503#comment-16468503
 ] 

ASF GitHub Bot commented on FINERACT-613:
-

Github user Ippezrobert commented on the issue:

https://github.com/apache/fineract/pull/451
  
@wkk91193 , i face the same but it seems it's because of maria-db driver. 
Make sure you are using mysql server. Please check this 
https://gist.github.com/odan/c799417460470c3776ffa8adce57eece

Confirm this by running `mysql -uroot -pmysql` from command line and please 
paste your result


> 500 Internal Server Errors on Data Tables
> -
>
> Key: FINERACT-613
> URL: https://issues.apache.org/jira/browse/FINERACT-613
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Data Tables
>Affects Versions: 1.1.0
>Reporter: Edward Cable
>Priority: Blocker
> Attachments: Screen Shot 2018-04-08 at 19.35.16.png
>
>
> After the release of Apache Fineract 1.1, users have reported the following 
> errors related to data tables:
>  * A logged in user will receive an empty ‘error’ alert when they click on 
> any data tables that were previously set. 
>  * On close inspection with Firefox debugger, the GET request to retrieve 
> datatables data is returning with an internal server error (500)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-613) 500 Internal Server Errors on Data Tables

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468591#comment-16468591
 ] 

ASF GitHub Bot commented on FINERACT-613:
-

Github user wkk91193 commented on the issue:

https://github.com/apache/fineract/pull/451
  
@Ippezrobert  yes, I'm using the MySQL server


> 500 Internal Server Errors on Data Tables
> -
>
> Key: FINERACT-613
> URL: https://issues.apache.org/jira/browse/FINERACT-613
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Data Tables
>Affects Versions: 1.1.0
>Reporter: Edward Cable
>Priority: Blocker
> Attachments: Screen Shot 2018-04-08 at 19.35.16.png
>
>
> After the release of Apache Fineract 1.1, users have reported the following 
> errors related to data tables:
>  * A logged in user will receive an empty ‘error’ alert when they click on 
> any data tables that were previously set. 
>  * On close inspection with Firefox debugger, the GET request to retrieve 
> datatables data is returning with an internal server error (500)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-613) 500 Internal Server Errors on Data Tables

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468660#comment-16468660
 ] 

ASF GitHub Bot commented on FINERACT-613:
-

Github user lingalamadhukar commented on the issue:

https://github.com/apache/fineract/pull/451
  
@wkk91193 this pull request is still open and not merged into develop 
branch.
Correct me if am wrong, I think we cannot run or execute Pentaho reports in 
apache/fineract code base, you need to use openMF/incubator-fineract repository 
code to execute Pentaho reports.



> 500 Internal Server Errors on Data Tables
> -
>
> Key: FINERACT-613
> URL: https://issues.apache.org/jira/browse/FINERACT-613
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Data Tables
>Affects Versions: 1.1.0
>Reporter: Edward Cable
>Priority: Blocker
> Attachments: Screen Shot 2018-04-08 at 19.35.16.png
>
>
> After the release of Apache Fineract 1.1, users have reported the following 
> errors related to data tables:
>  * A logged in user will receive an empty ‘error’ alert when they click on 
> any data tables that were previously set. 
>  * On close inspection with Firefox debugger, the GET request to retrieve 
> datatables data is returning with an internal server error (500)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-613) 500 Internal Server Errors on Data Tables

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468702#comment-16468702
 ] 

ASF GitHub Bot commented on FINERACT-613:
-

Github user wkk91193 commented on the issue:

https://github.com/apache/fineract/pull/451
  
@lingalamadhukar  where can I get the latest source code for Mifosx 
18.03.01?


> 500 Internal Server Errors on Data Tables
> -
>
> Key: FINERACT-613
> URL: https://issues.apache.org/jira/browse/FINERACT-613
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Data Tables
>Affects Versions: 1.1.0
>Reporter: Edward Cable
>Priority: Blocker
> Attachments: Screen Shot 2018-04-08 at 19.35.16.png
>
>
> After the release of Apache Fineract 1.1, users have reported the following 
> errors related to data tables:
>  * A logged in user will receive an empty ‘error’ alert when they click on 
> any data tables that were previously set. 
>  * On close inspection with Firefox debugger, the GET request to retrieve 
> datatables data is returning with an internal server error (500)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-613) 500 Internal Server Errors on Data Tables

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468745#comment-16468745
 ] 

ASF GitHub Bot commented on FINERACT-613:
-

Github user lingalamadhukar commented on the issue:

https://github.com/apache/fineract/pull/451
  
@wkk91193 you can find the same under releases, 
https://github.com/openMF/incubator-fineract/releases


> 500 Internal Server Errors on Data Tables
> -
>
> Key: FINERACT-613
> URL: https://issues.apache.org/jira/browse/FINERACT-613
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Data Tables
>Affects Versions: 1.1.0
>Reporter: Edward Cable
>Priority: Blocker
> Attachments: Screen Shot 2018-04-08 at 19.35.16.png
>
>
> After the release of Apache Fineract 1.1, users have reported the following 
> errors related to data tables:
>  * A logged in user will receive an empty ‘error’ alert when they click on 
> any data tables that were previously set. 
>  * On close inspection with Firefox debugger, the GET request to retrieve 
> datatables data is returning with an internal server error (500)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-610) Post Interest As On

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471496#comment-16471496
 ] 

ASF GitHub Bot commented on FINERACT-610:
-

GitHub user MexinaD opened a pull request:

https://github.com/apache/fineract/pull/453

FINERACT-610 - Post Interest As On Permision



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MexinaD/incubator-fineract FINERACT-610

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #453


commit 66078d4ec289c3dd48c51b0dafb96eb83fa9372d
Author: Mexina M Daniel 
Date:   2018-05-04T09:24:17Z

FINERACT-610 - Post Interest As On Permision




> Post Interest As On
> ---
>
> Key: FINERACT-610
> URL: https://issues.apache.org/jira/browse/FINERACT-610
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Savings
>Reporter: May Myint
>Priority: Minor
>  Labels: saving
>
> Currently, Post Interest As On is only available when User is given ALL 
> FUNCTION permission. However, this is needed by many Users who should not be 
> given the ALL FUNCTION (loan officers etc). This function is used when a 
> client leaves the MFI and all their Savings are posted up to date and 
> withdrawn. It would be ideal to have a separate permission setting for this 
> function.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-623) The restriction of product mix should apply during submission of another loan

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490369#comment-16490369
 ] 

ASF GitHub Bot commented on FINERACT-623:
-

GitHub user MexinaD opened a pull request:

https://github.com/apache/fineract/pull/454

FINERACT-623 - Restriction of product mix fix



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MexinaD/incubator-fineract FINERACT-623

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/454.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #454


commit e839d8034a6021ccefed455d1eb64d8489862afd
Author: Mexina M Daniel 
Date:   2018-05-25T07:11:26Z

FINERACT-623 - Restriction of product mix fix




> The restriction of product mix should apply during submission of another loan
> -
>
> Key: FINERACT-623
> URL: https://issues.apache.org/jira/browse/FINERACT-623
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Mexina Daniel
>Priority: Major
>  Labels: gsoc, p2
>
> For now when you configure one loan account of Product1 not to be applied 
> when a client already have another loan account of Product2, during the 
> application of another loan account, the system accept to submit and approve 
> the loan and give the error of co-exist during disburse.
> Expected: The system should give the error of co-exist of the restricted loan 
> when a user is submitting the new loan account since the two loans should not 
> exist together.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-613) 500 Internal Server Errors on Data Tables

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508480#comment-16508480
 ] 

ASF GitHub Bot commented on FINERACT-613:
-

Github user edcable commented on the issue:

https://github.com/apache/fineract/pull/451
  
@avikganguly01 @conradsp @nazeer1100126 @nikpawar Can we get this merged in 
so we can ship the point release that contains this hot fix?


> 500 Internal Server Errors on Data Tables
> -
>
> Key: FINERACT-613
> URL: https://issues.apache.org/jira/browse/FINERACT-613
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Data Tables
>Affects Versions: 1.1.0
>Reporter: Edward Cable
>Priority: Blocker
> Attachments: Screen Shot 2018-04-08 at 19.35.16.png
>
>
> After the release of Apache Fineract 1.1, users have reported the following 
> errors related to data tables:
>  * A logged in user will receive an empty ‘error’ alert when they click on 
> any data tables that were previously set. 
>  * On close inspection with Firefox debugger, the GET request to retrieve 
> datatables data is returning with an internal server error (500)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-613) 500 Internal Server Errors on Data Tables

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508558#comment-16508558
 ] 

ASF GitHub Bot commented on FINERACT-613:
-

Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/451


> 500 Internal Server Errors on Data Tables
> -
>
> Key: FINERACT-613
> URL: https://issues.apache.org/jira/browse/FINERACT-613
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Data Tables
>Affects Versions: 1.1.0
>Reporter: Edward Cable
>Priority: Blocker
> Attachments: Screen Shot 2018-04-08 at 19.35.16.png
>
>
> After the release of Apache Fineract 1.1, users have reported the following 
> errors related to data tables:
>  * A logged in user will receive an empty ‘error’ alert when they click on 
> any data tables that were previously set. 
>  * On close inspection with Firefox debugger, the GET request to retrieve 
> datatables data is returning with an internal server error (500)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-613) 500 Internal Server Errors on Data Tables

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508560#comment-16508560
 ] 

ASF GitHub Bot commented on FINERACT-613:
-

Github user conradsp commented on the issue:

https://github.com/apache/fineract/pull/451
  
I have merged this PR.


> 500 Internal Server Errors on Data Tables
> -
>
> Key: FINERACT-613
> URL: https://issues.apache.org/jira/browse/FINERACT-613
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Data Tables
>Affects Versions: 1.1.0
>Reporter: Edward Cable
>Priority: Blocker
> Attachments: Screen Shot 2018-04-08 at 19.35.16.png
>
>
> After the release of Apache Fineract 1.1, users have reported the following 
> errors related to data tables:
>  * A logged in user will receive an empty ‘error’ alert when they click on 
> any data tables that were previously set. 
>  * On close inspection with Firefox debugger, the GET request to retrieve 
> datatables data is returning with an internal server error (500)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-613) 500 Internal Server Errors on Data Tables

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508561#comment-16508561
 ] 

ASF GitHub Bot commented on FINERACT-613:
-

Github user conradsp commented on the issue:

https://github.com/apache/fineract/pull/451
  
I have merged this PR.
Thanks,
Steve


On Mon, Jun 11, 2018 at 1:19 PM edcable  wrote:

> @avikganguly01  @conradsp
>  @nazeer1100126
>  @nikpawar 
> Can we get this merged in so we can ship the point release that contains
> this hot fix?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



> 500 Internal Server Errors on Data Tables
> -
>
> Key: FINERACT-613
> URL: https://issues.apache.org/jira/browse/FINERACT-613
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Data Tables
>Affects Versions: 1.1.0
>Reporter: Edward Cable
>Priority: Blocker
> Attachments: Screen Shot 2018-04-08 at 19.35.16.png
>
>
> After the release of Apache Fineract 1.1, users have reported the following 
> errors related to data tables:
>  * A logged in user will receive an empty ‘error’ alert when they click on 
> any data tables that were previously set. 
>  * On close inspection with Firefox debugger, the GET request to retrieve 
> datatables data is returning with an internal server error (500)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-630) Bulk import to allow importing loan with decimal interest

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510865#comment-16510865
 ] 

ASF GitHub Bot commented on FINERACT-630:
-

GitHub user MexinaD opened a pull request:

https://github.com/apache/fineract/pull/455

FINERACT-630 Allow decimal interest in a sheet to import loan



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MexinaD/incubator-fineract FINERACT-630

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #455


commit 2e5aaf72de209471e669ea46c5afd0d1baa8c94d
Author: Mexina M Daniel 
Date:   2018-06-13T09:34:53Z

FINERACT-630 Allow decimal interest in a sheet to import loan




> Bulk import to allow importing loan with decimal interest
> -
>
> Key: FINERACT-630
> URL: https://issues.apache.org/jira/browse/FINERACT-630
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Mexina Daniel
>Priority: Major
>  Labels: LOAN, bulkimport
>
> For now the downloaded sheets to import loans does not allow the interest 
> which is of decimal value.
> The platform should allow both decimals and without decimal values of 
> interest.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-429) Node aware Scheduler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521513#comment-16521513
 ] 

ASF GitHub Bot commented on FINERACT-429:
-

GitHub user wkk91193 opened a pull request:

https://github.com/apache/fineract/pull/459

FINERACT-429: Node aware Scheduler

[Fineract-429](https://issues.apache.org/jira/browse/FINERACT-429)

Executing jobs based on node id

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wkk91193/incubator-fineract 
fineract-429-node-aware-scheduler

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/459.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #459


commit abed7b5f0df61b816e2dcb64771ad3dc4d1fdeba
Author: unknown 
Date:   2018-06-24T14:02:47Z

Commit-1: Execute jobs based on node_id

commit 68f2bdf885cecc57bd67ffc2a641a57964b66ffe
Author: unknown 
Date:   2018-06-24T14:44:30Z

Commit-2:Add dirty job scheduler




> Node aware Scheduler
> 
>
> Key: FINERACT-429
> URL: https://issues.apache.org/jira/browse/FINERACT-429
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Avik Ganguly
>Assignee: Markus Geiss
>Priority: Major
>  Labels: gsoc, p2
>
> I believe multiple instances of the same job can be created by keeping the 
> same job identifier but having different job keys. Additional parameter 
> nodeId can be saved in the job table defaulting to 1. Default this parameter 
> for a single-instance app-server to 1. 
> If node.id parameter exists in the application yaml while deploying, set that 
> system property to configured node id.  
> Front-end can pass the configured node-id of the job instance as a query 
> parameter.
> This will allow the organization to configure something like let Node 1 do 
> all accruals for North zonal office and Node 2 do all accruals for South 
> Zonal office.
> System admin can setup the corresponding mapping for node to IPs/URL while 
> configuring load balancer. Example :-
> ```
> //Nginx - Default Round Robin Configuration
> http {
> upstream myapp1 {
> server srv1.example.com;
> server srv2.example.com;
> server srv3.example.com;
> }
>map $query_string $srvr {
>   default https://myapp1   // If it doesn't match, send to load 
> balancer
> node=1  srv1.example.com;
> node=2  srv2.example.com;
> node=3  srv3.example.com;
>}
> server {
> listen 80;
> location / {
> proxy_pass $srvr;
> }
> }
> }
> ```



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-637) Trial Balance Job

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521548#comment-16521548
 ] 

ASF GitHub Bot commented on FINERACT-637:
-

Github user wkk91193 commented on the issue:

https://github.com/apache/fineract/pull/458
  
@avikganguly01 
Removing collate,engine details and adding index to transaction_date done!


> Trial Balance Job
> -
>
> Key: FINERACT-637
> URL: https://issues.apache.org/jira/browse/FINERACT-637
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Accounting, Loan
>Reporter: Kumaranath Fernando
>Priority: Major
>  Labels: pull-request-available
>
> Creating a consolidated entry in the trial balance table for each day with 
> the aggregation of all journal entries for that given day by grouping by GL 
> account, branch, transaction date and updating the closing balance. As for 
> which the results can be used for any reporting service or MIS requirements 
> of MFIs or for merely reconciliation requirements



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-611) Unable to Create Share Product showing 'Unknown data integrity issue'

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543030#comment-16543030
 ] 

ASF GitHub Bot commented on FINERACT-611:
-

GitHub user ShruthiRajaram opened a pull request:

https://github.com/apache/fineract/pull/461

FINERACT-611 unable to create share product

FINERACT-611 : Unable to Create Share Product showing 'Unknown data 
integrity issue' 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ShruthiRajaram/fineract develop_FINERACT_611

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/461.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #461


commit 683c767e3f03dadca7a327175a636d60f09db369
Author: ShruthiRajaram 
Date:   2018-07-13T12:37:29Z

FINERACT-611 unable to create share product




> Unable to Create Share Product showing 'Unknown data integrity issue'
> -
>
> Key: FINERACT-611
> URL: https://issues.apache.org/jira/browse/FINERACT-611
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Shares
>Reporter: Santosh Math
>Assignee: Shruthi  M R
>Priority: Blocker
>  Labels: gsoc, p1
> Attachments: shareProduct.png
>
>
> Go to  Admin>Products> Share Products  and then click on 'Create Share 
> Product'
> Give inputs to all mandatory fields and at the last stage if you try to 
> submit, it's throwing the data integrity issue. check the screenshot attached 
> with  this issue. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-428) Parallelization of Jobs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545486#comment-16545486
 ] 

ASF GitHub Bot commented on FINERACT-428:
-

GitHub user wkk91193 opened a pull request:

https://github.com/apache/fineract/pull/462

 FINERACT-428 Parallelization of Jobs :Parallelizing periodic accurual

[Fineract-428](https://issues.apache.org/jira/browse/FINERACT-428)

Parallelizing and paging of periodic accrual


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wkk91193/incubator-fineract 
parallelizing-periodic-accurual

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #462


commit 200d01dda29dc85651aa6c654e435099d199e6a8
Author: unknown 
Date:   2018-06-19T14:41:43Z

Implementing Trial balance job

commit fa4dee6eda6a04833e8cebec415b552a237806b0
Author: unknown 
Date:   2018-06-24T16:51:10Z

Removing collate,engine details and adding index to transaction_date column

commit 16915f24fe96782e43adc1fa2214be0232702ba6
Author: unknown 
Date:   2018-07-16T16:54:55Z

Implementing parallelizing and paging of periodic accurual




> Parallelization of Jobs
> ---
>
> Key: FINERACT-428
> URL: https://issues.apache.org/jira/browse/FINERACT-428
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan, Savings
>Reporter: Avik Ganguly
>Assignee: Markus Geiss
>Priority: Major
>  Labels: gsoc, p2, performance
>
> For starters, it will be useful to have some technical configuration added as 
> job parameter for each of the below jobs, that is batch size and thread pool 
> size for executor service so this has a dependency on FINERACT-425. 
> Add migration script to add those 2 configurations to each of the following 
> jobs with the value of batch size being 500 and thread pool size being 16 :-
> Add Accrual Transactions
> Add Periodic Accrual Transactions
> Add Accrual Transactions For Loans With Income Posted As Transactions
> Generate Loan Loss Provisioning
> Post Interest for Savings
> Update Loan Summary
> This would require separation of core functionality to a separate class.
> Simplified example :-
> ```
> final ExecutorService executor = Executors.newFixedThreadPool(threadPoolSize);
> 
> final LocalDate dueDate = DateUtils.getLocalDateOfTenant();
> final Collection loansToBeRepaidData = 
> this.loanReadPlatformService
> .retrieveLoansToBeRepaidFromAdvancePayment(dueDate);
> Iterable> loansToBeRepaid = 
> Iterables.partition(loansToBeRepaidData, batchSize);
> final Authentication authentication = 
> SecurityContextHolder.getContext().getAuthentication();
> List> advancePaymentPosters = new 
> ArrayList>();
> 
> for (List subList : loansToBeRepaid) {
>   AdvancePaymentPoster poster = (AdvancePaymentPoster) 
> this.applicationContext.getBean("advancePaymentPoster");
>   poster.setLoans(subList);
>   poster.setTenant(ThreadLocalContextUtil.getTenant());
>   poster.setAuthentication(authentication);
>   poster.setCommandService(commandService);
>   advancePaymentPosters.add(Executors.callable(poster));
> }
> try {
>   List> responses = 
> executor.invokeAll(advancePaymentPosters);
> for(Future f : responses) {
>   f.get();
> }
>   } catch (InterruptedException e1) {
>   e1.printStackTrace();
>   }
> 
> executor.shutdown(); 
>  ```



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-628) Creation Of API's for Self-Service App

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546458#comment-16546458
 ] 

ASF GitHub Bot commented on FINERACT-628:
-

Github user ShruthiRajaram closed the pull request at:

https://github.com/apache/fineract/pull/460


> Creation Of API's for Self-Service App
> --
>
> Key: FINERACT-628
> URL: https://issues.apache.org/jira/browse/FINERACT-628
> Project: Apache Fineract
>  Issue Type: New Feature
>Reporter: Saksham Handu
>Assignee: Shruthi  M R
>Priority: Major
>
> List Of API's needed are mentioned below,
> 1) Support for applying for for savings accounts
>  2) Support for viewing share accounts
>  3) Support for adding guarantors
>  4) Support for editing user details. 
>  5) Support for viewing reports
>  6) Support for surveys
> 7) Support for Applying for new Shares Account
> 8) Support for uploading new Client's Image
> 9) Support for the list of Loan, Savings, Shares product along with their 
> details



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-628) Creation Of API's for Self-Service App

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546461#comment-16546461
 ] 

ASF GitHub Bot commented on FINERACT-628:
-

GitHub user ShruthiRajaram opened a pull request:

https://github.com/apache/fineract/pull/463

FINERACT-628 Savings account APIs for Self Service App

This support only savings account management APIs

Issue: https://issues.apache.org/jira/browse/FINERACT-628

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ShruthiRajaram/fineract develop_FINERACT_638

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/463.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #463


commit 424bd0884e7f21cc9c945fbbfd130be6423fbdbe
Author: ShruthiRajaram 
Date:   2018-07-17T11:35:55Z

FINERACT-628 Savings account APIs for Self Service App




> Creation Of API's for Self-Service App
> --
>
> Key: FINERACT-628
> URL: https://issues.apache.org/jira/browse/FINERACT-628
> Project: Apache Fineract
>  Issue Type: New Feature
>Reporter: Saksham Handu
>Assignee: Shruthi  M R
>Priority: Major
>
> List Of API's needed are mentioned below,
> 1) Support for applying for for savings accounts
>  2) Support for viewing share accounts
>  3) Support for adding guarantors
>  4) Support for editing user details. 
>  5) Support for viewing reports
>  6) Support for surveys
> 7) Support for Applying for new Shares Account
> 8) Support for uploading new Client's Image
> 9) Support for the list of Loan, Savings, Shares product along with their 
> details



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-642) Include Guarantor Accounts in Client Accounts Overview

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556755#comment-16556755
 ] 

ASF GitHub Bot commented on FINERACT-642:
-

Github user tonic889 commented on the issue:

https://github.com/apache/fineract/pull/452
  
Corresponding JIRA issue created for the fineact project 
(https://issues.apache.org/jira/browse/FINERACT-642)


> Include Guarantor Accounts in Client Accounts Overview
> --
>
> Key: FINERACT-642
> URL: https://issues.apache.org/jira/browse/FINERACT-642
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Client
>Reporter: Brian C Cooke
>Priority: Minor
>  Labels: newbie, pull-request-available, ready-to-commit
>
> Include accounts where the client is a guarantor in the client accounts 
> summary api.  This is proposed as part of enhancement for the community app 
> to show accounts where client is a guarantor in the client view 
> ([https://github.com/openMF/community-app/issues/1863)].
> Implementation of this enhancement is covered in pull request 452 
> (https://github.com/apache/fineract/pull/452/)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-428) Parallelization of Jobs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560790#comment-16560790
 ] 

ASF GitHub Bot commented on FINERACT-428:
-

GitHub user wkk91193 opened a pull request:

https://github.com/apache/fineract/pull/464

FINERACT-428 Parallelization of Jobs :Parallelizing and paging of update 
loan summary

[FINERACT-428](https://issues.apache.org/jira/browse/FINERACT-428)

Parallelizing and paging of update loan summary

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wkk91193/incubator-fineract 
parallelizing-update-loan-summary

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #464


commit e9bd04f98ec2aaa1f88588f5f1ea3ceccbb952cf
Author: unknown 
Date:   2018-07-28T15:48:06Z

Implementing parallelizing and paging of update loan summary




> Parallelization of Jobs
> ---
>
> Key: FINERACT-428
> URL: https://issues.apache.org/jira/browse/FINERACT-428
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan, Savings
>Reporter: Avik Ganguly
>Assignee: Markus Geiss
>Priority: Major
>  Labels: gsoc, p2, performance
>
> For starters, it will be useful to have some technical configuration added as 
> job parameter for each of the below jobs, that is batch size and thread pool 
> size for executor service so this has a dependency on FINERACT-425. 
> Add migration script to add those 2 configurations to each of the following 
> jobs with the value of batch size being 500 and thread pool size being 16 :-
> Add Accrual Transactions
> Add Periodic Accrual Transactions
> Add Accrual Transactions For Loans With Income Posted As Transactions
> Generate Loan Loss Provisioning
> Post Interest for Savings
> Update Loan Summary
> This would require separation of core functionality to a separate class.
> Simplified example :-
> ```
> final ExecutorService executor = Executors.newFixedThreadPool(threadPoolSize);
> 
> final LocalDate dueDate = DateUtils.getLocalDateOfTenant();
> final Collection loansToBeRepaidData = 
> this.loanReadPlatformService
> .retrieveLoansToBeRepaidFromAdvancePayment(dueDate);
> Iterable> loansToBeRepaid = 
> Iterables.partition(loansToBeRepaidData, batchSize);
> final Authentication authentication = 
> SecurityContextHolder.getContext().getAuthentication();
> List> advancePaymentPosters = new 
> ArrayList>();
> 
> for (List subList : loansToBeRepaid) {
>   AdvancePaymentPoster poster = (AdvancePaymentPoster) 
> this.applicationContext.getBean("advancePaymentPoster");
>   poster.setLoans(subList);
>   poster.setTenant(ThreadLocalContextUtil.getTenant());
>   poster.setAuthentication(authentication);
>   poster.setCommandService(commandService);
>   advancePaymentPosters.add(Executors.callable(poster));
> }
> try {
>   List> responses = 
> executor.invokeAll(advancePaymentPosters);
> for(Future f : responses) {
>   f.get();
> }
>   } catch (InterruptedException e1) {
>   e1.printStackTrace();
>   }
> 
> executor.shutdown(); 
>  ```



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-628) Creation Of API's for Self-Service App

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564774#comment-16564774
 ] 

ASF GitHub Bot commented on FINERACT-628:
-

Github user ShruthiRajaram closed the pull request at:

https://github.com/apache/fineract/pull/463


> Creation Of API's for Self-Service App
> --
>
> Key: FINERACT-628
> URL: https://issues.apache.org/jira/browse/FINERACT-628
> Project: Apache Fineract
>  Issue Type: New Feature
>Reporter: Saksham Handu
>Assignee: Shruthi  M R
>Priority: Major
>
> List Of API's needed are mentioned below,
> 1) Support for applying for for savings accounts
>  2) Support for viewing share accounts
>  3) Support for adding guarantors
>  4) Support for editing user details. 
>  5) Support for viewing reports
>  6) Support for surveys
> 7) Support for Applying for new Shares Account
> 8) Support for uploading new Client's Image
> 9) Support for the list of Loan, Savings, Shares product along with their 
> details



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-628) Creation Of API's for Self-Service App

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564797#comment-16564797
 ] 

ASF GitHub Bot commented on FINERACT-628:
-

GitHub user ShruthiRajaram opened a pull request:

https://github.com/apache/fineract/pull/467

FINERACT-628 Savings account APIs for Self Service App



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ShruthiRajaram/fineract develop_FINERACT_638

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/467.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #467


commit 424bd0884e7f21cc9c945fbbfd130be6423fbdbe
Author: ShruthiRajaram 
Date:   2018-07-17T11:35:55Z

FINERACT-628 Savings account APIs for Self Service App




> Creation Of API's for Self-Service App
> --
>
> Key: FINERACT-628
> URL: https://issues.apache.org/jira/browse/FINERACT-628
> Project: Apache Fineract
>  Issue Type: New Feature
>Reporter: Saksham Handu
>Assignee: Shruthi  M R
>Priority: Major
>
> List Of API's needed are mentioned below,
> 1) Support for applying for for savings accounts
>  2) Support for viewing share accounts
>  3) Support for adding guarantors
>  4) Support for editing user details. 
>  5) Support for viewing reports
>  6) Support for surveys
> 7) Support for Applying for new Shares Account
> 8) Support for uploading new Client's Image
> 9) Support for the list of Loan, Savings, Shares product along with their 
> details



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-431) Should not allow more than expected loan term based on 'number of repayments' and 'Repaid every' values.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568226#comment-16568226
 ] 

ASF GitHub Bot commented on FINERACT-431:
-

Github user ShruthiRajaram commented on the issue:

https://github.com/apache/fineract/pull/437
  
reviewed and can be merged


> Should not allow more than expected  loan term based on 'number of 
> repayments' and 'Repaid every' values.
> -
>
> Key: FINERACT-431
> URL: https://issues.apache.org/jira/browse/FINERACT-431
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Mexina Daniel
>Assignee: Markus Geiss
>Priority: Minor
>  Labels: gsoc, p2
>
> In loan application, the frequency of the loan term has to be the same with 
> the frequency of repaid every (days/weeks/months/years), by this : loan term 
> = number of repayment x repaid every.
> e.g 
> 1. Create a loan product and fill the necessary requirements (put default 
> number of repayment = 6, repaid every = 1 month)
> 2. Create a loan account to an active client and fill all necessary 
> requirement ( put loan term = 8 months), leave the number of repayment to 6.
> The system is allowing the loan term to be greater than (number of repayments 
> x repaid every) and provide the repayment schedule based on 'number of 
> repayments' and 'repaid every' values
> It should deny the submission and through an error like when you provide loan 
> term less than (number of repayments x repaid every)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-428) Parallelization of Jobs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569201#comment-16569201
 ] 

ASF GitHub Bot commented on FINERACT-428:
-

GitHub user wkk91193 opened a pull request:

https://github.com/apache/fineract/pull/468

Implementing parallelizing and paging of Add accrual accounting

[FINERACT-428](https://issues.apache.org/jira/browse/FINERACT-428)

Parallelizing and paging of add accrual accounting

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wkk91193/incubator-fineract 
parallelizing-accurual

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/468.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #468


commit ebd557769b9fc0f79d28bce59e08d1df59266606
Author: unknown 
Date:   2018-08-04T15:04:53Z

Implementing parallelizing and paging of Add accrual accounting




> Parallelization of Jobs
> ---
>
> Key: FINERACT-428
> URL: https://issues.apache.org/jira/browse/FINERACT-428
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan, Savings
>Affects Versions: 1.1.0
>Reporter: Avik Ganguly
>Assignee: Markus Geiss
>Priority: Major
>  Labels: gsoc, p2, performance
> Fix For: 1.2.0
>
>
> For starters, it will be useful to have some technical configuration added as 
> job parameter for each of the below jobs, that is batch size and thread pool 
> size for executor service so this has a dependency on FINERACT-425. 
> Add migration script to add those 2 configurations to each of the following 
> jobs with the value of batch size being 500 and thread pool size being 16 :-
> Add Accrual Transactions
> Add Periodic Accrual Transactions
> Add Accrual Transactions For Loans With Income Posted As Transactions
> Generate Loan Loss Provisioning
> Post Interest for Savings
> Update Loan Summary
> This would require separation of core functionality to a separate class.
> Simplified example :-
> ```
> final ExecutorService executor = Executors.newFixedThreadPool(threadPoolSize);
> 
> final LocalDate dueDate = DateUtils.getLocalDateOfTenant();
> final Collection loansToBeRepaidData = 
> this.loanReadPlatformService
> .retrieveLoansToBeRepaidFromAdvancePayment(dueDate);
> Iterable> loansToBeRepaid = 
> Iterables.partition(loansToBeRepaidData, batchSize);
> final Authentication authentication = 
> SecurityContextHolder.getContext().getAuthentication();
> List> advancePaymentPosters = new 
> ArrayList>();
> 
> for (List subList : loansToBeRepaid) {
>   AdvancePaymentPoster poster = (AdvancePaymentPoster) 
> this.applicationContext.getBean("advancePaymentPoster");
>   poster.setLoans(subList);
>   poster.setTenant(ThreadLocalContextUtil.getTenant());
>   poster.setAuthentication(authentication);
>   poster.setCommandService(commandService);
>   advancePaymentPosters.add(Executors.callable(poster));
> }
> try {
>   List> responses = 
> executor.invokeAll(advancePaymentPosters);
> for(Future f : responses) {
>   f.get();
> }
>   } catch (InterruptedException e1) {
>   e1.printStackTrace();
>   }
> 
> executor.shutdown(); 
>  ```



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-574) Issues related to share Account Creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570010#comment-16570010
 ] 

ASF GitHub Bot commented on FINERACT-574:
-

Github user ShruthiRajaram commented on the issue:

https://github.com/apache/fineract/pull/441
  
@Nenge1 While reviewing the PR, I observed few other scenarios which I 
mentioned in the JIRA issue.
Those needs to be addressed before fixing the current issue


> Issues related to share Account Creation
> 
>
> Key: FINERACT-574
> URL: https://issues.apache.org/jira/browse/FINERACT-574
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Shares
>Reporter: Santosh Math
>Assignee: Shaik Nazeer Hussain
>Priority: Critical
>  Labels: gci, gsoc, p1
> Fix For: 1.2.0
>
> Attachments: Screenshot from 2017-12-12 21-05-47.png
>
>
> 1. Create Share  Product with Accounting Enabled 
> 2. Create a share charge with type 'Share Purchase' ,'Flat' amount $2.
> 3. Create and activate savings account for client which is needed to link 
> with share account
> 4.  Create a share Account application for current date using above product 
> and charge and number of shares issued as 10 , each share price as $0.5.
> > Once you 'Submit' the share application journal entries are created 
> > (including charge) even though share account is not yet approved/activated.
> >Approve the share account and again duplicate jounal entries are created. 
> >If share account application is attached with 'Share Activation Fee' , upon 
> >submission of share account application, if we check 'Transaction Overview' 
> >tab, it shows 'Activation Fee' is received even though share account is not 
> >activated. Same is updated in the database 
> >table,"m_share_account_charge_paid_by". But under the 'Charges' tab, it 
> >shows Outstanding(which is correct).
> The all scenarios can be tested here by modifying application and using the 
> charges 
> 'Share Purchase Fee'  or  'Share Activation Fee'
> https://staging.openmf.org/#/viewshareaccount/5



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-428) Parallelization of Jobs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577237#comment-16577237
 ] 

ASF GitHub Bot commented on FINERACT-428:
-

GitHub user wkk91193 opened a pull request:

https://github.com/apache/fineract/pull/469

FINERACT-428 Parallelization of Jobs : Parallelizing and paging of 
recalculate interest for loans

[Fineract-428](https://issues.apache.org/jira/browse/FINERACT-428)

Parallelizing and paging of periodic accrual

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wkk91193/incubator-fineract 
parallelizing-and-paging-recalculate-interest-for-loans

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/469.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #469


commit 468a4cc31b97c1d179a3677352ceef2b4b137a25
Author: unknown 
Date:   2018-08-11T16:41:02Z

Implementing parallelizing and paging of recalculate interest for loans




> Parallelization of Jobs
> ---
>
> Key: FINERACT-428
> URL: https://issues.apache.org/jira/browse/FINERACT-428
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan, Savings
>Affects Versions: 1.1.0
>Reporter: Avik Ganguly
>Assignee: Markus Geiss
>Priority: Major
>  Labels: gsoc, p2, performance
> Fix For: 1.2.0
>
>
> For starters, it will be useful to have some technical configuration added as 
> job parameter for each of the below jobs, that is batch size and thread pool 
> size for executor service so this has a dependency on FINERACT-425. 
> Add migration script to add those 2 configurations to each of the following 
> jobs with the value of batch size being 500 and thread pool size being 16 :-
> Add Accrual Transactions
> Add Periodic Accrual Transactions
> Add Accrual Transactions For Loans With Income Posted As Transactions
> Generate Loan Loss Provisioning
> Post Interest for Savings
> Update Loan Summary
> This would require separation of core functionality to a separate class.
> Simplified example :-
> ```
> final ExecutorService executor = Executors.newFixedThreadPool(threadPoolSize);
> 
> final LocalDate dueDate = DateUtils.getLocalDateOfTenant();
> final Collection loansToBeRepaidData = 
> this.loanReadPlatformService
> .retrieveLoansToBeRepaidFromAdvancePayment(dueDate);
> Iterable> loansToBeRepaid = 
> Iterables.partition(loansToBeRepaidData, batchSize);
> final Authentication authentication = 
> SecurityContextHolder.getContext().getAuthentication();
> List> advancePaymentPosters = new 
> ArrayList>();
> 
> for (List subList : loansToBeRepaid) {
>   AdvancePaymentPoster poster = (AdvancePaymentPoster) 
> this.applicationContext.getBean("advancePaymentPoster");
>   poster.setLoans(subList);
>   poster.setTenant(ThreadLocalContextUtil.getTenant());
>   poster.setAuthentication(authentication);
>   poster.setCommandService(commandService);
>   advancePaymentPosters.add(Executors.callable(poster));
> }
> try {
>   List> responses = 
> executor.invokeAll(advancePaymentPosters);
> for(Future f : responses) {
>   f.get();
> }
>   } catch (InterruptedException e1) {
>   e1.printStackTrace();
>   }
> 
> executor.shutdown(); 
>  ```



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-428) Parallelization of Jobs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577847#comment-16577847
 ] 

ASF GitHub Bot commented on FINERACT-428:
-

Github user santoshconflux commented on the issue:

https://github.com/apache/fineract/pull/469
  
Hi Kumarnath,

There is one  more PR for same ticket , Fineract-428?

https://github.com/apache/fineract/pull/464

On Sat, Aug 11, 2018 at 10:14 PM, Kumaranath Fernando <
notificati...@github.com> wrote:

> Fineract-428 
>
> Parallelizing and paging of periodic accrual
> --
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/apache/fineract/pull/469
> Commit Summary
>
>- Implementing parallelizing and paging of recalculate interest for
>loans
>
> File Changes
>
>- *A* fineract-provider/src/main/java/org/apache/fineract/
>infrastructure/jobs/domain/JobParameter.java
> (84)
>- *A* fineract-provider/src/main/java/org/apache/fineract/
>infrastructure/jobs/domain/JobParameterRepository.java
> (32)
>- *M* fineract-provider/src/main/java/org/apache/fineract/
>infrastructure/jobs/service/JobRegisterServiceImpl.java
> (26)
>- *M* fineract-provider/src/main/java/org/apache/fineract/
>portfolio/loanaccount/service/LoanReadPlatformService.java
> (3)
>- *M* fineract-provider/src/main/java/org/apache/fineract/
>portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
> (46)
>- *M* fineract-provider/src/main/java/org/apache/fineract/
>portfolio/loanaccount/service/LoanSchedularService.java
> (7)
>- *M* fineract-provider/src/main/java/org/apache/fineract/
>portfolio/loanaccount/service/LoanSchedularServiceImpl.java
> (155)
>- *A* fineract-provider/src/main/java/org/apache/fineract/
>portfolio/loanaccount/service/RecalculateInterestPoster.java
> (152)
>- *A* fineract-provider/src/main/resources/sql/migrations/core_
>db/V344__parallelizing_and_paging_recalculate_interest_
>for_loans_job.sql
> (33)
>
> Patch Links:
>
>- https://github.com/apache/fineract/pull/469.patch
>- https://github.com/apache/fineract/pull/469.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> , or mute the thread
> 

> .
>



-- 
Thanks & Regards

Santosh Math

*QA Engineer*

*Conflux Technologies Pvt Ltd *
| *Office*: +91-080-41208662 |

*Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
Bengaluru, Karnataka, 560043 INDIA



> Parallelization of Jobs
> ---
>
> Key: FINERACT-428
> URL: https://issues.apache.org/jira/browse/FINERACT-428
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan, Savings
>Affects Versions: 1.1.0
>Reporter: Avik Ganguly
>Assignee: Markus Geiss
>Priority: Major
>  Labels: gsoc, p2, performance
> Fix For: 1.2.0
>
>
> For starters, it will be useful to have some technical configuration added as 
> job parameter for each of the below jobs, that is batch size and thread pool 
> size for executor service so this has a dependency on FINERACT-425. 
> Add migration script to add those 2 configurations to each of the following 
> jobs with the value of batch size being 500 and thread pool size being 16 :-
> Add Accrual Transactions
> Add Periodic Accrual Transactions
> Add Accrual Transactions For Loans With Income Posted As Transactions
> Generate Loan Loss Provisioning
> Post Interest for Savings
> Update Loan Summary
> This would require separation of core functionality to a separate class.
> Simplified example :-
> ```
> final ExecutorService executor = Executors.newF

[jira] [Commented] (FINERACT-428) Parallelization of Jobs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577849#comment-16577849
 ] 

ASF GitHub Bot commented on FINERACT-428:
-

Github user santoshconflux commented on the issue:

https://github.com/apache/fineract/pull/469
  
Hi Santosh!
Ticket, Fineract-428 will have multiple PRs since it takes into account all
jobs intended for parallelizing and paging. Each job will have a separate PR

Hope it answers your question.

Regards,
Kumaranath Fernando



On Mon, Aug 13, 2018 at 10:57 AM, Santosh Math <
sant...@confluxtechnologies.com> wrote:

> Hi Kumarnath,
>
> There is one  more PR for same ticket , Fineract-428?
>
> https://github.com/apache/fineract/pull/464
>
> On Sat, Aug 11, 2018 at 10:14 PM, Kumaranath Fernando <
> notificati...@github.com> wrote:
>
> > Fineract-428 
> >
> > Parallelizing and paging of periodic accrual
> > --
> > You can view, comment on, or merge this pull request online at:
> >
> >   https://github.com/apache/fineract/pull/469
> > Commit Summary
> >
> >- Implementing parallelizing and paging of recalculate interest for
> >loans
> >
> > File Changes
> >
> >- *A* fineract-provider/src/main/java/org/apache/fineract/
> >infrastructure/jobs/domain/JobParameter.java
> > (84)
> >- *A* fineract-provider/src/main/java/org/apache/fineract/
> >infrastructure/jobs/domain/JobParameterRepository.java
> > (32)
> >- *M* fineract-provider/src/main/java/org/apache/fineract/
> >infrastructure/jobs/service/JobRegisterServiceImpl.java
> > (26)
> >- *M* fineract-provider/src/main/java/org/apache/fineract/
> >portfolio/loanaccount/service/LoanReadPlatformService.java
> > (3)
> >- *M* fineract-provider/src/main/java/org/apache/fineract/
> >portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
> > (46)
> >- *M* fineract-provider/src/main/java/org/apache/fineract/
> >portfolio/loanaccount/service/LoanSchedularService.java
> > (7)
> >- *M* fineract-provider/src/main/java/org/apache/fineract/
> >portfolio/loanaccount/service/LoanSchedularServiceImpl.java
> > (155)
> >- *A* fineract-provider/src/main/java/org/apache/fineract/
> >portfolio/loanaccount/service/RecalculateInterestPoster.java
> > (152)
> >- *A* fineract-provider/src/main/resources/sql/migrations/core_
> >db/V344__parallelizing_and_paging_recalculate_interest_
> >for_loans_job.sql
> > (33)
> >
> > Patch Links:
> >
> >- https://github.com/apache/fineract/pull/469.patch
> >- https://github.com/apache/fineract/pull/469.diff
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub
> > , or mute the thread
> >  auth/AV9MS_TwImbrVWDae6Aas7_sNv9zpke0ks5uPwoGgaJpZM4V5OxW>
> > .
> >
>
>
>
> --
> Thanks & Regards
>
> Santosh Math
>
> *QA Engineer*
>
> *Conflux Technologies Pvt Ltd *
> | *Office*: +91-080-41208662 |
>
> *Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
> Bengaluru, Karnataka, 560043 INDIA
>



> Parallelization of Jobs
> ---
>
> Key: FINERACT-428
> URL: https://issues.apache.org/jira/browse/FINERACT-428
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan, Savings
>Affects Versions: 1.1.0
>Reporter: Avik Ganguly
>Assignee: Markus Geiss
>Priority: Major
>  Labels: gsoc, p2, performance
> Fix For: 1.2.0
>
>
> For starters, it will be useful to have some technical configuration added as 
> job parameter for each of the below jobs, that is batch size and thread pool 
> size for executor service so this has a dependency on FINERACT-425

[jira] [Commented] (FINERACT-431) Should not allow more than expected loan term based on 'number of repayments' and 'Repaid every' values.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591160#comment-16591160
 ] 

ASF GitHub Bot commented on FINERACT-431:
-

Github user asfgit closed the pull request at:

https://github.com/apache/fineract/pull/437


> Should not allow more than expected  loan term based on 'number of 
> repayments' and 'Repaid every' values.
> -
>
> Key: FINERACT-431
> URL: https://issues.apache.org/jira/browse/FINERACT-431
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Mexina Daniel
>Assignee: Markus Geiss
>Priority: Minor
>  Labels: gsoc, p2
>
> In loan application, the frequency of the loan term has to be the same with 
> the frequency of repaid every (days/weeks/months/years), by this : loan term 
> = number of repayment x repaid every.
> e.g 
> 1. Create a loan product and fill the necessary requirements (put default 
> number of repayment = 6, repaid every = 1 month)
> 2. Create a loan account to an active client and fill all necessary 
> requirement ( put loan term = 8 months), leave the number of repayment to 6.
> The system is allowing the loan term to be greater than (number of repayments 
> x repaid every) and provide the repayment schedule based on 'number of 
> repayments' and 'repaid every' values
> It should deny the submission and through an error like when you provide loan 
> term less than (number of repayments x repaid every)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-623) The restriction of product mix should apply during submission of another loan

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593472#comment-16593472
 ] 

ASF GitHub Bot commented on FINERACT-623:
-

Github user MexinaD commented on the issue:

https://github.com/apache/fineract/pull/454
  
Hello @ShruthiRajaram , thank you for your comments, am working on them


> The restriction of product mix should apply during submission of another loan
> -
>
> Key: FINERACT-623
> URL: https://issues.apache.org/jira/browse/FINERACT-623
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Mexina Daniel
>Priority: Major
>  Labels: gsoc, p2
>
> For now when you configure one loan account of Product1 not to be applied 
> when a client already have another loan account of Product2, during the 
> application of another loan account, the system accept to submit and approve 
> the loan and give the error of co-exist during disburse.
> Expected: The system should give the error of co-exist of the restricted loan 
> when a user is submitting the new loan account since the two loans should not 
> exist together.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-627) ADDING TRANSFER DATE WHEN A CLIENT IS TRANSFERED FROM ONE BRANCH TO ANOTHER

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594871#comment-16594871
 ] 

ASF GitHub Bot commented on FINERACT-627:
-

ShruthiRajaram opened a new pull request #471: FINERACT-627 back dated client 
transfer
URL: https://github.com/apache/fineract/pull/471
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ADDING TRANSFER DATE WHEN A CLIENT IS TRANSFERED FROM ONE BRANCH TO ANOTHER
> ---
>
> Key: FINERACT-627
> URL: https://issues.apache.org/jira/browse/FINERACT-627
> Project: Apache Fineract
>  Issue Type: New Feature
>  Components: Client
>Affects Versions: 1.1.0
> Environment: Ubuntu 16
>Reporter: Jimmy Jubha Mayala 
>Assignee: Shruthi  M R
>Priority: Major
>  Labels: easyfix, gsoc, p2
> Fix For: 1.2.0
>
>
> We need this feature in Mifosx. The current scenario is, when you want to 
> transfer a client from one branch to another you do not need to choose which 
> date the transfer was made, Mifos x picks the current date of the transfer. 
> so for us we find it to be a big need to have a place to select a date when 
> we are transferring a client from one branch to another. simply because most 
> of the time our clients transfer are done with back dates. This helps put a 
> real record concerning a client transfer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-623) The restriction of product mix should apply during submission of another loan

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594960#comment-16594960
 ] 

ASF GitHub Bot commented on FINERACT-623:
-

MexinaD commented on issue #454: FINERACT-623 - Restriction of product mix fix
URL: https://github.com/apache/fineract/pull/454#issuecomment-416580383
 
 
   Hello @ShruthiRajaram 
   I have already updated the PR with change of implementation, if the loan 
products should not co-exist, its enough to be checked on the time of 
application, please review


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The restriction of product mix should apply during submission of another loan
> -
>
> Key: FINERACT-623
> URL: https://issues.apache.org/jira/browse/FINERACT-623
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Mexina Daniel
>Priority: Major
>  Labels: gsoc, p2
>
> For now when you configure one loan account of Product1 not to be applied 
> when a client already have another loan account of Product2, during the 
> application of another loan account, the system accept to submit and approve 
> the loan and give the error of co-exist during disburse.
> Expected: The system should give the error of co-exist of the restricted loan 
> when a user is submitting the new loan account since the two loans should not 
> exist together.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-416) Interest to be calculated for the whole loan term given

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594961#comment-16594961
 ] 

ASF GitHub Bot commented on FINERACT-416:
-

MexinaD commented on issue #436: FINERACT-416 Interest of the whole term
URL: https://github.com/apache/fineract/pull/436#issuecomment-416581077
 
 
   Hello @ShruthiRajaram Can you help to review this too


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Interest to be calculated for the whole loan term given
> ---
>
> Key: FINERACT-416
> URL: https://issues.apache.org/jira/browse/FINERACT-416
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Mexina Daniel
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: gsoc, p1
> Fix For: 1.3.0
>
>
> As for some of the MFI practise here in our country, they specify the 
> interest for the whole loan term given, i.e their loan product have the 
> interest for the whole loan term regardless of the frequency of repayment ()
> To accomplish this in mifos, a user has to do calculation of finding an 
> interest of a month/year with respect of the loan term of that specific 
> client. This is a very tiresome work as for a day a user can have apply many 
> loans and the task of calculation make the work even harder.
> I was suggesting improvement in the loan product, to be able to allow the 
> interest rate of the whole loan term.
> Example:
> Loan product -  Development Loan
> Amount -  Min: 100,000, Max:1,000,000
> Interest - 20%
> Loan term - From 3months to 6months
> -- This means the interest given is for any loan term the client will want to 
> take the loan.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-623) The restriction of product mix should apply during submission of another loan

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595961#comment-16595961
 ] 

ASF GitHub Bot commented on FINERACT-623:
-

ShruthiRajaram commented on issue #454: FINERACT-623 - Restriction of product 
mix fix
URL: https://github.com/apache/fineract/pull/454#issuecomment-416833518
 
 
   @MexinaD  I think there is a little confusion over my last comment. I was 
completely fine with validation during disbursal and submission. All I wanted 
to convey was, change the method signature of "checkForProductMixRestrictions" 
and "checkForProductMixRestrictions" present in 
LoanWritePlatformServiceJpaRepositoryImpl, so that you can have a common method 
and call it from  "LoanApplicationWritePlatformServiceJpaRepositoryImpl" and 
"LoanWritePlatformServiceJpaRepositoryImpl". So that you handle all the 
scenarios you described previously. I believe the current change checks only 
during submission. If you want to check only during the submission and not 
during disbursal for existing loans, let me know I will approve the change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The restriction of product mix should apply during submission of another loan
> -
>
> Key: FINERACT-623
> URL: https://issues.apache.org/jira/browse/FINERACT-623
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Mexina Daniel
>Priority: Major
>  Labels: gsoc, p2
>
> For now when you configure one loan account of Product1 not to be applied 
> when a client already have another loan account of Product2, during the 
> application of another loan account, the system accept to submit and approve 
> the loan and give the error of co-exist during disburse.
> Expected: The system should give the error of co-exist of the restricted loan 
> when a user is submitting the new loan account since the two loans should not 
> exist together.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-623) The restriction of product mix should apply during submission of another loan

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595976#comment-16595976
 ] 

ASF GitHub Bot commented on FINERACT-623:
-

MexinaD commented on issue #454: FINERACT-623 - Restriction of product mix fix
URL: https://github.com/apache/fineract/pull/454#issuecomment-416836595
 
 
   Hello @ShruthiRajaram I think if the loan has already passed the state of 
approval that means the user was okay with their co-existence at the time 
he/she was approving the loan, So i want the check to be on submission 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The restriction of product mix should apply during submission of another loan
> -
>
> Key: FINERACT-623
> URL: https://issues.apache.org/jira/browse/FINERACT-623
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Mexina Daniel
>Priority: Major
>  Labels: gsoc, p2
>
> For now when you configure one loan account of Product1 not to be applied 
> when a client already have another loan account of Product2, during the 
> application of another loan account, the system accept to submit and approve 
> the loan and give the error of co-exist during disburse.
> Expected: The system should give the error of co-exist of the restricted loan 
> when a user is submitting the new loan account since the two loans should not 
> exist together.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-546) Cannot remove Group from Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607002#comment-16607002
 ] 

ASF GitHub Bot commented on FINERACT-546:
-

ShruthiRajaram opened a new pull request #473: FINERACT-546 disassociate group 
from center
URL: https://github.com/apache/fineract/pull/473
 
 
   Unable to remove group from center fixed. Since OpenJPA annotation failed to 
load the eager entities, application was unable to load the entities mapped to 
it. The fix initializes entities mapped to it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cannot remove Group from Center
> ---
>
> Key: FINERACT-546
> URL: https://issues.apache.org/jira/browse/FINERACT-546
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Groups
>Reporter: May Myint
>Assignee: Shruthi  M R
>Priority: Major
>  Labels: gci2017, group, p1
> Fix For: 1.1.0
>
>
> Unable to remove Group from Center.
> Error message "field is required. error.msg.group.not.in.center"
> https://demo.openmf.org/#/viewcenter/1175



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FINERACT-546) Cannot remove Group from Center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607133#comment-16607133
 ] 

ASF GitHub Bot commented on FINERACT-546:
-

ShruthiRajaram closed pull request #473: FINERACT-546 disassociate group from 
center
URL: https://github.com/apache/fineract/pull/473
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java
 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java
index c3a14ae7d..333ca458c 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java
@@ -22,7 +22,6 @@
 import java.util.Date;
 import java.util.HashSet;
 import java.util.LinkedHashMap;
-import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -46,10 +45,10 @@
 import org.apache.fineract.infrastructure.codes.domain.CodeValue;
 import org.apache.fineract.infrastructure.core.api.JsonCommand;
 import org.apache.fineract.infrastructure.core.data.ApiParameterError;
+import 
org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
 import 
org.apache.fineract.infrastructure.core.exception.GeneralPlatformDomainRuleException;
 import 
org.apache.fineract.infrastructure.core.exception.PlatformApiDataValidationException;
 import org.apache.fineract.infrastructure.core.service.DateUtils;
-import 
org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
 import 
org.apache.fineract.infrastructure.security.service.RandomPasswordGenerator;
 import org.apache.fineract.organisation.office.domain.Office;
 import org.apache.fineract.organisation.staff.domain.Staff;
@@ -108,9 +107,9 @@
 
 @OneToMany(fetch = FetchType.EAGER)
 @JoinColumn(name = "parent_id")
-private final List groupMembers = new LinkedList<>();
-
-@ManyToMany
+private Set groupMembers = new HashSet<>();
+
+   @ManyToMany
 @JoinTable(name = "m_group_client", joinColumns = @JoinColumn(name = 
"group_id"), inverseJoinColumns = @JoinColumn(name = "client_id"))
 private Set clientMembers = new HashSet<>();
 
@@ -577,7 +576,7 @@ public boolean hasStaff() {
 }
 
 public List disassociateGroups(Set groupMembersSet) {
-
+   
 final List differences = new ArrayList<>();
 for (final Group group : groupMembersSet) {
 if (hasGroupAsMember(group)) {
@@ -744,4 +743,13 @@ public void updateAccountNo(final String 
accountIdentifier) {
 this.accountNumber = accountIdentifier;
 this.accountNumberRequiresAutoGeneration = false;
 }
+
+   public Set getGroupMembers() {
+   return groupMembers;
+   }
+
+   public void setGroupMembers(Set groupMembers) {
+   this.groupMembers = groupMembers;
+   }
+
 }
\ No newline at end of file
diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/GroupRepositoryWrapper.java
 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/GroupRepositoryWrapper.java
index c86391344..73e131136 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/GroupRepositoryWrapper.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/GroupRepositoryWrapper.java
@@ -66,4 +66,13 @@ public void delete(final Group entity) {
 public void flush() {
 this.repository.flush();
 }
+
+public Group findOneAndLoadAssociatedMembers(final Long id) {
+final Group entity = this.repository.findOne(id);
+if (entity == null) { throw new GroupNotFoundException(id); }
+else{
+   entity.getGroupMembers().size();
+}
+return entity;
+}
 }
\ No newline at end of file
diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/GroupingTypesWritePlatformServiceJpaRepositoryImpl.java
 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/GroupingTypesWritePlatformServiceJpaRepositoryImpl.java
index 2616c27cb..d2f92d14f 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/GroupingTypesWritePlatformServiceJpaRepositoryImpl.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/GroupingTypesWritePlatformServiceJpaRepositoryImpl.java
@@ -877,14 +877,14 @@ public CommandProcessingResult 
associateGroupsToCenter(final Long centerId, fina
 public CommandProcessingResult disassociateG