[jira] [Commented] (FINERACT-1203) Fix broken Executable WAR (and unify & ditch Executable JAR?)
[
https://issues.apache.org/jira/browse/FINERACT-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214290#comment-17214290
]
Aleksandar Vidakovic commented on FINERACT-1203:
[~vorburger] I think this is solved. Please check the PR.
> Fix broken Executable WAR (and unify & ditch Executable JAR?)
> -
>
> Key: FINERACT-1203
> URL: https://issues.apache.org/jira/browse/FINERACT-1203
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Aleksandar Vidakovic
>Priority: Minor
> Attachments: war.log
>
>
> I've noticed that the WAR we build is not a traditional Tomcat only WAR, but
> a Spring Boot Executable WAR - but a broken one! :( Whereas our Executable
> JAR works of course, our WAR with {{java -jar
> fineract-provider/build/libs/fineract-provider.war}} fails to start, see
> attached {{war.log}}.
> [~ptuomola] and [~aleks] perhaps this is something one of you would like to
> look into?
> If you can fix this, then it poses the question why we would build and
> document and distribute and support two different artifacts. My vote, if this
> can be fixed, could be to unify on only having a (both "traditional AND
> Executable") WAR and no JAR. Unless there are reasons why that may be stupid,
> and both are useful, even if the problem above was fixed. Thoughts?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1203) Fix broken Executable WAR (and unify & ditch Executable JAR?)
[
https://issues.apache.org/jira/browse/FINERACT-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214223#comment-17214223
]
Aleksandar Vidakovic commented on FINERACT-1203:
[~vorburger] will take that one ;)
> Fix broken Executable WAR (and unify & ditch Executable JAR?)
> -
>
> Key: FINERACT-1203
> URL: https://issues.apache.org/jira/browse/FINERACT-1203
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Priority: Minor
> Attachments: war.log
>
>
> I've noticed that the WAR we build is not a traditional Tomcat only WAR, but
> a Spring Boot Executable WAR - but a broken one! :( Whereas our Executable
> JAR works of course, our WAR with {{java -jar
> fineract-provider/build/libs/fineract-provider.war}} fails to start, see
> attached {{war.log}}.
> [~ptuomola] and [~aleks] perhaps this is something one of you would like to
> look into?
> If you can fix this, then it poses the question why we would build and
> document and distribute and support two different artifacts. My vote, if this
> can be fixed, could be to unify on only having a (both "traditional AND
> Executable") WAR and no JAR. Unless there are reasons why that may be stupid,
> and both are useful, even if the problem above was fixed. Thoughts?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1203) Fix broken Executable WAR (and unify & ditch Executable JAR?)
[
https://issues.apache.org/jira/browse/FINERACT-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214215#comment-17214215
]
Michael Vorburger commented on FINERACT-1203:
-
[~aleks] I had posted my comment concurrently with yours. So yes, I'm on board
with "strip all Spring Boot startup magic from the WAR file". If you want to
raise a PR for that (and just that, small! LOL), that seems useful to me. We
could even just do that as the solution "forever", and close this issue if we
make that change, from my side (unless either of you thinks we should change it
later, if we could; but we don't have to).
> Fix broken Executable WAR (and unify & ditch Executable JAR?)
> -
>
> Key: FINERACT-1203
> URL: https://issues.apache.org/jira/browse/FINERACT-1203
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Priority: Minor
> Attachments: war.log
>
>
> I've noticed that the WAR we build is not a traditional Tomcat only WAR, but
> a Spring Boot Executable WAR - but a broken one! :( Whereas our Executable
> JAR works of course, our WAR with {{java -jar
> fineract-provider/build/libs/fineract-provider.war}} fails to start, see
> attached {{war.log}}.
> [~ptuomola] and [~aleks] perhaps this is something one of you would like to
> look into?
> If you can fix this, then it poses the question why we would build and
> document and distribute and support two different artifacts. My vote, if this
> can be fixed, could be to unify on only having a (both "traditional AND
> Executable") WAR and no JAR. Unless there are reasons why that may be stupid,
> and both are useful, even if the problem above was fixed. Thoughts?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1203) Fix broken Executable WAR (and unify & ditch Executable JAR?)
[
https://issues.apache.org/jira/browse/FINERACT-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214211#comment-17214211
]
Michael Vorburger commented on FINERACT-1203:
-
Ah, yes - thanks for the reminder. IMHO totally NOT worth digging into how to
fix up OpenJPA class loading. Let's just mark this one Blocked By FINERACT-849.
One small thought: Would it be relatively trivial to NOT make the build not
have the WAR file be a Spring Boot Executable, just a "plain good ol' WAR"?
It's not super important, could be slightly less confusing than our current
solution.
> Fix broken Executable WAR (and unify & ditch Executable JAR?)
> -
>
> Key: FINERACT-1203
> URL: https://issues.apache.org/jira/browse/FINERACT-1203
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Priority: Major
> Attachments: war.log
>
>
> I've noticed that the WAR we build is not a traditional Tomcat only WAR, but
> a Spring Boot Executable WAR - but a broken one! :( Whereas our Executable
> JAR works of course, our WAR with {{java -jar
> fineract-provider/build/libs/fineract-provider.war}} fails to start, see
> attached {{war.log}}.
> [~ptuomola] and [~aleks] perhaps this is something one of you would like to
> look into?
> If you can fix this, then it poses the question why we would build and
> document and distribute and support two different artifacts. My vote, if this
> can be fixed, could be to unify on only having a (both "traditional AND
> Executable") WAR and no JAR. Unless there are reasons why that may be stupid,
> and both are useful, even if the problem above was fixed. Thoughts?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1203) Fix broken Executable WAR (and unify & ditch Executable JAR?)
[
https://issues.apache.org/jira/browse/FINERACT-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214209#comment-17214209
]
Aleksandar Vidakovic commented on FINERACT-1203:
[~vorburger] I think 2 artifacts are actually OK; my personal preference is
actually the JAR artifact, but I can see that some users might want to deploy
Fineract in an existing infrastructure (JBoss, Jetty, Undertow...); I would
actually strip all Spring Boot startup magic from the WAR file. That way we
could say JAR = batteries included, WAR = requires an Java application
container.
> Fix broken Executable WAR (and unify & ditch Executable JAR?)
> -
>
> Key: FINERACT-1203
> URL: https://issues.apache.org/jira/browse/FINERACT-1203
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Priority: Major
> Attachments: war.log
>
>
> I've noticed that the WAR we build is not a traditional Tomcat only WAR, but
> a Spring Boot Executable WAR - but a broken one! :( Whereas our Executable
> JAR works of course, our WAR with {{java -jar
> fineract-provider/build/libs/fineract-provider.war}} fails to start, see
> attached {{war.log}}.
> [~ptuomola] and [~aleks] perhaps this is something one of you would like to
> look into?
> If you can fix this, then it poses the question why we would build and
> document and distribute and support two different artifacts. My vote, if this
> can be fixed, could be to unify on only having a (both "traditional AND
> Executable") WAR and no JAR. Unless there are reasons why that may be stupid,
> and both are useful, even if the problem above was fixed. Thoughts?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1203) Fix broken Executable WAR (and unify & ditch Executable JAR?)
[
https://issues.apache.org/jira/browse/FINERACT-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214187#comment-17214187
]
Petri Tuomola commented on FINERACT-1203:
-
Hi [~vorburger] - this is the issue I mentioned when I was getting Spring Boot
to work at all in May, from my original email:
"bootWar creates a WAR that can be deployed to an external Tomcat and works as
expected. However the WAR file can’t be started directly from command line, as
OpenJPA doesn’t seem to be able to find persistence-enhanced classes from
within a WAR (looking at the source, it seems to be hardcoded to only handle
classes from filesystem or JAR)."
So assuming my analysis back then was correct, some clever magic would be
required to get this working - I suppose an option would be to raise a PR
against OpenJPA, or alternatively complete the migration to EclipseLink...
> Fix broken Executable WAR (and unify & ditch Executable JAR?)
> -
>
> Key: FINERACT-1203
> URL: https://issues.apache.org/jira/browse/FINERACT-1203
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Priority: Major
> Attachments: war.log
>
>
> I've noticed that the WAR we build is not a traditional Tomcat only WAR, but
> a Spring Boot Executable WAR - but a broken one! :( Whereas our Executable
> JAR works of course, our WAR with {{java -jar
> fineract-provider/build/libs/fineract-provider.war}} fails to start, see
> attached {{war.log}}.
> [~ptuomola] and [~aleks] perhaps this is something one of you would like to
> look into?
> If you can fix this, then it poses the question why we would build and
> document and distribute and support two different artifacts. My vote, if this
> can be fixed, could be to unify on only having a (both "traditional AND
> Executable") WAR and no JAR. Unless there are reasons why that may be stupid,
> and both are useful, even if the problem above was fixed. Thoughts?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1203) Fix broken Executable WAR (and unify & ditch Executable JAR?)
[
https://issues.apache.org/jira/browse/FINERACT-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214142#comment-17214142
]
Michael Vorburger commented on FINERACT-1203:
-
What we decide to do here is indirectly relevant for some documentation I'm
planning to contribute re. FINERACT-1177.
> Fix broken Executable WAR (and unify & ditch Executable JAR?)
> -
>
> Key: FINERACT-1203
> URL: https://issues.apache.org/jira/browse/FINERACT-1203
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Priority: Major
> Attachments: war.log
>
>
> I've noticed that the WAR we build is not a traditional Tomcat only WAR, but
> a Spring Boot Executable WAR - but a broken one! :( Whereas our Executable
> JAR works of course, our WAR with {{java -jar
> fineract-provider/build/libs/fineract-provider.war}} fails to start, see
> attached.
> [~ptuomola] and [~aleks] perhaps this is something one of you would like to
> look into?
> If you can fix this, then it poses the question why we would build and
> document and distribute and support two different artifacts. My vote, if this
> can be fixed, could be to unify on only having a (both "traditional AND
> Executable") WAR and no JAR. Unless there are reasons why that may be stupid,
> and both are useful, even if the problem above was fixed. Thoughts?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
