[jira] [Commented] (FLINK-9404) Adapter viewfs in BucketingSink when verify that truncate actually works
[ https://issues.apache.org/jira/browse/FLINK-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482244#comment-16482244 ] ASF GitHub Bot commented on FLINK-9404: --- GitHub user maqingxiang opened a pull request: https://github.com/apache/flink/pull/6050 [FLINK-9404][flink-connector-filesystem] Adapter viewfs in BucketingSink when verify that truncate actually works You can merge this pull request into a Git repository by running: $ git pull https://github.com/maqingxiang/flink fix-BucketingSink-reflectTruncate Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6050.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6050 commit 829d085e5ad33da3ca8cd6288bb10c73aec7f78f Author: maqingxiang-it Date: 2018-05-21T04:28:59Z modify Path in reflectTruncate > Adapter viewfs in BucketingSink when verify that truncate actually works > > > Key: FLINK-9404 > URL: https://issues.apache.org/jira/browse/FLINK-9404 > Project: Flink > Issue Type: Bug >Reporter: xymaqingxiang >Priority: Major > > Hi: > > when the viewfs function is enabled, the following operation will report > errors, > "new Path(UUID.randomUUID().toString())" > Hence, I think that we can add the bashPath, like this: > "new Path(basePath, UUID.randomUUID().toString())" > > thanks, > Ma Qingxiang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink pull request #6050: [FLINK-9404][flink-connector-filesystem] Adapter v...
GitHub user maqingxiang opened a pull request: https://github.com/apache/flink/pull/6050 [FLINK-9404][flink-connector-filesystem] Adapter viewfs in BucketingSink when verify that truncate actually works You can merge this pull request into a Git repository by running: $ git pull https://github.com/maqingxiang/flink fix-BucketingSink-reflectTruncate Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6050.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6050 commit 829d085e5ad33da3ca8cd6288bb10c73aec7f78f Author: maqingxiang-it Date: 2018-05-21T04:28:59Z modify Path in reflectTruncate ---
[jira] [Created] (FLINK-9404) Adapter viewfs in BucketingSink when verify that truncate actually works
xymaqingxiang created FLINK-9404: Summary: Adapter viewfs in BucketingSink when verify that truncate actually works Key: FLINK-9404 URL: https://issues.apache.org/jira/browse/FLINK-9404 Project: Flink Issue Type: Bug Reporter: xymaqingxiang Hi: when the viewfs function is enabled, the following operation will report errors, "new Path(UUID.randomUUID().toString())" Hence, I think that we can add the bashPath, like this: "new Path(basePath, UUID.randomUUID().toString())" thanks, Ma Qingxiang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink pull request #6049: [FLINK-9398][Client] Fix CLI list running job retu...
GitHub user walterddr opened a pull request: https://github.com/apache/flink/pull/6049 [FLINK-9398][Client] Fix CLI list running job returns all except scheduled jobs ## What is the purpose of the change This PR fixes CLI command `bin/flink list -r` returning all except scheduled jobs. ## Brief change log Change the behavior of `bin/flink list` to - Adding in a `-a` option to list all jobs. Including `CREATED`, `RUNNING` & `RESTARTING` - Fixing `-r` option to list only `RUNNING` and `RESTARTING`. - Internally map `-a` with `other` job type so it won't affect the behavior of explicit listing options when adding other options to `list` command. ## Verifying this change This change added tests and can be verified as follows: - Added unit-test to verify `-a` options. - Added `ListOptions` unit-test suite which never existed before. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? yes - If yes, how is the feature documented? documented in `cli.md` You can merge this pull request into a Git repository by running: $ git pull https://github.com/walterddr/flink FLINK-9398 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6049.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6049 commit d742f3ec5ffd4b411162db234e108a496a4f5aaa Author: Rong Rong Date: 2018-05-20T14:29:56Z fix CLI list options showing all jobs instead of just running / restarting jobs commit e6d827700427a3f31a699ff02cb5b9906715c629 Author: Rong Rong Date: 2018-05-20T23:45:18Z adding in documentation for list all jobs option ---
[jira] [Commented] (FLINK-9398) Flink CLI list running job returns all jobs except in CREATE state
[ https://issues.apache.org/jira/browse/FLINK-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482080#comment-16482080 ] ASF GitHub Bot commented on FLINK-9398: --- GitHub user walterddr opened a pull request: https://github.com/apache/flink/pull/6049 [FLINK-9398][Client] Fix CLI list running job returns all except scheduled jobs ## What is the purpose of the change This PR fixes CLI command `bin/flink list -r` returning all except scheduled jobs. ## Brief change log Change the behavior of `bin/flink list` to - Adding in a `-a` option to list all jobs. Including `CREATED`, `RUNNING` & `RESTARTING` - Fixing `-r` option to list only `RUNNING` and `RESTARTING`. - Internally map `-a` with `other` job type so it won't affect the behavior of explicit listing options when adding other options to `list` command. ## Verifying this change This change added tests and can be verified as follows: - Added unit-test to verify `-a` options. - Added `ListOptions` unit-test suite which never existed before. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? yes - If yes, how is the feature documented? documented in `cli.md` You can merge this pull request into a Git repository by running: $ git pull https://github.com/walterddr/flink FLINK-9398 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6049.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6049 commit d742f3ec5ffd4b411162db234e108a496a4f5aaa Author: Rong Rong Date: 2018-05-20T14:29:56Z fix CLI list options showing all jobs instead of just running / restarting jobs commit e6d827700427a3f31a699ff02cb5b9906715c629 Author: Rong Rong Date: 2018-05-20T23:45:18Z adding in documentation for list all jobs option > Flink CLI list running job returns all jobs except in CREATE state > -- > > Key: FLINK-9398 > URL: https://issues.apache.org/jira/browse/FLINK-9398 > Project: Flink > Issue Type: Bug > Components: Client >Affects Versions: 1.5.0 >Reporter: Rong Rong >Assignee: Rong Rong >Priority: Major > > See: > https://github.com/apache/flink/blob/4922ced71a307a26b9f5070b41f72fd5d93b0ac8/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java#L437-L445 > Seems like CLI command: *flink list -r* returns all jobs except jobs in > *CREATE* state. which conflicts with the CLI description: *Running/Restarting > Jobs*. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9403) Documentation continues to refer to removed methods
[ https://issues.apache.org/jira/browse/FLINK-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482041#comment-16482041 ] ASF GitHub Bot commented on FLINK-9403: --- GitHub user eliaslevy opened a pull request: https://github.com/apache/flink/pull/6048 [FLINK-9403] [docs] Remove obsolete documentation *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.* ## Contribution Checklist - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue. - Name the pull request in the form "[FLINK-] [component] Title of the pull request", where *FLINK-* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component. Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices). - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message (including the JIRA id) - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of the change Remove obsolete `enableTimestamps`, `disableTimestamps`, and `areTimestampsEnabled` documentation. ## Brief change log ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable You can merge this pull request into a Git repository by running: $ git pull https://github.com/eliaslevy/flink flink-9403 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6048.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6048 commit 2e2778cea4eb5d7f97c8d4422f1b8ee823912f87 Author: Elias Levy Date: 2018-05-20T21:36:11Z [FLINK-9403] [docs] Remove obsolete documentation > Documentation continues to refer to removed methods > --- > > Key: FLINK-9403 > URL: https://issues.apache.org/jira/browse/FLINK-9403 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.6.0 >Reporter: Elias Levy >Priority: Minor > > {{org.apache.flink.api.common.ExecutionConfig}} no longer has the > {{enableTimestamps}}, {{disableTimestamps}}, and {{areTimestampsEnabled}} > methods. They were removed in [this > commit|https://github.com/apache/flink/commit/ceb64248daab04b01977ff02516696e4398d656e]. > The
[GitHub] flink pull request #6048: [FLINK-9403] [docs] Remove obsolete documentation
GitHub user eliaslevy opened a pull request: https://github.com/apache/flink/pull/6048 [FLINK-9403] [docs] Remove obsolete documentation *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.* ## Contribution Checklist - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue. - Name the pull request in the form "[FLINK-] [component] Title of the pull request", where *FLINK-* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component. Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices). - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message (including the JIRA id) - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of the change Remove obsolete `enableTimestamps`, `disableTimestamps`, and `areTimestampsEnabled` documentation. ## Brief change log ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable You can merge this pull request into a Git repository by running: $ git pull https://github.com/eliaslevy/flink flink-9403 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6048.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6048 commit 2e2778cea4eb5d7f97c8d4422f1b8ee823912f87 Author: Elias Levy Date: 2018-05-20T21:36:11Z [FLINK-9403] [docs] Remove obsolete documentation ---
[jira] [Updated] (FLINK-9403) Documentation continues to refer to removed methods
[ https://issues.apache.org/jira/browse/FLINK-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elias Levy updated FLINK-9403: -- Description: {{org.apache.flink.api.common.ExecutionConfig}} no longer has the {{enableTimestamps}}, {{disableTimestamps}}, and {{areTimestampsEnabled}} methods. They were removed in [this commit|https://github.com/apache/flink/commit/ceb64248daab04b01977ff02516696e4398d656e]. There are referenced in the Execution Parameters section of the Flink DataStream API Programming Guide page. was:{{org.apache.flink.api.common.ExecutionConfig}} no longer has the {{enableTimestamps}}, {{disableTimestamps}}, and {{areTimestampsEnabled}} methods. They were removed in [this commit|https://github.com/apache/flink/commit/ceb64248daab04b01977ff02516696e4398d656e]. > Documentation continues to refer to removed methods > --- > > Key: FLINK-9403 > URL: https://issues.apache.org/jira/browse/FLINK-9403 > Project: Flink > Issue Type: Bug > Components: Documentation >Affects Versions: 1.6.0 >Reporter: Elias Levy >Priority: Minor > > {{org.apache.flink.api.common.ExecutionConfig}} no longer has the > {{enableTimestamps}}, {{disableTimestamps}}, and {{areTimestampsEnabled}} > methods. They were removed in [this > commit|https://github.com/apache/flink/commit/ceb64248daab04b01977ff02516696e4398d656e]. > There are referenced in the Execution Parameters section of the Flink > DataStream API Programming Guide page. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (FLINK-9403) Documentation continues to refer to removed methods
Elias Levy created FLINK-9403: - Summary: Documentation continues to refer to removed methods Key: FLINK-9403 URL: https://issues.apache.org/jira/browse/FLINK-9403 Project: Flink Issue Type: Bug Components: Documentation Affects Versions: 1.6.0 Reporter: Elias Levy {{org.apache.flink.api.common.ExecutionConfig}} no longer has the {{enableTimestamps}}, {{disableTimestamps}}, and {{areTimestampsEnabled}} methods. They were removed in [this commit|https://github.com/apache/flink/commit/ceb64248daab04b01977ff02516696e4398d656e]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9168) Pulsar Sink Connector
[ https://issues.apache.org/jira/browse/FLINK-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481893#comment-16481893 ] ASF GitHub Bot commented on FLINK-9168: --- Github user XiaoZYang commented on the issue: https://github.com/apache/flink/pull/5845 @sijie would you mind help reviewing this commit? > Pulsar Sink Connector > - > > Key: FLINK-9168 > URL: https://issues.apache.org/jira/browse/FLINK-9168 > Project: Flink > Issue Type: New Feature > Components: Streaming Connectors >Affects Versions: 1.6.0 >Reporter: Zongyang Xiao >Priority: Minor > Fix For: 1.6.0 > > > Flink does not provide a sink connector for Pulsar. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9168) Pulsar Sink Connector
[ https://issues.apache.org/jira/browse/FLINK-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481894#comment-16481894 ] ASF GitHub Bot commented on FLINK-9168: --- Github user XiaoZYang closed the pull request at: https://github.com/apache/flink/pull/5845 > Pulsar Sink Connector > - > > Key: FLINK-9168 > URL: https://issues.apache.org/jira/browse/FLINK-9168 > Project: Flink > Issue Type: New Feature > Components: Streaming Connectors >Affects Versions: 1.6.0 >Reporter: Zongyang Xiao >Priority: Minor > Fix For: 1.6.0 > > > Flink does not provide a sink connector for Pulsar. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user XiaoZYang commented on the issue: https://github.com/apache/flink/pull/5845 @sijie would you mind help reviewing this commit? ---
[GitHub] flink pull request #5845: [FLINK-9168][flink-connectors]Pulsar Sink connecto...
Github user XiaoZYang closed the pull request at: https://github.com/apache/flink/pull/5845 ---
[jira] [Commented] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)
[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481874#comment-16481874 ] ASF GitHub Bot commented on FLINK-8500: --- Github user FredTing commented on the issue: https://github.com/apache/flink/pull/5958 Closing this PR because new insights > Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher) > --- > > Key: FLINK-8500 > URL: https://issues.apache.org/jira/browse/FLINK-8500 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Affects Versions: 1.4.0 >Reporter: yanxiaobin >Priority: Major > Fix For: 1.6.0 > > Attachments: image-2018-01-30-14-58-58-167.png, > image-2018-01-31-10-48-59-633.png > > > The method deserialize of KeyedDeserializationSchema needs a parameter > 'kafka message timestamp' (from ConsumerRecord) .In some business scenarios, > this is useful! > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink issue #5958: [FLINK-8500] Get the timestamp of the Kafka message from ...
Github user FredTing commented on the issue: https://github.com/apache/flink/pull/5958 Closing this PR because new insights ---
[jira] [Commented] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)
[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481875#comment-16481875 ] ASF GitHub Bot commented on FLINK-8500: --- Github user FredTing closed the pull request at: https://github.com/apache/flink/pull/5958 > Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher) > --- > > Key: FLINK-8500 > URL: https://issues.apache.org/jira/browse/FLINK-8500 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector >Affects Versions: 1.4.0 >Reporter: yanxiaobin >Priority: Major > Fix For: 1.6.0 > > Attachments: image-2018-01-30-14-58-58-167.png, > image-2018-01-31-10-48-59-633.png > > > The method deserialize of KeyedDeserializationSchema needs a parameter > 'kafka message timestamp' (from ConsumerRecord) .In some business scenarios, > this is useful! > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink pull request #5958: [FLINK-8500] Get the timestamp of the Kafka messag...
Github user FredTing closed the pull request at: https://github.com/apache/flink/pull/5958 ---