[GitHub] flink pull request #:
Github user mindprince commented on the pull request: https://github.com/apache/flink/commit/6342d6db1de5f38a921732e35abd83e6c5b9305a#commitcomment-20615018 In flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java: In flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java on line 130: I thought `allowedLateness` affected when we purged windows. Wouldn't this result in keeping processing time windows around for longer than we should? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #:
Github user mindprince commented on the pull request: https://github.com/apache/flink/commit/6342d6db1de5f38a921732e35abd83e6c5b9305a#commitcomment-20600038 In flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java: In flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java on line 130: @StephanEwen This would set allowedLateness for Processing time windows as well. Do we want that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2929: [FLINK-5247] Fix incorrect check in allowedLateness() met...
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2929 Merged in https://github.com/apache/flink/commit/87af84194911eb1e0c3b3a894bb3f04b628fbf11 and https://github.com/apache/flink/commit/4697b97a0101cf04b43c4a6e4887adba10b4a69a --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2929: [FLINK-5247] Fix incorrect check in allowedLatenes...
Github user mindprince closed the pull request at: https://github.com/apache/flink/pull/2929 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2929: [FLINK-5247] Fix incorrect check in allowedLateness() met...
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2929 Thanks for the review @kl0u I didn't do it because there was no logger defined in the file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2929: [FLINK-5247] Fix incorrect check in allowedLateness() met...
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2929 Ping @aljoscha --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2981: [docker] improve Dockerfile host configuration
Github user mindprince commented on a diff in the pull request: https://github.com/apache/flink/pull/2981#discussion_r93824021 --- Diff: flink-contrib/docker-flink/docker-entrypoint.sh --- @@ -40,3 +39,6 @@ elif [ "$1" = "taskmanager" ]; then else $@ fi + +# prevent script to exit +tail -f /dev/null --- End diff -- Why is this needed? https://github.com/apache/flink/blob/master/flink-contrib/docker-flink/Dockerfile#L49 already prevents the container from exiting till the daemon dies. This on the other hand will never let the container exit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2940: [FLINK-5258] [docs] reorganize the docs to improve naviga...
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2940 We seem to have lost changes from https://github.com/apache/flink/commit/c024b0b6cae16a0b668d864c77e923820c262087 and https://github.com/apache/flink/commit/91414d9611a5a14d4d73ae5ea090c16406dcf025 during the reorg. :-( I wonder if we lost more such changes. cc - @alpinegizmo @fhueske @mxm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2951: [docs] clarify default restart behavior when checkpointin...
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2951 Also, this PR is open but the change is already there in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...
Github user mindprince closed the pull request at: https://github.com/apache/flink/pull/2954 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2954: [docs] Note that numberOfExecutionRetries and executionRe...
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2954 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...
Github user mindprince commented on a diff in the pull request: https://github.com/apache/flink/pull/2954#discussion_r91163739 --- Diff: docs/setup/fault_tolerance.md --- @@ -45,9 +45,6 @@ To enable checkpointing, call `enableCheckpointing(n)` on the `StreamExecutionEn Other parameters for checkpointing include: -- *Number of retries*: The `setNumberOfExecutionRerties()` method defines how many times the job is restarted after a failure. --- End diff -- Removing from here because it will be taken care in https://github.com/apache/flink/pull/2951/files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2954: [docs] Note that numberOfExecutionRetries and executionRe...
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2954 cc - @mxm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...
Github user mindprince commented on a diff in the pull request: https://github.com/apache/flink/pull/2954#discussion_r91163826 --- Diff: docs/setup/fault_tolerance.md --- @@ -345,20 +342,6 @@ env.setRestartStrategy(RestartStrategies.fixedDelayRestart( - Restart Attempts --- End diff -- These were mostly the same content as above and made it very harder to read. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...
GitHub user mindprince opened a pull request: https://github.com/apache/flink/pull/2954 [docs] Note that numberOfExecutionRetries and executionRetryDelay are deprecated And some other minor fixes and deduplication. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mindprince/flink docs-fix-3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2954.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2954 commit dbd08ea10e2261b060584d1dd8059f97bbac35ae Author: Rohit Agarwal <mindpri...@gmail.com> Date: 2016-12-06T20:21:38Z [docs] Note that numberOfExecutionRetries and executionRetryDelay are deprecated. And some other minor fixes and deduplication. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2929: [FLINK-5247] Fix check to make sure that we throw error w...
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2929 cc - @kl0u, @aljoscha for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2929: [FLINK-5247] Fix check to make sure that we throw ...
GitHub user mindprince opened a pull request: https://github.com/apache/flink/pull/2929 [FLINK-5247] Fix check to make sure that we throw error when allowed lateness is set for non event-time windows. Also, fix outdated documentation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mindprince/flink FLINK-5247-allowed-lateness Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2929.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2929 commit 10d523865e07df61e5a1c2b35e2201b498c46426 Author: Rohit Agarwal <mindpri...@gmail.com> Date: 2016-12-03T20:15:45Z [FLINK-5247] Fix check to make sure that we throw error when allowed lateness is set for non event-time windows. Also, fix outdated documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2927: [docs] Replace broken link.
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2927 Added another unrelated doc fix to this PR instead of creating a new PR. Let me know if that's not fine and I will create another PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2927: [docs] Replace broken link.
GitHub user mindprince opened a pull request: https://github.com/apache/flink/pull/2927 [docs] Replace broken link. This variable was removed in dc5062557a55 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mindprince/flink docs-fix-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2927.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2927 commit 5c4eeeb43fe987788c08459d17c912b7fc90e898 Author: Rohit Agarwal <mindpri...@gmail.com> Date: 2016-12-02T23:01:00Z [docs] Replace broken link. This variable was removed in dc5062557a55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2834: [docs] Fix broken links and incorrect examples
GitHub user mindprince opened a pull request: https://github.com/apache/flink/pull/2834 [docs] Fix broken links and incorrect examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/mindprince/flink docs-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2834.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2834 commit 8c22d8d137b4aea95d3c93046fb98ce788f15f04 Author: Rohit Agarwal <mindpri...@gmail.com> Date: 2016-11-19T03:27:26Z [docs] Fix example in kafka connector documenation. print() returns DataStreamSink not DataStream commit 86dce780bb6aaba88ff5d216730820c3d3a29546 Author: Rohit Agarwal <mindpri...@gmail.com> Date: 2016-11-19T08:41:34Z [docs] Fix return type of keyBy() commit 371e9889748da41fcc4bea37eacf334aa536b321 Author: Rohit Agarwal <mindpri...@gmail.com> Date: 2016-11-19T08:06:39Z [docs] Fix broken links. I used https://github.com/wummel/linkchecker to find broken links. linkchecker --no-follow-url '^(?!https://ci.apache.org/projects/flink/flink-docs-master).*$' https://ci.apache.org/projects/flink/flink-docs-master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2821: [MINOR][DOC] Fix incorrect URL
GitHub user mindprince opened a pull request: https://github.com/apache/flink/pull/2821 [MINOR][DOC] Fix incorrect URL You can merge this pull request into a Git repository by running: $ git pull https://github.com/mindprince/flink patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2821.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2821 commit 26cd26d7e81960f7ada770a069984ed3a3e76248 Author: Rohit Agarwal <mindpri...@gmail.com> Date: 2016-11-17T00:49:57Z [MINOR][DOC] Fix incorrect URL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
