[GitHub] flink issue #4683: [FLINK-5944] Support reading of Snappy files
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4683 @aljoscha @haohui , thank you for your comments. Marked hadoop dependency as provided, set Hadoop codec as default one ---
[GitHub] flink pull request #4683: [FLINK-5944] Support reading of Snappy files
Github user mlipkovich commented on a diff in the pull request:
https://github.com/apache/flink/pull/4683#discussion_r141424281
--- Diff: flink-core/pom.xml ---
@@ -52,6 +52,12 @@ under the License.
flink-shaded-asm
+
+ org.apache.flink
+ flink-shaded-hadoop2
+ ${project.version}
+
--- End diff --
Thanks for your comment Aljoscha,
So there are at least three ways on how to achieve it: either mark this
dependency as 'provided', move Hadoop Snappy Codec related classes to
flink-java module or move it to some separate module as suggested @haohui, but
I'm not sure what should be inside this module
---
[GitHub] flink pull request #4683: [FLINK-5944] Support reading of Snappy files
Github user mlipkovich commented on a diff in the pull request:
https://github.com/apache/flink/pull/4683#discussion_r140833786
--- Diff: flink-core/pom.xml ---
@@ -52,6 +52,12 @@ under the License.
flink-shaded-asm
+
+ org.apache.flink
+ flink-shaded-hadoop2
+ ${project.version}
+
--- End diff --
Yes, it is a good point to make Hadoop Snappy a default codec. I think we
still could support a Xerial Snappy since it comes for free. I will do these
changes once we agree on dependencies
Regarding to separate module what would be the content of this model?
As I understand a user which would like to read HDFS files will need
flink-java module anyway since it contains Hadoop wrappers like
HadoopInputSplit and so on. How do you think if it makes sense to put this
Hadoop codec there?
---
[GitHub] flink pull request #4683: [FLINK-5944] Support reading of Snappy files
Github user mlipkovich commented on a diff in the pull request:
https://github.com/apache/flink/pull/4683#discussion_r140652438
--- Diff: flink-core/pom.xml ---
@@ -52,6 +52,12 @@ under the License.
flink-shaded-asm
+
+ org.apache.flink
+ flink-shaded-hadoop2
+ ${project.version}
+
--- End diff --
What do you think about adding this dependency to compile-time only?
Regarding to difference between codecs as I understand the thing is that
Snappy compressed files are not splittable. So Hadoop splits raw files into
blocks and compresses each block separately using regular Snappy. If you
download the whole Hadoop Snappy compressed file regular Snappy will not be
able to decompress it since it's not aware of block boundaries
---
[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 Thanks! Closing it ---
[GitHub] flink pull request #4655: [FLINK-7567]: Removed keepPartitioning parameter f...
Github user mlipkovich closed the pull request at: https://github.com/apache/flink/pull/4655 ---
[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 Hi @aljoscha It turned out that exclude filter works if we escape dollar signs. I commited these changes, but I believe it still should be fixed by japicmp What do you think about merging this PR? ---
[GitHub] flink issue #4630: [FLINK-6733] Remove commented out AvgAggregationFunction....
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4630 @zentol thanks for your comment. As I understand I can't merge it without a formal review. May I ask you to review it? ---
[GitHub] flink pull request #4683: [FLINK-5944] Support reading of Snappy files
GitHub user mlipkovich opened a pull request: https://github.com/apache/flink/pull/4683 [FLINK-5944] Support reading of Snappy files ## What is the purpose of the change Support reading of Snappy compressed text files (both Xerial and Hadoop snappy) ## Brief change log - *Added InputStreamFactories for Xerial and Hadoop snappy* - *Added config parameter to control whether Xerial or Hadoop snappy should be used* ## Verifying this change - *Manually verified the change by running word count for text files compressed using different Snappy versions* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no ## Documentation - Does this pull request introduce a new feature? yes - If yes, how is the feature documented? JavaDocs You can merge this pull request into a Git repository by running: $ git pull https://github.com/mlipkovich/flink FLINK-5944 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4683.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4683 commit c4d4016f1e6b44833d24994c97532b4c5243e4d2 Author: Mikhail Lipkovich <mikhail_lipkov...@epam.com> Date: 2017-09-19T13:34:10Z [FLINK-5944] Support reading of Snappy files ---
[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 Thansk, Aljoscha Probably I've forgotten to run `clean`. The method `iterate$default$3` is a method which automatically created by Scala for calculation of default value for parameter `keepPartitioning`. I tried different ways to exclude it but it didn't help. Anyway it should be somehow tracked by japicmp so I created the issue there https://github.com/siom79/japicmp/issues/176 ---
[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 The local build works fine. If you mean `mvn verify` by compatibility plugin it also worked with no issues ---
[GitHub] flink issue #4655: [FLINK-7567]: Removed keepPartitioning parameter from ite...
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4655 As I understand the build has failed because of changed API method. The method which was changed has annotation PublicEvolving so there should be a way to change it. As was mentioned by @aljoscha https://issues.apache.org/jira/browse/FLINK-7567 there is no way to create a method with updated API and to deprecate the current one because of the default parameter ---
[GitHub] flink pull request #4655: [FLINK-7567]: Removed keepPartitioning parameter f...
GitHub user mlipkovich opened a pull request: https://github.com/apache/flink/pull/4655 [FLINK-7567]: Removed keepPartitioning parameter from iterate method ## What is the purpose of the change Removed parameter keepPartitioning from DataStream#iterate method since it's ignored. Also slightly modified error message related to different parallelism levels of input and feedback streams ## Brief change log - Removed parameter keepPartitioning from DataStream#iterate ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / no) no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) yes - The serializers: (yes / no / don't know) no - The runtime per-record code paths (performance sensitive): (yes / no / don't know) no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know) no ## Documentation - Does this pull request introduce a new feature? (yes / no) no - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not applicable You can merge this pull request into a Git repository by running: $ git pull https://github.com/mlipkovich/flink FLINK-7567 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4655.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4655 commit 2525aef6f65d297142472ae6532e3bddb08df0fd Author: Mikhail Lipkovich <mikhail_lipkov...@epam.com> Date: 2017-09-07T14:05:22Z [FLINK-7567]: Removed keepPartitioning parameter from iterate method ---
[GitHub] flink issue #4630: [FLINK-6733] Remove commented out AvgAggregationFunction....
Github user mlipkovich commented on the issue: https://github.com/apache/flink/pull/4630 The build has failed but it seems like Travis issue. My changes could not break it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #4630: [FLINK-6733] Remove commented out AvgAggregationFu...
GitHub user mlipkovich opened a pull request: https://github.com/apache/flink/pull/4630 [FLINK-6733] Remove commented out AvgAggregationFunction.java *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.* ## Contribution Checklist - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue. - Name the pull request in the form "[FLINK-] [component] Title of the pull request", where *FLINK-* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component. Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices). - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message (including the JIRA id) - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)* ## Brief change log *(for example:)* - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact* - *Deployments RPC transmits only the blob storage reference* - *TaskManagers retrieve the TaskInfo from the blob cache* ## Verifying this change *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (100MB)* - *Extended integration test for recovery after master (JobManager) failure* - *Added test that validates that TaskInfo is transferred only once across recoveries* - *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) - The serializers: (yes / no / don't know) - The runtime per-record code paths (performance sensitive): (yes / no / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) You can merge this pull request into a Git repository by running: $ git pull https://github.com/mlipkovich/flink FLINK-6733 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4630.patch
