[GitHub] flink pull request #6245: [FLINK-9718][scala-shell]. Add enviroment variable...

2018-07-04 Thread zjffdu 
Github user zjffdu commented on a diff in the pull request:

https://github.com/apache/flink/pull/6245#discussion_r200060027
  
--- Diff: flink-scala-shell/start-script/start-scala-shell.sh ---
@@ -19,6 +19,9 @@
 
 # from scala-lang 2.10.4
 
+# Uncomment the following line to enable remote debug
+# export 
FLINK_SCALA_SHELL_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005"
--- End diff --

Sorry @yanghua I still think using bool flag is not proper. Regarding 
`hiding the details of remote debug info`, I mean bool flag only control 
whether to enable remote debug, but does't control how, such as which port to 
listen.  If we introduce this bool flag,  we will use 2 env variable to control 
whether and how to remote debug which is too verbose to me. 


---

[GitHub] flink issue #6140: [FLINK-9554] flink scala shell doesn't work in yarn mode

2018-07-04 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/flink/pull/6140
  
@zentol  I have addressed the comments. Could you help take a look at it ? 
Thanks


---

[GitHub] flink pull request #6245: FLINK-9718. Add enviroment variable in start-scala...

2018-07-04 Thread zjffdu 
Github user zjffdu commented on a diff in the pull request:

https://github.com/apache/flink/pull/6245#discussion_r200040940
  
--- Diff: flink-scala-shell/start-script/start-scala-shell.sh ---
@@ -19,6 +19,9 @@
 
 # from scala-lang 2.10.4
 
+# Uncomment the following line to enable remote debug
+# export 
FLINK_SCALA_SHELL_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005"
--- End diff --

I don't find something like `flink-env.sh` for specify flink related env 
variable. So I just put it in `start-scala-shell.sh` directly. I don't think 
bool flag is proper, as it hide the details of remote debug info, like which 
port to listen. I believe most of apache project use `*JAVA_OPTS` for remote 
debug which is very common. What do you think ?


---

[GitHub] flink pull request #6140: [FLINK-9554] flink scala shell doesn't work in yar...

2018-07-03 Thread zjffdu 
Github user zjffdu commented on a diff in the pull request:

https://github.com/apache/flink/pull/6140#discussion_r199817183
  
--- Diff: flink-scala-shell/start-script/start-scala-shell.sh ---
@@ -19,6 +19,9 @@
 
 # from scala-lang 2.10.4
 
+# Uncomment the following line to enable remote debug
+# export 
FLINK_SCALA_SHELL_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005"
--- End diff --

Created PR #6245 for it


---

[GitHub] flink pull request #6245: FLINK-9718. Add enviroment variable in start-scala...

2018-07-03 Thread zjffdu 
GitHub user zjffdu opened a pull request:

https://github.com/apache/flink/pull/6245

FLINK-9718. Add enviroment variable in start-scala-shell.sh to enable 
remote debug

## What is the purpose of the change

Add enviroment variable `FLINK_SCALA_SHELL_JAVA_OPTS` in 
`start-scala-shell.sh` to enable remote debug.  

## Brief change log

## Verifying this change

Verify it manually via uncomment that line in `start-scala-shell.sh`
 

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  - The S3 file system connector: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not documented)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/flink FLINK-9718

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6245


commit 7d8d10ad7e91b291c94a37ad49c4dab84a1ae00c
Author: Jeff Zhang 
Date:   2018-07-03T13:53:06Z

FLINK-9718. Add enviroment variable in start-scala-shell.sh to enable 
remote debug




---

[GitHub] flink pull request #6140: [FLINK-9554] flink scala shell doesn't work in yar...

2018-07-03 Thread zjffdu 
Github user zjffdu commented on a diff in the pull request:

https://github.com/apache/flink/pull/6140#discussion_r199813552
  
--- Diff: flink-scala-shell/start-script/start-scala-shell.sh ---
@@ -19,6 +19,9 @@
 
 # from scala-lang 2.10.4
 
+# Uncomment the following line to enable remote debug
+# export 
FLINK_SCALA_SHELL_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005"
--- End diff --

Created FLINK-9718 for it


---

[GitHub] flink pull request #6140: [FLINK-9554] flink scala shell doesn't work in yar...

2018-07-03 Thread zjffdu 
Github user zjffdu commented on a diff in the pull request:

https://github.com/apache/flink/pull/6140#discussion_r199750956
  
--- Diff: 
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala ---
@@ -255,14 +257,25 @@ object FlinkShell {
 yarnConfig.queue.foreach((queue) => args ++= Seq("-yqu", 
queue.toString))
 yarnConfig.slots.foreach((slots) => args ++= Seq("-ys", 
slots.toString))
 
+val customCommandLines = CliFrontend.loadCustomCommandLines(
+  configuration,configurationDirectory)
+val commandOptions = CliFrontendParser.getRunCommandOptions
+val customCommandLineOptions = new Options()
+customCommandLines.asScala.foreach(cmd => {
--- End diff --

@zentol  I have fixed that, but I have to make `customCommandLineOptions` 
of `CliFrontend` to be static (a little ugly)


---

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-02 Thread zjffdu 
GitHub user zjffdu opened a pull request:

https://github.com/apache/flink/pull/6236

[FLINK-9699]. Add api to replace registered table

*Thank you very much for contributing to Apache Flink - we are happy that 
you want to help us improve Flink. To help the community review your 
contribution in the best possible way, please go through the checklist below, 
which will get the contribution into a shape in which it can be best reviewed.*

*Please understand that we do not do this to make contributions to Flink a 
hassle. In order to uphold a high standard of quality for code contributions, 
while at the same time managing a large number of contributions, we need 
contributors to prepare the contributions well, and give reviewers enough 
contextual information for the review. Please also understand that 
contributions that do not follow this guide will take longer to review and thus 
typically be picked up with lower priority by the community.*

## Contribution Checklist

  - Make sure that the pull request corresponds to a [JIRA 
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are 
made for typos in JavaDoc or documentation files, which need no JIRA issue.
  
  - Name the pull request in the form "[FLINK-] [component] Title of 
the pull request", where *FLINK-* should be replaced by the actual issue 
number. Skip *component* if you are unsure about which is the best component.
  Typo fixes that have no associated JIRA issue should be named following 
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or 
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.

  - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
  
  - Make sure that the change passes the automated tests, i.e., `mvn clean 
verify` passes. You can set up Travis CI to do that following [this 
guide](http://flink.apache.org/contribute-code.html#best-practices).

  - Each pull request should address only one issue, not mix up code from 
multiple issues.
  
  - Each commit in the pull request has a meaningful commit message 
(including the JIRA id)

  - Once all items of the checklist are addressed, remove the above text 
and this checklist, leaving only the filled out template below.


**(The sections below can be removed for hotfixes of typos)**

## What is the purpose of the change

*(For example: This pull request makes task deployment go through the blob 
server, rather than through RPC. That way we avoid re-transferring them on each 
deployment (during recovery).)*


## Brief change log

*(for example:)*
  - *The TaskInfo is stored in the blob store on job creation time as a 
persistent artifact*
  - *Deployments RPC transmits only the blob storage reference*
  - *TaskManagers retrieve the TaskInfo from the blob cache*


## Verifying this change

*(Please pick either of the following options)*

This change is a trivial rework / code cleanup without any test coverage.

*(or)*

This change is already covered by existing tests, such as *(please describe 
tests)*.

*(or)*

This change added tests and can be verified as follows:

*(example:)*
  - *Added integration tests for end-to-end deployment with large payloads 
(100MB)*
  - *Extended integration test for recovery after master (JobManager) 
failure*
  - *Added test that validates that TaskInfo is transferred only once 
across recoveries*
  - *Manually verified the change by running a 4 node cluser with 2 
JobManagers and 4 TaskManagers, a stateful streaming program, and killing one 
JobManager and two TaskManagers during the execution, verifying that recovery 
happens correctly.*

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (yes / no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / no)
  - The serializers: (yes / no / don't know)
  - The runtime per-record code paths (performance sensitive): (yes / no / 
don't know)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  - The S3 file system connector: (yes / no / don't know)

## Documentation

  - Does this pull request introduce a new feature? (yes / no)
  - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/flink FLINK-9699

Alternatively you can review and apply these changes as the patch at:

https://github.

[GitHub] flink issue #6140: [FLINK-9554] flink scala shell doesn't work in yarn mode

2018-06-12 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/flink/pull/6140
  
ping @tillrohrmann 


---

[GitHub] flink issue #6140: [FLINK-9554] flink scala shell doesn't work in yarn mode

2018-06-07 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/flink/pull/6140
  
@tillrohrmann  Could you help review it ? Thanks


---

[GitHub] flink pull request #6140: [FLINK-9554] flink scala shell doesn't work in yar...

2018-06-07 Thread zjffdu 
GitHub user zjffdu opened a pull request:

https://github.com/apache/flink/pull/6140

[FLINK-9554] flink scala shell doesn't work in yarn mode

## What is the purpose of the change

This PR is trying to fix the issue of scala-shell unable to run in yarn 
mode. 

## Brief change log

The root cause is the options of CustomCommandLine is missed which cause 
the "-m yarn-cluster" can not be parsed correctly.

## Verifying this change

I verify it manually on a single node hadoop cluster. I think it is better 
to add integration for that so that we can avoid the regression issue in 
future. If necessary, I can create a ticket for it and do it in another PR. 

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): ( no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no )
  - The S3 file system connector: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? ( not documented)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/flink FLINK-9554

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6140


commit f3d37d4799e51323fbbcd52cf972ac1d874d2514
Author: Jeff Zhang 
Date:   2018-06-07T09:47:32Z

save

commit d65058133ce220e2d4212b906d521b38b9ef53dd
Author: Jeff Zhang 
Date:   2018-06-08T02:39:27Z

[FLINK-9554] flink scala shell doesn't work in yarn mode




---

[GitHub] flink pull request #6131: [hotfix][docs] Fix Table API scala example code

2018-06-06 Thread zjffdu 
GitHub user zjffdu opened a pull request:

https://github.com/apache/flink/pull/6131

[hotfix][docs] Fix Table API scala example code

This change only fix the documentation. This is a straightforward fix for 
the Table API of scala example code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/flink doc_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6131


commit c0e2b7818094f4c1cc79981ad6dd3cc7dffe2bdc
Author: Jeff Zhang 
Date:   2018-06-07T00:45:43Z

[hotfix][docs] Fix Table API scala example code




---