[GitHub] [flink] syhily commented on a change in pull request #18388: [FLINK-25530][python][connector/pulsar] Support Pulsar source connector in Python DataStream API.
syhily commented on a change in pull request #18388:
URL: https://github.com/apache/flink/pull/18388#discussion_r791184358
##
File path: flink-connectors/pom.xml
##
@@ -105,6 +105,7 @@ under the License.
flink-sql-connector-hive-3.1.2
flink-sql-connector-kafka
flink-sql-connector-kinesis
+ flink-sql-connector-pulsar
Review comment:
Pulsar connector doesn't support the Flink SQL now. Add this module may
cause confusion for the end-user. Can we just use `flink-connector-pulsar`?
##
File path:
tools/ci/java-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/JarFileChecker.java
##
@@ -210,6 +210,11 @@ private static int findNonBinaryFilesContainingText(
// dual-licensed under GPL 2 and EPL 2.0
// contained in sql-avro-confluent-registry
.filter(path -> !pathStartsWith(path,
"/org/glassfish/jersey/internal"))
+// contained in sql-connector-pulsar
+.filter(
+path ->
+!pathStartsWith(
+path,
"/org/apache/pulsar/shade/org/glassfish/jersey/"))
Review comment:
Pulsar client shades a lot of jars, such as the `avro`. Can we just
change this check filter to `/org/apache/pulsar/shade`?
##
File path: flink-connectors/flink-sql-connector-pulsar/pom.xml
##
@@ -0,0 +1,73 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+ 4.0.0
+
+
+ flink-connectors
+ org.apache.flink
+ 1.15-SNAPSHOT
+ ..
+
+
+ flink-sql-connector-pulsar
+ Flink : Connectors : SQL : Pulsar
+
+ jar
+
+
+
+ org.apache.flink
+ flink-connector-pulsar
+ ${project.version}
+
+
+
+
+
+
+ org.apache.maven.plugins
+ maven-shade-plugin
+
+
+ shade-flink
+ package
+
+ shade
+
+
+
+
+
org.apache.flink:flink-connector-base
+
org.apache.flink:flink-connector-pulsar
+
org.apache.pulsar:*
Review comment:
This package phrase needs to be changed. We don't need
pulsar-package-core. And the `bouncycastle` is required for end-to-end
encryption in Pulsar. I think you can change it to the code below.
```
org.apache.pulsar:pulsar-client-admin-api
org.apache.pulsar:pulsar-client-api
org.apache.pulsar:bouncy-castle-bc
org.apache.pulsar:pulsar-client-all
org.bouncycastle:bcpkix-jdk15on
org.bouncycastle:bcprov-jdk15on
org.bouncycastle:bcutil-jdk15on
org.bouncycastle:bcprov-ext-jdk15on
```
##
File path: flink-connectors/flink-sql-connector-pulsar/pom.xml
##
@@ -0,0 +1,73 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+ 4.0.0
+
+
+ flink-connectors
+ org.apache.flink
+ 1.15-SNAPSHOT
+ ..
+
+
+ flink-sql-connector-pulsar
+ Flink : Connectors : SQL : Pulsar
+
+ jar
+
+
+
+ org.apache.flink
+ flink-connector-pulsar
+ ${project.version}
+
+
+
+
+
+
+ org.apache.maven.plugins
+ maven-shade-plugin
+
+
+ shade-flink
+ package
+
+
[GitHub] [flink] syhily commented on a change in pull request #18388: [FLINK-25530][python][connector/pulsar] Support Pulsar source connector in Python DataStream API.
syhily commented on a change in pull request #18388:
URL: https://github.com/apache/flink/pull/18388#discussion_r791415871
##
File path: flink-connectors/flink-sql-connector-pulsar/pom.xml
##
@@ -0,0 +1,73 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+ 4.0.0
+
+
+ flink-connectors
+ org.apache.flink
+ 1.15-SNAPSHOT
+ ..
+
+
+ flink-sql-connector-pulsar
+ Flink : Connectors : SQL : Pulsar
+
+ jar
+
+
+
+ org.apache.flink
+ flink-connector-pulsar
+ ${project.version}
+
+
+
+
+
+
+ org.apache.maven.plugins
+ maven-shade-plugin
+
+
+ shade-flink
+ package
+
+ shade
+
+
+
+
+
org.apache.flink:flink-connector-base
+
org.apache.flink:flink-connector-pulsar
+
org.apache.pulsar:*
Review comment:
This package phrase needs to be changed. We don't need
`org.apache.pulsar:pulsar-package-core`. And the `bouncycastle` is required for
end-to-end encryption in Pulsar. I think you can change it to the code below.
```
org.apache.pulsar:pulsar-client-admin-api
org.apache.pulsar:pulsar-client-api
org.apache.pulsar:bouncy-castle-bc
org.apache.pulsar:pulsar-client-all
org.bouncycastle:bcpkix-jdk15on
org.bouncycastle:bcprov-jdk15on
org.bouncycastle:bcutil-jdk15on
org.bouncycastle:bcprov-ext-jdk15on
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] syhily commented on a change in pull request #18388: [FLINK-25530][python][connector/pulsar] Support Pulsar source connector in Python DataStream API.
syhily commented on a change in pull request #18388:
URL: https://github.com/apache/flink/pull/18388#discussion_r791415871
##
File path: flink-connectors/flink-sql-connector-pulsar/pom.xml
##
@@ -0,0 +1,73 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+ 4.0.0
+
+
+ flink-connectors
+ org.apache.flink
+ 1.15-SNAPSHOT
+ ..
+
+
+ flink-sql-connector-pulsar
+ Flink : Connectors : SQL : Pulsar
+
+ jar
+
+
+
+ org.apache.flink
+ flink-connector-pulsar
+ ${project.version}
+
+
+
+
+
+
+ org.apache.maven.plugins
+ maven-shade-plugin
+
+
+ shade-flink
+ package
+
+ shade
+
+
+
+
+
org.apache.flink:flink-connector-base
+
org.apache.flink:flink-connector-pulsar
+
org.apache.pulsar:*
Review comment:
This package phrase needs to be changed. We don't need
pulsar-package-core. And the `bouncycastle` is required for end-to-end
encryption in Pulsar. I think you can change it to the code below.
```
org.apache.pulsar:pulsar-client-admin-api
org.apache.pulsar:pulsar-client-api
org.apache.pulsar:bouncy-castle-bc
org.apache.pulsar:pulsar-client-all
org.bouncycastle:bcpkix-jdk15on
org.bouncycastle:bcprov-jdk15on
org.bouncycastle:bcutil-jdk15on
org.bouncycastle:bcprov-ext-jdk15on
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] syhily commented on a change in pull request #18388: [FLINK-25530][python][connector/pulsar] Support Pulsar source connector in Python DataStream API.
syhily commented on a change in pull request #18388: URL: https://github.com/apache/flink/pull/18388#discussion_r791185396 ## File path: tools/ci/java-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/JarFileChecker.java ## @@ -210,6 +210,11 @@ private static int findNonBinaryFilesContainingText( // dual-licensed under GPL 2 and EPL 2.0 // contained in sql-avro-confluent-registry .filter(path -> !pathStartsWith(path, "/org/glassfish/jersey/internal")) +// contained in sql-connector-pulsar +.filter( +path -> +!pathStartsWith( +path, "/org/apache/pulsar/shade/org/glassfish/jersey/")) Review comment: Pulsar client shades a lot of jars, such as the `avro`. Can we just change this check filter to `/org/apache/pulsar/shade`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] syhily commented on a change in pull request #18388: [FLINK-25530][python][connector/pulsar] Support Pulsar source connector in Python DataStream API.
syhily commented on a change in pull request #18388: URL: https://github.com/apache/flink/pull/18388#discussion_r791184358 ## File path: flink-connectors/pom.xml ## @@ -105,6 +105,7 @@ under the License. flink-sql-connector-hive-3.1.2 flink-sql-connector-kafka flink-sql-connector-kinesis + flink-sql-connector-pulsar Review comment: Pulsar connector doesn't support the Flink SQL now. Add this module may cause confusion for the end-user. Can we just use `flink-connector-pulsar`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
