[GitHub] [flink-kubernetes-operator] FuyaoLi2017 commented on pull request #202: [FLINK-27483]Add session job config field
FuyaoLi2017 commented on PR #202: URL: https://github.com/apache/flink-kubernetes-operator/pull/202#issuecomment-1126402997 Hi @Aitozi @gyfora , thanks for reviewing this. I have updated the code based on your suggestions. 1. Update typos for `spec.job.flinkConfiguration`. 2. Update documentation about the session job flink configuration and provided allowed configurations (only the header config at the moment). 3. Add validator logic in `DefaultValidator`. Also refactored existing `validateFlinkConfig` method name to `validateFlinkDeploymentConfig` to avoid confusion. 4. Move configuration merge logic into `FlinkConfigManager`. Add a `getSessionJobObserveConfig` method, refactor a few places to call this method instead of `getObserveConfig`. There were some merge conflicts and rebased the main branch. I ran into some errors and introduced some unexpected changes, as a result, I force pushed the code to make it clean. Sorry for making the commit history kind of messy.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-kubernetes-operator] FuyaoLi2017 commented on pull request #202: [FLINK-27483]Add session job config field
FuyaoLi2017 commented on PR #202: URL: https://github.com/apache/flink-kubernetes-operator/pull/202#issuecomment-1125653576 In the CI pipeline, it shows some unit test failures. But I can pass them in my local. I guess it might be some cascading error caused by documentation? I didn't rebuild the docs eariler since I am not familiar with the procedure. ``` mvn clean install -DskipTests -Pgenerate-docs ``` I ran the command above, generated some docs and pushed again... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-kubernetes-operator] FuyaoLi2017 commented on pull request #202: [FLINK-27483]Add session job config field
FuyaoLi2017 commented on PR #202: URL: https://github.com/apache/flink-kubernetes-operator/pull/202#issuecomment-1125524916 Hi @gyfora , I noticed this error. ``` Error: Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project flink-kubernetes-operator-parent: Too many files with unapproved license: 1 See RAT report in: /home/runner/work/flink-kubernetes-operator/flink-kubernetes-operator/target/rat.txt -> [Help 1] ``` I don't know how to fix this. I can build the project successfully on my local laptop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
