Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]
echauchot merged PR #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]
snuyanzin commented on code in PR #25:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/25#discussion_r1413196788
##
pom.xml:
##
@@ -558,6 +563,8 @@ under the License.
US
en
${project.basedir}
+
+
${surefire.module.config}
Review Comment:
That's actually a good question.
Initially I thought it might be useful in case there will be something
similar to `org.apache.flink.runtime.testutils.TestJvmProcess` on connetors
level. However after looking at connector's repos it seems not the case at
least for the moment... So I will remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]
echauchot commented on code in PR #25:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/25#discussion_r1412014261
##
pom.xml:
##
@@ -558,6 +563,8 @@ under the License.
US
en
${project.basedir}
+
+
${surefire.module.config}
Review Comment:
please elaborate on why exposing the property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]
echauchot commented on PR #25:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/25#issuecomment-1835994166
>> @snuyanzin can you elaborate on the use cases you have in mind for
systemPropertyVariable surefire.module.config ?
> The use case is testing against jdk17/21 The issue with these jdks is that
sometimes it is from one side required to add `add-opens/export` flags for
tests like it is done e.g. for flink-core
https://github.com/apache/flink/blob/a024f6329593bee1188080ca41808b8ac77b0660/flink-core/pom.xml#L44-L58
>
> Similar it is required for connector's code. From another side it's better
to keep existing surefire flags. + in case of jdk8 it makes sence to have
`-XX:+IgnoreUnrecognizedVMOptions` to make it non failing because of all these
`add-[opens|exports]`
yes, it was clear already in the comment in the pom. I meant, can you
elaborate on why this:
`
${surefire.module.config}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]
snuyanzin commented on PR #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25#issuecomment-1835851027 The use case is testing against jdk17/21 The issue with these jdks is that sometimes it is from one side required to add `add-opens/export` flags for tests like it is done e.g. for flink-core https://github.com/apache/flink/blob/a024f6329593bee1188080ca41808b8ac77b0660/flink-core/pom.xml#L44-L58 Similar it is required for connector's code. From another side it's better to keep existing surefire flags. + in case of jdk8 it makes sence to have `-XX:+IgnoreUnrecognizedVMOptions` to make it non failing because of all these `add-[opens|exports]` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]
echauchot commented on PR #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25#issuecomment-1834048030 @snuyanzin can you elaborate on the use cases you have in mind for systemPropertyVariable surefire.module.config ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]
snuyanzin opened a new pull request, #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25 The idea is to apply same approach as for Flink main repo and it's modules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
