[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290793#comment-14290793 ] Stephan Ewen commented on FLINK-1330: - I think a good solution would be to that the build creates a symbolic link in the root to point to the target of the build. We can use the Maven junction plugin to do that: http://pyx4j.com/pyx4j-maven-plugins/maven-junction-plugin/introduction.html > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290813#comment-14290813 ] ASF GitHub Bot commented on FLINK-1330: --- GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/333 [FLINK-1330] [build] Build creates a link in the root directory to the build target directory The sym link allows you to find the target directory of the build fast. It looks like this ``` lrwxrwxrwx 1 user group84 Jan 24 12:13 build-target -> /data/repositories/flink/flink-dist/target/flink-0.9-SNAPSHOT-bin/flink-0.9-SNAPSHOT/ drwxrwxr-x 9 user group 4096 Jan 24 11:25 docs/ drwxrwxr-x 12 user group 4096 Jan 24 11:55 flink-addons/ drwxrwxr-x 5 user group 4096 Jan 24 11:54 flink-clients/ drwxrwxr-x 5 user group 4096 Jan 24 11:54 flink-compiler/ ... ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/StephanEwen/incubator-flink sym_link Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/333.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #333 commit dd321379e77895c439bd83d22fcb8025dd654247 Author: Stephan Ewen Date: 2015-01-24T20:19:38Z [FLINK-1330] [build] Build creates a link in the root directory to the build target directory > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291031#comment-14291031 ] ASF GitHub Bot commented on FLINK-1330: --- Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71365114 LGTM > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291043#comment-14291043 ] ASF GitHub Bot commented on FLINK-1330: --- Github user mxm commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71366786 This looks good. > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291774#comment-14291774 ] ASF GitHub Bot commented on FLINK-1330: --- Github user uce commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71454018 Very nice. +1 Will merge this later. > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[
https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291781#comment-14291781
]
ASF GitHub Bot commented on FLINK-1330:
---
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/333#discussion_r23527422
--- Diff: flink-dist/pom.xml ---
@@ -436,6 +436,37 @@ under the License.
+
+
+
+ com.pyx4j
+ maven-junction-plugin
+ 1.0.3
+
+
+ package
+
+ link
+
+
+
+ unlink
+ clean
+
+ unlink
+
+
+
+
+
+
+
${basedir}/../build-target
--- End diff --
Isn't based deprecated? In the next line you use project.basedir.
> Restructure directory layout
>
>
> Key: FLINK-1330
> URL: https://issues.apache.org/jira/browse/FLINK-1330
> Project: Flink
> Issue Type: Improvement
> Components: Build System, Documentation
>Reporter: Max Michels
>Priority: Minor
> Labels: usability
>
> When building Flink, the build results can currently be found under
> "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/".
> I think we could improve the directory layout with the following:
> - provide the bin folder in the root by default
> - let the start up and submissions scripts in bin assemble the class path
> - in case the project hasn't been build yet, inform the user
> The changes would make it easier to work with Flink from source.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[
https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291796#comment-14291796
]
ASF GitHub Bot commented on FLINK-1330:
---
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/333#discussion_r23528552
--- Diff: flink-dist/pom.xml ---
@@ -436,6 +436,37 @@ under the License.
+
+
+
+ com.pyx4j
+ maven-junction-plugin
+ 1.0.3
+
+
+ package
+
+ link
+
+
+
+ unlink
+ clean
+
+ unlink
+
+
+
+
+
+
+
${basedir}/../build-target
--- End diff --
I couldn't find a document stating that $basedir is deprecated, but I think
you are right in the sense that the project prefix is used for everything
related to the POM of the project (I think in previous versions the (now
deprecated) prefix was `pom` and both the `version` and `basedir` properties
are "built-ins").
We use $basedir in other places as well.
> Restructure directory layout
>
>
> Key: FLINK-1330
> URL: https://issues.apache.org/jira/browse/FLINK-1330
> Project: Flink
> Issue Type: Improvement
> Components: Build System, Documentation
>Reporter: Max Michels
>Priority: Minor
> Labels: usability
>
> When building Flink, the build results can currently be found under
> "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/".
> I think we could improve the directory layout with the following:
> - provide the bin folder in the root by default
> - let the start up and submissions scripts in bin assemble the class path
> - in case the project hasn't been build yet, inform the user
> The changes would make it easier to work with Flink from source.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291839#comment-14291839 ] ASF GitHub Bot commented on FLINK-1330: --- Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71464164 -1 I think we need to add the `build-target` "directory" into the list of ignored directories for apache rat. Rat will fail subsequent builds ``` 1 Unknown Licenses *** Unapproved licenses: build-target/conf/slaves *** ``` > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291880#comment-14291880 ] ASF GitHub Bot commented on FLINK-1330: --- Github user uce commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71468579 Very good catch. I would address @aljoscha's comment and add the exclude. After that, I think it's fine to merge. I've tested it locally and it works fine. > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291886#comment-14291886 ] ASF GitHub Bot commented on FLINK-1330: --- Github user uce commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71469342 There's another minor thing. After running mvn clean, the symlink will point to a non-existing directory. > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291891#comment-14291891 ] ASF GitHub Bot commented on FLINK-1330: --- Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71469736 Oh, actually, that should work because the configuration explicitly binds the plugin to the "clean" phase. > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291898#comment-14291898 ] ASF GitHub Bot commented on FLINK-1330: --- Github user uce commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71470142 Yes, I thought it would handle it as well, but I just ran it and it didn't work. > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293071#comment-14293071 ] ASF GitHub Bot commented on FLINK-1330: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71598417 Okay, let's add an exclude for the linked target directory and update `basedir` to `project.basedir`. Will that do? > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293193#comment-14293193 ] ASF GitHub Bot commented on FLINK-1330: --- Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71610034 In addition to that, we should probably investigate why the "clean" phase is not removing the directory. > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293390#comment-14293390 ] ASF GitHub Bot commented on FLINK-1330: --- Github user mxm commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71633168 So either we can somehow change the execution order of the clean goal or we fix this in the junction plugin. > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294137#comment-14294137 ] ASF GitHub Bot commented on FLINK-1330: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71722351 We can bind the `unlink`to the `pre-clean` phase, see if that helps. All in all, if it does not work, it does not work. This is a nice utility, by no way crucial enough to spent huge amounts of time on it... > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294900#comment-14294900 ] ASF GitHub Bot commented on FLINK-1330: --- Github user mxm commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71801652 I can confirm that the symlink gets deleted when `unlink` goal is executed in the `pre-clean` phase. > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303260#comment-14303260 ] ASF GitHub Bot commented on FLINK-1330: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/333 > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Priority: Minor > Labels: usability > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303483#comment-14303483 ] ASF GitHub Bot commented on FLINK-1330: --- Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-72676563 The symlink is not excluded from the rat check. So subsequent builds will fail due to the rat check. > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Assignee: Stephan Ewen >Priority: Minor > Labels: usability > Fix For: 0.9 > > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303497#comment-14303497 ] ASF GitHub Bot commented on FLINK-1330: --- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-72678344 I modified the merged version to exclude it from rat. I also tried subsequent builds, it worked. See here: https://github.com/apache/flink/commit/0c726f833892a03a12cc92d35e7d249369eb0dc9#diff-600376dffeb79835ede4a0b285078036R1046 > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Assignee: Stephan Ewen >Priority: Minor > Labels: usability > Fix For: 0.9 > > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1330) Restructure directory layout
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303508#comment-14303508 ] ASF GitHub Bot commented on FLINK-1330: --- Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-72678817 Ah, okay. I was on a branch which has not been rebased yet (so it didn't contain the exclude). So for now I have to do a "mvn clean" before going to older branches. > Restructure directory layout > > > Key: FLINK-1330 > URL: https://issues.apache.org/jira/browse/FLINK-1330 > Project: Flink > Issue Type: Improvement > Components: Build System, Documentation >Reporter: Max Michels >Assignee: Stephan Ewen >Priority: Minor > Labels: usability > Fix For: 0.9 > > > When building Flink, the build results can currently be found under > "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/". > I think we could improve the directory layout with the following: > - provide the bin folder in the root by default > - let the start up and submissions scripts in bin assemble the class path > - in case the project hasn't been build yet, inform the user > The changes would make it easier to work with Flink from source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
