[jira] [Commented] (FLINK-19656) Automatically replace delimiter in metric name components
[ https://issues.apache.org/jira/browse/FLINK-19656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249007#comment-17249007 ] Etienne Chauchot commented on FLINK-19656: -- Hi [~chesnay], thanks for your answers. It is clearer now: the existing filters in the reporters only filter out static chars and should also filter out the configured per-reporter delimiter. All reporters could have a default filtering implementation that filter out the configured delimiter and some reporters could override this implementation to filter out other characters. > Automatically replace delimiter in metric name components > - > > Key: FLINK-19656 > URL: https://issues.apache.org/jira/browse/FLINK-19656 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Reporter: Chesnay Schepler >Priority: Major > Labels: starter > Fix For: 1.13.0 > > > The metric name consists of various components (like job ID, task ID), that > are then joined by a delimiter(commonly {{.}}). > The delimiter isn't just for convention, but also carries semantics for many > metric backends, as they organize metrics based on the delimiter. > This can behave in unfortunate ways if the delimiter is contained with a > given component, as it will now be split up by the backend. > We should automatically filter such occurrences to prevent this from > happening. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-19656) Automatically replace delimiter in metric name components
[ https://issues.apache.org/jira/browse/FLINK-19656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245812#comment-17245812 ] Chesnay Schepler commented on FLINK-19656: -- [~echauchot] Not quite. What you missed is that the delimiter is configurable, and this is not visible to the reporter. The configured delimiter is injected by the {{FrontMetricGroup}}. We also have to adjust {{AbstractMetricGroup#getAllVariables()}} to accept a filter. > Automatically replace delimiter in metric name components > - > > Key: FLINK-19656 > URL: https://issues.apache.org/jira/browse/FLINK-19656 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Reporter: Chesnay Schepler >Priority: Major > Labels: starter > Fix For: 1.13.0 > > > The metric name consists of various components (like job ID, task ID), that > are then joined by a delimiter(commonly {{.}}). > The delimiter isn't just for convention, but also carries semantics for many > metric backends, as they organize metrics based on the delimiter. > This can behave in unfortunate ways if the delimiter is contained with a > given component, as it will now be split up by the backend. > We should automatically filter such occurrences to prevent this from > happening. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-19656) Automatically replace delimiter in metric name components
[ https://issues.apache.org/jira/browse/FLINK-19656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239310#comment-17239310 ] Etienne Chauchot commented on FLINK-19656: -- [~chesnay] I guess you'll get this message on Monday. I have the impression that everything is already in place for this ticket. Backends that need to filter certain characters from the component names already define a filter as in [here for dropwizard|[https://github.com/apache/flink/blob/22679aacd04612fb01f96bbbe58012cc7b2cda58/flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java#L185] and pass it to |https://github.com/apache/flink/blob/22679aacd04612fb01f96bbbe58012cc7b2cda58/flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java#L185].] ProxyMetricGroup#[getMetricIdentifier|https://github.com/apache/flink/blob/22679aacd04612fb01f96bbbe58012cc7b2cda58/flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java#L185].] > Automatically replace delimiter in metric name components > - > > Key: FLINK-19656 > URL: https://issues.apache.org/jira/browse/FLINK-19656 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Reporter: Chesnay Schepler >Priority: Major > Labels: starter > Fix For: 1.12.0 > > > The metric name consists of various components (like job ID, task ID), that > are then joined by a delimiter(commonly {{.}}). > The delimiter isn't just for convention, but also carries semantics for many > metric backends, as they organize metrics based on the delimiter. > This can behave in unfortunate ways if the delimiter is contained with a > given component, as it will now be split up by the backend. > We should automatically filter such occurrences to prevent this from > happening. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-19656) Automatically replace delimiter in metric name components
[ https://issues.apache.org/jira/browse/FLINK-19656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236113#comment-17236113 ] Robert Metzger commented on FLINK-19656: [~echauchot] thanks a lot for picking up this ticket. Chesnay is currently on vacation. He should be back in the last week of November. > Automatically replace delimiter in metric name components > - > > Key: FLINK-19656 > URL: https://issues.apache.org/jira/browse/FLINK-19656 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Reporter: Chesnay Schepler >Priority: Major > Labels: starter > Fix For: 1.12.0 > > > The metric name consists of various components (like job ID, task ID), that > are then joined by a delimiter(commonly {{.}}). > The delimiter isn't just for convention, but also carries semantics for many > metric backends, as they organize metrics based on the delimiter. > This can behave in unfortunate ways if the delimiter is contained with a > given component, as it will now be split up by the backend. > We should automatically filter such occurrences to prevent this from > happening. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-19656) Automatically replace delimiter in metric name components
[ https://issues.apache.org/jira/browse/FLINK-19656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232760#comment-17232760 ] Etienne Chauchot commented on FLINK-19656: -- Hi [~chesnay] I took a look at Flink code and _FrontMetricGroup_ class already provides Metric name character filtering [here|https://github.com/apache/flink/blob/4a6ce272cbb53a683a9c68aa003a0f5464d8fb4d/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/FrontMetricGroup.java#L48] that allows to specify a backend specific delimiter and a backend specific filtering function. Can you explain a bit more " if the delimiter is contained with a given component" ? Thanks > Automatically replace delimiter in metric name components > - > > Key: FLINK-19656 > URL: https://issues.apache.org/jira/browse/FLINK-19656 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Reporter: Chesnay Schepler >Priority: Major > Labels: starter > Fix For: 1.12.0 > > > The metric name consists of various components (like job ID, task ID), that > are then joined by a delimiter(commonly {{.}}). > The delimiter isn't just for convention, but also carries semantics for many > metric backends, as they organize metrics based on the delimiter. > This can behave in unfortunate ways if the delimiter is contained with a > given component, as it will now be split up by the backend. > We should automatically filter such occurrences to prevent this from > happening. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-19656) Automatically replace delimiter in metric name components
[ https://issues.apache.org/jira/browse/FLINK-19656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231493#comment-17231493 ] Etienne Chauchot commented on FLINK-19656: -- Hi [~chesnay], can you assign this ticket to me please ? > Automatically replace delimiter in metric name components > - > > Key: FLINK-19656 > URL: https://issues.apache.org/jira/browse/FLINK-19656 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics >Reporter: Chesnay Schepler >Priority: Major > Labels: starter > Fix For: 1.12.0 > > > The metric name consists of various components (like job ID, task ID), that > are then joined by a delimiter(commonly {{.}}). > The delimiter isn't just for convention, but also carries semantics for many > metric backends, as they organize metrics based on the delimiter. > This can behave in unfortunate ways if the delimiter is contained with a > given component, as it will now be split up by the backend. > We should automatically filter such occurrences to prevent this from > happening. -- This message was sent by Atlassian Jira (v8.3.4#803005)