[jira] [Commented] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class
[
https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825162#comment-17825162
]
Rui Fan commented on FLINK-34522:
-
merged in master(1.20):
* eb9bcfa5893374093d3add272ca698dcb262c4fd
* 972dc0cfc79e0afbe7567520cc53b24b5727e11f
* 7bfa1d303d84c1489e372c150d01ef62450ba2fd
> StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time
> class
> -
>
> Key: FLINK-34522
> URL: https://issues.apache.org/jira/browse/FLINK-34522
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
>Affects Versions: 1.19.0
>Reporter: Rui Fan
>Assignee: Rui Fan
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.19.0, 1.20.0
>
>
> FLINK-32570 deprecated the Time class and refactor all Public or
> PublicEvolving apis to use the Java's Duration.
> StateTtlConfig.Builder#cleanupInRocksdbCompactFilter is still using the Time
> class. In general, we expect:
> * Mark {{cleanupInRocksdbCompactFilter(long, Time)}} as {{@Deprecated}}
> * Provide a new cleanupInRocksdbCompactFilter(long, Duration)
> Note: This is exactly what FLINK-32570 does, so I guess FLINK-32570 missed
> cleanupInRocksdbCompactFilter.
> But I found this method is introduced in 1.19(FLINK-30854), so a better
> solution may be: only provide cleanupInRocksdbCompactFilter(long, Duration)
> and don't use Time.
> The deprecated Api should be keep for 2 minor version. IIUC, we cannot remove
> Time related class in Flink 2.0 if we don't deprecate it in 1.19. If so, I
> think it's better to merge this JIRA in 1.19.0 as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class
[
https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822754#comment-17822754
]
Yun Tang commented on FLINK-34522:
--
merged in release-1.19: 161defe0bb2dc8136133e07699b6ac433d52dc65 ...
7618bdeeab06c09219136a04a62262148c677134
> StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time
> class
> -
>
> Key: FLINK-34522
> URL: https://issues.apache.org/jira/browse/FLINK-34522
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
>Affects Versions: 1.19.0
>Reporter: Rui Fan
>Assignee: Rui Fan
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.19.0, 1.20.0
>
>
> FLINK-32570 deprecated the Time class and refactor all Public or
> PublicEvolving apis to use the Java's Duration.
> StateTtlConfig.Builder#cleanupInRocksdbCompactFilter is still using the Time
> class. In general, we expect:
> * Mark {{cleanupInRocksdbCompactFilter(long, Time)}} as {{@Deprecated}}
> * Provide a new cleanupInRocksdbCompactFilter(long, Duration)
> Note: This is exactly what FLINK-32570 does, so I guess FLINK-32570 missed
> cleanupInRocksdbCompactFilter.
> But I found this method is introduced in 1.19(FLINK-30854), so a better
> solution may be: only provide cleanupInRocksdbCompactFilter(long, Duration)
> and don't use Time.
> The deprecated Api should be keep for 2 minor version. IIUC, we cannot remove
> Time related class in Flink 2.0 if we don't deprecate it in 1.19. If so, I
> think it's better to merge this JIRA in 1.19.0 as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class
[
https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821921#comment-17821921
]
lincoln lee commented on FLINK-34522:
-
[~mapohl] Thanks for resolving it!
Back to this issue, [~dianfu] & [~hxb] have made some attempts, but there're no
clear leads yet, looks like it will take some time.
> StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time
> class
> -
>
> Key: FLINK-34522
> URL: https://issues.apache.org/jira/browse/FLINK-34522
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
>Affects Versions: 1.19.0
>Reporter: Rui Fan
>Assignee: Rui Fan
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.19.0, 1.20.0
>
>
> FLINK-32570 deprecated the Time class and refactor all Public or
> PublicEvolving apis to use the Java's Duration.
> StateTtlConfig.Builder#cleanupInRocksdbCompactFilter is still using the Time
> class. In general, we expect:
> * Mark {{cleanupInRocksdbCompactFilter(long, Time)}} as {{@Deprecated}}
> * Provide a new cleanupInRocksdbCompactFilter(long, Duration)
> Note: This is exactly what FLINK-32570 does, so I guess FLINK-32570 missed
> cleanupInRocksdbCompactFilter.
> But I found this method is introduced in 1.19(FLINK-30854), so a better
> solution may be: only provide cleanupInRocksdbCompactFilter(long, Duration)
> and don't use Time.
> The deprecated Api should be keep for 2 minor version. IIUC, we cannot remove
> Time related class in Flink 2.0 if we don't deprecate it in 1.19. If so, I
> think it's better to merge this JIRA in 1.19.0 as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class
[
https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821686#comment-17821686
]
Matthias Pohl commented on FLINK-34522:
---
I see - it's related to FLINK-34499 as far as I can see. I approved Chesnay's
FLINK-34499 PR and created the corresponding backports.
> StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time
> class
> -
>
> Key: FLINK-34522
> URL: https://issues.apache.org/jira/browse/FLINK-34522
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
>Affects Versions: 1.19.0
>Reporter: Rui Fan
>Assignee: Rui Fan
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.19.0, 1.20.0
>
>
> FLINK-32570 deprecated the Time class and refactor all Public or
> PublicEvolving apis to use the Java's Duration.
> StateTtlConfig.Builder#cleanupInRocksdbCompactFilter is still using the Time
> class. In general, we expect:
> * Mark {{cleanupInRocksdbCompactFilter(long, Time)}} as {{@Deprecated}}
> * Provide a new cleanupInRocksdbCompactFilter(long, Duration)
> Note: This is exactly what FLINK-32570 does, so I guess FLINK-32570 missed
> cleanupInRocksdbCompactFilter.
> But I found this method is introduced in 1.19(FLINK-30854), so a better
> solution may be: only provide cleanupInRocksdbCompactFilter(long, Duration)
> and don't use Time.
> The deprecated Api should be keep for 2 minor version. IIUC, we cannot remove
> Time related class in Flink 2.0 if we don't deprecate it in 1.19. If so, I
> think it's better to merge this JIRA in 1.19.0 as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class
[
https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821651#comment-17821651
]
lincoln lee commented on FLINK-34522:
-
[~mapohl] Btw, I missed a new blocker on yesterday’s
discussion(https://issues.apache.org/jira/browse/FLINK-34498)
As it stands now, we also need to fix it in 1.19.
> StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time
> class
> -
>
> Key: FLINK-34522
> URL: https://issues.apache.org/jira/browse/FLINK-34522
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
>Affects Versions: 1.19.0
>Reporter: Rui Fan
>Assignee: Rui Fan
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.19.0, 1.20.0
>
>
> FLINK-32570 deprecated the Time class and refactor all Public or
> PublicEvolving apis to use the Java's Duration.
> StateTtlConfig.Builder#cleanupInRocksdbCompactFilter is still using the Time
> class. In general, we expect:
> * Mark {{cleanupInRocksdbCompactFilter(long, Time)}} as {{@Deprecated}}
> * Provide a new cleanupInRocksdbCompactFilter(long, Duration)
> Note: This is exactly what FLINK-32570 does, so I guess FLINK-32570 missed
> cleanupInRocksdbCompactFilter.
> But I found this method is introduced in 1.19(FLINK-30854), so a better
> solution may be: only provide cleanupInRocksdbCompactFilter(long, Duration)
> and don't use Time.
> The deprecated Api should be keep for 2 minor version. IIUC, we cannot remove
> Time related class in Flink 2.0 if we don't deprecate it in 1.19. If so, I
> think it's better to merge this JIRA in 1.19.0 as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class
[
https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821650#comment-17821650
]
Matthias Pohl commented on FLINK-34522:
---
great, thanks for the support :)
> StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time
> class
> -
>
> Key: FLINK-34522
> URL: https://issues.apache.org/jira/browse/FLINK-34522
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
>Affects Versions: 1.19.0
>Reporter: Rui Fan
>Assignee: Rui Fan
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.19.0, 1.20.0
>
>
> FLINK-32570 deprecated the Time class and refactor all Public or
> PublicEvolving apis to use the Java's Duration.
> StateTtlConfig.Builder#cleanupInRocksdbCompactFilter is still using the Time
> class. In general, we expect:
> * Mark {{cleanupInRocksdbCompactFilter(long, Time)}} as {{@Deprecated}}
> * Provide a new cleanupInRocksdbCompactFilter(long, Duration)
> Note: This is exactly what FLINK-32570 does, so I guess FLINK-32570 missed
> cleanupInRocksdbCompactFilter.
> But I found this method is introduced in 1.19(FLINK-30854), so a better
> solution may be: only provide cleanupInRocksdbCompactFilter(long, Duration)
> and don't use Time.
> The deprecated Api should be keep for 2 minor version. IIUC, we cannot remove
> Time related class in Flink 2.0 if we don't deprecate it in 1.19. If so, I
> think it's better to merge this JIRA in 1.19.0 as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class
[
https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821648#comment-17821648
]
lincoln lee commented on FLINK-34522:
-
[~mapohl] I contacted [~dianfu] offline today and he'll take a look as soon as
he can.
> StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time
> class
> -
>
> Key: FLINK-34522
> URL: https://issues.apache.org/jira/browse/FLINK-34522
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
>Affects Versions: 1.19.0
>Reporter: Rui Fan
>Assignee: Rui Fan
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.19.0, 1.20.0
>
>
> FLINK-32570 deprecated the Time class and refactor all Public or
> PublicEvolving apis to use the Java's Duration.
> StateTtlConfig.Builder#cleanupInRocksdbCompactFilter is still using the Time
> class. In general, we expect:
> * Mark {{cleanupInRocksdbCompactFilter(long, Time)}} as {{@Deprecated}}
> * Provide a new cleanupInRocksdbCompactFilter(long, Duration)
> Note: This is exactly what FLINK-32570 does, so I guess FLINK-32570 missed
> cleanupInRocksdbCompactFilter.
> But I found this method is introduced in 1.19(FLINK-30854), so a better
> solution may be: only provide cleanupInRocksdbCompactFilter(long, Duration)
> and don't use Time.
> The deprecated Api should be keep for 2 minor version. IIUC, we cannot remove
> Time related class in Flink 2.0 if we don't deprecate it in 1.19. If so, I
> think it's better to merge this JIRA in 1.19.0 as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class
[
https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821641#comment-17821641
]
Matthias Pohl commented on FLINK-34522:
---
[~lincoln] can you help finding support for finalizing the PR? It looks like
this issue is now the only problem that prevents us from preceding with the RC,
isn't it?
> StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time
> class
> -
>
> Key: FLINK-34522
> URL: https://issues.apache.org/jira/browse/FLINK-34522
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
>Affects Versions: 1.19.0
>Reporter: Rui Fan
>Assignee: Rui Fan
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.19.0, 1.20.0
>
>
> FLINK-32570 deprecated the Time class and refactor all Public or
> PublicEvolving apis to use the Java's Duration.
> StateTtlConfig.Builder#cleanupInRocksdbCompactFilter is still using the Time
> class. In general, we expect:
> * Mark {{cleanupInRocksdbCompactFilter(long, Time)}} as {{@Deprecated}}
> * Provide a new cleanupInRocksdbCompactFilter(long, Duration)
> Note: This is exactly what FLINK-32570 does, so I guess FLINK-32570 missed
> cleanupInRocksdbCompactFilter.
> But I found this method is introduced in 1.19(FLINK-30854), so a better
> solution may be: only provide cleanupInRocksdbCompactFilter(long, Duration)
> and don't use Time.
> The deprecated Api should be keep for 2 minor version. IIUC, we cannot remove
> Time related class in Flink 2.0 if we don't deprecate it in 1.19. If so, I
> think it's better to merge this JIRA in 1.19.0 as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class
[
https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821614#comment-17821614
]
Matthias Pohl commented on FLINK-34522:
---
I increased the priority to Blocker because we agreed to get this change into
1.19 in yesterday's release sync
> StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time
> class
> -
>
> Key: FLINK-34522
> URL: https://issues.apache.org/jira/browse/FLINK-34522
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
>Affects Versions: 1.19.0
>Reporter: Rui Fan
>Assignee: Rui Fan
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.19.0, 1.20.0
>
>
> FLINK-32570 deprecated the Time class and refactor all Public or
> PublicEvolving apis to use the Java's Duration.
> StateTtlConfig.Builder#cleanupInRocksdbCompactFilter is still using the Time
> class. In general, we expect:
> * Mark {{cleanupInRocksdbCompactFilter(long, Time)}} as {{@Deprecated}}
> * Provide a new cleanupInRocksdbCompactFilter(long, Duration)
> Note: This is exactly what FLINK-32570 does, so I guess FLINK-32570 missed
> cleanupInRocksdbCompactFilter.
> But I found this method is introduced in 1.19(FLINK-30854), so a better
> solution may be: only provide cleanupInRocksdbCompactFilter(long, Duration)
> and don't use Time.
> The deprecated Api should be keep for 2 minor version. IIUC, we cannot remove
> Time related class in Flink 2.0 if we don't deprecate it in 1.19. If so, I
> think it's better to merge this JIRA in 1.19.0 as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
