[jira] [Commented] (FLINK-3618) Rename abstract UDF classes in Scatter-Gather implementation
[
https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357648#comment-15357648
]
ASF GitHub Bot commented on FLINK-3618:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2184
> Rename abstract UDF classes in Scatter-Gather implementation
>
>
> Key: FLINK-3618
> URL: https://issues.apache.org/jira/browse/FLINK-3618
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
>Affects Versions: 1.1.0, 1.0.1
>Reporter: Martin Junghanns
>Assignee: Greg Hogan
>Priority: Minor
> Fix For: 1.1.0
>
>
> We now offer three Vertex-centric computing abstractions:
> * Pregel
> * Gather-Sum-Apply
> * Scatter-Gather
> Each of these abstractions provides abstract classes that need to be
> implemented by the user:
> * Pregel: {{ComputeFunction}}
> * GSA: {{GatherFunction}}, {{SumFunction}}, {{ApplyFunction}}
> * Scatter-Gather: {{MessagingFunction}}, {{VertexUpdateFunction}}
> In Pregel and GSA, the names of those functions follow the name of the
> abstraction or the name suggested in the corresponding papers. For
> consistency of the API, I propose to rename {{MessageFunction}} to
> {{ScatterFunction}} and {{VertexUpdateFunction}} to {{GatherFunction}}.
> Also for consistency, I would like to change the parameter order in
> {{Graph.runScatterGatherIteration(VertexUpdateFunction f1, MessagingFunction
> f2}} to {{Graph.runScatterGatherIteration(ScatterFunction f1, GatherFunction
> f2}} (like in {{Graph.runGatherSumApplyFunction(...)}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3618) Rename abstract UDF classes in Scatter-Gather implementation
[
https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357436#comment-15357436
]
ASF GitHub Bot commented on FLINK-3618:
---
Github user vasia commented on the issue:
https://github.com/apache/flink/pull/2184
Thanks for the update @greghogan! +1 to merge.
> Rename abstract UDF classes in Scatter-Gather implementation
>
>
> Key: FLINK-3618
> URL: https://issues.apache.org/jira/browse/FLINK-3618
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
>Affects Versions: 1.1.0, 1.0.1
>Reporter: Martin Junghanns
>Assignee: Greg Hogan
>Priority: Minor
> Fix For: 1.1.0
>
>
> We now offer three Vertex-centric computing abstractions:
> * Pregel
> * Gather-Sum-Apply
> * Scatter-Gather
> Each of these abstractions provides abstract classes that need to be
> implemented by the user:
> * Pregel: {{ComputeFunction}}
> * GSA: {{GatherFunction}}, {{SumFunction}}, {{ApplyFunction}}
> * Scatter-Gather: {{MessagingFunction}}, {{VertexUpdateFunction}}
> In Pregel and GSA, the names of those functions follow the name of the
> abstraction or the name suggested in the corresponding papers. For
> consistency of the API, I propose to rename {{MessageFunction}} to
> {{ScatterFunction}} and {{VertexUpdateFunction}} to {{GatherFunction}}.
> Also for consistency, I would like to change the parameter order in
> {{Graph.runScatterGatherIteration(VertexUpdateFunction f1, MessagingFunction
> f2}} to {{Graph.runScatterGatherIteration(ScatterFunction f1, GatherFunction
> f2}} (like in {{Graph.runGatherSumApplyFunction(...)}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3618) Rename abstract UDF classes in Scatter-Gather implementation
[
https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355723#comment-15355723
]
ASF GitHub Bot commented on FLINK-3618:
---
Github user vasia commented on the issue:
https://github.com/apache/flink/pull/2184
Thanks a lot @greghogan. Everything looks good. Can you please update the
docs too?
> Rename abstract UDF classes in Scatter-Gather implementation
>
>
> Key: FLINK-3618
> URL: https://issues.apache.org/jira/browse/FLINK-3618
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
>Affects Versions: 1.1.0, 1.0.1
>Reporter: Martin Junghanns
>Assignee: Greg Hogan
>Priority: Minor
> Fix For: 1.1.0
>
>
> We now offer three Vertex-centric computing abstractions:
> * Pregel
> * Gather-Sum-Apply
> * Scatter-Gather
> Each of these abstractions provides abstract classes that need to be
> implemented by the user:
> * Pregel: {{ComputeFunction}}
> * GSA: {{GatherFunction}}, {{SumFunction}}, {{ApplyFunction}}
> * Scatter-Gather: {{MessagingFunction}}, {{VertexUpdateFunction}}
> In Pregel and GSA, the names of those functions follow the name of the
> abstraction or the name suggested in the corresponding papers. For
> consistency of the API, I propose to rename {{MessageFunction}} to
> {{ScatterFunction}} and {{VertexUpdateFunction}} to {{GatherFunction}}.
> Also for consistency, I would like to change the parameter order in
> {{Graph.runScatterGatherIteration(VertexUpdateFunction f1, MessagingFunction
> f2}} to {{Graph.runScatterGatherIteration(ScatterFunction f1, GatherFunction
> f2}} (like in {{Graph.runGatherSumApplyFunction(...)}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3618) Rename abstract UDF classes in Scatter-Gather implementation
[
https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355334#comment-15355334
]
ASF GitHub Bot commented on FLINK-3618:
---
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2184
[FLINK-3618] [gelly] Rename abstract UDF classes in Scatter-Gather
implementation
Rename MessageFunction to ScatterFunction and VertexUpdateFunction to
GatherFunction.
Change the parameter order in
Graph.runScatterGatherIteration(VertexUpdateFunction, MessagingFunction) to
Graph.runScatterGatherIteration(ScatterFunction, GatherFunction)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
3618_rename_abstract_udf_classes_in_scatter_gather_implementation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2184
commit 9dd51074104184a5cb6e69affa5775a91de4d9a4
Author: Greg Hogan
Date: 2016-05-06T19:39:38Z
[FLINK-3618] [gelly] Rename abstract UDF classes in Scatter-Gather
implementation
Rename MessageFunction to ScatterFunction
and VertexUpdateFunction to GatherFunction.
Change the parameter order in
Graph.runScatterGatherIteration(VertexUpdateFunction, MessagingFunction)
to
Graph.runScatterGatherIteration(ScatterFunction, GatherFunction)
> Rename abstract UDF classes in Scatter-Gather implementation
>
>
> Key: FLINK-3618
> URL: https://issues.apache.org/jira/browse/FLINK-3618
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
>Affects Versions: 1.1.0, 1.0.1
>Reporter: Martin Junghanns
>Assignee: Greg Hogan
>Priority: Minor
>
> We now offer three Vertex-centric computing abstractions:
> * Pregel
> * Gather-Sum-Apply
> * Scatter-Gather
> Each of these abstractions provides abstract classes that need to be
> implemented by the user:
> * Pregel: {{ComputeFunction}}
> * GSA: {{GatherFunction}}, {{SumFunction}}, {{ApplyFunction}}
> * Scatter-Gather: {{MessagingFunction}}, {{VertexUpdateFunction}}
> In Pregel and GSA, the names of those functions follow the name of the
> abstraction or the name suggested in the corresponding papers. For
> consistency of the API, I propose to rename {{MessageFunction}} to
> {{ScatterFunction}} and {{VertexUpdateFunction}} to {{GatherFunction}}.
> Also for consistency, I would like to change the parameter order in
> {{Graph.runScatterGatherIteration(VertexUpdateFunction f1, MessagingFunction
> f2}} to {{Graph.runScatterGatherIteration(ScatterFunction f1, GatherFunction
> f2}} (like in {{Graph.runGatherSumApplyFunction(...)}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3618) Rename abstract UDF classes in Scatter-Gather implementation
[
https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338595#comment-15338595
]
Vasia Kalavri commented on FLINK-3618:
--
[~greghogan] are you working on this? It would be nice to make this change for
1.1.0. If you don't have time to finish this, let me know and I'll take over.
Thanks!
> Rename abstract UDF classes in Scatter-Gather implementation
>
>
> Key: FLINK-3618
> URL: https://issues.apache.org/jira/browse/FLINK-3618
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
>Affects Versions: 1.1.0, 1.0.1
>Reporter: Martin Junghanns
>Assignee: Greg Hogan
>Priority: Minor
>
> We now offer three Vertex-centric computing abstractions:
> * Pregel
> * Gather-Sum-Apply
> * Scatter-Gather
> Each of these abstractions provides abstract classes that need to be
> implemented by the user:
> * Pregel: {{ComputeFunction}}
> * GSA: {{GatherFunction}}, {{SumFunction}}, {{ApplyFunction}}
> * Scatter-Gather: {{MessagingFunction}}, {{VertexUpdateFunction}}
> In Pregel and GSA, the names of those functions follow the name of the
> abstraction or the name suggested in the corresponding papers. For
> consistency of the API, I propose to rename {{MessageFunction}} to
> {{ScatterFunction}} and {{VertexUpdateFunction}} to {{GatherFunction}}.
> Also for consistency, I would like to change the parameter order in
> {{Graph.runScatterGatherIteration(VertexUpdateFunction f1, MessagingFunction
> f2}} to {{Graph.runScatterGatherIteration(ScatterFunction f1, GatherFunction
> f2}} (like in {{Graph.runGatherSumApplyFunction(...)}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3618) Rename abstract UDF classes in Scatter-Gather implementation
[
https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275179#comment-15275179
]
Martin Junghanns commented on FLINK-3618:
-
[~greghogan] thanks for taking this. I'm currently a bit busy (building graph
pattern matching on Flink).
> Rename abstract UDF classes in Scatter-Gather implementation
>
>
> Key: FLINK-3618
> URL: https://issues.apache.org/jira/browse/FLINK-3618
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
>Affects Versions: 1.1.0, 1.0.1
>Reporter: Martin Junghanns
>Assignee: Greg Hogan
>Priority: Minor
>
> We now offer three Vertex-centric computing abstractions:
> * Pregel
> * Gather-Sum-Apply
> * Scatter-Gather
> Each of these abstractions provides abstract classes that need to be
> implemented by the user:
> * Pregel: {{ComputeFunction}}
> * GSA: {{GatherFunction}}, {{SumFunction}}, {{ApplyFunction}}
> * Scatter-Gather: {{MessagingFunction}}, {{VertexUpdateFunction}}
> In Pregel and GSA, the names of those functions follow the name of the
> abstraction or the name suggested in the corresponding papers. For
> consistency of the API, I propose to rename {{MessageFunction}} to
> {{ScatterFunction}} and {{VertexUpdateFunction}} to {{GatherFunction}}.
> Also for consistency, I would like to change the parameter order in
> {{Graph.runScatterGatherIteration(VertexUpdateFunction f1, MessagingFunction
> f2}} to {{Graph.runScatterGatherIteration(ScatterFunction f1, GatherFunction
> f2}} (like in {{Graph.runGatherSumApplyFunction(...)}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3618) Rename abstract UDF classes in Scatter-Gather implementation
[
https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258097#comment-15258097
]
Vasia Kalavri commented on FLINK-3618:
--
I agree. The sooner we make this change the better. Would any of you like to
take over this issue [~mju], [~greghogan]?
> Rename abstract UDF classes in Scatter-Gather implementation
>
>
> Key: FLINK-3618
> URL: https://issues.apache.org/jira/browse/FLINK-3618
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
>Affects Versions: 1.1.0, 1.0.1
>Reporter: Martin Junghanns
>Priority: Minor
>
> We now offer three Vertex-centric computing abstractions:
> * Pregel
> * Gather-Sum-Apply
> * Scatter-Gather
> Each of these abstractions provides abstract classes that need to be
> implemented by the user:
> * Pregel: {{ComputeFunction}}
> * GSA: {{GatherFunction}}, {{SumFunction}}, {{ApplyFunction}}
> * Scatter-Gather: {{MessagingFunction}}, {{VertexUpdateFunction}}
> In Pregel and GSA, the names of those functions follow the name of the
> abstraction or the name suggested in the corresponding papers. For
> consistency of the API, I propose to rename {{MessageFunction}} to
> {{ScatterFunction}} and {{VertexUpdateFunction}} to {{GatherFunction}}.
> Also for consistency, I would like to change the parameter order in
> {{Graph.runScatterGatherIteration(VertexUpdateFunction f1, MessagingFunction
> f2}} to {{Graph.runScatterGatherIteration(ScatterFunction f1, GatherFunction
> f2}} (like in {{Graph.runGatherSumApplyFunction(...)}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3618) Rename abstract UDF classes in Scatter-Gather implementation
[
https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253888#comment-15253888
]
Greg Hogan commented on FLINK-3618:
---
This looks to be a simple change with no dissension, but is unassigned. Any
reason not to make this change for 1.1.0?
> Rename abstract UDF classes in Scatter-Gather implementation
>
>
> Key: FLINK-3618
> URL: https://issues.apache.org/jira/browse/FLINK-3618
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
>Affects Versions: 1.1.0, 1.0.1
>Reporter: Martin Junghanns
>Priority: Minor
>
> We now offer three Vertex-centric computing abstractions:
> * Pregel
> * Gather-Sum-Apply
> * Scatter-Gather
> Each of these abstractions provides abstract classes that need to be
> implemented by the user:
> * Pregel: {{ComputeFunction}}
> * GSA: {{GatherFunction}}, {{SumFunction}}, {{ApplyFunction}}
> * Scatter-Gather: {{MessagingFunction}}, {{VertexUpdateFunction}}
> In Pregel and GSA, the names of those functions follow the name of the
> abstraction or the name suggested in the corresponding papers. For
> consistency of the API, I propose to rename {{MessageFunction}} to
> {{ScatterFunction}} and {{VertexUpdateFunction}} to {{GatherFunction}}.
> Also for consistency, I would like to change the parameter order in
> {{Graph.runScatterGatherIteration(VertexUpdateFunction f1, MessagingFunction
> f2}} to {{Graph.runScatterGatherIteration(ScatterFunction f1, GatherFunction
> f2}} (like in {{Graph.runGatherSumApplyFunction(...)}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-3618) Rename abstract UDF classes in Scatter-Gather implementation
[
https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199310#comment-15199310
]
Vasia Kalavri commented on FLINK-3618:
--
+1 I think this proposal makes sense.
> Rename abstract UDF classes in Scatter-Gather implementation
>
>
> Key: FLINK-3618
> URL: https://issues.apache.org/jira/browse/FLINK-3618
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
>Affects Versions: 1.1.0, 1.0.1
>Reporter: Martin Junghanns
>Priority: Minor
>
> We now offer three Vertex-centric computing abstractions:
> * Pregel
> * Gather-Sum-Apply
> * Scatter-Gather
> Each of these abstractions provides abstract classes that need to be
> implemented by the user:
> * Pregel: {{ComputeFunction}}
> * GSA: {{GatherFunction}}, {{SumFunction}}, {{ApplyFunction}}
> * Scatter-Gather: {{MessagingFunction}}, {{VertexUpdateFunction}}
> In Pregel and GSA, the names of those functions follow the name of the
> abstraction or the name suggested in the corresponding papers. For
> consistency of the API, I propose to rename {{MessageFunction}} to
> {{ScatterFunction}} and {{VertexUpdateFunction}} to {{GatherFunction}}.
> Also for consistency, I would like to change the parameter order in
> {{Graph.runScatterGatherIteration(VertexUpdateFunction f1, MessagingFunction
> f2}} to {{Graph.runScatterGatherIteration(ScatterFunction f1, GatherFunction
> f2}} (like in {{Graph.runGatherSumApplyFunction(...)}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
