[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293576#comment-15293576
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220642391
  
Merging...we need to fix the RocksDB issue afterwards. In the worst case, 
we'll comment out the relevant test cases for now. The test which seems to 
cause the segfaults is `EventTimeWindowCheckpointingITCase`.


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293573#comment-15293573
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2003


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292998#comment-15292998
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220545613
  
The Travis builds here also segfault in all RocksDB tests. I'm assuming 
these test failed silently in the past since I can't make any connection to the 
test plugin changes.


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291517#comment-15291517
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220388275
  
I get segfaults from RocksDB in my Travis tests:  
https://travis-ci.org/mxm/flink/builds/131412162

Let's see how the builds here go. All in all, looks ready to be merged.


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291081#comment-15291081
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220321817
  
Thanks for looking into the problem and providing a detailed explanation 
@markreddy. I think we're good to go with the newest version of the Surefire 
plugin. I verified the tests 1) fail when errors occur 2) are actually run 
(added some debug output) 3) the number of tests/ITCases remains unchanged.

Just running one more time because I forgot to set the default of 
`reuseForks` to false for the integration tests. Reusing of forks doesn't work 
for some tests because of garbage collection problems (this was the same for 
the Failsafe plugin). Apparently almost all tests pass. So looking forward to 
merging this soon.


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291005#comment-15291005
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user markreddy commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220307660
  
I took a look at the root issue of upgrading to 2.19.1. I'm able to 
reliably reproduce this issue on my laptop. 

When I bump the version I get the same as @tillrohrmann 
`java.lang.NoSuchMethodError:

org.apache.flink.runtime.util.ZooKeeperUtils.startCuratorFramework(Lorg/apache/flink/configuration/Configuration;)Lorg/apache/curator/framework/CuratorFramework`

When running the build in debug mode for both 2.18.1 and 2.19.1 I observed 
some differences in the classpath. 

**2.18.1**
`[DEBUG] boot(compact) classpath:  surefire-booter-2.18.1.jar  
surefire-api-2.18.1.jar  test-classes  classes  
flink-core-1.1-SNAPSHOT.jar.`

**2.19.1**
`[DEBUG] boot(compact) classpath:  surefire-booter-2.19.1.jar  
surefire-api-2.19.1.jar  test-classes  flink-runtime_2.10-1.1-SNAPSHOT.jar  
flink-core-1.1-SNAPSHOT.jar.`

So 2.19.1 has changed behaviour. What is loaded onto the classpath differs, 
in 2.19.1 instead of loading target/classes it loads the actual built jar. 
https://issues.apache.org/jira/browse/SUREFIRE-855 confirms this. 

The issue with this is the final jar has curator shaded while the test 
classes are looking for the unshaded version of curator, as shown by the debug 
output:
`Lorg/apache/curator/framework/CuratorFramework`

If @mxm can get everything working on a lower version thats the easiest 
solution. If not or we want to proceed with moving up in version, at least we 
know the root of the issue and can work from there




> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290882#comment-15290882
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220289348
  
Thanks @mxm ! Eagerly looking forward to the results...


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290851#comment-15290851
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220284867
  
Also pushed a version to my local Travis branch with some deliberately 
failing tests and debug output to see if the above tests are executed correctly 
(and don't fail silently).


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290807#comment-15290807
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220276542
  
I just replaced Failsafe with Surefire. Also updated the version of 
Surefire in a separate commit to see if the classpath issues occur there as 
well (after all it's the same Apache project). 


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290771#comment-15290771
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user aljoscha commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220272107
  
 and make sure that the tests were not silently failing with 2.17


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290770#comment-15290770
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220271685
  
In the surefire JIRA, the "silently ignore exceptions" bug is tagged to 
affect 2.18, not 2.17, so it may be good.

How about:
  - Checking if using surefire solves things
  - If not, use failsafe 2.17 making sure it is not affected


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290761#comment-15290761
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220270745
  
The question is whether this bug was introduced with version `2.18.1` or 
whether it was already there in version `2.17`. We originally bumped the 
version to `2.18` in order to allow retries for the `ElasticSearchSinkITCase`. 
But if it works with the Surefire plugin, then we can also do this.


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290758#comment-15290758
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220269992
  
@aljoscha Yes, I think so too :)


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290755#comment-15290755
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user aljoscha commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220269755
  
But maybe it only works since the exceptions are silently ignored and not 
forwarded?


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290741#comment-15290741
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220267821
  
Reverting back to version `2.17` it works again (at least the plugin does 
not complain about the `NoSuchMethodError`).


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290676#comment-15290676
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220257496
  
I could reproduce it via maven on my machine. It is a bit odd since he 
complains that

```

org.apache.flink.runtime.util.ZooKeeperUtils.startCuratorFramework(Lorg/apache/flink/configuration/Configuration;)Lorg/apache/curator/framework/CuratorFramework
```

Even though `ZooKeeperUtils` is in `flink-runtime`. Maybe it has something 
to do with the shading and that `org.apache.curator.framework.CuratorFramework` 
has been relocated?


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289374#comment-15289374
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220098334
  
Could you reproduce the problem on your laptop?


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289291#comment-15289291
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220087832
  
Couldn't find the problem.


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289243#comment-15289243
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220081808
  
Running the tests from within IntelliJ works fine without a problem. I 
guess it has something todo how failsafe `2.19` handles dependencies.


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289062#comment-15289062
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user aljoscha commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220044747
  
Good fix! The failures went unnoticed before, I guess?


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289008#comment-15289008
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

Github user mxm commented on the pull request:

https://github.com/apache/flink/pull/2003#issuecomment-220035850
  
Tests fail in flink-runtime now. Seem to be class path related problems.
```
  
CheckpointIDCounterTest$ZooKeeperCheckpointIDCounterITCase.org.apache.flink.runtime.checkpoint.CheckpointIDCounterTest$ZooKeeperCheckpointIDCounterITCase
 » NoClassDefFound
  CheckpointIDCounterTest$ZooKeeperCheckpointIDCounterITCase.:53 » 
NoSuchMethod
  
CheckpointIDCounterTest$ZooKeeperCheckpointIDCounterITCase.testSerialIncrementAndGet
 » NoClassDefFound
  CheckpointIDCounterTest$ZooKeeperCheckpointIDCounterITCase.testSetCount 
» NoClassDefFound
  
ZooKeeperCompletedCheckpointStoreITCase.org.apache.flink.runtime.checkpoint.ZooKeeperCompletedCheckpointStoreITCase
 » NoClassDefFound
  ZooKeeperCompletedCheckpointStoreITCase.testAddAndGetLatestCheckpoint » 
NoClassDefFound
  
ZooKeeperCompletedCheckpointStoreITCase.testAddCheckpointMoreThanMaxRetained » 
NoClassDefFound
  ZooKeeperCompletedCheckpointStoreITCase.testDiscardAllCheckpoints » 
NoClassDefFound
  ZooKeeperCompletedCheckpointStoreITCase.testEmptyState » NoClassDefFound 
Could...
  
ZooKeeperCompletedCheckpointStoreITCase.testExceptionOnNoRetainedCheckpoints » 
NoClassDefFound
  ZooKeeperCompletedCheckpointStoreITCase.testGetAllCheckpoints » 
NoClassDefFound
  ZooKeeperCompletedCheckpointStoreITCase.:40 » NoSuchMethod 
org.apache
  
ZooKeeperSubmittedJobGraphsStoreITCase.org.apache.flink.runtime.jobmanager.ZooKeeperSubmittedJobGraphsStoreITCase
 » NoClassDefFound
  ZooKeeperSubmittedJobGraphsStoreITCase.testConcurrentAddJobGraph » 
NoClassDefFound
  ZooKeeperSubmittedJobGraphsStoreITCase.:58 » NoSuchMethod 
org.apache.f...
  ZooKeeperSubmittedJobGraphsStoreITCase.testRecoverJobGraphs » 
NoClassDefFound ...
  
ZooKeeperSubmittedJobGraphsStoreITCase.testUpdateJobGraphYouDidNotGetOrAdd » 
NoClassDefFound
  
ZooKeeperStateHandleStoreITCase.org.apache.flink.runtime.zookeeper.ZooKeeperStateHandleStoreITCase
 » NoClassDefFound
  ZooKeeperStateHandleStoreITCase.testAdd » NoClassDefFound Could not 
initialize...
  ZooKeeperStateHandleStoreITCase.testAddAlreadyExistingPath » 
NoClassDefFound C...
  ZooKeeperStateHandleStoreITCase.testAddDiscardStateHandleAfterFailure » 
NoClassDefFound
  ZooKeeperStateHandleStoreITCase.testAddWithCreateMode » NoClassDefFound 
Could ...
  ZooKeeperStateHandleStoreITCase.testGetAll » NoClassDefFound Could not 
initial...
  ZooKeeperStateHandleStoreITCase.testGetAllSortedByName » NoClassDefFound 
Could...
  ZooKeeperStateHandleStoreITCase.testGetAndExists » NoClassDefFound Could 
not i...
  ZooKeeperStateHandleStoreITCase.testGetNonExistingPath » NoClassDefFound 
Could...
  ZooKeeperStateHandleStoreITCase.testRemove » NoClassDefFound Could not 
initial...
  ZooKeeperStateHandleStoreITCase.testRemoveAndDiscardAllState » 
NoClassDefFound
  ZooKeeperStateHandleStoreITCase.testRemoveAndDiscardState » 
NoClassDefFound Co...
  ZooKeeperStateHandleStoreITCase.testRemoveWithCallback » NoClassDefFound 
Could...
  ZooKeeperStateHandleStoreITCase.testReplace » NoClassDefFound Could not 
initia...
  ZooKeeperStateHandleStoreITCase.:66 » NoSuchMethod 
org.apache.flink.ru...
  ZooKeeperStateHandleStoreITCase.testReplaceNonExistingPath » 
NoClassDefFound C...
```


> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288968#comment-15288968
 ] 

ASF GitHub Bot commented on FLINK-3909:
---

GitHub user mxm opened a pull request:

https://github.com/apache/flink/pull/2003

[FLINK-3909] update Maven Failsafe version

Failures during execution of the integration tests with the Maven
Failsafe plugin were silently ignored on Travis with Maven version
3.2.5. The problem is that failures are not passed on correctly from the
'integration-test' phase (where failures are recorded and tolerated) to
the 'verify' phase.

The cause of the error is most likely SUREFIRE-1127. An exception in the
'integration-test' is sometimes not flushed back to disk where it is
evaluated in the 'verify' phase. Bumping the version of the Failsafe
plugin from 2.18.1 to 2.19.1 fixes the issue.

Tests will fail for this PR ;) 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mxm/flink FLINK-3909

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2003.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2003


commit dc2530d72609032a2ca72e82b83709c46bd5db96
Author: Maximilian Michels 
Date:   2016-05-18T12:34:06Z

[FLINK-3909] update Maven Failsafe version

Failures during execution of the integration tests with the Maven
Failsafe plugin were silently ignored on Travis with Maven version
3.2.5. The problem is that failures are not passed on correctly from the
'integration-test' phase (where failures are recorded and tolerated) to
the 'verify' phase.

The cause of the error is most likely SUREFIRE-1127. An exception in the
'integration-test' is sometimes not flushed back to disk where it is
evaluated in the 'verify' phase. Bumping the version of the Failsafe
plugin from 2.18.1 to 2.19.1 fixes the issue.




> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-17 Thread Maximilian Michels (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286742#comment-15286742
 ] 

Maximilian Michels commented on FLINK-3909:
---

Failing tests are not supposed to fail the entire build in the 
{{integration-test}} phase:

{quote}
The Failsafe Plugin is used during the integration-test and verify phases of 
the build lifecycle to execute the integration tests of an application. The 
Failsafe Plugin will not fail the build during the integration-test phase, thus 
enabling the post-integration-test phase to execute.
{quote}
https://maven.apache.org/surefire/maven-failsafe-plugin/

The verify phase also runs afterwards but doesn't receive the failed tests from 
the previous phase. It appears the test failures are read from the 
{{failsafe-reports}} file in the verify phase.

I verified on my machine that Exceptions thrown in the integration-tests phase 
let maven fail the build on {{mvn verify}}.
{noformat}
[INFO] --- maven-failsafe-plugin:2.18.1:verify (default) @ flink-tests_2.10 ---
[INFO] Failsafe report directory: 
/Users/max/Dev/flink/flink-tests/target/failsafe-reports
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.18.1:verify (default) on 
project flink-tests_2.10: There are test failures.
{noformat}

On Travis, all we get is 
{noformat}
[INFO] --- maven-failsafe-plugin:2.18.1:verify (default) @ flink-tests_2.10 ---
[INFO] Failsafe report directory: 
/home/travis/build/apache/flink/flink-tests/target/failsafe-reports
{noformat}

The {{executions}} are set up correctly in the parent pom. I'll try to 
reproduce the error on Travis with activated debug logging.

> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
>Assignee: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3909) Maven Failsafe plugin may report SUCCESS on failed tests

2016-05-17 Thread Robert Metzger (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286550#comment-15286550
 ] 

Robert Metzger commented on FLINK-3909:
---

Would be interesting to see if this is an issue of the maven version or the 
failsafe plugin version

> Maven Failsafe plugin may report SUCCESS on failed tests
> 
>
> Key: FLINK-3909
> URL: https://issues.apache.org/jira/browse/FLINK-3909
> Project: Flink
>  Issue Type: Bug
>  Components: Build System
>Affects Versions: 1.1.0
>Reporter: Maximilian Michels
> Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)