[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367779#comment-15367779
]
ASF GitHub Bot commented on FLINK-4184:
---
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2220
[FLINK-4184] [metrics] Replace invalid characters in
ScheduledDropwizardReporter
The GraphiteReporter and GangliaReporter report metric names which can
contain invalid
characters. These characters include quotes and dots. In order to properly
report metrics
to these systems, the afore-mentioned characters have to be replaced in
metric names.
The PR also removes quotes from the garbage collector metric name.
The PR sets the default value for TTL in the GangliaReporter to 1, because
-1 causes the
reporter to fail.
R @zentol.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixDropwizardReporters
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2220.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2220
commit d63911499aef10f54d7c4c0774f4f22a520bcc66
Author: Till Rohrmann
Date: 2016-07-08T14:41:39Z
[FLINK-4184] [metrics] Replace invalid characters in
ScheduledDropwizardReporter
The GraphiteReporter and GangliaReporter report metric names which can
contain invalid
characters. These characters include quotes and dots. In order to properly
report metrics
to these systems, the afore-mentioned characters have to be replaced in
metric names.
The PR also removes quotes from the garbage collector metric name.
The PR sets the default value for TTL in the GangliaReporter to 1, because
-1 causes the
reporter to fail.
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367842#comment-15367842
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2220#discussion_r70095846
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/AbstractReporter.java
---
@@ -84,4 +84,24 @@ public void notifyOfRemovedMetric(Metric metric, String
metricName, AbstractMetr
protected String replaceInvalidChars(String metricName) {
return metricName;
}
+
+ /**
+* Method which constructs the fully qualified metric name from the
metric group and the metric
+* name.
+*
+* @param metricName Name of the metric
+* @param group Associated metric group
+* @return Fully qualified metric name
+*/
+ private String constructMetricName(String metricName,
AbstractMetricGroup group) {
+ StringBuilder builder = new StringBuilder();
+
+ for (String componentName : group.getScopeComponents()) {
+
builder.append(replaceInvalidChars(componentName)).append(".");
+ }
+
+ builder.append(replaceInvalidChars(metricName));
--- End diff --
the call to replaceInvalidChars is not required; metric names can only
contain alphanumeric characters. I don't think any reporter will not support
these.
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367871#comment-15367871
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2220#discussion_r70097230
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/AbstractReporter.java
---
@@ -84,4 +84,24 @@ public void notifyOfRemovedMetric(Metric metric, String
metricName, AbstractMetr
protected String replaceInvalidChars(String metricName) {
return metricName;
}
+
+ /**
+* Method which constructs the fully qualified metric name from the
metric group and the metric
+* name.
+*
+* @param metricName Name of the metric
+* @param group Associated metric group
+* @return Fully qualified metric name
+*/
+ private String constructMetricName(String metricName,
AbstractMetricGroup group) {
+ StringBuilder builder = new StringBuilder();
+
+ for (String componentName : group.getScopeComponents()) {
+
builder.append(replaceInvalidChars(componentName)).append(".");
--- End diff --
this is a bit inefficient. The output of this loop is identical for all
metrics on that group, yet is computed for every single metric. Instead you
could modify the getScopeString() method to accept a charFilter argument that
is passed into ScopeFormat.concat().
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367882#comment-15367882
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2220
This PR will heavily conflict with #2219, in their current state we can't
merge one without blocking the other.
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374763#comment-15374763
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2220
True, it conflicts with your proposed changes for the definable metric
group delimiter. I will rebase and adapt this PR wrt #2219.
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375162#comment-15375162
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2220
I rebased on the latest master and introduced a `CharacterFilter`
interface. The `CharacterFilter` allows to filter out invalid characters while
generating the fully qualified metric name.
In order to do this, the `AbstractMetricGroup#generateMetricName` takes a
`CharacterFilter` as argument. The `AbstractReporter` and the
`ScheduledDropwizardReporter` implement this interface to filter out reporter
specific characters.
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376580#comment-15376580
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2220#discussion_r70768940
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/AbstractMetricGroup.java
---
@@ -100,10 +101,29 @@ public AbstractMetricGroup(MetricRegistry registry,
String[] scope) {
* @return fully qualified metric name
*/
public String getMetricIdentifier(String metricName) {
+ return getMetricIdentifier(metricName, null);
+ }
+
+ /**
+* Returns the fully qualified metric name, for example
+* {@code "host-7.taskmanager-2.window_word_count.my-mapper.metricName"}
+*
+* @param metricName metric name
+* @param filter character filter which is applied to the fully
qualified metric name
+* @return fully qualified metric name
+*/
+ public String getMetricIdentifier(String metricName, CharacterFilter
filter) {
if (scopeString == null) {
- scopeString =
ScopeFormat.concat(registry.getDelimiter(), scopeComponents);
+ if (filter != null) {
+ scopeString =
ScopeFormat.concat(registry.getDelimiter(), scopeComponents);
--- End diff --
if no filter is given we will now never assign to scopeString, breaking all
names. We should assume that no filtering is required.
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376589#comment-15376589
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2220
do we have a test that verifies that reporters properly pass their filter
when notified of new metrics?
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376591#comment-15376591
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2220#discussion_r70770115
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/AbstractMetricGroup.java
---
@@ -100,10 +101,29 @@ public AbstractMetricGroup(MetricRegistry registry,
String[] scope) {
* @return fully qualified metric name
*/
public String getMetricIdentifier(String metricName) {
+ return getMetricIdentifier(metricName, null);
+ }
+
+ /**
+* Returns the fully qualified metric name, for example
+* {@code "host-7.taskmanager-2.window_word_count.my-mapper.metricName"}
+*
+* @param metricName metric name
+* @param filter character filter which is applied to the fully
qualified metric name
--- End diff --
this is misleading; it is not applied to the fully qualified name (as
delimiter's are not filtered)
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376672#comment-15376672
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2220#discussion_r70777251
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/AbstractMetricGroup.java
---
@@ -100,10 +101,29 @@ public AbstractMetricGroup(MetricRegistry registry,
String[] scope) {
* @return fully qualified metric name
*/
public String getMetricIdentifier(String metricName) {
+ return getMetricIdentifier(metricName, null);
+ }
+
+ /**
+* Returns the fully qualified metric name, for example
+* {@code "host-7.taskmanager-2.window_word_count.my-mapper.metricName"}
+*
+* @param metricName metric name
+* @param filter character filter which is applied to the fully
qualified metric name
--- End diff --
Will adapt the comment
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376677#comment-15376677
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2220#discussion_r70777393
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/AbstractMetricGroup.java
---
@@ -100,10 +101,29 @@ public AbstractMetricGroup(MetricRegistry registry,
String[] scope) {
* @return fully qualified metric name
*/
public String getMetricIdentifier(String metricName) {
+ return getMetricIdentifier(metricName, null);
+ }
+
+ /**
+* Returns the fully qualified metric name, for example
+* {@code "host-7.taskmanager-2.window_word_count.my-mapper.metricName"}
+*
+* @param metricName metric name
+* @param filter character filter which is applied to the fully
qualified metric name
+* @return fully qualified metric name
+*/
+ public String getMetricIdentifier(String metricName, CharacterFilter
filter) {
if (scopeString == null) {
- scopeString =
ScopeFormat.concat(registry.getDelimiter(), scopeComponents);
+ if (filter != null) {
+ scopeString =
ScopeFormat.concat(registry.getDelimiter(), scopeComponents);
--- End diff --
True, this is wrong. Fill fix it.
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376824#comment-15376824
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2220
Thanks for the review @zentol. I've addressed your comments and added test
cases which verify that the corresponding `MetricReporters` filter out invalid
characters in the fully qualified metric name.
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15377304#comment-15377304
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2220#discussion_r70845241
--- Diff:
flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java
---
@@ -74,6 +75,15 @@ protected ScheduledDropwizardReporter() {
}
//
+ // Getters
+ //
+
+ // used for testing purposes
+ Map getCounters() {
--- End diff --
could we move this into the TestingScheduledDropwizardReporter?
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15377314#comment-15377314
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2220
only one comment left, otherwise +1
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379407#comment-15379407
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2220#discussion_r70977551
--- Diff:
flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java
---
@@ -74,6 +75,15 @@ protected ScheduledDropwizardReporter() {
}
//
+ // Getters
+ //
+
+ // used for testing purposes
+ Map getCounters() {
--- End diff --
We can, if we mark the counters, gauges and histograms fields as protected.
But then we would expose the implementation details to all sub-classes instead
of having a getter which is package private. I think the latter option is a bit
nicer, because it hides the implementation details.
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379409#comment-15379409
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2220
Thanks for the review @zentol. Will be merging this PR then.
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379416#comment-15379416
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2220
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379445#comment-15379445
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2220#discussion_r70979472
--- Diff:
flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java
---
@@ -74,6 +75,15 @@ protected ScheduledDropwizardReporter() {
}
//
+ // Getters
+ //
+
+ // used for testing purposes
+ Map getCounters() {
--- End diff --
You could also access the protected registry and get the counters from
there.
We may not even need the gauges/counters/histograms fields in the
ScheduledDropwizardReporter.
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
[
https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379459#comment-15379459
]
ASF GitHub Bot commented on FLINK-4184:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2220
I would appreciate it if you would give me time to answer to your response
before going ahead with a merge.
> Ganglia and GraphiteReporter report metric names with invalid characters
>
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
>Affects Versions: 1.1.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with
> names which contain invalid characters. For example, quotes are not filtered
> out which can be problematic for Ganglia. Moreover, dots are not replaced
> which causes Graphite to think that an IP address is actually a scoped metric
> name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
