[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167179#comment-16167179
 ] 

ASF GitHub Bot commented on FLINK-7617:
---

Github user KurtYoung commented on the issue:

https://github.com/apache/flink/pull/4668
  
@fhueske sure


> Remove string format in BitSet to improve the performance of 
> BuildSideOuterjoin
> ---
>
> Key: FLINK-7617
> URL: https://issues.apache.org/jira/browse/FLINK-7617
> Project: Flink
>  Issue Type: Improvement
>  Components: Local Runtime
>Reporter: Jingsong Lee
>Assignee: Jingsong Lee
>
> When using BuildSideOuterjoin, will frequently call Bitset.set and get, there 
> will be
> Preconditions.checkArgument (index  = 0,
> String.format ("Input Index [% d] is larger than BitSet available size [% 
> d].", Index, bitLength));
> Of the check, String.format will lead to a sharp decline performance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166369#comment-16166369
 ] 

ASF GitHub Bot commented on FLINK-7617:
---

Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/4668
  
Hi @KurtYoung, do you want to merge this to the `release-1.3` branch as 
well?


> Remove string format in BitSet to improve the performance of 
> BuildSideOuterjoin
> ---
>
> Key: FLINK-7617
> URL: https://issues.apache.org/jira/browse/FLINK-7617
> Project: Flink
>  Issue Type: Improvement
>  Components: Local Runtime
>Reporter: Jingsong Lee
>Assignee: Jingsong Lee
>
> When using BuildSideOuterjoin, will frequently call Bitset.set and get, there 
> will be
> Preconditions.checkArgument (index  = 0,
> String.format ("Input Index [% d] is larger than BitSet available size [% 
> d].", Index, bitLength));
> Of the check, String.format will lead to a sharp decline performance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166291#comment-16166291
 ] 

ASF GitHub Bot commented on FLINK-7617:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4668


> Remove string format in BitSet to improve the performance of 
> BuildSideOuterjoin
> ---
>
> Key: FLINK-7617
> URL: https://issues.apache.org/jira/browse/FLINK-7617
> Project: Flink
>  Issue Type: Improvement
>  Components: Local Runtime
>Reporter: Jingsong Lee
>
> When using BuildSideOuterjoin, will frequently call Bitset.set and get, there 
> will be
> Preconditions.checkArgument (index  = 0,
> String.format ("Input Index [% d] is larger than BitSet available size [% 
> d].", Index, bitLength));
> Of the check, String.format will lead to a sharp decline performance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166162#comment-16166162
 ] 

ASF GitHub Bot commented on FLINK-7617:
---

Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/4668
  
+1 to merge this


> Remove string format in BitSet to improve the performance of 
> BuildSideOuterjoin
> ---
>
> Key: FLINK-7617
> URL: https://issues.apache.org/jira/browse/FLINK-7617
> Project: Flink
>  Issue Type: Improvement
>  Components: Local Runtime
>Reporter: Jingsong Lee
>
> When using BuildSideOuterjoin, will frequently call Bitset.set and get, there 
> will be
> Preconditions.checkArgument (index  = 0,
> String.format ("Input Index [% d] is larger than BitSet available size [% 
> d].", Index, bitLength));
> Of the check, String.format will lead to a sharp decline performance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166161#comment-16166161
 ] 

ASF GitHub Bot commented on FLINK-7617:
---

Github user fhueske commented on a diff in the pull request:

https://github.com/apache/flink/pull/4668#discussion_r138876371
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java 
---
@@ -56,8 +56,7 @@ public void setMemorySegment(MemorySegment memorySegment, 
int offset) {
 * @param index - position
 */
public void set(int index) {
-   Preconditions.checkArgument(index < bitLength && index >= 0, 
-   String.format("Input Index[%d] is larger than BitSet 
available size[%d].", index, bitLength));
+   Preconditions.checkArgument(index < bitLength && index >= 0);
--- End diff --

Just noticed your reply to the same comment on the JIRA issue. You are of 
course right, the varargs will create and fill an array which adds overhead.

So +1 to keep it as it is.


> Remove string format in BitSet to improve the performance of 
> BuildSideOuterjoin
> ---
>
> Key: FLINK-7617
> URL: https://issues.apache.org/jira/browse/FLINK-7617
> Project: Flink
>  Issue Type: Improvement
>  Components: Local Runtime
>Reporter: Jingsong Lee
>
> When using BuildSideOuterjoin, will frequently call Bitset.set and get, there 
> will be
> Preconditions.checkArgument (index  = 0,
> String.format ("Input Index [% d] is larger than BitSet available size [% 
> d].", Index, bitLength));
> Of the check, String.format will lead to a sharp decline performance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166155#comment-16166155
 ] 

ASF GitHub Bot commented on FLINK-7617:
---

Github user fhueske commented on a diff in the pull request:

https://github.com/apache/flink/pull/4668#discussion_r138875420
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java 
---
@@ -56,8 +56,7 @@ public void setMemorySegment(MemorySegment memorySegment, 
int offset) {
 * @param index - position
 */
public void set(int index) {
-   Preconditions.checkArgument(index < bitLength && index >= 0, 
-   String.format("Input Index[%d] is larger than BitSet 
available size[%d].", index, bitLength));
+   Preconditions.checkArgument(index < bitLength && index >= 0);
--- End diff --

Can be changed to 

```
Preconditions.checkArgument(index < bitLength && index >= 0, 
  "Input Index[%d] is larger than BitSet available size[%d].", index, 
bitLength);
``` 
to perserve the error message.


> Remove string format in BitSet to improve the performance of 
> BuildSideOuterjoin
> ---
>
> Key: FLINK-7617
> URL: https://issues.apache.org/jira/browse/FLINK-7617
> Project: Flink
>  Issue Type: Improvement
>  Components: Local Runtime
>Reporter: Jingsong Lee
>
> When using BuildSideOuterjoin, will frequently call Bitset.set and get, there 
> will be
> Preconditions.checkArgument (index  = 0,
> String.format ("Input Index [% d] is larger than BitSet available size [% 
> d].", Index, bitLength));
> Of the check, String.format will lead to a sharp decline performance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread Jingsong Lee (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165979#comment-16165979
 ] 

Jingsong Lee commented on FLINK-7617:
-

[~XKing] Good suggestion, this method is useful.
But I think {{Object ...}} will produce an array, Bitset operation is the most 
granular, let it clean.

> Remove string format in BitSet to improve the performance of 
> BuildSideOuterjoin
> ---
>
> Key: FLINK-7617
> URL: https://issues.apache.org/jira/browse/FLINK-7617
> Project: Flink
>  Issue Type: Improvement
>  Components: Local Runtime
>Reporter: Jingsong Lee
>
> When using BuildSideOuterjoin, will frequently call Bitset.set and get, there 
> will be
> Preconditions.checkArgument (index  = 0,
> String.format ("Input Index [% d] is larger than BitSet available size [% 
> d].", Index, bitLength));
> Of the check, String.format will lead to a sharp decline performance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread Jin Xiaojun (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165962#comment-16165962
 ] 

Jin Xiaojun commented on FLINK-7617:


hi, [~lzljs3620320], I think a better is to call Preconditions.checkArgument 
with errorMeesageTemplate and errorMessageArgs

{code:java}
public static void checkArgument(boolean condition,
@Nullable String errorMessageTemplate,
@Nullable Object... errorMessageArgs) {

if (!condition) {
throw new IllegalArgumentException(format(errorMessageTemplate, 
errorMessageArgs));
}
}
{code}
Do you think so? :) Thanks~

> Remove string format in BitSet to improve the performance of 
> BuildSideOuterjoin
> ---
>
> Key: FLINK-7617
> URL: https://issues.apache.org/jira/browse/FLINK-7617
> Project: Flink
>  Issue Type: Improvement
>  Components: Local Runtime
>Reporter: Jingsong Lee
>
> When using BuildSideOuterjoin, will frequently call Bitset.set and get, there 
> will be
> Preconditions.checkArgument (index  = 0,
> String.format ("Input Index [% d] is larger than BitSet available size [% 
> d].", Index, bitLength));
> Of the check, String.format will lead to a sharp decline performance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165952#comment-16165952
 ] 

ASF GitHub Bot commented on FLINK-7617:
---

Github user KurtYoung commented on the issue:

https://github.com/apache/flink/pull/4668
  
Thanks @JingsongLi for your contribution
LGTM, +1 to merge
cc @fhueske @StephanEwen 


> Remove string format in BitSet to improve the performance of 
> BuildSideOuterjoin
> ---
>
> Key: FLINK-7617
> URL: https://issues.apache.org/jira/browse/FLINK-7617
> Project: Flink
>  Issue Type: Improvement
>  Components: Local Runtime
>Reporter: Jingsong Lee
>
> When using BuildSideOuterjoin, will frequently call Bitset.set and get, there 
> will be
> Preconditions.checkArgument (index  = 0,
> String.format ("Input Index [% d] is larger than BitSet available size [% 
> d].", Index, bitLength));
> Of the check, String.format will lead to a sharp decline performance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165836#comment-16165836
 ] 

ASF GitHub Bot commented on FLINK-7617:
---

Github user JingsongLi commented on the issue:

https://github.com/apache/flink/pull/4668
  
## Performance
  - HashVsSortMiniBenchmark: use buildSideOuterJoin
testBuildFirst:   16s 208ms(before)10s 98ms(after)
testBuildSecond:7s 793ms(before) 6s 67ms(after)

R: @KurtYoung 



> Remove string format in BitSet to improve the performance of 
> BuildSideOuterjoin
> ---
>
> Key: FLINK-7617
> URL: https://issues.apache.org/jira/browse/FLINK-7617
> Project: Flink
>  Issue Type: Improvement
>  Components: Local Runtime
>Reporter: Jingsong Lee
>
> When using BuildSideOuterjoin, will frequently call Bitset.set and get, there 
> will be
> Preconditions.checkArgument (index  = 0,
> String.format ("Input Index [% d] is larger than BitSet available size [% 
> d].", Index, bitLength));
> Of the check, String.format will lead to a sharp decline performance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165830#comment-16165830
 ] 

ASF GitHub Bot commented on FLINK-7617:
---

GitHub user JingsongLi opened a pull request:

https://github.com/apache/flink/pull/4668

[FLINK-7617] Remove string format in BitSet to improve the performance of 
BuildSideOuterjoin

*Thank you very much for contributing to Apache Flink - we are happy that 
you want to help us improve Flink. To help the community review your 
contribution in the best possible way, please go through the checklist below, 
which will get the contribution into a shape in which it can be best reviewed.*

*Please understand that we do not do this to make contributions to Flink a 
hassle. In order to uphold a high standard of quality for code contributions, 
while at the same time managing a large number of contributions, we need 
contributors to prepare the contributions well, and give reviewers enough 
contextual information for the review. Please also understand that 
contributions that do not follow this guide will take longer to review and thus 
typically be picked up with lower priority by the community.*

## Contribution Checklist

  - Make sure that the pull request corresponds to a [JIRA 
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are 
made for typos in JavaDoc or documentation files, which need no JIRA issue.
  
  - Name the pull request in the form "[FLINK-] [component] Title of 
the pull request", where *FLINK-* should be replaced by the actual issue 
number. Skip *component* if you are unsure about which is the best component.
  Typo fixes that have no associated JIRA issue should be named following 
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or 
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.

  - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
  
  - Make sure that the change passes the automated tests, i.e., `mvn clean 
verify` passes. You can set up Travis CI to do that following [this 
guide](http://flink.apache.org/contribute-code.html#best-practices).

  - Each pull request should address only one issue, not mix up code from 
multiple issues.
  
  - Each commit in the pull request has a meaningful commit message 
(including the JIRA id)

  - Once all items of the checklist are addressed, remove the above text 
and this checklist, leaving only the filled out template below.


**(The sections below can be removed for hotfixes of typos)**

## What is the purpose of the change

*(For example: This pull request makes task deployment go through the blob 
server, rather than through RPC. That way we avoid re-transferring them on each 
deployment (during recovery).)*


## Brief change log

*(for example:)*
  - *The TaskInfo is stored in the blob store on job creation time as a 
persistent artifact*
  - *Deployments RPC transmits only the blob storage reference*
  - *TaskManagers retrieve the TaskInfo from the blob cache*


## Verifying this change

*(Please pick either of the following options)*

This change is a trivial rework / code cleanup without any test coverage.

*(or)*

This change is already covered by existing tests, such as *(please describe 
tests)*.

*(or)*

This change added tests and can be verified as follows:

*(example:)*
  - *Added integration tests for end-to-end deployment with large payloads 
(100MB)*
  - *Extended integration test for recovery after master (JobManager) 
failure*
  - *Added test that validates that TaskInfo is transferred only once 
across recoveries*
  - *Manually verified the change by running a 4 node cluser with 2 
JobManagers and 4 TaskManagers, a stateful streaming program, and killing one 
JobManager and two TaskManagers during the execution, verifying that recovery 
happens correctly.*

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (yes / no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / no)
  - The serializers: (yes / no / don't know)
  - The runtime per-record code paths (performance sensitive): (yes / no / 
don't know)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)

## Documentation

  - Does this pull request introduce a new feature? (yes / no)
  - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / not d

[jira] [Commented] (FLINK-7617) Remove string format in BitSet to improve the performance of BuildSideOuterjoin

2017-09-13 Thread Jingsong Lee (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165786#comment-16165786
 ] 

Jingsong Lee commented on FLINK-7617:
-

Can someone give me the right to assign to me?

> Remove string format in BitSet to improve the performance of 
> BuildSideOuterjoin
> ---
>
> Key: FLINK-7617
> URL: https://issues.apache.org/jira/browse/FLINK-7617
> Project: Flink
>  Issue Type: Improvement
>  Components: Local Runtime
>Reporter: Jingsong Lee
>
> When using BuildSideOuterjoin, will frequently call Bitset.set and get, there 
> will be
> Preconditions.checkArgument (index  = 0,
> String.format ("Input Index [% d] is larger than BitSet available size [% 
> d].", Index, bitLength));
> Of the check, String.format will lead to a sharp decline performance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)