Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
snuyanzin commented on PR #23858: URL: https://github.com/apache/flink/pull/23858#issuecomment-1837922338 closing since finally the change introduced such ci failures was at https://github.com/apache/flink/pull/23861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
snuyanzin closed pull request #23858: [FLINK-33727][table] Use different sink names for restore tests URL: https://github.com/apache/flink/pull/23858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
jnh5y commented on PR #23858: URL: https://github.com/apache/flink/pull/23858#issuecomment-1837506076 > Are there any savepoint where currently changed names were participating? Yes. > Then how to find all? Or is it just a question in general? The savepoints are living under directories in https://github.com/apache/flink/tree/master/flink-table/flink-table-planner/src/test/resources/restore-tests, e.g. https://github.com/apache/flink/tree/master/flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-join_1/anti-join/savepoint -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
snuyanzin commented on PR #23858: URL: https://github.com/apache/flink/pull/23858#issuecomment-1837503632 Are there any savepoint where currently changed names were participating? Then how to find all? Or is it just a question in general? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
snuyanzin commented on code in PR #23858:
URL: https://github.com/apache/flink/pull/23858#discussion_r1413116026
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -142,7 +142,7 @@ public class JoinTestPrograms {
.setupTableSource(SOURCE_T1)
.setupTableSource(SOURCE_T2)
.setupTableSink(
-SinkTestStep.newBuilder("MySink")
+
SinkTestStep.newBuilder("NON_WINDOW_INNER_JOIN_WITH_NULL_Sink")
Review Comment:
makes sense, thanks
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
JingGe commented on code in PR #23858:
URL: https://github.com/apache/flink/pull/23858#discussion_r1413009264
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -142,7 +142,7 @@ public class JoinTestPrograms {
.setupTableSource(SOURCE_T1)
.setupTableSource(SOURCE_T2)
.setupTableSink(
-SinkTestStep.newBuilder("MySink")
+
SinkTestStep.newBuilder("NON_WINDOW_INNER_JOIN_WITH_NULL_Sink")
Review Comment:
It is a great idea to use data warehouse like naming convention to improve
the readability. It would be even better to follow the naming convention that
table names commonly use lower case letters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]
flinkbot commented on PR #23858: URL: https://github.com/apache/flink/pull/23858#issuecomment-1837279346 ## CI report: * da62de304dcaeef07bda7d8da7bfc082737b14fa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
