Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]
MartijnVisser merged PR #24805: URL: https://github.com/apache/flink/pull/24805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]
MartijnVisser commented on PR #24805: URL: https://github.com/apache/flink/pull/24805#issuecomment-2163842389 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]
snuyanzin commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636593978
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java:
##
@@ -33,7 +33,10 @@
* no {@code sinkIdentifier} provided, parallelism == 1
*
* @param Input record type
+ * @deprecated This interface will be removed in future versions. Use the new
{@link PrintSink}
+ * interface instead.
Review Comment:
~~I've doubled checked: `PrintSink` implements `Sink` interface which is
going to be deprecated in this PR~~
~~So seems we can't propose to use it.~~
~~and may be mark `PrintSink` as well deprecated~~
~~may be just reference to `org.apache.flink.api.connector.sink2.Sink`~~
UPD: my bad, it already uses v2 version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]
MartijnVisser commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636642416
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java:
##
@@ -33,7 +33,10 @@
* no {@code sinkIdentifier} provided, parallelism == 1
*
* @param Input record type
+ * @deprecated This interface will be removed in future versions. Use the new
{@link PrintSink}
+ * interface instead.
Review Comment:
Verified that `PrintSink` actually uses `Sink2` and not `Sink`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]
snuyanzin commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636593978
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java:
##
@@ -33,7 +33,10 @@
* no {@code sinkIdentifier} provided, parallelism == 1
*
* @param Input record type
+ * @deprecated This interface will be removed in future versions. Use the new
{@link PrintSink}
+ * interface instead.
Review Comment:
I've doubled checked: `PrintSink` implements `Sink` interface which is going
to be deprecated in this PR
So seems we can't propose to use it.
and may be mark `PrintSink` as well deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]
snuyanzin commented on code in PR #24805:
URL: https://github.com/apache/flink/pull/24805#discussion_r1636593978
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java:
##
@@ -33,7 +33,10 @@
* no {@code sinkIdentifier} provided, parallelism == 1
*
* @param Input record type
+ * @deprecated This interface will be removed in future versions. Use the new
{@link PrintSink}
+ * interface instead.
Review Comment:
I've doubled checked: `PrintSink` implements `Sink` interface which is going
to be deprecated in this PR
So seems we can't propose to use it.
and may be mark `PrintSink` as well deprecated
may be just reference to `org.apache.flink.api.connector.sink2.Sink`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]
MartijnVisser commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636585255 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License. org.apache.flink.util.function.SerializableFunction org.apache.flink.util.function.SupplierWithException org.apache.flink.util.function.ThrowingConsumer + Review Comment: I've updated the PR; I'll squash the commits when merging, but added them as separate commits to this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636579070 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License. org.apache.flink.util.function.SerializableFunction org.apache.flink.util.function.SupplierWithException org.apache.flink.util.function.ThrowingConsumer + Review Comment: all others are good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]
MartijnVisser commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636572746 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License. org.apache.flink.util.function.SerializableFunction org.apache.flink.util.function.SupplierWithException org.apache.flink.util.function.ThrowingConsumer + Review Comment: I think it makes sense to also mark those as deprecated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636561747 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License. org.apache.flink.util.function.SerializableFunction org.apache.flink.util.function.SupplierWithException org.apache.flink.util.function.ThrowingConsumer + Review Comment: A question about `DiscardingSink`, `PrintSinkFunction`, `RichSinkFunction` should they also be marked as deprecated? I'm asking since `SinkFunction` is marked as deprecated and those 3 classes implement `SinkFunction` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]
MartijnVisser commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636516611 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License. org.apache.flink.util.function.SerializableFunction org.apache.flink.util.function.SupplierWithException org.apache.flink.util.function.ThrowingConsumer + Review Comment: Yep it is. I'll fix it; is there anything else? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636475673 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License. org.apache.flink.util.function.SerializableFunction org.apache.flink.util.function.SupplierWithException org.apache.flink.util.function.ThrowingConsumer + Review Comment: ```suggestion ``` i think one two is enough 樂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]
flinkbot commented on PR #24805: URL: https://github.com/apache/flink/pull/24805#issuecomment-2116209257 ## CI report: * 50b7df7bcec79ae1d990d8184eb77f32942f8e7a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
