[jira] [Resolved] (GEODE-8559) A race could occur during interest registration combined with transactional operations
[ https://issues.apache.org/jira/browse/GEODE-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Shu resolved GEODE-8559. - Resolution: Duplicate duplicate of GEODE-8926 > A race could occur during interest registration combined with transactional > operations > -- > > Key: GEODE-8559 > URL: https://issues.apache.org/jira/browse/GEODE-8559 > Project: Geode > Issue Type: Bug > Components: client queues, transactions >Affects Versions: 1.1.0 >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: pull-request-available > > During client interest registration, a region snapshot is taken from server > and entry operations after the registration should be sent to client via > Region queue. > There is a race in transaction implementation. Interested client computation > is occurred before the transactional operations is applied to the cache > during commit. This could lead to client does not get the operations through > region snapshot taken, and the transactional operation is not being sent to > the client (as the interested clients were computed before hand.) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9111) CI failure: SerialGatewaySenderEventListenerDUnitTest
Ernest Burghardt created GEODE-9111: --- Summary: CI failure: SerialGatewaySenderEventListenerDUnitTest Key: GEODE-9111 URL: https://issues.apache.org/jira/browse/GEODE-9111 Project: Geode Issue Type: Bug Components: wan Reporter: Ernest Burghardt Task :geode-wan:distributedTest org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderEventListenerDUnitTest > testGatewaySender2EventListenerInvocation FAILED java.lang.AssertionError: Suspicious strings were written to the log during this run. Fix the strings or use IgnoredException.addIgnoredException to ignore. --- Found suspect string in 'dunit_suspect-vm5.log' at line 650 [error 2021/03/31 21:42:09.115 GMT :41005 unshared ordered sender uid=24 dom #1 local port=45967 remote port=37684> tid=166] Exception occurred in CacheListener java.util.concurrent.RejectedExecutionException: Task org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderEventProcessor$2@ca2e465 rejected from java.util.concurrent.ThreadPoolExecutor@78e45162[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 1231] at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2063) at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830) at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1379) at org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderEventProcessor.handlePrimaryDestroy(SerialGatewaySenderEventProcessor.java:616) at org.apache.geode.internal.cache.wan.serial.SerialSecondaryGatewayListener.afterDestroy(SerialSecondaryGatewayListener.java:91) at org.apache.geode.internal.cache.EnumListenerEvent$AFTER_DESTROY.dispatchEvent(EnumListenerEvent.java:178) at org.apache.geode.internal.cache.LocalRegion.dispatchEvent(LocalRegion.java:8262) at org.apache.geode.internal.cache.LocalRegion.dispatchListenerEvent(LocalRegion.java:6971) at org.apache.geode.internal.cache.LocalRegion.invokeDestroyCallbacks(LocalRegion.java:6772) at org.apache.geode.internal.cache.EntryEventImpl.invokeCallbacks(EntryEventImpl.java:2453) at org.apache.geode.internal.cache.entries.AbstractRegionEntry.dispatchListenerEvents(AbstractRegionEntry.java:164) at org.apache.geode.internal.cache.LocalRegion.basicDestroyPart2(LocalRegion.java:6713) at org.apache.geode.internal.cache.map.RegionMapDestroy.destroyExistingEntry(RegionMapDestroy.java:420) at org.apache.geode.internal.cache.map.RegionMapDestroy.handleExistingRegionEntry(RegionMapDestroy.java:244) at org.apache.geode.internal.cache.map.RegionMapDestroy.destroy(RegionMapDestroy.java:152) at org.apache.geode.internal.cache.AbstractRegionMap.destroy(AbstractRegionMap.java:969) at org.apache.geode.internal.cache.LocalRegion.mapDestroy(LocalRegion.java:6502) at org.apache.geode.internal.cache.LocalRegion.mapDestroy(LocalRegion.java:6476) at org.apache.geode.internal.cache.LocalRegionDataView.destroyExistingEntry(LocalRegionDataView.java:59) at org.apache.geode.internal.cache.LocalRegion.basicDestroy(LocalRegion.java:6427) at org.apache.geode.internal.cache.DistributedRegion.basicDestroy(DistributedRegion.java:1730) at org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderQueue$SerialGatewaySenderQueueMetaRegion.basicDestroy(SerialGatewaySenderQueue.java:1413) at org.apache.geode.internal.cache.LocalRegion.localDestroy(LocalRegion.java:2238) at org.apache.geode.internal.cache.DistributedRegion.localDestroy(DistributedRegion.java:967) at org.apache.geode.internal.cache.wan.serial.BatchDestroyOperation$DestroyMessage.operateOnRegion(BatchDestroyOperation.java:121) at org.apache.geode.internal.cache.DistributedCacheOperation$CacheOperationMessage.basicProcess(DistributedCacheOperation.java:1213) at org.apache.geode.internal.cache.DistributedCacheOperation$CacheOperationMessage.process(DistributedCacheOperation.java:1115) at org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376) at org.apache.geode.distributed.internal.DistributionMessage.schedule(DistributionMessage.java:432) at org.apache.geode.distributed.internal.ClusterDistributionManager.scheduleIncomingMessage(ClusterDistributionManager.java:2066) at org.apache.geode.distributed.internal.ClusterDistributionManager.handleIncomingDMsg(ClusterDistributionManager.java:1831) at org.apache.geode.distributed.internal.membership.gms.GMSMembership.dispatchMessage(GMSMembership.java:847) at org.apache.geode.distributed.internal.membership.gms.GMSMembership.handleOrDeferMessage(GMSMembership.java:804) at org.apache.geode.distributed.internal.membership.gms.GMSMembership.processMess
[jira] [Commented] (GEODE-9111) CI failure: SerialGatewaySenderEventListenerDUnitTest
[ https://issues.apache.org/jira/browse/GEODE-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312781#comment-17312781 ] Geode Integration commented on GEODE-9111: -- Seen in [DistributedTestOpenJDK8 #121|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/121] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0104/test-results/distributedTest/1617233161/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0104/test-artifacts/1617233161/distributedtestfiles-OpenJDK8-1.15.0-build.0104.tgz]. > CI failure: SerialGatewaySenderEventListenerDUnitTest > - > > Key: GEODE-9111 > URL: https://issues.apache.org/jira/browse/GEODE-9111 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: Ernest Burghardt >Priority: Major > > > Task :geode-wan:distributedTest > > > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderEventListenerDUnitTest > > testGatewaySender2EventListenerInvocation FAILED > > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > > Fix the strings or use IgnoredException.addIgnoredException to ignore. > > --- > > Found suspect string in 'dunit_suspect-vm5.log' at line 650 > > > [error 2021/03/31 21:42:09.115 GMT 172.17.0.16(663):41005 unshared ordered sender uid=24 dom #1 local > port=45967 remote port=37684> tid=166] Exception occurred in CacheListener > > java.util.concurrent.RejectedExecutionException: Task > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderEventProcessor$2@ca2e465 > rejected from java.util.concurrent.ThreadPoolExecutor@78e45162[Terminated, > pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 1231] > > at > java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2063) > > at > java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830) > > at > java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1379) > > at > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderEventProcessor.handlePrimaryDestroy(SerialGatewaySenderEventProcessor.java:616) > > at > org.apache.geode.internal.cache.wan.serial.SerialSecondaryGatewayListener.afterDestroy(SerialSecondaryGatewayListener.java:91) > > at > org.apache.geode.internal.cache.EnumListenerEvent$AFTER_DESTROY.dispatchEvent(EnumListenerEvent.java:178) > > at > org.apache.geode.internal.cache.LocalRegion.dispatchEvent(LocalRegion.java:8262) > > at > org.apache.geode.internal.cache.LocalRegion.dispatchListenerEvent(LocalRegion.java:6971) > > at > org.apache.geode.internal.cache.LocalRegion.invokeDestroyCallbacks(LocalRegion.java:6772) > > at > org.apache.geode.internal.cache.EntryEventImpl.invokeCallbacks(EntryEventImpl.java:2453) > > at > org.apache.geode.internal.cache.entries.AbstractRegionEntry.dispatchListenerEvents(AbstractRegionEntry.java:164) > > at > org.apache.geode.internal.cache.LocalRegion.basicDestroyPart2(LocalRegion.java:6713) > > at > org.apache.geode.internal.cache.map.RegionMapDestroy.destroyExistingEntry(RegionMapDestroy.java:420) > > at > org.apache.geode.internal.cache.map.RegionMapDestroy.handleExistingRegionEntry(RegionMapDestroy.java:244) > > at > org.apache.geode.internal.cache.map.RegionMapDestroy.destroy(RegionMapDestroy.java:152) > > at > org.apache.geode.internal.cache.AbstractRegionMap.destroy(AbstractRegionMap.java:969) > > at > org.apache.geode.internal.cache.LocalRegion.mapDestroy(LocalRegion.java:6502) > > at > org.apache.geode.internal.cache.LocalRegion.mapDestroy(LocalRegion.java:6476) > > at > org.apache.geode.internal.cache.LocalRegionDataView.destroyExistingEntry(LocalRegionDataView.java:59) > > at > org.apache.geode.internal.cache.LocalRegion.basicDestroy(LocalRegion.java:6427) > > at > org.apache.geode.internal.cache.DistributedRegion.basicDestroy(DistributedRegion.java:1730) > > at > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderQueue$SerialGatewaySenderQueueMetaRegion.basicDestroy(SerialGatewaySenderQueue.java:1413) > > at > org.apache.geode.internal.cache.LocalRegion.localDestroy(LocalRegion.java:2238) > > at > org.apache.geode.internal.cache.DistributedRegion.localDestroy(DistributedRegion.java:967) > > at > org.apache.geode.internal.cache.wan.serial.BatchDestroyOperation$DestroyMessage.operateOnRegion(BatchDestroyOperation.java:121) > > at > org.apache.geode.internal.cache.DistributedCacheOperation$CacheOperationMessage.basicProce
[jira] [Commented] (GEODE-8411) CI Failure: Jetty9CachingClientServerTest. containersShouldShareDataRemovals() fails with comparison failure
[
https://issues.apache.org/jira/browse/GEODE-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312778#comment-17312778
]
Geode Integration commented on GEODE-8411:
--
Seen in [DistributedTestOpenJDK11
#125|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/125]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0104/test-results/distributedTest/1617232951/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0104/test-artifacts/1617232951/distributedtestfiles-OpenJDK11-1.15.0-build.0104.tgz].
> CI Failure: Jetty9CachingClientServerTest.
> containersShouldShareDataRemovals() fails with comparison failure
>
>
> Key: GEODE-8411
> URL: https://issues.apache.org/jira/browse/GEODE-8411
> Project: Geode
> Issue Type: Bug
>Reporter: Benjamin P Ross
>Priority: Major
>
> We saw Jetty9CachingClientServerTest fail with a Comparison failure in a CI
> run.
> {code:java}
> org.apache.geode.session.tests.Jetty9CachingClientServerTest >
> containersShouldShareDataRemovals FAILED
> org.junit.ComparisonFailure: expected:<"[]"> but was:<"[Foo]">
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-9110) Port "important" disabled legacy tests to new framework and enable
Blake Bender created GEODE-9110: --- Summary: Port "important" disabled legacy tests to new framework and enable Key: GEODE-9110 URL: https://issues.apache.org/jira/browse/GEODE-9110 Project: Geode Issue Type: Improvement Components: native client Reporter: Blake Bender After scouring through the code for the disabled legacy tests, we've identified the following list of 31 tests that look important enough to have running in the new framework: testThinClientAfterRegionLive testThinClientCq testThinClientDurableDisconnectNormal testThinClientDurableDisconnectTimeout testThinClientDurableReconnect testThinClientHAMixedRedundancy testThinClientHAQueryFailover testThinClientLRUExpiration testThinClientLargePutAllWithCallBackArg testThinClientLocatorFailover testThinClientPartitionResolver testThinClientPdxDeltaWithNotification testThinClientPdxTests testThinClientPutAll testThinClientPutAllPRSingleHop testThinClientSecurityCQAuthorizationMU testThinClientTXFailover testTimedSemaphore testThinClientCqDurable testThinClientPRSingleHop testThinClientRemoveOps testThinClientSecurityAuthentication testThinClientSecurityAuthenticationMU testThinClientSecurityAuthorization testThinClientSecurityAuthorizationMU testThinClientSecurityDurableCQAuthorizationMU testThinClientSecurityPostAuthorization testThinClientTicket303 testThinClientTicket304 testThinClientTracking testThinClientWriterException When you port a test, submit a PR against this issue, and strike out the test name in the list so we know it's done. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9060) checkMyStateOnMemebers is better not to change the replicates
[ https://issues.apache.org/jira/browse/GEODE-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312742#comment-17312742 ] ASF subversion and git services commented on GEODE-9060: Commit 73850e15d66f08e11cfd8689325795872cc84044 in geode's branch refs/heads/feature/GEODE-9060 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=73850e1 ] GEODE-9060: Remove the member from a copy of replicates as GII candidate if it's not part of the same distributed system, but leave original replicates unchanged. > checkMyStateOnMemebers is better not to change the replicates > - > > Key: GEODE-9060 > URL: https://issues.apache.org/jira/browse/GEODE-9060 > Project: Geode > Issue Type: Bug >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > This is an enhancement to previous GEODE-9003. > The previous fix will remove the members in replicates if it cannot recognize > current member, thus these removed members will not acting as GII provider > candidates. The fix is correct. > However, Dan suggested to keep the replicates as is to be more conservative. > These members will still act as GII provider candidates even they cannot > recognize current member due to the split-brain. Conceptually these members > should be the same as other online members. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9060) checkMyStateOnMemebers is better not to change the replicates
[ https://issues.apache.org/jira/browse/GEODE-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-9060: -- Labels: GeodeOperationAPI pull-request-available (was: GeodeOperationAPI) > checkMyStateOnMemebers is better not to change the replicates > - > > Key: GEODE-9060 > URL: https://issues.apache.org/jira/browse/GEODE-9060 > Project: Geode > Issue Type: Bug >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > This is an enhancement to previous GEODE-9003. > The previous fix will remove the members in replicates if it cannot recognize > current member, thus these removed members will not acting as GII provider > candidates. The fix is correct. > However, Dan suggested to keep the replicates as is to be more conservative. > These members will still act as GII provider candidates even they cannot > recognize current member due to the split-brain. Conceptually these members > should be the same as other online members. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9003) Remove the member from replicates as GII candidate if it's not part of the same distributed system
[ https://issues.apache.org/jira/browse/GEODE-9003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312738#comment-17312738 ] Xiaojian Zhou commented on GEODE-9003: -- It will be fixed in GEODE-9060 instead. > Remove the member from replicates as GII candidate if it's not part of the > same distributed system > -- > > Key: GEODE-9003 > URL: https://issues.apache.org/jira/browse/GEODE-9003 > Project: Geode > Issue Type: Bug >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9094) Package splitting geode-gfsh
[ https://issues.apache.org/jira/browse/GEODE-9094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312732#comment-17312732 ] ASF subversion and git services commented on GEODE-9094: Commit 856df90be392f4fbda203198b74be1bf7626199c in geode's branch refs/heads/develop from Udo Kohlmeyer [ https://gitbox.apache.org/repos/asf?p=geode.git;h=856df90 ] GEODE-9094: Resolve package splitting for geode-gfsh (#6218) Co-authored-by: Udo Kohlmeyer Co-authored-by: Patrick Johnson > Package splitting geode-gfsh > > > Key: GEODE-9094 > URL: https://issues.apache.org/jira/browse/GEODE-9094 > Project: Geode > Issue Type: Sub-task >Reporter: Udo Kohlmeyer >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9109) The local filter (CQ/Interest) computation code seems to be not needed
Anilkumar Gingade created GEODE-9109:
Summary: The local filter (CQ/Interest) computation code seems to
be not needed
Key: GEODE-9109
URL: https://issues.apache.org/jira/browse/GEODE-9109
Project: Geode
Issue Type: Bug
Components: transactions
Affects Versions: 1.15.0
Reporter: Anilkumar Gingade
In TxCallbackEventFactoryImpl.createCallbackEvent() there is logic which looks
to see if filters (CQ/Interests) needs to be computed after receiving the TX
commit message from remote. Since with GEODE-8926 the computation for remote
nodes happen in primary only the logic here looks like unnecessary.
{code:java}
boolean computeFilterInfo = false;
if (filterRoutingInfo != null) {
localRouting = filterRoutingInfo.getLocalFilterInfo();
if (localRouting != null) {
// routing was computed in this VM but may need to perform local
interest processing
computeFilterInfo = !filterRoutingInfo.hasLocalInterestBeenComputed()
&& !localRouting.filterProcessedLocally;
} else {
// routing was computed elsewhere and is in the "remote" routing table
localRouting =
filterRoutingInfo.getFilterInfo(internalRegion.getMyId());
}
if (localRouting != null) {
if (!computeFilterInfo) {
retVal.setLocalFilterInfo(localRouting);
}
}
}
{code}
Check with computeFilterInfo.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-9109) The local filter (CQ/Interest) computation code seems to be not needed
[
https://issues.apache.org/jira/browse/GEODE-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anilkumar Gingade reassigned GEODE-9109:
Assignee: Eric Shu
> The local filter (CQ/Interest) computation code seems to be not needed
> --
>
> Key: GEODE-9109
> URL: https://issues.apache.org/jira/browse/GEODE-9109
> Project: Geode
> Issue Type: Bug
> Components: transactions
>Affects Versions: 1.15.0
>Reporter: Anilkumar Gingade
>Assignee: Eric Shu
>Priority: Major
>
> In TxCallbackEventFactoryImpl.createCallbackEvent() there is logic which
> looks to see if filters (CQ/Interests) needs to be computed after receiving
> the TX commit message from remote. Since with GEODE-8926 the computation for
> remote nodes happen in primary only the logic here looks like unnecessary.
> {code:java}
> boolean computeFilterInfo = false;
> if (filterRoutingInfo != null) {
> localRouting = filterRoutingInfo.getLocalFilterInfo();
> if (localRouting != null) {
> // routing was computed in this VM but may need to perform local
> interest processing
> computeFilterInfo =
> !filterRoutingInfo.hasLocalInterestBeenComputed()
> && !localRouting.filterProcessedLocally;
> } else {
> // routing was computed elsewhere and is in the "remote" routing
> table
> localRouting =
> filterRoutingInfo.getFilterInfo(internalRegion.getMyId());
> }
> if (localRouting != null) {
> if (!computeFilterInfo) {
> retVal.setLocalFilterInfo(localRouting);
> }
> }
> }
> {code}
> Check with computeFilterInfo.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8559) A race could occur during interest registration combined with transactional operations
[ https://issues.apache.org/jira/browse/GEODE-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312722#comment-17312722 ] ASF subversion and git services commented on GEODE-8559: Commit 826ee181ac367cc940e5883250f06393613204a8 in geode's branch refs/heads/support/1.14 from Eric Shu [ https://gitbox.apache.org/repos/asf?p=geode.git;h=826ee18 ] Revert "GEODE-8559: Compute interest routing info after transaction committed. (#5581)" (#6204) (#6234) *This reverts commit 0cc4fa067d0a9ef4166c021b322a281986851ca5. (cherry picked from commit be1fad39c4f7291ad37051ba1e59046f8c52537e) > A race could occur during interest registration combined with transactional > operations > -- > > Key: GEODE-8559 > URL: https://issues.apache.org/jira/browse/GEODE-8559 > Project: Geode > Issue Type: Bug > Components: client queues, transactions >Affects Versions: 1.1.0 >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: pull-request-available > > During client interest registration, a region snapshot is taken from server > and entry operations after the registration should be sent to client via > Region queue. > There is a race in transaction implementation. Interested client computation > is occurred before the transactional operations is applied to the cache > during commit. This could lead to client does not get the operations through > region snapshot taken, and the transactional operation is not being sent to > the client (as the interested clients were computed before hand.) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8761) Add ServerConnection threads to ThreadMonitoring Service
[ https://issues.apache.org/jira/browse/GEODE-8761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312720#comment-17312720 ] ASF subversion and git services commented on GEODE-8761: Commit e1f64269cb34949d942ce87994ec9967236ba1ba in geode's branch refs/heads/support/1.14 from Darrel Schneider [ https://gitbox.apache.org/repos/asf?p=geode.git;h=e1f6426 ] GEODE-8761: detect stuck ServerConnection threads (#6226) (#6236) * The threadMonitorExecutor is now created in the run() method which causes the correct thread id to be set on it. * changed threadMonitorExecutor field from protected to private (cherry picked from commit 89200dca57a3ab57fd98bd1af438944a9aff5f23) > Add ServerConnection threads to ThreadMonitoring Service > > > Key: GEODE-8761 > URL: https://issues.apache.org/jira/browse/GEODE-8761 > Project: Geode > Issue Type: Improvement > Components: regions >Affects Versions: 1.9.2, 1.10.0, 1.11.0, 1.12.0, 1.12.1, 1.13.0, 1.13.1, > 1.14.0 >Reporter: Anilkumar Gingade >Assignee: Darrel Schneider >Priority: Major > Labels: GeodeOperationAPI, blocks-1.14.0, pull-request-available > Fix For: 1.14.0, 1.15.0 > > > In Geode the Thread Monitoring Service (TMS) monitors threads to see if a > they are stuck; it logs a thread dump of stuck threads after a configured > time. This ticket is to add ServerConnection threads to be monitored by TMS. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9003) Remove the member from replicates as GII candidate if it's not part of the same distributed system
[ https://issues.apache.org/jira/browse/GEODE-9003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312695#comment-17312695 ] ASF subversion and git services commented on GEODE-9003: Commit c39cb90cbe42d86ef59b65facddf4697a3222b4c in geode's branch refs/heads/develop from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c39cb90 ] Revert "GEODE-9003: Remove the member from replicates as GII candidate if it'… (#6093)" (#6242) This reverts commit 1fb1dc186cb2aeaa97606a8fe9488128bac2f808. revert it to apply a better fix. > Remove the member from replicates as GII candidate if it's not part of the > same distributed system > -- > > Key: GEODE-9003 > URL: https://issues.apache.org/jira/browse/GEODE-9003 > Project: Geode > Issue Type: Bug >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9096) Package splitting geode-lucene
[ https://issues.apache.org/jira/browse/GEODE-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udo Kohlmeyer resolved GEODE-9096. -- Fix Version/s: 1.15.0 Resolution: Fixed > Package splitting geode-lucene > -- > > Key: GEODE-9096 > URL: https://issues.apache.org/jira/browse/GEODE-9096 > Project: Geode > Issue Type: Sub-task >Reporter: Udo Kohlmeyer >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9100) Package splitting geode-wan
[ https://issues.apache.org/jira/browse/GEODE-9100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312682#comment-17312682 ] ASF subversion and git services commented on GEODE-9100: Commit f584970906c22fd6cb3b416a52bf3e355f993e9a in geode's branch refs/heads/develop from Udo Kohlmeyer [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f584970 ] GEODE-9100: Resolve package splitting for geode-wan (#6222) * GEODE-9100: Resolve package splitting for geode-wan Co-authored-by: Udo Kohlmeyer Co-authored-by: Patrick Johnson > Package splitting geode-wan > --- > > Key: GEODE-9100 > URL: https://issues.apache.org/jira/browse/GEODE-9100 > Project: Geode > Issue Type: Sub-task >Reporter: Udo Kohlmeyer >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9100) Package splitting geode-wan
[ https://issues.apache.org/jira/browse/GEODE-9100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312681#comment-17312681 ] ASF subversion and git services commented on GEODE-9100: Commit f584970906c22fd6cb3b416a52bf3e355f993e9a in geode's branch refs/heads/develop from Udo Kohlmeyer [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f584970 ] GEODE-9100: Resolve package splitting for geode-wan (#6222) * GEODE-9100: Resolve package splitting for geode-wan Co-authored-by: Udo Kohlmeyer Co-authored-by: Patrick Johnson > Package splitting geode-wan > --- > > Key: GEODE-9100 > URL: https://issues.apache.org/jira/browse/GEODE-9100 > Project: Geode > Issue Type: Sub-task >Reporter: Udo Kohlmeyer >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9100) Package splitting geode-wan
[ https://issues.apache.org/jira/browse/GEODE-9100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udo Kohlmeyer resolved GEODE-9100. -- Fix Version/s: 1.15.0 Resolution: Fixed > Package splitting geode-wan > --- > > Key: GEODE-9100 > URL: https://issues.apache.org/jira/browse/GEODE-9100 > Project: Geode > Issue Type: Sub-task >Reporter: Udo Kohlmeyer >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8698) Remove TcrPoolEndPoint::registerDM unnecessary DM lock
[ https://issues.apache.org/jira/browse/GEODE-8698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312638#comment-17312638 ] Mario Salazar de Torres commented on GEODE-8698: Hi [~bbender], I think you might have closed this issue by mistake. Reopening this one as it's still in progress. Also, sorry for not properly updating the issues statuses. For the new issues I am putting some extra care to close them when the associated PRs are merged. > Remove TcrPoolEndPoint::registerDM unnecessary DM lock > -- > > Key: GEODE-8698 > URL: https://issues.apache.org/jira/browse/GEODE-8698 > Project: Geode > Issue Type: Bug > Components: native client >Affects Versions: 1.12.0, 1.13.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > Within TcrPoolEndPoint::registerDM, there is a lock for the DM connection > queue mutex, > which is not really necessary given that, as stated before, having a hard > restriction on the connection number is not a must. > Problem with this lock is that if any of the pool endpoints fails, > connections are on hold while this endpoint is restored. > One of the examples I've seen is that whenever a server goes down, and a pool > with subscription enabled tries to re-open the subscription connection, all > of the threads get locked due to this, even if they are not connecting to the > server which is failing. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-8700) Add the ability to change the partition resolver
[ https://issues.apache.org/jira/browse/GEODE-8700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Salazar de Torres closed GEODE-8700. -- > Add the ability to change the partition resolver > > > Key: GEODE-8700 > URL: https://issues.apache.org/jira/browse/GEODE-8700 > Project: Geode > Issue Type: New Feature > Components: native client >Affects Versions: 1.13.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > *AS A* native client contributor > *I WANT* to be able to mutate partition resolver > *SO THAT* I don't need to create a shared library to specify one. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9078) Remove ACE mutexes
[ https://issues.apache.org/jira/browse/GEODE-9078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312616#comment-17312616 ] ASF GitHub Bot commented on GEODE-9078: --- gaussianrecurrence commented on pull request #776: URL: https://github.com/apache/geode-native/pull/776#issuecomment-811333206 > @gaussianrecurrence Please rebase onto `develop` and we will review. We merged a couple of old outstanding PRs this morning, one of which was _huge_, so there are conflicts to resolve. Will do. However note that there is one thing to look into: ``` TODO. Review mutex usage in PdxType as it is only used to read, so either it's not necessary or we are missing write locks. ``` Anyone happens to know why is there a RW mutex to protect just read access? Seems quite odd to me :S -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ACE mutexes > -- > > Key: GEODE-9078 > URL: https://issues.apache.org/jira/browse/GEODE-9078 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS AN* geode-native contributor > *I WANT TO* remove all occurrences of ACE mutexes > *SO THAT* we can get rid of ACE for good -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9078) Remove ACE mutexes
[ https://issues.apache.org/jira/browse/GEODE-9078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312615#comment-17312615 ] ASF GitHub Bot commented on GEODE-9078: --- gaussianrecurrence removed a comment on pull request #776: URL: https://github.com/apache/geode-native/pull/776#issuecomment-811313472 > @gaussianrecurrence Please rebase onto `develop` and we will review. We merged a couple of old outstanding PRs this morning, one of which was _huge_, so there are conflicts to resolve. Will do. However note that there is one thing to look into: ``` TODO. Review mutex usage in PdxType as it is only used to read, so either it's not necessary or we are missing write locks. ``` Anyone happens to know why is there a RW mutex to protect just read access? Seems quite odd to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ACE mutexes > -- > > Key: GEODE-9078 > URL: https://issues.apache.org/jira/browse/GEODE-9078 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS AN* geode-native contributor > *I WANT TO* remove all occurrences of ACE mutexes > *SO THAT* we can get rid of ACE for good -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9047) Refactor mangement.internal.cli.result package in geode-gfsh
[ https://issues.apache.org/jira/browse/GEODE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-9047. -- Fix Version/s: 1.15.0 Resolution: Fixed > Refactor mangement.internal.cli.result package in geode-gfsh > > > Key: GEODE-9047 > URL: https://issues.apache.org/jira/browse/GEODE-9047 > Project: Geode > Issue Type: Wish > Components: gfsh >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > Refactor mangement.internal.cli.result package in geode-gfsh. Some of the > issues to cleanup are: > * too many inner classes that are public and used outside the package > * most classes do not have unit tests > * CommandResultException is serializable but has a non-serializable, > non-transient field -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9078) Remove ACE mutexes
[ https://issues.apache.org/jira/browse/GEODE-9078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312606#comment-17312606 ] ASF GitHub Bot commented on GEODE-9078: --- gaussianrecurrence commented on pull request #776: URL: https://github.com/apache/geode-native/pull/776#issuecomment-811313472 > @gaussianrecurrence Please rebase onto `develop` and we will review. We merged a couple of old outstanding PRs this morning, one of which was _huge_, so there are conflicts to resolve. Will do. However note that there is one thing to look into: ``` TODO. Review mutex usage in PdxType as it is only used to read, so either it's not necessary or we are missing write locks. ``` Anyone happens to know why is there a RW mutex to protect just read access? Seems quite odd to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ACE mutexes > -- > > Key: GEODE-9078 > URL: https://issues.apache.org/jira/browse/GEODE-9078 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS AN* geode-native contributor > *I WANT TO* remove all occurrences of ACE mutexes > *SO THAT* we can get rid of ACE for good -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8943) Filters (Interest and CQ) is processed multiple times with transactional operation on PR
[ https://issues.apache.org/jira/browse/GEODE-8943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Murmann updated GEODE-8943: - Summary: Filters (Interest and CQ) is processed multiple times with transactional operation on PR (was: Filterrs (Interest and CQ) is processed multiple times with transactional operation on PR) > Filters (Interest and CQ) is processed multiple times with transactional > operation on PR > > > Key: GEODE-8943 > URL: https://issues.apache.org/jira/browse/GEODE-8943 > Project: Geode > Issue Type: Bug > Components: cq, regions >Affects Versions: 1.14.0 >Reporter: Anilkumar Gingade >Assignee: Eric Shu >Priority: Major > Labels: blocks-1.14.0, pull-request-available > > The Filters (interest and CQ) could be getting processed multiple times when > transactional operation is performed. > By design on PR the filters are processed on primary bucket where the data is > applied/changed and adjunct message with interested clients are sent to > remote servers (where the subscription queues are hosted) and replicas; thus > performing filter processing once and sending the message to remote servers > only if the filters are satisfied; it looks like currently the filter > processing is happening both at the primary and secondary buckets for TX > operation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9035) Enable all Hash tests in pipeline native-Redis tests
[ https://issues.apache.org/jira/browse/GEODE-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312585#comment-17312585 ] ASF subversion and git services commented on GEODE-9035: Commit db2412705f96efdebb0b28c3f0e709b4fdbd778f in geode's branch refs/heads/GEODE-9035-backport-to-1.14 from Ray Ingles [ https://gitbox.apache.org/repos/asf?p=geode.git;h=db241270 ] GEODE-9035: Enable Redis TCL tests for all Hash commands (cherry picked from commit fa6103b444d0357e5be34650df20acebdc7e2a7a) > Enable all Hash tests in pipeline native-Redis tests > > > Key: GEODE-9035 > URL: https://issues.apache.org/jira/browse/GEODE-9035 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > All hash commands are now supported in the compatibility-with-Redis > subsystem. This will enable the native Redis integration tests (written in > TCL) to run the Hash test suite against Geode compatibility-with-Redis. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9037) Do not expose unsupported commands in Geode compatibility with Redis
[ https://issues.apache.org/jira/browse/GEODE-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols updated GEODE-9037: Fix Version/s: (was: 1.14.0) > Do not expose unsupported commands in Geode compatibility with Redis > > > Key: GEODE-9037 > URL: https://issues.apache.org/jira/browse/GEODE-9037 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: blocks-1.14.0, pull-request-available > Fix For: 1.15.0 > > > The distinction between 'supported' and 'unsupported' commands is no longer > useful and will be removed. Any commands still listed as unsupported will now > respond if they were unimplemented/unknown. > A system property will allow them to be enabled solely for tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8990) CI Failure: Jetty9CachingClientServerTest.shouldCacheSessionOnClient
[
https://issues.apache.org/jira/browse/GEODE-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312579#comment-17312579
]
Geode Integration commented on GEODE-8990:
--
Seen in [DistributedTestOpenJDK8
#114.2|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/114.2]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0097/test-results/distributedTest/1617173073/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0097/test-artifacts/1617173073/distributedtestfiles-OpenJDK8-1.15.0-build.0097.tgz].
> CI Failure: Jetty9CachingClientServerTest.shouldCacheSessionOnClient
>
>
> Key: GEODE-8990
> URL: https://issues.apache.org/jira/browse/GEODE-8990
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Assignee: Mark Hanson
>Priority: Major
> Labels: pull-request-available
>
> {noformat}
> org.apache.geode.session.tests.Jetty9CachingClientServerTest >
> shouldCacheSessionOnClient FAILED
> org.junit.ComparisonFailure: expected:<[Foo]> but was:<[bogus]>
> at org.junit.Assert.assertEquals(Assert.java:117)
> at org.junit.Assert.assertEquals(Assert.java:146)
> at
> org.apache.geode.session.tests.Jetty9CachingClientServerTest.shouldCacheSessionOnClient(Jetty9CachingClientServerTest.java:65)
> 371 tests completed, 1 failed
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0023/test-results/distributedTest/1614646829/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0023/test-artifacts/1614646829/distributedtestfiles-OpenJDK8-1.15.0-build.0023.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8990) CI Failure: Jetty9CachingClientServerTest.shouldCacheSessionOnClient
[
https://issues.apache.org/jira/browse/GEODE-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312578#comment-17312578
]
Geode Integration commented on GEODE-8990:
--
Seen in [DistributedTestOpenJDK8
#114.3|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/114.3]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0097/test-results/distributedTest/1617185044/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0097/test-artifacts/1617185044/distributedtestfiles-OpenJDK8-1.15.0-build.0097.tgz].
> CI Failure: Jetty9CachingClientServerTest.shouldCacheSessionOnClient
>
>
> Key: GEODE-8990
> URL: https://issues.apache.org/jira/browse/GEODE-8990
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Assignee: Mark Hanson
>Priority: Major
> Labels: pull-request-available
>
> {noformat}
> org.apache.geode.session.tests.Jetty9CachingClientServerTest >
> shouldCacheSessionOnClient FAILED
> org.junit.ComparisonFailure: expected:<[Foo]> but was:<[bogus]>
> at org.junit.Assert.assertEquals(Assert.java:117)
> at org.junit.Assert.assertEquals(Assert.java:146)
> at
> org.apache.geode.session.tests.Jetty9CachingClientServerTest.shouldCacheSessionOnClient(Jetty9CachingClientServerTest.java:65)
> 371 tests completed, 1 failed
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0023/test-results/distributedTest/1614646829/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0023/test-artifacts/1614646829/distributedtestfiles-OpenJDK8-1.15.0-build.0023.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9003) Remove the member from replicates as GII candidate if it's not part of the same distributed system
[ https://issues.apache.org/jira/browse/GEODE-9003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312551#comment-17312551 ] ASF subversion and git services commented on GEODE-9003: Commit fb55d3dcfc3fc7850bec7da7eb6f52955f200ce4 in geode's branch refs/heads/feature/GEODE-9003 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=fb55d3d ] Revert "GEODE-9003: Remove the member from replicates as GII candidate if it'… (#6093)" This reverts commit 1fb1dc186cb2aeaa97606a8fe9488128bac2f808. revert it to apply a better fix. > Remove the member from replicates as GII candidate if it's not part of the > same distributed system > -- > > Key: GEODE-9003 > URL: https://issues.apache.org/jira/browse/GEODE-9003 > Project: Geode > Issue Type: Bug >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9084) Remove Redis GFSH command
[ https://issues.apache.org/jira/browse/GEODE-9084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nabarun Nag reassigned GEODE-9084: -- Assignee: Nabarun Nag > Remove Redis GFSH command > - > > Key: GEODE-9084 > URL: https://issues.apache.org/jira/browse/GEODE-9084 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Nabarun Nag >Assignee: Nabarun Nag >Priority: Major > Labels: blocks-1.14.0 > > Things have changed since we first introduced the concept of Unsupported vs > Unimplemented. > _Original Idea:_ Allow users to use the unsupported commands, log which one's > were being used. Use this information to help drive future iterations. > Given: > * new direction of the product (Tanzu Cache) > * Safety for customers not to get into a bad situation > * Confusion for support, our team, the field > We should remove the ability to use the unsupported commands unless the > system property 'enable-unsupported-commands' is set. > > End result: > * The 'redis' gfsh command is no longer present > * Remove the documentation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8990) CI Failure: Jetty9CachingClientServerTest.shouldCacheSessionOnClient
[
https://issues.apache.org/jira/browse/GEODE-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-8990:
--
Labels: pull-request-available (was: )
> CI Failure: Jetty9CachingClientServerTest.shouldCacheSessionOnClient
>
>
> Key: GEODE-8990
> URL: https://issues.apache.org/jira/browse/GEODE-8990
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Assignee: Mark Hanson
>Priority: Major
> Labels: pull-request-available
>
> {noformat}
> org.apache.geode.session.tests.Jetty9CachingClientServerTest >
> shouldCacheSessionOnClient FAILED
> org.junit.ComparisonFailure: expected:<[Foo]> but was:<[bogus]>
> at org.junit.Assert.assertEquals(Assert.java:117)
> at org.junit.Assert.assertEquals(Assert.java:146)
> at
> org.apache.geode.session.tests.Jetty9CachingClientServerTest.shouldCacheSessionOnClient(Jetty9CachingClientServerTest.java:65)
> 371 tests completed, 1 failed
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0023/test-results/distributedTest/1614646829/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0023/test-artifacts/1614646829/distributedtestfiles-OpenJDK8-1.15.0-build.0023.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-8990) CI Failure: Jetty9CachingClientServerTest.shouldCacheSessionOnClient
[
https://issues.apache.org/jira/browse/GEODE-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Hanson reassigned GEODE-8990:
--
Assignee: Mark Hanson
> CI Failure: Jetty9CachingClientServerTest.shouldCacheSessionOnClient
>
>
> Key: GEODE-8990
> URL: https://issues.apache.org/jira/browse/GEODE-8990
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Assignee: Mark Hanson
>Priority: Major
>
> {noformat}
> org.apache.geode.session.tests.Jetty9CachingClientServerTest >
> shouldCacheSessionOnClient FAILED
> org.junit.ComparisonFailure: expected:<[Foo]> but was:<[bogus]>
> at org.junit.Assert.assertEquals(Assert.java:117)
> at org.junit.Assert.assertEquals(Assert.java:146)
> at
> org.apache.geode.session.tests.Jetty9CachingClientServerTest.shouldCacheSessionOnClient(Jetty9CachingClientServerTest.java:65)
> 371 tests completed, 1 failed
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0023/test-results/distributedTest/1614646829/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0023/test-artifacts/1614646829/distributedtestfiles-OpenJDK8-1.15.0-build.0023.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-8994) Log line for EventId ctor potentially contains garbage string
[
https://issues.apache.org/jira/browse/GEODE-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender resolved GEODE-8994.
-
Resolution: Fixed
> Log line for EventId ctor potentially contains garbage string
> -
>
> Key: GEODE-8994
> URL: https://issues.apache.org/jira/browse/GEODE-8994
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Blake Bender
>Assignee: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> The following logging was recently added to geode-native for debugging:
> ```
> LOGDEBUG("EventId::EventId(%p) - memId=%s, memIdLen=%d, thr=%" PRId64
> ", seq=%" PRId64, this, memId, memIdLen, thr, seq);
> ```
> The variable `memId` in this case is of type `char*` but is NOT a valid
> string, rather just a byte buffer. Logging it this way can potentially print
> out garbage, causing errors in parsing tools like gnmsg or other apps when
> attempting to read it. `memId` needs to be decoded into a string
> representation of the bytes, and that logged, rather than attempting to print
> it out raw.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (GEODE-8994) Log line for EventId ctor potentially contains garbage string
[
https://issues.apache.org/jira/browse/GEODE-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender closed GEODE-8994.
---
> Log line for EventId ctor potentially contains garbage string
> -
>
> Key: GEODE-8994
> URL: https://issues.apache.org/jira/browse/GEODE-8994
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Blake Bender
>Assignee: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> The following logging was recently added to geode-native for debugging:
> ```
> LOGDEBUG("EventId::EventId(%p) - memId=%s, memIdLen=%d, thr=%" PRId64
> ", seq=%" PRId64, this, memId, memIdLen, thr, seq);
> ```
> The variable `memId` in this case is of type `char*` but is NOT a valid
> string, rather just a byte buffer. Logging it this way can potentially print
> out garbage, causing errors in parsing tools like gnmsg or other apps when
> attempting to read it. `memId` needs to be decoded into a string
> representation of the bytes, and that logged, rather than attempting to print
> it out raw.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8926) CQ events can be missed while executing with initial results simultaneously with transactions
[ https://issues.apache.org/jira/browse/GEODE-8926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312526#comment-17312526 ] Eric Shu commented on GEODE-8926: - This addresses the issue in GEODE-8943. > CQ events can be missed while executing with initial results simultaneously > with transactions > - > > Key: GEODE-8926 > URL: https://issues.apache.org/jira/browse/GEODE-8926 > Project: Geode > Issue Type: Bug > Components: cq >Reporter: Barrett Oglesby >Priority: Major > Labels: blocks-1.14.0, pull-request-available > Attachments: cq_with_transaction_behavior.png > > > In this case, the event is not in either the initial results or received in > the CqListener. > A test that shows the behavior is: > - 2 servers with: > - a root PR > - a colocated child PR > In a client, asynchronously: > - start a transaction that: > - does N puts into the root PR > - does 1 put into the child PR > - commit the transaction > In the client: > create N CQs with initial results with: 'select * from /childPR' > When the test succeeds, all the CQs either get the 1 event in their initial > results or in their CqListener. > When the test fails, one or more CQs don't see the event either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9008) gnmsg isn't parsing correctly if the first message on a thread is from the server
[ https://issues.apache.org/jira/browse/GEODE-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9008. - Resolution: Fixed > gnmsg isn't parsing correctly if the first message on a thread is from the > server > -- > > Key: GEODE-9008 > URL: https://issues.apache.org/jira/browse/GEODE-9008 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > > There's a dictionary mapping thread id --> connection, and it is only being > populated on a client-to-server message. Thus, if the first message on a > thread in a log file is server-to-client, there will be no dictionary entry > for the connection, and the gnmsg state machine breaks. We need to add the > tid entry in the dictionary for the connection when we hit a trace line for > receipt of a header from the server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8926) CQ events can be missed while executing with initial results simultaneously with transactions
[ https://issues.apache.org/jira/browse/GEODE-8926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Shu updated GEODE-8926: Labels: blocks-1.14.0 pull-request-available (was: pull-request-available) > CQ events can be missed while executing with initial results simultaneously > with transactions > - > > Key: GEODE-8926 > URL: https://issues.apache.org/jira/browse/GEODE-8926 > Project: Geode > Issue Type: Bug > Components: cq >Reporter: Barrett Oglesby >Priority: Major > Labels: blocks-1.14.0, pull-request-available > Attachments: cq_with_transaction_behavior.png > > > In this case, the event is not in either the initial results or received in > the CqListener. > A test that shows the behavior is: > - 2 servers with: > - a root PR > - a colocated child PR > In a client, asynchronously: > - start a transaction that: > - does N puts into the root PR > - does 1 put into the child PR > - commit the transaction > In the client: > create N CQs with initial results with: 'select * from /childPR' > When the test succeeds, all the CQs either get the 1 event in their initial > results or in their CqListener. > When the test fails, one or more CQs don't see the event either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-9008) gnmsg isn't parsing correctly if the first message on a thread is from the server
[ https://issues.apache.org/jira/browse/GEODE-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9008. --- > gnmsg isn't parsing correctly if the first message on a thread is from the > server > -- > > Key: GEODE-9008 > URL: https://issues.apache.org/jira/browse/GEODE-9008 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > > There's a dictionary mapping thread id --> connection, and it is only being > populated on a client-to-server message. Thus, if the first message on a > thread in a log file is server-to-client, there will be no dictionary entry > for the connection, and the gnmsg state machine breaks. We need to add the > tid entry in the dictionary for the connection when we hit a trace line for > receipt of a header from the server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-9054) Decode ADD_PDX_TYPE message in gnmsg
[ https://issues.apache.org/jira/browse/GEODE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9054. --- > Decode ADD_PDX_TYPE message in gnmsg > > > Key: GEODE-9054 > URL: https://issues.apache.org/jira/browse/GEODE-9054 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-9058) Remove ACE_OS references
[ https://issues.apache.org/jira/browse/GEODE-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9058. --- > Remove ACE_OS references > > > Key: GEODE-9058 > URL: https://issues.apache.org/jira/browse/GEODE-9058 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* geode-native contributor > *I WOULD LIKE* to remove any references to ACE_OS in the source > *SO THAT* we can get rid of ACE for good, eventually. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9054) Decode ADD_PDX_TYPE message in gnmsg
[ https://issues.apache.org/jira/browse/GEODE-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9054. - Resolution: Fixed > Decode ADD_PDX_TYPE message in gnmsg > > > Key: GEODE-9054 > URL: https://issues.apache.org/jira/browse/GEODE-9054 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9058) Remove ACE_OS references
[ https://issues.apache.org/jira/browse/GEODE-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9058. - Resolution: Fixed > Remove ACE_OS references > > > Key: GEODE-9058 > URL: https://issues.apache.org/jira/browse/GEODE-9058 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* geode-native contributor > *I WOULD LIKE* to remove any references to ACE_OS in the source > *SO THAT* we can get rid of ACE for good, eventually. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9078) Remove ACE mutexes
[ https://issues.apache.org/jira/browse/GEODE-9078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312507#comment-17312507 ] ASF GitHub Bot commented on GEODE-9078: --- pdxcodemonkey commented on pull request #776: URL: https://github.com/apache/geode-native/pull/776#issuecomment-811178222 @gaussianrecurrence Please rebase onto `develop` and we will review. We merged a couple of old outstanding PRs this morning, one of which was _huge_, so there are conflicts to resolve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ACE mutexes > -- > > Key: GEODE-9078 > URL: https://issues.apache.org/jira/browse/GEODE-9078 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS AN* geode-native contributor > *I WANT TO* remove all occurrences of ACE mutexes > *SO THAT* we can get rid of ACE for good -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8968) PdxTypeRegistry clean up causes a coredump
[ https://issues.apache.org/jira/browse/GEODE-8968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312506#comment-17312506 ] ASF GitHub Bot commented on GEODE-8968: --- pdxcodemonkey merged pull request #770: URL: https://github.com/apache/geode-native/pull/770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > PdxTypeRegistry clean up causes a coredump > -- > > Key: GEODE-8968 > URL: https://issues.apache.org/jira/browse/GEODE-8968 > Project: Geode > Issue Type: Bug > Components: native client >Affects Versions: 1.14.0 >Reporter: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > *GIVEN* a client/server that with PDX serialization > *WHEN* the client looses connection towards the cluster > *AND* PdxTypeRegistry is cleaned up > *WHILE* a PDX instance is being serialized > *THEN* a coredump occurs > > *Additional information:* > As it seems PdxHelper::serializePdx calls toData -> toDataMutable -> > getPdxType and the later part returns a nullptr if the registry was cleaned > up in the process. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8601) Replace ACE ExpiryTaskManager impl by boost::asio one
[ https://issues.apache.org/jira/browse/GEODE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-8601. - Resolution: Fixed > Replace ACE ExpiryTaskManager impl by boost::asio one > - > > Key: GEODE-8601 > URL: https://issues.apache.org/jira/browse/GEODE-8601 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WOULD LIKE* to replace ACE implementation of ExpiryTaskManager for a > boost::asio one > *SO THAT* all issues related to it disappear, the implementation is more > simple and move away from ACE as it's the project policy for a while. > — > *Additional information* > Current implementation of ExpiryTaskManager is causing issue GEODE-8535 and > some other related, not yet reported. > Also, as I am aware the project is moving away from ACE, so I'd say this is > the perfect oportunity to replace ExpiryTaskManager implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-8601) Replace ACE ExpiryTaskManager impl by boost::asio one
[ https://issues.apache.org/jira/browse/GEODE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-8601. --- > Replace ACE ExpiryTaskManager impl by boost::asio one > - > > Key: GEODE-8601 > URL: https://issues.apache.org/jira/browse/GEODE-8601 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WOULD LIKE* to replace ACE implementation of ExpiryTaskManager for a > boost::asio one > *SO THAT* all issues related to it disappear, the implementation is more > simple and move away from ACE as it's the project policy for a while. > — > *Additional information* > Current implementation of ExpiryTaskManager is causing issue GEODE-8535 and > some other related, not yet reported. > Also, as I am aware the project is moving away from ACE, so I'd say this is > the perfect oportunity to replace ExpiryTaskManager implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-8698) Remove TcrPoolEndPoint::registerDM unnecessary DM lock
[ https://issues.apache.org/jira/browse/GEODE-8698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-8698. --- > Remove TcrPoolEndPoint::registerDM unnecessary DM lock > -- > > Key: GEODE-8698 > URL: https://issues.apache.org/jira/browse/GEODE-8698 > Project: Geode > Issue Type: Bug > Components: native client >Affects Versions: 1.12.0, 1.13.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > Within TcrPoolEndPoint::registerDM, there is a lock for the DM connection > queue mutex, > which is not really necessary given that, as stated before, having a hard > restriction on the connection number is not a must. > Problem with this lock is that if any of the pool endpoints fails, > connections are on hold while this endpoint is restored. > One of the examples I've seen is that whenever a server goes down, and a pool > with subscription enabled tries to re-open the subscription connection, all > of the threads get locked due to this, even if they are not connecting to the > server which is failing. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8698) Remove TcrPoolEndPoint::registerDM unnecessary DM lock
[ https://issues.apache.org/jira/browse/GEODE-8698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-8698. - Resolution: Fixed > Remove TcrPoolEndPoint::registerDM unnecessary DM lock > -- > > Key: GEODE-8698 > URL: https://issues.apache.org/jira/browse/GEODE-8698 > Project: Geode > Issue Type: Bug > Components: native client >Affects Versions: 1.12.0, 1.13.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > Within TcrPoolEndPoint::registerDM, there is a lock for the DM connection > queue mutex, > which is not really necessary given that, as stated before, having a hard > restriction on the connection number is not a must. > Problem with this lock is that if any of the pool endpoints fails, > connections are on hold while this endpoint is restored. > One of the examples I've seen is that whenever a server goes down, and a pool > with subscription enabled tries to re-open the subscription connection, all > of the threads get locked due to this, even if they are not connecting to the > server which is failing. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8968) PdxTypeRegistry clean up causes a coredump
[
https://issues.apache.org/jira/browse/GEODE-8968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312495#comment-17312495
]
ASF GitHub Bot commented on GEODE-8968:
---
pdxcodemonkey commented on a change in pull request #770:
URL: https://github.com/apache/geode-native/pull/770#discussion_r602567152
##
File path: cppcache/integration/test/PdxInstanceTest.cpp
##
@@ -31,32 +27,53 @@
#include
#include
#include
-#include
#include "LocalRegion.hpp"
#include "NestedPdxObject.hpp"
#include "PdxType.hpp"
+#include "mock/CacheListenerMock.hpp"
namespace {
using apache::geode::client::Cache;
using apache::geode::client::CacheableKey;
using apache::geode::client::CacheableString;
+using apache::geode::client::CacheFactory;
+using apache::geode::client::CacheListenerMock;
+using apache::geode::client::CacheRegionHelper;
using apache::geode::client::IllegalStateException;
using apache::geode::client::LocalRegion;
+using apache::geode::client::PdxInstance;
using apache::geode::client::PdxInstanceFactory;
using apache::geode::client::PdxSerializable;
+using apache::geode::client::PoolFactory;
using apache::geode::client::Region;
using apache::geode::client::RegionShortcut;
+using apache::geode::client::SelectResults;
using PdxTests::Address;
using PdxTests::PdxType;
using testobject::ChildPdx;
using testobject::ParentPdx;
+using testing::_;
+using testing::DoAll;
+using testing::InvokeWithoutArgs;
+using testing::Return;
+
const std::string gemfireJsonClassName = "__GEMFIRE_JSON";
+Cache createTestCache() {
+ auto cache = CacheFactory()
+ .set("log-level", "debug")
Review comment:
please set log-level to "none" for integration tests. It makes a big
difference in performance of CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> PdxTypeRegistry clean up causes a coredump
> --
>
> Key: GEODE-8968
> URL: https://issues.apache.org/jira/browse/GEODE-8968
> Project: Geode
> Issue Type: Bug
> Components: native client
>Affects Versions: 1.14.0
>Reporter: Mario Salazar de Torres
>Priority: Major
> Labels: pull-request-available
>
> *GIVEN* a client/server that with PDX serialization
> *WHEN* the client looses connection towards the cluster
> *AND* PdxTypeRegistry is cleaned up
> *WHILE* a PDX instance is being serialized
> *THEN* a coredump occurs
>
> *Additional information:*
> As it seems PdxHelper::serializePdx calls toData -> toDataMutable ->
> getPdxType and the later part returns a nullptr if the registry was cleaned
> up in the process.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8968) PdxTypeRegistry clean up causes a coredump
[ https://issues.apache.org/jira/browse/GEODE-8968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312493#comment-17312493 ] ASF subversion and git services commented on GEODE-8968: Commit 8935ccd0a64fd871a9d8c3d41afa408025a567aa in geode-native's branch refs/heads/develop from Mario Salazar de Torres [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=8935ccd ] GEODE-8968: Fix toDataMutable coredump (#770) - In those scenarios in which Pdx serialization occurs while PdxTypeRegistry is being cleaned up, it happened that NC crashed because it couldn't find the PdxType. - This commit adds retries to Pdx serialization, and in case retries are exhausted, UnknownPdxTypeException is thrown, so it can be handled by the user. - Implemented IT to verify this behaviour. > PdxTypeRegistry clean up causes a coredump > -- > > Key: GEODE-8968 > URL: https://issues.apache.org/jira/browse/GEODE-8968 > Project: Geode > Issue Type: Bug > Components: native client >Affects Versions: 1.14.0 >Reporter: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > *GIVEN* a client/server that with PDX serialization > *WHEN* the client looses connection towards the cluster > *AND* PdxTypeRegistry is cleaned up > *WHILE* a PDX instance is being serialized > *THEN* a coredump occurs > > *Additional information:* > As it seems PdxHelper::serializePdx calls toData -> toDataMutable -> > getPdxType and the later part returns a nullptr if the registry was cleaned > up in the process. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8601) Replace ACE ExpiryTaskManager impl by boost::asio one
[ https://issues.apache.org/jira/browse/GEODE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312490#comment-17312490 ] ASF GitHub Bot commented on GEODE-8601: --- pdxcodemonkey merged pull request #678: URL: https://github.com/apache/geode-native/pull/678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace ACE ExpiryTaskManager impl by boost::asio one > - > > Key: GEODE-8601 > URL: https://issues.apache.org/jira/browse/GEODE-8601 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WOULD LIKE* to replace ACE implementation of ExpiryTaskManager for a > boost::asio one > *SO THAT* all issues related to it disappear, the implementation is more > simple and move away from ACE as it's the project policy for a while. > — > *Additional information* > Current implementation of ExpiryTaskManager is causing issue GEODE-8535 and > some other related, not yet reported. > Also, as I am aware the project is moving away from ACE, so I'd say this is > the perfect oportunity to replace ExpiryTaskManager implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8601) Replace ACE ExpiryTaskManager impl by boost::asio one
[
https://issues.apache.org/jira/browse/GEODE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312485#comment-17312485
]
ASF subversion and git services commented on GEODE-8601:
Commit db82746d2ed72a8d88651e4912a4d3805a2507b3 in geode-native's branch
refs/heads/develop from Mario Salazar de Torres
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=db82746 ]
GEODE-8601: Replace ExpiryTaskManager ACE implementation by boost::asio one
(#678)
* GEODE-8601: Replace ExpiryTaskManager impl
- Now ExpiryTaskManager implementation uses boost::asio.
- Handlers have been replaced by ExpiryTasks, which will serve as base
to each custom expiry task.
- Add a generic ExpiryTask implementation which accepts an
std::function as on_expire callback.
- Refactored EntryExpiryHandler code to use new ExpiryTask implementation.
- Class has been renamed to EntryExpiryTask. However file has not being renamed
so git log is not lost. This will be addressed in the next commit.
- As class has been previously renamed, now files have also been renamed to
EntryExpiryTask.{h,c}pp
- Refactored RegionExpiryHandler to use the new ExpiryTask implementation.
- Renamed RegionExpiryHandler class to RegionExpiryTask. Note that files have
not been renamed in order to avoid git log from being lost. This will be
addressed in the following commit.
- Moved TombstoneEntry into a separate file, for clarity's shake.
- Code has been refactored, so only thing stored is:
* Task ID.
* Validity flag. This is a new flag added to avoid race conditions.
This way, tombstone entries can be now invalidated.
* Actual entry's reference.
- Refactored TomstoneExpiryHandler to use new ExpiryTask implementation.
- TombstoneExpiryHandler class files have been renamed to
TombstoneExpiryTask.{h,c}pp.
- Refactored SuspendedTxExpiryHandler to use the new implementation of the
ExpiryTask.
- Renamed SuspendedTxExpiryHandler to SuspendedTxExpiryTask.
- Renamed SuspendedTxExpiryHandler files to SuspendedTxExpiryTask.{h,c}pp
- Used new id_t types from ExpiryTask rather than the ones from
ExpiryTaskManager for the TXState class.
- Chnged setter names to comply with Google style guide.
- Setters have been left the same as they are part of the public API.
Consider if it's possible to change these names.
- Modified CLI's CacheStatistics to convert between system and steady
time_points.
- Changed CacheImpl to integrate with the new implementation of the
ExpiryTaskManager.
- While doing several refactors to adapt to the new ExpiryTaskManager
implementation it has been considered convinient to split MapEntry.hpp
into several files so everything is more readable.
- Minor refactors.
- TombstoneList has been completely refactored to better adapt the new
implementation of ExpiryTaskManager.
- Now ExpiryTask is created and scheduled in the add method, rather
than having two separate methods.
- Refactored TcrConnectionManager to use the new ExpiryTaskManager
implementation.
- Removed unused code in TcrConnectionManager related to expiry tasks.
- Changes made to integrate with the new implementation of the
ExpiryTaskManager.
- Refactored LocalRegion class to integrate with the new ExpiryTaskManager
implementation.
- system_clock has been replaced by steady_clock which is a monotonic one.
- Refactored PreservedDataExpiryHandler to integrate with the new
implementation of ExpiryTaskManager.
- Renamed PreservedDataExpiryHandler to PreservedDataExpiryTask. File renaming
has been left for the following commit in order to avoid git log from being
lost.
- Added the possiblity to internally reset the task, based on the expiration
time point.
- Fixed preserved expiry task as the entry was being removed from a copy,
rather than the actual map.
- Renamed PreservedDataExpiryHandler class files.
- Refactored PdxRemotePreservedData to integrate with the new ExpiryTaskManager
implementation.
- Added expiration time point.
- Refactored PdxTypeRegistry to integrate new ExpiryTaskManager implementation.
- Refactored ThinClientRedundancyManager to integrate with the new
ExpiryTaskmanager implementation.
- Refactored ThinClientPoolHADM to integrate with the new ExpiryTaskManager
implementation.
- Refactored ThinClientPoolDM to integrate with the new ExpiryTaskManager
implementation.
- Replaced 1ms sleep in cleanStaleConnections by thread yield in order
to guarantee thread is re-scheduled as soon as possible.
- Refactored CLI cache MemoryPressureHandler to integrate with the new
ExpiryTaskManager implementation.
- Renamed class to MemoryPressureTask. Files renaming left to the next commit
to avoid git log from being lost.
- Change integrated in DistributedSystem.
- Note that this task is not schduled per-se, however has been lef
[jira] [Commented] (GEODE-8601) Replace ACE ExpiryTaskManager impl by boost::asio one
[
https://issues.apache.org/jira/browse/GEODE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312487#comment-17312487
]
ASF subversion and git services commented on GEODE-8601:
Commit db82746d2ed72a8d88651e4912a4d3805a2507b3 in geode-native's branch
refs/heads/develop from Mario Salazar de Torres
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=db82746 ]
GEODE-8601: Replace ExpiryTaskManager ACE implementation by boost::asio one
(#678)
* GEODE-8601: Replace ExpiryTaskManager impl
- Now ExpiryTaskManager implementation uses boost::asio.
- Handlers have been replaced by ExpiryTasks, which will serve as base
to each custom expiry task.
- Add a generic ExpiryTask implementation which accepts an
std::function as on_expire callback.
- Refactored EntryExpiryHandler code to use new ExpiryTask implementation.
- Class has been renamed to EntryExpiryTask. However file has not being renamed
so git log is not lost. This will be addressed in the next commit.
- As class has been previously renamed, now files have also been renamed to
EntryExpiryTask.{h,c}pp
- Refactored RegionExpiryHandler to use the new ExpiryTask implementation.
- Renamed RegionExpiryHandler class to RegionExpiryTask. Note that files have
not been renamed in order to avoid git log from being lost. This will be
addressed in the following commit.
- Moved TombstoneEntry into a separate file, for clarity's shake.
- Code has been refactored, so only thing stored is:
* Task ID.
* Validity flag. This is a new flag added to avoid race conditions.
This way, tombstone entries can be now invalidated.
* Actual entry's reference.
- Refactored TomstoneExpiryHandler to use new ExpiryTask implementation.
- TombstoneExpiryHandler class files have been renamed to
TombstoneExpiryTask.{h,c}pp.
- Refactored SuspendedTxExpiryHandler to use the new implementation of the
ExpiryTask.
- Renamed SuspendedTxExpiryHandler to SuspendedTxExpiryTask.
- Renamed SuspendedTxExpiryHandler files to SuspendedTxExpiryTask.{h,c}pp
- Used new id_t types from ExpiryTask rather than the ones from
ExpiryTaskManager for the TXState class.
- Chnged setter names to comply with Google style guide.
- Setters have been left the same as they are part of the public API.
Consider if it's possible to change these names.
- Modified CLI's CacheStatistics to convert between system and steady
time_points.
- Changed CacheImpl to integrate with the new implementation of the
ExpiryTaskManager.
- While doing several refactors to adapt to the new ExpiryTaskManager
implementation it has been considered convinient to split MapEntry.hpp
into several files so everything is more readable.
- Minor refactors.
- TombstoneList has been completely refactored to better adapt the new
implementation of ExpiryTaskManager.
- Now ExpiryTask is created and scheduled in the add method, rather
than having two separate methods.
- Refactored TcrConnectionManager to use the new ExpiryTaskManager
implementation.
- Removed unused code in TcrConnectionManager related to expiry tasks.
- Changes made to integrate with the new implementation of the
ExpiryTaskManager.
- Refactored LocalRegion class to integrate with the new ExpiryTaskManager
implementation.
- system_clock has been replaced by steady_clock which is a monotonic one.
- Refactored PreservedDataExpiryHandler to integrate with the new
implementation of ExpiryTaskManager.
- Renamed PreservedDataExpiryHandler to PreservedDataExpiryTask. File renaming
has been left for the following commit in order to avoid git log from being
lost.
- Added the possiblity to internally reset the task, based on the expiration
time point.
- Fixed preserved expiry task as the entry was being removed from a copy,
rather than the actual map.
- Renamed PreservedDataExpiryHandler class files.
- Refactored PdxRemotePreservedData to integrate with the new ExpiryTaskManager
implementation.
- Added expiration time point.
- Refactored PdxTypeRegistry to integrate new ExpiryTaskManager implementation.
- Refactored ThinClientRedundancyManager to integrate with the new
ExpiryTaskmanager implementation.
- Refactored ThinClientPoolHADM to integrate with the new ExpiryTaskManager
implementation.
- Refactored ThinClientPoolDM to integrate with the new ExpiryTaskManager
implementation.
- Replaced 1ms sleep in cleanStaleConnections by thread yield in order
to guarantee thread is re-scheduled as soon as possible.
- Refactored CLI cache MemoryPressureHandler to integrate with the new
ExpiryTaskManager implementation.
- Renamed class to MemoryPressureTask. Files renaming left to the next commit
to avoid git log from being lost.
- Change integrated in DistributedSystem.
- Note that this task is not schduled per-se, however has been lef
[jira] [Commented] (GEODE-8543) Client disconnects from server due to exception on other server
[ https://issues.apache.org/jira/browse/GEODE-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312481#comment-17312481 ] ASF GitHub Bot commented on GEODE-8543: --- pdxcodemonkey merged pull request #705: URL: https://github.com/apache/geode-native/pull/705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Client disconnects from server due to exception on other server > --- > > Key: GEODE-8543 > URL: https://issues.apache.org/jira/browse/GEODE-8543 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Alberto Bustamante Reyes >Assignee: Jakov Varenina >Priority: Major > Labels: pull-request-available > > In ThinClientBaseDM::handleEPError when the client receives an exception from > a given endpoint, it will mark that server dead if in the exception contains > "java.lang.OutOfMemoryError", > "org.apache.geode.distributed.ShutdownException" or > "org.apache.geode.cache.CacheClosedException" ( in > ThinClientBaseDM::unrecoverableServerError() ) > The problem is that the server causing the exception can be a different > server than the endpoint the client is connected to. In that case, > the client will wrongly close a connection to a working server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-8543) Client disconnects from server due to exception on other server
[ https://issues.apache.org/jira/browse/GEODE-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-8543. --- > Client disconnects from server due to exception on other server > --- > > Key: GEODE-8543 > URL: https://issues.apache.org/jira/browse/GEODE-8543 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Alberto Bustamante Reyes >Assignee: Jakov Varenina >Priority: Major > Labels: pull-request-available > > In ThinClientBaseDM::handleEPError when the client receives an exception from > a given endpoint, it will mark that server dead if in the exception contains > "java.lang.OutOfMemoryError", > "org.apache.geode.distributed.ShutdownException" or > "org.apache.geode.cache.CacheClosedException" ( in > ThinClientBaseDM::unrecoverableServerError() ) > The problem is that the server causing the exception can be a different > server than the endpoint the client is connected to. In that case, > the client will wrongly close a connection to a working server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8543) Client disconnects from server due to exception on other server
[ https://issues.apache.org/jira/browse/GEODE-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-8543. - Resolution: Fixed > Client disconnects from server due to exception on other server > --- > > Key: GEODE-8543 > URL: https://issues.apache.org/jira/browse/GEODE-8543 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Alberto Bustamante Reyes >Assignee: Jakov Varenina >Priority: Major > Labels: pull-request-available > > In ThinClientBaseDM::handleEPError when the client receives an exception from > a given endpoint, it will mark that server dead if in the exception contains > "java.lang.OutOfMemoryError", > "org.apache.geode.distributed.ShutdownException" or > "org.apache.geode.cache.CacheClosedException" ( in > ThinClientBaseDM::unrecoverableServerError() ) > The problem is that the server causing the exception can be a different > server than the endpoint the client is connected to. In that case, > the client will wrongly close a connection to a working server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8543) Client disconnects from server due to exception on other server
[ https://issues.apache.org/jira/browse/GEODE-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312476#comment-17312476 ] ASF subversion and git services commented on GEODE-8543: Commit 391a84f8b212147f78b22d68bafe6ee78464d1ba in geode-native's branch refs/heads/develop from Jakov Varenina [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=391a84f ] GEODE-8543: Fix for uneccessary connections closure (#705) * Test to reproduce issue * Dont close connection to ep if CacheClosedException detected * Added hook that checks for disconnections * Added test hook: - setDisconnectionTest() - activates test hook which then stores all endpoints that are disconnected from client. - getDisconnectedEPs() - retrives all disconnected endpoints. * Test framework updated: - Assign port to server using Framework::getAvailablePort() function - Interface updated with method that retrieves server port - made server address and port configurable in framework - used existing counter numberOfTimesFailed() from TcrEndpoint to check for disconnections of servers - removed used static methods and variables Co-authored-by: Alberto Bustamante Reyes > Client disconnects from server due to exception on other server > --- > > Key: GEODE-8543 > URL: https://issues.apache.org/jira/browse/GEODE-8543 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Alberto Bustamante Reyes >Assignee: Jakov Varenina >Priority: Major > Labels: pull-request-available > > In ThinClientBaseDM::handleEPError when the client receives an exception from > a given endpoint, it will mark that server dead if in the exception contains > "java.lang.OutOfMemoryError", > "org.apache.geode.distributed.ShutdownException" or > "org.apache.geode.cache.CacheClosedException" ( in > ThinClientBaseDM::unrecoverableServerError() ) > The problem is that the server causing the exception can be a different > server than the endpoint the client is connected to. In that case, > the client will wrongly close a connection to a working server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9068) Update documents to show removal of unsupported commands category
[ https://issues.apache.org/jira/browse/GEODE-9068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-9068: -- Labels: blocks-1.14.0 pull-request-available (was: blocks-1.14.0) > Update documents to show removal of unsupported commands category > - > > Key: GEODE-9068 > URL: https://issues.apache.org/jira/browse/GEODE-9068 > Project: Geode > Issue Type: Task > Components: redis >Reporter: John Hutchison >Assignee: John Hutchison >Priority: Major > Labels: blocks-1.14.0, pull-request-available > > update docs to represent changes in > https://issues.apache.org/jira/browse/GEODE-9037 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9068) Update documents to show removal of unsupported commands category
[ https://issues.apache.org/jira/browse/GEODE-9068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Hutchison updated GEODE-9068: -- Summary: Update documents to show removal of unsupported commands category (was: Update Documents to show removal of unsupported commands category) > Update documents to show removal of unsupported commands category > - > > Key: GEODE-9068 > URL: https://issues.apache.org/jira/browse/GEODE-9068 > Project: Geode > Issue Type: Task > Components: redis >Reporter: John Hutchison >Assignee: John Hutchison >Priority: Major > Labels: blocks-1.14.0 > > update docs to represent changes in > https://issues.apache.org/jira/browse/GEODE-9037 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9068) Update Documents to show removal of unsupported commands category
[ https://issues.apache.org/jira/browse/GEODE-9068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Hutchison updated GEODE-9068: -- Labels: blocks-1.14.0 (was: 1) > Update Documents to show removal of unsupported commands category > - > > Key: GEODE-9068 > URL: https://issues.apache.org/jira/browse/GEODE-9068 > Project: Geode > Issue Type: Task > Components: redis >Reporter: John Hutchison >Assignee: John Hutchison >Priority: Major > Labels: blocks-1.14.0 > > update docs to represent changes in > https://issues.apache.org/jira/browse/GEODE-9037 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9068) Update Documents to show removal of unsupported commands category
[ https://issues.apache.org/jira/browse/GEODE-9068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Hutchison updated GEODE-9068: -- Labels: 1 (was: ) > Update Documents to show removal of unsupported commands category > - > > Key: GEODE-9068 > URL: https://issues.apache.org/jira/browse/GEODE-9068 > Project: Geode > Issue Type: Task > Components: redis >Reporter: John Hutchison >Assignee: John Hutchison >Priority: Major > Labels: 1 > > update docs to represent changes in > https://issues.apache.org/jira/browse/GEODE-9037 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9068) Update Documents to show removal of unsupported commands category
[ https://issues.apache.org/jira/browse/GEODE-9068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Hutchison reassigned GEODE-9068: - Assignee: John Hutchison > Update Documents to show removal of unsupported commands category > - > > Key: GEODE-9068 > URL: https://issues.apache.org/jira/browse/GEODE-9068 > Project: Geode > Issue Type: Task > Components: redis >Reporter: John Hutchison >Assignee: John Hutchison >Priority: Major > > update docs to represent changes in > https://issues.apache.org/jira/browse/GEODE-9037 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9037) Do not expose unsupported commands in Geode compatibility with Redis
[ https://issues.apache.org/jira/browse/GEODE-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9037. --- Resolution: Fixed Merged on both open and closed side. > Do not expose unsupported commands in Geode compatibility with Redis > > > Key: GEODE-9037 > URL: https://issues.apache.org/jira/browse/GEODE-9037 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: blocks-1.14.0, pull-request-available > Fix For: 1.14.0, 1.15.0 > > > The distinction between 'supported' and 'unsupported' commands is no longer > useful and will be removed. Any commands still listed as unsupported will now > respond if they were unimplemented/unknown. > A system property will allow them to be enabled solely for tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9037) Do not expose unsupported commands in Geode compatibility with Redis
[ https://issues.apache.org/jira/browse/GEODE-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312393#comment-17312393 ] ASF subversion and git services commented on GEODE-9037: Commit cf4c3395644af48bcbda81bef7a6d1e01b2c47cf in geode's branch refs/heads/develop from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=cf4c339 ] Revert "Revert "Merge pull request #6155 from ringles/GEODE-9037-do-not-expose-unsupported-commands" (#6202)" (#6231) This reverts commit 55ee370ca436f10f5acd383867039ccc1055fd27. > Do not expose unsupported commands in Geode compatibility with Redis > > > Key: GEODE-9037 > URL: https://issues.apache.org/jira/browse/GEODE-9037 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: blocks-1.14.0, pull-request-available > Fix For: 1.14.0, 1.15.0 > > > The distinction between 'supported' and 'unsupported' commands is no longer > useful and will be removed. Any commands still listed as unsupported will now > respond if they were unimplemented/unknown. > A system property will allow them to be enabled solely for tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9108) Remove no-ack from existing tests
Michael Martell created GEODE-9108: -- Summary: Remove no-ack from existing tests Key: GEODE-9108 URL: https://issues.apache.org/jira/browse/GEODE-9108 Project: Geode Issue Type: Test Components: native client Reporter: Michael Martell Many of the geode-native legacy tests use no-ack for the region scope attribute. This has been shown to be the source of intermittent failures of many of the tests, and should should be removed. As region scope is purely server side functionality, there should little to no need to test it from a client's perspective. If there is a use case for such a no-ack test from geode-native, it should be captured in a new test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8543) Client disconnects from server due to exception on other server
[ https://issues.apache.org/jira/browse/GEODE-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312198#comment-17312198 ] ASF GitHub Bot commented on GEODE-8543: --- jvarenina commented on pull request #705: URL: https://github.com/apache/geode-native/pull/705#issuecomment-810896161 Hi @pdxcodemonkey , thank you for the review and the helpful hint (I had clang-format v6). I have formatted and pushed the code. Lets hope that test on Windows will pass this time :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Client disconnects from server due to exception on other server > --- > > Key: GEODE-8543 > URL: https://issues.apache.org/jira/browse/GEODE-8543 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Alberto Bustamante Reyes >Assignee: Jakov Varenina >Priority: Major > Labels: pull-request-available > > In ThinClientBaseDM::handleEPError when the client receives an exception from > a given endpoint, it will mark that server dead if in the exception contains > "java.lang.OutOfMemoryError", > "org.apache.geode.distributed.ShutdownException" or > "org.apache.geode.cache.CacheClosedException" ( in > ThinClientBaseDM::unrecoverableServerError() ) > The problem is that the server causing the exception can be a different > server than the endpoint the client is connected to. In that case, > the client will wrongly close a connection to a working server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
