[jira] [Commented] (GEODE-9299) CI Failure: WANRollingUpgradeSecondaryEventsNotReprocessedAfterOldSiteMemberFailover > testSecondaryEventsNotReprocessedAfterOldSiteMemberFailover
[
https://issues.apache.org/jira/browse/GEODE-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353642#comment-17353642
]
ASF subversion and git services commented on GEODE-9299:
Commit fe45da843dc383450d8d5aa24b8b8855034c6b14 in geode's branch
refs/heads/feature/GEODE-9299 from Barry Oglesby
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fe45da8 ]
GEODE-9299: Force CI to re-run
> CI Failure:
> WANRollingUpgradeSecondaryEventsNotReprocessedAfterOldSiteMemberFailover >
> testSecondaryEventsNotReprocessedAfterOldSiteMemberFailover
> --
>
> Key: GEODE-9299
> URL: https://issues.apache.org/jira/browse/GEODE-9299
> Project: Geode
> Issue Type: Bug
> Components: wan
>Affects Versions: 1.15.0
>Reporter: Hale Bales
>Assignee: Barrett Oglesby
>Priority: Major
> Labels: pull-request-available
>
> {code:java}
> org.apache.geode.cache.wan.WANRollingUpgradeSecondaryEventsNotReprocessedAfterOldSiteMemberFailover
> > testSecondaryEventsNotReprocessedAfterOldSiteMemberFailover[from_v1.12.2]
> FAILED
> java.lang.AssertionError: expected:<100> but was:<101>
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.failNotEquals(Assert.java:835)
> at org.junit.Assert.assertEquals(Assert.java:647)
> at org.junit.Assert.assertEquals(Assert.java:633)
> at
> org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest.stopSenderAndVerifyEvents(WANRollingUpgradeDUnitTest.java:227)
> at
> org.apache.geode.cache.wan.WANRollingUpgradeSecondaryEventsNotReprocessedAfterOldSiteMemberFailover.testSecondaryEventsNotReprocessedAfterOldSiteMemberFailover(WANRollingUpgradeSecondaryEventsNotReprocessedAfterOldSiteMemberFailover.java:98)
> {code}
> CI Failure:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/UpgradeTestOpenJDK11/builds/229#B
> Artifacts Available here:
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0253/test-results/upgradeTest/1621635640/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9071) CI Failure: PartitionedRegionCqQueryDUnitTest > testRemoveAllWithCQLocalDestroy
[
https://issues.apache.org/jira/browse/GEODE-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353582#comment-17353582
]
Geode Integration commented on GEODE-9071:
--
Seen in [distributed-test-openjdk8
#2|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/distributed-test-openjdk8/builds/2]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0278/test-results/distributedTest/1622238574/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0278/test-artifacts/1622238574/distributedtestfiles-openjdk8-1.15.0-build.0278.tgz].
> CI Failure: PartitionedRegionCqQueryDUnitTest >
> testRemoveAllWithCQLocalDestroy
> ---
>
> Key: GEODE-9071
> URL: https://issues.apache.org/jira/browse/GEODE-9071
> Project: Geode
> Issue Type: Bug
> Components: cq
>Affects Versions: 1.12.3, 1.13.3, 1.14.0, 1.15.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: caching-applications
>
> {noformat}
> org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest >
> testRemoveAllWithCQLocalDestroy FAILED
> 10:10:22org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest$$Lambda$87/434016892.run
> in VM 2 running on Host bb8c1d338b8b with 4 VMs
> 10:10:22at
> org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> 10:10:22at org.apache.geode.test.dunit.VM.invoke(VM.java:448)
> 10:10:22at
> org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest.testRemoveAllWithCQLocalDestroy(PartitionedRegionCqQueryDUnitTest.java:243)
> 10:10:22
> 10:10:22Caused by:
> 10:10:22org.junit.ComparisonFailure: expected:<[999]> but was:<[645]>
> 10:10:22at
> sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> 10:10:22at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> 10:10:22at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> 10:10:22at
> org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest.lambda$testRemoveAllWithCQLocalDestroy$c93719d5$3(PartitionedRegionCqQueryDUnitTest.java:251)
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0082/test-results/distributedTest/1616696789/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0082/test-artifacts/1616696789/distributedtestfiles-OpenJDK8-1.15.0-build.0082.tgz
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9252) CI failure: NativeRedisClusterTestRule incorrect primary node count (expected 3 but was 2)
[
https://issues.apache.org/jira/browse/GEODE-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353581#comment-17353581
]
Geode Integration commented on GEODE-9252:
--
Seen in [acceptance-test-openjdk8
#2|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/acceptance-test-openjdk8/builds/2]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0278/test-results/acceptanceTest/1622238627/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0278/test-artifacts/1622238627/acceptancetestfiles-openjdk8-1.15.0-build.0278.tgz].
> CI failure: NativeRedisClusterTestRule incorrect primary node count (expected
> 3 but was 2)
> --
>
> Key: GEODE-9252
> URL: https://issues.apache.org/jira/browse/GEODE-9252
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Owen Nichols
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> {noformat}
> org.apache.geode.redis.internal.executor.hash.HashesNativeRedisAcceptanceTest
> > classMethod FAILED
> org.junit.ComparisonFailure: [Incorrect primary node count]
> expected:<[3]> but was:<[2]>
> at
> org.apache.geode.redis.NativeRedisClusterTestRule$1.evaluate(NativeRedisClusterTestRule.java:93)
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8971) Batches with incomplete transactions when stopping the gateway sender
[ https://issues.apache.org/jira/browse/GEODE-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353551#comment-17353551 ] Geode Integration commented on GEODE-8971: -- Seen in [windows-unit-test-openjdk8 #2|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/windows-unit-test-openjdk8/builds/2] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0278/test-results/test/1622232168/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0278/test-artifacts/1622232168/windows-unittestfiles-openjdk8-1.15.0-build.0278.tgz]. > Batches with incomplete transactions when stopping the gateway sender > - > > Key: GEODE-8971 > URL: https://issues.apache.org/jira/browse/GEODE-8971 > Project: Geode > Issue Type: Improvement > Components: wan >Affects Versions: 1.14.0 >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > When the gateway sender is stopped there is a high probability that batches > with incomplete transactions are sent even if group-transaction-events is > enabled. > The reason is that once the stop command reaches the gateway sender, it > immediately stops queueing events, and this could happen in the middle of > receiving events for the same transaction. If this is the case, some events > for the transaction may have reached the queue right before the stop command > was received and the rest of events for that transaction would not make it to > the queue (they would be dropped) because they arrived right after the stop > command was received at the gateway sender. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9252) CI failure: NativeRedisClusterTestRule incorrect primary node count (expected 3 but was 2)
[
https://issues.apache.org/jira/browse/GEODE-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353552#comment-17353552
]
ASF subversion and git services commented on GEODE-9252:
Commit d0a63049d2d66c76b6eff8faa1d375b7379ea2d2 in geode's branch
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d0a6304 ]
GEODE-9252: Improve startup of NativeRedisClusterTestRule (#6538)
- Sometimes the docker cluster startup appears to complete but cluster
nodes reports fewer than expected primaries.
> CI failure: NativeRedisClusterTestRule incorrect primary node count (expected
> 3 but was 2)
> --
>
> Key: GEODE-9252
> URL: https://issues.apache.org/jira/browse/GEODE-9252
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Owen Nichols
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> {noformat}
> org.apache.geode.redis.internal.executor.hash.HashesNativeRedisAcceptanceTest
> > classMethod FAILED
> org.junit.ComparisonFailure: [Incorrect primary node count]
> expected:<[3]> but was:<[2]>
> at
> org.apache.geode.redis.NativeRedisClusterTestRule$1.evaluate(NativeRedisClusterTestRule.java:93)
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-9252) CI failure: NativeRedisClusterTestRule incorrect primary node count (expected 3 but was 2)
[
https://issues.apache.org/jira/browse/GEODE-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Deppe resolved GEODE-9252.
---
Fix Version/s: 1.15.0
Resolution: Fixed
> CI failure: NativeRedisClusterTestRule incorrect primary node count (expected
> 3 but was 2)
> --
>
> Key: GEODE-9252
> URL: https://issues.apache.org/jira/browse/GEODE-9252
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Owen Nichols
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> {noformat}
> org.apache.geode.redis.internal.executor.hash.HashesNativeRedisAcceptanceTest
> > classMethod FAILED
> org.junit.ComparisonFailure: [Incorrect primary node count]
> expected:<[3]> but was:<[2]>
> at
> org.apache.geode.redis.NativeRedisClusterTestRule$1.evaluate(NativeRedisClusterTestRule.java:93)
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9110) Port "important" disabled legacy tests to new framework and enable
[
https://issues.apache.org/jira/browse/GEODE-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353537#comment-17353537
]
ASF GitHub Bot commented on GEODE-9110:
---
pivotal-jbarrett commented on a change in pull request #805:
URL: https://github.com/apache/geode-native/pull/805#discussion_r641772179
##
File path: cppcache/integration/test/HARegionCacheListenerARLEPDTest.cpp
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include
+#include
+#include
+#include
+
+#include
+#include
+#include
+#include
+
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "mock/CacheListenerMock.hpp"
+
+namespace {
+// Until we get C++14 support...
+template
+::std::unique_ptr make_unique(Args &&... args) {
+ return ::std::unique_ptr(new T(::std::forward(args)...));
+}
+
+// A simple comparator for cachables wrapped in shared pointers.
+// MATCHER_P(CashableEq, value, "") {
+// return arg->toString() == value->toString();
+// }
+
+class HARegionCacheListenerARLEPDTest : public ::testing::Test {
Review comment:
Yikes yeah that's a screenful. Perhaps just a class level comment doc
with the full intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Port "important" disabled legacy tests to new framework and enable
> --
>
> Key: GEODE-9110
> URL: https://issues.apache.org/jira/browse/GEODE-9110
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> After scouring through the code for the disabled legacy tests, we've
> identified the following list of 31 tests that look important enough to have
> running in the new framework:
> testThinClientAfterRegionLive
> testThinClientCq
> testThinClientDurableDisconnectNormal
> testThinClientDurableDisconnectTimeout
> testThinClientDurableReconnect
> testThinClientHAMixedRedundancy
> testThinClientHAQueryFailover
> testThinClientLRUExpiration
> testThinClientLargePutAllWithCallBackArg
> testThinClientLocatorFailover
> testThinClientPartitionResolver
> testThinClientPdxDeltaWithNotification
> testThinClientPdxTests
> testThinClientPutAll
> testThinClientSecurityCQAuthorizationMU
> testThinClientTXFailover
> testTimedSemaphore
> testThinClientCqDurable
> testThinClientRemoveOps
> testThinClientSecurityAuthentication
> testThinClientSecurityAuthenticationMU
> testThinClientSecurityAuthorization
> testThinClientSecurityAuthorizationMU
> testThinClientSecurityDurableCQAuthorizationMU
> testThinClientSecurityPostAuthorization
> testThinClientTicket303
> testThinClientTicket304
> testThinClientTracking
> testThinClientWriterException
>
> When you port a test, submit a PR against this issue, and strike out the test
> name in the list so we know it's done.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-4826) Fail fast with Spotless and rat checks
[ https://issues.apache.org/jira/browse/GEODE-4826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353536#comment-17353536 ] ASF subversion and git services commented on GEODE-4826: Commit 64f912bfa7bd96669046bbd41016baba2a2207b7 in geode's branch refs/heads/develop from Robert Houghton [ https://gitbox.apache.org/repos/asf?p=geode.git;h=64f912b ] GEODE-4826: Use spotlessCheck, not spotlessApply, as input to srcDistTar (#6539) Using spotlessApply as an input to srcDistTar allowed `build` and other CI tasks to pass while still having style errors on the repo. Authored-by: Robert Houghton > Fail fast with Spotless and rat checks > -- > > Key: GEODE-4826 > URL: https://issues.apache.org/jira/browse/GEODE-4826 > Project: Geode > Issue Type: New Feature >Reporter: Michael W. Dodge >Assignee: Robert Houghton >Priority: Major > Labels: pull-request-available > > The Spotless and rat checks happened at the *end* of the build, which makes > them fail as slowly as possible. Enhance developer productivity by putting > those checks (and the potential for concomitant failures) at the *beginning* > of the build. Also, investigate automatically applying the Spotless rules to > prevent any possibility of a failed Spotless check. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9110) Port "important" disabled legacy tests to new framework and enable
[
https://issues.apache.org/jira/browse/GEODE-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353534#comment-17353534
]
ASF GitHub Bot commented on GEODE-9110:
---
mreddington commented on a change in pull request #805:
URL: https://github.com/apache/geode-native/pull/805#discussion_r641767709
##
File path: cppcache/integration/test/HARegionCacheListenerARLEPDTest.cpp
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include
+#include
+#include
+#include
+
+#include
+#include
+#include
+#include
+
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "mock/CacheListenerMock.hpp"
+
+namespace {
+// Until we get C++14 support...
+template
+::std::unique_ptr make_unique(Args &&... args) {
Review comment:
Because at the time, I couldn't be bothered, I was more focused on
figuring out just how not-trivial cache listener tests were. And then we ran
out of time for the sprint and I was trying to get a PR posted. I'll move it
into a utility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Port "important" disabled legacy tests to new framework and enable
> --
>
> Key: GEODE-9110
> URL: https://issues.apache.org/jira/browse/GEODE-9110
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> After scouring through the code for the disabled legacy tests, we've
> identified the following list of 31 tests that look important enough to have
> running in the new framework:
> testThinClientAfterRegionLive
> testThinClientCq
> testThinClientDurableDisconnectNormal
> testThinClientDurableDisconnectTimeout
> testThinClientDurableReconnect
> testThinClientHAMixedRedundancy
> testThinClientHAQueryFailover
> testThinClientLRUExpiration
> testThinClientLargePutAllWithCallBackArg
> testThinClientLocatorFailover
> testThinClientPartitionResolver
> testThinClientPdxDeltaWithNotification
> testThinClientPdxTests
> testThinClientPutAll
> testThinClientSecurityCQAuthorizationMU
> testThinClientTXFailover
> testTimedSemaphore
> testThinClientCqDurable
> testThinClientRemoveOps
> testThinClientSecurityAuthentication
> testThinClientSecurityAuthenticationMU
> testThinClientSecurityAuthorization
> testThinClientSecurityAuthorizationMU
> testThinClientSecurityDurableCQAuthorizationMU
> testThinClientSecurityPostAuthorization
> testThinClientTicket303
> testThinClientTicket304
> testThinClientTracking
> testThinClientWriterException
>
> When you port a test, submit a PR against this issue, and strike out the test
> name in the list so we know it's done.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9110) Port "important" disabled legacy tests to new framework and enable
[
https://issues.apache.org/jira/browse/GEODE-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353528#comment-17353528
]
ASF GitHub Bot commented on GEODE-9110:
---
mreddington commented on a change in pull request #805:
URL: https://github.com/apache/geode-native/pull/805#discussion_r641766995
##
File path: cppcache/integration/test/HARegionCacheListenerARLEPDTest.cpp
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include
+#include
+#include
+#include
+
+#include
+#include
+#include
+#include
+
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "mock/CacheListenerMock.hpp"
+
+namespace {
+// Until we get C++14 support...
+template
+::std::unique_ptr make_unique(Args &&... args) {
+ return ::std::unique_ptr(new T(::std::forward(args)...));
+}
+
+// A simple comparator for cachables wrapped in shared pointers.
+// MATCHER_P(CashableEq, value, "") {
+// return arg->toString() == value->toString();
+// }
+
+class HARegionCacheListenerARLEPDTest : public ::testing::Test {
Review comment:
AfterRegionLiveEndPointDisconnected. As you can see, I haven't figured
out how to get a grip on naming tests. The test cases are beautifully simple
and easy to understand, but to retain context of just what the preconditions
are being tested against, the names are getting huge. I'm very open to
suggestions because I don't like what's going on, either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Port "important" disabled legacy tests to new framework and enable
> --
>
> Key: GEODE-9110
> URL: https://issues.apache.org/jira/browse/GEODE-9110
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> After scouring through the code for the disabled legacy tests, we've
> identified the following list of 31 tests that look important enough to have
> running in the new framework:
> testThinClientAfterRegionLive
> testThinClientCq
> testThinClientDurableDisconnectNormal
> testThinClientDurableDisconnectTimeout
> testThinClientDurableReconnect
> testThinClientHAMixedRedundancy
> testThinClientHAQueryFailover
> testThinClientLRUExpiration
> testThinClientLargePutAllWithCallBackArg
> testThinClientLocatorFailover
> testThinClientPartitionResolver
> testThinClientPdxDeltaWithNotification
> testThinClientPdxTests
> testThinClientPutAll
> testThinClientSecurityCQAuthorizationMU
> testThinClientTXFailover
> testTimedSemaphore
> testThinClientCqDurable
> testThinClientRemoveOps
> testThinClientSecurityAuthentication
> testThinClientSecurityAuthenticationMU
> testThinClientSecurityAuthorization
> testThinClientSecurityAuthorizationMU
> testThinClientSecurityDurableCQAuthorizationMU
> testThinClientSecurityPostAuthorization
> testThinClientTicket303
> testThinClientTicket304
> testThinClientTracking
> testThinClientWriterException
>
> When you port a test, submit a PR against this issue, and strike out the test
> name in the list so we know it's done.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9110) Port "important" disabled legacy tests to new framework and enable
[
https://issues.apache.org/jira/browse/GEODE-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353522#comment-17353522
]
ASF GitHub Bot commented on GEODE-9110:
---
pivotal-jbarrett commented on a change in pull request #805:
URL: https://github.com/apache/geode-native/pull/805#discussion_r641759046
##
File path: cppcache/integration/test/HARegionCacheListenerARLEPDTest.cpp
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include
+#include
+#include
+#include
+
+#include
+#include
+#include
+#include
+
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "mock/CacheListenerMock.hpp"
+
+namespace {
+// Until we get C++14 support...
+template
+::std::unique_ptr make_unique(Args &&... args) {
Review comment:
Why not just make this a util and start using it all over? ;)
##
File path: cppcache/integration/test/HARegionCacheListenerARLEPDTest.cpp
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include
+#include
+#include
+#include
+
+#include
+#include
+#include
+#include
+
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "mock/CacheListenerMock.hpp"
+
+namespace {
+// Until we get C++14 support...
+template
+::std::unique_ptr make_unique(Args &&... args) {
+ return ::std::unique_ptr(new T(::std::forward(args)...));
+}
+
+// A simple comparator for cachables wrapped in shared pointers.
+// MATCHER_P(CashableEq, value, "") {
+// return arg->toString() == value->toString();
+// }
+
+class HARegionCacheListenerARLEPDTest : public ::testing::Test {
Review comment:
What is "ARLEPD"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Port "important" disabled legacy tests to new framework and enable
> --
>
> Key: GEODE-9110
> URL: https://issues.apache.org/jira/browse/GEODE-9110
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> After scouring through the code for the disabled legacy tests, we've
> identified the following list of 31 tests that look important enough to have
> running in the new framework:
> testThinClientAfterRegionLive
> testThinClientCq
> testThinClientDurableDisconnectNormal
> testThinClientDurableDisconnectTimeout
> testThinClientDurableReconnect
> testThinClientHAMixedRedundancy
> testThinClientHAQueryFailover
> testThinClientLRUExpiration
> testThinClientLargePutAllWithCallBackArg
> testThinClientLocatorFailover
> testThinClientPartitionResolver
> testThinClientPdxDeltaWithNotification
> testThinClientPdxTests
> testThinClientPutAll
> testThinClientSecurityCQAuthorizationMU
> testThinClientTXFailover
> testTimedSemaphore
> testThinClientCqDurable
> testThinClientRemoveOps
> testThinClientSecurityAuthentication
> testThinClientSecurityAuthenticationMU
>
[jira] [Assigned] (GEODE-4826) Fail fast with Spotless and rat checks
[ https://issues.apache.org/jira/browse/GEODE-4826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Houghton reassigned GEODE-4826: -- Assignee: Robert Houghton (was: Patrick Rhomberg) > Fail fast with Spotless and rat checks > -- > > Key: GEODE-4826 > URL: https://issues.apache.org/jira/browse/GEODE-4826 > Project: Geode > Issue Type: New Feature >Reporter: Michael W. Dodge >Assignee: Robert Houghton >Priority: Major > Labels: pull-request-available > > The Spotless and rat checks happened at the *end* of the build, which makes > them fail as slowly as possible. Enhance developer productivity by putting > those checks (and the potential for concomitant failures) at the *beginning* > of the build. Also, investigate automatically applying the Spotless rules to > prevent any possibility of a failed Spotless check. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-4826) Fail fast with Spotless and rat checks
[ https://issues.apache.org/jira/browse/GEODE-4826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-4826: -- Labels: pull-request-available (was: ) > Fail fast with Spotless and rat checks > -- > > Key: GEODE-4826 > URL: https://issues.apache.org/jira/browse/GEODE-4826 > Project: Geode > Issue Type: New Feature >Reporter: Michael W. Dodge >Assignee: Patrick Rhomberg >Priority: Major > Labels: pull-request-available > > The Spotless and rat checks happened at the *end* of the build, which makes > them fail as slowly as possible. Enhance developer productivity by putting > those checks (and the potential for concomitant failures) at the *beginning* > of the build. Also, investigate automatically applying the Spotless rules to > prevent any possibility of a failed Spotless check. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-6611) Subprojects should be audited with respect to which plugins ought be applied
[
https://issues.apache.org/jira/browse/GEODE-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Houghton resolved GEODE-6611.
Resolution: Fixed
> Subprojects should be audited with respect to which plugins ought be applied
>
>
> Key: GEODE-6611
> URL: https://issues.apache.org/jira/browse/GEODE-6611
> Project: Geode
> Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Previously, every Gradle subproject was aggressively configured via blocks
> like
> {noformat}
> subprojets {
> apply plugin: 'java'
> ...
> }
> {noformat}
> As the code base expanded, we have introduced many subprojects who do not
> warrant a "standard" configuration as a Java project. For instance, in
> GEODE-6569, a subproject responsible for producing Geode's BOM was also
> producing a trivial jar. This is the direct result of a configuration like
> the above.
> Modularity was restored by GEODE-6383 and such invasive configuration no
> longer exists. We will soon be positioned to remove from such subprojects
> those plugins that do not belong.
> Each subproject should be audited and only pull in the plugins necessary.
> This may resolve many tangental issues, particularly with publication, e.g.,
> the war subproject publishing jars not fit for (direct) consumption.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9110) Port "important" disabled legacy tests to new framework and enable
[
https://issues.apache.org/jira/browse/GEODE-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353497#comment-17353497
]
ASF GitHub Bot commented on GEODE-9110:
---
mreddington commented on a change in pull request #805:
URL: https://github.com/apache/geode-native/pull/805#discussion_r641730292
##
File path: cppcache/integration/test/ThinClientHARegionCacheListenerTest.cpp
##
@@ -0,0 +1,426 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include
+#include
+#include
+#include
+
+#include
+#include
+#include
+#include
+
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "mock/CacheListenerMock.hpp"
+
+namespace {
+// Until we get C++14 support...
+template
+::std::unique_ptr make_unique(Args &&... args) {
+ return ::std::unique_ptr(new T(::std::forward(args)...));
+}
+
+// A simple comparator for cachables wrapped in shared pointers.
+MATCHER_P(CashableEq, value, "") {
+ return arg->toString() == value->toString();
+}
+
+class ThinClientHARegionCacheListenerTest : public ::testing::Test {
Review comment:
Also will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Port "important" disabled legacy tests to new framework and enable
> --
>
> Key: GEODE-9110
> URL: https://issues.apache.org/jira/browse/GEODE-9110
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> After scouring through the code for the disabled legacy tests, we've
> identified the following list of 31 tests that look important enough to have
> running in the new framework:
> testThinClientAfterRegionLive
> testThinClientCq
> testThinClientDurableDisconnectNormal
> testThinClientDurableDisconnectTimeout
> testThinClientDurableReconnect
> testThinClientHAMixedRedundancy
> testThinClientHAQueryFailover
> testThinClientLRUExpiration
> testThinClientLargePutAllWithCallBackArg
> testThinClientLocatorFailover
> testThinClientPartitionResolver
> testThinClientPdxDeltaWithNotification
> testThinClientPdxTests
> testThinClientPutAll
> testThinClientSecurityCQAuthorizationMU
> testThinClientTXFailover
> testTimedSemaphore
> testThinClientCqDurable
> testThinClientRemoveOps
> testThinClientSecurityAuthentication
> testThinClientSecurityAuthenticationMU
> testThinClientSecurityAuthorization
> testThinClientSecurityAuthorizationMU
> testThinClientSecurityDurableCQAuthorizationMU
> testThinClientSecurityPostAuthorization
> testThinClientTicket303
> testThinClientTicket304
> testThinClientTracking
> testThinClientWriterException
>
> When you port a test, submit a PR against this issue, and strike out the test
> name in the list so we know it's done.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9110) Port "important" disabled legacy tests to new framework and enable
[
https://issues.apache.org/jira/browse/GEODE-9110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353496#comment-17353496
]
ASF GitHub Bot commented on GEODE-9110:
---
mreddington commented on a change in pull request #805:
URL: https://github.com/apache/geode-native/pull/805#discussion_r641729834
##
File path: cppcache/integration/framework/Cluster.h
##
@@ -127,6 +127,8 @@ using ConserveSockets = NamedType;
class Cluster {
public:
+ enum class Subscription_State { Enabled, Disabled };
Review comment:
Thy will be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Port "important" disabled legacy tests to new framework and enable
> --
>
> Key: GEODE-9110
> URL: https://issues.apache.org/jira/browse/GEODE-9110
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> After scouring through the code for the disabled legacy tests, we've
> identified the following list of 31 tests that look important enough to have
> running in the new framework:
> testThinClientAfterRegionLive
> testThinClientCq
> testThinClientDurableDisconnectNormal
> testThinClientDurableDisconnectTimeout
> testThinClientDurableReconnect
> testThinClientHAMixedRedundancy
> testThinClientHAQueryFailover
> testThinClientLRUExpiration
> testThinClientLargePutAllWithCallBackArg
> testThinClientLocatorFailover
> testThinClientPartitionResolver
> testThinClientPdxDeltaWithNotification
> testThinClientPdxTests
> testThinClientPutAll
> testThinClientSecurityCQAuthorizationMU
> testThinClientTXFailover
> testTimedSemaphore
> testThinClientCqDurable
> testThinClientRemoveOps
> testThinClientSecurityAuthentication
> testThinClientSecurityAuthenticationMU
> testThinClientSecurityAuthorization
> testThinClientSecurityAuthorizationMU
> testThinClientSecurityDurableCQAuthorizationMU
> testThinClientSecurityPostAuthorization
> testThinClientTicket303
> testThinClientTicket304
> testThinClientTracking
> testThinClientWriterException
>
> When you port a test, submit a PR against this issue, and strike out the test
> name in the list so we know it's done.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-9252) CI failure: NativeRedisClusterTestRule incorrect primary node count (expected 3 but was 2)
[
https://issues.apache.org/jira/browse/GEODE-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Deppe reassigned GEODE-9252:
-
Assignee: Jens Deppe
> CI failure: NativeRedisClusterTestRule incorrect primary node count (expected
> 3 but was 2)
> --
>
> Key: GEODE-9252
> URL: https://issues.apache.org/jira/browse/GEODE-9252
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Owen Nichols
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> {noformat}
> org.apache.geode.redis.internal.executor.hash.HashesNativeRedisAcceptanceTest
> > classMethod FAILED
> org.junit.ComparisonFailure: [Incorrect primary node count]
> expected:<[3]> but was:<[2]>
> at
> org.apache.geode.redis.NativeRedisClusterTestRule$1.evaluate(NativeRedisClusterTestRule.java:93)
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-9252) CI failure: NativeRedisClusterTestRule incorrect primary node count (expected 3 but was 2)
[
https://issues.apache.org/jira/browse/GEODE-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-9252:
--
Labels: pull-request-available (was: )
> CI failure: NativeRedisClusterTestRule incorrect primary node count (expected
> 3 but was 2)
> --
>
> Key: GEODE-9252
> URL: https://issues.apache.org/jira/browse/GEODE-9252
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Owen Nichols
>Priority: Major
> Labels: pull-request-available
>
> {noformat}
> org.apache.geode.redis.internal.executor.hash.HashesNativeRedisAcceptanceTest
> > classMethod FAILED
> org.junit.ComparisonFailure: [Incorrect primary node count]
> expected:<[3]> but was:<[2]>
> at
> org.apache.geode.redis.NativeRedisClusterTestRule$1.evaluate(NativeRedisClusterTestRule.java:93)
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (GEODE-9196) CI: NativeRedisClusterTest.classMethod failed
[ https://issues.apache.org/jira/browse/GEODE-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe closed GEODE-9196. - > CI: NativeRedisClusterTest.classMethod failed > - > > Key: GEODE-9196 > URL: https://issues.apache.org/jira/browse/GEODE-9196 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Xiaojian Zhou >Assignee: Jens Deppe >Priority: Major > > org.apache.geode.redis.NativeRedisClusterTest > classMethod FAILED > org.junit.ComparisonFailure: [Incorrect primary node count] > expected:<[3]> but was:<[0]> > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > Method) > at > sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) > at > sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at > org.apache.geode.test.dunit.rules.NativeRedisClusterTestRule$1.evaluate(NativeRedisClusterTestRule.java:90) > at > org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > at org.junit.runners.ParentRunner.run(ParentRunner.java:413) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38) > at > org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62) > at > org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33) > at > org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94) > at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) > at > org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:119) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182) > at > org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164) > at > org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:414) > at > org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64) > at > org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at > org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56) > at java.lang.Thread.run(Thread.java:748) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9196) CI: NativeRedisClusterTest.classMethod failed
[ https://issues.apache.org/jira/browse/GEODE-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe resolved GEODE-9196. --- Resolution: Duplicate > CI: NativeRedisClusterTest.classMethod failed > - > > Key: GEODE-9196 > URL: https://issues.apache.org/jira/browse/GEODE-9196 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Xiaojian Zhou >Assignee: Jens Deppe >Priority: Major > > org.apache.geode.redis.NativeRedisClusterTest > classMethod FAILED > org.junit.ComparisonFailure: [Incorrect primary node count] > expected:<[3]> but was:<[0]> > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > Method) > at > sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) > at > sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at > org.apache.geode.test.dunit.rules.NativeRedisClusterTestRule$1.evaluate(NativeRedisClusterTestRule.java:90) > at > org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > at org.junit.runners.ParentRunner.run(ParentRunner.java:413) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38) > at > org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62) > at > org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33) > at > org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94) > at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) > at > org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:119) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182) > at > org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164) > at > org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:414) > at > org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64) > at > org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at > org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56) > at java.lang.Thread.run(Thread.java:748) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9252) CI failure: NativeRedisClusterTestRule incorrect primary node count (expected 3 but was 2)
[
https://issues.apache.org/jira/browse/GEODE-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353377#comment-17353377
]
Geode Integration commented on GEODE-9252:
--
Seen in [acceptance-test-openjdk8
#1|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/acceptance-test-openjdk8/builds/1]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0276/test-results/acceptanceTest/1622172653/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0276/test-artifacts/1622172653/acceptancetestfiles-openjdk8-1.15.0-build.0276.tgz].
> CI failure: NativeRedisClusterTestRule incorrect primary node count (expected
> 3 but was 2)
> --
>
> Key: GEODE-9252
> URL: https://issues.apache.org/jira/browse/GEODE-9252
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Owen Nichols
>Priority: Major
>
> {noformat}
> org.apache.geode.redis.internal.executor.hash.HashesNativeRedisAcceptanceTest
> > classMethod FAILED
> org.junit.ComparisonFailure: [Incorrect primary node count]
> expected:<[3]> but was:<[2]>
> at
> org.apache.geode.redis.NativeRedisClusterTestRule$1.evaluate(NativeRedisClusterTestRule.java:93)
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-9333) SessionsAndCrashesDUnitTest.sessionOperationsDoNotFail_whileServersAreRestarted may fail due to IndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/GEODE-9333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Deppe reassigned GEODE-9333:
-
Assignee: Jens Deppe
> SessionsAndCrashesDUnitTest.sessionOperationsDoNotFail_whileServersAreRestarted
> may fail due to IndexOutOfBoundsException
> -
>
> Key: GEODE-9333
> URL: https://issues.apache.org/jira/browse/GEODE-9333
> Project: Geode
> Issue Type: Bug
> Components: redis
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Assignee: Jens Deppe
>Priority: Major
>
> Seen in a PR pre-checkin test run:
> {noformat}
> org.apache.geode.redis.session.SessionsAndCrashesDUnitTest >
> sessionOperationsDoNotFail_whileServersAreRestarted FAILED
> java.lang.IndexOutOfBoundsException: Index -5 out of bounds for length 100
> at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
> at
> jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
> at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248)
> at java.util.Objects.checkIndex(Objects.java:372)
> at java.util.ArrayList.get(ArrayList.java:459)
> at
> org.apache.geode.redis.session.SessionsAndCrashesDUnitTest.validateSessionAttributes(SessionsAndCrashesDUnitTest.java:179)
> at
> org.apache.geode.redis.session.SessionsAndCrashesDUnitTest.sessionOperationsDoNotFail_whileServersAreRestarted(SessionsAndCrashesDUnitTest.java:170)
> {noformat}
> This occurs in the below block when {{totalUpdates}} is less than
> {{NUM_SESSIONS}}.
> {code:java}
> for (int i = totalUpdates - NUM_SESSIONS; i < totalUpdates; i++) {
> int sessionIdx = i % NUM_SESSIONS;
> String sessionId = sessionIds.get(sessionIdx);
> ...
> {code}
> Running the test locally with some trace logging added, it seems that
> {{totalUpdates}} is typically ~120, so if something were to cause updates to
> be 20% slower on a run of the test, this failure could show up. A solution
> might be to either await until at least {{NUM_SESSIONS}} updates have been
> performed by the updater threads, or to put in some logic to handle the case
> when {{totalUpdates}} is less than {{NUM_SESSIONS}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-9327) Remove all remaining references to ACE networking
[ https://issues.apache.org/jira/browse/GEODE-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Salazar de Torres reassigned GEODE-9327: -- Assignee: Mario Salazar de Torres > Remove all remaining references to ACE networking > - > > Key: GEODE-9327 > URL: https://issues.apache.org/jira/browse/GEODE-9327 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE networking > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9327) Remove all remaining references to ACE networking
[ https://issues.apache.org/jira/browse/GEODE-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-9327: -- Labels: obliterate-ace pull-request-available (was: obliterate-ace) > Remove all remaining references to ACE networking > - > > Key: GEODE-9327 > URL: https://issues.apache.org/jira/browse/GEODE-9327 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE networking > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9327) Remove all remaining references to ACE networking
[ https://issues.apache.org/jira/browse/GEODE-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353139#comment-17353139 ] ASF GitHub Bot commented on GEODE-9327: --- gaussianrecurrence opened a new pull request #815: URL: https://github.com/apache/geode-native/pull/815 - Replaced method implementation to get a random port in old ITs framework. - Replaced convertHostToCanonicalForm implementation. - Changed ClientProxyMembershipID address serialization. - Removed unused PoolFactory::addCheck method. - Modified QueueConnectionRequestTest test to pass after the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove all remaining references to ACE networking > - > > Key: GEODE-9327 > URL: https://issues.apache.org/jira/browse/GEODE-9327 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE networking > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9326) Remove ACE_Get_Opt references
[ https://issues.apache.org/jira/browse/GEODE-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353109#comment-17353109 ] ASF GitHub Bot commented on GEODE-9326: --- gaussianrecurrence opened a new pull request #814: URL: https://github.com/apache/geode-native/pull/814 - Replaced ACE_GET_Opt by Boost alternative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ACE_Get_Opt references > - > > Key: GEODE-9326 > URL: https://issues.apache.org/jira/browse/GEODE-9326 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE_Get_Opt > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9326) Remove ACE_Get_Opt references
[ https://issues.apache.org/jira/browse/GEODE-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-9326: -- Labels: obliterate-ace pull-request-available (was: obliterate-ace) > Remove ACE_Get_Opt references > - > > Key: GEODE-9326 > URL: https://issues.apache.org/jira/browse/GEODE-9326 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE_Get_Opt > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9326) Remove ACE_Get_Opt references
[ https://issues.apache.org/jira/browse/GEODE-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Salazar de Torres reassigned GEODE-9326: -- Assignee: Mario Salazar de Torres > Remove ACE_Get_Opt references > - > > Key: GEODE-9326 > URL: https://issues.apache.org/jira/browse/GEODE-9326 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE_Get_Opt > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9324) Remove ACE_Task references
[ https://issues.apache.org/jira/browse/GEODE-9324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Salazar de Torres reassigned GEODE-9324: -- Assignee: Mario Salazar de Torres > Remove ACE_Task references > -- > > Key: GEODE-9324 > URL: https://issues.apache.org/jira/browse/GEODE-9324 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE_Task > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9323) Remove ACE references from tests/cpp
[ https://issues.apache.org/jira/browse/GEODE-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Salazar de Torres reassigned GEODE-9323: -- Assignee: Mario Salazar de Torres > Remove ACE references from tests/cpp > > > Key: GEODE-9323 > URL: https://issues.apache.org/jira/browse/GEODE-9323 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE in tests/cpp projects > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9325) Remove ACE_Process references
[ https://issues.apache.org/jira/browse/GEODE-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-9325: -- Labels: obliterate-ace pull-request-available (was: obliterate-ace) > Remove ACE_Process references > - > > Key: GEODE-9325 > URL: https://issues.apache.org/jira/browse/GEODE-9325 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE_Process > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9325) Remove ACE_Process references
[ https://issues.apache.org/jira/browse/GEODE-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353036#comment-17353036 ] ASF GitHub Bot commented on GEODE-9325: --- gaussianrecurrence opened a new pull request #813: URL: https://github.com/apache/geode-native/pull/813 - Replaced references to ACE_Process realated to old ITs process spawners. - Added Boost program_options project, given that was needed to fulfill above changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ACE_Process references > - > > Key: GEODE-9325 > URL: https://issues.apache.org/jira/browse/GEODE-9325 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE_Process > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9325) Remove ACE_Process references
[ https://issues.apache.org/jira/browse/GEODE-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Salazar de Torres reassigned GEODE-9325: -- Assignee: Mario Salazar de Torres > Remove ACE_Process references > - > > Key: GEODE-9325 > URL: https://issues.apache.org/jira/browse/GEODE-9325 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE_Process > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.3.4#803005)
