[jira] [Commented] (GEODE-4125) Add correct runner to query and wan tests

2017-12-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299214#comment-16299214
 ] 

ASF GitHub Bot commented on GEODE-4125:
---

jhuynh1 closed pull request #1188: GEODE-4125: Add correct runner to query and 
wan tests
URL: https://github.com/apache/geode/pull/1188
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandTest.java
 
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandTest.java
index afc1dbc9ba..13bb545b18 100644
--- 
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandTest.java
+++ 
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandTest.java
@@ -41,7 +41,9 @@
 import org.apache.geode.test.junit.categories.IntegrationTest;
 import org.apache.geode.test.junit.rules.GfshCommandRule;
 import org.apache.geode.test.junit.rules.ServerStarterRule;
+import 
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
 
+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
 @Category(IntegrationTest.class)
 @RunWith(Parameterized.class)
 public class QueryCommandTest {
diff --git 
a/geode-core/src/test/java/org/apache/geode/security/query/IndexSecurityDUnitTest.java
 
b/geode-core/src/test/java/org/apache/geode/security/query/IndexSecurityDUnitTest.java
index ea0f92074d..2488675cb1 100644
--- 
a/geode-core/src/test/java/org/apache/geode/security/query/IndexSecurityDUnitTest.java
+++ 
b/geode-core/src/test/java/org/apache/geode/security/query/IndexSecurityDUnitTest.java
@@ -18,11 +18,6 @@
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.fail;
 
-import java.util.Arrays;
-import java.util.List;
-
-import junitparams.JUnitParamsRunner;
-import junitparams.Parameters;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
@@ -36,7 +31,9 @@
 import org.apache.geode.security.query.data.QueryTestObject;
 import org.apache.geode.test.junit.categories.DistributedTest;
 import org.apache.geode.test.junit.categories.SecurityTest;
+import 
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
 
+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
 @Category({DistributedTest.class, SecurityTest.class})
 @RunWith(Parameterized.class)
 public class IndexSecurityDUnitTest extends QuerySecurityBase {
diff --git 
a/geode-core/src/test/java/org/apache/geode/security/query/PartitionedIndexSecurityDUnitTest.java
 
b/geode-core/src/test/java/org/apache/geode/security/query/PartitionedIndexSecurityDUnitTest.java
index 593bd4e280..e79113739f 100644
--- 
a/geode-core/src/test/java/org/apache/geode/security/query/PartitionedIndexSecurityDUnitTest.java
+++ 
b/geode-core/src/test/java/org/apache/geode/security/query/PartitionedIndexSecurityDUnitTest.java
@@ -14,7 +14,6 @@
  */
 package org.apache.geode.security.query;
 
-import junitparams.JUnitParamsRunner;
 import org.junit.experimental.categories.Category;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -22,7 +21,9 @@
 import org.apache.geode.cache.RegionShortcut;
 import org.apache.geode.test.junit.categories.DistributedTest;
 import org.apache.geode.test.junit.categories.SecurityTest;
+import 
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
 
+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
 @Category({DistributedTest.class, SecurityTest.class})
 @RunWith(Parameterized.class)
 public class PartitionedIndexSecurityDUnitTest extends IndexSecurityDUnitTest {
diff --git 
a/geode-core/src/test/java/org/apache/geode/security/query/PdxPartitionedQuerySecurityAllowedQueriesDUnitTest.java
 
b/geode-core/src/test/java/org/apache/geode/security/query/PdxPartitionedQuerySecurityAllowedQueriesDUnitTest.java
index b9d0fda099..8155d4ba10 100644
--- 
a/geode-core/src/test/java/org/apache/geode/security/query/PdxPartitionedQuerySecurityAllowedQueriesDUnitTest.java
+++ 
b/geode-core/src/test/java/org/apache/geode/security/query/PdxPartitionedQuerySecurityAllowedQueriesDUnitTest.java
@@ -21,7 +21,9 @@
 import org.apache.geode.cache.RegionShortcut;
 import org.apache.geode.test.junit.categories.DistributedTest;
 import org.apache.geode.test.junit.categories.SecurityTest;
+import 
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
 
+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
 @Category({DistributedTest.class, 

[jira] [Commented] (GEODE-4125) Add correct runner to query and wan tests

2017-12-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299197#comment-16299197
 ] 

ASF GitHub Bot commented on GEODE-4125:
---

PurelyApplied commented on issue #1188: GEODE-4125: Add correct runner to query 
and wan tests
URL: https://github.com/apache/geode/pull/1188#issuecomment-353203948
 
 
   Since `QueryCommandTest` is failing in its current state, I've opened 
GEODE-4136 as a separate ticket for it.
   
   I inadvertently duplicated your efforts on the others in my PR#1197 but 
could roll back wherever we both touch the same file.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add correct runner to query and wan tests
> -
>
> Key: GEODE-4125
> URL: https://issues.apache.org/jira/browse/GEODE-4125
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)