[GitHub] incubator-hawq pull request #1124: HAWQ-1330. More ASF header updates (inclu...

2017-02-15 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1124


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1124: HAWQ-1330. More ASF header updates (inclu...

2017-02-14 Thread edespino 
Github user edespino commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1124#discussion_r101207986
  
--- Diff: pom.xml ---
@@ -129,39 +129,88 @@
   src/pl/**/*
   src/port/*
   src/template/*
-  src/test/**/*.in
-  src/test/**/*.mdp
+
+  
+
+  src/test/bench/query*
+
+  
+  
+  src/test/regress/**/*.in
+  src/test/regress/**/*.mdp
+  src/test/regress/**/*.xml
+  
src/test/regress/data/fixedwidth/fixedwidth_3chars_line_delimiter.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_big.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_no_line_delimiter.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_out.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_blankfields.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_blankfields_and_nulls.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_correct.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtoolong.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtype.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitcrossed.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitnotcrossed.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_toofewfields.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_toomanyfields.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_nulldefined.tbl
+  src/test/regress/data/nation.tbl
+  src/test/regress/data/nation_error50.tbl
+  src/test/regress/data/region.tbl
+  src/test/regress/expected_statuses
+
+  
+
+  
src/test/feature/ExternalSource/data/nation.tbl
+  
src/test/feature/ExternalSource/data/nation_error50.tbl
+  
src/test/feature/ExternalSource/data/region.tbl
+  
src/test/feature/ManagementTool/test_hawq_register_hawq.paq
+  
src/test/feature/ManagementTool/test_hawq_register_hive.paq
+  
src/test/feature/ManagementTool/data/parquet200/dat.paq
+  
src/test/feature/ManagementTool/data/parquet200sum/a.paq
+  
src/test/feature/ManagementTool/data/parquet200sum/b.paq
+  
src/test/feature/ManagementTool/test_hawq_register_data_types.paq
--- End diff --

I'm afraid we will not question files which do not have ASF headers if we 
use directory wild cards so freely. As an example, the following was excluded 
but should have had a header:

src/test/**/init_file

Thank you for helping us think through this. It helps us all in the end.  
For now, I would like to be explicit in our exclusions. We can revisit if it 
becomes a significant maintenance issue.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1124: HAWQ-1330. More ASF header updates (inclu...

2017-02-14 Thread paul-guo- 
Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1124#discussion_r101189224
  
--- Diff: pom.xml ---
@@ -129,39 +129,88 @@
   src/pl/**/*
   src/port/*
   src/template/*
-  src/test/**/*.in
-  src/test/**/*.mdp
+
+  
+
+  src/test/bench/query*
+
+  
+  
+  src/test/regress/**/*.in
+  src/test/regress/**/*.mdp
+  src/test/regress/**/*.xml
+  
src/test/regress/data/fixedwidth/fixedwidth_3chars_line_delimiter.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_big.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_no_line_delimiter.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_out.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_blankfields.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_blankfields_and_nulls.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_correct.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtoolong.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtype.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitcrossed.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitnotcrossed.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_toofewfields.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_toomanyfields.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_nulldefined.tbl
+  src/test/regress/data/nation.tbl
+  src/test/regress/data/nation_error50.tbl
+  src/test/regress/data/region.tbl
+  src/test/regress/expected_statuses
+
+  
+
+  
src/test/feature/ExternalSource/data/nation.tbl
+  
src/test/feature/ExternalSource/data/nation_error50.tbl
+  
src/test/feature/ExternalSource/data/region.tbl
+  
src/test/feature/ManagementTool/test_hawq_register_hawq.paq
+  
src/test/feature/ManagementTool/test_hawq_register_hive.paq
+  
src/test/feature/ManagementTool/data/parquet200/dat.paq
+  
src/test/feature/ManagementTool/data/parquet200sum/a.paq
+  
src/test/feature/ManagementTool/data/parquet200sum/b.paq
+  
src/test/feature/ManagementTool/test_hawq_register_data_types.paq
--- End diff --

I think we should limit using wildcard for directory, etc, but not for file 
extensions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1124: HAWQ-1330. More ASF header updates (inclu...

2017-02-14 Thread edespino 
Github user edespino commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1124#discussion_r101183086
  
--- Diff: pom.xml ---
@@ -129,39 +129,88 @@
   src/pl/**/*
   src/port/*
   src/template/*
-  src/test/**/*.in
-  src/test/**/*.mdp
+
+  
+
+  src/test/bench/query*
+
+  
+  
+  src/test/regress/**/*.in
+  src/test/regress/**/*.mdp
+  src/test/regress/**/*.xml
+  
src/test/regress/data/fixedwidth/fixedwidth_3chars_line_delimiter.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_big.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_no_line_delimiter.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_out.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_blankfields.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_blankfields_and_nulls.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_correct.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtoolong.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtype.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitcrossed.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitnotcrossed.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_toofewfields.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_toomanyfields.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_nulldefined.tbl
+  src/test/regress/data/nation.tbl
+  src/test/regress/data/nation_error50.tbl
+  src/test/regress/data/region.tbl
+  src/test/regress/expected_statuses
+
+  
+
+  
src/test/feature/ExternalSource/data/nation.tbl
+  
src/test/feature/ExternalSource/data/nation_error50.tbl
+  
src/test/feature/ExternalSource/data/region.tbl
+  
src/test/feature/ManagementTool/test_hawq_register_hawq.paq
+  
src/test/feature/ManagementTool/test_hawq_register_hive.paq
+  
src/test/feature/ManagementTool/data/parquet200/dat.paq
+  
src/test/feature/ManagementTool/data/parquet200sum/a.paq
+  
src/test/feature/ManagementTool/data/parquet200sum/b.paq
+  
src/test/feature/ManagementTool/test_hawq_register_data_types.paq
--- End diff --

I am trying to limit our use of the wildcards thus forcing us to be as 
explicit as possible. The dev community will come to understand the importance 
of maintaining ASF headers as needed. Additionally, we have Apache RAT in place 
to allow a developer to catch potential issues as early as possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1124: HAWQ-1330. More ASF header updates (inclu...

2017-02-14 Thread paul-guo- 
Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1124#discussion_r101181207
  
--- Diff: pom.xml ---
@@ -129,39 +129,88 @@
   src/pl/**/*
   src/port/*
   src/template/*
-  src/test/**/*.in
-  src/test/**/*.mdp
+
+  
+
+  src/test/bench/query*
+
+  
+  
+  src/test/regress/**/*.in
+  src/test/regress/**/*.mdp
+  src/test/regress/**/*.xml
+  
src/test/regress/data/fixedwidth/fixedwidth_3chars_line_delimiter.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_big.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_no_line_delimiter.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_out.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_blankfields.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_blankfields_and_nulls.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_correct.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtoolong.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_fieldtype.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitcrossed.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_rejectlimitnotcrossed.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_toofewfields.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_error_toomanyfields.tbl
+  
src/test/regress/data/fixedwidth/fixedwidth_small_nulldefined.tbl
+  src/test/regress/data/nation.tbl
+  src/test/regress/data/nation_error50.tbl
+  src/test/regress/data/region.tbl
+  src/test/regress/expected_statuses
+
+  
+
+  
src/test/feature/ExternalSource/data/nation.tbl
+  
src/test/feature/ExternalSource/data/nation_error50.tbl
+  
src/test/feature/ExternalSource/data/region.tbl
+  
src/test/feature/ManagementTool/test_hawq_register_hawq.paq
+  
src/test/feature/ManagementTool/test_hawq_register_hive.paq
+  
src/test/feature/ManagementTool/data/parquet200/dat.paq
+  
src/test/feature/ManagementTool/data/parquet200sum/a.paq
+  
src/test/feature/ManagementTool/data/parquet200sum/b.paq
+  
src/test/feature/ManagementTool/test_hawq_register_data_types.paq
--- End diff --

Maybe we should use wildcat for .paq and .tbl files here. I've been 
thinking of having an extension standard in our dev/test code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1124: HAWQ-1330. More ASF header updates (inclu...

2017-02-14 Thread edespino 
GitHub user edespino opened a pull request:

https://github.com/apache/incubator-hawq/pull/1124

HAWQ-1330. More ASF header updates (including pom.xml update)

Here are more ASF license header updates.  I have verified the change in a 
dev pipeline ()https://hawq.ci.pivotalci.info/teams/main/pipelines/hdb-espino). 
 I would like to push this change for the upcoming Apache 2.2.0.0-incubating 
RC1 release.

-=e

Reviewer requests: @amyrazz44 @paul-guo- @radarwave @stanlyxiang @huor 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/edespino/incubator-hawq HAWQ-1330

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1124


commit bd52b584fd2ca2dadf4a896aa5fb8243db9d8983
Author: Ed Espino 
Date:   2017-02-14T19:26:16Z

HAWQ-1330. More ASF header updates (including pom.xml update)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---