[GitHub] incubator-hawq pull request #1179: HAWQ-1395. PXF build script to support pa...

[sansanichfb]

Github user sansanichfb closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1179


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1179: HAWQ-1395. PXF build script to support pa...

[sansanichfb]

Github user sansanichfb commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1179#discussion_r107239012
  
--- Diff: pxf/Makefile ---
@@ -42,6 +42,10 @@ ifneq "$(PXF_VERSION)" ""
 BUILD_PARAMS+= -Pversion="$(PXF_VERSION)"
 endif
 
+ifneq "$(GRADLEW_OPTIONS)" ""
--- End diff --

Another option - add EXCLUDE_PROJECTS, which will take comma-separated list 
of projects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1179: HAWQ-1395. PXF build script to support pa...

[shivzone]

Github user shivzone commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1179#discussion_r107220629
  
--- Diff: pxf/Makefile ---
@@ -42,6 +42,10 @@ ifneq "$(PXF_VERSION)" ""
 BUILD_PARAMS+= -Pversion="$(PXF_VERSION)"
 endif
 
+ifneq "$(GRADLEW_OPTIONS)" ""
--- End diff --

The purpose of Makefile is to abstract the user from gradle 
options/commands. Should we instead call this BUILD_OPTIONS ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1179: HAWQ-1395. PXF build script to support pa...

[sansanichfb]

GitHub user sansanichfb opened a pull request:

https://github.com/apache/incubator-hawq/pull/1179

HAWQ-1395. PXF build script to support passing additional Gradle options.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sansanichfb/incubator-hawq HAWQ-1395

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1179


commit 096b430cf4b4ed85ac3e87b21bc1afd861f5c605
Author: Oleksandr Diachenko 
Date:   2017-03-21T01:03:09Z

HAWQ-1395. PXF build script to support passing additional Gradle options.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---