[jira] [Commented] (HAWQ-544) Wrong MemoryAccountingPeakBalance assert after calling elog in function AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214461#comment-15214461
 ] 

ASF GitHub Bot commented on HAWQ-544:
-

Github user gcaragea commented on the pull request:

https://github.com/apache/incubator-hawq/pull/454#issuecomment-202483123
  
Merged to master by commit 536d99a6d1211ded20aaf502c0d70c2e8b5f9b52. 

Closing. 


> Wrong MemoryAccountingPeakBalance assert after calling elog in function 
> AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit
> --
>
> Key: HAWQ-544
> URL: https://issues.apache.org/jira/browse/HAWQ-544
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: George Caragea
>Assignee: George Caragea
>
> In function AdvanceMemoryAccountingGeneration, we first assign 
> "RolloverMemoryAccount->peak = Max(RolloverMemoryAccount->peak, 
> MemoryAccountingPeakBalance);", then we call elog if there is a generation 
> overflow. Then we assert "Assert(RolloverMemoryAccount->peak >= 
> MemoryAccountingPeakBalance);".
> If elog allocates additional memory, then this causes the assertion to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-544) Wrong MemoryAccountingPeakBalance assert after calling elog in function AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214462#comment-15214462
 ] 

ASF GitHub Bot commented on HAWQ-544:
-

Github user gcaragea closed the pull request at:

https://github.com/apache/incubator-hawq/pull/454


> Wrong MemoryAccountingPeakBalance assert after calling elog in function 
> AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit
> --
>
> Key: HAWQ-544
> URL: https://issues.apache.org/jira/browse/HAWQ-544
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: George Caragea
>Assignee: George Caragea
>
> In function AdvanceMemoryAccountingGeneration, we first assign 
> "RolloverMemoryAccount->peak = Max(RolloverMemoryAccount->peak, 
> MemoryAccountingPeakBalance);", then we call elog if there is a generation 
> overflow. Then we assert "Assert(RolloverMemoryAccount->peak >= 
> MemoryAccountingPeakBalance);".
> If elog allocates additional memory, then this causes the assertion to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-544) Wrong MemoryAccountingPeakBalance assert after calling elog in function AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209626#comment-15209626
 ] 

ASF GitHub Bot commented on HAWQ-544:
-

Github user liming01 commented on the pull request:

https://github.com/apache/incubator-hawq/pull/454#issuecomment-200629865
  
+1. 


> Wrong MemoryAccountingPeakBalance assert after calling elog in function 
> AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit
> --
>
> Key: HAWQ-544
> URL: https://issues.apache.org/jira/browse/HAWQ-544
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: George Caragea
>Assignee: George Caragea
>
> In function AdvanceMemoryAccountingGeneration, we first assign 
> "RolloverMemoryAccount->peak = Max(RolloverMemoryAccount->peak, 
> MemoryAccountingPeakBalance);", then we call elog if there is a generation 
> overflow. Then we assert "Assert(RolloverMemoryAccount->peak >= 
> MemoryAccountingPeakBalance);".
> If elog allocates additional memory, then this causes the assertion to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-544) Wrong MemoryAccountingPeakBalance assert after calling elog in function AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209625#comment-15209625
 ] 

ASF GitHub Bot commented on HAWQ-544:
-

Github user huor commented on the pull request:

https://github.com/apache/incubator-hawq/pull/454#issuecomment-200629188
  
+1


> Wrong MemoryAccountingPeakBalance assert after calling elog in function 
> AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit
> --
>
> Key: HAWQ-544
> URL: https://issues.apache.org/jira/browse/HAWQ-544
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: George Caragea
>Assignee: George Caragea
>
> In function AdvanceMemoryAccountingGeneration, we first assign 
> "RolloverMemoryAccount->peak = Max(RolloverMemoryAccount->peak, 
> MemoryAccountingPeakBalance);", then we call elog if there is a generation 
> overflow. Then we assert "Assert(RolloverMemoryAccount->peak >= 
> MemoryAccountingPeakBalance);".
> If elog allocates additional memory, then this causes the assertion to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-544) Wrong MemoryAccountingPeakBalance assert after calling elog in function AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203631#comment-15203631
 ] 

ASF GitHub Bot commented on HAWQ-544:
-

Github user ictmalili commented on the pull request:

https://github.com/apache/incubator-hawq/pull/454#issuecomment-199085185
  
@foyzur , Got it. Thanks :+1: 


> Wrong MemoryAccountingPeakBalance assert after calling elog in function 
> AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit
> --
>
> Key: HAWQ-544
> URL: https://issues.apache.org/jira/browse/HAWQ-544
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: George Caragea
>Assignee: George Caragea
>
> In function AdvanceMemoryAccountingGeneration, we first assign 
> "RolloverMemoryAccount->peak = Max(RolloverMemoryAccount->peak, 
> MemoryAccountingPeakBalance);", then we call elog if there is a generation 
> overflow. Then we assert "Assert(RolloverMemoryAccount->peak >= 
> MemoryAccountingPeakBalance);".
> If elog allocates additional memory, then this causes the assertion to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-544) Wrong MemoryAccountingPeakBalance assert after calling elog in function AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202203#comment-15202203
 ] 

ASF GitHub Bot commented on HAWQ-544:
-

Github user foyzur commented on the pull request:

https://github.com/apache/incubator-hawq/pull/454#issuecomment-198554875
  
Hi @ictmalili the HandleMemoryAccountingGenerationOverflow() is not 
supposed to allocate more memory. Part of the job of the assert 
```Assert(RolloverMemoryAccount->peak >= MemoryAccountingPeakBalance);``` is to 
make sure that all the allocated memory are now owned by RolloverMemoryAccount. 
If we allow further allocation during the migration process, it will be very 
difficult (if not impossible) to ensure that. Therefore, the assert should 
itself prevent further allocation, if any, made by accidental future change.


> Wrong MemoryAccountingPeakBalance assert after calling elog in function 
> AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit
> --
>
> Key: HAWQ-544
> URL: https://issues.apache.org/jira/browse/HAWQ-544
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: George Caragea
>Assignee: George Caragea
>
> In function AdvanceMemoryAccountingGeneration, we first assign 
> "RolloverMemoryAccount->peak = Max(RolloverMemoryAccount->peak, 
> MemoryAccountingPeakBalance);", then we call elog if there is a generation 
> overflow. Then we assert "Assert(RolloverMemoryAccount->peak >= 
> MemoryAccountingPeakBalance);".
> If elog allocates additional memory, then this causes the assertion to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-544) Wrong MemoryAccountingPeakBalance assert after calling elog in function AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196789#comment-15196789
 ] 

ASF GitHub Bot commented on HAWQ-544:
-

Github user ictmalili commented on the pull request:

https://github.com/apache/incubator-hawq/pull/454#issuecomment-197159124
  
@gcaragea  Does this function 
HandleMemoryAccountingGenerationOverflow(TopMemoryContext) consumes memory? If 
not, I think the modification is good to me. Thanks.


> Wrong MemoryAccountingPeakBalance assert after calling elog in function 
> AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit
> --
>
> Key: HAWQ-544
> URL: https://issues.apache.org/jira/browse/HAWQ-544
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: George Caragea
>Assignee: George Caragea
>
> In function AdvanceMemoryAccountingGeneration, we first assign 
> "RolloverMemoryAccount->peak = Max(RolloverMemoryAccount->peak, 
> MemoryAccountingPeakBalance);", then we call elog if there is a generation 
> overflow. Then we assert "Assert(RolloverMemoryAccount->peak >= 
> MemoryAccountingPeakBalance);".
> If elog allocates additional memory, then this causes the assertion to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HAWQ-544) Wrong MemoryAccountingPeakBalance assert after calling elog in function AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196220#comment-15196220
 ] 

ASF GitHub Bot commented on HAWQ-544:
-

GitHub user gcaragea opened a pull request:

https://github.com/apache/incubator-hawq/pull/454

HAWQ-544. Fixed assertion failure in AdvanceMemoryAccountingGeneration

Fixed assertion failure in AdvanceMemoryAccountingGeneration when we have a 
generation overflow

In function AdvanceMemoryAccountingGeneration, we first assign 
"RolloverMemoryAccount->peak = Max(RolloverMemoryAccount->peak, 
MemoryAccountingPeakBalance);", then we call elog if there is a generation 
overflow. Then we assert "Assert(RolloverMemoryAccount->peak >= 
MemoryAccountingPeakBalance);".

If elog allocates additional memory, then this causes the assertion to fail.


Signed-off-by: George Caragea 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gcaragea/incubator-hawq 
gcaragea-accounting-assert

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/454.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #454


commit 4bdd246a01584ab9a916036153b3e64e99cd153a
Author: Foyzur Rahman 
Date:   2016-03-15T19:19:44Z

HAWQ-544. Fixed assertion failure in AdvanceMemoryAccountingGeneration when 
we have a generation overflow

Signed-off-by: George Caragea 




> Wrong MemoryAccountingPeakBalance assert after calling elog in function 
> AdvanceMemoryAccountingGeneration, calling multiple errors thrown when OOM hit
> --
>
> Key: HAWQ-544
> URL: https://issues.apache.org/jira/browse/HAWQ-544
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Query Execution
>Reporter: George Caragea
>Assignee: George Caragea
>
> In function AdvanceMemoryAccountingGeneration, we first assign 
> "RolloverMemoryAccount->peak = Max(RolloverMemoryAccount->peak, 
> MemoryAccountingPeakBalance);", then we call elog if there is a generation 
> overflow. Then we assert "Assert(RolloverMemoryAccount->peak >= 
> MemoryAccountingPeakBalance);".
> If elog allocates additional memory, then this causes the assertion to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)