[jira] [Commented] (HBASE-17522) RuntimeExceptions from MemoryMXBean should not take down server process
[
https://issues.apache.org/jira/browse/HBASE-17522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843971#comment-15843971
]
stack commented on HBASE-17522:
---
Seems odd have MemorySizeUtil 'know' about LRU and Bucket Caches. Does it have
to? (I do see this util class already had cache mentions going on).
nit: This could be a method?
207 long max = -1L;
208 try {
209 max =
ManagementFactory.getMemoryMXBean().getHeapMemoryUsage().getMax();
210 } catch (RuntimeException exception) {
211 LOG.warn(JVM_HEAP_EXCEPTION, exception);
212 }
It is repeated four times in same class?
smaller nit: This is repeated too:
102 long usedHeap = -1L;
103 long maxHeap = -1L;
104 try {
105 final MemoryUsage heap =
ManagementFactory.getMemoryMXBean().getHeapMemoryUsage();
106 maxHeap = heap.getMax();
107 usedHeap = heap.getUsed();
108 } catch (RuntimeException exception) {
109 final Log LOG = LogFactory.getLog(getClass());
110 LOG.warn(MemorySizeUtil.JVM_HEAP_EXCEPTION, exception);
111 }
Could return a pair?
Above is not important.
Otherwise patch is great [~busbey]
> RuntimeExceptions from MemoryMXBean should not take down server process
> ---
>
> Key: HBASE-17522
> URL: https://issues.apache.org/jira/browse/HBASE-17522
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Environment: java version "1.8.0_92"
> Java(TM) SE Runtime Environment (build 1.8.0_92-b14)
> Java HotSpot(TM) 64-Bit Server VM (build 25.92-b14, mixed mode)
> -XX:+UseG1GC -XX:+UseStringDeduplication -Xmx32768m
>Reporter: Sean Busbey
>Assignee: Sean Busbey
> Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.9
>
> Attachments: HBASE-17522.0.patch
>
>
> RegionServer died after MemoryMXBean threw an IllegalArgumentException while
> attempting to create a MemoryUsage object for the heap during construction of
> the server load.
> We shouldn't allow failure to get load information to take down the RS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17346) Add coprocessor service support
[ https://issues.apache.org/jira/browse/HBASE-17346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843967#comment-15843967 ] stack commented on HBASE-17346: --- bq. I'm not sure which one is better. 'callback' is better than 'done' (IMO). 'done' is final. It is what you have when no more processing to do. I know what is going to happen to the 'callback' param when in an async context. Just some opinion. bq. 'whenComplete' is 'CompletableFuture.whenComplete'. Oh. I missed that. So, 'whenComplete' and then this in this callback, it is 'onComplete'. That ok you think? Ok. Thanks for clearning up onComplete vs onRegionComplete... Nothing wrong w/ your english. I just made one possible reading of what you had written (now I understand better, I can read your intention). Maybe add the text above as narrative on the pseudo-code. I skimmed the rest of the patch. More dumb questions. First the below looks very nice for client invocation of a endpoint method... 87 assertEquals(COUNT - 1, 88max(TABLE, new LongColumnInterpreter(), new Scan().addColumn(CF, CQ)).get().longValue()); ... but how is it working? How does above max invocation become an invocation on the AsyncAggregationClient max method? > Add coprocessor service support > --- > > Key: HBASE-17346 > URL: https://issues.apache.org/jira/browse/HBASE-17346 > Project: HBase > Issue Type: Sub-task > Components: asyncclient, Client, Coprocessors >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: 17346.suggestion.txt, HBASE-17346.patch, > HBASE-17346-v1.patch, HBASE-17346-v2.patch, HBASE-17346-v3.patch > > > I think we need to redesign the API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17540) Change SASL server GSSAPI callback log line from DEBUG to TRACE in RegionServer to reduce log volumes in DEBUG mode
[ https://issues.apache.org/jira/browse/HBASE-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843965#comment-15843965 ] Hudson commented on HBASE-17540: FAILURE: Integrated in Jenkins build HBase-1.1-JDK8 #1920 (See [https://builds.apache.org/job/HBase-1.1-JDK8/1920/]) HBASE-17540 Change SASL server GSSAPI callback log line from DEBUG to (apurtell: rev 9d86434ddeb219dac5879d1d4736063040fdb965) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java > Change SASL server GSSAPI callback log line from DEBUG to TRACE in > RegionServer to reduce log volumes in DEBUG mode > --- > > Key: HBASE-17540 > URL: https://issues.apache.org/jira/browse/HBASE-17540 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.2.4, 1.1.8 >Reporter: Maddineni Sukumar >Assignee: Maddineni Sukumar >Priority: Minor > Labels: easyfix > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.9 > > Attachments: HBASE-17540-branch-1.1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > For every client connect call to RS we are logging below log line in DEBUG > mode which is causing too many logs in RegionServer. > 2017-01-18 17:51:40,739 DEBUG [.reader=4,port=60020] > security.HBaseSaslRpcServer - SASL server GSSAPI callback: setting > canonicalized client ID: hbase/hostname-xxx@KDC -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17565) StochasticLoadBalancer may incorrectly skip balancing due to skewed multiplier sum
[
https://issues.apache.org/jira/browse/HBASE-17565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843954#comment-15843954
]
Hadoop QA commented on HBASE-17565:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 29s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 2s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
47s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 34s
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
37s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 34s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
24m 38s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
48s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 145m 19s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 181m 20s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestHRegion |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12849799/17565.v2.txt |
| JIRA Issue | HBASE-17565 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux d6ade94ac622 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / bd8a4d5 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/5490/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/5490/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit test logs |
https://builds.apache.org/job/PreCommit-HBASE-Build/5490/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.a
[jira] [Commented] (HBASE-17526) Procedure v2 - cleanup isSuspended from MasterProcedureScheduler#Queue
[ https://issues.apache.org/jira/browse/HBASE-17526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843953#comment-15843953 ] stack commented on HBASE-17526: --- +1 (pending hadoopqa). > Procedure v2 - cleanup isSuspended from MasterProcedureScheduler#Queue > -- > > Key: HBASE-17526 > URL: https://issues.apache.org/jira/browse/HBASE-17526 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Appy >Assignee: Appy >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-17526.addendum.patch, HBASE-17526.master.001.patch > > > Queue#setSuspended() is not used anywhere, probably because when queue > wait/wakes on an event, it gets removed or added back to the fairq. > Removing state, functions, and uses of isSuspended() -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17538) HDFS.setStoragePolicy() logs errors on local fs
[
https://issues.apache.org/jira/browse/HBASE-17538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-17538:
--
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Pushed to master. Addressed [~carp84] comment up in RB on commit (And Happy New
Year to you [~carp84]! I'd like to hear about what that drive was like -- smile)
> HDFS.setStoragePolicy() logs errors on local fs
> ---
>
> Key: HBASE-17538
> URL: https://issues.apache.org/jira/browse/HBASE-17538
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Enis Soztutar
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments:
> 0002-HBASE-17538-HFS.setStoragePolicy-logs-errors-on-loca.patch,
> HBASE-17538.master.001.patch, HBASE-17538.master.002.patch,
> HBASE-17538.master.003.patch
>
>
> On a master pseudo-cluster running on local disk, the log contains a lot of
> these:
> {code}
> 2017-01-25 12:30:41,542 WARN
> [StoreOpener-32976c3c9b7c28ad632c041da486bfc3-1] fs.HFileSystem: Failed to
> set storage policy of
> [file:/var/folders/h5/bbxg50c12r5bhsd9hf1n9hlrgp/T/hbase-enis/hbase/dat
> java.lang.UnsupportedOperationException: Cannot find specified method
> setStoragePolicy
> at
> org.apache.hadoop.hbase.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:209)
> at
> org.apache.hadoop.hbase.fs.HFileSystem.setStoragePolicy(HFileSystem.java:161)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.apache.hadoop.hbase.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:207)
> at
> org.apache.hadoop.hbase.regionserver.HRegionFileSystem.setStoragePolicy(HRegionFileSystem.java:198)
> at org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:237)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:5265)
> at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:988)
> at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:985)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NoSuchMethodException:
> org.apache.hadoop.fs.LocalFileSystem.setStoragePolicy(org.apache.hadoop.fs.Path,
> java.lang.String)
> at java.lang.Class.getMethod(Class.java:1786)
> at
> org.apache.hadoop.hbase.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:205)
> ... 17 more
> {code}
> These are coming from HFS.setStoragePolicy() or HRegionFS.setStoragePolicy()
> .
> This check:
> {code}
> try {
> ReflectionUtils.invokeMethod(this.fs, "setStoragePolicy", storeDir,
> policyName);
> } catch (Exception e) {
> if (!(this.fs instanceof LocalFileSystem)) {
> LOG.warn("Failed to set storage policy of [" + storeDir + "] to [" +
> policyName + "]", e);
> }
> }
> {code}
> does not work, because fs is not a LocalFS, but an HFS. And HFS internally
> does not do this check. seStoragePolicy() is very HDFS specific, the logic
> should instead check whether the underlying fs is HDFS (as opposed to
> checking whether it is not local FS). There are file systems that HBase
> supports other than local or HDFS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17538) HDFS.setStoragePolicy() logs errors on local fs
[
https://issues.apache.org/jira/browse/HBASE-17538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843947#comment-15843947
]
Yu Li commented on HBASE-17538:
---
And the findbugs issue in HadoopQA report for patch v3 is irrelative to the
patch here and tracked by an addendum patch in HBASE-17526
> HDFS.setStoragePolicy() logs errors on local fs
> ---
>
> Key: HBASE-17538
> URL: https://issues.apache.org/jira/browse/HBASE-17538
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Enis Soztutar
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments:
> 0002-HBASE-17538-HFS.setStoragePolicy-logs-errors-on-loca.patch,
> HBASE-17538.master.001.patch, HBASE-17538.master.002.patch,
> HBASE-17538.master.003.patch
>
>
> On a master pseudo-cluster running on local disk, the log contains a lot of
> these:
> {code}
> 2017-01-25 12:30:41,542 WARN
> [StoreOpener-32976c3c9b7c28ad632c041da486bfc3-1] fs.HFileSystem: Failed to
> set storage policy of
> [file:/var/folders/h5/bbxg50c12r5bhsd9hf1n9hlrgp/T/hbase-enis/hbase/dat
> java.lang.UnsupportedOperationException: Cannot find specified method
> setStoragePolicy
> at
> org.apache.hadoop.hbase.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:209)
> at
> org.apache.hadoop.hbase.fs.HFileSystem.setStoragePolicy(HFileSystem.java:161)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.apache.hadoop.hbase.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:207)
> at
> org.apache.hadoop.hbase.regionserver.HRegionFileSystem.setStoragePolicy(HRegionFileSystem.java:198)
> at org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:237)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:5265)
> at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:988)
> at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:985)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NoSuchMethodException:
> org.apache.hadoop.fs.LocalFileSystem.setStoragePolicy(org.apache.hadoop.fs.Path,
> java.lang.String)
> at java.lang.Class.getMethod(Class.java:1786)
> at
> org.apache.hadoop.hbase.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:205)
> ... 17 more
> {code}
> These are coming from HFS.setStoragePolicy() or HRegionFS.setStoragePolicy()
> .
> This check:
> {code}
> try {
> ReflectionUtils.invokeMethod(this.fs, "setStoragePolicy", storeDir,
> policyName);
> } catch (Exception e) {
> if (!(this.fs instanceof LocalFileSystem)) {
> LOG.warn("Failed to set storage policy of [" + storeDir + "] to [" +
> policyName + "]", e);
> }
> }
> {code}
> does not work, because fs is not a LocalFS, but an HFS. And HFS internally
> does not do this check. seStoragePolicy() is very HDFS specific, the logic
> should instead check whether the underlying fs is HDFS (as opposed to
> checking whether it is not local FS). There are file systems that HBase
> supports other than local or HDFS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17526) Procedure v2 - cleanup isSuspended from MasterProcedureScheduler#Queue
[ https://issues.apache.org/jira/browse/HBASE-17526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-17526: -- Status: Patch Available (was: Reopened) Let's check HadoopQA whether the simple addendum resolves the findbugs issue before commit. > Procedure v2 - cleanup isSuspended from MasterProcedureScheduler#Queue > -- > > Key: HBASE-17526 > URL: https://issues.apache.org/jira/browse/HBASE-17526 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Appy >Assignee: Appy >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-17526.addendum.patch, HBASE-17526.master.001.patch > > > Queue#setSuspended() is not used anywhere, probably because when queue > wait/wakes on an event, it gets removed or added back to the fairq. > Removing state, functions, and uses of isSuspended() -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17538) HDFS.setStoragePolicy() logs errors on local fs
[
https://issues.apache.org/jira/browse/HBASE-17538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843943#comment-15843943
]
Yu Li commented on HBASE-17538:
---
+1, nice clean up, left a minor comment on RB. Thanks for fixing the issue I
should have done in my commit sir (and sorry for the mess on UT output) [~stack]
And a Happy Chinese New Year to you all [~stack], [~enis], [~tedyu], I drove
over 800 miles from Beijing to Shanghai this year so it's a special Spring
Festival for me :-)
> HDFS.setStoragePolicy() logs errors on local fs
> ---
>
> Key: HBASE-17538
> URL: https://issues.apache.org/jira/browse/HBASE-17538
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Enis Soztutar
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments:
> 0002-HBASE-17538-HFS.setStoragePolicy-logs-errors-on-loca.patch,
> HBASE-17538.master.001.patch, HBASE-17538.master.002.patch,
> HBASE-17538.master.003.patch
>
>
> On a master pseudo-cluster running on local disk, the log contains a lot of
> these:
> {code}
> 2017-01-25 12:30:41,542 WARN
> [StoreOpener-32976c3c9b7c28ad632c041da486bfc3-1] fs.HFileSystem: Failed to
> set storage policy of
> [file:/var/folders/h5/bbxg50c12r5bhsd9hf1n9hlrgp/T/hbase-enis/hbase/dat
> java.lang.UnsupportedOperationException: Cannot find specified method
> setStoragePolicy
> at
> org.apache.hadoop.hbase.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:209)
> at
> org.apache.hadoop.hbase.fs.HFileSystem.setStoragePolicy(HFileSystem.java:161)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.apache.hadoop.hbase.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:207)
> at
> org.apache.hadoop.hbase.regionserver.HRegionFileSystem.setStoragePolicy(HRegionFileSystem.java:198)
> at org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:237)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:5265)
> at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:988)
> at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:985)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NoSuchMethodException:
> org.apache.hadoop.fs.LocalFileSystem.setStoragePolicy(org.apache.hadoop.fs.Path,
> java.lang.String)
> at java.lang.Class.getMethod(Class.java:1786)
> at
> org.apache.hadoop.hbase.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:205)
> ... 17 more
> {code}
> These are coming from HFS.setStoragePolicy() or HRegionFS.setStoragePolicy()
> .
> This check:
> {code}
> try {
> ReflectionUtils.invokeMethod(this.fs, "setStoragePolicy", storeDir,
> policyName);
> } catch (Exception e) {
> if (!(this.fs instanceof LocalFileSystem)) {
> LOG.warn("Failed to set storage policy of [" + storeDir + "] to [" +
> policyName + "]", e);
> }
> }
> {code}
> does not work, because fs is not a LocalFS, but an HFS. And HFS internally
> does not do this check. seStoragePolicy() is very HDFS specific, the logic
> should instead check whether the underlying fs is HDFS (as opposed to
> checking whether it is not local FS). There are file systems that HBase
> supports other than local or HDFS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17526) Procedure v2 - cleanup isSuspended from MasterProcedureScheduler#Queue
[ https://issues.apache.org/jira/browse/HBASE-17526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-17526: -- Attachment: HBASE-17526.addendum.patch > Procedure v2 - cleanup isSuspended from MasterProcedureScheduler#Queue > -- > > Key: HBASE-17526 > URL: https://issues.apache.org/jira/browse/HBASE-17526 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Appy >Assignee: Appy >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-17526.addendum.patch, HBASE-17526.master.001.patch > > > Queue#setSuspended() is not used anywhere, probably because when queue > wait/wakes on an event, it gets removed or added back to the fairq. > Removing state, functions, and uses of isSuspended() -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HBASE-16785) We are not running all tests
[ https://issues.apache.org/jira/browse/HBASE-16785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-16785. --- Resolution: Fixed Re-resolve after pushing addendum. > We are not running all tests > > > Key: HBASE-16785 > URL: https://issues.apache.org/jira/browse/HBASE-16785 > Project: HBase > Issue Type: Bug > Components: build, test >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: 16785.addendum.patch, HBASE-16785.master.001.patch, > HBASE-16785.master.002 (1).patch, HBASE-16785.master.002 (2).patch, > HBASE-16785.master.002 (2).patch, HBASE-16785.master.002.patch, > HBASE-16785.master.002.patch, HBASE-16785.master.003.patch > > > Noticed by [~mbertozzi] > We have some modules where we tried to 'skip' the running of the second part > of tests -- medium and larges. That might have made sense once when the > module was originally added when there may have been just a few small tests > to run but as time goes by and the module accumulates more tests in a few > cases we've added mediums and larges but we've not removed the 'skip' config. > Matteo noticed this happened in hbase-procedure. > In hbase-client, there is at least a medium test that is being skipped. > Let me try purging this trick everywhere. It doesn't seem to save us anything > going by build time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16785) We are not running all tests
[
https://issues.apache.org/jira/browse/HBASE-16785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-16785:
--
Attachment: 16785.addendum.patch
Pushed below addendum
commit da5722cb487ea5a7fa8dff94faf459aa0d657c14
Author: Michael Stack
Date: Fri Jan 27 22:56:07 2017 -0800
HBASE-16785 We are not running all tests; ADDENDUM Disable
TestHRegionServerBulkLoadWithOldSecureEndpoint because failing since
this patch re-enabled it.
diff --git
a/hbase-endpoint/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldSecureEndpoint.java
b/hbase-endpoint/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldSecureEndpoint.java
index 7ef9b9c..c0d2719 100644
---
a/hbase-endpoint/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldSecureEndpoint.java
+++
b/hbase-endpoint/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldSecureEndpoint.java
@@ -44,6 +44,7 @@ import
org.apache.hadoop.hbase.testclassification.RegionServerTests;
import org.apache.hadoop.hbase.util.Bytes;
import org.apache.hadoop.hbase.util.Pair;
import org.junit.BeforeClass;
+import org.junit.Ignore;
import org.junit.experimental.categories.Category;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
@@ -56,6 +57,7 @@ import com.google.common.collect.Lists;
*/
@RunWith(Parameterized.class)
@Category({RegionServerTests.class, LargeTests.class})
+@Ignore // BROKEN. FIX OR REMOVE.
public class TestHRegionServerBulkLoadWithOldSecureEndpoint extends
TestHRegionServerBulkLoad {
public TestHRegionServerBulkLoadWithOldSecureEndpoint(int duration) {
super(duration);
> We are not running all tests
>
>
> Key: HBASE-16785
> URL: https://issues.apache.org/jira/browse/HBASE-16785
> Project: HBase
> Issue Type: Bug
> Components: build, test
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments: 16785.addendum.patch, HBASE-16785.master.001.patch,
> HBASE-16785.master.002 (1).patch, HBASE-16785.master.002 (2).patch,
> HBASE-16785.master.002 (2).patch, HBASE-16785.master.002.patch,
> HBASE-16785.master.002.patch, HBASE-16785.master.003.patch
>
>
> Noticed by [~mbertozzi]
> We have some modules where we tried to 'skip' the running of the second part
> of tests -- medium and larges. That might have made sense once when the
> module was originally added when there may have been just a few small tests
> to run but as time goes by and the module accumulates more tests in a few
> cases we've added mediums and larges but we've not removed the 'skip' config.
> Matteo noticed this happened in hbase-procedure.
> In hbase-client, there is at least a medium test that is being skipped.
> Let me try purging this trick everywhere. It doesn't seem to save us anything
> going by build time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17526) Procedure v2 - cleanup isSuspended from MasterProcedureScheduler#Queue
[
https://issues.apache.org/jira/browse/HBASE-17526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843939#comment-15843939
]
Yu Li commented on HBASE-17526:
---
Observed the same issue in [pre-commit
check|https://issues.apache.org/jira/browse/HBASE-17538?focusedCommentId=15839541&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15839541]
for HBASE-17538, with below findbugs complaint:
{noformat}
UrF Unread field:
org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler$Queue.suspended
In class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler$Queue
Field
org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler$Queue.suspended
At MasterProcedureScheduler.java:[line 970]
{noformat}
Let me upload an addendum patch to avoid the further complaint for other
patches.
> Procedure v2 - cleanup isSuspended from MasterProcedureScheduler#Queue
> --
>
> Key: HBASE-17526
> URL: https://issues.apache.org/jira/browse/HBASE-17526
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2
>Reporter: Appy
>Assignee: Appy
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-17526.master.001.patch
>
>
> Queue#setSuspended() is not used anywhere, probably because when queue
> wait/wakes on an event, it gets removed or added back to the fairq.
> Removing state, functions, and uses of isSuspended()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17346) Add coprocessor service support
[
https://issues.apache.org/jira/browse/HBASE-17346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843937#comment-15843937
]
Duo Zhang commented on HBASE-17346:
---
{quote}
Do s/done/callback/g I'd say. 'done' I don't get when I see it in your javadoc
example. 'callback' I can follow and 'callback' makes it look like a protobuf
service invocation.
{quote}
'done' is the name of the RpcCallback for a method in a protobuf service, see
this:
{code}
public abstract void getMax(
com.google.protobuf.RpcController controller,
org.apache.hadoop.hbase.protobuf.generated.AggregateProtos.AggregateRequest
request,
com.google.protobuf.RpcCallback
done);
{code}
That's why I always use '(stub, controller, done) -> stub.xxx(controller,
request, done)' as the example. For me 'done' and 'callback' are both OK. I'm
not sure which one is better.
{quote}
Javadoc talks of whenComplete and onComplete?
{quote}
'whenComplete' is 'CompletableFuture.whenComplete'. The pseudo code just wang
to show you how CoprocessorCallback will be called during a ranged coprocessor
service call.
{quote}
We have onRegionComplete and onComplete in the Interface but onRegionComplete
is not called any more? Or if onRegionComplete, then it happens when we are
totally done with the region?
{quote}
Oh sorry for my English, I mean 'no more onRegionComplete calls in the future'.
You can see the pseudo code. We will start locating from the startKey. When
locating complete, if we have not covered the whole range, then send another
locating request. At the same time, we will send the actual coprocessor call to
the located region. When we get the response of the region, we either call
onRegionComplete or onRegionError. If we have already sent all the requests,
and there is no pending request, then we call onComplete.
> Add coprocessor service support
> ---
>
> Key: HBASE-17346
> URL: https://issues.apache.org/jira/browse/HBASE-17346
> Project: HBase
> Issue Type: Sub-task
> Components: asyncclient, Client, Coprocessors
>Affects Versions: 2.0.0
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: 17346.suggestion.txt, HBASE-17346.patch,
> HBASE-17346-v1.patch, HBASE-17346-v2.patch, HBASE-17346-v3.patch
>
>
> I think we need to redesign the API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Reopened] (HBASE-16785) We are not running all tests
[ https://issues.apache.org/jira/browse/HBASE-16785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack reopened HBASE-16785: --- Reopening to add an addendum to disable TestHRegionServerBulkLoadWithOldSecureEndpoint... it is just failing since this patch went in enabling it. Needs looking at... > We are not running all tests > > > Key: HBASE-16785 > URL: https://issues.apache.org/jira/browse/HBASE-16785 > Project: HBase > Issue Type: Bug > Components: build, test >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: HBASE-16785.master.001.patch, HBASE-16785.master.002 > (1).patch, HBASE-16785.master.002 (2).patch, HBASE-16785.master.002 > (2).patch, HBASE-16785.master.002.patch, HBASE-16785.master.002.patch, > HBASE-16785.master.003.patch > > > Noticed by [~mbertozzi] > We have some modules where we tried to 'skip' the running of the second part > of tests -- medium and larges. That might have made sense once when the > module was originally added when there may have been just a few small tests > to run but as time goes by and the module accumulates more tests in a few > cases we've added mediums and larges but we've not removed the 'skip' config. > Matteo noticed this happened in hbase-procedure. > In hbase-client, there is at least a medium test that is being skipped. > Let me try purging this trick everywhere. It doesn't seem to save us anything > going by build time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17346) Add coprocessor service support
[ https://issues.apache.org/jira/browse/HBASE-17346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843919#comment-15843919 ] stack commented on HBASE-17346: --- On the UT, it looks like it just started running as part of the pom edit. Let me just disable it for now. > Add coprocessor service support > --- > > Key: HBASE-17346 > URL: https://issues.apache.org/jira/browse/HBASE-17346 > Project: HBase > Issue Type: Sub-task > Components: asyncclient, Client, Coprocessors >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: 17346.suggestion.txt, HBASE-17346.patch, > HBASE-17346-v1.patch, HBASE-17346-v2.patch, HBASE-17346-v3.patch > > > I think we need to redesign the API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17346) Add coprocessor service support
[
https://issues.apache.org/jira/browse/HBASE-17346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843917#comment-15843917
]
stack commented on HBASE-17346:
---
Reviewed the patch. I can follow it better now.
Do s/done/callback/g I'd say. 'done' I don't get when I see it in your javadoc
example. 'callback' I can follow and 'callback' makes it look like a protobuf
service invocation.
When you say this...
.bq i.e, there will be no {@link #onRegionComplete(HRegionInfo, Object)} calls
anymore.
Have we shipped a client that does onRegionComplete callback? If not, strike
this. It only confuses.
Javadoc talks of whenComplete and onComplete?
We have onRegionComplete and onComplete in the Interface but onRegionComplete
is not called any more? Or if onRegionComplete, then it happens when we are
totally done with the region?
Sorry to fixate on the API and the doc. I think it important to get this bit
clear (and it is tough because what is going on here is a bit voodoo and
magical at same time). Thanks Duo.
[~ghelmling] FYI You might be interested in this spin on your original
EndpointCP work sir.
> Add coprocessor service support
> ---
>
> Key: HBASE-17346
> URL: https://issues.apache.org/jira/browse/HBASE-17346
> Project: HBase
> Issue Type: Sub-task
> Components: asyncclient, Client, Coprocessors
>Affects Versions: 2.0.0
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: 17346.suggestion.txt, HBASE-17346.patch,
> HBASE-17346-v1.patch, HBASE-17346-v2.patch, HBASE-17346-v3.patch
>
>
> I think we need to redesign the API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17346) Add coprocessor service support
[ https://issues.apache.org/jira/browse/HBASE-17346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843908#comment-15843908 ] Duo Zhang commented on HBASE-17346: --- The failed UT also fails on master. > Add coprocessor service support > --- > > Key: HBASE-17346 > URL: https://issues.apache.org/jira/browse/HBASE-17346 > Project: HBase > Issue Type: Sub-task > Components: asyncclient, Client, Coprocessors >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: 17346.suggestion.txt, HBASE-17346.patch, > HBASE-17346-v1.patch, HBASE-17346-v2.patch, HBASE-17346-v3.patch > > > I think we need to redesign the API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17540) Change SASL server GSSAPI callback log line from DEBUG to TRACE in RegionServer to reduce log volumes in DEBUG mode
[ https://issues.apache.org/jira/browse/HBASE-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843892#comment-15843892 ] Hudson commented on HBASE-17540: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #101 (See [https://builds.apache.org/job/HBase-1.3-JDK8/101/]) HBASE-17540 Change SASL server GSSAPI callback log line from DEBUG to (apurtell: rev f0c2cf938cdbd1172faef2ef646a601882ae5400) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java > Change SASL server GSSAPI callback log line from DEBUG to TRACE in > RegionServer to reduce log volumes in DEBUG mode > --- > > Key: HBASE-17540 > URL: https://issues.apache.org/jira/browse/HBASE-17540 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.2.4, 1.1.8 >Reporter: Maddineni Sukumar >Assignee: Maddineni Sukumar >Priority: Minor > Labels: easyfix > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.9 > > Attachments: HBASE-17540-branch-1.1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > For every client connect call to RS we are logging below log line in DEBUG > mode which is causing too many logs in RegionServer. > 2017-01-18 17:51:40,739 DEBUG [.reader=4,port=60020] > security.HBaseSaslRpcServer - SASL server GSSAPI callback: setting > canonicalized client ID: hbase/hostname-xxx@KDC -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17540) Change SASL server GSSAPI callback log line from DEBUG to TRACE in RegionServer to reduce log volumes in DEBUG mode
[ https://issues.apache.org/jira/browse/HBASE-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843880#comment-15843880 ] Hudson commented on HBASE-17540: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #84 (See [https://builds.apache.org/job/HBase-1.2-JDK8/84/]) HBASE-17540 Change SASL server GSSAPI callback log line from DEBUG to (apurtell: rev 466cc9f624647b1e1fdb84eb0b5e9fd20068c195) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java > Change SASL server GSSAPI callback log line from DEBUG to TRACE in > RegionServer to reduce log volumes in DEBUG mode > --- > > Key: HBASE-17540 > URL: https://issues.apache.org/jira/browse/HBASE-17540 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.2.4, 1.1.8 >Reporter: Maddineni Sukumar >Assignee: Maddineni Sukumar >Priority: Minor > Labels: easyfix > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.9 > > Attachments: HBASE-17540-branch-1.1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > For every client connect call to RS we are logging below log line in DEBUG > mode which is causing too many logs in RegionServer. > 2017-01-18 17:51:40,739 DEBUG [.reader=4,port=60020] > security.HBaseSaslRpcServer - SASL server GSSAPI callback: setting > canonicalized client ID: hbase/hostname-xxx@KDC -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17346) Add coprocessor service support
[
https://issues.apache.org/jira/browse/HBASE-17346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843864#comment-15843864
]
Hadoop QA commented on HBASE-17346:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m 59s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
55s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
34s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
40s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 57s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
32s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 14s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 43s {color}
| {color:red} hbase-endpoint in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 60m 33s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.regionserver.TestHRegionServerBulkLoadWithOldSecureEndpoint |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12849800/HBASE-17346-v3.patch |
| JIRA Issue | HBASE-17346 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 8c0a1b526965 3.13.0-98-generic #145-Ubuntu SMP Sat Oct 8
20:13:07 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / bd8a4d5 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/5491/artifact/patchprocess/patch-unit-hbase-endpoint.txt
|
| unit test logs |
https://builds.apache.org/job/PreCommit-HBASE-Build/5491/artifact/patchprocess/patch-unit-hbase-endpoint.txt
[jira] [Commented] (HBASE-17540) Change SASL server GSSAPI callback log line from DEBUG to TRACE in RegionServer to reduce log volumes in DEBUG mode
[ https://issues.apache.org/jira/browse/HBASE-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843821#comment-15843821 ] Hudson commented on HBASE-17540: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #88 (See [https://builds.apache.org/job/HBase-1.3-JDK7/88/]) HBASE-17540 Change SASL server GSSAPI callback log line from DEBUG to (apurtell: rev f0c2cf938cdbd1172faef2ef646a601882ae5400) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java > Change SASL server GSSAPI callback log line from DEBUG to TRACE in > RegionServer to reduce log volumes in DEBUG mode > --- > > Key: HBASE-17540 > URL: https://issues.apache.org/jira/browse/HBASE-17540 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.2.4, 1.1.8 >Reporter: Maddineni Sukumar >Assignee: Maddineni Sukumar >Priority: Minor > Labels: easyfix > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.9 > > Attachments: HBASE-17540-branch-1.1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > For every client connect call to RS we are logging below log line in DEBUG > mode which is causing too many logs in RegionServer. > 2017-01-18 17:51:40,739 DEBUG [.reader=4,port=60020] > security.HBaseSaslRpcServer - SASL server GSSAPI callback: setting > canonicalized client ID: hbase/hostname-xxx@KDC -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17540) Change SASL server GSSAPI callback log line from DEBUG to TRACE in RegionServer to reduce log volumes in DEBUG mode
[ https://issues.apache.org/jira/browse/HBASE-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843820#comment-15843820 ] Hudson commented on HBASE-17540: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2398 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2398/]) HBASE-17540 Change SASL server GSSAPI callback log line from DEBUG to (apurtell: rev bd8a4d5fadec1dd804aa7eb0a185a492a6f5805a) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java > Change SASL server GSSAPI callback log line from DEBUG to TRACE in > RegionServer to reduce log volumes in DEBUG mode > --- > > Key: HBASE-17540 > URL: https://issues.apache.org/jira/browse/HBASE-17540 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.2.4, 1.1.8 >Reporter: Maddineni Sukumar >Assignee: Maddineni Sukumar >Priority: Minor > Labels: easyfix > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.9 > > Attachments: HBASE-17540-branch-1.1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > For every client connect call to RS we are logging below log line in DEBUG > mode which is causing too many logs in RegionServer. > 2017-01-18 17:51:40,739 DEBUG [.reader=4,port=60020] > security.HBaseSaslRpcServer - SASL server GSSAPI callback: setting > canonicalized client ID: hbase/hostname-xxx@KDC -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17346) Add coprocessor service support
[ https://issues.apache.org/jira/browse/HBASE-17346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843808#comment-15843808 ] Duo Zhang commented on HBASE-17346: --- [~stack] I've add (a lot of) comments for the new methods and classes to describe how they work, especially some sample code. Can you see if it helps you to better understand the implementation? Thanks. > Add coprocessor service support > --- > > Key: HBASE-17346 > URL: https://issues.apache.org/jira/browse/HBASE-17346 > Project: HBase > Issue Type: Sub-task > Components: asyncclient, Client, Coprocessors >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: 17346.suggestion.txt, HBASE-17346.patch, > HBASE-17346-v1.patch, HBASE-17346-v2.patch, HBASE-17346-v3.patch > > > I think we need to redesign the API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17346) Add coprocessor service support
[ https://issues.apache.org/jira/browse/HBASE-17346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-17346: -- Attachment: HBASE-17346-v3.patch Add javadoc for newly added mehods and classes. > Add coprocessor service support > --- > > Key: HBASE-17346 > URL: https://issues.apache.org/jira/browse/HBASE-17346 > Project: HBase > Issue Type: Sub-task > Components: asyncclient, Client, Coprocessors >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: 17346.suggestion.txt, HBASE-17346.patch, > HBASE-17346-v1.patch, HBASE-17346-v2.patch, HBASE-17346-v3.patch > > > I think we need to redesign the API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17565) StochasticLoadBalancer may incorrectly skip balancing due to skewed multiplier sum
[
https://issues.apache.org/jira/browse/HBASE-17565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843798#comment-15843798
]
Ted Yu commented on HBASE-17565:
By checking the product of cost * multiplier, making the tests pass becomes
easy.
> StochasticLoadBalancer may incorrectly skip balancing due to skewed
> multiplier sum
> --
>
> Key: HBASE-17565
> URL: https://issues.apache.org/jira/browse/HBASE-17565
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.4.0
>
> Attachments: 17565.v1.txt, 17565.v2.txt
>
>
> I was investigating why a 6 node cluster kept skipping balancing requests.
> Here were the region counts on the servers:
> 449, 448, 447, 449, 453, 0
> {code}
> 2017-01-26 22:04:47,145 INFO
> [RpcServer.deafult.FPBQ.Fifo.handler=1,queue=0,port=16000]
> balancer.StochasticLoadBalancer: Skipping load balancing because balanced
> cluster; total cost is 127.0171157050385, sum multiplier is 111087.0 min cost
> which need balance is 0.05
> {code}
> The big multiplier sum caught my eyes. Here was what additional debug logging
> showed:
> {code}
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaHostCostFunction with multiplier 10.0
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaRackCostFunction with multiplier 1.0
> {code}
> Note however, that no table in the cluster used read replica.
> I can think of two ways of fixing this situation:
> 1. If there is no read replica in the cluster, ignore the multipliers for the
> above two functions.
> 2. When cost() returned by the CostFunction is 0 (or very very close to 0.0),
> ignore the multiplier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17565) StochasticLoadBalancer may incorrectly skip balancing due to skewed multiplier sum
[
https://issues.apache.org/jira/browse/HBASE-17565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17565:
---
Fix Version/s: 1.4.0
2.0.0
> StochasticLoadBalancer may incorrectly skip balancing due to skewed
> multiplier sum
> --
>
> Key: HBASE-17565
> URL: https://issues.apache.org/jira/browse/HBASE-17565
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.4.0
>
> Attachments: 17565.v1.txt, 17565.v2.txt
>
>
> I was investigating why a 6 node cluster kept skipping balancing requests.
> Here were the region counts on the servers:
> 449, 448, 447, 449, 453, 0
> {code}
> 2017-01-26 22:04:47,145 INFO
> [RpcServer.deafult.FPBQ.Fifo.handler=1,queue=0,port=16000]
> balancer.StochasticLoadBalancer: Skipping load balancing because balanced
> cluster; total cost is 127.0171157050385, sum multiplier is 111087.0 min cost
> which need balance is 0.05
> {code}
> The big multiplier sum caught my eyes. Here was what additional debug logging
> showed:
> {code}
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaHostCostFunction with multiplier 10.0
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaRackCostFunction with multiplier 1.0
> {code}
> Note however, that no table in the cluster used read replica.
> I can think of two ways of fixing this situation:
> 1. If there is no read replica in the cluster, ignore the multipliers for the
> above two functions.
> 2. When cost() returned by the CostFunction is 0 (or very very close to 0.0),
> ignore the multiplier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17565) StochasticLoadBalancer may incorrectly skip balancing due to skewed multiplier sum
[
https://issues.apache.org/jira/browse/HBASE-17565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17565:
---
Attachment: 17565.v2.txt
> StochasticLoadBalancer may incorrectly skip balancing due to skewed
> multiplier sum
> --
>
> Key: HBASE-17565
> URL: https://issues.apache.org/jira/browse/HBASE-17565
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 17565.v1.txt, 17565.v2.txt
>
>
> I was investigating why a 6 node cluster kept skipping balancing requests.
> Here were the region counts on the servers:
> 449, 448, 447, 449, 453, 0
> {code}
> 2017-01-26 22:04:47,145 INFO
> [RpcServer.deafult.FPBQ.Fifo.handler=1,queue=0,port=16000]
> balancer.StochasticLoadBalancer: Skipping load balancing because balanced
> cluster; total cost is 127.0171157050385, sum multiplier is 111087.0 min cost
> which need balance is 0.05
> {code}
> The big multiplier sum caught my eyes. Here was what additional debug logging
> showed:
> {code}
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaHostCostFunction with multiplier 10.0
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaRackCostFunction with multiplier 1.0
> {code}
> Note however, that no table in the cluster used read replica.
> I can think of two ways of fixing this situation:
> 1. If there is no read replica in the cluster, ignore the multipliers for the
> above two functions.
> 2. When cost() returned by the CostFunction is 0 (or very very close to 0.0),
> ignore the multiplier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17565) StochasticLoadBalancer may incorrectly skip balancing due to skewed multiplier sum
[
https://issues.apache.org/jira/browse/HBASE-17565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17565:
---
Attachment: (was: 17565.v2.txt)
> StochasticLoadBalancer may incorrectly skip balancing due to skewed
> multiplier sum
> --
>
> Key: HBASE-17565
> URL: https://issues.apache.org/jira/browse/HBASE-17565
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 17565.v1.txt
>
>
> I was investigating why a 6 node cluster kept skipping balancing requests.
> Here were the region counts on the servers:
> 449, 448, 447, 449, 453, 0
> {code}
> 2017-01-26 22:04:47,145 INFO
> [RpcServer.deafult.FPBQ.Fifo.handler=1,queue=0,port=16000]
> balancer.StochasticLoadBalancer: Skipping load balancing because balanced
> cluster; total cost is 127.0171157050385, sum multiplier is 111087.0 min cost
> which need balance is 0.05
> {code}
> The big multiplier sum caught my eyes. Here was what additional debug logging
> showed:
> {code}
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaHostCostFunction with multiplier 10.0
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaRackCostFunction with multiplier 1.0
> {code}
> Note however, that no table in the cluster used read replica.
> I can think of two ways of fixing this situation:
> 1. If there is no read replica in the cluster, ignore the multipliers for the
> above two functions.
> 2. When cost() returned by the CostFunction is 0 (or very very close to 0.0),
> ignore the multiplier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17565) StochasticLoadBalancer may incorrectly skip balancing due to skewed multiplier sum
[
https://issues.apache.org/jira/browse/HBASE-17565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17565:
---
Status: Patch Available (was: Open)
> StochasticLoadBalancer may incorrectly skip balancing due to skewed
> multiplier sum
> --
>
> Key: HBASE-17565
> URL: https://issues.apache.org/jira/browse/HBASE-17565
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 17565.v1.txt
>
>
> I was investigating why a 6 node cluster kept skipping balancing requests.
> Here were the region counts on the servers:
> 449, 448, 447, 449, 453, 0
> {code}
> 2017-01-26 22:04:47,145 INFO
> [RpcServer.deafult.FPBQ.Fifo.handler=1,queue=0,port=16000]
> balancer.StochasticLoadBalancer: Skipping load balancing because balanced
> cluster; total cost is 127.0171157050385, sum multiplier is 111087.0 min cost
> which need balance is 0.05
> {code}
> The big multiplier sum caught my eyes. Here was what additional debug logging
> showed:
> {code}
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaHostCostFunction with multiplier 10.0
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaRackCostFunction with multiplier 1.0
> {code}
> Note however, that no table in the cluster used read replica.
> I can think of two ways of fixing this situation:
> 1. If there is no read replica in the cluster, ignore the multipliers for the
> above two functions.
> 2. When cost() returned by the CostFunction is 0 (or very very close to 0.0),
> ignore the multiplier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17565) StochasticLoadBalancer may incorrectly skip balancing due to skewed multiplier sum
[
https://issues.apache.org/jira/browse/HBASE-17565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17565:
---
Attachment: 17565.v2.txt
> StochasticLoadBalancer may incorrectly skip balancing due to skewed
> multiplier sum
> --
>
> Key: HBASE-17565
> URL: https://issues.apache.org/jira/browse/HBASE-17565
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 17565.v1.txt
>
>
> I was investigating why a 6 node cluster kept skipping balancing requests.
> Here were the region counts on the servers:
> 449, 448, 447, 449, 453, 0
> {code}
> 2017-01-26 22:04:47,145 INFO
> [RpcServer.deafult.FPBQ.Fifo.handler=1,queue=0,port=16000]
> balancer.StochasticLoadBalancer: Skipping load balancing because balanced
> cluster; total cost is 127.0171157050385, sum multiplier is 111087.0 min cost
> which need balance is 0.05
> {code}
> The big multiplier sum caught my eyes. Here was what additional debug logging
> showed:
> {code}
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaHostCostFunction with multiplier 10.0
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaRackCostFunction with multiplier 1.0
> {code}
> Note however, that no table in the cluster used read replica.
> I can think of two ways of fixing this situation:
> 1. If there is no read replica in the cluster, ignore the multipliers for the
> above two functions.
> 2. When cost() returned by the CostFunction is 0 (or very very close to 0.0),
> ignore the multiplier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17540) Change SASL server GSSAPI callback log line from DEBUG to TRACE in RegionServer to reduce log volumes in DEBUG mode
[ https://issues.apache.org/jira/browse/HBASE-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843783#comment-15843783 ] Hudson commented on HBASE-17540: FAILURE: Integrated in Jenkins build HBase-1.3-IT #820 (See [https://builds.apache.org/job/HBase-1.3-IT/820/]) HBASE-17540 Change SASL server GSSAPI callback log line from DEBUG to (apurtell: rev 466cc9f624647b1e1fdb84eb0b5e9fd20068c195) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java > Change SASL server GSSAPI callback log line from DEBUG to TRACE in > RegionServer to reduce log volumes in DEBUG mode > --- > > Key: HBASE-17540 > URL: https://issues.apache.org/jira/browse/HBASE-17540 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.2.4, 1.1.8 >Reporter: Maddineni Sukumar >Assignee: Maddineni Sukumar >Priority: Minor > Labels: easyfix > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.9 > > Attachments: HBASE-17540-branch-1.1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > For every client connect call to RS we are logging below log line in DEBUG > mode which is causing too many logs in RegionServer. > 2017-01-18 17:51:40,739 DEBUG [.reader=4,port=60020] > security.HBaseSaslRpcServer - SASL server GSSAPI callback: setting > canonicalized client ID: hbase/hostname-xxx@KDC -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17540) Change SASL server GSSAPI callback log line from DEBUG to TRACE in RegionServer to reduce log volumes in DEBUG mode
[ https://issues.apache.org/jira/browse/HBASE-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843771#comment-15843771 ] Hudson commented on HBASE-17540: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #90 (See [https://builds.apache.org/job/HBase-1.2-JDK7/90/]) HBASE-17540 Change SASL server GSSAPI callback log line from DEBUG to (apurtell: rev 466cc9f624647b1e1fdb84eb0b5e9fd20068c195) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java > Change SASL server GSSAPI callback log line from DEBUG to TRACE in > RegionServer to reduce log volumes in DEBUG mode > --- > > Key: HBASE-17540 > URL: https://issues.apache.org/jira/browse/HBASE-17540 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.2.4, 1.1.8 >Reporter: Maddineni Sukumar >Assignee: Maddineni Sukumar >Priority: Minor > Labels: easyfix > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.9 > > Attachments: HBASE-17540-branch-1.1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > For every client connect call to RS we are logging below log line in DEBUG > mode which is causing too many logs in RegionServer. > 2017-01-18 17:51:40,739 DEBUG [.reader=4,port=60020] > security.HBaseSaslRpcServer - SASL server GSSAPI callback: setting > canonicalized client ID: hbase/hostname-xxx@KDC -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17540) Change SASL server GSSAPI callback log line from DEBUG to TRACE in RegionServer to reduce log volumes in DEBUG mode
[ https://issues.apache.org/jira/browse/HBASE-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843769#comment-15843769 ] Hudson commented on HBASE-17540: FAILURE: Integrated in Jenkins build HBase-1.4 #606 (See [https://builds.apache.org/job/HBase-1.4/606/]) HBASE-17540 Change SASL server GSSAPI callback log line from DEBUG to (apurtell: rev c937e9786431dac7f9dc313e6f9eef08db994a42) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java > Change SASL server GSSAPI callback log line from DEBUG to TRACE in > RegionServer to reduce log volumes in DEBUG mode > --- > > Key: HBASE-17540 > URL: https://issues.apache.org/jira/browse/HBASE-17540 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.2.4, 1.1.8 >Reporter: Maddineni Sukumar >Assignee: Maddineni Sukumar >Priority: Minor > Labels: easyfix > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.9 > > Attachments: HBASE-17540-branch-1.1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > For every client connect call to RS we are logging below log line in DEBUG > mode which is causing too many logs in RegionServer. > 2017-01-18 17:51:40,739 DEBUG [.reader=4,port=60020] > security.HBaseSaslRpcServer - SASL server GSSAPI callback: setting > canonicalized client ID: hbase/hostname-xxx@KDC -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17557) HRegionServer#reportRegionSizesForQuotas() should respond to UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HBASE-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843768#comment-15843768
]
Ted Yu commented on HBASE-17557:
Quota related tests passed.
> HRegionServer#reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException
> --
>
> Key: HBASE-17557
> URL: https://issues.apache.org/jira/browse/HBASE-17557
> Project: HBase
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 17557.HBASE-16961.v2.txt, 17557.HBASE-16961.v3.txt
>
>
> When master doesn't support quota, you would see the following repeatedly in
> region server log:
> {code}
> 2017-01-27 17:24:27,389 DEBUG
> [cn011.x.com,16020,1485468203653_ChoreService_1] regionserver.HRegionServer:
> Failed to report region sizes to Master. This will be retried.
> org.apache.hadoop.hbase.DoNotRetryIOException: /23:16000 is unable to read
> call parameter from client 21; java.lang.UnsupportedOperationException:
> ReportRegionSpaceUse
> at sun.reflect.GeneratedConstructorAccessor8.newInstance(Unknown
> Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)
> at
> org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:95)
> at
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:334)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1211)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.reportRegionSizesToMaster(FileSystemUtilizationChore.java:170)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.chore(FileSystemUtilizationChore.java:129)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:185)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by:
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.DoNotRetryIOException):
> /23:16000 is unable to read call parameter from client 21; java.lang.
> UnsupportedOperationException: ReportRegionSpaceUse
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1225)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:213)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:287)
> at
> org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.reportRegionSpaceUse(RegionServerStatusProtos.java:10919)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1209)
> {code}
> HRegionServer.reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException and stop retrying.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17565) StochasticLoadBalancer may incorrectly skip balancing due to skewed multiplier sum
[
https://issues.apache.org/jira/browse/HBASE-17565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843705#comment-15843705
]
Enis Soztutar commented on HBASE-17565:
---
Not sure about the test failures. We used to always run the SLB regardless of
needsBalance(). The logic in the patch seems fine as it is if we can get the
UTs passing.
> StochasticLoadBalancer may incorrectly skip balancing due to skewed
> multiplier sum
> --
>
> Key: HBASE-17565
> URL: https://issues.apache.org/jira/browse/HBASE-17565
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 17565.v1.txt
>
>
> I was investigating why a 6 node cluster kept skipping balancing requests.
> Here were the region counts on the servers:
> 449, 448, 447, 449, 453, 0
> {code}
> 2017-01-26 22:04:47,145 INFO
> [RpcServer.deafult.FPBQ.Fifo.handler=1,queue=0,port=16000]
> balancer.StochasticLoadBalancer: Skipping load balancing because balanced
> cluster; total cost is 127.0171157050385, sum multiplier is 111087.0 min cost
> which need balance is 0.05
> {code}
> The big multiplier sum caught my eyes. Here was what additional debug logging
> showed:
> {code}
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaHostCostFunction with multiplier 10.0
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaRackCostFunction with multiplier 1.0
> {code}
> Note however, that no table in the cluster used read replica.
> I can think of two ways of fixing this situation:
> 1. If there is no read replica in the cluster, ignore the multipliers for the
> above two functions.
> 2. When cost() returned by the CostFunction is 0 (or very very close to 0.0),
> ignore the multiplier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17565) StochasticLoadBalancer may incorrectly skip balancing due to skewed multiplier sum
[
https://issues.apache.org/jira/browse/HBASE-17565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17565:
---
Attachment: 17565.v1.txt
Patch v1 follows option #2 above.
In cluster testing, the balancer starts to balance regions.
However, there're a lot of test failures.
So I want to get other people's input first.
> StochasticLoadBalancer may incorrectly skip balancing due to skewed
> multiplier sum
> --
>
> Key: HBASE-17565
> URL: https://issues.apache.org/jira/browse/HBASE-17565
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 17565.v1.txt
>
>
> I was investigating why a 6 node cluster kept skipping balancing requests.
> Here were the region counts on the servers:
> 449, 448, 447, 449, 453, 0
> {code}
> 2017-01-26 22:04:47,145 INFO
> [RpcServer.deafult.FPBQ.Fifo.handler=1,queue=0,port=16000]
> balancer.StochasticLoadBalancer: Skipping load balancing because balanced
> cluster; total cost is 127.0171157050385, sum multiplier is 111087.0 min cost
> which need balance is 0.05
> {code}
> The big multiplier sum caught my eyes. Here was what additional debug logging
> showed:
> {code}
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaHostCostFunction with multiplier 10.0
> 2017-01-27 23:25:31,749 DEBUG
> [RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
> balancer.StochasticLoadBalancer: class
> org.apache.hadoop.hbase.master.balancer.
> StochasticLoadBalancer$RegionReplicaRackCostFunction with multiplier 1.0
> {code}
> Note however, that no table in the cluster used read replica.
> I can think of two ways of fixing this situation:
> 1. If there is no read replica in the cluster, ignore the multipliers for the
> above two functions.
> 2. When cost() returned by the CostFunction is 0 (or very very close to 0.0),
> ignore the multiplier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17280) Add mechanism to control hbase cleaner behavior
[
https://issues.apache.org/jira/browse/HBASE-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843693#comment-15843693
]
Hadoop QA commented on HBASE-17280:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 40s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 1s
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 1s
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 20s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
9s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 28s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 14m
9s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
56s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 55s
{color} | {color:red} hbase-protocol-shaded in master has 24 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 42s
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
38s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 29s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 29s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 29s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 14m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
45s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 9 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 36s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m
37s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
55s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 17s
{color} | {color:red} hbase-client generated 1 new + 13 unchanged - 0 fixed =
14 total (was 13) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 31s
{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 26s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 86m 20s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 58s
{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
53s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {c
[jira] [Created] (HBASE-17565) StochasticLoadBalancer may incorrectly skip balancing due to skewed multiplier sum
Ted Yu created HBASE-17565:
--
Summary: StochasticLoadBalancer may incorrectly skip balancing due
to skewed multiplier sum
Key: HBASE-17565
URL: https://issues.apache.org/jira/browse/HBASE-17565
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
I was investigating why a 6 node cluster kept skipping balancing requests.
Here were the region counts on the servers:
449, 448, 447, 449, 453, 0
{code}
2017-01-26 22:04:47,145 INFO
[RpcServer.deafult.FPBQ.Fifo.handler=1,queue=0,port=16000]
balancer.StochasticLoadBalancer: Skipping load balancing because balanced
cluster; total cost is 127.0171157050385, sum multiplier is 111087.0 min cost
which need balance is 0.05
{code}
The big multiplier sum caught my eyes. Here was what additional debug logging
showed:
{code}
2017-01-27 23:25:31,749 DEBUG
[RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
balancer.StochasticLoadBalancer: class org.apache.hadoop.hbase.master.balancer.
StochasticLoadBalancer$RegionReplicaHostCostFunction with multiplier
10.0
2017-01-27 23:25:31,749 DEBUG
[RpcServer.deafult.FPBQ.Fifo.handler=9,queue=0,port=16000]
balancer.StochasticLoadBalancer: class org.apache.hadoop.hbase.master.balancer.
StochasticLoadBalancer$RegionReplicaRackCostFunction with multiplier
1.0
{code}
Note however, that no table in the cluster used read replica.
I can think of two ways of fixing this situation:
1. If there is no read replica in the cluster, ignore the multipliers for the
above two functions.
2. When cost() returned by the CostFunction is 0 (or very very close to 0.0),
ignore the multiplier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17563) Foreach and switch in RootDocProcessor and StabilityOptions
[
https://issues.apache.org/jira/browse/HBASE-17563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843680#comment-15843680
]
Hadoop QA commented on HBASE-17563:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
40s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 6s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
5s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
12s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 7s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
6s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 7s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 7s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
6s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
24m 21s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 7s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 6s
{color} | {color:green} hbase-annotations in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 15s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12849772/HBASE-17563.master.002.patch
|
| JIRA Issue | HBASE-17563 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux caab67244066 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / bd8a4d5 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/5488/testReport/ |
| modules | C: hbase-annotations U: hbase-annotations |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/5488/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Foreach and switch in RootDocProcessor and StabilityOptions
> ---
>
> Key: HBASE-17563
> URL: https://issues.apache.org/jira/browse/HBASE-17563
> Project: HBase
> Issue Type: Improvement
>Reporter: Jan Hentschel
>
[jira] [Commented] (HBASE-17564) Fix remaining calls to deprecated methods of Admin and HBaseAdmin
[
https://issues.apache.org/jira/browse/HBASE-17564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843672#comment-15843672
]
Hadoop QA commented on HBASE-17564:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
9s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 0s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 15s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 15s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 42s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 0s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 19s
{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 30s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12849769/HBASE-17564.master.001.patch
|
| JIRA Issue | HBASE-17564 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 433e905963ad 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24
10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / bd8a4d5 |
| Default Java | 1.8.0_121 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/5487/testReport/ |
| modules | C: hbase-it U: hbase-it |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/5487/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Fix remaining calls to deprecated methods of Admin and HBaseAdmin
> -
>
> Key: HBASE-17564
> URL: https://issues.apache.org/jira/browse/HBASE-17564
> Project: HBase
> Issue Type: Improvement
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Attachments: HBASE-17564.master.001.patch
>
>
> Fix the remaining calls to depreca
[jira] [Commented] (HBASE-17556) The client will not invalidate stale region caches
[
https://issues.apache.org/jira/browse/HBASE-17556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843664#comment-15843664
]
Enis Soztutar commented on HBASE-17556:
---
Some of the fixes are here:
{code}
commit 94d576025fd158dae03dd6a6b50a62483b0f04e0
Author: Mikhail Antonov
Date: Wed Mar 16 16:32:11 2016 -0700
HBASE-15390 Unnecessary MetaCache evictions cause elevated number of
requests to meta
commit 43698b3fcb6b6759c5acae3b889e6b280c2205bd
Author: Mikhail Antonov
Date: Mon Mar 7 17:33:43 2016 -0800
HBASE-15354 Use same criteria for clearing meta cache for all operations
(Ashu Pachauri)
commit d747188f2cb7d198393a35f4dde543a798fed3c8
Author: Josh Elser
Date: Mon Feb 8 14:25:37 2016 -0500
HBASE-15232 Handle region location cache mgmt in AsyncProcess for multi()'s
{code}
Maybe you can take a look at the branch-1 or master code to see whether the
issue is still there. A unit test that can reproduce would be really useful if
you have the time.
> The client will not invalidate stale region caches
> --
>
> Key: HBASE-17556
> URL: https://issues.apache.org/jira/browse/HBASE-17556
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.0.0, 2.0.0, 0.98.24
>Reporter: Marcin Januszkiewicz
>Priority: Critical
>
> We noticed in our application, that sometimes when we interact with a table
> an operation will fail with an exception, an all operations that happen on
> the same region will also fail until the application is restarted.
> It seems that when a merge or split happens on a region that is already in
> the clients cache, and the client is configured to retry operations, then
> there is no way for the client to detect this. In
> RpcRetryingCaller#callWithRetries if a call fails with
> RegionNotServingException then the cache will be cleared only if the retry
> parameter is equal to 1. This means the call will fail but the following
> calls will succeed.
> RpcRetryingCaller#callWithoutRetries contains the comment "It would be nice
> to clear the location cache here". Additionally, the stale cache will cause
> this call to fail, even though the data is available.
> See also HBASE-12534
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17540) Change SASL server GSSAPI callback log line from DEBUG to TRACE in RegionServer to reduce log volumes in DEBUG mode
[ https://issues.apache.org/jira/browse/HBASE-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843660#comment-15843660 ] Hudson commented on HBASE-17540: FAILURE: Integrated in Jenkins build HBase-1.2-IT #586 (See [https://builds.apache.org/job/HBase-1.2-IT/586/]) HBASE-17540 Change SASL server GSSAPI callback log line from DEBUG to (apurtell: rev 466cc9f624647b1e1fdb84eb0b5e9fd20068c195) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java > Change SASL server GSSAPI callback log line from DEBUG to TRACE in > RegionServer to reduce log volumes in DEBUG mode > --- > > Key: HBASE-17540 > URL: https://issues.apache.org/jira/browse/HBASE-17540 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.2.4, 1.1.8 >Reporter: Maddineni Sukumar >Assignee: Maddineni Sukumar >Priority: Minor > Labels: easyfix > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.9 > > Attachments: HBASE-17540-branch-1.1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > For every client connect call to RS we are logging below log line in DEBUG > mode which is causing too many logs in RegionServer. > 2017-01-18 17:51:40,739 DEBUG [.reader=4,port=60020] > security.HBaseSaslRpcServer - SASL server GSSAPI callback: setting > canonicalized client ID: hbase/hostname-xxx@KDC -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17557) HRegionServer#reportRegionSizesForQuotas() should respond to UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HBASE-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843659#comment-15843659
]
Hadoop QA commented on HBASE-17557:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 26s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 2s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
52s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s
{color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
32s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s
{color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
38s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m 57s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.4.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 59s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 6s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 1s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 1s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.5.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
40s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 84m 19s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 125m 16s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12849753/17557.HBASE-16961.v3.txt
|
| JIRA Issue | HBASE-17557 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 671f33de4773 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenki
[jira] [Commented] (HBASE-17437) Support specifying a WAL directory outside of the root directory
[ https://issues.apache.org/jira/browse/HBASE-17437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843652#comment-15843652 ] Enis Soztutar commented on HBASE-17437: --- bq. I will be implementing approach 1 to move complete this JIRA, but then would like to do approach 2 in a follow-up JIRA. Sounds good. My gut feeling is that HFS has good intentions, but it will be a very intrusive and bigger patch if we want to take on completely abstracting two different file systems under it. Let's go with this patch as it is according to above. > Support specifying a WAL directory outside of the root directory > > > Key: HBASE-17437 > URL: https://issues.apache.org/jira/browse/HBASE-17437 > Project: HBase > Issue Type: Improvement > Components: Filesystem Integration, wal >Affects Versions: 1.2.4 >Reporter: Yishan Yang >Assignee: Zach York > Labels: patch > Fix For: 2.0.0, 1.4.0 > > Attachments: hbase-17437-branch-1.2.patch, > HBASE-17437.master.001.patch, HBASE-17437.master.002.patch, > HBASE-17437.master.003.patch, HBASE-17437.master.004.patch, > hbase-17437-master.patch > > > Currently, the WAL and the StoreFiles need to be on the same FileSystem. Some > FileSystems (such as Amazon S3) don’t support append or consistent writes. > These two properties are imperative for the WAL in order to avoid loss of > writes. However, StoreFiles don’t necessarily need the same consistency > guarantees (since writes are cached locally and if writes fail, they can > always be replayed from the WAL). > > This JIRA aims to allow users to configure a log directory (for WALs) that is > outside of the root directory or even in a different FileSystem. The default > value will still put the log directory under the root directory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17563) Foreach and switch in RootDocProcessor and StabilityOptions
[ https://issues.apache.org/jira/browse/HBASE-17563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-17563: -- Attachment: HBASE-17563.master.002.patch > Foreach and switch in RootDocProcessor and StabilityOptions > --- > > Key: HBASE-17563 > URL: https://issues.apache.org/jira/browse/HBASE-17563 > Project: HBase > Issue Type: Improvement >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-17563.master.001.patch, > HBASE-17563.master.002.patch > > > To make the code in *RootDocProcessor* and *StabilityOptions* more readable > change the existing for-loops and if-statements to foreach-loops and > switch-statements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17540) Change SASL server GSSAPI callback log line from DEBUG to TRACE in RegionServer to reduce log volumes in DEBUG mode
[ https://issues.apache.org/jira/browse/HBASE-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-17540: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.2.5 1.3.1 1.4.0 2.0.0 Status: Resolved (was: Patch Available) > Change SASL server GSSAPI callback log line from DEBUG to TRACE in > RegionServer to reduce log volumes in DEBUG mode > --- > > Key: HBASE-17540 > URL: https://issues.apache.org/jira/browse/HBASE-17540 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.2.4, 1.1.8 >Reporter: Maddineni Sukumar >Assignee: Maddineni Sukumar >Priority: Minor > Labels: easyfix > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.9 > > Attachments: HBASE-17540-branch-1.1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > For every client connect call to RS we are logging below log line in DEBUG > mode which is causing too many logs in RegionServer. > 2017-01-18 17:51:40,739 DEBUG [.reader=4,port=60020] > security.HBaseSaslRpcServer - SASL server GSSAPI callback: setting > canonicalized client ID: hbase/hostname-xxx@KDC -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17564) Fix remaining calls to deprecated methods of Admin and HBaseAdmin
[ https://issues.apache.org/jira/browse/HBASE-17564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-17564: -- Status: Patch Available (was: In Progress) > Fix remaining calls to deprecated methods of Admin and HBaseAdmin > - > > Key: HBASE-17564 > URL: https://issues.apache.org/jira/browse/HBASE-17564 > Project: HBase > Issue Type: Improvement >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-17564.master.001.patch > > > Fix the remaining calls to deprecated methods of the *Admin* interface and > the *HBaseAdmin* class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17564) Fix remaining calls to deprecated methods of Admin and HBaseAdmin
[ https://issues.apache.org/jira/browse/HBASE-17564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-17564: -- Attachment: HBASE-17564.master.001.patch > Fix remaining calls to deprecated methods of Admin and HBaseAdmin > - > > Key: HBASE-17564 > URL: https://issues.apache.org/jira/browse/HBASE-17564 > Project: HBase > Issue Type: Improvement >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-17564.master.001.patch > > > Fix the remaining calls to deprecated methods of the *Admin* interface and > the *HBaseAdmin* class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-17564) Fix remaining calls to deprecated methods of Admin and HBaseAdmin
Jan Hentschel created HBASE-17564: - Summary: Fix remaining calls to deprecated methods of Admin and HBaseAdmin Key: HBASE-17564 URL: https://issues.apache.org/jira/browse/HBASE-17564 Project: HBase Issue Type: Improvement Reporter: Jan Hentschel Assignee: Jan Hentschel Priority: Trivial Fix the remaining calls to deprecated methods of the *Admin* interface and the *HBaseAdmin* class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (HBASE-17564) Fix remaining calls to deprecated methods of Admin and HBaseAdmin
[ https://issues.apache.org/jira/browse/HBASE-17564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-17564 started by Jan Hentschel. - > Fix remaining calls to deprecated methods of Admin and HBaseAdmin > - > > Key: HBASE-17564 > URL: https://issues.apache.org/jira/browse/HBASE-17564 > Project: HBase > Issue Type: Improvement >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > > Fix the remaining calls to deprecated methods of the *Admin* interface and > the *HBaseAdmin* class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17437) Support specifying a WAL directory outside of the root directory
[ https://issues.apache.org/jira/browse/HBASE-17437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843630#comment-15843630 ] Zach York commented on HBASE-17437: --- [~enis] [~stack] Thanks for the reviews. I will update the patch today. Also, thanks for explaining the fs redo project. I would love to help with that effort (and try to get some of it out by HBase 2.0 if I have some good reviewers ;) ). I have been thinking about moving everything to HFileSystem and have a couple approaches: 1) Naive approach: Move the getWALRootDirectory() and getWALFileSystem() to HFileSystem and use them as they are being used right now. This way is error-prone because people can forget to use the right FileSystem in their changes (after this change) and break things. 2) Intelligent approach: Have HFileSystem override all the methods from FileSystem and ensure that the correct FileSystem is used based off of the scheme. This way is much better, but might incur a small performance loss (should be negligible though). What do you guys think? I will be implementing approach 1 to move complete this JIRA, but then would like to do approach 2 in a follow-up JIRA. > Support specifying a WAL directory outside of the root directory > > > Key: HBASE-17437 > URL: https://issues.apache.org/jira/browse/HBASE-17437 > Project: HBase > Issue Type: Improvement > Components: Filesystem Integration, wal >Affects Versions: 1.2.4 >Reporter: Yishan Yang >Assignee: Zach York > Labels: patch > Fix For: 2.0.0, 1.4.0 > > Attachments: hbase-17437-branch-1.2.patch, > HBASE-17437.master.001.patch, HBASE-17437.master.002.patch, > HBASE-17437.master.003.patch, HBASE-17437.master.004.patch, > hbase-17437-master.patch > > > Currently, the WAL and the StoreFiles need to be on the same FileSystem. Some > FileSystems (such as Amazon S3) don’t support append or consistent writes. > These two properties are imperative for the WAL in order to avoid loss of > writes. However, StoreFiles don’t necessarily need the same consistency > guarantees (since writes are cached locally and if writes fail, they can > always be replayed from the WAL). > > This JIRA aims to allow users to configure a log directory (for WALs) that is > outside of the root directory or even in a different FileSystem. The default > value will still put the log directory under the root directory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17280) Add mechanism to control hbase cleaner behavior
[ https://issues.apache.org/jira/browse/HBASE-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843621#comment-15843621 ] Ajay Jadhav commented on HBASE-17280: - rb link- https://reviews.apache.org/r/56044/ > Add mechanism to control hbase cleaner behavior > --- > > Key: HBASE-17280 > URL: https://issues.apache.org/jira/browse/HBASE-17280 > Project: HBase > Issue Type: Improvement > Components: Client, hbase, shell >Affects Versions: 2.0.0, 1.2.0 >Reporter: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0, 1.2.0 > > Attachments: HBASE-17280.branch-1.2.patch, > HBASE-17280.branch-2.0.patch, HBASE-17280.master.003.patch, > HBASE-17280.v1-branch-1.2.patch, HBASE-17280.v2-branch-1.2.patch, > HBASE-17280.v2-branch-2.patch > > > Cleaner is used to get rid of archived HFiles and old WALs in HBase. > In the case of heavy workload, cleaner can affect query performance by > creating a lot of connections to perform costly reads/ writes against > underlying filesystem. > This patch allows the user to control HBase cleaner behavior by providing > shell commands to enable/ disable and manually run it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17563) Foreach and switch in RootDocProcessor and StabilityOptions
[
https://issues.apache.org/jira/browse/HBASE-17563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843617#comment-15843617
]
Hadoop QA commented on HBASE-17563:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
3s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 7s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
7s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
13s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 7s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
8s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 7s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 7s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
6s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
26m 7s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 22s
{color} | {color:red} hbase-annotations generated 1 new + 0 unchanged - 0 fixed
= 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 7s
{color} | {color:green} hbase-annotations in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 31m 35s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-annotations |
| | Switch statement found in
org.apache.hadoop.hbase.classification.tools.StabilityOptions.validOptions(String[][],
DocErrorReporter) where default case is missing At
StabilityOptions.java:DocErrorReporter) where default case is missing At
StabilityOptions.java:[lines 45-53] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12849763/HBASE-17563.master.001.patch
|
| JIRA Issue | HBASE-17563 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux b4bb474706d1 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24
10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / ad8e6c8 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/5486/artifact/patchprocess/new-findbugs-hbase-annotations.html
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/5486/testReport/ |
| modules | C: hbase-annotations U: hbase-annotation
[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843587#comment-15843587 ] Xiaobing Zhou commented on HBASE-17465: --- Thank you [~enis] for reviews. # HBaseRpcController extends google::protobuf::RpcController # We need in SingleRequestCallerBuilder, AsyncRpcRetryingCallerFactory and AsyncSingleRequestRpcRetryingCaller to make generic Callable, i.e. hase::Callable. We will see how to bridge this with RawAsyncTableImpl in follow-up work. # conn_->get_rpc_controller_factory()->NewController(); actually instantiate HBaseRpcController by contracting with generic Connection. For your other comments, I will cover them in refactoring or follow-up work. I will focus on adding unit tests in upcoming patches. > [C++] implement request retry mechanism over RPC > > > Key: HBASE-17465 > URL: https://issues.apache.org/jira/browse/HBASE-17465 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-17465-HBASE-14850.000.patch, > HBASE-17465-HBASE-14850.001.patch, HBASE-17465-HBASE-14850.002.patch, > HBASE-17465-HBASE-14850.003.patch, HBASE-17465-HBASE-14850.004.patch, > HBASE-17465-HBASE-14850.005.patch > > > HBASE-17051 implemented RPC layer. Requests retries will make system > reliable. This JIRA proposes adding it, which corresponds to similar > implementation in SingleRequestCallerBuilder (or BatchCallerBuilder, > ScanSingleRegionCallerBuilder, SmallScanCallerBuilder, etc.) and > AsyncSingleRequestRpcRetryingCaller. As a bonus, retry should be more > generic, decoupled with HRegionLocation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HBASE-17465) [C++] implement request retry mechanism over RPC
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843587#comment-15843587 ] Xiaobing Zhou edited comment on HBASE-17465 at 1/27/17 10:28 PM: - Thank you [~enis] for reviews. # HBaseRpcController extends google::protobuf::RpcController # We need in SingleRequestCallerBuilder, AsyncRpcRetryingCallerFactory and AsyncSingleRequestRpcRetryingCaller to make generic Callable, i.e. hase::Callable. We will see how to bridge this with RawAsyncTableImpl in follow-up work. # conn_ -> get_rpc_controller_factory()->NewController(); actually instantiate HBaseRpcController by contracting with generic Connection. For your other comments, I will cover them in refactoring or follow-up work. I will focus on adding unit tests in upcoming patches. was (Author: xiaobingo): Thank you [~enis] for reviews. # HBaseRpcController extends google::protobuf::RpcController # We need in SingleRequestCallerBuilder, AsyncRpcRetryingCallerFactory and AsyncSingleRequestRpcRetryingCaller to make generic Callable, i.e. hase::Callable. We will see how to bridge this with RawAsyncTableImpl in follow-up work. # conn_->get_rpc_controller_factory()->NewController(); actually instantiate HBaseRpcController by contracting with generic Connection. For your other comments, I will cover them in refactoring or follow-up work. I will focus on adding unit tests in upcoming patches. > [C++] implement request retry mechanism over RPC > > > Key: HBASE-17465 > URL: https://issues.apache.org/jira/browse/HBASE-17465 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-17465-HBASE-14850.000.patch, > HBASE-17465-HBASE-14850.001.patch, HBASE-17465-HBASE-14850.002.patch, > HBASE-17465-HBASE-14850.003.patch, HBASE-17465-HBASE-14850.004.patch, > HBASE-17465-HBASE-14850.005.patch > > > HBASE-17051 implemented RPC layer. Requests retries will make system > reliable. This JIRA proposes adding it, which corresponds to similar > implementation in SingleRequestCallerBuilder (or BatchCallerBuilder, > ScanSingleRegionCallerBuilder, SmallScanCallerBuilder, etc.) and > AsyncSingleRequestRpcRetryingCaller. As a bonus, retry should be more > generic, decoupled with HRegionLocation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HBASE-17465) [C++] implement request retry mechanism over RPC
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843587#comment-15843587 ] Xiaobing Zhou edited comment on HBASE-17465 at 1/27/17 10:28 PM: - Thank you [~enis] for reviews. # HBaseRpcController extends google::protobuf::RpcController # We need in SingleRequestCallerBuilder, AsyncRpcRetryingCallerFactory and AsyncSingleRequestRpcRetryingCaller to make generic Callable, i.e. hase::Callable. We will see how to bridge this with RawAsyncTableImpl in follow-up work. # conn_-> get_rpc_controller_factory()->NewController(); actually instantiate HBaseRpcController by contracting with generic Connection. For your other comments, I will cover them in refactoring or follow-up work. I will focus on adding unit tests in upcoming patches. was (Author: xiaobingo): Thank you [~enis] for reviews. # HBaseRpcController extends google::protobuf::RpcController # We need in SingleRequestCallerBuilder, AsyncRpcRetryingCallerFactory and AsyncSingleRequestRpcRetryingCaller to make generic Callable, i.e. hase::Callable. We will see how to bridge this with RawAsyncTableImpl in follow-up work. # conn_ -> get_rpc_controller_factory()->NewController(); actually instantiate HBaseRpcController by contracting with generic Connection. For your other comments, I will cover them in refactoring or follow-up work. I will focus on adding unit tests in upcoming patches. > [C++] implement request retry mechanism over RPC > > > Key: HBASE-17465 > URL: https://issues.apache.org/jira/browse/HBASE-17465 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-17465-HBASE-14850.000.patch, > HBASE-17465-HBASE-14850.001.patch, HBASE-17465-HBASE-14850.002.patch, > HBASE-17465-HBASE-14850.003.patch, HBASE-17465-HBASE-14850.004.patch, > HBASE-17465-HBASE-14850.005.patch > > > HBASE-17051 implemented RPC layer. Requests retries will make system > reliable. This JIRA proposes adding it, which corresponds to similar > implementation in SingleRequestCallerBuilder (or BatchCallerBuilder, > ScanSingleRegionCallerBuilder, SmallScanCallerBuilder, etc.) and > AsyncSingleRequestRpcRetryingCaller. As a bonus, retry should be more > generic, decoupled with HRegionLocation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17563) Foreach and switch in RootDocProcessor and StabilityOptions
[ https://issues.apache.org/jira/browse/HBASE-17563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-17563: -- Status: Patch Available (was: In Progress) > Foreach and switch in RootDocProcessor and StabilityOptions > --- > > Key: HBASE-17563 > URL: https://issues.apache.org/jira/browse/HBASE-17563 > Project: HBase > Issue Type: Improvement >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-17563.master.001.patch > > > To make the code in *RootDocProcessor* and *StabilityOptions* more readable > change the existing for-loops and if-statements to foreach-loops and > switch-statements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17563) Foreach and switch in RootDocProcessor and StabilityOptions
[ https://issues.apache.org/jira/browse/HBASE-17563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-17563: -- Attachment: HBASE-17563.master.001.patch > Foreach and switch in RootDocProcessor and StabilityOptions > --- > > Key: HBASE-17563 > URL: https://issues.apache.org/jira/browse/HBASE-17563 > Project: HBase > Issue Type: Improvement >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-17563.master.001.patch > > > To make the code in *RootDocProcessor* and *StabilityOptions* more readable > change the existing for-loops and if-statements to foreach-loops and > switch-statements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (HBASE-17563) Foreach and switch in RootDocProcessor and StabilityOptions
[ https://issues.apache.org/jira/browse/HBASE-17563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-17563 started by Jan Hentschel. - > Foreach and switch in RootDocProcessor and StabilityOptions > --- > > Key: HBASE-17563 > URL: https://issues.apache.org/jira/browse/HBASE-17563 > Project: HBase > Issue Type: Improvement >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > > To make the code in *RootDocProcessor* and *StabilityOptions* more readable > change the existing for-loops and if-statements to foreach-loops and > switch-statements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17465) [C++] implement request retry mechanism over RPC
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Zhou updated HBASE-17465: -- Attachment: (was: HBASE-17465-HBASE-14850.005.patch) > [C++] implement request retry mechanism over RPC > > > Key: HBASE-17465 > URL: https://issues.apache.org/jira/browse/HBASE-17465 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-17465-HBASE-14850.000.patch, > HBASE-17465-HBASE-14850.001.patch, HBASE-17465-HBASE-14850.002.patch, > HBASE-17465-HBASE-14850.003.patch, HBASE-17465-HBASE-14850.004.patch > > > HBASE-17051 implemented RPC layer. Requests retries will make system > reliable. This JIRA proposes adding it, which corresponds to similar > implementation in SingleRequestCallerBuilder (or BatchCallerBuilder, > ScanSingleRegionCallerBuilder, SmallScanCallerBuilder, etc.) and > AsyncSingleRequestRpcRetryingCaller. As a bonus, retry should be more > generic, decoupled with HRegionLocation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17465) [C++] implement request retry mechanism over RPC
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Zhou updated HBASE-17465: -- Attachment: HBASE-17465-HBASE-14850.005.patch > [C++] implement request retry mechanism over RPC > > > Key: HBASE-17465 > URL: https://issues.apache.org/jira/browse/HBASE-17465 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-17465-HBASE-14850.000.patch, > HBASE-17465-HBASE-14850.001.patch, HBASE-17465-HBASE-14850.002.patch, > HBASE-17465-HBASE-14850.003.patch, HBASE-17465-HBASE-14850.004.patch, > HBASE-17465-HBASE-14850.005.patch > > > HBASE-17051 implemented RPC layer. Requests retries will make system > reliable. This JIRA proposes adding it, which corresponds to similar > implementation in SingleRequestCallerBuilder (or BatchCallerBuilder, > ScanSingleRegionCallerBuilder, SmallScanCallerBuilder, etc.) and > AsyncSingleRequestRpcRetryingCaller. As a bonus, retry should be more > generic, decoupled with HRegionLocation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-17563) Foreach and switch in RootDocProcessor and StabilityOptions
Jan Hentschel created HBASE-17563: - Summary: Foreach and switch in RootDocProcessor and StabilityOptions Key: HBASE-17563 URL: https://issues.apache.org/jira/browse/HBASE-17563 Project: HBase Issue Type: Improvement Reporter: Jan Hentschel Assignee: Jan Hentschel Priority: Trivial To make the code in *RootDocProcessor* and *StabilityOptions* more readable change the existing for-loops and if-statements to foreach-loops and switch-statements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843576#comment-15843576 ] Xiaobing Zhou commented on HBASE-17465: --- Posted patch v5. # added more exception related implementation in exception.h # implemented AsyncSingleRequestRpcRetryingCaller::Call(const HRegionLocation& loc) with retries. > [C++] implement request retry mechanism over RPC > > > Key: HBASE-17465 > URL: https://issues.apache.org/jira/browse/HBASE-17465 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-17465-HBASE-14850.000.patch, > HBASE-17465-HBASE-14850.001.patch, HBASE-17465-HBASE-14850.002.patch, > HBASE-17465-HBASE-14850.003.patch, HBASE-17465-HBASE-14850.004.patch, > HBASE-17465-HBASE-14850.005.patch > > > HBASE-17051 implemented RPC layer. Requests retries will make system > reliable. This JIRA proposes adding it, which corresponds to similar > implementation in SingleRequestCallerBuilder (or BatchCallerBuilder, > ScanSingleRegionCallerBuilder, SmallScanCallerBuilder, etc.) and > AsyncSingleRequestRpcRetryingCaller. As a bonus, retry should be more > generic, decoupled with HRegionLocation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17465) [C++] implement request retry mechanism over RPC
[ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Zhou updated HBASE-17465: -- Attachment: HBASE-17465-HBASE-14850.005.patch > [C++] implement request retry mechanism over RPC > > > Key: HBASE-17465 > URL: https://issues.apache.org/jira/browse/HBASE-17465 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-17465-HBASE-14850.000.patch, > HBASE-17465-HBASE-14850.001.patch, HBASE-17465-HBASE-14850.002.patch, > HBASE-17465-HBASE-14850.003.patch, HBASE-17465-HBASE-14850.004.patch, > HBASE-17465-HBASE-14850.005.patch > > > HBASE-17051 implemented RPC layer. Requests retries will make system > reliable. This JIRA proposes adding it, which corresponds to similar > implementation in SingleRequestCallerBuilder (or BatchCallerBuilder, > ScanSingleRegionCallerBuilder, SmallScanCallerBuilder, etc.) and > AsyncSingleRequestRpcRetryingCaller. As a bonus, retry should be more > generic, decoupled with HRegionLocation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17280) Add mechanism to control hbase cleaner behavior
[ https://issues.apache.org/jira/browse/HBASE-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843525#comment-15843525 ] Ajay Jadhav commented on HBASE-17280: - I'll put the patch on reviews.apache.org after resolving above comments. > Add mechanism to control hbase cleaner behavior > --- > > Key: HBASE-17280 > URL: https://issues.apache.org/jira/browse/HBASE-17280 > Project: HBase > Issue Type: Improvement > Components: Client, hbase, shell >Affects Versions: 2.0.0, 1.2.0 >Reporter: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0, 1.2.0 > > Attachments: HBASE-17280.branch-1.2.patch, > HBASE-17280.branch-2.0.patch, HBASE-17280.master.003.patch, > HBASE-17280.v1-branch-1.2.patch, HBASE-17280.v2-branch-1.2.patch, > HBASE-17280.v2-branch-2.patch > > > Cleaner is used to get rid of archived HFiles and old WALs in HBase. > In the case of heavy workload, cleaner can affect query performance by > creating a lot of connections to perform costly reads/ writes against > underlying filesystem. > This patch allows the user to control HBase cleaner behavior by providing > shell commands to enable/ disable and manually run it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17280) Add mechanism to control hbase cleaner behavior
[
https://issues.apache.org/jira/browse/HBASE-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843517#comment-15843517
]
Ted Yu commented on HBASE-17280:
+ * @param enable if true enables the cleaner
+ * @return the previous state
+ * @throws MasterNotRunningException
+ */
+ public boolean setCleanerChoreRunning(final boolean on) throws IOException;
Correct name of parameter in javadoc - on, not enable.
+ .setCleanerChoreRunning(getRpcController(),
RequestConverter.buildSetCleanerChoreRunningRequest(on))
Indentation is two spaces per indent. Line length should be no longer than 100
+ public static RunCleanerChoreRequest buildCleanerChoreRequest() {
+return CLEANERCHORE_REQUEST;
The request is to run cleaner. Name the method buildRunCleanerChoreRequest
Name cleaner_enabled.rb cleaner_chore_enabled.rb
Name cleaner_run.rb cleaner_chore_run.rb
Name cleaner_switch.rb cleaner_chore_switch.rb
> Add mechanism to control hbase cleaner behavior
> ---
>
> Key: HBASE-17280
> URL: https://issues.apache.org/jira/browse/HBASE-17280
> Project: HBase
> Issue Type: Improvement
> Components: Client, hbase, shell
>Affects Versions: 2.0.0, 1.2.0
>Reporter: Ajay Jadhav
>Priority: Minor
> Fix For: 2.0.0, 1.2.0
>
> Attachments: HBASE-17280.branch-1.2.patch,
> HBASE-17280.branch-2.0.patch, HBASE-17280.master.003.patch,
> HBASE-17280.v1-branch-1.2.patch, HBASE-17280.v2-branch-1.2.patch,
> HBASE-17280.v2-branch-2.patch
>
>
> Cleaner is used to get rid of archived HFiles and old WALs in HBase.
> In the case of heavy workload, cleaner can affect query performance by
> creating a lot of connections to perform costly reads/ writes against
> underlying filesystem.
> This patch allows the user to control HBase cleaner behavior by providing
> shell commands to enable/ disable and manually run it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HBASE-17280) Add mechanism to control hbase cleaner behavior
[
https://issues.apache.org/jira/browse/HBASE-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843517#comment-15843517
]
Ted Yu edited comment on HBASE-17280 at 1/27/17 9:30 PM:
-
{code}
+ * @param enable if true enables the cleaner
+ * @return the previous state
+ * @throws MasterNotRunningException
+ */
+ public boolean setCleanerChoreRunning(final boolean on) throws IOException;
{code}
Correct name of parameter in javadoc - on, not enable.
{code}
+ .setCleanerChoreRunning(getRpcController(),
RequestConverter.buildSetCleanerChoreRunningRequest(on))
{code}
Indentation is two spaces per indent. Line length should be no longer than 100
{code}
+ public static RunCleanerChoreRequest buildCleanerChoreRequest() {
+return CLEANERCHORE_REQUEST;
{code}
The request is to run cleaner. Name the method buildRunCleanerChoreRequest
Name cleaner_enabled.rb cleaner_chore_enabled.rb
Name cleaner_run.rb cleaner_chore_run.rb
Name cleaner_switch.rb cleaner_chore_switch.rb
was (Author: yuzhih...@gmail.com):
+ * @param enable if true enables the cleaner
+ * @return the previous state
+ * @throws MasterNotRunningException
+ */
+ public boolean setCleanerChoreRunning(final boolean on) throws IOException;
Correct name of parameter in javadoc - on, not enable.
+ .setCleanerChoreRunning(getRpcController(),
RequestConverter.buildSetCleanerChoreRunningRequest(on))
Indentation is two spaces per indent. Line length should be no longer than 100
+ public static RunCleanerChoreRequest buildCleanerChoreRequest() {
+return CLEANERCHORE_REQUEST;
The request is to run cleaner. Name the method buildRunCleanerChoreRequest
Name cleaner_enabled.rb cleaner_chore_enabled.rb
Name cleaner_run.rb cleaner_chore_run.rb
Name cleaner_switch.rb cleaner_chore_switch.rb
> Add mechanism to control hbase cleaner behavior
> ---
>
> Key: HBASE-17280
> URL: https://issues.apache.org/jira/browse/HBASE-17280
> Project: HBase
> Issue Type: Improvement
> Components: Client, hbase, shell
>Affects Versions: 2.0.0, 1.2.0
>Reporter: Ajay Jadhav
>Priority: Minor
> Fix For: 2.0.0, 1.2.0
>
> Attachments: HBASE-17280.branch-1.2.patch,
> HBASE-17280.branch-2.0.patch, HBASE-17280.master.003.patch,
> HBASE-17280.v1-branch-1.2.patch, HBASE-17280.v2-branch-1.2.patch,
> HBASE-17280.v2-branch-2.patch
>
>
> Cleaner is used to get rid of archived HFiles and old WALs in HBase.
> In the case of heavy workload, cleaner can affect query performance by
> creating a lot of connections to perform costly reads/ writes against
> underlying filesystem.
> This patch allows the user to control HBase cleaner behavior by providing
> shell commands to enable/ disable and manually run it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17280) Add mechanism to control hbase cleaner behavior
[ https://issues.apache.org/jira/browse/HBASE-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843511#comment-15843511 ] Ted Yu commented on HBASE-17280: Can you put the patch on reviews.apache.org ? > Add mechanism to control hbase cleaner behavior > --- > > Key: HBASE-17280 > URL: https://issues.apache.org/jira/browse/HBASE-17280 > Project: HBase > Issue Type: Improvement > Components: Client, hbase, shell >Affects Versions: 2.0.0, 1.2.0 >Reporter: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0, 1.2.0 > > Attachments: HBASE-17280.branch-1.2.patch, > HBASE-17280.branch-2.0.patch, HBASE-17280.master.003.patch, > HBASE-17280.v1-branch-1.2.patch, HBASE-17280.v2-branch-1.2.patch, > HBASE-17280.v2-branch-2.patch > > > Cleaner is used to get rid of archived HFiles and old WALs in HBase. > In the case of heavy workload, cleaner can affect query performance by > creating a lot of connections to perform costly reads/ writes against > underlying filesystem. > This patch allows the user to control HBase cleaner behavior by providing > shell commands to enable/ disable and manually run it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17557) HRegionServer#reportRegionSizesForQuotas() should respond to UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HBASE-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843510#comment-15843510
]
Hadoop QA commented on HBASE-17557:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 2s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
49s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
33s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s
{color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
37s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m 56s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.4.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 51s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 47s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 45s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 41s
{color} | {color:red} The patch causes 306 errors with Hadoop v2.5.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 79m 5s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 119m 17s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12849730/17557.HBASE-16961.v2.txt
|
| JIRA Issue | HBASE-17557 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 1c31ffc4d69b 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/
[jira] [Updated] (HBASE-17557) HRegionServer#reportRegionSizesForQuotas() should respond to UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HBASE-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17557:
---
Attachment: 17557.HBASE-16961.v3.txt
Patch v3 uses back off instead of using hard coded duration.
> HRegionServer#reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException
> --
>
> Key: HBASE-17557
> URL: https://issues.apache.org/jira/browse/HBASE-17557
> Project: HBase
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 17557.HBASE-16961.v2.txt, 17557.HBASE-16961.v3.txt
>
>
> When master doesn't support quota, you would see the following repeatedly in
> region server log:
> {code}
> 2017-01-27 17:24:27,389 DEBUG
> [cn011.x.com,16020,1485468203653_ChoreService_1] regionserver.HRegionServer:
> Failed to report region sizes to Master. This will be retried.
> org.apache.hadoop.hbase.DoNotRetryIOException: /23:16000 is unable to read
> call parameter from client 21; java.lang.UnsupportedOperationException:
> ReportRegionSpaceUse
> at sun.reflect.GeneratedConstructorAccessor8.newInstance(Unknown
> Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)
> at
> org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:95)
> at
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:334)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1211)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.reportRegionSizesToMaster(FileSystemUtilizationChore.java:170)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.chore(FileSystemUtilizationChore.java:129)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:185)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by:
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.DoNotRetryIOException):
> /23:16000 is unable to read call parameter from client 21; java.lang.
> UnsupportedOperationException: ReportRegionSpaceUse
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1225)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:213)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:287)
> at
> org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.reportRegionSpaceUse(RegionServerStatusProtos.java:10919)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1209)
> {code}
> HRegionServer.reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException and stop retrying.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HBASE-14477) Compaction improvements: Date tiered compaction policy
[
https://issues.apache.org/jira/browse/HBASE-14477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843489#comment-15843489
]
Vladimir Rodionov edited comment on HBASE-14477 at 1/27/17 9:03 PM:
Sure, [~enis]. Duplicate of HBASE-15181
was (Author: vrodionov):
Duplicate of HBASE-15181
> Compaction improvements: Date tiered compaction policy
> --
>
> Key: HBASE-14477
> URL: https://issues.apache.org/jira/browse/HBASE-14477
> Project: HBase
> Issue Type: New Feature
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
>
> For immutable and mostly immutable data the current SizeTiered-based
> compaction policy is not efficient.
> # There is no need to compact all files into one, because, data is (mostly)
> immutable and we do not need to collect garbage. (performance reason will be
> discussed later)
> # Size-tiered compaction is not suitable for applications where most recent
> data is most important and prevents efficient caching of this data.
> The idea is pretty similar to DateTieredCompaction in Cassandra:
> http://www.datastax.com/dev/blog/datetieredcompactionstrategy
> http://www.datastax.com/dev/blog/dtcs-notes-from-the-field
> From Cassandra own blog:
> {quote}
> Since DTCS can be used with any table, it is important to know when it is a
> good idea, and when it is not. I’ll try to explain the spectrum and
> trade-offs here:
> 1. Perfect Fit: Time Series Fact Data, Deletes by Default TTL: When you
> ingest fact data that is ordered in time, with no deletes or overwrites. This
> is the standard “time series” use case.
> 2. OK Fit: Time-Ordered, with limited updates across whole data set, or only
> updates to recent data: When you ingest data that is (mostly) ordered in
> time, but revise or delete a very small proportion of the overall data across
> the whole timeline.
> 3. Not a Good Fit: many partial row updates or deletions over time: When you
> need to partially revise or delete fields for rows that you read together.
> Also, when you revise or delete rows within clustered reads.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (HBASE-14477) Compaction improvements: Date tiered compaction policy
[
https://issues.apache.org/jira/browse/HBASE-14477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Rodionov resolved HBASE-14477.
---
Resolution: Duplicate
Duplicate of HBASE-15181
> Compaction improvements: Date tiered compaction policy
> --
>
> Key: HBASE-14477
> URL: https://issues.apache.org/jira/browse/HBASE-14477
> Project: HBase
> Issue Type: New Feature
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
>
> For immutable and mostly immutable data the current SizeTiered-based
> compaction policy is not efficient.
> # There is no need to compact all files into one, because, data is (mostly)
> immutable and we do not need to collect garbage. (performance reason will be
> discussed later)
> # Size-tiered compaction is not suitable for applications where most recent
> data is most important and prevents efficient caching of this data.
> The idea is pretty similar to DateTieredCompaction in Cassandra:
> http://www.datastax.com/dev/blog/datetieredcompactionstrategy
> http://www.datastax.com/dev/blog/dtcs-notes-from-the-field
> From Cassandra own blog:
> {quote}
> Since DTCS can be used with any table, it is important to know when it is a
> good idea, and when it is not. I’ll try to explain the spectrum and
> trade-offs here:
> 1. Perfect Fit: Time Series Fact Data, Deletes by Default TTL: When you
> ingest fact data that is ordered in time, with no deletes or overwrites. This
> is the standard “time series” use case.
> 2. OK Fit: Time-Ordered, with limited updates across whole data set, or only
> updates to recent data: When you ingest data that is (mostly) ordered in
> time, but revise or delete a very small proportion of the overall data across
> the whole timeline.
> 3. Not a Good Fit: many partial row updates or deletions over time: When you
> need to partially revise or delete fields for rows that you read together.
> Also, when you revise or delete rows within clustered reads.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17280) Add mechanism to control hbase cleaner behavior
[ https://issues.apache.org/jira/browse/HBASE-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Jadhav updated HBASE-17280: Status: Patch Available (was: Open) > Add mechanism to control hbase cleaner behavior > --- > > Key: HBASE-17280 > URL: https://issues.apache.org/jira/browse/HBASE-17280 > Project: HBase > Issue Type: Improvement > Components: Client, hbase, shell >Affects Versions: 1.2.0, 2.0.0 >Reporter: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0, 1.2.0 > > Attachments: HBASE-17280.branch-1.2.patch, > HBASE-17280.branch-2.0.patch, HBASE-17280.master.003.patch, > HBASE-17280.v1-branch-1.2.patch, HBASE-17280.v2-branch-1.2.patch, > HBASE-17280.v2-branch-2.patch > > > Cleaner is used to get rid of archived HFiles and old WALs in HBase. > In the case of heavy workload, cleaner can affect query performance by > creating a lot of connections to perform costly reads/ writes against > underlying filesystem. > This patch allows the user to control HBase cleaner behavior by providing > shell commands to enable/ disable and manually run it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17280) Add mechanism to control hbase cleaner behavior
[ https://issues.apache.org/jira/browse/HBASE-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Jadhav updated HBASE-17280: Status: Open (was: Patch Available) > Add mechanism to control hbase cleaner behavior > --- > > Key: HBASE-17280 > URL: https://issues.apache.org/jira/browse/HBASE-17280 > Project: HBase > Issue Type: Improvement > Components: Client, hbase, shell >Affects Versions: 1.2.0, 2.0.0 >Reporter: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0, 1.2.0 > > Attachments: HBASE-17280.branch-1.2.patch, > HBASE-17280.branch-2.0.patch, HBASE-17280.master.003.patch, > HBASE-17280.v1-branch-1.2.patch, HBASE-17280.v2-branch-1.2.patch, > HBASE-17280.v2-branch-2.patch > > > Cleaner is used to get rid of archived HFiles and old WALs in HBase. > In the case of heavy workload, cleaner can affect query performance by > creating a lot of connections to perform costly reads/ writes against > underlying filesystem. > This patch allows the user to control HBase cleaner behavior by providing > shell commands to enable/ disable and manually run it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17280) Add mechanism to control hbase cleaner behavior
[ https://issues.apache.org/jira/browse/HBASE-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Jadhav updated HBASE-17280: Attachment: HBASE-17280.master.003.patch > Add mechanism to control hbase cleaner behavior > --- > > Key: HBASE-17280 > URL: https://issues.apache.org/jira/browse/HBASE-17280 > Project: HBase > Issue Type: Improvement > Components: Client, hbase, shell >Affects Versions: 2.0.0, 1.2.0 >Reporter: Ajay Jadhav >Priority: Minor > Fix For: 2.0.0, 1.2.0 > > Attachments: HBASE-17280.branch-1.2.patch, > HBASE-17280.branch-2.0.patch, HBASE-17280.master.003.patch, > HBASE-17280.v1-branch-1.2.patch, HBASE-17280.v2-branch-1.2.patch, > HBASE-17280.v2-branch-2.patch > > > Cleaner is used to get rid of archived HFiles and old WALs in HBase. > In the case of heavy workload, cleaner can affect query performance by > creating a lot of connections to perform costly reads/ writes against > underlying filesystem. > This patch allows the user to control HBase cleaner behavior by providing > shell commands to enable/ disable and manually run it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17556) The client will not invalidate stale region caches
[ https://issues.apache.org/jira/browse/HBASE-17556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843441#comment-15843441 ] Marcin Januszkiewicz commented on HBASE-17556: -- We are using the cloudera release 1.0.0-cdh5.5.2. Could you point me to some of the JIRAs for these fixes? > The client will not invalidate stale region caches > -- > > Key: HBASE-17556 > URL: https://issues.apache.org/jira/browse/HBASE-17556 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.0.0, 2.0.0, 0.98.24 >Reporter: Marcin Januszkiewicz >Priority: Critical > > We noticed in our application, that sometimes when we interact with a table > an operation will fail with an exception, an all operations that happen on > the same region will also fail until the application is restarted. > It seems that when a merge or split happens on a region that is already in > the clients cache, and the client is configured to retry operations, then > there is no way for the client to detect this. In > RpcRetryingCaller#callWithRetries if a call fails with > RegionNotServingException then the cache will be cleared only if the retry > parameter is equal to 1. This means the call will fail but the following > calls will succeed. > RpcRetryingCaller#callWithoutRetries contains the comment "It would be nice > to clear the location cache here". Additionally, the stale cache will cause > this call to fail, even though the data is available. > See also HBASE-12534 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17271) hbase-thrift QA tests only run one test
[ https://issues.apache.org/jira/browse/HBASE-17271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843405#comment-15843405 ] Hudson commented on HBASE-17271: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2396 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2396/]) HBASE-17271 Fixed test runs in hbase-thrift (tedyu: rev ad8e6c831230b1d0389f413e1531e7f9e9f3f4d7) * (edit) hbase-thrift/pom.xml > hbase-thrift QA tests only run one test > --- > > Key: HBASE-17271 > URL: https://issues.apache.org/jira/browse/HBASE-17271 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Jan Hentschel > Labels: build, thrift > Fix For: 2.0.0 > > Attachments: HBASE-17271.master.001.patch > > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/4822/artifact/patchprocess/patch-unit-hbase-thrift.txt > , it is pretty clear that only one test was run - TestCallQueue > Even though the patch contains modified TestThriftHBaseServiceHandler. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-17562) Remove documentation for coprocessor execution times after HBASE-14205
Enis Soztutar created HBASE-17562: - Summary: Remove documentation for coprocessor execution times after HBASE-14205 Key: HBASE-17562 URL: https://issues.apache.org/jira/browse/HBASE-17562 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Thanks, [~manniche] for reporting. Opened up a subtask. Feel free to pick it up if you want to patch it yourself. Otherwise, I can do a quick patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17558) ZK dumping jsp should escape html
[
https://issues.apache.org/jira/browse/HBASE-17558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-17558:
Description:
Right now the ZK status page in the master dumps data from ZK using ZKUtil
without doing any processing to e.g. escape HTML entities.
ie.:
{code}
ZooKeeper Dump
<%= ZKUtil.dump(watcher).trim() %>
{code}
current url:
https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/zk.jsp#L83
was:
Right now the ZK status page in the master dumps data from ZK using ZKUtil
without doing any processing to e.g. escape HTML entities.
ie.:
{codE}
ZooKeeper Dump
<%= ZKUtil.dump(watcher).trim() %>
{code}
current url:
https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/zk.jsp#L83
> ZK dumping jsp should escape html
> --
>
> Key: HBASE-17558
> URL: https://issues.apache.org/jira/browse/HBASE-17558
> Project: HBase
> Issue Type: Bug
> Components: security, UI
>Reporter: Sean Busbey
>Priority: Minor
>
> Right now the ZK status page in the master dumps data from ZK using ZKUtil
> without doing any processing to e.g. escape HTML entities.
> ie.:
> {code}
>
>
>
> ZooKeeper Dump
>
>
>
>
> <%= ZKUtil.dump(watcher).trim() %>
>
>
>
> {code}
> current url:
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/zk.jsp#L83
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17555) Change calls to deprecated getHBaseAdmin to getAdmin
[ https://issues.apache.org/jira/browse/HBASE-17555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843384#comment-15843384 ] Jan Hentschel commented on HBASE-17555: --- The Findbugs warning seems to be unrelated to the actual change. > Change calls to deprecated getHBaseAdmin to getAdmin > > > Key: HBASE-17555 > URL: https://issues.apache.org/jira/browse/HBASE-17555 > Project: HBase > Issue Type: Improvement >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Attachments: HBASE-17555.master.001.patch, > HBASE-17555.master.002.patch > > > *HBaseTestingUtil.getHBaseAdmin* is deprecated and was replaced with > *getAdmin*. Change the calls to *getHBaseAdmin* to *getAdmin* where possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-17561) table status page should escape table name
Sean Busbey created HBASE-17561:
---
Summary: table status page should escape table name
Key: HBASE-17561
URL: https://issues.apache.org/jira/browse/HBASE-17561
Project: HBase
Issue Type: Bug
Components: master, UI
Reporter: Sean Busbey
Assignee: Sean Busbey
We write out table names to an html document without escaping html entities
e.g. in this case it even comes directly from the request
{code}
<% if ( !readOnly && action != null ) { %>
HBase Master: <%= master.getServerName() %>
<% } else { %>
Table: <%= fqtn %>
<% } %>
{code}
in
https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-17560) HMaster redirect should sanity check user input
Sean Busbey created HBASE-17560:
---
Summary: HMaster redirect should sanity check user input
Key: HBASE-17560
URL: https://issues.apache.org/jira/browse/HBASE-17560
Project: HBase
Issue Type: Bug
Components: master, security, UI
Reporter: Sean Busbey
We should do some sanity checking on the user provided data before we blindly
pass it to a redirect.
i.e.
{code}
public static class RedirectServlet extends HttpServlet {
private static final long serialVersionUID = 2894774810058302472L;
private static int regionServerInfoPort;
@Override
public void doGet(HttpServletRequest request,
HttpServletResponse response) throws ServletException, IOException {
String redirectUrl = request.getScheme() + "://"
+ request.getServerName() + ":" + regionServerInfoPort
+ request.getRequestURI();
response.sendRedirect(redirectUrl);
}
}
{code}
e.g.
* Are we reidrecting to a server that is ours?
* Did we validate the path/query string?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17559) Verify service threads are using the UncaughtExceptionHandler
[ https://issues.apache.org/jira/browse/HBASE-17559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843365#comment-15843365 ] Josh Elser commented on HBASE-17559: Tagged branch-1 and master tentatively. Also assigned it to myself, but am happy if someone wants to do this before I get to it. > Verify service threads are using the UncaughtExceptionHandler > - > > Key: HBASE-17559 > URL: https://issues.apache.org/jira/browse/HBASE-17559 > Project: HBase > Issue Type: Task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0, 1.4.0 > > > (Context: > https://lists.apache.org/thread.html/47c9a0f7193eaf0546ce241cfe093885366f5177ed867e18b45d77b9@%3Cdev.hbase.apache.org%3E) > We should take a once-over on the threads we start in the RegionServer/Master > to make sure that they're using the UncaughtExceptionHandler to prevent the > case where the process keeps running but one of our threads has died. > Such a situation may result in operators not realizing that their HBase > instance is not actually running as expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-17559) Verify service threads are using the UncaughtExceptionHandler
Josh Elser created HBASE-17559: -- Summary: Verify service threads are using the UncaughtExceptionHandler Key: HBASE-17559 URL: https://issues.apache.org/jira/browse/HBASE-17559 Project: HBase Issue Type: Task Reporter: Josh Elser Assignee: Josh Elser Fix For: 2.0.0, 1.4.0 (Context: https://lists.apache.org/thread.html/47c9a0f7193eaf0546ce241cfe093885366f5177ed867e18b45d77b9@%3Cdev.hbase.apache.org%3E) We should take a once-over on the threads we start in the RegionServer/Master to make sure that they're using the UncaughtExceptionHandler to prevent the case where the process keeps running but one of our threads has died. Such a situation may result in operators not realizing that their HBase instance is not actually running as expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-17558) ZK dumping jsp should escape html
Sean Busbey created HBASE-17558:
---
Summary: ZK dumping jsp should escape html
Key: HBASE-17558
URL: https://issues.apache.org/jira/browse/HBASE-17558
Project: HBase
Issue Type: Bug
Components: security, UI
Reporter: Sean Busbey
Priority: Minor
Right now the ZK status page in the master dumps data from ZK using ZKUtil
without doing any processing to e.g. escape HTML entities.
ie.:
{codE}
ZooKeeper Dump
<%= ZKUtil.dump(watcher).trim() %>
{code}
current url:
https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/zk.jsp#L83
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15597) Clean up configuration keys used in hbase-spark module
[ https://issues.apache.org/jira/browse/HBASE-15597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843352#comment-15843352 ] Yi Liang commented on HBASE-15597: -- [~jerryhe] [~te...@apache.org] [~busbey], Any comments for this patch? Thanks > Clean up configuration keys used in hbase-spark module > -- > > Key: HBASE-15597 > URL: https://issues.apache.org/jira/browse/HBASE-15597 > Project: HBase > Issue Type: Bug > Components: spark >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Yi Liang >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-15597-v1.patch > > > This should be considered a blocker for backport to branch-1 since it will > impact our compatibility. > The constants we expose in configuration should all start with "hbase". Since > our configurations keys for the spark integration all relate to that system, > the prefix for all configuration keys (excluding those cases where we need to > do something special due to restrictions in how properties are handled by > e.g. spark) should be "hbase.spark". > Before publishing a public api labeled version of our spark integration we > should review all of our configuration keys to make sure they either conform > to the "hbase.spark" prefix or they have a comment documenting why they need > to be otherwise. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14477) Compaction improvements: Date tiered compaction policy
[
https://issues.apache.org/jira/browse/HBASE-14477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843341#comment-15843341
]
Enis Soztutar commented on HBASE-14477:
---
Should we close this as a duplicate of HBASE-15181?
> Compaction improvements: Date tiered compaction policy
> --
>
> Key: HBASE-14477
> URL: https://issues.apache.org/jira/browse/HBASE-14477
> Project: HBase
> Issue Type: New Feature
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
>
> For immutable and mostly immutable data the current SizeTiered-based
> compaction policy is not efficient.
> # There is no need to compact all files into one, because, data is (mostly)
> immutable and we do not need to collect garbage. (performance reason will be
> discussed later)
> # Size-tiered compaction is not suitable for applications where most recent
> data is most important and prevents efficient caching of this data.
> The idea is pretty similar to DateTieredCompaction in Cassandra:
> http://www.datastax.com/dev/blog/datetieredcompactionstrategy
> http://www.datastax.com/dev/blog/dtcs-notes-from-the-field
> From Cassandra own blog:
> {quote}
> Since DTCS can be used with any table, it is important to know when it is a
> good idea, and when it is not. I’ll try to explain the spectrum and
> trade-offs here:
> 1. Perfect Fit: Time Series Fact Data, Deletes by Default TTL: When you
> ingest fact data that is ordered in time, with no deletes or overwrites. This
> is the standard “time series” use case.
> 2. OK Fit: Time-Ordered, with limited updates across whole data set, or only
> updates to recent data: When you ingest data that is (mostly) ordered in
> time, but revise or delete a very small proportion of the overall data across
> the whole timeline.
> 3. Not a Good Fit: many partial row updates or deletions over time: When you
> need to partially revise or delete fields for rows that you read together.
> Also, when you revise or delete rows within clustered reads.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17556) The client will not invalidate stale region caches
[ https://issues.apache.org/jira/browse/HBASE-17556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843329#comment-15843329 ] Enis Soztutar commented on HBASE-17556: --- There has been several fixes in that area. Which exact version of the client are you using? > The client will not invalidate stale region caches > -- > > Key: HBASE-17556 > URL: https://issues.apache.org/jira/browse/HBASE-17556 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.0.0, 2.0.0, 0.98.24 >Reporter: Marcin Januszkiewicz >Priority: Critical > > We noticed in our application, that sometimes when we interact with a table > an operation will fail with an exception, an all operations that happen on > the same region will also fail until the application is restarted. > It seems that when a merge or split happens on a region that is already in > the clients cache, and the client is configured to retry operations, then > there is no way for the client to detect this. In > RpcRetryingCaller#callWithRetries if a call fails with > RegionNotServingException then the cache will be cleared only if the retry > parameter is equal to 1. This means the call will fail but the following > calls will succeed. > RpcRetryingCaller#callWithoutRetries contains the comment "It would be nice > to clear the location cache here". Additionally, the stale cache will cause > this call to fail, even though the data is available. > See also HBASE-12534 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17557) HRegionServer#reportRegionSizesForQuotas() should respond to UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HBASE-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17557:
---
Attachment: 17557.HBASE-16961.v2.txt
> HRegionServer#reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException
> --
>
> Key: HBASE-17557
> URL: https://issues.apache.org/jira/browse/HBASE-17557
> Project: HBase
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 17557.HBASE-16961.v2.txt
>
>
> When master doesn't support quota, you would see the following repeatedly in
> region server log:
> {code}
> 2017-01-27 17:24:27,389 DEBUG
> [cn011.x.com,16020,1485468203653_ChoreService_1] regionserver.HRegionServer:
> Failed to report region sizes to Master. This will be retried.
> org.apache.hadoop.hbase.DoNotRetryIOException: /23:16000 is unable to read
> call parameter from client 21; java.lang.UnsupportedOperationException:
> ReportRegionSpaceUse
> at sun.reflect.GeneratedConstructorAccessor8.newInstance(Unknown
> Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)
> at
> org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:95)
> at
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:334)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1211)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.reportRegionSizesToMaster(FileSystemUtilizationChore.java:170)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.chore(FileSystemUtilizationChore.java:129)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:185)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by:
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.DoNotRetryIOException):
> /23:16000 is unable to read call parameter from client 21; java.lang.
> UnsupportedOperationException: ReportRegionSpaceUse
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1225)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:213)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:287)
> at
> org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.reportRegionSpaceUse(RegionServerStatusProtos.java:10919)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1209)
> {code}
> HRegionServer.reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException and stop retrying.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17557) HRegionServer#reportRegionSizesForQuotas() should respond to UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HBASE-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17557:
---
Attachment: (was: 17557.HBASE-16961.v1.txt)
> HRegionServer#reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException
> --
>
> Key: HBASE-17557
> URL: https://issues.apache.org/jira/browse/HBASE-17557
> Project: HBase
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
>
> When master doesn't support quota, you would see the following repeatedly in
> region server log:
> {code}
> 2017-01-27 17:24:27,389 DEBUG
> [cn011.x.com,16020,1485468203653_ChoreService_1] regionserver.HRegionServer:
> Failed to report region sizes to Master. This will be retried.
> org.apache.hadoop.hbase.DoNotRetryIOException: /23:16000 is unable to read
> call parameter from client 21; java.lang.UnsupportedOperationException:
> ReportRegionSpaceUse
> at sun.reflect.GeneratedConstructorAccessor8.newInstance(Unknown
> Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)
> at
> org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:95)
> at
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:334)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1211)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.reportRegionSizesToMaster(FileSystemUtilizationChore.java:170)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.chore(FileSystemUtilizationChore.java:129)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:185)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by:
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.DoNotRetryIOException):
> /23:16000 is unable to read call parameter from client 21; java.lang.
> UnsupportedOperationException: ReportRegionSpaceUse
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1225)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:213)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:287)
> at
> org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.reportRegionSpaceUse(RegionServerStatusProtos.java:10919)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1209)
> {code}
> HRegionServer.reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException and stop retrying.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17557) HRegionServer#reportRegionSizesForQuotas() should respond to UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HBASE-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17557:
---
Attachment: 17557.HBASE-16961.v1.txt
> HRegionServer#reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException
> --
>
> Key: HBASE-17557
> URL: https://issues.apache.org/jira/browse/HBASE-17557
> Project: HBase
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 17557.HBASE-16961.v1.txt
>
>
> When master doesn't support quota, you would see the following repeatedly in
> region server log:
> {code}
> 2017-01-27 17:24:27,389 DEBUG
> [cn011.x.com,16020,1485468203653_ChoreService_1] regionserver.HRegionServer:
> Failed to report region sizes to Master. This will be retried.
> org.apache.hadoop.hbase.DoNotRetryIOException: /23:16000 is unable to read
> call parameter from client 21; java.lang.UnsupportedOperationException:
> ReportRegionSpaceUse
> at sun.reflect.GeneratedConstructorAccessor8.newInstance(Unknown
> Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)
> at
> org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:95)
> at
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:334)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1211)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.reportRegionSizesToMaster(FileSystemUtilizationChore.java:170)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.chore(FileSystemUtilizationChore.java:129)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:185)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by:
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.DoNotRetryIOException):
> /23:16000 is unable to read call parameter from client 21; java.lang.
> UnsupportedOperationException: ReportRegionSpaceUse
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1225)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:213)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:287)
> at
> org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.reportRegionSpaceUse(RegionServerStatusProtos.java:10919)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1209)
> {code}
> HRegionServer.reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException and stop retrying.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17557) HRegionServer#reportRegionSizesForQuotas() should respond to UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HBASE-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17557:
---
Attachment: (was: 17557.HBASE-16961.v1.txt)
> HRegionServer#reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException
> --
>
> Key: HBASE-17557
> URL: https://issues.apache.org/jira/browse/HBASE-17557
> Project: HBase
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
>
> When master doesn't support quota, you would see the following repeatedly in
> region server log:
> {code}
> 2017-01-27 17:24:27,389 DEBUG
> [cn011.x.com,16020,1485468203653_ChoreService_1] regionserver.HRegionServer:
> Failed to report region sizes to Master. This will be retried.
> org.apache.hadoop.hbase.DoNotRetryIOException: /23:16000 is unable to read
> call parameter from client 21; java.lang.UnsupportedOperationException:
> ReportRegionSpaceUse
> at sun.reflect.GeneratedConstructorAccessor8.newInstance(Unknown
> Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)
> at
> org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:95)
> at
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:334)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1211)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.reportRegionSizesToMaster(FileSystemUtilizationChore.java:170)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.chore(FileSystemUtilizationChore.java:129)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:185)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by:
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.DoNotRetryIOException):
> /23:16000 is unable to read call parameter from client 21; java.lang.
> UnsupportedOperationException: ReportRegionSpaceUse
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1225)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:213)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:287)
> at
> org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.reportRegionSpaceUse(RegionServerStatusProtos.java:10919)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1209)
> {code}
> HRegionServer.reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException and stop retrying.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17557) HRegionServer#reportRegionSizesForQuotas() should respond to UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HBASE-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17557:
---
Status: Patch Available (was: Open)
> HRegionServer#reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException
> --
>
> Key: HBASE-17557
> URL: https://issues.apache.org/jira/browse/HBASE-17557
> Project: HBase
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 17557.HBASE-16961.v1.txt
>
>
> When master doesn't support quota, you would see the following repeatedly in
> region server log:
> {code}
> 2017-01-27 17:24:27,389 DEBUG
> [cn011.x.com,16020,1485468203653_ChoreService_1] regionserver.HRegionServer:
> Failed to report region sizes to Master. This will be retried.
> org.apache.hadoop.hbase.DoNotRetryIOException: /23:16000 is unable to read
> call parameter from client 21; java.lang.UnsupportedOperationException:
> ReportRegionSpaceUse
> at sun.reflect.GeneratedConstructorAccessor8.newInstance(Unknown
> Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)
> at
> org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:95)
> at
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:334)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1211)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.reportRegionSizesToMaster(FileSystemUtilizationChore.java:170)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.chore(FileSystemUtilizationChore.java:129)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:185)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by:
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.DoNotRetryIOException):
> /23:16000 is unable to read call parameter from client 21; java.lang.
> UnsupportedOperationException: ReportRegionSpaceUse
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1225)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:213)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:287)
> at
> org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.reportRegionSpaceUse(RegionServerStatusProtos.java:10919)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1209)
> {code}
> HRegionServer.reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException and stop retrying.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17557) HRegionServer#reportRegionSizesForQuotas() should respond to UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HBASE-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17557:
---
Attachment: 17557.HBASE-16961.v1.txt
> HRegionServer#reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException
> --
>
> Key: HBASE-17557
> URL: https://issues.apache.org/jira/browse/HBASE-17557
> Project: HBase
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 17557.HBASE-16961.v1.txt
>
>
> When master doesn't support quota, you would see the following repeatedly in
> region server log:
> {code}
> 2017-01-27 17:24:27,389 DEBUG
> [cn011.x.com,16020,1485468203653_ChoreService_1] regionserver.HRegionServer:
> Failed to report region sizes to Master. This will be retried.
> org.apache.hadoop.hbase.DoNotRetryIOException: /23:16000 is unable to read
> call parameter from client 21; java.lang.UnsupportedOperationException:
> ReportRegionSpaceUse
> at sun.reflect.GeneratedConstructorAccessor8.newInstance(Unknown
> Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)
> at
> org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:95)
> at
> org.apache.hadoop.hbase.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:334)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1211)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.reportRegionSizesToMaster(FileSystemUtilizationChore.java:170)
> at
> org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.chore(FileSystemUtilizationChore.java:129)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:185)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by:
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.DoNotRetryIOException):
> /23:16000 is unable to read call parameter from client 21; java.lang.
> UnsupportedOperationException: ReportRegionSpaceUse
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1225)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:213)
> at
> org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:287)
> at
> org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.reportRegionSpaceUse(RegionServerStatusProtos.java:10919)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1209)
> {code}
> HRegionServer.reportRegionSizesForQuotas() should respond to
> UnsupportedOperationException and stop retrying.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-17557) HRegionServer#reportRegionSizesForQuotas() should respond to UnsupportedOperationException
Ted Yu created HBASE-17557:
--
Summary: HRegionServer#reportRegionSizesForQuotas() should respond
to UnsupportedOperationException
Key: HBASE-17557
URL: https://issues.apache.org/jira/browse/HBASE-17557
Project: HBase
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Ted Yu
When master doesn't support quota, you would see the following repeatedly in
region server log:
{code}
2017-01-27 17:24:27,389 DEBUG [cn011.x.com,16020,1485468203653_ChoreService_1]
regionserver.HRegionServer: Failed to report region sizes to Master. This will
be retried.
org.apache.hadoop.hbase.DoNotRetryIOException: /23:16000 is unable to read call
parameter from client 21; java.lang.UnsupportedOperationException:
ReportRegionSpaceUse
at sun.reflect.GeneratedConstructorAccessor8.newInstance(Unknown Source)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at
org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)
at
org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:95)
at
org.apache.hadoop.hbase.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:334)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1211)
at
org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.reportRegionSizesToMaster(FileSystemUtilizationChore.java:170)
at
org.apache.hadoop.hbase.quotas.FileSystemUtilizationChore.chore(FileSystemUtilizationChore.java:129)
at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:185)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by:
org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.DoNotRetryIOException):
/23:16000 is unable to read call parameter from client 21; java.lang.
UnsupportedOperationException: ReportRegionSpaceUse
at
org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1225)
at
org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:213)
at
org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:287)
at
org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.reportRegionSpaceUse(RegionServerStatusProtos.java:10919)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.reportRegionSizesForQuotas(HRegionServer.java:1209)
{code}
HRegionServer.reportRegionSizesForQuotas() should respond to
UnsupportedOperationException and stop retrying.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-17271) hbase-thrift QA tests only run one test
[ https://issues.apache.org/jira/browse/HBASE-17271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-17271: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.0.0 Status: Resolved (was: Patch Available) Thanks for the patch, Jan. > hbase-thrift QA tests only run one test > --- > > Key: HBASE-17271 > URL: https://issues.apache.org/jira/browse/HBASE-17271 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Jan Hentschel > Labels: build, thrift > Fix For: 2.0.0 > > Attachments: HBASE-17271.master.001.patch > > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/4822/artifact/patchprocess/patch-unit-hbase-thrift.txt > , it is pretty clear that only one test was run - TestCallQueue > Even though the patch contains modified TestThriftHBaseServiceHandler. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17555) Change calls to deprecated getHBaseAdmin to getAdmin
[
https://issues.apache.org/jira/browse/HBASE-17555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843045#comment-15843045
]
Hadoop QA commented on HBASE-17555:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 206 new or modified
test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 22s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
7s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 15s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 6m
0s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
44s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 42s
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 44s
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
24s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 14s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 14s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m
58s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
43s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 46s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
54s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 49s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 83m 41s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 31s
{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 43s
{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 19s
{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 20s
{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 36s
{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 36s
{color} | {color:green} hbase-client-project in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 36s
{color} | {color:green} hbase-shaded-client-project in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
39s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 165m 0s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.
[jira] [Reopened] (HBASE-17526) Procedure v2 - cleanup isSuspended from MasterProcedureScheduler#Queue
[ https://issues.apache.org/jira/browse/HBASE-17526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reopened HBASE-17526: - Reopening. This commit introduced a findbugs warning that is now pinging every patch submission that touches hbase-server. Please include an addendum that cleans it up. One example: https://builds.apache.org/job/PreCommit-HBASE-Build/5449/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html Please check on precommit results before pushing. > Procedure v2 - cleanup isSuspended from MasterProcedureScheduler#Queue > -- > > Key: HBASE-17526 > URL: https://issues.apache.org/jira/browse/HBASE-17526 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Appy >Assignee: Appy >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-17526.master.001.patch > > > Queue#setSuspended() is not used anywhere, probably because when queue > wait/wakes on an event, it gets removed or added back to the fairq. > Removing state, functions, and uses of isSuspended() -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-17522) RuntimeExceptions from MemoryMXBean should not take down server process
[ https://issues.apache.org/jira/browse/HBASE-17522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-17522: Fix Version/s: 1.1.9 1.2.5 > RuntimeExceptions from MemoryMXBean should not take down server process > --- > > Key: HBASE-17522 > URL: https://issues.apache.org/jira/browse/HBASE-17522 > Project: HBase > Issue Type: Bug > Components: regionserver > Environment: java version "1.8.0_92" > Java(TM) SE Runtime Environment (build 1.8.0_92-b14) > Java HotSpot(TM) 64-Bit Server VM (build 25.92-b14, mixed mode) > -XX:+UseG1GC -XX:+UseStringDeduplication -Xmx32768m >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.9 > > Attachments: HBASE-17522.0.patch > > > RegionServer died after MemoryMXBean threw an IllegalArgumentException while > attempting to create a MemoryUsage object for the heap during construction of > the server load. > We shouldn't allow failure to get load information to take down the RS. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
