[jira] [Updated] (HBASE-18702) Document the cell helper - CellBuilder and ExtendedCellBuilder
[ https://issues.apache.org/jira/browse/HBASE-18702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18702: --- Component/s: documentation > Document the cell helper - CellBuilder and ExtendedCellBuilder > -- > > Key: HBASE-18702 > URL: https://issues.apache.org/jira/browse/HBASE-18702 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Chia-Ping Tsai >Priority: Minor > Labels: beginner > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18702) Document the cell helper - CellBuilder and ExtendedCellBuilder
[ https://issues.apache.org/jira/browse/HBASE-18702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18702: --- Labels: beginner (was: ) > Document the cell helper - CellBuilder and ExtendedCellBuilder > -- > > Key: HBASE-18702 > URL: https://issues.apache.org/jira/browse/HBASE-18702 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Chia-Ping Tsai >Priority: Minor > Labels: beginner > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18702) Document the cell helper - CellBuilder and ExtendedCellBuilder
[ https://issues.apache.org/jira/browse/HBASE-18702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18702: --- Summary: Document the cell helper - CellBuilder and ExtendedCellBuilder (was: Document the new tools - CellBuilder and ExtendedCellBuilder) > Document the cell helper - CellBuilder and ExtendedCellBuilder > -- > > Key: HBASE-18702 > URL: https://issues.apache.org/jira/browse/HBASE-18702 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18702) Document the new tools - CellBuilder and ExtendedCellBuilder
Chia-Ping Tsai created HBASE-18702: -- Summary: Document the new tools - CellBuilder and ExtendedCellBuilder Key: HBASE-18702 URL: https://issues.apache.org/jira/browse/HBASE-18702 Project: HBase Issue Type: Task Reporter: Chia-Ping Tsai Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-14255) Simplify Cell creation post 1.0
[
https://issues.apache.org/jira/browse/HBASE-14255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved HBASE-14255.
Resolution: Duplicate
see HBASE-18519
> Simplify Cell creation post 1.0
> ---
>
> Key: HBASE-14255
> URL: https://issues.apache.org/jira/browse/HBASE-14255
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 1.0.0, 2.0.0
>Reporter: Lars George
>Priority: Critical
> Labels: beginner
> Fix For: 2.0.0-alpha-3
>
>
> After the switch to the new Cell based client API, and making KeyValue
> private (but especially as soon as DBB backed Cells land) it is rather
> difficult to create a {{Cell}} instance. I am using this now:
> {code}
> @Override
> public void postGetOp(ObserverContext e,
> Get get, List results) throws IOException {
> Put put = new Put(get.getRow());
> put.addColumn(get.getRow(), FIXED_COLUMN, Bytes.toBytes(counter.get()));
> CellScanner scanner = put.cellScanner();
> scanner.advance();
> Cell cell = scanner.current();
> LOG.debug("Adding fake cell: " + cell);
> results.add(cell);
> }
> {code}
> That is, I have to create a {{Put}} instance to add a cell and then retrieve
> its instance. The {{KeyValue}} methods are private now and should not be
> used. Create a CellBuilder helper?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18519) Use builder pattern to create cell
[ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18519: --- Labels: client (was: ) > Use builder pattern to create cell > -- > > Key: HBASE-18519 > URL: https://issues.apache.org/jira/browse/HBASE-18519 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Labels: client > Fix For: 2.0.0 > > Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, > HBASE-18519.v2.patch, HBASE-18519.v3.patch, HBASE-18519.v4.patch, > HBASE-18519.v5.patch > > > The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the > input arguments without copying. We can substitute IndividualBytesFieldCell > for CellUtil.createCell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18519) Use builder pattern to create cell
[ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18519: --- Resolution: Fixed Hadoop Flags: Reviewed Release Note: Introduce the CellBuilder helper. 1) Using CellBuilderFactory to get CellBuilder for creating cell with row, column, qualifier, type, and value. 2) For internal use, the ExtendedCellBuilder, which is created by ExtendedCellBuilderFactory, is able to build cell with extra fields - sequence id and tags - Status: Resolved (was: Patch Available) > Use builder pattern to create cell > -- > > Key: HBASE-18519 > URL: https://issues.apache.org/jira/browse/HBASE-18519 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, > HBASE-18519.v2.patch, HBASE-18519.v3.patch, HBASE-18519.v4.patch, > HBASE-18519.v5.patch > > > The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the > input arguments without copying. We can substitute IndividualBytesFieldCell > for CellUtil.createCell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18519) Use builder pattern to create cell
[ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143417#comment-16143417 ] Chia-Ping Tsai commented on HBASE-18519: bq. Of course. ramkrishna.s.vasudevan and Anoop Sam John are the experts here. Listen to them. Thanks [~stack]. I prefer reaching a consensus as much as possible before committing. :P Thanks for all reviews folks. Push this to master and branch-2. > Use builder pattern to create cell > -- > > Key: HBASE-18519 > URL: https://issues.apache.org/jira/browse/HBASE-18519 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, > HBASE-18519.v2.patch, HBASE-18519.v3.patch, HBASE-18519.v4.patch, > HBASE-18519.v5.patch > > > The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the > input arguments without copying. We can substitute IndividualBytesFieldCell > for CellUtil.createCell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18692) [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int
[
https://issues.apache.org/jira/browse/HBASE-18692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143409#comment-16143409
]
Hadoop QA commented on HBASE-18692:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 44s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
21s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 45m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18692 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883993/HBASE-18692.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 62bb491f5196 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / a407b58 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8354/testReport/ |
| modules | C: hbase-common U: hbase-common |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8354/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int
> -
>
> Key: HBASE-18692
> URL: https://issues.apache.org/jira/browse/HBASE-18692
> Project: HBase
> Issue Type: Sub-task
> C
[jira] [Updated] (HBASE-18701) Optimize reference guide to use cell acl conveniently
[ https://issues.apache.org/jira/browse/HBASE-18701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-18701: - Attachment: HBASE-18701.patch > Optimize reference guide to use cell acl conveniently > - > > Key: HBASE-18701 > URL: https://issues.apache.org/jira/browse/HBASE-18701 > Project: HBase > Issue Type: Improvement >Reporter: Shibin Zhang >Priority: Trivial > Attachments: HBASE-18701.patch > > > When i use cell acl,i found it didn't work ,and without related settings > explain in hbase reference guide. After i read the code , i found we need to > change two option value in hbase-site.xml.It is user unfriendly to use cell > acl function.So, i think we need to explain how to enable this function in > reference guide. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18701) Optimize reference guide to use cell acl conveniently
Shibin Zhang created HBASE-18701: Summary: Optimize reference guide to use cell acl conveniently Key: HBASE-18701 URL: https://issues.apache.org/jira/browse/HBASE-18701 Project: HBase Issue Type: Improvement Reporter: Shibin Zhang Priority: Trivial When i use cell acl,i found it didn't work ,and without related settings explain in hbase reference guide. After i read the code , i found we need to change two option value in hbase-site.xml.It is user unfriendly to use cell acl function.So, i think we need to explain how to enable this function in reference guide. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143392#comment-16143392 ] Duo Zhang commented on HBASE-18640: --- [~chia7712] Create a sub task in HBASE-18696 please. > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18640.branch-2.001.patch, > HBASE-18640.master.001.patch, HBASE-18640.master.002.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.004.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.005.patch, HBASE-18640.master.006.patch, > HBASE-18640.master.007.patch, HBASE-18640.master.008.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18692) [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int
[ https://issues.apache.org/jira/browse/HBASE-18692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143388#comment-16143388 ] Anoop Sam John commented on HBASE-18692: +1 > [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int > - > > Key: HBASE-18692 > URL: https://issues.apache.org/jira/browse/HBASE-18692 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18692.master.001.patch > > > [~ram_krish] You need this change? BBUtils was public back in 1.0 and > ByteBufferUtils.copyFromBufferToBuffer > returned a void. HBASE-12213 HFileBlock backed by Array of ByteBuffers (Ram) > changed it to return an int. You think we need this? I can try undoing it. > Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143384#comment-16143384 ] stack commented on HBASE-18640: --- We can do that for endpoints. Yeah, lets address the teething issues in follow on. Nice list [~busbey] I can help [~appy]. Lets have a go in morning. I can look at the spark issue too... > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18640.branch-2.001.patch, > HBASE-18640.master.001.patch, HBASE-18640.master.002.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.004.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.005.patch, HBASE-18640.master.006.patch, > HBASE-18640.master.007.patch, HBASE-18640.master.008.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18519) Use builder pattern to create cell
[ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143383#comment-16143383 ] stack commented on HBASE-18519: --- bq. Can we undo the configured way ? Of course. [~ram_krish] and [~anoopsamjohn] are the experts here. Listen to them. > Use builder pattern to create cell > -- > > Key: HBASE-18519 > URL: https://issues.apache.org/jira/browse/HBASE-18519 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, > HBASE-18519.v2.patch, HBASE-18519.v3.patch, HBASE-18519.v4.patch, > HBASE-18519.v5.patch > > > The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the > input arguments without copying. We can substitute IndividualBytesFieldCell > for CellUtil.createCell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18692) [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int
[ https://issues.apache.org/jira/browse/HBASE-18692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18692: -- Assignee: stack Status: Patch Available (was: Open) Thanks boys. Small patch. > [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int > - > > Key: HBASE-18692 > URL: https://issues.apache.org/jira/browse/HBASE-18692 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18692.master.001.patch > > > [~ram_krish] You need this change? BBUtils was public back in 1.0 and > ByteBufferUtils.copyFromBufferToBuffer > returned a void. HBASE-12213 HFileBlock backed by Array of ByteBuffers (Ram) > changed it to return an int. You think we need this? I can try undoing it. > Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18692) [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int
[ https://issues.apache.org/jira/browse/HBASE-18692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18692: -- Attachment: HBASE-18692.master.001.patch > [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int > - > > Key: HBASE-18692 > URL: https://issues.apache.org/jira/browse/HBASE-18692 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18692.master.001.patch > > > [~ram_krish] You need this change? BBUtils was public back in 1.0 and > ByteBufferUtils.copyFromBufferToBuffer > returned a void. HBASE-12213 HFileBlock backed by Array of ByteBuffers (Ram) > changed it to return an int. You think we need this? I can try undoing it. > Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18649) Deprecate KV Usage in MR to move to Cells in 3.0
[ https://issues.apache.org/jira/browse/HBASE-18649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143368#comment-16143368 ] ramkrishna.s.vasudevan commented on HBASE-18649: bq. lets not expose non public classes/interfaces here Here we are not exposing it for the user to configure. Only the io.serializations are actually exposed. Which includes "KVSerailization". Generally the mapper's output value class are not configurable whereas we directly set them if the user tries to use it. Since KV is private then we should expose only the interface Cell then as it is public. But again am not sure if Mappers work with interfaces alone and do they need concrete implementations as the type? > Deprecate KV Usage in MR to move to Cells in 3.0 > > > Key: HBASE-18649 > URL: https://issues.apache.org/jira/browse/HBASE-18649 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 2.0.0-alpha-2 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 3.0.0, 2.1.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16594) ROW_INDEX_V2 DBE
[ https://issues.apache.org/jira/browse/HBASE-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143366#comment-16143366 ] Anoop Sam John commented on HBASE-16594: +1 on resuming this work. Once the latest patch is available, can do reviews. Ya lets try getting this in for 2.0 > ROW_INDEX_V2 DBE > > > Key: HBASE-16594 > URL: https://issues.apache.org/jira/browse/HBASE-16594 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.5.0 > > Attachments: HBASE-16594-master_v1.patch, HBASE-16594-master_v2.patch > > > See HBASE-16213, ROW_INDEX_V1 DataBlockEncoding. > ROW_INDEX_V1 is the first version which have no storage optimization, > ROW_INDEX_V2 do storage optimization: store every row only once, store column > family only once in a HFileBlock. > ROW_INDEX_V1 is : > /** > * Store cells following every row's start offset, so we can binary search to > a row's cells. > * > * Format: > * flat cells > * integer: number of rows > * integer: row0's offset > * integer: row1's offset > * > * integer: dataSize > * > */ > ROW_INDEX_V2 is : > * row1 qualifier timestamp type value tag > * qualifier timestamp type value tag > * qualifier timestamp type value tag > * row2 qualifier timestamp type value tag > * row3 qualifier timestamp type value tag > * qualifier timestamp type value tag > * > * integer: number of rows > * integer: row0's offset > * integer: row1's offset > * > * column family > * integer: dataSize -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18232) Add variable size chunks to the MSLAB
[ https://issues.apache.org/jira/browse/HBASE-18232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143362#comment-16143362 ] ramkrishna.s.vasudevan commented on HBASE-18232: [~anastas] Posted few comments in RB. Thanks. > Add variable size chunks to the MSLAB > - > > Key: HBASE-18232 > URL: https://issues.apache.org/jira/browse/HBASE-18232 > Project: HBase > Issue Type: Sub-task >Reporter: Anastasia Braginsky >Assignee: Anastasia Braginsky > Attachments: HBASE-18232-V03.patch > > > Add possibility to create a variable size chunks of memory, so any cell (of > any size) can reside on a chunk. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18519) Use builder pattern to create cell
[ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143359#comment-16143359 ] Chia-Ping Tsai commented on HBASE-18519: Thanks for the reviews [~ram_krish] Will commit it shortly. > Use builder pattern to create cell > -- > > Key: HBASE-18519 > URL: https://issues.apache.org/jira/browse/HBASE-18519 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, > HBASE-18519.v2.patch, HBASE-18519.v3.patch, HBASE-18519.v4.patch, > HBASE-18519.v5.patch > > > The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the > input arguments without copying. We can substitute IndividualBytesFieldCell > for CellUtil.createCell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143357#comment-16143357 ] Chia-Ping Tsai commented on HBASE-18640: HBASE15806 introduce a tool which exports table data by Endpoint. The new tool needs the Import for testing but the new tool is located in hbase-endpoint so it can't access the Import in testing after this fix. A workaround is hbase-endpoint includes the test scope of hbase-mapreduce. Any suggestions folks ? > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18640.branch-2.001.patch, > HBASE-18640.master.001.patch, HBASE-18640.master.002.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.004.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.005.patch, HBASE-18640.master.006.patch, > HBASE-18640.master.007.patch, HBASE-18640.master.008.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18519) Use builder pattern to create cell
[ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143355#comment-16143355 ] ramkrishna.s.vasudevan commented on HBASE-18519: +1 > Use builder pattern to create cell > -- > > Key: HBASE-18519 > URL: https://issues.apache.org/jira/browse/HBASE-18519 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, > HBASE-18519.v2.patch, HBASE-18519.v3.patch, HBASE-18519.v4.patch, > HBASE-18519.v5.patch > > > The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the > input arguments without copying. We can substitute IndividualBytesFieldCell > for CellUtil.createCell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18519) Use builder pattern to create cell
[ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143355#comment-16143355 ] ramkrishna.s.vasudevan edited comment on HBASE-18519 at 8/28/17 4:27 AM: - +1. Nice work. was (Author: ram_krish): +1 > Use builder pattern to create cell > -- > > Key: HBASE-18519 > URL: https://issues.apache.org/jira/browse/HBASE-18519 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, > HBASE-18519.v2.patch, HBASE-18519.v3.patch, HBASE-18519.v4.patch, > HBASE-18519.v5.patch > > > The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the > input arguments without copying. We can substitute IndividualBytesFieldCell > for CellUtil.createCell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18700) Document the new changes on mapreduce stuffs
Duo Zhang created HBASE-18700: - Summary: Document the new changes on mapreduce stuffs Key: HBASE-18700 URL: https://issues.apache.org/jira/browse/HBASE-18700 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18699) Move LoadIncrementalHFiles to another package
Duo Zhang created HBASE-18699: - Summary: Move LoadIncrementalHFiles to another package Key: HBASE-18699 URL: https://issues.apache.org/jira/browse/HBASE-18699 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang LoadIncrementalHFiles does not depend on map reduce. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18698) MapreduceDependencyClasspathTool does not include hbase-server as a dependency
[ https://issues.apache.org/jira/browse/HBASE-18698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18698: -- Description: This would introduce runtime errors when using snapshot input format. > MapreduceDependencyClasspathTool does not include hbase-server as a dependency > -- > > Key: HBASE-18698 > URL: https://issues.apache.org/jira/browse/HBASE-18698 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-3 > > > This would introduce runtime errors when using snapshot input format. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18698) MapreduceDependencyClasspathTool does not include hbase-server as a dependency
Duo Zhang created HBASE-18698: - Summary: MapreduceDependencyClasspathTool does not include hbase-server as a dependency Key: HBASE-18698 URL: https://issues.apache.org/jira/browse/HBASE-18698 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18697) Need a shaded hbase-mapreduce module
Duo Zhang created HBASE-18697: - Summary: Need a shaded hbase-mapreduce module Key: HBASE-18697 URL: https://issues.apache.org/jira/browse/HBASE-18697 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18635) Fix asciidoc warnings
[
https://issues.apache.org/jira/browse/HBASE-18635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Misty Stanley-Jones updated HBASE-18635:
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 3.0.0
Status: Resolved (was: Patch Available)
> Fix asciidoc warnings
> -
>
> Key: HBASE-18635
> URL: https://issues.apache.org/jira/browse/HBASE-18635
> Project: HBase
> Issue Type: Bug
>Reporter: Misty Stanley-Jones
>Assignee: Jan Hentschel
> Fix For: 3.0.0
>
> Attachments: HBASE-18635.master.001.patch,
> HBASE-18635.master.002.patch
>
>
> When building docs, I noticed:
> {code}
> Failed to parse formatted text: To supply filters to the Scanner object or
> configure the Scanner in any other way, you can create a text file and add
> your filter to the file. For example, to return only rows for which keys
> start with u123 and use a batch size of 100, the
> filter file would look like this:
> { "type": "PrefixFilter",
> "value": "u123" }
> {code}
> Working hypthesis is that we should either be using proper codeblocks rather
> than pre tags. Otherwise we may need to do something to escape curly braces.
> Asciidoctor is probably trying to interpret them as Liquid tags.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17069) RegionServer writes invalid META entries for split daughters in some circumstances
[
https://issues.apache.org/jira/browse/HBASE-17069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143323#comment-16143323
]
Yu Li commented on HBASE-17069:
---
bq. It is introduced by HBASE-14465, which is the backport of HBASE-12751.
Adding link to HBASE-14465 according to above description for better tracking
> RegionServer writes invalid META entries for split daughters in some
> circumstances
> --
>
> Key: HBASE-17069
> URL: https://issues.apache.org/jira/browse/HBASE-17069
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.2.4
>Reporter: Andrew Purtell
>Assignee: Abhishek Singh Chouhan
>Priority: Blocker
> Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5
>
> Attachments: daughter_1_d55ef81c2f8299abbddfce0445067830.log,
> daughter_2_08629d59564726da2497f70451aafcdb.log,
> HBASE-17069-addendum.branch-1.3.001.patch, HBASE-17069.branch-1.3.001.patch,
> HBASE-17069.branch-1.3.002.patch, HBASE-17069.master.001.patch, logs.tar.gz,
> parent-393d2bfd8b1c52ce08540306659624f2.log
>
>
> I have been seeing frequent ITBLL failures testing various versions of 1.2.x.
> Over the lifetime of 1.2.x the following issues have been fixed:
> - HBASE-15315 (Remove always set super user call as high priority)
> - HBASE-16093 (Fix splits failed before creating daughter regions leave meta
> inconsistent)
> And this one is pending:
> - HBASE-17044 (Fix merge failed before creating merged region leaves meta
> inconsistent)
> I can apply all of the above to branch-1.2 and still see this failure:
> *The life of stillborn region d55ef81c2f8299abbddfce0445067830*
> *Master sees SPLITTING_NEW*
> {noformat}
> 2016-11-08 04:23:21,186 INFO [AM.ZK.Worker-pool2-t82] master.RegionStates:
> Transition null to {d55ef81c2f8299abbddfce0445067830 state=SPLITTING_NEW,
> ts=1478579001186, server=node-3.cluster,16020,1478578389506}
> {noformat}
> *The RegionServer creates it*
> {noformat}
> 2016-11-08 04:23:26,035 INFO
> [StoreOpener-d55ef81c2f8299abbddfce0445067830-1] hfile.CacheConfig: Created
> cacheConfig for GomnU: blockCache=LruBlockCache{blockCount=34,
> currentSize=14996112, freeSize=12823716208, maxSize=12838712320,
> heapSize=14996112, minSize=12196776960, minFactor=0.95, multiSize=6098388480,
> multiFactor=0.5, singleSize=3049194240, singleFactor=0.25},
> cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false,
> cacheBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false,
> prefetchOnOpen=false
> 2016-11-08 04:23:26,038 INFO
> [StoreOpener-d55ef81c2f8299abbddfce0445067830-1] hfile.CacheConfig: Created
> cacheConfig for big: blockCache=LruBlockCache{blockCount=34,
> currentSize=14996112, freeSize=12823716208, maxSize=12838712320,
> heapSize=14996112, minSize=12196776960, minFactor=0.95, multiSize=6098388480,
> multiFactor=0.5, singleSize=3049194240, singleFactor=0.25},
> cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false,
> cacheBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false,
> prefetchOnOpen=false
> 2016-11-08 04:23:26,442 INFO
> [StoreOpener-d55ef81c2f8299abbddfce0445067830-1] hfile.CacheConfig: Created
> cacheConfig for meta: blockCache=LruBlockCache{blockCount=63,
> currentSize=17187656, freeSize=12821524664, maxSize=12838712320,
> heapSize=17187656, minSize=12196776960, minFactor=0.95, multiSize=6098388480,
> multiFactor=0.5, singleSize=3049194240, singleFactor=0.25},
> cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false,
> cacheBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false,
> prefetchOnOpen=false
> 2016-11-08 04:23:26,713 INFO
> [StoreOpener-d55ef81c2f8299abbddfce0445067830-1] hfile.CacheConfig: Created
> cacheConfig for nwmrW: blockCache=LruBlockCache{blockCount=96,
> currentSize=19178440, freeSize=12819533880, maxSize=12838712320,
> heapSize=19178440, minSize=12196776960, minFactor=0.95, multiSize=6098388480,
> multiFactor=0.5, singleSize=3049194240, singleFactor=0.25},
> cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false,
> cacheBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false,
> prefetchOnOpen=false
> 2016-11-08 04:23:26,715 INFO
> [StoreOpener-d55ef81c2f8299abbddfce0445067830-1] hfile.CacheConfig: Created
> cacheConfig for piwbr: blockCache=LruBlockCache{blockCount=96,
> currentSize=19178440, freeSize=12819533880, maxSize=12838712320,
> heapSize=19178440, minSize=12196776960, minFactor=0.95, multiSize=6098388480,
> multiFactor=0.5, singleSize=3049194240, singleFactor=0.25},
> cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false,
> cacheBloomsOnWrite=false, cacheEvictOnClose=fals
[jira] [Updated] (HBASE-18696) Fix the problems when introducing the new hbase-mapreduce module
[ https://issues.apache.org/jira/browse/HBASE-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18696: -- Description: See the comment in HBASE-18640 https://issues.apache.org/jira/browse/HBASE-18640?focusedCommentId=16143234&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16143234 > Fix the problems when introducing the new hbase-mapreduce module > > > Key: HBASE-18696 > URL: https://issues.apache.org/jira/browse/HBASE-18696 > Project: HBase > Issue Type: Umbrella > Components: mapreduce >Affects Versions: 3.0.0, 2.0.0-alpha-2 >Reporter: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.0.0-alpha-3 > > > See the comment in HBASE-18640 > https://issues.apache.org/jira/browse/HBASE-18640?focusedCommentId=16143234&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16143234 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18696) Fix the problems when introducing the new hbase-mapreduce module
[ https://issues.apache.org/jira/browse/HBASE-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143322#comment-16143322 ] Duo Zhang commented on HBASE-18696: --- [~busbey] [~stack] [~appy] FYI. > Fix the problems when introducing the new hbase-mapreduce module > > > Key: HBASE-18696 > URL: https://issues.apache.org/jira/browse/HBASE-18696 > Project: HBase > Issue Type: Umbrella > Components: mapreduce >Affects Versions: 3.0.0, 2.0.0-alpha-2 >Reporter: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.0.0-alpha-3 > > > See the comment in HBASE-18640 > https://issues.apache.org/jira/browse/HBASE-18640?focusedCommentId=16143234&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16143234 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18696) Fix the problems when introducing the new hbase-mapreduce module
Duo Zhang created HBASE-18696: - Summary: Fix the problems when introducing the new hbase-mapreduce module Key: HBASE-18696 URL: https://issues.apache.org/jira/browse/HBASE-18696 Project: HBase Issue Type: Umbrella Components: mapreduce Affects Versions: 2.0.0-alpha-2, 3.0.0 Reporter: Duo Zhang Priority: Blocker Fix For: 3.0.0, 2.0.0-alpha-3 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[
https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143319#comment-16143319
]
Duo Zhang commented on HBASE-18640:
---
And [~appy], seems {{LoadIncrementalHFiles}} does not depend on map reduce, so
let's move it to another package, for example, o.a.h.h.tool? We are allowed to
do incompatible changes for major release.
[~busbey] I prefer open a blocker issue to address the problems.
Thanks.
> Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
> ---
>
> Key: HBASE-18640
> URL: https://issues.apache.org/jira/browse/HBASE-18640
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18640.branch-2.001.patch,
> HBASE-18640.master.001.patch, HBASE-18640.master.002.patch,
> HBASE-18640.master.003.patch, HBASE-18640.master.003.patch,
> HBASE-18640.master.004.patch, HBASE-18640.master.004.patch,
> HBASE-18640.master.005.patch, HBASE-18640.master.006.patch,
> HBASE-18640.master.007.patch, HBASE-18640.master.008.patch
>
>
> (Couldn't find another dedicated jira, so creating new one).
> Uploaded patch which is moving ~60 files to the new module. Few notes:
> - The classes remaining in hbase-server are the ones which are intensively
> coupled with visibility labels/wal/filesystem/hfile. These can not be
> migrated to new module until corresponding subcomponents are untangled out of
> hbase-server into their own separate modules.
> - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to
> hbase-mapreduce module. Given these dependency constraints, one way would be
> having a separate module for tests:
> hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests
> Imo, this makes sense and looks fine.
> The only issue is - yetus' pre-commit. It won't run tests in
> hbase-mapreduce-tests module if something changed in just hbase-mapreduce.
> However, yetus' limitation shouldn't warrant against the idea.
> So i'd say that we should go that way, unless there are better suggestions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143317#comment-16143317 ] Duo Zhang commented on HBASE-18640: --- So we need a hbase-shaded-mapreduce module? > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18640.branch-2.001.patch, > HBASE-18640.master.001.patch, HBASE-18640.master.002.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.004.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.005.patch, HBASE-18640.master.006.patch, > HBASE-18640.master.007.patch, HBASE-18640.master.008.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-16213) A new HFileBlock structure for fast random get
[ https://issues.apache.org/jira/browse/HBASE-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143316#comment-16143316 ] Yu Li edited comment on HBASE-16213 at 8/28/17 2:55 AM: bq. I think V2 can replace V1, V2 have space optimize and the same seek perf. [~aoxiang] Let's get HBASE-16594 in then if no objections ([~anoop.hbase] please let us know if any comments here sir, thanks), then people like our mighty [~yangzhe1991] could use it and further improve it (smile). was (Author: carp84): bq. I think V2 can replace V1, V2 have space optimize and the same seek perf. Let's get HBASE-16594 in then if no objections ([~anoop.hbase] please let us know if any comments here sir, thanks), then people like our mighty [~yangzhe1991] could use it and further improve it (smile). > A new HFileBlock structure for fast random get > -- > > Key: HBASE-16213 > URL: https://issues.apache.org/jira/browse/HBASE-16213 > Project: HBase > Issue Type: New Feature > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16213.branch-1.v1.patch, > HBASE-16213_branch1_v3.patch, HBASE-16213.branch-1.v4.patch, > HBASE-16213.branch-1.v4.patch, HBASE-16213-master_v1.patch, > HBASE-16213-master_v3.patch, HBASE-16213-master_v4.patch, > HBASE-16213-master_v5.patch, HBASE-16213-master_v6.patch, HBASE-16213.patch, > HBASE-16213_v2.patch, hfile_block_performance2.pptx, > hfile_block_performance_E2E.pptx, hfile_block_performance.pptx, hfile-cpu.png > > > HFileBlock store cells sequential, current when to get a row from the block, > it scan from the first cell until the row's cell. > The new structure store every row's start offset with data, so it can find > the exact row with binarySearch. > I use EncodedSeekPerformanceTest test the performance. > First use ycsb write 100w data, every row have only one qualifier, and > valueLength=16B/64/256B/1k. > Then use EncodedSeekPerformanceTest to test random read 1w or 100w row, and > also record HFileBlock's dataSize/dataWithMetaSize in the encoding. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16213) A new HFileBlock structure for fast random get
[ https://issues.apache.org/jira/browse/HBASE-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143316#comment-16143316 ] Yu Li commented on HBASE-16213: --- bq. I think V2 can replace V1, V2 have space optimize and the same seek perf. Let's get HBASE-16594 in then if no objections ([~anoop.hbase] please let us know if any comments here sir, thanks), then people like our mighty [~yangzhe1991] could use it and further improve it (smile). > A new HFileBlock structure for fast random get > -- > > Key: HBASE-16213 > URL: https://issues.apache.org/jira/browse/HBASE-16213 > Project: HBase > Issue Type: New Feature > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16213.branch-1.v1.patch, > HBASE-16213_branch1_v3.patch, HBASE-16213.branch-1.v4.patch, > HBASE-16213.branch-1.v4.patch, HBASE-16213-master_v1.patch, > HBASE-16213-master_v3.patch, HBASE-16213-master_v4.patch, > HBASE-16213-master_v5.patch, HBASE-16213-master_v6.patch, HBASE-16213.patch, > HBASE-16213_v2.patch, hfile_block_performance2.pptx, > hfile_block_performance_E2E.pptx, hfile_block_performance.pptx, hfile-cpu.png > > > HFileBlock store cells sequential, current when to get a row from the block, > it scan from the first cell until the row's cell. > The new structure store every row's start offset with data, so it can find > the exact row with binarySearch. > I use EncodedSeekPerformanceTest test the performance. > First use ycsb write 100w data, every row have only one qualifier, and > valueLength=16B/64/256B/1k. > Then use EncodedSeekPerformanceTest to test random read 1w or 100w row, and > also record HFileBlock's dataSize/dataWithMetaSize in the encoding. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18677) typo in namespace docs
[
https://issues.apache.org/jira/browse/HBASE-18677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143292#comment-16143292
]
Hadoop QA commented on HBASE-18677:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 20s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}144m
15s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}196m 25s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18677 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883983/HBASE-18677.master.v0.patch
|
| Optional Tests | asflicense javac javadoc unit |
| uname | Linux b7ea040faec1 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / a407b58 |
| Default Java | 1.8.0_144 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8353/testReport/ |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8353/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> typo in namespace docs
> --
>
> Key: HBASE-18677
> URL: https://issues.apache.org/jira/browse/HBASE-18677
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Mike Drob
>Assignee: ChunHao
>Priority: Trivial
> Labels: beginner
> Attachments: HBASE-18677.master.v0.patch
>
>
> In the docs at http://hbase.apache.org/book.html#_namespace - "Region server
> groups (HBASE-6721) - A namespace/table can be pinned onto a subset of
> RegionServers thus guaranteeing a course level of isolation."
> Should be "coarse"
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18677) typo in namespace docs
[ https://issues.apache.org/jira/browse/HBASE-18677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChunHao updated HBASE-18677: Status: Patch Available (was: Open) > typo in namespace docs > -- > > Key: HBASE-18677 > URL: https://issues.apache.org/jira/browse/HBASE-18677 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Mike Drob >Assignee: ChunHao >Priority: Trivial > Labels: beginner > Attachments: HBASE-18677.master.v0.patch > > > In the docs at http://hbase.apache.org/book.html#_namespace - "Region server > groups (HBASE-6721) - A namespace/table can be pinned onto a subset of > RegionServers thus guaranteeing a course level of isolation." > Should be "coarse" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18677) typo in namespace docs
[ https://issues.apache.org/jira/browse/HBASE-18677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChunHao updated HBASE-18677: Attachment: HBASE-18677.master.v0.patch > typo in namespace docs > -- > > Key: HBASE-18677 > URL: https://issues.apache.org/jira/browse/HBASE-18677 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Mike Drob >Assignee: ChunHao >Priority: Trivial > Labels: beginner > Attachments: HBASE-18677.master.v0.patch > > > In the docs at http://hbase.apache.org/book.html#_namespace - "Region server > groups (HBASE-6721) - A namespace/table can be pinned onto a subset of > RegionServers thus guaranteeing a course level of isolation." > Should be "coarse" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[
https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey reopened HBASE-18640:
-
A few problems:
1. This broke the shaded hbase-server module, which exists to provide MapReduce
classes:
{code}
$ mvn -DskipTests -Prelease package
...
$ jar tf
hbase-shaded/hbase-shaded-server/target/hbase-shaded-server-3.0.0-SNAPSHOT.jar
| grep "org/apache/hadoop/hbase/mapred"
org/apache/hadoop/hbase/mapreduce/
org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles$2.class
org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles$3.class
org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles$LoadQueueItem.class
org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles$4.class
org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles$5.class
org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles$1.class
org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles$BulkHFileVisitor.class
org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.class
org/apache/hadoop/hbase/mapreduce/JobUtil.class
{code}
I don't see e.g. {{hbase-shaded-mapreduce}} or other equivalent to those
included prior to the change:
{code}
$ git checkout 664b6be^
...
$ mvn -DskipTests -Prelease package
...
$ jar tf
hbase-shaded/hbase-shaded-server/target/hbase-shaded-server-3.0.0-SNAPSHOT.jar
| grep "org/apache/hadoop/hbase/mapred"
org/apache/hadoop/hbase/mapred/
org/apache/hadoop/hbase/mapred/IdentityTableReduce.class
org/apache/hadoop/hbase/mapred/MultiTableSnapshotInputFormat.class
org/apache/hadoop/hbase/mapred/TableInputFormat.class
org/apache/hadoop/hbase/mapred/TableInputFormatBase.class
org/apache/hadoop/hbase/mapred/TableReduce.class
org/apache/hadoop/hbase/mapred/TableSnapshotInputFormat$TableSnapshotRecordReader.class
org/apache/hadoop/hbase/mapreduce/
org/apache/hadoop/hbase/mapreduce/CellCounter$CellCounterMapper.class
org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver$1.class
org/apache/hadoop/hbase/mapreduce/Export.class
org/apache/hadoop/hbase/mapreduce/HashTable$ResultHasher.class
org/apache/hadoop/hbase/mapreduce/HFileInputFormat$1.class
org/apache/hadoop/hbase/mapreduce/HFileInputFormat.class
org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2$WriterLength.class
org/apache/hadoop/hbase/mapreduce/IdentityTableMapper.class
org/apache/hadoop/hbase/mapreduce/IdentityTableReducer.class
org/apache/hadoop/hbase/mapreduce/Import$KeyValueSortImporter.class
org/apache/hadoop/hbase/mapreduce/ImportTsv$TsvParser$ParsedLine.class
org/apache/hadoop/hbase/mapreduce/JarFinder.class
org/apache/hadoop/hbase/mapreduce/KeyValueSerialization$KeyValueDeserializer.class
org/apache/hadoop/hbase/mapreduce/KeyValueSortReducer.class
org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles$5.class
org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase$1.class
org/apache/hadoop/hbase/mapreduce/MultiTableOutputFormat.class
org/apache/hadoop/hbase/mapreduce/MultiTableSnapshotInputFormat.class
org/apache/hadoop/hbase/mapreduce/MultithreadedTableMapper$1.class
org/apache/hadoop/hbase/mapreduce/MultithreadedTableMapper$MapRunner.class
org/apache/hadoop/hbase/mapreduce/MultithreadedTableMapper$SubMapStatusReporter.class
org/apache/hadoop/hbase/mapreduce/MultithreadedTableMapper.class
org/apache/hadoop/hbase/mapreduce/PutCombiner.class
org/apache/hadoop/hbase/mapreduce/ResultSerialization$1.class
org/apache/hadoop/hbase/mapreduce/ResultSerialization$Result94Deserializer.class
org/apache/hadoop/hbase/mapreduce/RowCounter$RowCounterMapper$Counters.class
org/apache/hadoop/hbase/mapreduce/RowCounter.class
org/apache/hadoop/hbase/mapreduce/SyncTable$SyncMapper$Counter.class
org/apache/hadoop/hbase/mapreduce/TableInputFormatBase$1.class
org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.class
org/apache/hadoop/hbase/mapreduce/TableRecordReader.class
org/apache/hadoop/hbase/mapreduce/TableReducer.class
org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormat$TableSnapshotRegionRecordReader.class
org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl$RecordReader.class
org/apache/hadoop/hbase/mapreduce/TableSplit.class
org/apache/hadoop/hbase/mapreduce/TsvImporterTextMapper.class
org/apache/hadoop/hbase/mapreduce/WALInputFormat$WALRecordReader.class
org/apache/hadoop/hbase/mapreduce/WALPlayer.class
org/apache/hadoop/hbase/mapred/HRegionPartitioner.class
org/apache/hadoop/hbase/mapred/RowCounter$RowCounterMapper$Counters.class
org/apache/hadoop/hbase/mapred/TableMap.class
org/apache/hadoop/hbase/mapred/TableOutputFormat.class
org/apache/hadoop/hbase/mapred/TableRecordReader.class
org/apache/hadoop/hbase/mapred/TableSnapshotInputFormat$TableSnapshotRegionSplit.class
org/apache/hadoop/hbase/mapred/TableSplit.class
org/apache/hadoop/hbase/mapreduce/CellCounter$IntSumReducer.class
org/apache/hadoop/hbase/mapreduce/CopyTable.class
org/apache/hadoop/hbase/mapreduce/HashTable$HashMapper.class
org/apache/hadoop/hbase/mapreduce/HashTable
[jira] [Commented] (HBASE-18306) Get rid of TableDescriptor#getConfiguration
[
https://issues.apache.org/jira/browse/HBASE-18306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143215#comment-16143215
]
Hadoop QA commented on HBASE-18306:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
31m 36s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
25s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 91m 10s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
30s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}143m 37s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestStore |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18306 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883977/HBASE-18306.v0.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux b6a24fbb9ae0 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / a407b58 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8352/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8352/testReport/ |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https:/
[jira] [Commented] (HBASE-18665) ReversedScannerCallable invokes getRegionLocations incorrectly
[
https://issues.apache.org/jira/browse/HBASE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143202#comment-16143202
]
Hadoop QA commented on HBASE-18665:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 13s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
45s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}100m
6s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}159m 49s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18665 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883976/HBASE-18665.master.003.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 8e50792766e5 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / a407b58 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8351/testReport/ |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8351/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> ReversedScannerCalla
[jira] [Commented] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[
https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143190#comment-16143190
]
Hadoop QA commented on HBASE-3935:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
38s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
4s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
11s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
54s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
37s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 32s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
30s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
21s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
33s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}100m
47s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
34s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}185m 9s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364 |
| JIRA Issue | HBASE-3935 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883975/HBASE-3935.branch-2.v4.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile cc
[jira] [Updated] (HBASE-18306) Get rid of TableDescriptor#getConfiguration
[ https://issues.apache.org/jira/browse/HBASE-18306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18306: --- Status: Patch Available (was: Open) > Get rid of TableDescriptor#getConfiguration > --- > > Key: HBASE-18306 > URL: https://issues.apache.org/jira/browse/HBASE-18306 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-18306.v0.patch > > > We should substitute TD#Value for the TD#Configuration. The TD#Configuration > is rarely used in code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18306) Get rid of TableDescriptor#getConfiguration
[ https://issues.apache.org/jira/browse/HBASE-18306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143181#comment-16143181 ] Chia-Ping Tsai edited comment on HBASE-18306 at 8/27/17 6:06 PM: - v0 patch # remove the **config from TableDescriptor # the data of configuration are redirected to values # TableSchema (proto) isn't changed for compatibility. was (Author: chia7712): v0 patch # remove the **config from TableDescriptor # the data of configuration are redirected to values # TableSchema (proto) doesn't be changed for compatibility. > Get rid of TableDescriptor#getConfiguration > --- > > Key: HBASE-18306 > URL: https://issues.apache.org/jira/browse/HBASE-18306 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-18306.v0.patch > > > We should substitute TD#Value for the TD#Configuration. The TD#Configuration > is rarely used in code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18306) Get rid of TableDescriptor#getConfiguration
[ https://issues.apache.org/jira/browse/HBASE-18306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18306: --- Attachment: HBASE-18306.v0.patch v0 patch # remove the **config from TableDescriptor # the data of configuration are redirected to values # TableSchema (proto) doesn't be changed for compatibility. > Get rid of TableDescriptor#getConfiguration > --- > > Key: HBASE-18306 > URL: https://issues.apache.org/jira/browse/HBASE-18306 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-18306.v0.patch > > > We should substitute TD#Value for the TD#Configuration. The TD#Configuration > is rarely used in code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[ https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143171#comment-16143171 ] Hudson commented on HBASE-18611: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3607 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3607/]) HBASE-18611 Copy all tests from o.a.h.h.p.TestProtobufUtil to (chia7712: rev a407b58f17f92ce036b4c021c9a1c7feae39958f) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/shaded/protobuf/TestProtobufUtil.java > Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil > -- > > Key: HBASE-18611 > URL: https://issues.apache.org/jira/browse/HBASE-18611 > Project: HBase > Issue Type: Task > Components: Protobufs, test >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: ChunHao >Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18611.master.v0.patch, > HBASE-18611.master.v1.patch, HBASE-18611.master.v2.patch, > HBASE-18611.master.v3.patch > > > We copied all codes from o.a.h.h.p.ProtobufUtil to o.a.h.h.s.p.ProtobufUtil, > but we ignored the test codes. Let us increase the code coverage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18665) ReversedScannerCallable invokes getRegionLocations incorrectly
[ https://issues.apache.org/jira/browse/HBASE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-18665: -- Attachment: HBASE-18665.master.003.patch > ReversedScannerCallable invokes getRegionLocations incorrectly > -- > > Key: HBASE-18665 > URL: https://issues.apache.org/jira/browse/HBASE-18665 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13 >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Attachments: 18665.master.003.patch, HBASE-18665.branch-1.003.patch, > HBASE-18665.branch-1.003.patch, HBASE-18665.master.001.patch, > HBASE-18665.master.002.patch, HBASE-18665.master.003.patch, > HBASE-18665.master.003.patch > > > The behavior of ReversedScannerCallable#prepare [1] and > ScannerCallable#prepare [2] methods differ how they call > RpcRetryingCallerWithReadReplicas.getRegionLocations method. > The reversed scanner uses the 'reload' parameter directly as the first > argument - RpcRetryingCallerWithReadReplicas.getRegionLocations(reload, id, > getConnection(), getTableName(), getRow()) - however, the forward scanner > passes '!reload'. The getRegionLocations first parameter is 'useCache', the > way we use it in ScannerCallable is the correct one. > The same call can be found in ReversedScannerCallable#locateRegionsInRange > [3] also without negating its value. > [1] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L89-L90 > [2] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java#L139-L140 > [3] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L143-L144 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18665) ReversedScannerCallable invokes getRegionLocations incorrectly
[ https://issues.apache.org/jira/browse/HBASE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143169#comment-16143169 ] Peter Somogyi commented on HBASE-18665: --- Many tests timed out, retying on master. > ReversedScannerCallable invokes getRegionLocations incorrectly > -- > > Key: HBASE-18665 > URL: https://issues.apache.org/jira/browse/HBASE-18665 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13 >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Attachments: 18665.master.003.patch, HBASE-18665.branch-1.003.patch, > HBASE-18665.branch-1.003.patch, HBASE-18665.master.001.patch, > HBASE-18665.master.002.patch, HBASE-18665.master.003.patch, > HBASE-18665.master.003.patch > > > The behavior of ReversedScannerCallable#prepare [1] and > ScannerCallable#prepare [2] methods differ how they call > RpcRetryingCallerWithReadReplicas.getRegionLocations method. > The reversed scanner uses the 'reload' parameter directly as the first > argument - RpcRetryingCallerWithReadReplicas.getRegionLocations(reload, id, > getConnection(), getTableName(), getRow()) - however, the forward scanner > passes '!reload'. The getRegionLocations first parameter is 'useCache', the > way we use it in ScannerCallable is the correct one. > The same call can be found in ReversedScannerCallable#locateRegionsInRange > [3] also without negating its value. > [1] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L89-L90 > [2] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java#L139-L140 > [3] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L143-L144 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18665) ReversedScannerCallable invokes getRegionLocations incorrectly
[
https://issues.apache.org/jira/browse/HBASE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143167#comment-16143167
]
Hadoop QA commented on HBASE-18665:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
33m 48s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
32s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 63m 2s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
48s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}120m 57s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure |
| | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.client.TestMultipleTimestamps |
| | org.apache.hadoop.hbase.client.TestAsyncReplicationAdminApi |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.trace.TestHTraceHooks |
| | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics |
| | org.apache.hadoop.hbase.TestHBaseTestingUtility |
| | org.apache.hadoop.hbase.client.TestAsyncNamespaceAdminApi |
| | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint |
| | org.ap
[jira] [Commented] (HBASE-18682) TestCompactingMemStore#testFlatteningToCellChunkMap fails in master
[
https://issues.apache.org/jira/browse/HBASE-18682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143158#comment-16143158
]
Chia-Ping Tsai commented on HBASE-18682:
Similar error occurs on TestHeapSize.
> TestCompactingMemStore#testFlatteningToCellChunkMap fails in master
> ---
>
> Key: HBASE-18682
> URL: https://issues.apache.org/jira/browse/HBASE-18682
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Chia-Ping Tsai
>Priority: Minor
> Fix For: 2.0.0
>
>
> The UT works well on my centos(64-bits) but it always fails on my
> ubuntu(17.04 64-bits).
> {code}
> Running org.apache.hadoop.hbase.regionserver.TestCompactingMemStore
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.998 sec <<<
> FAILURE! - in org.apache.hadoop.hbase.regionserver.TestCompactingMemStore
> testFlatteningToCellChunkMap(org.apache.hadoop.hbase.regionserver.TestCompactingMemStore)
> Time elapsed: 1.64 sec <<< FAILURE!
> java.lang.AssertionError: expected:<920> but was:<952>
> at
> org.apache.hadoop.hbase.regionserver.TestCompactingMemStore.testFlatteningToCellChunkMap(TestCompactingMemStore.java:609)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18693) adding an option to restore_snapshot to move mob files from archive dir to working dir
[ https://issues.apache.org/jira/browse/HBASE-18693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143157#comment-16143157 ] huaxiang sun commented on HBASE-18693: -- For each mob file, it is expected that fs.move() will be called. Right now, for each mob file, it needs to create two files for HFileLink. So I am expecting that moving files from archive dir to working dir to be as efficient as the current implementation. > adding an option to restore_snapshot to move mob files from archive dir to > working dir > -- > > Key: HBASE-18693 > URL: https://issues.apache.org/jira/browse/HBASE-18693 > Project: HBase > Issue Type: Improvement > Components: mob >Affects Versions: 2.0.0-alpha-2 >Reporter: huaxiang sun >Assignee: huaxiang sun > > Today, there is a single mob region where mob files for all user regions are > saved. There could be many files (one million) in a single mob directory. > When one mob table is restored or cloned from snapshot, links are created for > these mob files. This creates a scaling issue for mob compaction. In mob > compaction's select() logic, for each hFileLink, it needs to call NN's > getFileStatus() to get the size of the linked hfile. Assume that one such > call takes 20ms, 20ms * 100 = 6 hours. > To avoid this overhead, we want to add an option so that restore_snapshot can > move mob files from archive dir to working dir. clone_snapshot is more > complicated as it can clone a snapshot to a different table so moving that > can destroy the snapshot. No option will be added for clone_snapshot. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[ https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Yang updated HBASE-3935: - Status: Patch Available (was: Open) > HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB > -- > > Key: HBASE-3935 > URL: https://issues.apache.org/jira/browse/HBASE-3935 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Andy Yang > Attachments: HBASE-3935.branch-2.v0.patch, > HBASE-3935.branch-2.v1.patch, HBASE-3935.branch-2.v2.patch, > HBASE-3935.branch-2.v3.patch, HBASE-3935.branch-2.v4.patch, > HBASE-3935.master.v0.patch > > > Related to HBASE-3927, Matt proposed changing > HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB so that user can see > the size of small store file index. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[ https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Yang updated HBASE-3935: - Attachment: HBASE-3935.branch-2.v4.patch > HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB > -- > > Key: HBASE-3935 > URL: https://issues.apache.org/jira/browse/HBASE-3935 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Andy Yang > Attachments: HBASE-3935.branch-2.v0.patch, > HBASE-3935.branch-2.v1.patch, HBASE-3935.branch-2.v2.patch, > HBASE-3935.branch-2.v3.patch, HBASE-3935.branch-2.v4.patch, > HBASE-3935.master.v0.patch > > > Related to HBASE-3927, Matt proposed changing > HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB so that user can see > the size of small store file index. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[ https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Yang updated HBASE-3935: - Status: Open (was: Patch Available) > HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB > -- > > Key: HBASE-3935 > URL: https://issues.apache.org/jira/browse/HBASE-3935 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Andy Yang > Attachments: HBASE-3935.branch-2.v0.patch, > HBASE-3935.branch-2.v1.patch, HBASE-3935.branch-2.v2.patch, > HBASE-3935.branch-2.v3.patch, HBASE-3935.branch-2.v4.patch, > HBASE-3935.master.v0.patch > > > Related to HBASE-3927, Matt proposed changing > HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB so that user can see > the size of small store file index. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18691) [compat 1-2] HCD remove and removeConfiguration change return type
[
https://issues.apache.org/jira/browse/HBASE-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143147#comment-16143147
]
Hudson commented on HBASE-18691:
FAILURE: Integrated in Jenkins build HBase-2.0 #406 (See
[https://builds.apache.org/job/HBase-2.0/406/])
HBASE-18691 [compat 1-2] HCD remove and removeConfiguration change (chia7712:
rev 13769ab7c15f2d72224026336fa35cea0ac18cc0)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
> [compat 1-2] HCD remove and removeConfiguration change return type
> --
>
> Key: HBASE-18691
> URL: https://issues.apache.org/jira/browse/HBASE-18691
> Project: HBase
> Issue Type: Sub-task
> Components: API
>Reporter: stack
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18691.v0.patch
>
>
> Change made in HBASE-18008. Asking [~chia7712] if ok to undo.
> Here is complaint from JACC:
> {code}
> hbase-client-1.2.6.jar, HColumnDescriptor.class
> package org.apache.hadoop.hbase
> [−] HColumnDescriptor.remove ( byte[ ] key ) : void 1
> org/apache/hadoop/hbase/HColumnDescriptor.remove:([B)V
> ChangeEffect
> 1 Return value type has been changed from void to HColumnDescriptor.
> This method has been removed because the return type is part of the method
> signature.
> [−] HColumnDescriptor.removeConfiguration ( String key ) : void 1
> org/apache/hadoop/hbase/HColumnDescriptor.removeConfiguration:(Ljava/lang/String;)V
> ChangeEffect
> 1 Return value type has been changed from void to HColumnDescriptor.
> This method has been removed because the return type is part of the method
> signature.
> {code}
> Binary breaking but not src breaking. See
> https://stackoverflow.com/questions/3589946/retrofitting-void-methods-to-return-its-argument-to-facilitate-fluency-breaking
> for good discussion. Probably not a prob. but just in case and if not really
> needed, will purge.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18670) Add .DS_Store to .gitignore
[ https://issues.apache.org/jira/browse/HBASE-18670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143146#comment-16143146 ] Hudson commented on HBASE-18670: FAILURE: Integrated in Jenkins build HBase-2.0 #406 (See [https://builds.apache.org/job/HBase-2.0/406/]) HBASE-18670 Add .DS_Store to .gitignore (chia7712: rev 9919a47b77001b9a86c9a52df9b8ba2651d62396) * (edit) .gitignore > Add .DS_Store to .gitignore > --- > > Key: HBASE-18670 > URL: https://issues.apache.org/jira/browse/HBASE-18670 > Project: HBase > Issue Type: Task > Components: community >Reporter: Chia-Ping Tsai >Assignee: Deon Huang >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18670.branch-1.2.v0.patch, > HBASE-18670.branch-1.3.v0.patch, HBASE-18670.branch-1.4.v0.patch, > HBASE-18670.branch-1.v0.patch, HBASE-18670.branch-2.v0.patch > > > Stop letting .DS_Store mess up our commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[ https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143148#comment-16143148 ] Hudson commented on HBASE-18611: FAILURE: Integrated in Jenkins build HBase-2.0 #406 (See [https://builds.apache.org/job/HBase-2.0/406/]) HBASE-18611 Copy all tests from o.a.h.h.p.TestProtobufUtil to (chia7712: rev e07ff0452fdb81c20721cd1de4f1419c40b8d14c) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/shaded/protobuf/TestProtobufUtil.java > Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil > -- > > Key: HBASE-18611 > URL: https://issues.apache.org/jira/browse/HBASE-18611 > Project: HBase > Issue Type: Task > Components: Protobufs, test >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: ChunHao >Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18611.master.v0.patch, > HBASE-18611.master.v1.patch, HBASE-18611.master.v2.patch, > HBASE-18611.master.v3.patch > > > We copied all codes from o.a.h.h.p.ProtobufUtil to o.a.h.h.s.p.ProtobufUtil, > but we ignored the test codes. Let us increase the code coverage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18665) ReversedScannerCallable invokes getRegionLocations incorrectly
[ https://issues.apache.org/jira/browse/HBASE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143145#comment-16143145 ] Peter Somogyi commented on HBASE-18665: --- I also ran the tests locally and passed for me too. > ReversedScannerCallable invokes getRegionLocations incorrectly > -- > > Key: HBASE-18665 > URL: https://issues.apache.org/jira/browse/HBASE-18665 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13 >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Attachments: 18665.master.003.patch, HBASE-18665.branch-1.003.patch, > HBASE-18665.branch-1.003.patch, HBASE-18665.master.001.patch, > HBASE-18665.master.002.patch, HBASE-18665.master.003.patch > > > The behavior of ReversedScannerCallable#prepare [1] and > ScannerCallable#prepare [2] methods differ how they call > RpcRetryingCallerWithReadReplicas.getRegionLocations method. > The reversed scanner uses the 'reload' parameter directly as the first > argument - RpcRetryingCallerWithReadReplicas.getRegionLocations(reload, id, > getConnection(), getTableName(), getRow()) - however, the forward scanner > passes '!reload'. The getRegionLocations first parameter is 'useCache', the > way we use it in ScannerCallable is the correct one. > The same call can be found in ReversedScannerCallable#locateRegionsInRange > [3] also without negating its value. > [1] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L89-L90 > [2] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java#L139-L140 > [3] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L143-L144 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[ https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142796#comment-16142796 ] Andy Yang edited comment on HBASE-3935 at 8/27/17 3:23 PM: --- [~chia7712] , thank for the feedback. was (Author: andy7904): [~chia7712] , thanks for the feedback. > HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB > -- > > Key: HBASE-3935 > URL: https://issues.apache.org/jira/browse/HBASE-3935 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Andy Yang > Attachments: HBASE-3935.branch-2.v0.patch, > HBASE-3935.branch-2.v1.patch, HBASE-3935.branch-2.v2.patch, > HBASE-3935.branch-2.v3.patch, HBASE-3935.master.v0.patch > > > Related to HBASE-3927, Matt proposed changing > HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB so that user can see > the size of small store file index. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18519) Use builder pattern to create cell
[
https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143137#comment-16143137
]
Hadoop QA commented on HBASE-18519:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
30s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 57s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
26s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
44s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}104m 32s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
1s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
57s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}174m 33s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | org.apache.hadoop.hbase.TestZooKeeper |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18519 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883970/HBASE-18519.v5.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 683b3f33ae0b 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / a407b58 |
| Default Java | 1.8.0_144 |
| findbugs |
[jira] [Commented] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[ https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143136#comment-16143136 ] Andy Yang commented on HBASE-3935: -- [~tedyu] , thank for the advice. > HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB > -- > > Key: HBASE-3935 > URL: https://issues.apache.org/jira/browse/HBASE-3935 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Andy Yang > Attachments: HBASE-3935.branch-2.v0.patch, > HBASE-3935.branch-2.v1.patch, HBASE-3935.branch-2.v2.patch, > HBASE-3935.branch-2.v3.patch, HBASE-3935.master.v0.patch > > > Related to HBASE-3927, Matt proposed changing > HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB so that user can see > the size of small store file index. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18665) ReversedScannerCallable invokes getRegionLocations incorrectly
[ https://issues.apache.org/jira/browse/HBASE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143131#comment-16143131 ] Ted Yu commented on HBASE-18665: I ran TestVisibilityLabelsWithACL,TestTableSnapshotInputFormat and TestSerialReplication based on branch-1 patch which passed. The other tests are flaky. +1 from me. > ReversedScannerCallable invokes getRegionLocations incorrectly > -- > > Key: HBASE-18665 > URL: https://issues.apache.org/jira/browse/HBASE-18665 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13 >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Attachments: 18665.master.003.patch, HBASE-18665.branch-1.003.patch, > HBASE-18665.branch-1.003.patch, HBASE-18665.master.001.patch, > HBASE-18665.master.002.patch, HBASE-18665.master.003.patch > > > The behavior of ReversedScannerCallable#prepare [1] and > ScannerCallable#prepare [2] methods differ how they call > RpcRetryingCallerWithReadReplicas.getRegionLocations method. > The reversed scanner uses the 'reload' parameter directly as the first > argument - RpcRetryingCallerWithReadReplicas.getRegionLocations(reload, id, > getConnection(), getTableName(), getRow()) - however, the forward scanner > passes '!reload'. The getRegionLocations first parameter is 'useCache', the > way we use it in ScannerCallable is the correct one. > The same call can be found in ReversedScannerCallable#locateRegionsInRange > [3] also without negating its value. > [1] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L89-L90 > [2] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java#L139-L140 > [3] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L143-L144 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18665) ReversedScannerCallable invokes getRegionLocations incorrectly
[ https://issues.apache.org/jira/browse/HBASE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-18665: --- Attachment: 18665.master.003.patch Re-attaching patch for master branch. > ReversedScannerCallable invokes getRegionLocations incorrectly > -- > > Key: HBASE-18665 > URL: https://issues.apache.org/jira/browse/HBASE-18665 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13 >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Attachments: 18665.master.003.patch, HBASE-18665.branch-1.003.patch, > HBASE-18665.branch-1.003.patch, HBASE-18665.master.001.patch, > HBASE-18665.master.002.patch, HBASE-18665.master.003.patch > > > The behavior of ReversedScannerCallable#prepare [1] and > ScannerCallable#prepare [2] methods differ how they call > RpcRetryingCallerWithReadReplicas.getRegionLocations method. > The reversed scanner uses the 'reload' parameter directly as the first > argument - RpcRetryingCallerWithReadReplicas.getRegionLocations(reload, id, > getConnection(), getTableName(), getRow()) - however, the forward scanner > passes '!reload'. The getRegionLocations first parameter is 'useCache', the > way we use it in ScannerCallable is the correct one. > The same call can be found in ReversedScannerCallable#locateRegionsInRange > [3] also without negating its value. > [1] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L89-L90 > [2] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java#L139-L140 > [3] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L143-L144 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[ https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143127#comment-16143127 ] Ted Yu commented on HBASE-3935: --- bq. ServerLoad#getStorefileSizeInMB return ServerLoad#getStorefileIndexSizeKB / 1024 We can achieve the same result by using right shift. > HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB > -- > > Key: HBASE-3935 > URL: https://issues.apache.org/jira/browse/HBASE-3935 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Andy Yang > Attachments: HBASE-3935.branch-2.v0.patch, > HBASE-3935.branch-2.v1.patch, HBASE-3935.branch-2.v2.patch, > HBASE-3935.branch-2.v3.patch, HBASE-3935.master.v0.patch > > > Related to HBASE-3927, Matt proposed changing > HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB so that user can see > the size of small store file index. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[
https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143125#comment-16143125
]
Hadoop QA commented on HBASE-3935:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
14s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
35s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
14s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m
29s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
45s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 0s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
28s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
16s{color} | {color:red} hbase-rest generated 1 new + 0 unchanged - 0 fixed = 1
total (was 0) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
18s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
31s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 93m
44s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
42s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}177m 0s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364 |
| JIRA Issue | HBASE-3935 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883969/HBASE-3935.branch-2.
[jira] [Commented] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[ https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143123#comment-16143123 ] Ted Yu commented on HBASE-3935: --- Please fix failed tests. Thanks > HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB > -- > > Key: HBASE-3935 > URL: https://issues.apache.org/jira/browse/HBASE-3935 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Andy Yang > Attachments: HBASE-3935.branch-2.v0.patch, > HBASE-3935.branch-2.v1.patch, HBASE-3935.branch-2.v2.patch, > HBASE-3935.branch-2.v3.patch, HBASE-3935.master.v0.patch > > > Related to HBASE-3927, Matt proposed changing > HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB so that user can see > the size of small store file index. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18691) [compat 1-2] HCD remove and removeConfiguration change return type
[
https://issues.apache.org/jira/browse/HBASE-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143116#comment-16143116
]
Hudson commented on HBASE-18691:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3606 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3606/])
HBASE-18691 [compat 1-2] HCD remove and removeConfiguration change (chia7712:
rev 8f290c35b7259820de4a7c04256e74a3c3b6e056)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
> [compat 1-2] HCD remove and removeConfiguration change return type
> --
>
> Key: HBASE-18691
> URL: https://issues.apache.org/jira/browse/HBASE-18691
> Project: HBase
> Issue Type: Sub-task
> Components: API
>Reporter: stack
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18691.v0.patch
>
>
> Change made in HBASE-18008. Asking [~chia7712] if ok to undo.
> Here is complaint from JACC:
> {code}
> hbase-client-1.2.6.jar, HColumnDescriptor.class
> package org.apache.hadoop.hbase
> [−] HColumnDescriptor.remove ( byte[ ] key ) : void 1
> org/apache/hadoop/hbase/HColumnDescriptor.remove:([B)V
> ChangeEffect
> 1 Return value type has been changed from void to HColumnDescriptor.
> This method has been removed because the return type is part of the method
> signature.
> [−] HColumnDescriptor.removeConfiguration ( String key ) : void 1
> org/apache/hadoop/hbase/HColumnDescriptor.removeConfiguration:(Ljava/lang/String;)V
> ChangeEffect
> 1 Return value type has been changed from void to HColumnDescriptor.
> This method has been removed because the return type is part of the method
> signature.
> {code}
> Binary breaking but not src breaking. See
> https://stackoverflow.com/questions/3589946/retrofitting-void-methods-to-return-its-argument-to-facilitate-fluency-breaking
> for good discussion. Probably not a prob. but just in case and if not really
> needed, will purge.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18670) Add .DS_Store to .gitignore
[ https://issues.apache.org/jira/browse/HBASE-18670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143115#comment-16143115 ] Hudson commented on HBASE-18670: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3606 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3606/]) HBASE-18670 Add .DS_Store to .gitignore (chia7712: rev 483c42a7561f3f21dc8a9706ad6d8964c07ccf5b) * (edit) .gitignore > Add .DS_Store to .gitignore > --- > > Key: HBASE-18670 > URL: https://issues.apache.org/jira/browse/HBASE-18670 > Project: HBase > Issue Type: Task > Components: community >Reporter: Chia-Ping Tsai >Assignee: Deon Huang >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18670.branch-1.2.v0.patch, > HBASE-18670.branch-1.3.v0.patch, HBASE-18670.branch-1.4.v0.patch, > HBASE-18670.branch-1.v0.patch, HBASE-18670.branch-2.v0.patch > > > Stop letting .DS_Store mess up our commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18670) Add .DS_Store to .gitignore
[ https://issues.apache.org/jira/browse/HBASE-18670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143113#comment-16143113 ] Hudson commented on HBASE-18670: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #201 (See [https://builds.apache.org/job/HBase-1.2-JDK8/201/]) HBASE-18670 Add .DS_Store to .gitignore (chia7712: rev 6624e64e1ae36f87e3b84c66da743be44f29acad) * (edit) .gitignore > Add .DS_Store to .gitignore > --- > > Key: HBASE-18670 > URL: https://issues.apache.org/jira/browse/HBASE-18670 > Project: HBase > Issue Type: Task > Components: community >Reporter: Chia-Ping Tsai >Assignee: Deon Huang >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18670.branch-1.2.v0.patch, > HBASE-18670.branch-1.3.v0.patch, HBASE-18670.branch-1.4.v0.patch, > HBASE-18670.branch-1.v0.patch, HBASE-18670.branch-2.v0.patch > > > Stop letting .DS_Store mess up our commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18670) Add .DS_Store to .gitignore
[ https://issues.apache.org/jira/browse/HBASE-18670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143105#comment-16143105 ] Hudson commented on HBASE-18670: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #266 (See [https://builds.apache.org/job/HBase-1.3-JDK8/266/]) HBASE-18670 Add .DS_Store to .gitignore (chia7712: rev 2f769c0ca87d2b01b9a17866eefd8c559177eed1) * (edit) .gitignore > Add .DS_Store to .gitignore > --- > > Key: HBASE-18670 > URL: https://issues.apache.org/jira/browse/HBASE-18670 > Project: HBase > Issue Type: Task > Components: community >Reporter: Chia-Ping Tsai >Assignee: Deon Huang >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18670.branch-1.2.v0.patch, > HBASE-18670.branch-1.3.v0.patch, HBASE-18670.branch-1.4.v0.patch, > HBASE-18670.branch-1.v0.patch, HBASE-18670.branch-2.v0.patch > > > Stop letting .DS_Store mess up our commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18670) Add .DS_Store to .gitignore
[ https://issues.apache.org/jira/browse/HBASE-18670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143102#comment-16143102 ] Hudson commented on HBASE-18670: FAILURE: Integrated in Jenkins build HBase-1.5 #34 (See [https://builds.apache.org/job/HBase-1.5/34/]) HBASE-18670 Add .DS_Store to .gitignore (chia7712: rev dbe60e3856b48b7ee57b2f7d4f1eebc2665269e6) * (edit) .gitignore > Add .DS_Store to .gitignore > --- > > Key: HBASE-18670 > URL: https://issues.apache.org/jira/browse/HBASE-18670 > Project: HBase > Issue Type: Task > Components: community >Reporter: Chia-Ping Tsai >Assignee: Deon Huang >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18670.branch-1.2.v0.patch, > HBASE-18670.branch-1.3.v0.patch, HBASE-18670.branch-1.4.v0.patch, > HBASE-18670.branch-1.v0.patch, HBASE-18670.branch-2.v0.patch > > > Stop letting .DS_Store mess up our commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18670) Add .DS_Store to .gitignore
[ https://issues.apache.org/jira/browse/HBASE-18670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143097#comment-16143097 ] Hudson commented on HBASE-18670: FAILURE: Integrated in Jenkins build HBase-1.4 #888 (See [https://builds.apache.org/job/HBase-1.4/888/]) HBASE-18670 Add .DS_Store to .gitignore (chia7712: rev 3f07a71277f306319f70060be5f547b383eb967f) * (edit) .gitignore > Add .DS_Store to .gitignore > --- > > Key: HBASE-18670 > URL: https://issues.apache.org/jira/browse/HBASE-18670 > Project: HBase > Issue Type: Task > Components: community >Reporter: Chia-Ping Tsai >Assignee: Deon Huang >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18670.branch-1.2.v0.patch, > HBASE-18670.branch-1.3.v0.patch, HBASE-18670.branch-1.4.v0.patch, > HBASE-18670.branch-1.v0.patch, HBASE-18670.branch-2.v0.patch > > > Stop letting .DS_Store mess up our commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18519) Use builder pattern to create cell
[ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18519: --- Status: Patch Available (was: Open) > Use builder pattern to create cell > -- > > Key: HBASE-18519 > URL: https://issues.apache.org/jira/browse/HBASE-18519 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, > HBASE-18519.v2.patch, HBASE-18519.v3.patch, HBASE-18519.v4.patch, > HBASE-18519.v5.patch > > > The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the > input arguments without copying. We can substitute IndividualBytesFieldCell > for CellUtil.createCell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18519) Use builder pattern to create cell
[ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18519: --- Attachment: HBASE-18519.v5.patch v5 patch # add docs for CellBuilderFactory # remove #create(Configuration, CellBuilderType) > Use builder pattern to create cell > -- > > Key: HBASE-18519 > URL: https://issues.apache.org/jira/browse/HBASE-18519 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, > HBASE-18519.v2.patch, HBASE-18519.v3.patch, HBASE-18519.v4.patch, > HBASE-18519.v5.patch > > > The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the > input arguments without copying. We can substitute IndividualBytesFieldCell > for CellUtil.createCell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18519) Use builder pattern to create cell
[ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18519: --- Status: Open (was: Patch Available) > Use builder pattern to create cell > -- > > Key: HBASE-18519 > URL: https://issues.apache.org/jira/browse/HBASE-18519 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, > HBASE-18519.v2.patch, HBASE-18519.v3.patch, HBASE-18519.v4.patch > > > The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the > input arguments without copying. We can substitute IndividualBytesFieldCell > for CellUtil.createCell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[ https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Yang updated HBASE-3935: - Attachment: HBASE-3935.branch-2.v3.patch > HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB > -- > > Key: HBASE-3935 > URL: https://issues.apache.org/jira/browse/HBASE-3935 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Andy Yang > Attachments: HBASE-3935.branch-2.v0.patch, > HBASE-3935.branch-2.v1.patch, HBASE-3935.branch-2.v2.patch, > HBASE-3935.branch-2.v3.patch, HBASE-3935.master.v0.patch > > > Related to HBASE-3927, Matt proposed changing > HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB so that user can see > the size of small store file index. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[ https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Yang updated HBASE-3935: - Status: Patch Available (was: Open) > HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB > -- > > Key: HBASE-3935 > URL: https://issues.apache.org/jira/browse/HBASE-3935 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Andy Yang > Attachments: HBASE-3935.branch-2.v0.patch, > HBASE-3935.branch-2.v1.patch, HBASE-3935.branch-2.v2.patch, > HBASE-3935.branch-2.v3.patch, HBASE-3935.master.v0.patch > > > Related to HBASE-3927, Matt proposed changing > HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB so that user can see > the size of small store file index. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[ https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Yang updated HBASE-3935: - Status: Open (was: Patch Available) > HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB > -- > > Key: HBASE-3935 > URL: https://issues.apache.org/jira/browse/HBASE-3935 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Andy Yang > Attachments: HBASE-3935.branch-2.v0.patch, > HBASE-3935.branch-2.v1.patch, HBASE-3935.branch-2.v2.patch, > HBASE-3935.branch-2.v3.patch, HBASE-3935.master.v0.patch > > > Related to HBASE-3927, Matt proposed changing > HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB so that user can see > the size of small store file index. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[ https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18611: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks for the patch. [~chunhao] > Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil > -- > > Key: HBASE-18611 > URL: https://issues.apache.org/jira/browse/HBASE-18611 > Project: HBase > Issue Type: Task > Components: Protobufs, test >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: ChunHao >Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18611.master.v0.patch, > HBASE-18611.master.v1.patch, HBASE-18611.master.v2.patch, > HBASE-18611.master.v3.patch > > > We copied all codes from o.a.h.h.p.ProtobufUtil to o.a.h.h.s.p.ProtobufUtil, > but we ignored the test codes. Let us increase the code coverage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18670) Add .DS_Store to .gitignore
[ https://issues.apache.org/jira/browse/HBASE-18670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143079#comment-16143079 ] Hudson commented on HBASE-18670: SUCCESS: Integrated in Jenkins build HBase-1.2-IT #942 (See [https://builds.apache.org/job/HBase-1.2-IT/942/]) HBASE-18670 Add .DS_Store to .gitignore (chia7712: rev 6624e64e1ae36f87e3b84c66da743be44f29acad) * (edit) .gitignore > Add .DS_Store to .gitignore > --- > > Key: HBASE-18670 > URL: https://issues.apache.org/jira/browse/HBASE-18670 > Project: HBase > Issue Type: Task > Components: community >Reporter: Chia-Ping Tsai >Assignee: Deon Huang >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18670.branch-1.2.v0.patch, > HBASE-18670.branch-1.3.v0.patch, HBASE-18670.branch-1.4.v0.patch, > HBASE-18670.branch-1.v0.patch, HBASE-18670.branch-2.v0.patch > > > Stop letting .DS_Store mess up our commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18519) Use builder pattern to create cell
[ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143049#comment-16143049 ] Chia-Ping Tsai edited comment on HBASE-18519 at 8/27/17 11:14 AM: -- [~stack] Can we undo the configured way ? As Anoop was just saying in RB, users can create cell builder on their own. Also, there is no use case for configuring the extended cell builder internally. was (Author: chia7712): [~stack] Can we undo the configured way ? As anoop's comment in RB, users can create cell builder on their own. Also, there is no use case for configuring the extended cell builder internally. > Use builder pattern to create cell > -- > > Key: HBASE-18519 > URL: https://issues.apache.org/jira/browse/HBASE-18519 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, > HBASE-18519.v2.patch, HBASE-18519.v3.patch, HBASE-18519.v4.patch > > > The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the > input arguments without copying. We can substitute IndividualBytesFieldCell > for CellUtil.createCell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18670) Add .DS_Store to .gitignore
[ https://issues.apache.org/jira/browse/HBASE-18670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143078#comment-16143078 ] Hudson commented on HBASE-18670: FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #206 (See [https://builds.apache.org/job/HBase-1.2-JDK7/206/]) HBASE-18670 Add .DS_Store to .gitignore (chia7712: rev 6624e64e1ae36f87e3b84c66da743be44f29acad) * (edit) .gitignore > Add .DS_Store to .gitignore > --- > > Key: HBASE-18670 > URL: https://issues.apache.org/jira/browse/HBASE-18670 > Project: HBase > Issue Type: Task > Components: community >Reporter: Chia-Ping Tsai >Assignee: Deon Huang >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18670.branch-1.2.v0.patch, > HBASE-18670.branch-1.3.v0.patch, HBASE-18670.branch-1.4.v0.patch, > HBASE-18670.branch-1.v0.patch, HBASE-18670.branch-2.v0.patch > > > Stop letting .DS_Store mess up our commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18670) Add .DS_Store to .gitignore
[ https://issues.apache.org/jira/browse/HBASE-18670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143077#comment-16143077 ] Hudson commented on HBASE-18670: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #189 (See [https://builds.apache.org/job/HBase-1.3-IT/189/]) HBASE-18670 Add .DS_Store to .gitignore (chia7712: rev 2f769c0ca87d2b01b9a17866eefd8c559177eed1) * (edit) .gitignore > Add .DS_Store to .gitignore > --- > > Key: HBASE-18670 > URL: https://issues.apache.org/jira/browse/HBASE-18670 > Project: HBase > Issue Type: Task > Components: community >Reporter: Chia-Ping Tsai >Assignee: Deon Huang >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18670.branch-1.2.v0.patch, > HBASE-18670.branch-1.3.v0.patch, HBASE-18670.branch-1.4.v0.patch, > HBASE-18670.branch-1.v0.patch, HBASE-18670.branch-2.v0.patch > > > Stop letting .DS_Store mess up our commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18670) Add .DS_Store to .gitignore
[ https://issues.apache.org/jira/browse/HBASE-18670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143076#comment-16143076 ] Hudson commented on HBASE-18670: FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #256 (See [https://builds.apache.org/job/HBase-1.3-JDK7/256/]) HBASE-18670 Add .DS_Store to .gitignore (chia7712: rev 2f769c0ca87d2b01b9a17866eefd8c559177eed1) * (edit) .gitignore > Add .DS_Store to .gitignore > --- > > Key: HBASE-18670 > URL: https://issues.apache.org/jira/browse/HBASE-18670 > Project: HBase > Issue Type: Task > Components: community >Reporter: Chia-Ping Tsai >Assignee: Deon Huang >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18670.branch-1.2.v0.patch, > HBASE-18670.branch-1.3.v0.patch, HBASE-18670.branch-1.4.v0.patch, > HBASE-18670.branch-1.v0.patch, HBASE-18670.branch-2.v0.patch > > > Stop letting .DS_Store mess up our commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18691) [compat 1-2] HCD remove and removeConfiguration change return type
[
https://issues.apache.org/jira/browse/HBASE-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18691:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Push to master and branch-2
> [compat 1-2] HCD remove and removeConfiguration change return type
> --
>
> Key: HBASE-18691
> URL: https://issues.apache.org/jira/browse/HBASE-18691
> Project: HBase
> Issue Type: Sub-task
> Components: API
>Reporter: stack
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18691.v0.patch
>
>
> Change made in HBASE-18008. Asking [~chia7712] if ok to undo.
> Here is complaint from JACC:
> {code}
> hbase-client-1.2.6.jar, HColumnDescriptor.class
> package org.apache.hadoop.hbase
> [−] HColumnDescriptor.remove ( byte[ ] key ) : void 1
> org/apache/hadoop/hbase/HColumnDescriptor.remove:([B)V
> ChangeEffect
> 1 Return value type has been changed from void to HColumnDescriptor.
> This method has been removed because the return type is part of the method
> signature.
> [−] HColumnDescriptor.removeConfiguration ( String key ) : void 1
> org/apache/hadoop/hbase/HColumnDescriptor.removeConfiguration:(Ljava/lang/String;)V
> ChangeEffect
> 1 Return value type has been changed from void to HColumnDescriptor.
> This method has been removed because the return type is part of the method
> signature.
> {code}
> Binary breaking but not src breaking. See
> https://stackoverflow.com/questions/3589946/retrofitting-void-methods-to-return-its-argument-to-facilitate-fluency-breaking
> for good discussion. Probably not a prob. but just in case and if not really
> needed, will purge.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18670) Add .DS_Store to .gitignore
[ https://issues.apache.org/jira/browse/HBASE-18670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18670: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks for the patch. [~deonashh] > Add .DS_Store to .gitignore > --- > > Key: HBASE-18670 > URL: https://issues.apache.org/jira/browse/HBASE-18670 > Project: HBase > Issue Type: Task > Components: community >Reporter: Chia-Ping Tsai >Assignee: Deon Huang >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18670.branch-1.2.v0.patch, > HBASE-18670.branch-1.3.v0.patch, HBASE-18670.branch-1.4.v0.patch, > HBASE-18670.branch-1.v0.patch, HBASE-18670.branch-2.v0.patch > > > Stop letting .DS_Store mess up our commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18670) Add .DS_Store to .gitignore
[ https://issues.apache.org/jira/browse/HBASE-18670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143068#comment-16143068 ] Chia-Ping Tsai commented on HBASE-18670: You are right. +1 > Add .DS_Store to .gitignore > --- > > Key: HBASE-18670 > URL: https://issues.apache.org/jira/browse/HBASE-18670 > Project: HBase > Issue Type: Task > Components: community >Reporter: Chia-Ping Tsai >Assignee: Deon Huang >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18670.branch-1.2.v0.patch, > HBASE-18670.branch-1.3.v0.patch, HBASE-18670.branch-1.4.v0.patch, > HBASE-18670.branch-1.v0.patch, HBASE-18670.branch-2.v0.patch > > > Stop letting .DS_Store mess up our commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18670) Add .DS_Store to .gitignore
[ https://issues.apache.org/jira/browse/HBASE-18670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143067#comment-16143067 ] Deon Huang commented on HBASE-18670: Do you mean we should use **/.DS_Store instead of .DS_Store? I can do that. But I just check Hadoop, Spark, NiFi they all use .DS_Store only. Seems has same result, should we follow them? > Add .DS_Store to .gitignore > --- > > Key: HBASE-18670 > URL: https://issues.apache.org/jira/browse/HBASE-18670 > Project: HBase > Issue Type: Task > Components: community >Reporter: Chia-Ping Tsai >Assignee: Deon Huang >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18670.branch-1.2.v0.patch, > HBASE-18670.branch-1.3.v0.patch, HBASE-18670.branch-1.4.v0.patch, > HBASE-18670.branch-1.v0.patch, HBASE-18670.branch-2.v0.patch > > > Stop letting .DS_Store mess up our commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18375) The pool chunks from ChunkCreator are deallocated while in pool because there is no reference to them
[
https://issues.apache.org/jira/browse/HBASE-18375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143052#comment-16143052
]
Hadoop QA commented on HBASE-18375:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
33s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
13s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
31m 27s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 88m
0s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}133m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364 |
| JIRA Issue | HBASE-18375 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883966/HBASE-18375-branch-2.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 39aa2a167465 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-2 / 6db3d81 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8346/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8346/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> The pool chunks from ChunkCreator are deallocated while in pool because there
> is no reference to them
> -
>
> Key: HBASE-18375
> URL: https://issues.apache.org/jira/browse/HBASE-18375
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-1
>Reporter: Anastas
[jira] [Commented] (HBASE-18693) adding an option to restore_snapshot to move mob files from archive dir to working dir
[ https://issues.apache.org/jira/browse/HBASE-18693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143051#comment-16143051 ] Anoop Sam John commented on HBASE-18693: bq. we want to add an option so that restore_snapshot can move mob files from archive dir to working dir How efficient this op will be? I assume this wont include actual data move but just rename ops. What if a million files under the MOB region? > adding an option to restore_snapshot to move mob files from archive dir to > working dir > -- > > Key: HBASE-18693 > URL: https://issues.apache.org/jira/browse/HBASE-18693 > Project: HBase > Issue Type: Improvement > Components: mob >Affects Versions: 2.0.0-alpha-2 >Reporter: huaxiang sun >Assignee: huaxiang sun > > Today, there is a single mob region where mob files for all user regions are > saved. There could be many files (one million) in a single mob directory. > When one mob table is restored or cloned from snapshot, links are created for > these mob files. This creates a scaling issue for mob compaction. In mob > compaction's select() logic, for each hFileLink, it needs to call NN's > getFileStatus() to get the size of the linked hfile. Assume that one such > call takes 20ms, 20ms * 100 = 6 hours. > To avoid this overhead, we want to add an option so that restore_snapshot can > move mob files from archive dir to working dir. clone_snapshot is more > complicated as it can clone a snapshot to a different table so moving that > can destroy the snapshot. No option will be added for clone_snapshot. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18691) [compat 1-2] HCD remove and removeConfiguration change return type
[
https://issues.apache.org/jira/browse/HBASE-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143050#comment-16143050
]
Chia-Ping Tsai commented on HBASE-18691:
Will commit it later. Thanks for the reviews [~anoop.hbase]
> [compat 1-2] HCD remove and removeConfiguration change return type
> --
>
> Key: HBASE-18691
> URL: https://issues.apache.org/jira/browse/HBASE-18691
> Project: HBase
> Issue Type: Sub-task
> Components: API
>Reporter: stack
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18691.v0.patch
>
>
> Change made in HBASE-18008. Asking [~chia7712] if ok to undo.
> Here is complaint from JACC:
> {code}
> hbase-client-1.2.6.jar, HColumnDescriptor.class
> package org.apache.hadoop.hbase
> [−] HColumnDescriptor.remove ( byte[ ] key ) : void 1
> org/apache/hadoop/hbase/HColumnDescriptor.remove:([B)V
> ChangeEffect
> 1 Return value type has been changed from void to HColumnDescriptor.
> This method has been removed because the return type is part of the method
> signature.
> [−] HColumnDescriptor.removeConfiguration ( String key ) : void 1
> org/apache/hadoop/hbase/HColumnDescriptor.removeConfiguration:(Ljava/lang/String;)V
> ChangeEffect
> 1 Return value type has been changed from void to HColumnDescriptor.
> This method has been removed because the return type is part of the method
> signature.
> {code}
> Binary breaking but not src breaking. See
> https://stackoverflow.com/questions/3589946/retrofitting-void-methods-to-return-its-argument-to-facilitate-fluency-breaking
> for good discussion. Probably not a prob. but just in case and if not really
> needed, will purge.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18519) Use builder pattern to create cell
[ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143049#comment-16143049 ] Chia-Ping Tsai commented on HBASE-18519: [~stack] Can we undo the configured way ? As anoop's comment in RB, users can create cell builder on their own. Also, there is no use case for configuring the extended cell builder internally. > Use builder pattern to create cell > -- > > Key: HBASE-18519 > URL: https://issues.apache.org/jira/browse/HBASE-18519 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, > HBASE-18519.v2.patch, HBASE-18519.v3.patch, HBASE-18519.v4.patch > > > The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the > input arguments without copying. We can substitute IndividualBytesFieldCell > for CellUtil.createCell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18692) [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int
[ https://issues.apache.org/jira/browse/HBASE-18692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143047#comment-16143047 ] Anoop Sam John commented on HBASE-18692: Return value seems not used at all by calling places. We can easily revert this change. > [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int > - > > Key: HBASE-18692 > URL: https://issues.apache.org/jira/browse/HBASE-18692 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack > Fix For: 2.0.0-alpha-3 > > > [~ram_krish] You need this change? BBUtils was public back in 1.0 and > ByteBufferUtils.copyFromBufferToBuffer > returned a void. HBASE-12213 HFileBlock backed by Array of ByteBuffers (Ram) > changed it to return an int. You think we need this? I can try undoing it. > Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18691) [compat 1-2] HCD remove and removeConfiguration change return type
[
https://issues.apache.org/jira/browse/HBASE-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143046#comment-16143046
]
Anoop Sam John commented on HBASE-18691:
+1
> [compat 1-2] HCD remove and removeConfiguration change return type
> --
>
> Key: HBASE-18691
> URL: https://issues.apache.org/jira/browse/HBASE-18691
> Project: HBase
> Issue Type: Sub-task
> Components: API
>Reporter: stack
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18691.v0.patch
>
>
> Change made in HBASE-18008. Asking [~chia7712] if ok to undo.
> Here is complaint from JACC:
> {code}
> hbase-client-1.2.6.jar, HColumnDescriptor.class
> package org.apache.hadoop.hbase
> [−] HColumnDescriptor.remove ( byte[ ] key ) : void 1
> org/apache/hadoop/hbase/HColumnDescriptor.remove:([B)V
> ChangeEffect
> 1 Return value type has been changed from void to HColumnDescriptor.
> This method has been removed because the return type is part of the method
> signature.
> [−] HColumnDescriptor.removeConfiguration ( String key ) : void 1
> org/apache/hadoop/hbase/HColumnDescriptor.removeConfiguration:(Ljava/lang/String;)V
> ChangeEffect
> 1 Return value type has been changed from void to HColumnDescriptor.
> This method has been removed because the return type is part of the method
> signature.
> {code}
> Binary breaking but not src breaking. See
> https://stackoverflow.com/questions/3589946/retrofitting-void-methods-to-return-its-argument-to-facilitate-fluency-breaking
> for good discussion. Probably not a prob. but just in case and if not really
> needed, will purge.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18682) TestCompactingMemStore#testFlatteningToCellChunkMap fails in master
[
https://issues.apache.org/jira/browse/HBASE-18682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143044#comment-16143044
]
Chia-Ping Tsai commented on HBASE-18682:
bq. I will not be in the office this week, so if it can wait till next week, I
can try to (anyhow remotely) look on this problem then. Or may be you can try
to debug it if it is urgent...
Got it. It is not urgent. We can deal with it later. Thanks.
> TestCompactingMemStore#testFlatteningToCellChunkMap fails in master
> ---
>
> Key: HBASE-18682
> URL: https://issues.apache.org/jira/browse/HBASE-18682
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Chia-Ping Tsai
>Priority: Minor
> Fix For: 2.0.0
>
>
> The UT works well on my centos(64-bits) but it always fails on my
> ubuntu(17.04 64-bits).
> {code}
> Running org.apache.hadoop.hbase.regionserver.TestCompactingMemStore
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.998 sec <<<
> FAILURE! - in org.apache.hadoop.hbase.regionserver.TestCompactingMemStore
> testFlatteningToCellChunkMap(org.apache.hadoop.hbase.regionserver.TestCompactingMemStore)
> Time elapsed: 1.64 sec <<< FAILURE!
> java.lang.AssertionError: expected:<920> but was:<952>
> at
> org.apache.hadoop.hbase.regionserver.TestCompactingMemStore.testFlatteningToCellChunkMap(TestCompactingMemStore.java:609)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18519) Use builder pattern to create cell
[ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143041#comment-16143041 ] Anoop Sam John commented on HBASE-18519: This is excellent work. Such clean coding :-) Added some Qs/comments in RB. > Use builder pattern to create cell > -- > > Key: HBASE-18519 > URL: https://issues.apache.org/jira/browse/HBASE-18519 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, > HBASE-18519.v2.patch, HBASE-18519.v3.patch, HBASE-18519.v4.patch > > > The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the > input arguments without copying. We can substitute IndividualBytesFieldCell > for CellUtil.createCell. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-18695) Remove HTablePool
[ https://issues.apache.org/jira/browse/HBASE-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved HBASE-18695. Resolution: Duplicate > Remove HTablePool > - > > Key: HBASE-18695 > URL: https://issues.apache.org/jira/browse/HBASE-18695 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > > We have a beautiful memories with HTablePool, but it is deprecated and > useless now. It is time to say goodbye. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
