[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437616#comment-16437616
 ] 

stack commented on HBASE-20404:
---

bq. We end up in that block if we hit literally any kind of IOException. I 
think we need to print it, because the problem could be e.g. HDFS in safe mode 
or some other thing that an operator could do something about.

Fair enough.

bq. Are we seeing the specific IOException of "you're trying to delete a 
directory before the contents are deleted" a bunch of times because of a bad 
sort order? i.e. does a directory sort ahead of the stuff in the directory 
because of the "prioritize by size" check?

Zero study done by me. Doesn't happen that frequently... Just ugly when it does 
happen... Only exception in my log.

{code}
2018-04-12 04:42:06,543 WARN  [ForkJoinPool-1-worker-7] cleaner.CleanerChore: 
Could not delete dir under 
hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/hbase/meta/1588230740; 
{}
2018-04-12 06:52:10,365 WARN  [ForkJoinPool-1-worker-22] cleaner.CleanerChore: 
Could not delete dir under 
hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/03a723d5e024f4db900a185ccf946910/big;
 {}
2018-04-12 08:22:07,378 WARN  [ForkJoinPool-1-worker-22] cleaner.CleanerChore: 
Could not delete dir under 
hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/b10528e8b4ee831ec7db083823570f09/meta;
 {}
2018-04-12 10:32:10,324 WARN  [ForkJoinPool-1-worker-26] cleaner.CleanerChore: 
Could not delete dir under 
hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/adf743126026818a92350a53d5176897/meta;
 {}
2018-04-12 14:02:10,534 WARN  [ForkJoinPool-1-worker-14] cleaner.CleanerChore: 
Could not delete dir under 
hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553;
 {}
2018-04-12 15:42:10,314 WARN  [ForkJoinPool-1-worker-14] cleaner.CleanerChore: 
Could not delete dir under 
hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/639945dfda2ed3c7e783b02ef40d91fd/tiny;
 {}
2018-04-12 15:42:10,329 WARN  [ForkJoinPool-1-worker-0] cleaner.CleanerChore: 
Could not delete dir under 
hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/614d71f722cb9f8865b4eafdf180/tiny;
 {}
2018-04-12 15:52:15,532 WARN  [ForkJoinPool-1-worker-13] cleaner.CleanerChore: 
Could not delete dir under 
hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/tsdb/82e18bf2a034476b116226b0f7071738/t;
 {}
2018-04-12 16:02:09,911 WARN  [ForkJoinPool-1-worker-15] cleaner.CleanerChore: 
Could not delete dir under 
hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta;
 {}
2018-04-12 16:02:09,926 WARN  [ForkJoinPool-1-worker-12] cleaner.CleanerChore: 
Could not delete dir under 
hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/45e381c40cd3ce0e81947ad40369adfd/meta;
 {}
2018-04-12 16:02:09,951 WARN  [ForkJoinPool-1-worker-29] cleaner.CleanerChore: 
Could not delete dir under 
hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/45e381c40cd3ce0e81947ad40369adfd/big;
 {}
{code}

> Ugly cleanerchore complaint that dir is not empty
> -
>
> Key: HBASE-20404
> URL: https://issues.apache.org/jira/browse/HBASE-20404
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20404.0.patch, HBASE-20404.1.patch
>
>
>  I see these big dirty exceptions in my master log during a long-run Lets 
> clean them up (Are they exceptions I as an operator can actually do something 
> about? Are they 'problems'? Should they be LOG.warn?)
> {code}
> 2018-04-12 16:02:09,911 WARN  [ForkJoinPool-1-worker-15] 
> cleaner.CleanerChore: Could not delete dir under 
> hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta;
>  {}
> org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.fs.PathIsNotEmptyDirectoryException):
>  
> `/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta
>  is non empty': Directory is not empty
>   at 
> org.apache.hadoop.hdfs.server.namenode.FSDirDeleteOp.delete(FSDirDeleteOp.java:115)
>   at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.delete(FSNamesystem.java:2848)
>   at 
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.delete(NameNodeRpcServer.java:1048)
>   at 
> org.

[jira] [Commented] (HBASE-15557) document SyncTable in ref guide

2018-04-13 Thread Roland Teague (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437596#comment-16437596
 ] 

Roland Teague commented on HBASE-15557:
---

[~davelatham] Can you add documentation for this MR tool to the HBase Ref Guide 
on how to use the tool? This have been open for 2 years now.

> document SyncTable in ref guide
> ---
>
> Key: HBASE-15557
> URL: https://issues.apache.org/jira/browse/HBASE-15557
> Project: HBase
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 1.2.0
>Reporter: Sean Busbey
>Priority: Critical
>
> The docs for SyncTable are insufficient. Brief description from [~davelatham] 
> HBASE-13639 comment:
> {quote}
> Sorry for the lack of better documentation, Abhishek Soni. Thanks for 
> bringing it up. I'll try to provide a better explanation. You may have 
> already seen it, but if not, the design doc linked in the description above 
> may also give you some better clues as to how it should be used.
> Briefly, the feature is intended to start with a pair of tables in remote 
> clusters that are already substantially similar and make them identical by 
> comparing hashes of the data and copying only the diffs instead of having to 
> copy the entire table. So it is targeted at a very specific use case (with 
> some work it could generalize to cover things like CopyTable and 
> VerifyRepliaction but it's not there yet). To use it, you choose one table to 
> be the "source", and the other table is the "target". After the process is 
> complete the target table should end up being identical to the source table.
> In the source table's cluster, run 
> org.apache.hadoop.hbase.mapreduce.HashTable and pass it the name of the 
> source table and an output directory in HDFS. HashTable will scan the source 
> table, break the data up into row key ranges (default of 8kB per range) and 
> produce a hash of the data for each range.
> Make the hashes available to the target cluster - I'd recommend using DistCp 
> to copy it across.
> In the target table's cluster, run 
> org.apache.hadoop.hbase.mapreduce.SyncTable and pass it the directory where 
> you put the hashes, and the names of the source and destination tables. You 
> will likely also need to specify the source table's ZK quorum via the 
> --sourcezkcluster option. SyncTable will then read the hash information, and 
> compute the hashes of the same row ranges for the target table. For any row 
> range where the hash fails to match, it will open a remote scanner to the 
> source table, read the data for that range, and do Puts and Deletes to the 
> target table to update it to match the source.
> I hope that clarifies it a bit. Let me know if you need a hand. If anyone 
> wants to work on getting some documentation into the book, I can try to write 
> some more but would love a hand on turning it into an actual book patch.
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (HBASE-20145) HMaster start fails with IllegalStateException when HADOOP_HOME is set

2018-04-13 Thread Artem Ervits (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437565#comment-16437565
 ] 

Artem Ervits edited comment on HBASE-20145 at 4/13/18 5:10 PM:
---

I just got the same issue and can confirm that it's mixing jars on the classpath
{code:java}
/opt/hbase/hbase-2.0.0/lib/hadoop-annotations-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-auth-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-client-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-common-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-common-2.7.4-tests.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-distcp-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-hdfs-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-hdfs-2.7.4-tests.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-app-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-common-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-core-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-hs-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-jobclient-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-shuffle-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-minicluster-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-yarn-api-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-yarn-client-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-yarn-common-2.7.4.jar{code}
the key issue for me was omission of -Dhadoop.profile=3.0 as the stackoverflow 
article by [~rohithsharma] specifies. I only used -Dhadoop.version=3.1.0.


was (Author: dbist13):
I just got the same issue and can confirm that it's mixing jars on the classpath
{code:java}
/opt/hbase/hbase-2.0.0/lib/hadoop-annotations-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-auth-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-client-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-common-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-common-2.7.4-tests.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-distcp-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-hdfs-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-hdfs-2.7.4-tests.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-app-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-common-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-core-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-hs-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-jobclient-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-shuffle-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-minicluster-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-yarn-api-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-yarn-client-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-yarn-common-2.7.4.jar{code}

> HMaster start fails with IllegalStateException when HADOOP_HOME is set
> --
>
> Key: HBASE-20145
> URL: https://issues.apache.org/jira/browse/HBASE-20145
> Project: HBase
>  Issue Type: Bug
> Environment: HBase-2.0-beta1.
> Hadoop trunk version.
> java version "1.8.0_144"
>Reporter: Rohith Sharma K S
>Assignee: Wei-Chiu Chuang
>Priority: Critical
>
> It is observed that HMaster start is failed when HADOOP_HOME is set as env 
> while starting HMaster. HADOOP_HOME is pointing to Hadoop trunk version.
> {noformat}
> 2018-03-07 16:59:52,654 ERROR [master//10.200.4.200:16000] master.HMaster: 
> Failed to become active master
> java.lang.IllegalStateException: The procedure WAL relies on the ability to 
> hsync for proper operation during component failures, but the underlying 
> filesystem does not support doing so. Please check the config value of 
> 'hbase.procedure.store.wal.use.hsync' to set the desired level of robustness 
> and ensure the config value of 'hbase.wal.dir' points to a FileSystem mount 
> that can provide it.
>     at 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.rollWriter(WALProcedureStore.java:1036)
>     at 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.recoverLease(WALProcedureStore.java:374)
>     at 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:532)
>     at 
> org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1232)
>     at 
> org.apache.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1145)
>     at 
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:837)
>     at 
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2026)
>     at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:547)
>     at java.lang.Thread.run(Thread.java:748)
> {noformat}
> The same configs is working in HBase-1.2.6 build properly. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (HBASE-20145) HMaster start fails with IllegalStateException when HADOOP_HOME is set

2018-04-13 Thread Wei-Chiu Chuang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437475#comment-16437475
 ] 

Wei-Chiu Chuang edited comment on HBASE-20145 at 4/13/18 4:53 PM:
--

Thanks [~rohithsharma] now I understand why:

Turns out that if you point env HADOOP_HOME to a Hadoop3 path with hbase2.0 
convenience binary, the classpath will contain both Hadoop 2.7.4 and Hadoop 3 
jar files. Effectively causing class conflicts.

Since Hadoop 3 jars are available, HBase is able to query StreamCapabilities of 
the output stream. However, because Hadoop 2.7.4 jars is loaded before Hadoop 3 
jars in classpath, it loaded the HdfsDataOutputStream class implemented in 
Hadoop 2.7.4, which does not inherit from StreamCapabilities.
{code:java}
if (StreamCapabilities.CLASS.isAssignableFrom(stream.getClass())) {
try {
  result = ((Boolean)StreamCapabilities.METHOD.invoke(stream, 
capability)).booleanValue();
} catch 
(IllegalAccessException|IllegalArgumentException|InvocationTargetException
exception) {
  LOG.warn("Your Hadoop installation's StreamCapabilities 
implementation doesn't match " +
  "our understanding of how it's supposed to work. Please file a 
JIRA and include " +
  "the following stack trace. In the mean time we're interpreting 
this behavior " +
  "difference as a lack of capability support, which will probably 
cause a failure.",
  exception);
}
  }
{code}

This is not a problem in the code itself. But the code can be improved to log a 
warning message when output stream class does not inherit from 
StreamCapabilities.


was (Author: jojochuang):
Thanks [~rohithsharma] now I understand why:

Turns out that if you point env HADOOP_HOME to a Hadoop3 path with hbase2.0 
convenience binary, the classpath will contain both Hadoop 2.7.4 and Hadoop 3 
jar files. Effectively causing class conflicts.

Since Hadoop 3 jars are available, HBase is able to query StreamCapabilities of 
the output stream. However, because Hadoop 2.7.4 jars is loaded before Hadoop 3 
jars in classpath, it loaded the HdfsDataOutputStream class implemented in 
Hadoop 2.7.4, which does not inherit from StreamCapabilities.
{code:java}
if (StreamCapabilities.CLASS.isAssignableFrom(stream.getClass())) {
try {
  LOG.warn("stream type = " + 
stream.getWrappedStream().getClass().getCanonicalName());
  result = ((Boolean)StreamCapabilities.METHOD.invoke(stream, 
capability)).booleanValue();
} catch 
(IllegalAccessException|IllegalArgumentException|InvocationTargetException
exception) {
  LOG.warn("Your Hadoop installation's StreamCapabilities 
implementation doesn't match " +
  "our understanding of how it's supposed to work. Please file a 
JIRA and include " +
  "the following stack trace. In the mean time we're interpreting 
this behavior " +
  "difference as a lack of capability support, which will probably 
cause a failure.",
  exception);
}
  }
{code}

This is not a problem in the code itself. But the code can be improved to log 
warning message when output stream class does not inherit from 
StreamCapabilities.

> HMaster start fails with IllegalStateException when HADOOP_HOME is set
> --
>
> Key: HBASE-20145
> URL: https://issues.apache.org/jira/browse/HBASE-20145
> Project: HBase
>  Issue Type: Bug
> Environment: HBase-2.0-beta1.
> Hadoop trunk version.
> java version "1.8.0_144"
>Reporter: Rohith Sharma K S
>Assignee: Wei-Chiu Chuang
>Priority: Critical
>
> It is observed that HMaster start is failed when HADOOP_HOME is set as env 
> while starting HMaster. HADOOP_HOME is pointing to Hadoop trunk version.
> {noformat}
> 2018-03-07 16:59:52,654 ERROR [master//10.200.4.200:16000] master.HMaster: 
> Failed to become active master
> java.lang.IllegalStateException: The procedure WAL relies on the ability to 
> hsync for proper operation during component failures, but the underlying 
> filesystem does not support doing so. Please check the config value of 
> 'hbase.procedure.store.wal.use.hsync' to set the desired level of robustness 
> and ensure the config value of 'hbase.wal.dir' points to a FileSystem mount 
> that can provide it.
>     at 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.rollWriter(WALProcedureStore.java:1036)
>     at 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.recoverLease(WALProcedureStore.java:374)
>     at 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:532)
>     at 
> org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.

[jira] [Commented] (HBASE-20145) HMaster start fails with IllegalStateException when HADOOP_HOME is set

2018-04-13 Thread Artem Ervits (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437565#comment-16437565
 ] 

Artem Ervits commented on HBASE-20145:
--

I just got the same issue and can confirm that it's mixing jars on the classpath
{code:java}
/opt/hbase/hbase-2.0.0/lib/hadoop-annotations-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-auth-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-client-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-common-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-common-2.7.4-tests.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-distcp-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-hdfs-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-hdfs-2.7.4-tests.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-app-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-common-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-core-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-hs-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-jobclient-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-mapreduce-client-shuffle-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-minicluster-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-yarn-api-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-yarn-client-2.7.4.jar:/opt/hbase/hbase-2.0.0/lib/hadoop-yarn-common-2.7.4.jar{code}

> HMaster start fails with IllegalStateException when HADOOP_HOME is set
> --
>
> Key: HBASE-20145
> URL: https://issues.apache.org/jira/browse/HBASE-20145
> Project: HBase
>  Issue Type: Bug
> Environment: HBase-2.0-beta1.
> Hadoop trunk version.
> java version "1.8.0_144"
>Reporter: Rohith Sharma K S
>Assignee: Wei-Chiu Chuang
>Priority: Critical
>
> It is observed that HMaster start is failed when HADOOP_HOME is set as env 
> while starting HMaster. HADOOP_HOME is pointing to Hadoop trunk version.
> {noformat}
> 2018-03-07 16:59:52,654 ERROR [master//10.200.4.200:16000] master.HMaster: 
> Failed to become active master
> java.lang.IllegalStateException: The procedure WAL relies on the ability to 
> hsync for proper operation during component failures, but the underlying 
> filesystem does not support doing so. Please check the config value of 
> 'hbase.procedure.store.wal.use.hsync' to set the desired level of robustness 
> and ensure the config value of 'hbase.wal.dir' points to a FileSystem mount 
> that can provide it.
>     at 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.rollWriter(WALProcedureStore.java:1036)
>     at 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.recoverLease(WALProcedureStore.java:374)
>     at 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:532)
>     at 
> org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1232)
>     at 
> org.apache.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1145)
>     at 
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:837)
>     at 
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2026)
>     at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:547)
>     at java.lang.Thread.run(Thread.java:748)
> {noformat}
> The same configs is working in HBase-1.2.6 build properly. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20410) upgrade protoc compiler to 3.5.1-1

2018-04-13 Thread Josh Elser (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437548#comment-16437548
 ] 

Josh Elser commented on HBASE-20410:


+1 if you add a comment to hbase-protocol-shaded/pom.xml to describe why that 
version is different than hbase-thirdparty's dep now :)

> upgrade protoc compiler to 3.5.1-1
> --
>
> Key: HBASE-20410
> URL: https://issues.apache.org/jira/browse/HBASE-20410
> Project: HBase
>  Issue Type: Bug
>  Components: build, dependencies, Protobufs
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Critical
> Attachments: HBASE-20410.patch
>
>
> See HBASE-20356
> After doing the cleanup there, I was informed that there's a 3.5.1-1 version 
> of the compiler binaries that work on rhel6, so let's just go to that. Wish I 
> knew about it beforehand.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20406) HBase Thrift HTTP - Shouldn't handle TRACE/OPTIONS methods

2018-04-13 Thread Josh Elser (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437546#comment-16437546
 ] 

Josh Elser commented on HBASE-20406:


Change looks fine, but I'd happily wait for a test case too :)

> HBase Thrift HTTP - Shouldn't handle TRACE/OPTIONS methods
> --
>
> Key: HBASE-20406
> URL: https://issues.apache.org/jira/browse/HBASE-20406
> Project: HBase
>  Issue Type: Improvement
>  Components: security, Thrift
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Attachments: HBASE-20406.master.001.patch
>
>
> HBASE-10473 introduced a utility HttpServerUtil.constrainHttpMethods to 
> prevent Jetty from answering on TRACE and OPTIONS methods. This should be 
> added to Thrift in HTTP mode as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437542#comment-16437542
 ] 

Sean Busbey commented on HBASE-20404:
-

{quote}Patch looks good. Do we have to print the exception at all, even at 
DEBUG? Its a big dirty one. The prefatory text helps but It shows up often 
enough. Thanks.
{quote}
 

We end up in that block if we hit literally any kind of IOException. I think we 
need to print it, because the problem could be e.g. HDFS in safe mode or some 
other thing that an operator could do something about.

 

Are we seeing the specific IOException of "you're trying to delete a directory 
before the contents are deleted" a bunch of times because of a bad sort order? 
i.e. does a directory sort ahead of the stuff in the directory because of the 
"prioritize by size" check?

> Ugly cleanerchore complaint that dir is not empty
> -
>
> Key: HBASE-20404
> URL: https://issues.apache.org/jira/browse/HBASE-20404
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20404.0.patch, HBASE-20404.1.patch
>
>
>  I see these big dirty exceptions in my master log during a long-run Lets 
> clean them up (Are they exceptions I as an operator can actually do something 
> about? Are they 'problems'? Should they be LOG.warn?)
> {code}
> 2018-04-12 16:02:09,911 WARN  [ForkJoinPool-1-worker-15] 
> cleaner.CleanerChore: Could not delete dir under 
> hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta;
>  {}
> org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.fs.PathIsNotEmptyDirectoryException):
>  
> `/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta
>  is non empty': Directory is not empty
>   at 
> org.apache.hadoop.hdfs.server.namenode.FSDirDeleteOp.delete(FSDirDeleteOp.java:115)
>   at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.delete(FSNamesystem.java:2848)
>   at 
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.delete(NameNodeRpcServer.java:1048)
>   at 
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.delete(ClientNamenodeProtocolServerSideTranslatorPB.java:641)
>   at 
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:447)
>   at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:989)
>   at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:847)
>   at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:790)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1836)
>   at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2486)
>   at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1489)
>   at org.apache.hadoop.ipc.Client.call(Client.java:1435)
>   at org.apache.hadoop.ipc.Client.call(Client.java:1345)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:227)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:116)
>   at com.sun.proxy.$Proxy26.delete(Unknown Source)
>   at 
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.delete(ClientNamenodeProtocolTranslatorPB.java:568)
>   at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:409)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:163)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:346)
>   at com.sun.proxy.$Proxy27.delete(Unknown Source)
>   at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
> ...
> {code}
> Looks like log format is off too...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437535#comment-16437535
 ] 

Hadoop QA commented on HBASE-20404:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
40s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
45s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
14m 26s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}129m 
29s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}174m 30s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20404 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12918940/HBASE-20404.1.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux ca5cf39fff9e 3.13.0-137-generic #186-Ubuntu SMP Mon Dec 4 
19:09:19 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 5a633adffe |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12438/testReport/ |
| Max. process+thread count | 4214 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12438/console |
| Po

[jira] [Commented] (HBASE-20335) nightly jobs no longer contain machine information

2018-04-13 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437520#comment-16437520
 ] 

stack commented on HBASE-20335:
---

It looks great. Thanks for adding.

> nightly jobs no longer contain machine information
> --
>
> Key: HBASE-20335
> URL: https://issues.apache.org/jira/browse/HBASE-20335
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-20335.0.patch, HBASE-20335.1.patch
>
>
> something is up with nightly jobs. they no longer have the machine 
> information from HBASE-19228.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20379) shadedjars yetus plugin should add a footer link

2018-04-13 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437518#comment-16437518
 ] 

Hudson commented on HBASE-20379:


SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1102 (See 
[https://builds.apache.org/job/HBase-1.2-IT/1102/])
HBASE-20379 shadedjars yetus plugin should add a footer link (busbey: rev 
e78037107185e55cf796ef9373e918c698152f56)
* (edit) dev-support/hbase-personality.sh


> shadedjars yetus plugin should add a footer link
> 
>
> Key: HBASE-20379
> URL: https://issues.apache.org/jira/browse/HBASE-20379
> Project: HBase
>  Issue Type: Improvement
>  Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.4, 2.0.1
>
> Attachments: HBASE-20379.0.patch
>
>
> investigating the failure on HBASE-20219, it would be nice if we posted a 
> footer link to what failed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20112) Include test results from nightly hadoop3 tests in jenkins test results

2018-04-13 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437517#comment-16437517
 ] 

Hudson commented on HBASE-20112:


SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1102 (See 
[https://builds.apache.org/job/HBase-1.2-IT/1102/])
HBASE-20112 register nightly junit over hadoop3 results with jenkins. (busbey: 
rev 90ad8c64f2944b0582c98c15c4520d0e752beb96)
* (edit) dev-support/Jenkinsfile


> Include test results from nightly hadoop3 tests in jenkins test results
> ---
>
> Key: HBASE-20112
> URL: https://issues.apache.org/jira/browse/HBASE-20112
> Project: HBase
>  Issue Type: Task
>  Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.4, 2.0.1
>
> Attachments: HBASE-20112.0.patch
>
>
> right now our nightly tests that run atop hadoop 3 are reported on pass/fail 
> but aren't recorded via the jenkins reporting mechanism.
> we should add them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437516#comment-16437516
 ] 

stack commented on HBASE-20404:
---

Patch looks good. Do we have to print the exception at all, even at DEBUG? Its 
a big dirty one. The prefatory text helps but  It shows up often enough. Thanks.

> Ugly cleanerchore complaint that dir is not empty
> -
>
> Key: HBASE-20404
> URL: https://issues.apache.org/jira/browse/HBASE-20404
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20404.0.patch, HBASE-20404.1.patch
>
>
>  I see these big dirty exceptions in my master log during a long-run Lets 
> clean them up (Are they exceptions I as an operator can actually do something 
> about? Are they 'problems'? Should they be LOG.warn?)
> {code}
> 2018-04-12 16:02:09,911 WARN  [ForkJoinPool-1-worker-15] 
> cleaner.CleanerChore: Could not delete dir under 
> hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta;
>  {}
> org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.fs.PathIsNotEmptyDirectoryException):
>  
> `/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta
>  is non empty': Directory is not empty
>   at 
> org.apache.hadoop.hdfs.server.namenode.FSDirDeleteOp.delete(FSDirDeleteOp.java:115)
>   at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.delete(FSNamesystem.java:2848)
>   at 
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.delete(NameNodeRpcServer.java:1048)
>   at 
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.delete(ClientNamenodeProtocolServerSideTranslatorPB.java:641)
>   at 
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:447)
>   at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:989)
>   at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:847)
>   at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:790)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1836)
>   at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2486)
>   at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1489)
>   at org.apache.hadoop.ipc.Client.call(Client.java:1435)
>   at org.apache.hadoop.ipc.Client.call(Client.java:1345)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:227)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:116)
>   at com.sun.proxy.$Proxy26.delete(Unknown Source)
>   at 
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.delete(ClientNamenodeProtocolTranslatorPB.java:568)
>   at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:409)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:163)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:346)
>   at com.sun.proxy.$Proxy27.delete(Unknown Source)
>   at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
> ...
> {code}
> Looks like log format is off too...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20224) Web UI is broken in standalone mode

2018-04-13 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437509#comment-16437509
 ] 

stack commented on HBASE-20224:
---

My fault. I should have noticed these addendums but I lost track at the third 
one (I should have checked all modules at addendum #3... My fault).

> Web UI is broken in standalone mode
> ---
>
> Key: HBASE-20224
> URL: https://issues.apache.org/jira/browse/HBASE-20224
> Project: HBase
>  Issue Type: Bug
>  Components: UI, Usability
>Affects Versions: 2.0.0-beta-2
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: 
> 0001-HBASE-20224-Web-UI-is-broken-in-standalone-mode-ADDE.ADDENDUM.patch, 
> 20224-addendum.3.txt, 20224.addendum.4, 20224.addendum.5, 20224.addendum.6, 
> hbase-20224.master.001.patch, hbase-20224.master.002.patch, 
> hbase-20224.master.003.patch, hbase-20224.master.addendum.patch
>
>
> Web UI doesn't show up in standalone mode on default port. This can be seen 
> on master and branch-2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20396) Remove redundant MBean from thrift JMX

2018-04-13 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437503#comment-16437503
 ] 

Ted Yu commented on HBASE-20396:


lgtm

> Remove redundant MBean from thrift JMX
> --
>
> Key: HBASE-20396
> URL: https://issues.apache.org/jira/browse/HBASE-20396
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Attachments: HBASE-20396.master.001.patch
>
>
> HBase has two types of thrift server. When any type of thrift server is 
> started, the MBean of the two thrift servers will be registered which is 
> redundant.
> For example, when starting thrift2, we only need to register MBean 
> "Hadoop:service=HBase,name=Thrift,sub=ThriftTwo" of thrift2 in JMX, there's 
> no need to register MBean "Hadoop:service=HBase,name=Thrift,sub=ThriftOne" of 
> thrift. Vice versa



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20396) Remove redundant MBean from thrift JMX

2018-04-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437500#comment-16437500
 ] 

Hadoop QA commented on HBASE-20396:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
22s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
14s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
13m 31s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
27s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 6s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m  5s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20396 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12918934/HBASE-20396.master.001.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 7db555d68d7d 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 5a633adffe |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12439/testReport/ |
| Max. process+thread count | 210 (vs. ulimit of 1) |
| modules | C: hbase-hadoop2-compat U: hbase-hadoop2-compat |
| Console output | 
https://builds.apache.org/job/PreCommit-H

[jira] [Commented] (HBASE-20379) shadedjars yetus plugin should add a footer link

2018-04-13 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437492#comment-16437492
 ] 

Hudson commented on HBASE-20379:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #394 (See 
[https://builds.apache.org/job/HBase-1.3-IT/394/])
HBASE-20379 shadedjars yetus plugin should add a footer link (busbey: rev 
1c8246c6aa42746045681a89b01d4b0703ffd504)
* (edit) dev-support/hbase-personality.sh


> shadedjars yetus plugin should add a footer link
> 
>
> Key: HBASE-20379
> URL: https://issues.apache.org/jira/browse/HBASE-20379
> Project: HBase
>  Issue Type: Improvement
>  Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.4, 2.0.1
>
> Attachments: HBASE-20379.0.patch
>
>
> investigating the failure on HBASE-20219, it would be nice if we posted a 
> footer link to what failed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20112) Include test results from nightly hadoop3 tests in jenkins test results

2018-04-13 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437491#comment-16437491
 ] 

Hudson commented on HBASE-20112:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #394 (See 
[https://builds.apache.org/job/HBase-1.3-IT/394/])
HBASE-20112 register nightly junit over hadoop3 results with jenkins. (busbey: 
rev 64a209795f18fce6fe4cbcd0b40ec0e0dd3de6c3)
* (edit) dev-support/Jenkinsfile


> Include test results from nightly hadoop3 tests in jenkins test results
> ---
>
> Key: HBASE-20112
> URL: https://issues.apache.org/jira/browse/HBASE-20112
> Project: HBase
>  Issue Type: Task
>  Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.4, 2.0.1
>
> Attachments: HBASE-20112.0.patch
>
>
> right now our nightly tests that run atop hadoop 3 are reported on pass/fail 
> but aren't recorded via the jenkins reporting mechanism.
> we should add them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20145) HMaster start fails with IllegalStateException when HADOOP_HOME is set

2018-04-13 Thread Wei-Chiu Chuang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437475#comment-16437475
 ] 

Wei-Chiu Chuang commented on HBASE-20145:
-

Thanks [~rohithsharma] now I understand why:

Turns out that if you point env HADOOP_HOME to a Hadoop3 path with hbase2.0 
convenience binary, the classpath will contain both Hadoop 2.7.4 and Hadoop 3 
jar files. Effectively causing class conflicts.

Since Hadoop 3 jars are available, HBase is able to query StreamCapabilities of 
the output stream. However, because Hadoop 2.7.4 jars is loaded before Hadoop 3 
jars in classpath, it loaded the HdfsDataOutputStream class implemented in 
Hadoop 2.7.4, which does not inherit from StreamCapabilities.
{code:java}
if (StreamCapabilities.CLASS.isAssignableFrom(stream.getClass())) {
try {
  LOG.warn("stream type = " + 
stream.getWrappedStream().getClass().getCanonicalName());
  result = ((Boolean)StreamCapabilities.METHOD.invoke(stream, 
capability)).booleanValue();
} catch 
(IllegalAccessException|IllegalArgumentException|InvocationTargetException
exception) {
  LOG.warn("Your Hadoop installation's StreamCapabilities 
implementation doesn't match " +
  "our understanding of how it's supposed to work. Please file a 
JIRA and include " +
  "the following stack trace. In the mean time we're interpreting 
this behavior " +
  "difference as a lack of capability support, which will probably 
cause a failure.",
  exception);
}
  }
{code}

This is not a problem in the code itself. But the code can be improved to log 
warning message when output stream class does not inherit from 
StreamCapabilities.

> HMaster start fails with IllegalStateException when HADOOP_HOME is set
> --
>
> Key: HBASE-20145
> URL: https://issues.apache.org/jira/browse/HBASE-20145
> Project: HBase
>  Issue Type: Bug
> Environment: HBase-2.0-beta1.
> Hadoop trunk version.
> java version "1.8.0_144"
>Reporter: Rohith Sharma K S
>Assignee: Wei-Chiu Chuang
>Priority: Critical
>
> It is observed that HMaster start is failed when HADOOP_HOME is set as env 
> while starting HMaster. HADOOP_HOME is pointing to Hadoop trunk version.
> {noformat}
> 2018-03-07 16:59:52,654 ERROR [master//10.200.4.200:16000] master.HMaster: 
> Failed to become active master
> java.lang.IllegalStateException: The procedure WAL relies on the ability to 
> hsync for proper operation during component failures, but the underlying 
> filesystem does not support doing so. Please check the config value of 
> 'hbase.procedure.store.wal.use.hsync' to set the desired level of robustness 
> and ensure the config value of 'hbase.wal.dir' points to a FileSystem mount 
> that can provide it.
>     at 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.rollWriter(WALProcedureStore.java:1036)
>     at 
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.recoverLease(WALProcedureStore.java:374)
>     at 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:532)
>     at 
> org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1232)
>     at 
> org.apache.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1145)
>     at 
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:837)
>     at 
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2026)
>     at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:547)
>     at java.lang.Thread.run(Thread.java:748)
> {noformat}
> The same configs is working in HBase-1.2.6 build properly. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20379) shadedjars yetus plugin should add a footer link

2018-04-13 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20379:

   Resolution: Fixed
Fix Version/s: 2.0.1
   1.4.4
   1.3.3
   1.2.7
   1.5.0
   2.1.0
   3.0.0
   Status: Resolved  (was: Patch Available)

> shadedjars yetus plugin should add a footer link
> 
>
> Key: HBASE-20379
> URL: https://issues.apache.org/jira/browse/HBASE-20379
> Project: HBase
>  Issue Type: Improvement
>  Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.4, 2.0.1
>
> Attachments: HBASE-20379.0.patch
>
>
> investigating the failure on HBASE-20219, it would be nice if we posted a 
> footer link to what failed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20391) close out stale or finished PRs on github

2018-04-13 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20391:

   Resolution: Fixed
Fix Version/s: 3.0.0
   Status: Resolved  (was: Patch Available)

> close out stale or finished PRs on github
> -
>
> Key: HBASE-20391
> URL: https://issues.apache.org/jira/browse/HBASE-20391
> Project: HBase
>  Issue Type: Task
>  Components: community, documentation
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20391.0.patch
>
>
> Time to do another round of closing PRs via empty commit.
> * [#51|https://github.com/apache/hbase/pull/51] - > 1 month since notification
> * [#52|https://github.com/apache/hbase/pull/52] - > 1 month since notification
> * [#61|https://github.com/apache/hbase/pull/61] - HBASE-18928 has already 
> closed
> * [#62|https://github.com/apache/hbase/pull/62] - HBASE-18929 has already 
> closed
> * [#64|https://github.com/apache/hbase/pull/64] -HBASE-18901 has already 
> closed
> * [#67|https://github.com/apache/hbase/pull/67] - HBASE-19386 has already 
> closed
> * [#68|https://github.com/apache/hbase/pull/68] - HBASE-19387 has already 
> closed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20112) Include test results from nightly hadoop3 tests in jenkins test results

2018-04-13 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20112:

   Resolution: Fixed
Fix Version/s: 2.0.1
   1.4.4
   1.3.3
   1.2.7
   1.5.0
   2.1.0
   3.0.0
   Status: Resolved  (was: Patch Available)

> Include test results from nightly hadoop3 tests in jenkins test results
> ---
>
> Key: HBASE-20112
> URL: https://issues.apache.org/jira/browse/HBASE-20112
> Project: HBase
>  Issue Type: Task
>  Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.2.7, 1.3.3, 1.4.4, 2.0.1
>
> Attachments: HBASE-20112.0.patch
>
>
> right now our nightly tests that run atop hadoop 3 are reported on pass/fail 
> but aren't recorded via the jenkins reporting mechanism.
> we should add them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20369) Document incompatibilities between HBase 1.1.2 and HBase 2.0

2018-04-13 Thread Thiriguna Bharat Rao (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437471#comment-16437471
 ] 

Thiriguna Bharat Rao commented on HBASE-20369:
--

[~hadoopqa] I submitted a new patch version HBASE-20369_v1.patch that includes 
the new appendix titled as appendix_hbase_incompatibilities.adoc and the change 
to the book.adoc. 

Please verify and let me know if anything is missing. Appreciate your support 
and time.

 

Best,

Triguna

> Document incompatibilities between HBase 1.1.2 and HBase 2.0
> 
>
> Key: HBASE-20369
> URL: https://issues.apache.org/jira/browse/HBASE-20369
> Project: HBase
>  Issue Type: Bug
>  Components: documentation
>Reporter: Thiriguna Bharat Rao
>Assignee: Thiriguna Bharat Rao
>Priority: Critical
>  Labels: patch
> Attachments: HBASE-20369.patch, HBASE-20369_v1.patch, book.adoc
>
>
> Hi, 
> I compiled a  draft document for the HBase incompatibilities from the raw 
> source content that was available in HBase Beta 1 site. Can someone please 
> review and provide a feedback or share your comments on this document?
> Appreciate your support and time.
>  
> Best Regards, 
> Triguna



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (HBASE-20224) Web UI is broken in standalone mode

2018-04-13 Thread Peter Somogyi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi resolved HBASE-20224.
---
Resolution: Fixed

Pushed addendum 4 and 5 to branch-2.0.

> Web UI is broken in standalone mode
> ---
>
> Key: HBASE-20224
> URL: https://issues.apache.org/jira/browse/HBASE-20224
> Project: HBase
>  Issue Type: Bug
>  Components: UI, Usability
>Affects Versions: 2.0.0-beta-2
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: 
> 0001-HBASE-20224-Web-UI-is-broken-in-standalone-mode-ADDE.ADDENDUM.patch, 
> 20224-addendum.3.txt, 20224.addendum.4, 20224.addendum.5, 20224.addendum.6, 
> hbase-20224.master.001.patch, hbase-20224.master.002.patch, 
> hbase-20224.master.003.patch, hbase-20224.master.addendum.patch
>
>
> Web UI doesn't show up in standalone mode on default port. This can be seen 
> on master and branch-2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20224) Web UI is broken in standalone mode

2018-04-13 Thread Peter Somogyi (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437460#comment-16437460
 ] 

Peter Somogyi commented on HBASE-20224:
---

Thanks, just wanted to be sure that not because it causes some other problem 
there. Pushed to branch-2.0.

> Web UI is broken in standalone mode
> ---
>
> Key: HBASE-20224
> URL: https://issues.apache.org/jira/browse/HBASE-20224
> Project: HBase
>  Issue Type: Bug
>  Components: UI, Usability
>Affects Versions: 2.0.0-beta-2
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: 
> 0001-HBASE-20224-Web-UI-is-broken-in-standalone-mode-ADDE.ADDENDUM.patch, 
> 20224-addendum.3.txt, 20224.addendum.4, 20224.addendum.5, 20224.addendum.6, 
> hbase-20224.master.001.patch, hbase-20224.master.002.patch, 
> hbase-20224.master.003.patch, hbase-20224.master.addendum.patch
>
>
> Web UI doesn't show up in standalone mode on default port. This can be seen 
> on master and branch-2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20224) Web UI is broken in standalone mode

2018-04-13 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437454#comment-16437454
 ] 

Ted Yu commented on HBASE-20224:


Probably I just didn't check whether related tests failed for the same reason 
in branch-2.0

> Web UI is broken in standalone mode
> ---
>
> Key: HBASE-20224
> URL: https://issues.apache.org/jira/browse/HBASE-20224
> Project: HBase
>  Issue Type: Bug
>  Components: UI, Usability
>Affects Versions: 2.0.0-beta-2
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: 
> 0001-HBASE-20224-Web-UI-is-broken-in-standalone-mode-ADDE.ADDENDUM.patch, 
> 20224-addendum.3.txt, 20224.addendum.4, 20224.addendum.5, 20224.addendum.6, 
> hbase-20224.master.001.patch, hbase-20224.master.002.patch, 
> hbase-20224.master.003.patch, hbase-20224.master.addendum.patch
>
>
> Web UI doesn't show up in standalone mode on default port. This can be seen 
> on master and branch-2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20399) Fix merge layout

2018-04-13 Thread Balazs Meszaros (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-20399:

Attachment: after.png

> Fix merge layout
> 
>
> Key: HBASE-20399
> URL: https://issues.apache.org/jira/browse/HBASE-20399
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 3.0.0, 2.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20399.master.001.patch, after.png, merge.png
>
>
> Merge regions on {{table.jsp}} has wrong layout (see screenshot).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20399) Fix merge layout

2018-04-13 Thread Balazs Meszaros (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-20399:

Attachment: HBASE-20399.master.001.patch

> Fix merge layout
> 
>
> Key: HBASE-20399
> URL: https://issues.apache.org/jira/browse/HBASE-20399
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 3.0.0, 2.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20399.master.001.patch, after.png, merge.png
>
>
> Merge regions on {{table.jsp}} has wrong layout (see screenshot).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20399) Fix merge layout

2018-04-13 Thread Balazs Meszaros (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-20399:

Fix Version/s: 3.0.0
   Status: Patch Available  (was: In Progress)

> Fix merge layout
> 
>
> Key: HBASE-20399
> URL: https://issues.apache.org/jira/browse/HBASE-20399
> Project: HBase
>  Issue Type: Bug
>  Components: UI
>Affects Versions: 3.0.0, 2.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20399.master.001.patch, after.png, merge.png
>
>
> Merge regions on {{table.jsp}} has wrong layout (see screenshot).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20224) Web UI is broken in standalone mode

2018-04-13 Thread Peter Somogyi (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437444#comment-16437444
 ] 

Peter Somogyi commented on HBASE-20224:
---

[~yuzhih...@gmail.com], are there any specific reason why these were not pushed 
to branch-2.0?

> Web UI is broken in standalone mode
> ---
>
> Key: HBASE-20224
> URL: https://issues.apache.org/jira/browse/HBASE-20224
> Project: HBase
>  Issue Type: Bug
>  Components: UI, Usability
>Affects Versions: 2.0.0-beta-2
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: 
> 0001-HBASE-20224-Web-UI-is-broken-in-standalone-mode-ADDE.ADDENDUM.patch, 
> 20224-addendum.3.txt, 20224.addendum.4, 20224.addendum.5, 20224.addendum.6, 
> hbase-20224.master.001.patch, hbase-20224.master.002.patch, 
> hbase-20224.master.003.patch, hbase-20224.master.addendum.patch
>
>
> Web UI doesn't show up in standalone mode on default port. This can be seen 
> on master and branch-2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20379) shadedjars yetus plugin should add a footer link

2018-04-13 Thread Mike Drob (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437442#comment-16437442
 ] 

Mike Drob commented on HBASE-20379:
---

+1

> shadedjars yetus plugin should add a footer link
> 
>
> Key: HBASE-20379
> URL: https://issues.apache.org/jira/browse/HBASE-20379
> Project: HBase
>  Issue Type: Improvement
>  Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20379.0.patch
>
>
> investigating the failure on HBASE-20219, it would be nice if we posted a 
> footer link to what failed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20396) Remove redundant MBean from thrift JMX

2018-04-13 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-20396:
---
Status: Patch Available  (was: Open)

> Remove redundant MBean from thrift JMX
> --
>
> Key: HBASE-20396
> URL: https://issues.apache.org/jira/browse/HBASE-20396
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Attachments: HBASE-20396.master.001.patch
>
>
> HBase has two types of thrift server. When any type of thrift server is 
> started, the MBean of the two thrift servers will be registered which is 
> redundant.
> For example, when starting thrift2, we only need to register MBean 
> "Hadoop:service=HBase,name=Thrift,sub=ThriftTwo" of thrift2 in JMX, there's 
> no need to register MBean "Hadoop:service=HBase,name=Thrift,sub=ThriftOne" of 
> thrift. Vice versa



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20388) nightly tests running on a feature branch should only comment on that feature branch's jira

2018-04-13 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437441#comment-16437441
 ] 

Sean Busbey commented on HBASE-20388:
-

the nightly build on the feature branch, I mean.

> nightly tests running on a feature branch should only comment on that feature 
> branch's jira
> ---
>
> Key: HBASE-20388
> URL: https://issues.apache.org/jira/browse/HBASE-20388
> Project: HBase
>  Issue Type: Improvement
>  Components: community, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20388.0.patch, HBASE-20388.1.patch
>
>
> It would help improve our signal-to-noise ratio from nightly tests if feature 
> branch runs stopped commenting on all the jiras that got covered by a rebase 
> / merge.
> should be straight forward to have the commenting bit check the current 
> branch against our feature branch naming convention.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20388) nightly tests running on a feature branch should only comment on that feature branch's jira

2018-04-13 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20388:

Status: In Progress  (was: Patch Available)

build failed with some jenkins DSL error

> nightly tests running on a feature branch should only comment on that feature 
> branch's jira
> ---
>
> Key: HBASE-20388
> URL: https://issues.apache.org/jira/browse/HBASE-20388
> Project: HBase
>  Issue Type: Improvement
>  Components: community, test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20388.0.patch, HBASE-20388.1.patch
>
>
> It would help improve our signal-to-noise ratio from nightly tests if feature 
> branch runs stopped commenting on all the jiras that got covered by a rebase 
> / merge.
> should be straight forward to have the commenting bit check the current 
> branch against our feature branch naming convention.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20391) close out stale or finished PRs on github

2018-04-13 Thread Mike Drob (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437435#comment-16437435
 ] 

Mike Drob commented on HBASE-20391:
---

+1

> close out stale or finished PRs on github
> -
>
> Key: HBASE-20391
> URL: https://issues.apache.org/jira/browse/HBASE-20391
> Project: HBase
>  Issue Type: Task
>  Components: community, documentation
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HBASE-20391.0.patch
>
>
> Time to do another round of closing PRs via empty commit.
> * [#51|https://github.com/apache/hbase/pull/51] - > 1 month since notification
> * [#52|https://github.com/apache/hbase/pull/52] - > 1 month since notification
> * [#61|https://github.com/apache/hbase/pull/61] - HBASE-18928 has already 
> closed
> * [#62|https://github.com/apache/hbase/pull/62] - HBASE-18929 has already 
> closed
> * [#64|https://github.com/apache/hbase/pull/64] -HBASE-18901 has already 
> closed
> * [#67|https://github.com/apache/hbase/pull/67] - HBASE-19386 has already 
> closed
> * [#68|https://github.com/apache/hbase/pull/68] - HBASE-19387 has already 
> closed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20410) upgrade protoc compiler to 3.5.1-1

2018-04-13 Thread Mike Drob (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437434#comment-16437434
 ] 

Mike Drob commented on HBASE-20410:
---

verified this locally, btw. not sure that QA is going to be very useful here.

> upgrade protoc compiler to 3.5.1-1
> --
>
> Key: HBASE-20410
> URL: https://issues.apache.org/jira/browse/HBASE-20410
> Project: HBase
>  Issue Type: Bug
>  Components: build, dependencies, Protobufs
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Critical
> Attachments: HBASE-20410.patch
>
>
> See HBASE-20356
> After doing the cleanup there, I was informed that there's a 3.5.1-1 version 
> of the compiler binaries that work on rhel6, so let's just go to that. Wish I 
> knew about it beforehand.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20112) Include test results from nightly hadoop3 tests in jenkins test results

2018-04-13 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437422#comment-16437422
 ] 

Sean Busbey commented on HBASE-20112:
-

thanks for the review!

while the branch exists:

https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/HBASE-20112/3/testReport/

shows failures from the hadoop 3 test

and here's an example of a test that passed showing both hadoop 2 and hadoop 3:

https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/HBASE-20112/3/testReport/org.apache.hadoop.hbase.http/TestHttpRequestLog/

> Include test results from nightly hadoop3 tests in jenkins test results
> ---
>
> Key: HBASE-20112
> URL: https://issues.apache.org/jira/browse/HBASE-20112
> Project: HBase
>  Issue Type: Task
>  Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-20112.0.patch
>
>
> right now our nightly tests that run atop hadoop 3 are reported on pass/fail 
> but aren't recorded via the jenkins reporting mechanism.
> we should add them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (HBASE-20224) Web UI is broken in standalone mode

2018-04-13 Thread Peter Somogyi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi reopened HBASE-20224:
---

Reopening to push addendum 4 and 5 to branch-2.0.

> Web UI is broken in standalone mode
> ---
>
> Key: HBASE-20224
> URL: https://issues.apache.org/jira/browse/HBASE-20224
> Project: HBase
>  Issue Type: Bug
>  Components: UI, Usability
>Affects Versions: 2.0.0-beta-2
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: 
> 0001-HBASE-20224-Web-UI-is-broken-in-standalone-mode-ADDE.ADDENDUM.patch, 
> 20224-addendum.3.txt, 20224.addendum.4, 20224.addendum.5, 20224.addendum.6, 
> hbase-20224.master.001.patch, hbase-20224.master.002.patch, 
> hbase-20224.master.003.patch, hbase-20224.master.addendum.patch
>
>
> Web UI doesn't show up in standalone mode on default port. This can be seen 
> on master and branch-2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20395) Displaying thrift server type on the thrift page

2018-04-13 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437404#comment-16437404
 ] 

Ted Yu commented on HBASE-20395:


The following method is only called by tests:
{code}
+public TThriftServerType getThriftServerType() {
{code}
Since this is for checking programmatically, can you verify that thrift2 client 
calling thrift server can get the type correctly ?

Thanks

> Displaying thrift server type on the thrift page
> 
>
> Key: HBASE-20395
> URL: https://issues.apache.org/jira/browse/HBASE-20395
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Attachments: HBASE-20395.master.001.patch, 
> HBASE-20395.master.002.patch, HBASE-20395.master.003.patch, result.png
>
>
> HBase supports two types of thrift server: thrift and thrift2.
> But after start the thrift server successfully, we can not get the thrift 
> server type conveniently. 
> So, displaying thrift server type on the thrift page may provide some 
> convenience for the users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20389) Move website building flags into a profile

2018-04-13 Thread Mike Drob (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-20389:
--
Status: In Progress  (was: Patch Available)

> Move website building flags into a profile
> --
>
> Key: HBASE-20389
> URL: https://issues.apache.org/jira/browse/HBASE-20389
> Project: HBase
>  Issue Type: Improvement
>  Components: build, website
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HBASE-20389.0.patch
>
>
> we have some "magic" in our website building right now. The script that's 
> used bout our automated website build + publish mechanism manually sets a 
> bunch of stuff on the maven command line.
> It'd be better to reflect those settings in a maven profile, so that folks 
> are less likely to be surprised e.g. when trying to debug a failure in the 
> {{site}} goal happens.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20389) Move website building flags into a profile

2018-04-13 Thread Mike Drob (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437402#comment-16437402
 ] 

Mike Drob commented on HBASE-20389:
---

oh, wait, we still compile scala during the website construction. should figure 
out how to skip that too

> Move website building flags into a profile
> --
>
> Key: HBASE-20389
> URL: https://issues.apache.org/jira/browse/HBASE-20389
> Project: HBase
>  Issue Type: Improvement
>  Components: build, website
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HBASE-20389.0.patch
>
>
> we have some "magic" in our website building right now. The script that's 
> used bout our automated website build + publish mechanism manually sets a 
> bunch of stuff on the maven command line.
> It'd be better to reflect those settings in a maven profile, so that folks 
> are less likely to be surprised e.g. when trying to debug a failure in the 
> {{site}} goal happens.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20410) upgrade protoc compiler to 3.5.1-1

2018-04-13 Thread Mike Drob (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437399#comment-16437399
 ] 

Mike Drob commented on HBASE-20410:
---

nope!

it's the same release but with fixed binaries

> upgrade protoc compiler to 3.5.1-1
> --
>
> Key: HBASE-20410
> URL: https://issues.apache.org/jira/browse/HBASE-20410
> Project: HBase
>  Issue Type: Bug
>  Components: build, dependencies, Protobufs
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Critical
> Attachments: HBASE-20410.patch
>
>
> See HBASE-20356
> After doing the cleanup there, I was informed that there's a 3.5.1-1 version 
> of the compiler binaries that work on rhel6, so let's just go to that. Wish I 
> knew about it beforehand.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20410) upgrade protoc compiler to 3.5.1-1

2018-04-13 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437395#comment-16437395
 ] 

Sean Busbey commented on HBASE-20410:
-

does this require an update to hbase-thirdparty?

> upgrade protoc compiler to 3.5.1-1
> --
>
> Key: HBASE-20410
> URL: https://issues.apache.org/jira/browse/HBASE-20410
> Project: HBase
>  Issue Type: Bug
>  Components: build, dependencies, Protobufs
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Critical
> Attachments: HBASE-20410.patch
>
>
> See HBASE-20356
> After doing the cleanup there, I was informed that there's a 3.5.1-1 version 
> of the compiler binaries that work on rhel6, so let's just go to that. Wish I 
> knew about it beforehand.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20409) Set hbase.client.meta.operation.timeout in TestClientOperationTimeout

2018-04-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437384#comment-16437384
 ] 

Hadoop QA commented on HBASE-20409:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
14s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
12s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
13m  7s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}104m 
14s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}144m 31s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20409 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12918936/HBASE-20409.master.001.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux ad4c5d1ff6d5 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 826909a59c |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12437/testReport/ |
| Max. process+thread count | 4511 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12437/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Set hbase.c

[jira] [Updated] (HBASE-20410) upgrade protoc compiler to 3.5.1-1

2018-04-13 Thread Mike Drob (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-20410:
--
Attachment: HBASE-20410.patch

> upgrade protoc compiler to 3.5.1-1
> --
>
> Key: HBASE-20410
> URL: https://issues.apache.org/jira/browse/HBASE-20410
> Project: HBase
>  Issue Type: Bug
>  Components: build, dependencies, Protobufs
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Critical
> Attachments: HBASE-20410.patch
>
>
> See HBASE-20356
> After doing the cleanup there, I was informed that there's a 3.5.1-1 version 
> of the compiler binaries that work on rhel6, so let's just go to that. Wish I 
> knew about it beforehand.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20410) upgrade protoc compiler to 3.5.1-1

2018-04-13 Thread Mike Drob (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-20410:
--
Status: Patch Available  (was: Open)

> upgrade protoc compiler to 3.5.1-1
> --
>
> Key: HBASE-20410
> URL: https://issues.apache.org/jira/browse/HBASE-20410
> Project: HBase
>  Issue Type: Bug
>  Components: build, dependencies, Protobufs
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Critical
> Attachments: HBASE-20410.patch
>
>
> See HBASE-20356
> After doing the cleanup there, I was informed that there's a 3.5.1-1 version 
> of the compiler binaries that work on rhel6, so let's just go to that. Wish I 
> knew about it beforehand.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20410) upgrade protoc compiler to 3.5.1-1

2018-04-13 Thread Mike Drob (JIRA)
Mike Drob created HBASE-20410:
-

 Summary: upgrade protoc compiler to 3.5.1-1
 Key: HBASE-20410
 URL: https://issues.apache.org/jira/browse/HBASE-20410
 Project: HBase
  Issue Type: Bug
  Components: build, dependencies, Protobufs
Reporter: Mike Drob
Assignee: Mike Drob


See HBASE-20356

After doing the cleanup there, I was informed that there's a 3.5.1-1 version of 
the compiler binaries that work on rhel6, so let's just go to that. Wish I knew 
about it beforehand.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20356) make skipping protoc possible

2018-04-13 Thread Mike Drob (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-20356:
--
Summary: make skipping protoc possible  (was: protoc 3.5.1 can't compile on 
rhel6)

> make skipping protoc possible
> -
>
> Key: HBASE-20356
> URL: https://issues.apache.org/jira/browse/HBASE-20356
> Project: HBase
>  Issue Type: Bug
>  Components: dependencies, thirdparty
>Affects Versions: 2.0.0-beta-2
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Critical
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20356.patch, HBASE-20356.v2.patch, 
> HBASE-20356.v3.patch
>
>
> We upgraded our internal protoc version, and now can't build on RHEL6.
> I get this build error:
> {noformat}
> 2018-04-05 08:15:21.929278 [ERROR] PROTOC FAILED: ... /lib64/libc.so.6: 
> version `GLIBC_2.14' not found
> {noformat}
> See https://github.com/google/protobuf/issues/4109
> And this has come up before in https://github.com/google/protobuf/issues/3718
> Looks like we need to be on 3.4.0, unless there's a compelling reason to be 
> on something newer? Maybe roll back all the way to 3.3.0 which is what we 
> were on before... was there a specific bug we needed to get addressed?
> cc: [~elserj] [~stack]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20294) Also cleanup last pushed sequence id in ReplicationBarrierCleaner

2018-04-13 Thread Zheng Hu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437343#comment-16437343
 ] 

Zheng Hu commented on HBASE-20294:
--

+1,  Please fix checkstyle when committing. 

> Also cleanup last pushed sequence id in ReplicationBarrierCleaner
> -
>
> Key: HBASE-20294
> URL: https://issues.apache.org/jira/browse/HBASE-20294
> Project: HBase
>  Issue Type: Sub-task
>  Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20294.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20406) HBase Thrift HTTP - Shouldn't handle TRACE/OPTIONS methods

2018-04-13 Thread Kevin Risden (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437324#comment-16437324
 ] 

Kevin Risden commented on HBASE-20406:
--

Whoops thanks [~busbey] for triggering the patch.

I can try to put together a test for this (I didn't see other tests for 
OPTIONS/TRACE but shouldn't be hard to put together). It might take me a few 
days.

> HBase Thrift HTTP - Shouldn't handle TRACE/OPTIONS methods
> --
>
> Key: HBASE-20406
> URL: https://issues.apache.org/jira/browse/HBASE-20406
> Project: HBase
>  Issue Type: Improvement
>  Components: security, Thrift
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Attachments: HBASE-20406.master.001.patch
>
>
> HBASE-10473 introduced a utility HttpServerUtil.constrainHttpMethods to 
> prevent Jetty from answering on TRACE and OPTIONS methods. This should be 
> added to Thrift in HTTP mode as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20370) Also remove the wal file in remote cluster when we finish replicating a file

2018-04-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437317#comment-16437317
 ] 

Hadoop QA commented on HBASE-20370:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} HBASE-19064 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
46s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
19s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
34s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
10s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
56s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
44s{color} | {color:green} HBASE-19064 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
58s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m  
9s{color} | {color:red} hbase-server: The patch generated 1 new + 11 unchanged 
- 1 fixed = 12 total (was 12) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
50s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
14m 50s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
32s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
29s{color} | {color:red} hbase-server generated 5 new + 2 unchanged - 0 fixed = 
7 total (was 2) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
21s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}138m  
2s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
42s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}190m 20s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20370 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12918926/HBASE-20370-HBASE-19064.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux e6540a4451cd 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | HBASE-19

[jira] [Commented] (HBASE-18792) hbase-2 needs to defend against hbck operations

2018-04-13 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437304#comment-16437304
 ] 

Sean Busbey commented on HBASE-18792:
-

{code}
+for (int i = 0; i < strComps.length; ++i) {
+  try {
+comps[i] = Integer.parseInt((String) strComps[i]);
+  } catch (NumberFormatException e) {
+comps[i] = strComps[i];
+  }
+}
{code}

nit: We should use something like commons-lang's {{StringUtils#isNumeric}} to 
check this so that we're not relying on exceptions for control flow. on the 
other hand, this is a standard Java idiom so no big deal if we keep it.

> hbase-2 needs to defend against hbck operations
> ---
>
> Key: HBASE-18792
> URL: https://issues.apache.org/jira/browse/HBASE-18792
> Project: HBase
>  Issue Type: Task
>  Components: hbck
>Reporter: stack
>Assignee: Umesh Agashe
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: hbase-18792.master.001.patch
>
>
> hbck needs updating to run against hbase2. Meantime, if an hbck from hbase1 
> is run against hbck2, it may do damage. hbase2 should defend itself against 
> hbck1 ops.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-18792) hbase-2 needs to defend against hbck operations

2018-04-13 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437291#comment-16437291
 ] 

Sean Busbey commented on HBASE-18792:
-

{code}
-if (index < s1.length) {
+if (index < v1Comps.length) {
   // s1 is longer
   return 1;
 }
{code}

I think this is wrong? like version "2.0.0" should be after "2.0.0-SNAPSHOT". 
it's also after "2.0.0-alpha-3" or "2.0.0-beta-1"

Can we expand the versions checked in {{TestVersionInfo}} to include a) some 
"same major different minor", b) "same minor different maintenance", c) both of 
the above, but SNAPSHOT, d) "-alpha" / "-beta"?

> hbase-2 needs to defend against hbck operations
> ---
>
> Key: HBASE-18792
> URL: https://issues.apache.org/jira/browse/HBASE-18792
> Project: HBase
>  Issue Type: Task
>  Components: hbck
>Reporter: stack
>Assignee: Umesh Agashe
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: hbase-18792.master.001.patch
>
>
> hbck needs updating to run against hbase2. Meantime, if an hbck from hbase1 
> is run against hbck2, it may do damage. hbase2 should defend itself against 
> hbck1 ops.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-18792) hbase-2 needs to defend against hbck operations

2018-04-13 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437289#comment-16437289
 ] 

Sean Busbey commented on HBASE-18792:
-

{code}
+while (index < v1Comps.length && index < v2Comps.length) {
+  int va = v1Comps[index] instanceof Integer ? (Integer)v1Comps[index] : 
VERY_LARGE_NUMBER;
+  int vb = v2Comps[index] instanceof Integer ? (Integer)v2Comps[index] : 
VERY_LARGE_NUMBER;
+
   if (va != vb) {
 return va - vb;
   }
   if (va == VERY_LARGE_NUMBER) {
 // compare as String
-int c = s1[index].compareTo(s2[index]);
+int c = ((String)v1Comps[index]).compareTo((String)v2Comps[index]);
 if (c != 0) {
   return c;
 }
   }
   index++;
 }
{code}

ooof. man that's rough. How about a comment before the {{if(va == 
VERY_LARGE_NUMBER)}} that says something like "va and vb must both be the same 
and indicate that the version part is a String"?

Also make {{va}}, {{vb}}, and {{VERY_LARGE_NUMBER}} all type {{Integer}} 
instead of int and use {{Integer#compareTo(Integer)}} so that we're not going 
through a bunch of autoboxing.

> hbase-2 needs to defend against hbck operations
> ---
>
> Key: HBASE-18792
> URL: https://issues.apache.org/jira/browse/HBASE-18792
> Project: HBase
>  Issue Type: Task
>  Components: hbck
>Reporter: stack
>Assignee: Umesh Agashe
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: hbase-18792.master.001.patch
>
>
> hbck needs updating to run against hbase2. Meantime, if an hbck from hbase1 
> is run against hbck2, it may do damage. hbase2 should defend itself against 
> hbck1 ops.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-18792) hbase-2 needs to defend against hbck operations

2018-04-13 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437276#comment-16437276
 ] 

Sean Busbey commented on HBASE-18792:
-

{code:java}
+  /**
+   * Returns the version components as Integer and String objects
+   * Examples: "1.2.3" returns [1, 2, 3], "4.5.6-SNAPSHOT" returns [4, 5, 6, 
"SNAPSHOT"]
+   * @return the components of the version string
+   */
+  public static Object[] getVersionComponents(final String version) {{code}

VersionInfo is IA.Public, so any public methods become a part of our supported 
API. Can we make this method private?

> hbase-2 needs to defend against hbck operations
> ---
>
> Key: HBASE-18792
> URL: https://issues.apache.org/jira/browse/HBASE-18792
> Project: HBase
>  Issue Type: Task
>  Components: hbck
>Reporter: stack
>Assignee: Umesh Agashe
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: hbase-18792.master.001.patch
>
>
> hbck needs updating to run against hbase2. Meantime, if an hbck from hbase1 
> is run against hbck2, it may do damage. hbase2 should defend itself against 
> hbck1 ops.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20377) Deal with table in enabling and disabling state when modifying serial replication peer

2018-04-13 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-20377:
--
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Pushed to master and branch-2. Thanks [~openinx] for reviewing.

> Deal with table in enabling and disabling state when modifying serial 
> replication peer
> --
>
> Key: HBASE-20377
> URL: https://issues.apache.org/jira/browse/HBASE-20377
> Project: HBase
>  Issue Type: Sub-task
>  Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20377-v1.patch, HBASE-20377.patch
>
>
> There could be race between reopening regions and enabling table, and also 
> between disabling table and write last pushed sequence id for disabled table. 
> Maybe we need to wait for the table state to become enabled or disabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20275) [DOC] clarify impact to hfile command from HBASE-17197

2018-04-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437256#comment-16437256
 ] 

Hadoop QA commented on HBASE-20275:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 7s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue}  3m 
17s{color} | {color:blue} branch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. {color} 
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue}  3m 
13s{color} | {color:blue} patch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. {color} 
|
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
11s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 19s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20275 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12918939/HBASE-20275.master.001.patch
 |
| Optional Tests |  asflicense  refguide  |
| uname | Linux 7488e29182bf 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 826909a59c |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| refguide | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12436/artifact/patchprocess/branch-site/book.html
 |
| refguide | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12436/artifact/patchprocess/patch-site/book.html
 |
| Max. process+thread count | 83 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12436/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> [DOC] clarify impact to hfile command from HBASE-17197
> --
>
> Key: HBASE-20275
> URL: https://issues.apache.org/jira/browse/HBASE-20275
> Project: HBase
>  Issue Type: Sub-task
>  Components: documentation, tooling
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20275.master.001.patch
>
>
> Feedback on HBASE-19158 from [~mdrob]
> {quote}
> Tools:
> HBASE-17197
> {quote}
> It's not clear to me from the patch on HBASE-17197 if this was actually a 
> change that needs to be called out. So tasks:
> 1) Figure out if the {{hfile}} command args from HBase 1.y still works
> 2) Update the title of HBASE-17197 to match what the change in the jira ended 
> up being
> 3) If hfile changed in an incompatible way, add it to the upgrade section and 
> make sure the refguide section "hfile_tool" is up to date.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437246#comment-16437246
 ] 

Sean Busbey commented on HBASE-20404:
-

-v1

  - fix checkstyle complaint.

> Ugly cleanerchore complaint that dir is not empty
> -
>
> Key: HBASE-20404
> URL: https://issues.apache.org/jira/browse/HBASE-20404
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20404.0.patch, HBASE-20404.1.patch
>
>
>  I see these big dirty exceptions in my master log during a long-run Lets 
> clean them up (Are they exceptions I as an operator can actually do something 
> about? Are they 'problems'? Should they be LOG.warn?)
> {code}
> 2018-04-12 16:02:09,911 WARN  [ForkJoinPool-1-worker-15] 
> cleaner.CleanerChore: Could not delete dir under 
> hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta;
>  {}
> org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.fs.PathIsNotEmptyDirectoryException):
>  
> `/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta
>  is non empty': Directory is not empty
>   at 
> org.apache.hadoop.hdfs.server.namenode.FSDirDeleteOp.delete(FSDirDeleteOp.java:115)
>   at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.delete(FSNamesystem.java:2848)
>   at 
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.delete(NameNodeRpcServer.java:1048)
>   at 
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.delete(ClientNamenodeProtocolServerSideTranslatorPB.java:641)
>   at 
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:447)
>   at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:989)
>   at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:847)
>   at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:790)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1836)
>   at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2486)
>   at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1489)
>   at org.apache.hadoop.ipc.Client.call(Client.java:1435)
>   at org.apache.hadoop.ipc.Client.call(Client.java:1345)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:227)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:116)
>   at com.sun.proxy.$Proxy26.delete(Unknown Source)
>   at 
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.delete(ClientNamenodeProtocolTranslatorPB.java:568)
>   at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:409)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:163)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:346)
>   at com.sun.proxy.$Proxy27.delete(Unknown Source)
>   at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
> ...
> {code}
> Looks like log format is off too...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-20404:

Attachment: HBASE-20404.1.patch

> Ugly cleanerchore complaint that dir is not empty
> -
>
> Key: HBASE-20404
> URL: https://issues.apache.org/jira/browse/HBASE-20404
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.0.0
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-20404.0.patch, HBASE-20404.1.patch
>
>
>  I see these big dirty exceptions in my master log during a long-run Lets 
> clean them up (Are they exceptions I as an operator can actually do something 
> about? Are they 'problems'? Should they be LOG.warn?)
> {code}
> 2018-04-12 16:02:09,911 WARN  [ForkJoinPool-1-worker-15] 
> cleaner.CleanerChore: Could not delete dir under 
> hdfs://ve0524.halxg.cloudera.com:8020/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta;
>  {}
> org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.fs.PathIsNotEmptyDirectoryException):
>  
> `/hbase/archive/data/default/IntegrationTestBigLinkedList/1e24549061df3adc4858fbcaf1929553/meta
>  is non empty': Directory is not empty
>   at 
> org.apache.hadoop.hdfs.server.namenode.FSDirDeleteOp.delete(FSDirDeleteOp.java:115)
>   at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.delete(FSNamesystem.java:2848)
>   at 
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.delete(NameNodeRpcServer.java:1048)
>   at 
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.delete(ClientNamenodeProtocolServerSideTranslatorPB.java:641)
>   at 
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:447)
>   at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:989)
>   at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:847)
>   at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:790)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:422)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1836)
>   at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2486)
>   at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1489)
>   at org.apache.hadoop.ipc.Client.call(Client.java:1435)
>   at org.apache.hadoop.ipc.Client.call(Client.java:1345)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:227)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:116)
>   at com.sun.proxy.$Proxy26.delete(Unknown Source)
>   at 
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.delete(ClientNamenodeProtocolTranslatorPB.java:568)
>   at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:409)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:163)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:346)
>   at com.sun.proxy.$Proxy27.delete(Unknown Source)
>   at sun.reflect.GeneratedMethodAccessor28.invoke(Unknown Source)
> ...
> {code}
> Looks like log format is off too...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20409) Set hbase.client.meta.operation.timeout in TestClientOperationTimeout

2018-04-13 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437235#comment-16437235
 ] 

Ted Yu commented on HBASE-20409:


Lgtm 
Pending QA

> Set hbase.client.meta.operation.timeout in TestClientOperationTimeout
> -
>
> Key: HBASE-20409
> URL: https://issues.apache.org/jira/browse/HBASE-20409
> Project: HBase
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 3.0.0, 2.1.0, 2.0.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Trivial
> Attachments: HBASE-20409.master.001.patch
>
>
> In TestClientOperationTimeout the hbase.client.meta.operation.timeout 
> property is not, so default value is used which is 120ms. The test 
> finishes earlier if we set the timeout to match with 
> hbase.client.meta.operation.timeout.
> Since the first call will go to META table where the default timeout is used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20275) [DOC] clarify impact to hfile command from HBASE-17197

2018-04-13 Thread Balazs Meszaros (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437231#comment-16437231
 ] 

Balazs Meszaros commented on HBASE-20275:
-

Ok, fixed.

> [DOC] clarify impact to hfile command from HBASE-17197
> --
>
> Key: HBASE-20275
> URL: https://issues.apache.org/jira/browse/HBASE-20275
> Project: HBase
>  Issue Type: Sub-task
>  Components: documentation, tooling
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20275.master.001.patch
>
>
> Feedback on HBASE-19158 from [~mdrob]
> {quote}
> Tools:
> HBASE-17197
> {quote}
> It's not clear to me from the patch on HBASE-17197 if this was actually a 
> change that needs to be called out. So tasks:
> 1) Figure out if the {{hfile}} command args from HBase 1.y still works
> 2) Update the title of HBASE-17197 to match what the change in the jira ended 
> up being
> 3) If hfile changed in an incompatible way, add it to the upgrade section and 
> make sure the refguide section "hfile_tool" is up to date.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20275) [DOC] clarify impact to hfile command from HBASE-17197

2018-04-13 Thread Balazs Meszaros (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-20275:

 Assignee: Balazs Meszaros
Fix Version/s: 3.0.0
   Status: Patch Available  (was: Open)

> [DOC] clarify impact to hfile command from HBASE-17197
> --
>
> Key: HBASE-20275
> URL: https://issues.apache.org/jira/browse/HBASE-20275
> Project: HBase
>  Issue Type: Sub-task
>  Components: documentation, tooling
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20275.master.001.patch
>
>
> Feedback on HBASE-19158 from [~mdrob]
> {quote}
> Tools:
> HBASE-17197
> {quote}
> It's not clear to me from the patch on HBASE-17197 if this was actually a 
> change that needs to be called out. So tasks:
> 1) Figure out if the {{hfile}} command args from HBase 1.y still works
> 2) Update the title of HBASE-17197 to match what the change in the jira ended 
> up being
> 3) If hfile changed in an incompatible way, add it to the upgrade section and 
> make sure the refguide section "hfile_tool" is up to date.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20275) [DOC] clarify impact to hfile command from HBASE-17197

2018-04-13 Thread Balazs Meszaros (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Balazs Meszaros updated HBASE-20275:

Attachment: HBASE-20275.master.001.patch

> [DOC] clarify impact to hfile command from HBASE-17197
> --
>
> Key: HBASE-20275
> URL: https://issues.apache.org/jira/browse/HBASE-20275
> Project: HBase
>  Issue Type: Sub-task
>  Components: documentation, tooling
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Priority: Major
> Attachments: HBASE-20275.master.001.patch
>
>
> Feedback on HBASE-19158 from [~mdrob]
> {quote}
> Tools:
> HBASE-17197
> {quote}
> It's not clear to me from the patch on HBASE-17197 if this was actually a 
> change that needs to be called out. So tasks:
> 1) Figure out if the {{hfile}} command args from HBase 1.y still works
> 2) Update the title of HBASE-17197 to match what the change in the jira ended 
> up being
> 3) If hfile changed in an incompatible way, add it to the upgrade section and 
> make sure the refguide section "hfile_tool" is up to date.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-17449) Add explicit document on different timeout settings

2018-04-13 Thread Peter Somogyi (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437230#comment-16437230
 ] 

Peter Somogyi commented on HBASE-17449:
---

The improvement issue is HBASE-20409.

> Add explicit document on different timeout settings
> ---
>
> Key: HBASE-17449
> URL: https://issues.apache.org/jira/browse/HBASE-17449
> Project: HBase
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Yu Li
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: 0001-Standalone.patch, HBASE-17449.master.002.patch, 
> WIP-HBASE-17499.master.001.patch
>
>
> Currently we have more than one timeout settings, mainly includes:
> * hbase.rpc.timeout
> * hbase.client.operation.timeout
> * hbase.client.scanner.timeout.period
> And in latest branch-1 or master branch code, we will have two other 
> properties:
> * hbase.rpc.read.timeout
> * hbase.rpc.write.timeout
> However, in current refguid we don't have explicit instruction on the 
> difference of these timeout settings (there're explanations for each 
> property, but no instruction on when to use which)
> In my understanding, for RPC layer timeout, or say each rpc call:
> * Scan (openScanner/next): controlled by hbase.client.scanner.timeout.period
> * Other operations:
>1. For released versions: controlled by hbase.rpc.timeout
>2. For 1.4+ versions: read operation controlled by hbase.rpc.read.timeout, 
> write operation controlled by hbase.rpc.write.timeout, or hbase.rpc.timeout 
> if the previous two are not set.
> And hbase.client.operation.timeout is a higher-level control counting retry 
> in, or say the overall control for one user call.
> After this JIRA, I hope when users ask questions like "What settings I should 
> use if I don't want to wait for more than 1 second for a single 
> put/get/scan.next call", we could give a neat answer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20409) Set hbase.client.meta.operation.timeout in TestClientOperationTimeout

2018-04-13 Thread Peter Somogyi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-20409:
--
Attachment: HBASE-20409.master.001.patch

> Set hbase.client.meta.operation.timeout in TestClientOperationTimeout
> -
>
> Key: HBASE-20409
> URL: https://issues.apache.org/jira/browse/HBASE-20409
> Project: HBase
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 3.0.0, 2.1.0, 2.0.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Trivial
> Attachments: HBASE-20409.master.001.patch
>
>
> In TestClientOperationTimeout the hbase.client.meta.operation.timeout 
> property is not, so default value is used which is 120ms. The test 
> finishes earlier if we set the timeout to match with 
> hbase.client.meta.operation.timeout.
> Since the first call will go to META table where the default timeout is used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20409) Set hbase.client.meta.operation.timeout in TestClientOperationTimeout

2018-04-13 Thread Peter Somogyi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-20409:
--
Status: Patch Available  (was: Open)

> Set hbase.client.meta.operation.timeout in TestClientOperationTimeout
> -
>
> Key: HBASE-20409
> URL: https://issues.apache.org/jira/browse/HBASE-20409
> Project: HBase
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 3.0.0, 2.1.0, 2.0.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Trivial
> Attachments: HBASE-20409.master.001.patch
>
>
> In TestClientOperationTimeout the hbase.client.meta.operation.timeout 
> property is not, so default value is used which is 120ms. The test 
> finishes earlier if we set the timeout to match with 
> hbase.client.meta.operation.timeout.
> Since the first call will go to META table where the default timeout is used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-20409) Set hbase.client.meta.operation.timeout in TestClientOperationTimeout

2018-04-13 Thread Peter Somogyi (JIRA)
Peter Somogyi created HBASE-20409:
-

 Summary: Set hbase.client.meta.operation.timeout in 
TestClientOperationTimeout
 Key: HBASE-20409
 URL: https://issues.apache.org/jira/browse/HBASE-20409
 Project: HBase
  Issue Type: Improvement
  Components: test
Affects Versions: 3.0.0, 2.1.0, 2.0.0
Reporter: Peter Somogyi
Assignee: Peter Somogyi


In TestClientOperationTimeout the hbase.client.meta.operation.timeout property 
is not, so default value is used which is 120ms. The test finishes earlier 
if we set the timeout to match with hbase.client.meta.operation.timeout.

Since the first call will go to META table where the default timeout is used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20408) Plug-gable retry policy in all admin API's

2018-04-13 Thread Divesh Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437219#comment-16437219
 ] 

Divesh Jain commented on HBASE-20408:
-

[~psomogyi] Thanks!!

> Plug-gable retry policy in all admin API's
> --
>
> Key: HBASE-20408
> URL: https://issues.apache.org/jira/browse/HBASE-20408
> Project: HBase
>  Issue Type: New Feature
>Reporter: Divesh Jain
>Assignee: Divesh Jain
>Priority: Major
>
> All admin API's that are retry able should support custom retry policy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20407) Retry HBase admin API if master failover is in progress

2018-04-13 Thread Divesh Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437218#comment-16437218
 ] 

Divesh Jain commented on HBASE-20407:
-

[~psomogyi] Thanks

 

> Retry HBase admin API if master failover is in progress
> ---
>
> Key: HBASE-20407
> URL: https://issues.apache.org/jira/browse/HBASE-20407
> Project: HBase
>  Issue Type: Improvement
>  Components: Admin
>Reporter: Divesh Jain
>Assignee: Divesh Jain
>Priority: Minor
>
> When a master switch over is in progress and an admin API is called, perform 
> a retry operation before throwing an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20395) Displaying thrift server type on the thrift page

2018-04-13 Thread Balazs Meszaros (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437198#comment-16437198
 ] 

Balazs Meszaros commented on HBASE-20395:
-

+1: ran locally, reviewed the code.

> Displaying thrift server type on the thrift page
> 
>
> Key: HBASE-20395
> URL: https://issues.apache.org/jira/browse/HBASE-20395
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Attachments: HBASE-20395.master.001.patch, 
> HBASE-20395.master.002.patch, HBASE-20395.master.003.patch, result.png
>
>
> HBase supports two types of thrift server: thrift and thrift2.
> But after start the thrift server successfully, we can not get the thrift 
> server type conveniently. 
> So, displaying thrift server type on the thrift page may provide some 
> convenience for the users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20396) Remove redundant MBean from thrift JMX

2018-04-13 Thread Guangxu Cheng (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guangxu Cheng updated HBASE-20396:
--
Attachment: HBASE-20396.master.001.patch

> Remove redundant MBean from thrift JMX
> --
>
> Key: HBASE-20396
> URL: https://issues.apache.org/jira/browse/HBASE-20396
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Attachments: HBASE-20396.master.001.patch
>
>
> HBase has two types of thrift server. When any type of thrift server is 
> started, the MBean of the two thrift servers will be registered which is 
> redundant.
> For example, when starting thrift2, we only need to register MBean 
> "Hadoop:service=HBase,name=Thrift,sub=ThriftTwo" of thrift2 in JMX, there's 
> no need to register MBean "Hadoop:service=HBase,name=Thrift,sub=ThriftOne" of 
> thrift. Vice versa



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20396) Remove redundant MBean from thrift JMX

2018-04-13 Thread Guangxu Cheng (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437194#comment-16437194
 ] 

Guangxu Cheng commented on HBASE-20396:
---

Attach first patch for reivew.Thanks

> Remove redundant MBean from thrift JMX
> --
>
> Key: HBASE-20396
> URL: https://issues.apache.org/jira/browse/HBASE-20396
> Project: HBase
>  Issue Type: Improvement
>  Components: Thrift
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Attachments: HBASE-20396.master.001.patch
>
>
> HBase has two types of thrift server. When any type of thrift server is 
> started, the MBean of the two thrift servers will be registered which is 
> redundant.
> For example, when starting thrift2, we only need to register MBean 
> "Hadoop:service=HBase,name=Thrift,sub=ThriftTwo" of thrift2 in JMX, there's 
> no need to register MBean "Hadoop:service=HBase,name=Thrift,sub=ThriftOne" of 
> thrift. Vice versa



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20377) Deal with table in enabling and disabling state when modifying serial replication peer

2018-04-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437191#comment-16437191
 ] 

Hadoop QA commented on HBASE-20377:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
22s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
14s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
13m  5s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
46s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m  
4s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}101m 
55s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
42s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}151m  8s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20377 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12918907/HBASE-20377-v1.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux bed65302abe6 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / d59a6c8166 |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| fi

[jira] [Comment Edited] (HBASE-20369) Document incompatibilities between HBase 1.1.2 and HBase 2.0

2018-04-13 Thread Thiriguna Bharat Rao (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436981#comment-16436981
 ] 

Thiriguna Bharat Rao edited comment on HBASE-20369 at 4/13/18 11:01 AM:


Many thanks, [~busbey], for the prompt response and guidance. The changes that 
I've submitted have to happen in two different locations, however, as per the 
guidelines it requires a single patch. Resubmitting the patch with a versioning 
added to it.  

Request to review and provide feedback. Appreciate your support and time. 

comments added in the git commit log:

HBASE-20369_v1.patch

 

Included the appendix_hbase_incompatibilities.adoc content .  Since it's a new 

appendix section, I've made changes to the book.adoc and appended that change

 as well in the same patch file, because the review process requires a single 
patch file.

 

Best,

Triguna

 


was (Author: trigunab):
Many thanks, [~busbey], for the prompt response and guidance. The changes that 
I've submitted have to happen in two different locations, however, as per the 
guidelines it requires a single patch. Resubmitting the patch with a versioning 
added to it.  

Request to review and provide feedback. Appreciate your support and time. 

comments added in the git commit log:

HBASE-20369_v1.patch

 

Included the appendix_hbase_incompatibilities.adoc content, since it's a new 

appendix section, I've made changes to the book.adoc and appended that change

 as well in the same patch file, because review requires a single patch file.

 

Best,

Triguna

 

> Document incompatibilities between HBase 1.1.2 and HBase 2.0
> 
>
> Key: HBASE-20369
> URL: https://issues.apache.org/jira/browse/HBASE-20369
> Project: HBase
>  Issue Type: Bug
>  Components: documentation
>Reporter: Thiriguna Bharat Rao
>Assignee: Thiriguna Bharat Rao
>Priority: Critical
>  Labels: patch
> Attachments: HBASE-20369.patch, HBASE-20369_v1.patch, book.adoc
>
>
> Hi, 
> I compiled a  draft document for the HBase incompatibilities from the raw 
> source content that was available in HBase Beta 1 site. Can someone please 
> review and provide a feedback or share your comments on this document?
> Appreciate your support and time.
>  
> Best Regards, 
> Triguna



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20370) Also remove the wal file in remote cluster when we finish replicating a file

2018-04-13 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437163#comment-16437163
 ] 

Duo Zhang commented on HBASE-20370:
---

Review board link:

 

https://reviews.apache.org/r/66605/

> Also remove the wal file in remote cluster when we finish replicating a file
> 
>
> Key: HBASE-20370
> URL: https://issues.apache.org/jira/browse/HBASE-20370
> Project: HBase
>  Issue Type: Sub-task
>  Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: HBASE-19064
>
> Attachments: HBASE-20370-HBASE-19064.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20163) Forbid major compaction when standby cluster replay the remote wals

2018-04-13 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437133#comment-16437133
 ] 

Hudson commented on HBASE-20163:


Results for branch HBASE-19064
[build #96 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/96/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/96//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/96//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/96//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Forbid major compaction when standby cluster replay the remote wals
> ---
>
> Key: HBASE-20163
> URL: https://issues.apache.org/jira/browse/HBASE-20163
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-20163.HBASE-19064.001.patch, 
> HBASE-20163.HBASE-19064.002.patch, HBASE-20163.HBASE-19064.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (HBASE-20407) Retry HBase admin API if master failover is in progress

2018-04-13 Thread Peter Somogyi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi reassigned HBASE-20407:
-

Assignee: Divesh Jain

> Retry HBase admin API if master failover is in progress
> ---
>
> Key: HBASE-20407
> URL: https://issues.apache.org/jira/browse/HBASE-20407
> Project: HBase
>  Issue Type: Improvement
>  Components: Admin
>Reporter: Divesh Jain
>Assignee: Divesh Jain
>Priority: Minor
>
> When a master switch over is in progress and an admin API is called, perform 
> a retry operation before throwing an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20407) Retry HBase admin API if master failover is in progress

2018-04-13 Thread Peter Somogyi (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437132#comment-16437132
 ] 

Peter Somogyi commented on HBASE-20407:
---

[~jdivesh], I added you as a contributor and assigned the issue to you.

> Retry HBase admin API if master failover is in progress
> ---
>
> Key: HBASE-20407
> URL: https://issues.apache.org/jira/browse/HBASE-20407
> Project: HBase
>  Issue Type: Improvement
>  Components: Admin
>Reporter: Divesh Jain
>Assignee: Divesh Jain
>Priority: Minor
>
> When a master switch over is in progress and an admin API is called, perform 
> a retry operation before throwing an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20408) Plug-gable retry policy in all admin API's

2018-04-13 Thread Peter Somogyi (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437130#comment-16437130
 ] 

Peter Somogyi commented on HBASE-20408:
---

[~jdivesh], I added you as a contributor and assigned the issue to you.

> Plug-gable retry policy in all admin API's
> --
>
> Key: HBASE-20408
> URL: https://issues.apache.org/jira/browse/HBASE-20408
> Project: HBase
>  Issue Type: New Feature
>Reporter: Divesh Jain
>Assignee: Divesh Jain
>Priority: Major
>
> All admin API's that are retry able should support custom retry policy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (HBASE-20408) Plug-gable retry policy in all admin API's

2018-04-13 Thread Peter Somogyi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi reassigned HBASE-20408:
-

Assignee: Divesh Jain  (was: Divesh Jain)

> Plug-gable retry policy in all admin API's
> --
>
> Key: HBASE-20408
> URL: https://issues.apache.org/jira/browse/HBASE-20408
> Project: HBase
>  Issue Type: New Feature
>Reporter: Divesh Jain
>Assignee: Divesh Jain
>Priority: Major
>
> All admin API's that are retry able should support custom retry policy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (HBASE-20408) Plug-gable retry policy in all admin API's

2018-04-13 Thread Peter Somogyi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi reassigned HBASE-20408:
-

Assignee: Divesh Jain

> Plug-gable retry policy in all admin API's
> --
>
> Key: HBASE-20408
> URL: https://issues.apache.org/jira/browse/HBASE-20408
> Project: HBase
>  Issue Type: New Feature
>Reporter: Divesh Jain
>Assignee: Divesh Jain
>Priority: Major
>
> All admin API's that are retry able should support custom retry policy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20370) Also remove the wal file in remote cluster when we finish replicating a file

2018-04-13 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-20370:
--
Component/s: Replication

> Also remove the wal file in remote cluster when we finish replicating a file
> 
>
> Key: HBASE-20370
> URL: https://issues.apache.org/jira/browse/HBASE-20370
> Project: HBase
>  Issue Type: Sub-task
>  Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: HBASE-19064
>
> Attachments: HBASE-20370-HBASE-19064.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20370) Also remove the wal file in remote cluster when we finish replicating a file

2018-04-13 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-20370:
--
 Assignee: Duo Zhang
Fix Version/s: HBASE-19064
   Status: Patch Available  (was: Open)

> Also remove the wal file in remote cluster when we finish replicating a file
> 
>
> Key: HBASE-20370
> URL: https://issues.apache.org/jira/browse/HBASE-20370
> Project: HBase
>  Issue Type: Sub-task
>  Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: HBASE-19064
>
> Attachments: HBASE-20370-HBASE-19064.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20370) Also remove the wal file in remote cluster when we finish replicating a file

2018-04-13 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-20370:
--
Attachment: HBASE-20370-HBASE-19064.patch

> Also remove the wal file in remote cluster when we finish replicating a file
> 
>
> Key: HBASE-20370
> URL: https://issues.apache.org/jira/browse/HBASE-20370
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Duo Zhang
>Priority: Major
> Attachments: HBASE-20370-HBASE-19064.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20370) Also remove the wal file in remote cluster when we finish replicating a file

2018-04-13 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-20370:
--
Attachment: (was: HBASE-20377-v1.patch)

> Also remove the wal file in remote cluster when we finish replicating a file
> 
>
> Key: HBASE-20370
> URL: https://issues.apache.org/jira/browse/HBASE-20370
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Duo Zhang
>Priority: Major
> Attachments: HBASE-20370-HBASE-19064.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-20370) Also remove the wal file in remote cluster when we finish replicating a file

2018-04-13 Thread Duo Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-20370:
--
Attachment: HBASE-20377-v1.patch

> Also remove the wal file in remote cluster when we finish replicating a file
> 
>
> Key: HBASE-20370
> URL: https://issues.apache.org/jira/browse/HBASE-20370
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Duo Zhang
>Priority: Major
> Attachments: HBASE-20370-HBASE-19064.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20404) Ugly cleanerchore complaint that dir is not empty

2018-04-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437097#comment-16437097
 ] 

Hadoop QA commented on HBASE-20404:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
10s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m  
2s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
15s{color} | {color:red} hbase-server: The patch generated 1 new + 3 unchanged 
- 0 fixed = 4 total (was 3) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
12s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
16m 27s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}164m 
26s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}215m  7s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20404 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12918890/HBASE-20404.0.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux cd1b7a82bc96 4.4.0-104-generic #127-Ubuntu SMP Mon Dec 11 
12:16:42 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / d59a6c8166 |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12431/artifact/patchprocess/diff-checkstyle-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12431/testReport/ |
| Max. 

[jira] [Commented] (HBASE-20395) Displaying thrift server type on the thrift page

2018-04-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437086#comment-16437086
 ] 

Hadoop QA commented on HBASE-20395:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
 5s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue}  3m 
45s{color} | {color:blue} branch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. {color} 
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 0s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m  
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m 
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 
25s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  7m 25s{color} 
| {color:red} root generated 2 new + 1297 unchanged - 0 fixed = 1299 total (was 
1297) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
 1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 39 line(s) that end in whitespace. Use 
git apply --whitespace=fix <>. Refer 
https://git-scm.com/docs/git-apply {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue}  3m 
18s{color} | {color:blue} patch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. {color} 
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 0s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
15m 44s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m 
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}200m 
14s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
53s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}278m 57s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| D

[jira] [Updated] (HBASE-20344) Fix asciidoc warnings

2018-04-13 Thread Peter Somogyi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-20344:
--
   Resolution: Fixed
Fix Version/s: 3.0.0
   Status: Resolved  (was: Patch Available)

Thanks for the review [~busbey]. Pushed to master.

> Fix asciidoc warnings
> -
>
> Key: HBASE-20344
> URL: https://issues.apache.org/jira/browse/HBASE-20344
> Project: HBase
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 2.0.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20344.master.001.patch, 
> HBASE-20344.master.001.patch, HBASE-20344.master.002.patch
>
>
> IntelliJ shows some warnings for asciidoc files.
> 1. Markdown Style Heading:
> \### Required properties
>  
> 2. Asciidoc Old Style Heading:
> Creating a New Table with Compression On a ColumnFamily
>  
>  \
> hbase> create 'test2', \{ NAME => 'cf2', COMPRESSION => 'SNAPPY' }
>  \
>  
> 3. Warning during build
> asciidoctor: WARNING: _chapters/troubleshooting.adoc: line 105: invalid style 
> for listing block: NOTE



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (HBASE-20407) Retry HBase admin API if master failover is in progress

2018-04-13 Thread Amit Kabra (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Kabra reassigned HBASE-20407:
--

Assignee: (was: Amit Kabra)

> Retry HBase admin API if master failover is in progress
> ---
>
> Key: HBASE-20407
> URL: https://issues.apache.org/jira/browse/HBASE-20407
> Project: HBase
>  Issue Type: Improvement
>  Components: Admin
>Reporter: Divesh Jain
>Priority: Minor
>
> When a master switch over is in progress and an admin API is called, perform 
> a retry operation before throwing an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (HBASE-20407) Retry HBase admin API if master failover is in progress

2018-04-13 Thread Amit Kabra (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-20407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Kabra reassigned HBASE-20407:
--

Assignee: Amit Kabra

> Retry HBase admin API if master failover is in progress
> ---
>
> Key: HBASE-20407
> URL: https://issues.apache.org/jira/browse/HBASE-20407
> Project: HBase
>  Issue Type: Improvement
>  Components: Admin
>Reporter: Divesh Jain
>Assignee: Amit Kabra
>Priority: Minor
>
> When a master switch over is in progress and an admin API is called, perform 
> a retry operation before throwing an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (HBASE-20407) Retry HBase admin API if master failover is in progress

2018-04-13 Thread Divesh Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437048#comment-16437048
 ] 

Divesh Jain edited comment on HBASE-20407 at 4/13/18 9:12 AM:
--

Fixing this issue. But for some reason unable to assign this issue it to myself.


was (Author: jdivesh):
Fixing this issue. But for some reason unable to assign it to myself.

> Retry HBase admin API if master failover is in progress
> ---
>
> Key: HBASE-20407
> URL: https://issues.apache.org/jira/browse/HBASE-20407
> Project: HBase
>  Issue Type: Improvement
>  Components: Admin
>Reporter: Divesh Jain
>Priority: Minor
>
> When a master switch over is in progress and an admin API is called, perform 
> a retry operation before throwing an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (HBASE-20408) Plug-gable retry policy in all admin API's

2018-04-13 Thread Divesh Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437049#comment-16437049
 ] 

Divesh Jain edited comment on HBASE-20408 at 4/13/18 9:12 AM:
--

Fixing this issue. But for some reason unable to assign this feature to myself.


was (Author: jdivesh):
Fixing this issue. But for some reason unable to assign it to myself.

> Plug-gable retry policy in all admin API's
> --
>
> Key: HBASE-20408
> URL: https://issues.apache.org/jira/browse/HBASE-20408
> Project: HBase
>  Issue Type: New Feature
>Reporter: Divesh Jain
>Priority: Major
>
> All admin API's that are retry able should support custom retry policy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20408) Plug-gable retry policy in all admin API's

2018-04-13 Thread Divesh Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437049#comment-16437049
 ] 

Divesh Jain commented on HBASE-20408:
-

Fixing this issue. But for some reason unable to assign it to myself.

> Plug-gable retry policy in all admin API's
> --
>
> Key: HBASE-20408
> URL: https://issues.apache.org/jira/browse/HBASE-20408
> Project: HBase
>  Issue Type: New Feature
>Reporter: Divesh Jain
>Priority: Major
>
> All admin API's that are retry able should support custom retry policy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20407) Retry HBase admin API if master failover is in progress

2018-04-13 Thread Divesh Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437048#comment-16437048
 ] 

Divesh Jain commented on HBASE-20407:
-

Fixing this issue. But for some reason unable to assign it to myself.

> Retry HBase admin API if master failover is in progress
> ---
>
> Key: HBASE-20407
> URL: https://issues.apache.org/jira/browse/HBASE-20407
> Project: HBase
>  Issue Type: Improvement
>  Components: Admin
>Reporter: Divesh Jain
>Priority: Minor
>
> When a master switch over is in progress and an admin API is called, perform 
> a retry operation before throwing an exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20368) Fix RIT stuck when a rsgroup has no online servers but AM's pendingAssginQueue is cleared

2018-04-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437037#comment-16437037
 ] 

Hadoop QA commented on HBASE-20368:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  3m  
1s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m  
4s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
17s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
7s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
14s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
36s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
15s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
49s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m  
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
41s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
10m 15s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}160m 
36s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  5m  
1s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
31s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}210m  8s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:dba4808 |
| JIRA Issue | HBASE-20368 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12918886/HBASE-20368.branch-2.003.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 01c46b05a25d 4.4.0-116-generic #140-Ubuntu SMP Mon Feb 12 
21:23:04 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | branch-2 / b1901c9a15 |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Def

[jira] [Commented] (HBASE-20389) Move website building flags into a profile

2018-04-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437023#comment-16437023
 ] 

Hadoop QA commented on HBASE-20389:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
3s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
15s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  6m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
28s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
13m 34s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}208m 16s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
24s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}257m 45s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.procedure.TestCreateTableProcedure |
|   | hadoop.hbase.client.TestMvccConsistentScanner |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20389 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12918865/HBASE-20389.0.patch |
| Optional Tests |  asflicense  shellcheck  shelldocs  javac  javadoc  unit  
shadedjars  hadoopcheck  xml  compile  |
| uname | Linux 8a5901f2ef52 4.4.0-89-generic #112-Ubuntu SMP Mon Jul 31 
19:38:41 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / d59a6c8166 |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| shellcheck | v0.4.4 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12423/artifact/patchprocess/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12423/testReport/ |
| Max. process+thread count | 4372 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12423/console |
| Powered by | A

[jira] [Commented] (HBASE-20349) [DOC] upgrade guide should call out removal of prefix-tree data block encoding

2018-04-13 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437003#comment-16437003
 ] 

Hudson commented on HBASE-20349:


Results for branch master
[build #297 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/297/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/297//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/297//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/297//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> [DOC] upgrade guide should call out removal of prefix-tree data block encoding
> --
>
> Key: HBASE-20349
> URL: https://issues.apache.org/jira/browse/HBASE-20349
> Project: HBase
>  Issue Type: Sub-task
>  Components: documentation
>Reporter: Sean Busbey
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-20349.master.001.patch, 
> HBASE-20349.master.002.patch
>
>
> See HBASE-19179. Needs to be in the upgrade section. Right now there's just 
> an offhand mention in Appendix E about the removal.
> Since we can no longer read data encoded with prefix tree, we should include 
> instructions on rewriting data.
> Also ensure we don't have spurious references to it. (the help from ltt 
> that's in the ref guide still lists it, for example).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20356) protoc 3.5.1 can't compile on rhel6

2018-04-13 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437007#comment-16437007
 ] 

Hudson commented on HBASE-20356:


Results for branch master
[build #297 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/297/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/297//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/297//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/297//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> protoc 3.5.1 can't compile on rhel6
> ---
>
> Key: HBASE-20356
> URL: https://issues.apache.org/jira/browse/HBASE-20356
> Project: HBase
>  Issue Type: Bug
>  Components: dependencies, thirdparty
>Affects Versions: 2.0.0-beta-2
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Critical
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20356.patch, HBASE-20356.v2.patch, 
> HBASE-20356.v3.patch
>
>
> We upgraded our internal protoc version, and now can't build on RHEL6.
> I get this build error:
> {noformat}
> 2018-04-05 08:15:21.929278 [ERROR] PROTOC FAILED: ... /lib64/libc.so.6: 
> version `GLIBC_2.14' not found
> {noformat}
> See https://github.com/google/protobuf/issues/4109
> And this has come up before in https://github.com/google/protobuf/issues/3718
> Looks like we need to be on 3.4.0, unless there's a compelling reason to be 
> on something newer? Maybe roll back all the way to 3.3.0 which is what we 
> were on before... was there a specific bug we needed to get addressed?
> cc: [~elserj] [~stack]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20329) Add note for operators to refguide on AsyncFSWAL

2018-04-13 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437009#comment-16437009
 ] 

Hudson commented on HBASE-20329:


Results for branch master
[build #297 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/297/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/297//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/297//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/297//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Add note for operators to refguide on AsyncFSWAL
> 
>
> Key: HBASE-20329
> URL: https://issues.apache.org/jira/browse/HBASE-20329
> Project: HBase
>  Issue Type: Sub-task
>  Components: documentation, wal
>Reporter: stack
>Assignee: stack
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HBASE-20329.master.001.patch
>
>
> Need a few notes in refguide on this new facility.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


<    1   2   3   >