[GitHub] [hbase] infraio commented on a change in pull request #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr…
infraio commented on a change in pull request #1243: HBASE-23944 The method
setClusterLoad of SimpleLoadBalancer is incorr…
URL: https://github.com/apache/hbase/pull/1243#discussion_r388758950
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestDefaultLoadBalancer.java
##
@@ -171,20 +171,33 @@ public void testBalanceClusterOverall() throws Exception
{
*/
@Test
public void testImpactOfBalanceClusterOverall() throws Exception {
+testImpactOfBalanceClusterOverall(false);
+ }
+
+ @Test
+ public void testImpactOfBalanceClusterOverallWithTableClusterLoad() throws
Exception {
+testImpactOfBalanceClusterOverall(true);
+ }
+
+ private void testImpactOfBalanceClusterOverall(boolean useTableClusterLoad)
throws Exception {
Map>> clusterLoad = new
TreeMap<>();
Map> clusterServers =
mockUniformClusterServers(mockUniformCluster);
List clusterList = convertToList(clusterServers);
clusterLoad.put(TableName.valueOf(name.getMethodName()), clusterServers);
// use overall can achieve both table and cluster level balance
-HashMap>> result1 =
mockClusterServersWithTables(clusterServers);
-loadBalancer.setClusterLoad(clusterLoad);
+Map>> result1 =
mockClusterServersWithTables(clusterServers);
Review comment:
The difference of results1 and clusterLoad is?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr…
infraio commented on a change in pull request #1243: HBASE-23944 The method
setClusterLoad of SimpleLoadBalancer is incorr…
URL: https://github.com/apache/hbase/pull/1243#discussion_r388758807
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java
##
@@ -402,13 +402,13 @@ protected void updateLoad(final Map map,
return servers;
}
- protected HashMap>>
mockClusterServersWithTables(Map> clusterServers) {
-HashMap>> result = new
HashMap<>();
+ protected Map>>
mockClusterServersWithTables(Map> clusterServers) {
Review comment:
Why change TreeMap to Map?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr…
Apache-HBase commented on issue #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr… URL: https://github.com/apache/hbase/pull/1243#issuecomment-595651831 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 22s | master passed | | +1 :green_heart: | compile | 1m 12s | master passed | | +1 :green_heart: | shadedjars | 5m 35s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 7s | the patch passed | | +1 :green_heart: | compile | 1m 12s | the patch passed | | +1 :green_heart: | javac | 1m 12s | the patch passed | | +1 :green_heart: | shadedjars | 5m 27s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 6m 56s | hbase-server in the patch failed. | | | | 38m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1243 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 28df17da8449 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4ef326be15 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/testReport/ | | Max. process+thread count | 1099 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] nyl3532016 commented on a change in pull request #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr…
nyl3532016 commented on a change in pull request #1243: HBASE-23944 The method
setClusterLoad of SimpleLoadBalancer is incorr…
URL: https://github.com/apache/hbase/pull/1243#discussion_r388762315
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java
##
@@ -402,13 +402,13 @@ protected void updateLoad(final Map map,
return servers;
}
- protected HashMap>>
mockClusterServersWithTables(Map> clusterServers) {
-HashMap>> result = new
HashMap<>();
+ protected Map>>
mockClusterServersWithTables(Map> clusterServers) {
Review comment:
use the return value of method mockClusterServersWithTables as clusterLoad
the extend feature of treeMap is no use , Map is enough
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr…
Apache-HBase commented on issue #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr… URL: https://github.com/apache/hbase/pull/1243#issuecomment-595655907 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 50s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 25s | master passed | | +1 :green_heart: | checkstyle | 1m 19s | master passed | | +0 :ok: | spotbugs | 4m 53s | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 :x: | findbugs | 3m 24s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 47s | the patch passed | | -0 :warning: | checkstyle | 1m 19s | hbase-server: The patch generated 8 new + 146 unchanged - 7 fixed = 154 total (was 153) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 11s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 :x: | findbugs | 3m 21s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 50m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1243 | | Optional Tests | dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 16d57915a67b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4ef326be15 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/artifact/yetus-general-check/output/branch-findbugs-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] nyl3532016 commented on a change in pull request #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr…
nyl3532016 commented on a change in pull request #1243: HBASE-23944 The method
setClusterLoad of SimpleLoadBalancer is incorr…
URL: https://github.com/apache/hbase/pull/1243#discussion_r388766538
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestDefaultLoadBalancer.java
##
@@ -171,20 +171,33 @@ public void testBalanceClusterOverall() throws Exception
{
*/
@Test
public void testImpactOfBalanceClusterOverall() throws Exception {
+testImpactOfBalanceClusterOverall(false);
+ }
+
+ @Test
+ public void testImpactOfBalanceClusterOverallWithTableClusterLoad() throws
Exception {
+testImpactOfBalanceClusterOverall(true);
+ }
+
+ private void testImpactOfBalanceClusterOverall(boolean useTableClusterLoad)
throws Exception {
Map>> clusterLoad = new
TreeMap<>();
Map> clusterServers =
mockUniformClusterServers(mockUniformCluster);
List clusterList = convertToList(clusterServers);
clusterLoad.put(TableName.valueOf(name.getMethodName()), clusterServers);
// use overall can achieve both table and cluster level balance
-HashMap>> result1 =
mockClusterServersWithTables(clusterServers);
-loadBalancer.setClusterLoad(clusterLoad);
+Map>> result1 =
mockClusterServersWithTables(clusterServers);
Review comment:
clusterLoad's value is map (server to all region on it , whatever region's
table), clusterLoad's key is no use
results1's value is map(server to region ,the region only belong to the key
table), results1's key is actual tableName
in balance by table, we should use results1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-23944) The method setClusterLoad of SimpleLoadBalancer is incorrect when balance by table
[
https://issues.apache.org/jira/browse/HBASE-23944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-23944:
--
Fix Version/s: (was: 2.2.2)
2.2.5
> The method setClusterLoad of SimpleLoadBalancer is incorrect when balance by
> table
> ---
>
> Key: HBASE-23944
> URL: https://issues.apache.org/jira/browse/HBASE-23944
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 2.2.2
>Reporter: niuyulin
>Assignee: niuyulin
>Priority: Major
> Fix For: 3.0.0, 2.2.5
>
>
> now if in parameter clusterLoad is by table, for example
> {code:java}
> table1=>
> server1=>[table1,region1]
> server2=>[]
> table2=>
> server1=>[table2,region1]
> server2=>[]
> {code}
> then, the member variable serverLoadList is:
> {code:java}
> [{server1, load 1}{server2, load 0}{server1, load 1} {server2, load 0}]
> {code}
> the cluster will be considered balanced in method overallNeedsBalance
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] pankaj72981 commented on a change in pull request #1223: HBASE-23739 BoundedRecoveredHFilesOutputSink should read the table de…
pankaj72981 commented on a change in pull request #1223: HBASE-23739
BoundedRecoveredHFilesOutputSink should read the table de…
URL: https://github.com/apache/hbase/pull/1223#discussion_r387445203
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
##
@@ -114,20 +118,24 @@
@VisibleForTesting
WALSplitter(final WALFactory factory, Configuration conf, Path walDir,
FileSystem walFS,
-LastSequenceId idChecker, SplitLogWorkerCoordination
splitLogWorkerCoordination) {
+ Path rootDir, FileSystem rootFS, LastSequenceId idChecker,
+ SplitLogWorkerCoordination splitLogWorkerCoordination) {
this.conf = HBaseConfiguration.create(conf);
String codecClassName =
conf.get(WALCellCodec.WAL_CELL_CODEC_CLASS_KEY,
WALCellCodec.class.getName());
this.conf.set(HConstants.RPC_CODEC_CONF_KEY, codecClassName);
this.walDir = walDir;
this.walFS = walFS;
+this.rootDir = rootDir;
+this.rootFS = rootFS;
this.sequenceIdChecker = idChecker;
this.splitLogWorkerCoordination = splitLogWorkerCoordination;
this.walFactory = factory;
PipelineController controller = new PipelineController();
this.tmpDirName =
conf.get(HConstants.TEMPORARY_FS_DIRECTORY_KEY,
HConstants.DEFAULT_TEMPORARY_HDFS_DIRECTORY);
+this.tableDescriptors = new FSTableDescriptors(rootFS, rootDir, true,
true);
Review comment:
We should reuse the RegionServer FSTableDescriptors instead of creating
FSTableDescriptors instance for each WAL split.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] pankaj72981 closed pull request #1223: HBASE-23739 BoundedRecoveredHFilesOutputSink should read the table de…
pankaj72981 closed pull request #1223: HBASE-23739 BoundedRecoveredHFilesOutputSink should read the table de… URL: https://github.com/apache/hbase/pull/1223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio opened a new pull request #1223: HBASE-23739 BoundedRecoveredHFilesOutputSink should read the table de…
infraio opened a new pull request #1223: HBASE-23739 BoundedRecoveredHFilesOutputSink should read the table de… URL: https://github.com/apache/hbase/pull/1223 …scriptor directly This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] pankaj72981 commented on a change in pull request #1223: HBASE-23739 BoundedRecoveredHFilesOutputSink should read the table de…
pankaj72981 commented on a change in pull request #1223: HBASE-23739
BoundedRecoveredHFilesOutputSink should read the table de…
URL: https://github.com/apache/hbase/pull/1223#discussion_r387445203
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
##
@@ -114,20 +118,24 @@
@VisibleForTesting
WALSplitter(final WALFactory factory, Configuration conf, Path walDir,
FileSystem walFS,
-LastSequenceId idChecker, SplitLogWorkerCoordination
splitLogWorkerCoordination) {
+ Path rootDir, FileSystem rootFS, LastSequenceId idChecker,
+ SplitLogWorkerCoordination splitLogWorkerCoordination) {
this.conf = HBaseConfiguration.create(conf);
String codecClassName =
conf.get(WALCellCodec.WAL_CELL_CODEC_CLASS_KEY,
WALCellCodec.class.getName());
this.conf.set(HConstants.RPC_CODEC_CONF_KEY, codecClassName);
this.walDir = walDir;
this.walFS = walFS;
+this.rootDir = rootDir;
+this.rootFS = rootFS;
this.sequenceIdChecker = idChecker;
this.splitLogWorkerCoordination = splitLogWorkerCoordination;
this.walFactory = factory;
PipelineController controller = new PipelineController();
this.tmpDirName =
conf.get(HConstants.TEMPORARY_FS_DIRECTORY_KEY,
HConstants.DEFAULT_TEMPORARY_HDFS_DIRECTORY);
+this.tableDescriptors = new FSTableDescriptors(rootFS, rootDir, true,
true);
Review comment:
We should reuse the RegionServer FSTableDescriptors instead of creating
FSTableDescriptors instance for each WAL split.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr…
Apache-HBase commented on issue #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr… URL: https://github.com/apache/hbase/pull/1243#issuecomment-595670537 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 49s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 4m 48s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 19s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 4m 49s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 65m 11s | hbase-server in the patch failed. | | | | 91m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1243 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a3c5e8f11540 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4ef326be15 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/testReport/ | | Max. process+thread count | 8270 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…
Apache9 commented on a change in pull request #1221: HBASE-23895 STUCK
Region-In-Transition when failed to insert procedur…
URL: https://github.com/apache/hbase/pull/1221#discussion_r388784471
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
##
@@ -547,6 +551,10 @@ public void insert(Procedure proc, Procedure[]
subProcs) {
}
List mutations = new ArrayList<>(subProcs.length + 1);
List rowsToLock = new ArrayList<>(subProcs.length + 1);
+// Insert procedure may be called by master's rpc call. There are some
check about the rpc call
+// when mutate region. Here unset the current rpc call and set it back in
finally block.
+// See HBASE-23895 for more details.
+Optional rpcCall = RpcServer.unsetCurrentCall();
Review comment:
Pity we have to write the comment three times...
Can be a follow on, to abstract a method for this logic...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] wchevreuil merged pull request #1239: HBASE-23939 Remove unused variables from HBaseSaslRpcServer
wchevreuil merged pull request #1239: HBASE-23939 Remove unused variables from HBaseSaslRpcServer URL: https://github.com/apache/hbase/pull/1239 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23939) Remove unused variables from HBaseSaslRpcServer
[ https://issues.apache.org/jira/browse/HBASE-23939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23939: - Fix Version/s: 3.0.0 > Remove unused variables from HBaseSaslRpcServer > --- > > Key: HBASE-23939 > URL: https://issues.apache.org/jira/browse/HBASE-23939 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.3 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Trivial > Fix For: 3.0.0 > > > On *HBaseSaslRpcServer*, there's currently an unused _Logger_ variable, as > well as an unused _Configuration_ parameter defined on *HBaseSaslRpcServer* > constructor. *HBaseSaslRpcServer* is IA private, and its constructor is only > referenced by *ServerRpcConnection,* so it should be fine to change > constructor signature to get rid of the unused parameter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23939) Remove unused variables from HBaseSaslRpcServer
[ https://issues.apache.org/jira/browse/HBASE-23939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23939: - Affects Version/s: 3.0.0 2.2.3 > Remove unused variables from HBaseSaslRpcServer > --- > > Key: HBASE-23939 > URL: https://issues.apache.org/jira/browse/HBASE-23939 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.3 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Trivial > > On *HBaseSaslRpcServer*, there's currently an unused _Logger_ variable, as > well as an unused _Configuration_ parameter defined on *HBaseSaslRpcServer* > constructor. *HBaseSaslRpcServer* is IA private, and its constructor is only > referenced by *ServerRpcConnection,* so it should be fine to change > constructor signature to get rid of the unused parameter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23939) Remove unused variables from HBaseSaslRpcServer
[ https://issues.apache.org/jira/browse/HBASE-23939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23939: - Affects Version/s: 2.3.0 > Remove unused variables from HBaseSaslRpcServer > --- > > Key: HBASE-23939 > URL: https://issues.apache.org/jira/browse/HBASE-23939 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.3.0, 2.2.3 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Trivial > Fix For: 3.0.0 > > > On *HBaseSaslRpcServer*, there's currently an unused _Logger_ variable, as > well as an unused _Configuration_ parameter defined on *HBaseSaslRpcServer* > constructor. *HBaseSaslRpcServer* is IA private, and its constructor is only > referenced by *ServerRpcConnection,* so it should be fine to change > constructor signature to get rid of the unused parameter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23788) ROW_INDEX_V1 encoder should consider the secondary index size with the encoded data size tracking
[
https://issues.apache.org/jira/browse/HBASE-23788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053245#comment-17053245
]
Hudson commented on HBASE-23788:
Results for branch branch-2
[build #2536 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2536/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2536//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2536//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2536//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2536//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> ROW_INDEX_V1 encoder should consider the secondary index size with the
> encoded data size tracking
> -
>
> Key: HBASE-23788
> URL: https://issues.apache.org/jira/browse/HBASE-23788
> Project: HBase
> Issue Type: Sub-task
>Reporter: Anoop Sam John
>Assignee: Abhinaba Sarkar
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Copied from parent issue comments
> "In case of Row Index this tracking is not accounting the row offsets index
> being written. Because on the go these are kept in memory only and written at
> the end of block write. This end block decision was based on size check only
> which did NOT include this offsets index."
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23939) Remove unused variables from HBaseSaslRpcServer
[ https://issues.apache.org/jira/browse/HBASE-23939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23939: - Affects Version/s: (was: 2.2.3) > Remove unused variables from HBaseSaslRpcServer > --- > > Key: HBASE-23939 > URL: https://issues.apache.org/jira/browse/HBASE-23939 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.3.0 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Trivial > Fix For: 3.0.0 > > > On *HBaseSaslRpcServer*, there's currently an unused _Logger_ variable, as > well as an unused _Configuration_ parameter defined on *HBaseSaslRpcServer* > constructor. *HBaseSaslRpcServer* is IA private, and its constructor is only > referenced by *ServerRpcConnection,* so it should be fine to change > constructor signature to get rid of the unused parameter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23939) Remove unused variables from HBaseSaslRpcServer
[ https://issues.apache.org/jira/browse/HBASE-23939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-23939. -- Resolution: Fixed Merged into master and branch-2. > Remove unused variables from HBaseSaslRpcServer > --- > > Key: HBASE-23939 > URL: https://issues.apache.org/jira/browse/HBASE-23939 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.3.0 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Trivial > Fix For: 3.0.0, 2.3.0 > > > On *HBaseSaslRpcServer*, there's currently an unused _Logger_ variable, as > well as an unused _Configuration_ parameter defined on *HBaseSaslRpcServer* > constructor. *HBaseSaslRpcServer* is IA private, and its constructor is only > referenced by *ServerRpcConnection,* so it should be fine to change > constructor signature to get rid of the unused parameter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23939) Remove unused variables from HBaseSaslRpcServer
[ https://issues.apache.org/jira/browse/HBASE-23939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23939: - Fix Version/s: 2.3.0 > Remove unused variables from HBaseSaslRpcServer > --- > > Key: HBASE-23939 > URL: https://issues.apache.org/jira/browse/HBASE-23939 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.3.0 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Trivial > Fix For: 3.0.0, 2.3.0 > > > On *HBaseSaslRpcServer*, there's currently an unused _Logger_ variable, as > well as an unused _Configuration_ parameter defined on *HBaseSaslRpcServer* > constructor. *HBaseSaslRpcServer* is IA private, and its constructor is only > referenced by *ServerRpcConnection,* so it should be fine to change > constructor signature to get rid of the unused parameter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #1217: HBASE-23891: Add an option to Actions to filter out meta RS
BukrosSzabolcs commented on a change in pull request #1217: HBASE-23891: Add an
option to Actions to filter out meta RS
URL: https://github.com/apache/hbase/pull/1217#discussion_r388824781
##
File path:
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MobNoKillMonkeyFactory.java
##
@@ -75,7 +75,7 @@
Action[] actions4 = new Action[] { new DumpClusterStatusAction() };
-return new PolicyBasedChaosMonkey(util,
+return new PolicyBasedChaosMonkey(properties, util,
Review comment:
I kind of had to. The issue was that Actions do not have access to these
properties. This is the main reason we have this clutter in factories where we
read the properties and pass them along to the actions in the action
constructor, when it could have been an internal thing. So I looked for a way
to get these properties to them. (It was a minor issue that Action.init could
not use these properties and had to rely on the default values from the config.
Passing it along fixed this too.) Anyway the best way to do this was through
PolicyBasedChaosMonkey and PolicyContext. Technically I could have just created
a setter on PolicyBasedChaosMonkey and leave the constructor alone and call the
setter from IntegrationTestBase, but it felt like a bad practice to circumvent
a factory.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] wchevreuil merged pull request #54: HBASE-23934 [operator tools] Add forbiddennapis plugin to pom.xml so …
wchevreuil merged pull request #54: HBASE-23934 [operator tools] Add forbiddennapis plugin to pom.xml so … URL: https://github.com/apache/hbase-operator-tools/pull/54 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23934) [operator tools] Add forbiddennapis plugin to pom.xml so that we can permanently ban references to hbase I.A. private classes from hbck2
[ https://issues.apache.org/jira/browse/HBASE-23934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23934: - Affects Version/s: hbase-operator-tools-1.0.0 > [operator tools] Add forbiddennapis plugin to pom.xml so that we can > permanently ban references to hbase I.A. private classes from hbck2 > > > Key: HBASE-23934 > URL: https://issues.apache.org/jira/browse/HBASE-23934 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools >Affects Versions: hbase-operator-tools-1.0.0 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Major > > Following suggestion from [~elserj] on PR for HBASE-23791, this adds > _forbiddenapis_ plugin to hbck2 pom.xml file, defining a ban to > *MetaTableAccessor.* This also gets rid of one remaining reference to > *MetaTableAccessor* on *HBCKMetaTableAccessor* that we missed to detect in > HBASE-23791. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23934) [operator tools] Add forbiddennapis plugin to pom.xml so that we can permanently ban references to hbase I.A. private classes from hbck2
[ https://issues.apache.org/jira/browse/HBASE-23934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-23934. -- Resolution: Fixed Merged into operator tools master branch. > [operator tools] Add forbiddennapis plugin to pom.xml so that we can > permanently ban references to hbase I.A. private classes from hbck2 > > > Key: HBASE-23934 > URL: https://issues.apache.org/jira/browse/HBASE-23934 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools >Affects Versions: hbase-operator-tools-1.0.0 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Major > Fix For: hbase-operator-tools-1.1.0 > > > Following suggestion from [~elserj] on PR for HBASE-23791, this adds > _forbiddenapis_ plugin to hbck2 pom.xml file, defining a ban to > *MetaTableAccessor.* This also gets rid of one remaining reference to > *MetaTableAccessor* on *HBCKMetaTableAccessor* that we missed to detect in > HBASE-23791. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23934) [operator tools] Add forbiddennapis plugin to pom.xml so that we can permanently ban references to hbase I.A. private classes from hbck2
[ https://issues.apache.org/jira/browse/HBASE-23934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23934: - Fix Version/s: hbase-operator-tools-1.1.0 > [operator tools] Add forbiddennapis plugin to pom.xml so that we can > permanently ban references to hbase I.A. private classes from hbck2 > > > Key: HBASE-23934 > URL: https://issues.apache.org/jira/browse/HBASE-23934 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools >Affects Versions: hbase-operator-tools-1.0.0 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Major > Fix For: hbase-operator-tools-1.1.0 > > > Following suggestion from [~elserj] on PR for HBASE-23791, this adds > _forbiddenapis_ plugin to hbck2 pom.xml file, defining a ban to > *MetaTableAccessor.* This also gets rid of one remaining reference to > *MetaTableAccessor* on *HBCKMetaTableAccessor* that we missed to detect in > HBASE-23791. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] wchevreuil merged pull request #1217: HBASE-23891: Add an option to Actions to filter out meta RS
wchevreuil merged pull request #1217: HBASE-23891: Add an option to Actions to filter out meta RS URL: https://github.com/apache/hbase/pull/1217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1217: HBASE-23891: Add an option to Actions to filter out meta RS
Apache-HBase commented on issue #1217: HBASE-23891: Add an option to Actions to filter out meta RS URL: https://github.com/apache/hbase/pull/1217#issuecomment-595716940 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 47s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 33s | master passed | | +1 :green_heart: | compile | 0m 30s | master passed | | +1 :green_heart: | shadedjars | 5m 30s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 2s | the patch passed | | +1 :green_heart: | compile | 0m 31s | the patch passed | | +1 :green_heart: | javac | 0m 31s | the patch passed | | +1 :green_heart: | shadedjars | 5m 20s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 53s | hbase-it in the patch passed. | | | | 28m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1217 | | JIRA Issue | HBASE-23891 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d61998cc957c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9c67abef18 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/testReport/ | | Max. process+thread count | 392 (vs. ulimit of 1) | | modules | C: hbase-it U: hbase-it | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1217: HBASE-23891: Add an option to Actions to filter out meta RS
Apache-HBase commented on issue #1217: HBASE-23891: Add an option to Actions to filter out meta RS URL: https://github.com/apache/hbase/pull/1217#issuecomment-595718273 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 48s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 51s | master passed | | +1 :green_heart: | compile | 0m 40s | master passed | | +1 :green_heart: | shadedjars | 5m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 20s | the patch passed | | +1 :green_heart: | compile | 0m 36s | the patch passed | | +1 :green_heart: | javac | 0m 36s | the patch passed | | +1 :green_heart: | shadedjars | 5m 44s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 55s | hbase-it in the patch passed. | | | | 32m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1217 | | JIRA Issue | HBASE-23891 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3849c7b9c56b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9c67abef18 | | Default Java | 2020-01-14 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/testReport/ | | Max. process+thread count | 423 (vs. ulimit of 1) | | modules | C: hbase-it U: hbase-it | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio merged pull request #1223: HBASE-23739 BoundedRecoveredHFilesOutputSink should read the table de…
infraio merged pull request #1223: HBASE-23739 BoundedRecoveredHFilesOutputSink should read the table de… URL: https://github.com/apache/hbase/pull/1223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1217: HBASE-23891: Add an option to Actions to filter out meta RS
Apache-HBase commented on issue #1217: HBASE-23891: Add an option to Actions to filter out meta RS URL: https://github.com/apache/hbase/pull/1217#issuecomment-595720623 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 5s | master passed | | +1 :green_heart: | checkstyle | 0m 19s | master passed | | +0 :ok: | spotbugs | 0m 29s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 0m 0s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 37s | the patch passed | | +1 :green_heart: | checkstyle | 0m 18s | hbase-it: The patch generated 0 new + 122 unchanged - 1 fixed = 122 total (was 123) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 54s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | findbugs | 0m 0s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 38m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1217 | | JIRA Issue | HBASE-23891 | | Optional Tests | dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle | | uname | Linux df0fa84e8ffa 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9c67abef18 | | Max. process+thread count | 63 (vs. ulimit of 1) | | modules | C: hbase-it U: hbase-it | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1217/4/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…
Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur… URL: https://github.com/apache/hbase/pull/1221#issuecomment-595725713 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 34s | master passed | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 44s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 13s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | +1 :green_heart: | shadedjars | 4m 56s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 5m 13s | hbase-server in the patch failed. | | | | 33m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1221 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 378b5d3343a3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4cb60327be | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/testReport/ | | Max. process+thread count | 1110 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23909) list_regions fails if table is under split
[
https://issues.apache.org/jira/browse/HBASE-23909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053315#comment-17053315
]
Hudson commented on HBASE-23909:
Results for branch master
[build #1656 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1656/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1656//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1656//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1656//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1656//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> list_regions fails if table is under split
> --
>
> Key: HBASE-23909
> URL: https://issues.apache.org/jira/browse/HBASE-23909
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.6.0
>Reporter: Peter Somogyi
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.2.4, 2.1.10
>
>
> Shortly after executing split 'table' command from the shell the list_regions
> 'table' fails with "ERROR: undefined method `toString' for nil:NilClass"
>
> {noformat}
> hbase(main):002:0> list_regions 'cluster_test'
> SERVER_NAME |
>REGION_NAME | START_KEY |END_KEY | SIZE | REQ |
> LOCALITY |
> --- |
> - |
> -- | -- | - | | -- |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.857a9b734a2f490e573ba20b1bbf99b3. ||
> | 3348 | 20408042 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.1749360028b3a5e76b5da1d1888e5b9d. |
> | | 3321 | 20242123 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.1f1366aa0ee621d496103ac5a50bca77. |
> | | 3316 | 20215774 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.ae95589c9498443a89aea4c42c199372. |
> | | 3327 | 20285312 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.239647c37e27cbd3154180ce5004a1ea. |
> || 3355 | 20451469 |0.0 |
> 5 rows
> hbase(main):003:0> split 'cluster_test'
> 0 row(s) in 0.2240 seconds
> hbase(main):004:0> list_regions 'cluster_test'
> ERROR: undefined method `toString' for nil:NilClass
> Here is some help for this command:
> List all regions for a particular table as an array and also filter
> them by server name (optional) as prefix
> and maximum locality (optional). By default, it will return all the
> regions for the table with any locality.
> The command displays server name, region name, start key, end key,
> size of the region in MB, number of requests
> and the locality. The information can be projected out via an array
> as third parameter. By default all these information
> is displayed. Possible array values are SERVER_NAME, REGION_NAME,
> START_KEY, END_KEY, SIZE, REQ and LOCALITY. Values
> are not case sensitive. If you don't want to filter by server name,
> pass an empty hash / string as shown below.
> Examples:
> hbase> list_regions 'table_name'
> hbase> list_regions 'table_name', 'server_name'
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name',
> LOCALITY_THRESHOLD => 0.8}
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name',
> LOCALITY_THRESHOLD => 0.8}, ['SERVER_NAME']
> hbase> list_regions 'table_name', {}, ['SERVER_NAME', 'start_key']
> hbase> list_regions 'table_name', '', ['SERVER_NAME', 'start_key']
> hbase(main):005:0> list_regions 'cluster_test'
> SERVER_NAME |
> REGION_NAME |
> START_KEY | END_KEY | SIZE |
> R
[jira] [Commented] (HBASE-23909) list_regions fails if table is under split
[
https://issues.apache.org/jira/browse/HBASE-23909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053317#comment-17053317
]
Hudson commented on HBASE-23909:
Results for branch branch-1
[build #1255 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1255/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1255//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1255//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1255//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> list_regions fails if table is under split
> --
>
> Key: HBASE-23909
> URL: https://issues.apache.org/jira/browse/HBASE-23909
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.6.0
>Reporter: Peter Somogyi
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.2.4, 2.1.10
>
>
> Shortly after executing split 'table' command from the shell the list_regions
> 'table' fails with "ERROR: undefined method `toString' for nil:NilClass"
>
> {noformat}
> hbase(main):002:0> list_regions 'cluster_test'
> SERVER_NAME |
>REGION_NAME | START_KEY |END_KEY | SIZE | REQ |
> LOCALITY |
> --- |
> - |
> -- | -- | - | | -- |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.857a9b734a2f490e573ba20b1bbf99b3. ||
> | 3348 | 20408042 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.1749360028b3a5e76b5da1d1888e5b9d. |
> | | 3321 | 20242123 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.1f1366aa0ee621d496103ac5a50bca77. |
> | | 3316 | 20215774 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.ae95589c9498443a89aea4c42c199372. |
> | | 3327 | 20285312 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.239647c37e27cbd3154180ce5004a1ea. |
> || 3355 | 20451469 |0.0 |
> 5 rows
> hbase(main):003:0> split 'cluster_test'
> 0 row(s) in 0.2240 seconds
> hbase(main):004:0> list_regions 'cluster_test'
> ERROR: undefined method `toString' for nil:NilClass
> Here is some help for this command:
> List all regions for a particular table as an array and also filter
> them by server name (optional) as prefix
> and maximum locality (optional). By default, it will return all the
> regions for the table with any locality.
> The command displays server name, region name, start key, end key,
> size of the region in MB, number of requests
> and the locality. The information can be projected out via an array
> as third parameter. By default all these information
> is displayed. Possible array values are SERVER_NAME, REGION_NAME,
> START_KEY, END_KEY, SIZE, REQ and LOCALITY. Values
> are not case sensitive. If you don't want to filter by server name,
> pass an empty hash / string as shown below.
> Examples:
> hbase> list_regions 'table_name'
> hbase> list_regions 'table_name', 'server_name'
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name',
> LOCALITY_THRESHOLD => 0.8}
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name',
> LOCALITY_THRESHOLD => 0.8}, ['SERVER_NAME']
> hbase> list_regions 'table_name', {}, ['SERVER_NAME', 'start_key']
> hbase> list_regions 'table_name', '', ['SERVER_NAME', 'start_key']
> hbase(main):005:0> list_regions 'cluster_test'
> SERVER_NAME |
> REGION_NAME |
> START_KEY | END_KEY | SIZE |
> REQ | LOCALITY |
> --- |
>
> | --- |
> --- | ---
[GitHub] [hbase] Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…
Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur… URL: https://github.com/apache/hbase/pull/1221#issuecomment-595731992 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 35s | master passed | | +1 :green_heart: | checkstyle | 1m 9s | master passed | | +0 :ok: | spotbugs | 4m 54s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 52s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 3s | the patch passed | | -0 :warning: | checkstyle | 1m 7s | hbase-server: The patch generated 2 new + 8 unchanged - 0 fixed = 10 total (was 8) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 21m 4s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 :x: | findbugs | 4m 19s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. | | | | 53m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1221 | | Optional Tests | dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle | | uname | Linux bb2008733d9f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4cb60327be | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Reopened] (HBASE-23921) Findbugs is OOM on master
[
https://issues.apache.org/jira/browse/HBASE-23921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reopened HBASE-23921:
---
This does not work.
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt
{noformat}
[java] Total memory: 477M
[java] free memory: 62M
{noformat}
Why we only have 477M total memory?
> Findbugs is OOM on master
> -
>
> Key: HBASE-23921
> URL: https://issues.apache.org/jira/browse/HBASE-23921
> Project: HBase
> Issue Type: Bug
> Components: build, findbugs
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 3.0.0
>
>
> Happens after merging of HBASE-22514.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-23891) Add an option to Actions to filter out meta RS
[ https://issues.apache.org/jira/browse/HBASE-23891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-23891. -- Resolution: Fixed Merged PR to master and cherry picked it into branch-2 and branch-2.2. Thanks for the contribution, [~bszabolcs]! > Add an option to Actions to filter out meta RS > -- > > Key: HBASE-23891 > URL: https://issues.apache.org/jira/browse/HBASE-23891 > Project: HBase > Issue Type: Sub-task > Components: integration tests >Affects Versions: 3.0.0 >Reporter: Tamas Adami >Assignee: Szabolcs Bukros >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.3 > > > Add an option to Actions to be able to filter meta server out. > Some ITs rely on meta RS and have timeout errors if this RS is killed. (e.g. > IntegrationTestTimeBoundedRequestsWithRegionReplicas) > For the time being there is no option for removing meta server from server > list to kill or configuring these actions properly. > The following chaos monkey actions are affected: > GracefulRollingRestartRsAction, RollingBatchSuspendResumeRsAction -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-23562) [operator tools] Add a RegionsMerge tool that allows for merging multiple adjacent regions until a desired number of regions is reached.
[ https://issues.apache.org/jira/browse/HBASE-23562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23562 started by Wellington Chevreuil. > [operator tools] Add a RegionsMerge tool that allows for merging multiple > adjacent regions until a desired number of regions is reached. > > > Key: HBASE-23562 > URL: https://issues.apache.org/jira/browse/HBASE-23562 > Project: HBase > Issue Type: New Feature >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > > There's been a few occasions where different customers had faced the need to > reduce the number of regions for specific tables, either due to mistakenly > pre-split or after a purge in table data. This jira is for adding a simple > merge tool that takes the table name and the desired number of regions, then > perform region merges until the total number of regions for the given table > reached the passed valued. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…
Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur… URL: https://github.com/apache/hbase/pull/1221#issuecomment-595747049 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 32s | master passed | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 10s | the patch passed | | +1 :green_heart: | compile | 1m 1s | the patch passed | | +1 :green_heart: | javac | 1m 1s | the patch passed | | +1 :green_heart: | shadedjars | 4m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 71m 44s | hbase-server in the patch failed. | | | | 98m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1221 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux edbbc0e49aac 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4cb60327be | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/testReport/ | | Max. process+thread count | 9640 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/10/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23921) Findbugs is OOM on master
[ https://issues.apache.org/jira/browse/HBASE-23921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053566#comment-17053566 ] Sean Busbey commented on HBASE-23921: - the default for recent JVMs is a % of total system memory. Since we're in a docker container maybe we're launching the docker container with an overly restricted view of how much system memory there is? > Findbugs is OOM on master > - > > Key: HBASE-23921 > URL: https://issues.apache.org/jira/browse/HBASE-23921 > Project: HBase > Issue Type: Bug > Components: build, findbugs >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 3.0.0 > > > Happens after merging of HBASE-22514. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23876) Add JDK11 compilation and unit test support to nightly job
[
https://issues.apache.org/jira/browse/HBASE-23876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053568#comment-17053568
]
Nick Dimiduk commented on HBASE-23876:
--
{quote}Docker file complaints?
[https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2535/artifact/output-general/diff-patch-hadolint.txt|https://slack-redir.net/link?url=https%3A%2F%2Fbuilds.apache.org%2Fjob%2FHBase%2520Nightly%2Fjob%2Fbranch-2%2F2535%2Fartifact%2Foutput-general%2Fdiff-patch-hadolint.txt&v=3]
{quote}
Yeah so i fixed the {{hadolint}} executable and now it's actually running
checks against our dockerfiles... which have linter warnings.
> Add JDK11 compilation and unit test support to nightly job
> --
>
> Key: HBASE-23876
> URL: https://issues.apache.org/jira/browse/HBASE-23876
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's
> get JDK11 added to the mix. Applies to nightly job.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-23945) Dockerfiles showing hadolint check failures
Nick Dimiduk created HBASE-23945: Summary: Dockerfiles showing hadolint check failures Key: HBASE-23945 URL: https://issues.apache.org/jira/browse/HBASE-23945 Project: HBase Issue Type: Bug Components: build Reporter: Nick Dimiduk HBASE-23876 fixed the hadolint install path, so now those checks are being run, and flagging problems. Let's fix them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23876) Add JDK11 compilation and unit test support to nightly job
[ https://issues.apache.org/jira/browse/HBASE-23876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053570#comment-17053570 ] Nick Dimiduk commented on HBASE-23876: -- hadolint failures: HBASE-23945 > Add JDK11 compilation and unit test support to nightly job > -- > > Key: HBASE-23876 > URL: https://issues.apache.org/jira/browse/HBASE-23876 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > We already test against multiple JDK versions in a handful of places. Let's > get JDK11 added to the mix. Applies to nightly job. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23946) [JDK11] Yetus should vote -0 for known JDK11 issues
Nick Dimiduk created HBASE-23946:
Summary: [JDK11] Yetus should vote -0 for known JDK11 issues
Key: HBASE-23946
URL: https://issues.apache.org/jira/browse/HBASE-23946
Project: HBase
Issue Type: Test
Components: build
Reporter: Nick Dimiduk
So as t avoid everyone being depressed by failing builds, we should have Yetus
vote -0 instead of -1 for checks that are known to fail with JDK11. Off the top
of my head, these should be {{javadocs}} and {{unit}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23946) [JDK11] Yetus should vote -0 for known JDK11 issues
[
https://issues.apache.org/jira/browse/HBASE-23946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-23946:
-
Parent: HBASE-22972
Issue Type: Sub-task (was: Test)
> [JDK11] Yetus should vote -0 for known JDK11 issues
> ---
>
> Key: HBASE-23946
> URL: https://issues.apache.org/jira/browse/HBASE-23946
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Minor
>
> So as t avoid everyone being depressed by failing builds, we should have
> Yetus vote -0 instead of -1 for checks that are known to fail with JDK11. Off
> the top of my head, these should be {{javadocs}} and {{unit}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23876) Add JDK11 compilation and unit test support to nightly job
[ https://issues.apache.org/jira/browse/HBASE-23876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053572#comment-17053572 ] Nick Dimiduk commented on HBASE-23876: -- Vote -0 for known problems. > Add JDK11 compilation and unit test support to nightly job > -- > > Key: HBASE-23876 > URL: https://issues.apache.org/jira/browse/HBASE-23876 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > We already test against multiple JDK versions in a handful of places. Let's > get JDK11 added to the mix. Applies to nightly job. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23945) Dockerfiles showing hadolint check failures
[
https://issues.apache.org/jira/browse/HBASE-23945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053573#comment-17053573
]
Nick Dimiduk commented on HBASE-23945:
--
{noformat}
dev-support/Dockerfile:25 DL3020 Use COPY instead of ADD for files and folders
dev-support/Dockerfile:27 DL3008 Pin versions in apt get install. Instead of
`apt-get install ` use `apt-get install =`
dev-support/Dockerfile:27 DL3009 Delete the apt-get lists after installing
something
dev-support/Dockerfile:27 DL3015 Avoid additional packages by specifying
`--no-install-recommends`
dev-support/apache_hbase_topology/Dockerfile:19 DL3020 Use COPY instead of ADD
for files and folders
dev-support/hbase_docker/Dockerfile:20 DL3008 Pin versions in apt get install.
Instead of `apt-get install ` use `apt-get install =`
dev-support/hbase_docker/Dockerfile:20 DL3009 Delete the apt-get lists after
installing something
dev-support/hbase_docker/Dockerfile:20 DL3015 Avoid additional packages by
specifying `--no-install-recommends`
dev-support/hbase_docker/Dockerfile:24 DL3020 Use COPY instead of ADD for files
and folders
dev-support/hbase_docker/Dockerfile:29 SC2035 Use ./*glob* or -- *glob* so
names with dashes won't become options.
dev-support/hbase_docker/Dockerfile:34 SC2035 Use ./*glob* or -- *glob* so
names with dashes won't become options.
{noformat}
> Dockerfiles showing hadolint check failures
> ---
>
> Key: HBASE-23945
> URL: https://issues.apache.org/jira/browse/HBASE-23945
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Nick Dimiduk
>Priority: Minor
>
> HBASE-23876 fixed the hadolint install path, so now those checks are being
> run, and flagging problems. Let's fix them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23876) Add JDK11 compilation and unit test support to nightly job
[ https://issues.apache.org/jira/browse/HBASE-23876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053574#comment-17053574 ] Michael Stack commented on HBASE-23876: --- Thanks. > Add JDK11 compilation and unit test support to nightly job > -- > > Key: HBASE-23876 > URL: https://issues.apache.org/jira/browse/HBASE-23876 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > We already test against multiple JDK versions in a handful of places. Let's > get JDK11 added to the mix. Applies to nightly job. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23077) move entirely to spotbugs
[
https://issues.apache.org/jira/browse/HBASE-23077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053575#comment-17053575
]
Duo Zhang commented on HBASE-23077:
---
Oh I met another problem. The spotbugs-annotations is LGPL so we can not
include it in the artifacts. I tried to declare it as optional, but still got
an error when building to say that there is a license error...
With mvn dependency:tree, I can see that all spotbugs-annotations dependencies
are optional or provided, so do not know how to fix this...
{noformat}
--
This product includes SpotBugs Annotations licensed under the GNU LESSER
GENERAL PUBLIC LICENSE, Version 2.1.
ERROR: Please check this License for acceptability here:
https://www.apache.org/legal/resolved
If it is okay, then update the list named 'non_aggregate_fine' in the
LICENSE.vm file.
If it isn't okay, then revert the change that added the dependency.
More info on the dependency:
com.github.spotbugs
spotbugs-annotations
3.1.12
maven central search
g:com.github.spotbugs AND a:spotbugs-annotations AND v:3.1.12
project website
https://spotbugs.github.io/
project source
https://github.com/spotbugs/spotbugs/
{noformat}
> move entirely to spotbugs
> -
>
> Key: HBASE-23077
> URL: https://issues.apache.org/jira/browse/HBASE-23077
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Sean Busbey
>Priority: Major
>
> we've been relying on spotbugs definitions with findbugs tooling for awhile
> now. I think spotbugs now provides its own versions of everything we need
> (and Yetus supports spotbugs directly).
> Do a pass removing findbugs tooling from all branches in favor of spotbugs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23077) move entirely to spotbugs
[ https://issues.apache.org/jira/browse/HBASE-23077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053592#comment-17053592 ] Sean Busbey commented on HBASE-23077: - I was under the impression that we could continue to use the stephenc clean room annotations to actually mark our code. > move entirely to spotbugs > - > > Key: HBASE-23077 > URL: https://issues.apache.org/jira/browse/HBASE-23077 > Project: HBase > Issue Type: Improvement > Components: build, test >Reporter: Sean Busbey >Priority: Major > > we've been relying on spotbugs definitions with findbugs tooling for awhile > now. I think spotbugs now provides its own versions of everything we need > (and Yetus supports spotbugs directly). > Do a pass removing findbugs tooling from all branches in favor of spotbugs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23945) Dockerfiles showing hadolint check failures
[
https://issues.apache.org/jira/browse/HBASE-23945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053602#comment-17053602
]
Nick Dimiduk commented on HBASE-23945:
--
So there's some bit-rot happening here.
* {{dev-support/Dockerfile}} doesn't build for me
* {{dev-support/apache_hbase_topology/Dockerfile}} no longer exists on master
* {{dev-support/hbase_docker/Dockerfile}} doesn't build for me.
> Dockerfiles showing hadolint check failures
> ---
>
> Key: HBASE-23945
> URL: https://issues.apache.org/jira/browse/HBASE-23945
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Nick Dimiduk
>Priority: Minor
>
> HBASE-23876 fixed the hadolint install path, so now those checks are being
> run, and flagging problems. Let's fix them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23945) Dockerfiles showing hadolint check failures
[
https://issues.apache.org/jira/browse/HBASE-23945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053603#comment-17053603
]
Nick Dimiduk commented on HBASE-23945:
--
{{dev-support/apache_hbase_topology/Dockerfile}} was removed... sometime?
HBASE-18418. There's no fixVersion set. Should back-port this to branch-2 as
well.
> Dockerfiles showing hadolint check failures
> ---
>
> Key: HBASE-23945
> URL: https://issues.apache.org/jira/browse/HBASE-23945
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Nick Dimiduk
>Priority: Minor
>
> HBASE-23876 fixed the hadolint install path, so now those checks are being
> run, and flagging problems. Let's fix them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-23947) Backport "HBASE-18418 Remove apache_hbase_topology from dev-support" to branch-2
Nick Dimiduk created HBASE-23947: Summary: Backport "HBASE-18418 Remove apache_hbase_topology from dev-support" to branch-2 Key: HBASE-23947 URL: https://issues.apache.org/jira/browse/HBASE-23947 Project: HBase Issue Type: Task Components: build Affects Versions: 2.3.0 Reporter: Nick Dimiduk HBASE-23945 flags this dockerfile as having issues, but it's been deleted from master. Drop it from branch-2 as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23947) Backport "HBASE-18418 Remove apache_hbase_topology from dev-support" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-23947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23947: - Fix Version/s: 2.3.0 > Backport "HBASE-18418 Remove apache_hbase_topology from dev-support" to > branch-2 > > > Key: HBASE-23947 > URL: https://issues.apache.org/jira/browse/HBASE-23947 > Project: HBase > Issue Type: Task > Components: build >Affects Versions: 2.3.0 >Reporter: Nick Dimiduk >Priority: Minor > Fix For: 2.3.0 > > > HBASE-23945 flags this dockerfile as having issues, but it's been deleted > from master. Drop it from branch-2 as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23562) [operator tools] Add a RegionsMerge tool that allows for merging multiple adjacent regions until a desired number of regions is reached.
[ https://issues.apache.org/jira/browse/HBASE-23562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053618#comment-17053618 ] Josh Elser commented on HBASE-23562: bq. should we consider adding this functionality natively We actually already have this functionality natively in the Region Normalizer chore. I'd like to see some differentiation to prevent this feature and the Region Normalizer from overlapping and causing confusion in "how do I reduce the regions in my cluster"? Thinking about it quickly, I think if we focus the Normalizer on "slow, always-on, always correcting, low-user impact" and this tool on "Proactively merging many regions together, high-user impact, 'fast'", that's a decent distinction. > [operator tools] Add a RegionsMerge tool that allows for merging multiple > adjacent regions until a desired number of regions is reached. > > > Key: HBASE-23562 > URL: https://issues.apache.org/jira/browse/HBASE-23562 > Project: HBase > Issue Type: New Feature >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > > There's been a few occasions where different customers had faced the need to > reduce the number of regions for specific tables, either due to mistakenly > pre-split or after a purge in table data. This jira is for adding a simple > merge tool that takes the table name and the desired number of regions, then > perform region merges until the total number of regions for the given table > reached the passed valued. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23945) Dockerfiles showing hadolint check failures
[ https://issues.apache.org/jira/browse/HBASE-23945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-23945: Assignee: Nick Dimiduk > Dockerfiles showing hadolint check failures > --- > > Key: HBASE-23945 > URL: https://issues.apache.org/jira/browse/HBASE-23945 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > > HBASE-23876 fixed the hadolint install path, so now those checks are being > run, and flagging problems. Let's fix them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ndimiduk opened a new pull request #1244: HBASE-23945 Dockerfiles showing hadolint check failures
ndimiduk opened a new pull request #1244: HBASE-23945 Dockerfiles showing
hadolint check failures
URL: https://github.com/apache/hbase/pull/1244
With this patch, `find . -iname '*Dockerfile*' -exec hadolint {} +` reports
nothing. Let's see what buildbot says.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1244: HBASE-23945 Dockerfiles showing hadolint check failures
Apache-HBase commented on issue #1244: HBASE-23945 Dockerfiles showing hadolint check failures URL: https://github.com/apache/hbase/pull/1244#issuecomment-595881398 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 40s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1244/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1244 | | Optional Tests | | | uname | Linux 6439d2d9d91c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / df62dde394 | | Max. process+thread count | 52 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1244/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-18418) Remove apache_hbase_topology from dev-support
[
https://issues.apache.org/jira/browse/HBASE-18418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-18418:
-
Fix Version/s: 3.0.0
> Remove apache_hbase_topology from dev-support
> -
>
> Key: HBASE-18418
> URL: https://issues.apache.org/jira/browse/HBASE-18418
> Project: HBase
> Issue Type: Task
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-18418_v1.patch
>
>
> As [~misty] noted on dev@, we still keep a folder containing the Apache HBase
> topology for [clusterdock|https://github.com/clusterdock/framework] in
> dev-support. Since the {{clusterdock}} org on GitHub will likely always have
> a more up-to-date iteration of this code (and since I plan on showing it some
> love there in the next few weeks), we'd probably be better off removing it
> from HBase. Any objections?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1244: HBASE-23945 Dockerfiles showing hadolint check failures
Apache-HBase commented on issue #1244: HBASE-23945 Dockerfiles showing hadolint check failures URL: https://github.com/apache/hbase/pull/1244#issuecomment-595881622 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1244/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1244 | | Optional Tests | | | uname | Linux 4491fe159c62 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / df62dde394 | | Max. process+thread count | 51 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1244/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1244: HBASE-23945 Dockerfiles showing hadolint check failures
Apache-HBase commented on issue #1244: HBASE-23945 Dockerfiles showing hadolint check failures URL: https://github.com/apache/hbase/pull/1244#issuecomment-595881649 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch | | +1 :green_heart: | hadolint | 0m 4s | The patch generated 0 new + 0 unchanged - 12 fixed = 0 total (was 12) | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 2m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1244/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1244 | | Optional Tests | dupname asflicense hadolint shellcheck shelldocs | | uname | Linux 9e09b4a6d17a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / df62dde394 | | Max. process+thread count | 45 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1244/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Reopened] (HBASE-18418) Remove apache_hbase_topology from dev-support
[
https://issues.apache.org/jira/browse/HBASE-18418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk reopened HBASE-18418:
--
Reopening to apply to branch-2.
> Remove apache_hbase_topology from dev-support
> -
>
> Key: HBASE-18418
> URL: https://issues.apache.org/jira/browse/HBASE-18418
> Project: HBase
> Issue Type: Task
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-18418_v1.patch
>
>
> As [~misty] noted on dev@, we still keep a folder containing the Apache HBase
> topology for [clusterdock|https://github.com/clusterdock/framework] in
> dev-support. Since the {{clusterdock}} org on GitHub will likely always have
> a more up-to-date iteration of this code (and since I plan on showing it some
> love there in the next few weeks), we'd probably be better off removing it
> from HBase. Any objections?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-23947) Backport "HBASE-18418 Remove apache_hbase_topology from dev-support" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-23947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-23947. -- Resolution: Duplicate HBASE-18418 applies cleanly so just reopening that JIRA. > Backport "HBASE-18418 Remove apache_hbase_topology from dev-support" to > branch-2 > > > Key: HBASE-23947 > URL: https://issues.apache.org/jira/browse/HBASE-23947 > Project: HBase > Issue Type: Task > Components: build >Affects Versions: 2.3.0 >Reporter: Nick Dimiduk >Priority: Minor > > HBASE-23945 flags this dockerfile as having issues, but it's been deleted > from master. Drop it from branch-2 as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23947) Backport "HBASE-18418 Remove apache_hbase_topology from dev-support" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-23947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23947: - Fix Version/s: (was: 2.3.0) > Backport "HBASE-18418 Remove apache_hbase_topology from dev-support" to > branch-2 > > > Key: HBASE-23947 > URL: https://issues.apache.org/jira/browse/HBASE-23947 > Project: HBase > Issue Type: Task > Components: build >Affects Versions: 2.3.0 >Reporter: Nick Dimiduk >Priority: Minor > > HBASE-23945 flags this dockerfile as having issues, but it's been deleted > from master. Drop it from branch-2 as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ndimiduk opened a new pull request #1245: Backport HBASE-23945, HBASE-18418 to branch-2
ndimiduk opened a new pull request #1245: Backport HBASE-23945, HBASE-18418 to branch-2 URL: https://github.com/apache/hbase/pull/1245 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1245: Backport HBASE-23945, HBASE-18418 to branch-2
Apache-HBase commented on issue #1245: Backport HBASE-23945, HBASE-18418 to branch-2 URL: https://github.com/apache/hbase/pull/1245#issuecomment-595885207 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch | | +1 :green_heart: | hadolint | 0m 4s | The patch generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11) | | +1 :green_heart: | pylint | 0m 5s | There were no new pylint issues. | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 2m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1245/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1245 | | Optional Tests | dupname asflicense pylint hadolint shellcheck shelldocs markdownlint | | uname | Linux 760b9ab19946 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 7d8fa5c818 | | Max. process+thread count | 50 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1245/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c pylint=2.4.4 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1245: Backport HBASE-23945, HBASE-18418 to branch-2
Apache-HBase commented on issue #1245: Backport HBASE-23945, HBASE-18418 to branch-2 URL: https://github.com/apache/hbase/pull/1245#issuecomment-595885062 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 1m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1245/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1245 | | Optional Tests | | | uname | Linux c6c53255add8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 7d8fa5c818 | | Max. process+thread count | 46 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1245/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk merged pull request #1244: HBASE-23945 Dockerfiles showing hadolint check failures
ndimiduk merged pull request #1244: HBASE-23945 Dockerfiles showing hadolint check failures URL: https://github.com/apache/hbase/pull/1244 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1245: Backport HBASE-23945, HBASE-18418 to branch-2
Apache-HBase commented on issue #1245: Backport HBASE-23945, HBASE-18418 to branch-2 URL: https://github.com/apache/hbase/pull/1245#issuecomment-595885324 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1245/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1245 | | Optional Tests | | | uname | Linux 1bb35087245f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 7d8fa5c818 | | Max. process+thread count | 51 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1245/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23945) Dockerfiles showing hadolint check failures
[ https://issues.apache.org/jira/browse/HBASE-23945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23945: - Fix Version/s: 2.3.0 3.0.0 > Dockerfiles showing hadolint check failures > --- > > Key: HBASE-23945 > URL: https://issues.apache.org/jira/browse/HBASE-23945 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > > HBASE-23876 fixed the hadolint install path, so now those checks are being > run, and flagging problems. Let's fix them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ndimiduk merged pull request #1245: Backport HBASE-23945, HBASE-18418 to branch-2
ndimiduk merged pull request #1245: Backport HBASE-23945, HBASE-18418 to branch-2 URL: https://github.com/apache/hbase/pull/1245 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-18418) Remove apache_hbase_topology from dev-support
[
https://issues.apache.org/jira/browse/HBASE-18418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-18418:
-
Fix Version/s: 2.3.0
> Remove apache_hbase_topology from dev-support
> -
>
> Key: HBASE-18418
> URL: https://issues.apache.org/jira/browse/HBASE-18418
> Project: HBase
> Issue Type: Task
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-18418_v1.patch
>
>
> As [~misty] noted on dev@, we still keep a folder containing the Apache HBase
> topology for [clusterdock|https://github.com/clusterdock/framework] in
> dev-support. Since the {{clusterdock}} org on GitHub will likely always have
> a more up-to-date iteration of this code (and since I plan on showing it some
> love there in the next few weeks), we'd probably be better off removing it
> from HBase. Any objections?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-18418) Remove apache_hbase_topology from dev-support
[
https://issues.apache.org/jira/browse/HBASE-18418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk resolved HBASE-18418.
--
Resolution: Fixed
> Remove apache_hbase_topology from dev-support
> -
>
> Key: HBASE-18418
> URL: https://issues.apache.org/jira/browse/HBASE-18418
> Project: HBase
> Issue Type: Task
>Reporter: Dima Spivak
>Assignee: Dima Spivak
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-18418_v1.patch
>
>
> As [~misty] noted on dev@, we still keep a folder containing the Apache HBase
> topology for [clusterdock|https://github.com/clusterdock/framework] in
> dev-support. Since the {{clusterdock}} org on GitHub will likely always have
> a more up-to-date iteration of this code (and since I plan on showing it some
> love there in the next few weeks), we'd probably be better off removing it
> from HBase. Any objections?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-23945) Dockerfiles showing hadolint check failures
[ https://issues.apache.org/jira/browse/HBASE-23945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-23945. -- Resolution: Fixed > Dockerfiles showing hadolint check failures > --- > > Key: HBASE-23945 > URL: https://issues.apache.org/jira/browse/HBASE-23945 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 3.0.0, 2.3.0 > > > HBASE-23876 fixed the hadolint install path, so now those checks are being > run, and flagging problems. Let's fix them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23946) [JDK11] Yetus should vote -0 for known JDK11 issues
[
https://issues.apache.org/jira/browse/HBASE-23946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053650#comment-17053650
]
Nick Dimiduk commented on HBASE-23946:
--
Looks like we already filter {{javadocs}}, so just filter {{unit}}.
> [JDK11] Yetus should vote -0 for known JDK11 issues
> ---
>
> Key: HBASE-23946
> URL: https://issues.apache.org/jira/browse/HBASE-23946
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Minor
>
> So as t avoid everyone being depressed by failing builds, we should have
> Yetus vote -0 instead of -1 for checks that are known to fail with JDK11. Off
> the top of my head, these should be {{javadocs}} and {{unit}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-23946) [JDK11] Yetus should vote -0 for known JDK11 issues
[
https://issues.apache.org/jira/browse/HBASE-23946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk reassigned HBASE-23946:
Assignee: Nick Dimiduk
> [JDK11] Yetus should vote -0 for known JDK11 issues
> ---
>
> Key: HBASE-23946
> URL: https://issues.apache.org/jira/browse/HBASE-23946
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
>
> So as t avoid everyone being depressed by failing builds, we should have
> Yetus vote -0 instead of -1 for checks that are known to fail with JDK11. Off
> the top of my head, these should be {{javadocs}} and {{unit}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] ndimiduk opened a new pull request #1246: HBASE-23946 [JDK11] Yetus should vote -0 for known JDK11 issues
ndimiduk opened a new pull request #1246: HBASE-23946 [JDK11] Yetus should vote -0 for known JDK11 issues URL: https://github.com/apache/hbase/pull/1246 This should do the trick. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1246: HBASE-23946 [JDK11] Yetus should vote -0 for known JDK11 issues
Apache-HBase commented on issue #1246: HBASE-23946 [JDK11] Yetus should vote -0 for known JDK11 issues URL: https://github.com/apache/hbase/pull/1246#issuecomment-595893132 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1246/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1246 | | Optional Tests | | | uname | Linux 7fe5769ced12 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c61f95022d | | Max. process+thread count | 57 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1246/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1246: HBASE-23946 [JDK11] Yetus should vote -0 for known JDK11 issues
Apache-HBase commented on issue #1246: HBASE-23946 [JDK11] Yetus should vote -0 for known JDK11 issues URL: https://github.com/apache/hbase/pull/1246#issuecomment-595893136 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 37s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1246/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1246 | | Optional Tests | | | uname | Linux 1b60452203fb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c61f95022d | | Max. process+thread count | 52 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1246/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1246: HBASE-23946 [JDK11] Yetus should vote -0 for known JDK11 issues
Apache-HBase commented on issue #1246: HBASE-23946 [JDK11] Yetus should vote -0 for known JDK11 issues URL: https://github.com/apache/hbase/pull/1246#issuecomment-595893572 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 3m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1246/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1246 | | Optional Tests | dupname asflicense shellcheck shelldocs | | uname | Linux a5856d60814c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c61f95022d | | Max. process+thread count | 47 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1246/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1220: HBASE-23847 Removed deprecated setStartRow from Scan
Apache-HBase commented on issue #1220: HBASE-23847 Removed deprecated setStartRow from Scan URL: https://github.com/apache/hbase/pull/1220#issuecomment-595986345 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 55s | master passed | | +1 :green_heart: | checkstyle | 4m 38s | master passed | | +0 :ok: | spotbugs | 1m 19s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 10m 0s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 10s | the patch passed | | +1 :green_heart: | checkstyle | 3m 44s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 16m 34s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | findbugs | 11m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 2m 15s | The patch does not generate ASF License warnings. | | | | 69m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1220 | | Optional Tests | dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle | | uname | Linux f2aa1eed0093 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c61f95022d | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #1220: HBASE-23847 Removed deprecated setStartRow from Scan
HorizonNet commented on issue #1220: HBASE-23847 Removed deprecated setStartRow from Scan URL: https://github.com/apache/hbase/pull/1220#issuecomment-595987250 @virajjasani Build is now green. I ran the shell tests locally and they pass. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1220: HBASE-23847 Removed deprecated setStartRow from Scan
Apache-HBase commented on issue #1220: HBASE-23847 Removed deprecated setStartRow from Scan URL: https://github.com/apache/hbase/pull/1220#issuecomment-595988110 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 9s | master passed | | +1 :green_heart: | compile | 5m 3s | master passed | | +1 :green_heart: | shadedjars | 5m 30s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 18s | hbase-backup in master failed. | | -0 :warning: | javadoc | 0m 19s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 23s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 58s | hbase-thrift in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 3s | the patch passed | | +1 :green_heart: | compile | 5m 7s | the patch passed | | +1 :green_heart: | javac | 5m 7s | the patch passed | | +1 :green_heart: | shadedjars | 5m 25s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 55s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 18s | hbase-backup in the patch failed. | | -0 :warning: | javadoc | 0m 22s | hbase-rest in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 5s | hbase-client in the patch passed. | | -1 :x: | unit | 7m 0s | hbase-server in the patch failed. | | -1 :x: | unit | 6m 44s | hbase-mapreduce in the patch failed. | | +1 :green_heart: | unit | 2m 35s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 3m 24s | hbase-endpoint in the patch passed. | | -1 :x: | unit | 4m 25s | hbase-backup in the patch failed. | | +1 :green_heart: | unit | 0m 56s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 2m 44s | hbase-rest in the patch passed. | | | | 75m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1220 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 61aab53448e9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c61f95022d | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | j
[GitHub] [hbase] HorizonNet commented on issue #1220: HBASE-23847 Removed deprecated setStartRow from Scan
HorizonNet commented on issue #1220: HBASE-23847 Removed deprecated setStartRow from Scan URL: https://github.com/apache/hbase/pull/1220#issuecomment-595989715 JDK11 build will downvote this one until #1246 lands. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan
Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan URL: https://github.com/apache/hbase/pull/1213#issuecomment-595991705 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 40s | master passed | | +1 :green_heart: | compile | 4m 35s | master passed | | +1 :green_heart: | shadedjars | 5m 3s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 29s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-backup in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 25s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 38s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 47s | hbase-thrift in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 23s | the patch passed | | +1 :green_heart: | compile | 4m 26s | the patch passed | | +1 :green_heart: | javac | 4m 26s | the patch passed | | +1 :green_heart: | shadedjars | 5m 23s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 27s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 21s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 51s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 19s | hbase-backup in the patch failed. | | -0 :warning: | javadoc | 0m 24s | hbase-rest in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 5s | hbase-client in the patch passed. | | -1 :x: | unit | 5m 25s | hbase-server in the patch failed. | | -1 :x: | unit | 4m 58s | hbase-mapreduce in the patch failed. | | +1 :green_heart: | unit | 2m 12s | hbase-thrift in the patch passed. | | -1 :x: | unit | 4m 21s | hbase-backup in the patch failed. | | +1 :green_heart: | unit | 0m 57s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 2m 47s | hbase-rest in the patch passed. | | | | 64m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1213 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7eefd5937748 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c61f95022d | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/
[GitHub] [hbase] saintstack commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…
saintstack commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur… URL: https://github.com/apache/hbase/pull/1221#issuecomment-595992182 Re-running hadoopqa. Master flakies list should be shorter now (The flakies reporter script is broke at moment but hopefully fixed soon). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan
Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan URL: https://github.com/apache/hbase/pull/1213#issuecomment-595996977 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 17s | master passed | | +1 :green_heart: | checkstyle | 3m 53s | master passed | | +0 :ok: | spotbugs | 1m 34s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 9m 38s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 58s | the patch passed | | +1 :green_heart: | checkstyle | 5m 26s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 24m 42s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | findbugs | 13m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 59s | The patch does not generate ASF License warnings. | | | | 86m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1213 | | Optional Tests | dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle | | uname | Linux cbe6006240f7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c61f95022d | | Max. process+thread count | 94 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-it hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…
Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur… URL: https://github.com/apache/hbase/pull/1221#issuecomment-596001092 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 31s | master passed | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | shadedjars | 4m 55s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 8s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | +1 :green_heart: | shadedjars | 4m 54s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 5m 14s | hbase-server in the patch failed. | | | | 32m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1221 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a660a4df80b8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c61f95022d | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/testReport/ | | Max. process+thread count | 1108 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1220: HBASE-23847 Removed deprecated setStartRow from Scan
Apache-HBase commented on issue #1220: HBASE-23847 Removed deprecated setStartRow from Scan URL: https://github.com/apache/hbase/pull/1220#issuecomment-596007257 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 19s | master passed | | +1 :green_heart: | compile | 4m 13s | master passed | | +1 :green_heart: | shadedjars | 4m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 54s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 14s | the patch passed | | +1 :green_heart: | compile | 4m 22s | the patch passed | | +1 :green_heart: | javac | 4m 22s | the patch passed | | +1 :green_heart: | shadedjars | 5m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 56s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 57s | hbase-client in the patch passed. | | -1 :x: | unit | 71m 38s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 8m 48s | hbase-mapreduce in the patch passed. | | +1 :green_heart: | unit | 2m 24s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 3m 6s | hbase-endpoint in the patch passed. | | -1 :x: | unit | 15m 17s | hbase-backup in the patch failed. | | +1 :green_heart: | unit | 1m 10s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 3m 12s | hbase-rest in the patch passed. | | | | 147m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1220 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 71a5ab393e83 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c61f95022d | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-backup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/testReport/ | | Max. process+thread count | 9870 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1220/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…
Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur… URL: https://github.com/apache/hbase/pull/1221#issuecomment-596007293 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 5s | master passed | | +1 :green_heart: | checkstyle | 1m 45s | master passed | | +0 :ok: | spotbugs | 6m 41s | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 :x: | findbugs | 4m 43s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 7s | the patch passed | | -0 :warning: | checkstyle | 1m 46s | hbase-server: The patch generated 2 new + 8 unchanged - 0 fixed = 10 total (was 8) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 24m 13s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 :x: | findbugs | 4m 50s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. | | | | 62m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1221 | | Optional Tests | dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 93d93ae44733 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c61f95022d | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/artifact/yetus-general-check/output/branch-findbugs-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt | | Max. process+thread count | 84 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…
Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur… URL: https://github.com/apache/hbase/pull/1221#issuecomment-596013843 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 31s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 4m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 4s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 4m 44s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 63m 19s | hbase-server in the patch passed. | | | | 93m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1221 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 62e1b8722bef 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c61f95022d | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/testReport/ | | Max. process+thread count | 9482 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/11/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan
Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan URL: https://github.com/apache/hbase/pull/1213#issuecomment-596016797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 50s | master passed | | +1 :green_heart: | compile | 3m 56s | master passed | | +1 :green_heart: | shadedjars | 5m 30s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 20s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 53s | the patch passed | | +1 :green_heart: | compile | 4m 3s | the patch passed | | +1 :green_heart: | javac | 4m 3s | the patch passed | | +1 :green_heart: | shadedjars | 5m 20s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 57s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 101m 24s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 10m 17s | hbase-mapreduce in the patch passed. | | +1 :green_heart: | unit | 2m 22s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 8m 49s | hbase-backup in the patch passed. | | +1 :green_heart: | unit | 1m 21s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 3m 49s | hbase-rest in the patch passed. | | | | 170m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1213 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8670733e94bb 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c61f95022d | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/testReport/ | | Max. process+thread count | 6510 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-it hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr…
Apache-HBase commented on issue #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr… URL: https://github.com/apache/hbase/pull/1243#issuecomment-596033267 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 13s | master passed | | +1 :green_heart: | checkstyle | 1m 16s | master passed | | +0 :ok: | spotbugs | 4m 44s | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 :x: | findbugs | 3m 18s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 39s | the patch passed | | -0 :warning: | checkstyle | 1m 16s | hbase-server: The patch generated 6 new + 76 unchanged - 5 fixed = 82 total (was 81) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 54s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 :x: | findbugs | 3m 18s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 47m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1243 | | Optional Tests | dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle | | uname | Linux dbde835f53d6 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d099f242e9 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/2/artifact/yetus-general-check/output/branch-findbugs-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/2/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr…
Apache-HBase commented on issue #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr… URL: https://github.com/apache/hbase/pull/1243#issuecomment-596033353 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 50s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 36s | master passed | | +1 :green_heart: | compile | 1m 21s | master passed | | +1 :green_heart: | shadedjars | 5m 45s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 46s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 15s | the patch passed | | +1 :green_heart: | compile | 1m 17s | the patch passed | | +1 :green_heart: | javac | 1m 17s | the patch passed | | +1 :green_heart: | shadedjars | 6m 43s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 1m 5s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 11m 50s | hbase-server in the patch failed. | | | | 47m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1243 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ee2f41201739 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d099f242e9 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/2/testReport/ | | Max. process+thread count | 1046 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1243/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23205) Correctly update the position of WALs currently being replicated.
[
https://issues.apache.org/jira/browse/HBASE-23205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-23205:
Fix Version/s: (was: 1.5.1)
1.6.0
> Correctly update the position of WALs currently being replicated.
> -
>
> Key: HBASE-23205
> URL: https://issues.apache.org/jira/browse/HBASE-23205
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.5.0, 1.4.10, 1.4.11
>Reporter: Jeongdae Kim
>Assignee: Jeongdae Kim
>Priority: Major
> Fix For: 1.6.0, 1.4.13
>
>
> We observed a lot of old WALs were not removed from archives and their
> corresponding replication queues, while testing with 1.4.10.
> stacked old WALs are empty or have no entries to be replicated (not in
> replication table_cfs)
>
> As described in HBASE-22784, if no entries to be replicated are appended to
> WALs, log position will never be updated. As a consequence, all WALs won’t be
> removed. this issue happened since HBASE-15995.
>
> I think old WALs would not be stacked with HBASE-22784. but, it still have
> something to be fixed as below
> case 1) Log position could be updated wrongly, when log rolled, because
> lastWalPath of batches might not point to WAL currently being read.
> * For example, after last entry added in a batch were read from P1 position
> in the WAL W1
> and then WAL rolled, and reader read until it reaches the end of old wals
> and continue reading entries from new WAL W2, and then it reached batch size.
> current read position for W2 is P2. In this case, the batch being passed to a
> shipper have walPath W1 and P2, so shipper will try to update position P2 for
> W1. it may result in data inconsistency in recovery case or update failure to
> zookeeper (znode could not exist by previous log position updates, i guess
> this case is the same case as HBASE-23169 ?)
>
> case 2) Log position could be not updated or updated to wrong position by
> pendingShipment flag introduced from HBASE-22784
> * In shipper thread, it would not be guaranteed to update log position
> always, by setting pendingShipment to false.
> If reader set the flag to true, right after shipper set it to false during
> {color:#24292e}updateLogPosition(), shipper won’t update log position.{color}
> On the other hand, while reader read filtered entries, If shipper set to
> false reader will update log position to current read position. it may lose
> data in recovery case.
>
> case 3) A lot of log position updates could be happened, when most of WAL
> entries are filtered by TableCfWALEntryFilter.
> * I think it would be better to reduce the number of log updates in that
> case, because
> ## zookeeper writes are more expensive operations than reads.(since writes
> involve synchronizing the state of all servers),
> ## even if read position was not updated, it would be harmless because all
> entries will be filtered out again in recovery process.
> * It would be enough to update log position only when wal rolled in that
> case. (to cleanup old wals)
>
> -In addition, During this work, i found a minor bug which is updating
> replication buffer size wrongly by decreasing total buffer size with the size
> of bulk loaded files.-
> -I’d like to fix it, if it’s ok.-
> I removed the changes above and made a separate jira : HBASE-23254
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-16141) Unwind use of UserGroupInformation.doAs() to convey requester identity in coprocessor upcalls
[ https://issues.apache.org/jira/browse/HBASE-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell resolved HBASE-16141. - Fix Version/s: (was: 1.7.0) (was: 3.0.0) Assignee: (was: Gary Helmling) Resolution: Later > Unwind use of UserGroupInformation.doAs() to convey requester identity in > coprocessor upcalls > - > > Key: HBASE-16141 > URL: https://issues.apache.org/jira/browse/HBASE-16141 > Project: HBase > Issue Type: Improvement > Components: Coprocessors, security >Reporter: Gary Helmling >Priority: Major > > In discussion on HBASE-16115, there is some discussion of whether > UserGroupInformation.doAs() is the right mechanism for propagating the > original requester's identify in certain system contexts (splits, > compactions, some procedure calls). It has the unfortunately of overriding > the current user, which makes for very confusing semantics for coprocessor > implementors. We should instead find an alternate mechanism for conveying > the caller identity, which does not override the current user context. > I think we should instead look at passing this through as part of the > ObserverContext passed to every coprocessor hook. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23693) Split failure may cause region hole and data loss when use zk assign
[
https://issues.apache.org/jira/browse/HBASE-23693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-23693:
Fix Version/s: (was: 1.5.1)
1.6.0
> Split failure may cause region hole and data loss when use zk assign
>
>
> Key: HBASE-23693
> URL: https://issues.apache.org/jira/browse/HBASE-23693
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 1.4.8
>Reporter: tianhang tang
>Assignee: tianhang tang
>Priority: Critical
> Fix For: 1.6.0
>
> Attachments: HBASE-23693.branch-1.001.patch
>
>
> to mock this case, I add a sleep code in SplitTransactionImpl.excute after
> the PONR and before openDaughters:
> {code:java}
> public PairOfSameType execute(final Server server,
> final RegionServerServices services, User user) throws IOException {
> this.server = server;
> this.rsServices = services;
> useZKForAssignment = server == null ? true :
> ConfigUtil.useZKForAssignment(server.getConfiguration());
> if (useCoordinatedStateManager(server)) {
> std =
> ((BaseCoordinatedStateManager) server.getCoordinatedStateManager())
> .getSplitTransactionCoordination().getDefaultDetails();
> }
> PairOfSameType regions = createDaughters(server, services, user);
> if (this.parent.getCoprocessorHost() != null) {
> if (user == null) {
> parent.getCoprocessorHost().preSplitAfterPONR();
> } else {
> try {
> user.getUGI().doAs(new PrivilegedExceptionAction() {
> @Override
> public Void run() throws Exception {
> parent.getCoprocessorHost().preSplitAfterPONR();
> return null;
> }
> });
> } catch (InterruptedException ie) {
> InterruptedIOException iioe = new InterruptedIOException();
> iioe.initCause(ie);
> throw iioe;
> }
> }
> }
>
> //sleep here!!!
> try {
> Thread.sleep(1000 * 60 * 60);
> } catch (InterruptedException e) {
> e.printStackTrace();
> }
> regions = stepsAfterPONR(server, services, regions, user);
> transition(SplitTransactionPhase.COMPLETED);
> return regions;
> }
> {code}
> so the split transaction will hang.
> then i try to reproduce this problem:
> 1.Create a test table and move it into a test rsgroup, there is only 1 RS in
> the test group
> 2.Trigger a region split
> 3.The split transaction step after the PONR and sleep, regioninfo in meta has
> been updated
> 4.Kill the RS process to mock machine crash
> 5.ServerCrashProcedure cleanup SPLITING_NEW region, the daughter regions will
> be deleted
> 6.ServerCrashProcedure try to assign the parent region, because RS is down
> and assign fails, the region status is set to FAILED_OPEN and put back into
> regionsInTransition. But at this time, due to RS crash, the node of the
> region under ZK region-in-transition no longer exist
> 7.CatalogJanitor thread is blocked due to RIT
> 8.Switch active master
> 9.The CatalogJanitor thread on the new master executes normally and the
> parent region is cleaned up because split = true && offline = true in the
> meta table
> 10.We have a hole in the test table and loss data.
>
> I modified the code when ServerCrashProcedure cleans up the child regions, it
> will update the parent regioninfo in the meta table, and this problem is no
> longer reproduced.
> I will upload the patch later.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-21831) Optional store-and-forward of simple mutations for regions in transition
[ https://issues.apache.org/jira/browse/HBASE-21831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-21831: Fix Version/s: 2.4.0 > Optional store-and-forward of simple mutations for regions in transition > > > Key: HBASE-21831 > URL: https://issues.apache.org/jira/browse/HBASE-21831 > Project: HBase > Issue Type: New Feature > Components: regionserver, rpc >Reporter: Andrew Kyle Purtell >Assignee: Sandeep Pal >Priority: Major > Fix For: 3.0.0, 1.7.0, 2.4.0 > > > We have an internal service built on Redis that is considering writing > through to HBase directly for their persistence needs. Their current > experience with Redis is > * Average write latency is ~milliseconds > * p999 write latencies with are "a few seconds" > They want a similar experience when writing simple values directly to HBase. > Infrequent exceptions to this would be acceptable. > * Availability of 99.9% for writes > * Expect most writes to be serviced within a few milliseconds, e.g. few > millis at p95. Still evaluating what the requirement should be (~millis at > p90 vs p95 vs p99). > * Timeout of 2 seconds, should be rare > There is a fallback plan considered if HBase cannot respond within 2 seconds. > However this fallback cannot guarantee durability. Redis or the service's > daemons may go down. They want HBase to provide required durability. > Because this is a caching service, where all writes are expected to be served > again from cache, at least for a while, if HBase were to accept writes such > that they are not immediately visible, it could be fine that they are not > visible for 10-20 minutes in the worst case. This is relatively easy to > achieve as an engineering target should we consider offering a write option > that does not guarantee immediate visibility. (A proposal follows below.) We > are considering store-and-forward of simple mutations and perhaps also simple > deletes, although the latter is not a hard requirement. Out of order > processing of this subset of mutation requests is acceptable because their > data model ensures all values are immutable. Presumably on the HBase side the > timestamps of the requests would be set to the current server wall clock time > when received, so eventually when applied all are available with correct > temporal ordering (within the effective resolution of the server clocks). > Deletes which are not immediately applied (or failed) could cause application > level confusion, and although this would remain a concern for the general > case, for this specific use case, stale reads could be explained to and > tolerated by their users. > The BigTable architecture assigns at most one server to serve a region at a > time. Region Replicas are an enhancement to the base BigTable architecture we > made in HBase which stands up two more read-only replicas for a given region, > meaning a client attempting a read has the option to fail very quickly over > from the primary to a replica for a (potentially stale) read, or distribute > read load over all replicas, or employ a hedged reading strategy. Enabling > region replicas and timeline consistency can lower the availability gap for > reads in the high percentiles from ~minutes to ~milliseconds. However, this > option will not help for write use cases wanting roughly the same thing, > because there can be no fail-over for writes. Writes must still go to the > active primary. When that region is in transition, writes must be held on the > client until it is redeployed. Or, if region replicas are not enabled, when > the sole region is in transition, again, writes must be held on the client > until the region is available again. > Regions enter the in-transition state for two reasons: failures, and > housekeeping (splits and merges, or balancing). Time to region redeployment > after failures depends on a number of factors, like how long it took for us > to become aware of the failure, and how long it takes to split the > write-ahead log of the failed server and distribute the recovered edits to > the reopening region(s). We could in theory improve this behavior by being > more predictive about declaring failure, like employing a phi accrual failure > detector to signal to the master from clients that a regionserver is sick. > Other time-to-recovery issues and mitigations are discussed in a number of > JIRAs and blog posts and not discussed further here. Regarding housekeeping > activities, splits and merges typically complete in under a second. However, > split times up to ~30 seconds have been observed at my place of employ in > rare conditions. In the instances I have investigated the cause is I/O stalls >
[jira] [Assigned] (HBASE-21831) Optional store-and-forward of simple mutations for regions in transition
[ https://issues.apache.org/jira/browse/HBASE-21831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal reassigned HBASE-21831: --- Assignee: Sandeep Pal > Optional store-and-forward of simple mutations for regions in transition > > > Key: HBASE-21831 > URL: https://issues.apache.org/jira/browse/HBASE-21831 > Project: HBase > Issue Type: New Feature > Components: regionserver, rpc >Reporter: Andrew Kyle Purtell >Assignee: Sandeep Pal >Priority: Major > Fix For: 3.0.0, 1.7.0 > > > We have an internal service built on Redis that is considering writing > through to HBase directly for their persistence needs. Their current > experience with Redis is > * Average write latency is ~milliseconds > * p999 write latencies with are "a few seconds" > They want a similar experience when writing simple values directly to HBase. > Infrequent exceptions to this would be acceptable. > * Availability of 99.9% for writes > * Expect most writes to be serviced within a few milliseconds, e.g. few > millis at p95. Still evaluating what the requirement should be (~millis at > p90 vs p95 vs p99). > * Timeout of 2 seconds, should be rare > There is a fallback plan considered if HBase cannot respond within 2 seconds. > However this fallback cannot guarantee durability. Redis or the service's > daemons may go down. They want HBase to provide required durability. > Because this is a caching service, where all writes are expected to be served > again from cache, at least for a while, if HBase were to accept writes such > that they are not immediately visible, it could be fine that they are not > visible for 10-20 minutes in the worst case. This is relatively easy to > achieve as an engineering target should we consider offering a write option > that does not guarantee immediate visibility. (A proposal follows below.) We > are considering store-and-forward of simple mutations and perhaps also simple > deletes, although the latter is not a hard requirement. Out of order > processing of this subset of mutation requests is acceptable because their > data model ensures all values are immutable. Presumably on the HBase side the > timestamps of the requests would be set to the current server wall clock time > when received, so eventually when applied all are available with correct > temporal ordering (within the effective resolution of the server clocks). > Deletes which are not immediately applied (or failed) could cause application > level confusion, and although this would remain a concern for the general > case, for this specific use case, stale reads could be explained to and > tolerated by their users. > The BigTable architecture assigns at most one server to serve a region at a > time. Region Replicas are an enhancement to the base BigTable architecture we > made in HBase which stands up two more read-only replicas for a given region, > meaning a client attempting a read has the option to fail very quickly over > from the primary to a replica for a (potentially stale) read, or distribute > read load over all replicas, or employ a hedged reading strategy. Enabling > region replicas and timeline consistency can lower the availability gap for > reads in the high percentiles from ~minutes to ~milliseconds. However, this > option will not help for write use cases wanting roughly the same thing, > because there can be no fail-over for writes. Writes must still go to the > active primary. When that region is in transition, writes must be held on the > client until it is redeployed. Or, if region replicas are not enabled, when > the sole region is in transition, again, writes must be held on the client > until the region is available again. > Regions enter the in-transition state for two reasons: failures, and > housekeeping (splits and merges, or balancing). Time to region redeployment > after failures depends on a number of factors, like how long it took for us > to become aware of the failure, and how long it takes to split the > write-ahead log of the failed server and distribute the recovered edits to > the reopening region(s). We could in theory improve this behavior by being > more predictive about declaring failure, like employing a phi accrual failure > detector to signal to the master from clients that a regionserver is sick. > Other time-to-recovery issues and mitigations are discussed in a number of > JIRAs and blog posts and not discussed further here. Regarding housekeeping > activities, splits and merges typically complete in under a second. However, > split times up to ~30 seconds have been observed at my place of employ in > rare conditions. In the instances I have investigated the cause is I/O stalls > on the datanode
[jira] [Commented] (HBASE-21831) Optional store-and-forward of simple mutations for regions in transition
[ https://issues.apache.org/jira/browse/HBASE-21831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053823#comment-17053823 ] Andrew Kyle Purtell commented on HBASE-21831: - [~sandeep.pal] are you working on this? > Optional store-and-forward of simple mutations for regions in transition > > > Key: HBASE-21831 > URL: https://issues.apache.org/jira/browse/HBASE-21831 > Project: HBase > Issue Type: New Feature > Components: regionserver, rpc >Reporter: Andrew Kyle Purtell >Assignee: Sandeep Pal >Priority: Major > Fix For: 3.0.0, 1.7.0, 2.4.0 > > > We have an internal service built on Redis that is considering writing > through to HBase directly for their persistence needs. Their current > experience with Redis is > * Average write latency is ~milliseconds > * p999 write latencies with are "a few seconds" > They want a similar experience when writing simple values directly to HBase. > Infrequent exceptions to this would be acceptable. > * Availability of 99.9% for writes > * Expect most writes to be serviced within a few milliseconds, e.g. few > millis at p95. Still evaluating what the requirement should be (~millis at > p90 vs p95 vs p99). > * Timeout of 2 seconds, should be rare > There is a fallback plan considered if HBase cannot respond within 2 seconds. > However this fallback cannot guarantee durability. Redis or the service's > daemons may go down. They want HBase to provide required durability. > Because this is a caching service, where all writes are expected to be served > again from cache, at least for a while, if HBase were to accept writes such > that they are not immediately visible, it could be fine that they are not > visible for 10-20 minutes in the worst case. This is relatively easy to > achieve as an engineering target should we consider offering a write option > that does not guarantee immediate visibility. (A proposal follows below.) We > are considering store-and-forward of simple mutations and perhaps also simple > deletes, although the latter is not a hard requirement. Out of order > processing of this subset of mutation requests is acceptable because their > data model ensures all values are immutable. Presumably on the HBase side the > timestamps of the requests would be set to the current server wall clock time > when received, so eventually when applied all are available with correct > temporal ordering (within the effective resolution of the server clocks). > Deletes which are not immediately applied (or failed) could cause application > level confusion, and although this would remain a concern for the general > case, for this specific use case, stale reads could be explained to and > tolerated by their users. > The BigTable architecture assigns at most one server to serve a region at a > time. Region Replicas are an enhancement to the base BigTable architecture we > made in HBase which stands up two more read-only replicas for a given region, > meaning a client attempting a read has the option to fail very quickly over > from the primary to a replica for a (potentially stale) read, or distribute > read load over all replicas, or employ a hedged reading strategy. Enabling > region replicas and timeline consistency can lower the availability gap for > reads in the high percentiles from ~minutes to ~milliseconds. However, this > option will not help for write use cases wanting roughly the same thing, > because there can be no fail-over for writes. Writes must still go to the > active primary. When that region is in transition, writes must be held on the > client until it is redeployed. Or, if region replicas are not enabled, when > the sole region is in transition, again, writes must be held on the client > until the region is available again. > Regions enter the in-transition state for two reasons: failures, and > housekeeping (splits and merges, or balancing). Time to region redeployment > after failures depends on a number of factors, like how long it took for us > to become aware of the failure, and how long it takes to split the > write-ahead log of the failed server and distribute the recovered edits to > the reopening region(s). We could in theory improve this behavior by being > more predictive about declaring failure, like employing a phi accrual failure > detector to signal to the master from clients that a regionserver is sick. > Other time-to-recovery issues and mitigations are discussed in a number of > JIRAs and blog posts and not discussed further here. Regarding housekeeping > activities, splits and merges typically complete in under a second. However, > split times up to ~30 seconds have been observed at my place of employ in > rare con
