[jira] [Created] (HBASE-24010) HBase shell list_peers command is displayed incorrectly
song XinCun created HBASE-24010:
---
Summary: HBase shell list_peers command is displayed incorrectly
Key: HBASE-24010
URL: https://issues.apache.org/jira/browse/HBASE-24010
Project: HBase
Issue Type: Bug
Components: shell
Reporter: song XinCun
In 2.X version, I found hbase shell list_peers command displays java object id
not the human readable peer messages
{code:java}
hbase(main):002:0> list_peers
PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE REPLICATE_ALL NAMESPACES
TABLE_CFS BANDWIDTH SERIAL
0 row(s)
Took 0.3336 seconds
=> #
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
virajjasani commented on a change in pull request #1286: HBASE-23977 : Resolve
flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r394126999
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##
@@ -140,12 +141,16 @@ public void testOnlieSlowLogConsumption() throws
Exception {
Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
() -> slowLogRecorder.getSlowLogPayloads(request).size() == 7));
-slowLogPayloads = slowLogRecorder.getSlowLogPayloads(request);
-
-Assert.assertEquals(slowLogPayloads.size(), 7);
-confirmPayloadParams(0, 7, slowLogPayloads);
-confirmPayloadParams(5, 2, slowLogPayloads);
-confirmPayloadParams(6, 1, slowLogPayloads);
+Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
+ () -> {
+List slowLogPayloadsList =
slowLogRecorder.getSlowLogPayloads(request);
+Assert.assertEquals(slowLogPayloadsList.size(), 7);
+boolean b1 = confirmPayloadParams(0, 7, slowLogPayloadsList);
Review comment:
e.g if we send {1,2,3,4,5,6,7} to RingBuffer of size 8, then all of them are
consumed in same order. Now if we send {8,9,10,11}, we expect final output from
RingBuffer consumer to be {9,10,11,4,5,6,7,8} (1,2,3 are overridden). However,
the reason why we have flakes is because by the time we expect above output,
consumer might not have consumed say 10 and 11 and hence actual output would be
{9,2,3,4,5,6,7,8}. And hence the failures, so now with waitFor(), we wait until
we get ordered output {9,10,11,4,5,6,7,8}, which is why we will wait for all of
8,9,10,11 to be consumed and put in the queue in correct order i.e. no flakes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23977) [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:
[
https://issues.apache.org/jira/browse/HBASE-23977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061438#comment-17061438
]
Viraj Jasani commented on HBASE-23977:
--
[~stack] [~ndimiduk] sorry for one more quick follow up while both of you are
quite busy.
The changes done in the patch are to ensure that we wait for ordered events
processing done by consumer of ring buffer rather than just sleeping for some
fixed amount of time.
For instance, if we send \{1,2,3,4,5,6,7} to RingBuffer of size 8, then all of
them are consumed in same order. Now if we send \{8,9,10,11}, we expect final
output from RingBuffer consumer to be \{9,10,11,4,5,6,7,8} (1,2,3 are
overridden). However, the reason why we have flakes is because by the time we
expect above output, consumer might not have consumed say 10 and 11 and hence
actual output would be \{9,2,3,4,5,6,7,8}. And hence the failures, so now with
waitFor(), we wait until we get ordered output \{9,10,11,4,5,6,7,8}, which is
why we will wait for all of 8,9,10,11 to be consumed and put in the queue in
correct order i.e. no flakes.
> [Flakey Tests]
> TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97
> expected: but was:
> -
>
> Key: HBASE-23977
> URL: https://issues.apache.org/jira/browse/HBASE-23977
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Michael Stack
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> I see this occasionally on a linux vm. [~vjasani] .. you might have an idea
> why this is going on (this is your test I believe and a recent addition). If
> you have stuff I can try, shout.
> Here is fail:
> {code}
> org.junit.ComparisonFailure: expected: but was:
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.confirmPayloadParams(TestSlowLogRecorder.java:97)
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.testOnlieSlowLogConsumption(TestSlowLogRecorder.java:178)
> {code}
> Here is log:
> {code}
> 2020-03-12 17:02:06,266 INFO [Time-limited test] hbase.ResourceChecker(179):
> after:
> regionserver.slowlog.TestSlowLogRecorder#testOnlineSlowLogWithDisableConfig
> Thread=7 (was 7), OpenFileDescriptor=226 (was 226),
> MaxFileDescriptor=131072 (was 131072), SystemLoadAverage=353 (was 353),
> ProcessCount=195 (was 195), AvailableMemoryMB=7037 (was 7027) -
> AvailableMemoryMB LEAK? -
> 2020-03-12 17:02:06,281 INFO [Time-limited test]
> hbase.ResourceChecker(151): before:
> regionserver.slowlog.TestSlowLogRecorder#testOnlieSlowLogConsumption
> Thread=7, OpenFileDescriptor=226, MaxFileDescriptor=131072,
> SystemLoadAverage=353, ProcessCount=195, AvailableMemoryMB=7036
> 2020-03-12 17:02:06,317 DEBUG [Time-limited test]
> slowlog.TestSlowLogRecorder(111): Initially ringbuffer of Slow Log records is
> empty
> 2020-03-12 17:02:06,326 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,528 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,630 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,732 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1305: HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in tea…
Apache-HBase commented on issue #1305: HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in tea… URL: https://github.com/apache/hbase/pull/1305#issuecomment-600444955 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 51s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 4s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 28s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 38s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 20s | the patch passed | | -0 :warning: | checkstyle | 1m 26s | hbase-server: The patch generated 3 new + 67 unchanged - 5 fixed = 70 total (was 72) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | hadoopcheck | 15m 9s | The patch causes 20 errors with Hadoop v3.1.2. | | -1 :x: | spotbugs | 2m 59s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 43m 5s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | Possible null pointer dereference of region in org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.create(HRegionServer, String, long, boolean, ServerName) Dereferenced at UnassignRegionHandler.java:region in org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.create(HRegionServer, String, long, boolean, ServerName) Dereferenced at UnassignRegionHandler.java:[line 137] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1305 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux ab394a659015 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ebd37a314c | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23971) protoc warns: "no protobuf syntax specified"
[
https://issues.apache.org/jira/browse/HBASE-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061429#comment-17061429
]
Michael Stack commented on HBASE-23971:
---
[~wenfeiyi666] What were you going to commit? Add an addendum? A patch attached
here or a new PR? Thanks.
> protoc warns: "no protobuf syntax specified"
>
>
> Key: HBASE-23971
> URL: https://issues.apache.org/jira/browse/HBASE-23971
> Project: HBase
> Issue Type: Task
> Components: Protobufs
>Reporter: Nick Dimiduk
>Assignee: wenfeiyi666
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
>
> This comes up in a couple places.
> {noformat}
> [INFO] --- protobuf-maven-plugin:0.6.1:compile (compile-protoc) @
> hbase-protocol-shaded ---
> [INFO] Compiling 37 proto file(s) to
> /Users/ndimiduk/repos/apache/hbase/hbase-protocol-shaded/target/generated-sources/protobuf/java
> [WARNING] PROTOC: [libprotobuf WARNING
> google/protobuf/compiler/parser.cc:546] No syntax specified for the proto
> file: RSGroupAdmin.proto. Please use 'syntax = "proto2";' or 'syntax =
> "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
> [libprotobuf WARNING google/protobuf/compiler/parser.cc:546] No syntax
> specified for the proto file: RSGroup.proto. Please use 'syntax = "proto2";'
> or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2
> syntax.)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23971) protoc warns: "no protobuf syntax specified"
[
https://issues.apache.org/jira/browse/HBASE-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061424#comment-17061424
]
wenfeiyi666 commented on HBASE-23971:
-
Sorry, I was going to commit to HBASE-23970, didn't notice it would be merged
> protoc warns: "no protobuf syntax specified"
>
>
> Key: HBASE-23971
> URL: https://issues.apache.org/jira/browse/HBASE-23971
> Project: HBase
> Issue Type: Task
> Components: Protobufs
>Reporter: Nick Dimiduk
>Assignee: wenfeiyi666
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
>
> This comes up in a couple places.
> {noformat}
> [INFO] --- protobuf-maven-plugin:0.6.1:compile (compile-protoc) @
> hbase-protocol-shaded ---
> [INFO] Compiling 37 proto file(s) to
> /Users/ndimiduk/repos/apache/hbase/hbase-protocol-shaded/target/generated-sources/protobuf/java
> [WARNING] PROTOC: [libprotobuf WARNING
> google/protobuf/compiler/parser.cc:546] No syntax specified for the proto
> file: RSGroupAdmin.proto. Please use 'syntax = "proto2";' or 'syntax =
> "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
> [libprotobuf WARNING google/protobuf/compiler/parser.cc:546] No syntax
> specified for the proto file: RSGroup.proto. Please use 'syntax = "proto2";'
> or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2
> syntax.)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1305: HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in tea…
Apache-HBase commented on issue #1305: HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in tea… URL: https://github.com/apache/hbase/pull/1305#issuecomment-600437808 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 23s | branch-2 passed | | +1 :green_heart: | compile | 1m 7s | branch-2 passed | | -1 :x: | shadedjars | 0m 12s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 3m 0s | root in the patch failed. | | -1 :x: | compile | 0m 42s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 42s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 0m 10s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 23s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 0m 42s | hbase-server in the patch failed. | | | | 15m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1305 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 635f5a9131b3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ebd37a314c | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/testReport/ | | Max. process+thread count | 94 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1305/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack opened a new pull request #1305: HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in tea…
saintstack opened a new pull request #1305: HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in tea… URL: https://github.com/apache/hbase/pull/1305 …rdown Remove Region from RegionServer#regionsInTransitionInRS Map even on exception (because server is aborted). hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Only dump metrics once on abort. Refactor closeRegion method removing overlap with CloseRegionHandler; i.e. call to CP. hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/AssignRegionHandler.java Refactor so we remove Region from regionsInTransitionRS on success or failure. hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseRegionHandler.java Cleanup but also made it so UnassignRegionHandler can use it closing Regions. hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/UnassignRegionHandler.java Use CloseRegionHandler to close Region rather than dupe code. hbase-server/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java Bit more info when thread dumping... TestRegionServerNoMaster was changed because it presumes a behavior not present anymore (that CRH will leave danglng mention in regionsInTransitionInRS as it used to) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23984) [Flakey Tests] TestMasterAbortAndRSGotKilled fails in teardown
[
https://issues.apache.org/jira/browse/HBASE-23984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061397#comment-17061397
]
Michael Stack commented on HBASE-23984:
---
!Screen Shot 2020-03-17 at 9.46.49 PM.png!
This one keeps failing... about 30% of the time. It happens pretty frequently
in local runs too.
Studying this some, it can happen in other test teardowns in other tests --
locally at least -- and there is another form of this failure that happens
where the problem happens when AssignRegionHandler runs during cluster shutdown
and the shutdown sequence is out of the usual ordering (the
TestMasterAbortAndRSGotKilled issue is when UnassignRegionHandler runs at
cluster shutdown). In both cases, the close that goes with the unassign or the
open that goes w/ the assign, they can fail in a not usual way whe the cluster
is going down and the sequencing strays from the usual. When this happens, the
exception complaining we can't close/open because server aborting happens
WITHOUT clearing the region entry from the RegionServer regionsInTransitionInRS
Map and so we are destined to circle the waitOnAllRegionsToClose loop until the
test timesout.
Looking at the handler code in UnassignRegionHandler and in
AssignRegionHandler, they need a bit of restructuring so the clearing of the
Region from regionsInTransitionInRS happens even on error. CloseRegionHandler
does this already. Code in HRegionServer#closeRegion duplicates much of what is
in CloseRegionHandler. Code in UnassignRegionHandler needs to close a Region
and again dupes CloseRegionHandler.
Attached patch addresses the non-clearing of this.regionsInTransitionInRS in
the respective Handlers in a finally block making shutdown succeed more often
and it cleans up some of the duplication.
> [Flakey Tests] TestMasterAbortAndRSGotKilled fails in teardown
> --
>
> Key: HBASE-23984
> URL: https://issues.apache.org/jira/browse/HBASE-23984
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
> Attachments: Screen Shot 2020-03-17 at 9.46.49 PM.png
>
>
> Its failing with decent frequency of late in shutdown of cluster. Seems
> basic. There is an unassign/move going on. Test just checks Master can come
> back up after being killed. Does not check move is done. If on subsequent
> cluster shutdown, if the move can't report the Master because its shutting
> down, then the move fails, we abort the server, and then we get a wonky loop
> where we can't close because server is aborting.
> At the root, there is a misaccounting when the unassign close fails where we
> don't cleanup references in the regionserver local RIT accounting. Deeper
> than this, close code is duplicated in three places that I can see; in
> RegionServer, in CloseRegionHandler, and in UnassignRegionHandler.
> Let me fix this issue and the code dupe.
> Details:
> From
> https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-2/5733/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.master.TestMasterAbortAndRSGotKilled-output.txt
> Here is the unassign handler failing because master went down earlier (Its
> probably trying to talk to the old Master location)
> {code}
> * ABORTING region server asf905.gq1.ygridcore.net,32989,1584000644108:
> Failed to close region ede67f9f661acc1241faf468b081d548 and can not recover
> *
> Cause:
> java.io.IOException: Failed to report close to master:
> ede67f9f661acc1241faf468b081d548
> at
> org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:125)
> at
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> ... then the cluster shutdown tries to close the same Region... but fails
> because we are aborting because of above
> {code}
> 2020-03-12 08:11:16,600 ERROR [RS_CLOSE_REGION-regionserver/asf905:0-0]
> helpers.MarkerIgnoringBase(159): * ABORTING region server
> asf905.gq1.ygridcore.net,32989,1584000644108: Unrecoverable exception while
> closing region
> hbase:namespace,,1584000652744.78f4ae5beda711a9bebad0b6b8376cc9., still
> finishing close *
> java.io.IOException: Aborting flush because server is aborted...
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2545)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2530)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2504)
>
[GitHub] [hbase] Apache-HBase commented on issue #1279: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t…
Apache-HBase commented on issue #1279: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t… URL: https://github.com/apache/hbase/pull/1279#issuecomment-600426181 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 19s | master passed | | +1 :green_heart: | compile | 1m 2s | master passed | | +1 :green_heart: | shadedjars | 5m 26s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 52s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 5m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 88m 50s | hbase-server in the patch passed. | | | | 118m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1279 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a37a67f33d79 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9190a6b59a | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/testReport/ | | Max. process+thread count | 4458 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23984) [Flakey Tests] TestMasterAbortAndRSGotKilled fails in teardown
[
https://issues.apache.org/jira/browse/HBASE-23984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack updated HBASE-23984:
--
Attachment: Screen Shot 2020-03-17 at 9.46.49 PM.png
> [Flakey Tests] TestMasterAbortAndRSGotKilled fails in teardown
> --
>
> Key: HBASE-23984
> URL: https://issues.apache.org/jira/browse/HBASE-23984
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
> Attachments: Screen Shot 2020-03-17 at 9.46.49 PM.png
>
>
> Its failing with decent frequency of late in shutdown of cluster. Seems
> basic. There is an unassign/move going on. Test just checks Master can come
> back up after being killed. Does not check move is done. If on subsequent
> cluster shutdown, if the move can't report the Master because its shutting
> down, then the move fails, we abort the server, and then we get a wonky loop
> where we can't close because server is aborting.
> At the root, there is a misaccounting when the unassign close fails where we
> don't cleanup references in the regionserver local RIT accounting. Deeper
> than this, close code is duplicated in three places that I can see; in
> RegionServer, in CloseRegionHandler, and in UnassignRegionHandler.
> Let me fix this issue and the code dupe.
> Details:
> From
> https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-2/5733/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.master.TestMasterAbortAndRSGotKilled-output.txt
> Here is the unassign handler failing because master went down earlier (Its
> probably trying to talk to the old Master location)
> {code}
> * ABORTING region server asf905.gq1.ygridcore.net,32989,1584000644108:
> Failed to close region ede67f9f661acc1241faf468b081d548 and can not recover
> *
> Cause:
> java.io.IOException: Failed to report close to master:
> ede67f9f661acc1241faf468b081d548
> at
> org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:125)
> at
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> ... then the cluster shutdown tries to close the same Region... but fails
> because we are aborting because of above
> {code}
> 2020-03-12 08:11:16,600 ERROR [RS_CLOSE_REGION-regionserver/asf905:0-0]
> helpers.MarkerIgnoringBase(159): * ABORTING region server
> asf905.gq1.ygridcore.net,32989,1584000644108: Unrecoverable exception while
> closing region
> hbase:namespace,,1584000652744.78f4ae5beda711a9bebad0b6b8376cc9., still
> finishing close *
> java.io.IOException: Aborting flush because server is aborted...
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2545)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2530)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2504)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2495)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1650)
> at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1552)
> at
> org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:110)
> at
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
>
> And the RS keeps looping trying to close the Region even though we're aborted
> and there is handling in RS close Regions to deal with abort.
> Trouble seems to be because when UnassignRegionHandler fails its region
> close, it does not unregister the Region with
> rs.getRegionsInTransitionInRS().remove(encodedNameBytes, Boolean.FALSE);
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23986) Bump hadoop-two.version to 2.10.0 on master and branch-2
[
https://issues.apache.org/jira/browse/HBASE-23986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061385#comment-17061385
]
Hudson commented on HBASE-23986:
Results for branch branch-2
[build #2556 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2556/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2556//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2556//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2556//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2556//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2556//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Bump hadoop-two.version to 2.10.0 on master and branch-2
>
>
> Key: HBASE-23986
> URL: https://issues.apache.org/jira/browse/HBASE-23986
> Project: HBase
> Issue Type: Task
> Components: build, dependencies, hadoop2
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> See this discussion on mailing list
> https://lists.apache.org/thread.html/rbab2e79f25b38c85fe205390b3fdbc6711984881a994a499c54aee97%40%3Cdev.hbase.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22103) HDFS-13209 in Hadoop 3.3.0 breaks asyncwal
[
https://issues.apache.org/jira/browse/HBASE-22103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061386#comment-17061386
]
Hudson commented on HBASE-22103:
Results for branch branch-2
[build #2556 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2556/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2556//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2556//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2556//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2556//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2556//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> HDFS-13209 in Hadoop 3.3.0 breaks asyncwal
> --
>
> Key: HBASE-22103
> URL: https://issues.apache.org/jira/browse/HBASE-22103
> Project: HBase
> Issue Type: Bug
> Components: hadoop3, wal
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-22103.master.001.patch
>
>
> HDFS-13209 added an additional parameter to {{DistributedFileSystem.create}}
> and broke asyncwal.
> {noformat}
> 2019-03-25 12:19:21,061 ERROR [Listener at localhost/54758]
> asyncfs.FanOutOneBlockAsyncDFSOutputHelper(562): Couldn't properly initialize
> access to HDFS internals. Please update your WAL Provider to not make use of
> the 'asyncfs' provider. See HBASE-16110 for more information.
> java.lang.NoSuchMethodException:
> org.apache.hadoop.hdfs.protocol.ClientProtocol.create(java.lang.String,
> org.apache.hadoop.fs.permission.FsPermission, java.lang.String,
> org.apache.hadoop.io.EnumSetWritable, boolean, short, long,
> [Lorg.apache.hadoop.crypto.CryptoProtocolVersion;)
> at java.lang.Class.getMethod(Class.java:1786)
> at
> org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createFileCreator2(FanOutOneBlockAsyncDFSOutputHelper.java:513)
> at
> org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createFileCreator(FanOutOneBlockAsyncDFSOutputHelper.java:530)
> at
> org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.(FanOutOneBlockAsyncDFSOutputHelper.java:557)
> at
> org.apache.hadoop.hbase.io.asyncfs.AsyncFSOutputHelper.createOutput(AsyncFSOutputHelper.java:51)
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.initOutput(AsyncProtobufLogWriter.java:169)
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.init(AbstractProtobufLogWriter.java:166)
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:105)
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createAsyncWriter(AsyncFSWAL.java:663)
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:669)
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:126)
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:813)
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:519)
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:460)
> at
> org.apache.hadoop.hbase.regionserver.wal.TestAsyncFSWAL.newWAL(TestAsyncFSWAL.java:72)
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractTestFSWAL.testWALComparator(AbstractTestFSWAL.java:194)
> {noformat}
> Credit: this bug was found by [~gabor.bota]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1279: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t…
Apache-HBase commented on issue #1279: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t… URL: https://github.com/apache/hbase/pull/1279#issuecomment-600418645 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 35s | master passed | | +1 :green_heart: | compile | 1m 9s | master passed | | -1 :x: | shadedjars | 0m 11s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 17s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | -1 :x: | shadedjars | 0m 12s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 62m 43s | hbase-server in the patch failed. | | | | 82m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1279 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3c1c83cf74d3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9190a6b59a | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/testReport/ | | Max. process+thread count | 5912 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#discussion_r394099926 ## File path: hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java ## @@ -77,6 +73,10 @@ import org.slf4j.LoggerFactory; import org.apache.hbase.thirdparty.com.google.common.base.Preconditions; +import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors; +import org.apache.hbase.thirdparty.com.google.protobuf.Message; +import org.apache.hbase.thirdparty.com.google.protobuf.Service; +import org.apache.hbase.thirdparty.com.google.protobuf.ServiceException; /** * HTable interface to remote tables accessed via REST gateway Review comment: This class should be removed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
saintstack commented on a change in pull request #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394099616
##
File path: hbase-protocol-shaded/src/main/protobuf/AccessControl.proto
##
@@ -128,6 +128,15 @@ message HasUserPermissionsResponse {
repeated bool has_user_permission = 1;
}
+message HasPermissionRequest {
+ required TablePermission table_permission = 1;
+ required bytes user_name = 2;
+}
Review comment:
Missing from hbase-protocol-shaded?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#discussion_r393906696 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/Coprocessor.java ## @@ -21,11 +21,11 @@ import java.io.IOException; import java.util.Collections; - -import com.google.protobuf.Service; import org.apache.yetus.audience.InterfaceAudience; import org.apache.yetus.audience.InterfaceStability; +import org.apache.hbase.thirdparty.com.google.protobuf.Service; + Review comment: What about CPEPs? Will clients now need access to the hbase-shaded-protobuf jar? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
saintstack commented on a change in pull request #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394016223
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
##
@@ -124,7 +125,7 @@ public void initialize(EmptyMsg msg) {
private BigDecimalMsg getProtoForType(BigDecimal t) {
BigDecimalMsg.Builder builder = BigDecimalMsg.newBuilder();
-return
builder.setBigdecimalMsg(ByteStringer.wrap(Bytes.toBytes(t))).build();
+return
builder.setBigdecimalMsg(UnsafeByteOperations.unsafeWrap(Bytes.toBytes(t))).build();
Review comment:
Good
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
saintstack commented on a change in pull request #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394100184
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##
@@ -1985,21 +1985,20 @@ public SecurityCapabilitiesResponse
getSecurityCapabilities(RpcController contro
/**
* Determines if there is a MasterCoprocessor deployed which implements
- * {@link
org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.AccessControlService.Interface}.
+ * {@link AccessControlService.Interface}.
*/
boolean hasAccessControlServiceCoprocessor(MasterCoprocessorHost cpHost) {
-return checkCoprocessorWithService(
-cpHost.findCoprocessors(MasterCoprocessor.class),
AccessControlService.Interface.class);
+return
checkCoprocessorWithService(cpHost.findCoprocessors(MasterCoprocessor.class),
+ AccessControlService.Interface.class);
}
/**
* Determines if there is a MasterCoprocessor deployed which implements
- * {@link
org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos.VisibilityLabelsService.Interface}.
+ * {@link VisibilityLabelsService.Interface}.
*/
boolean hasVisibilityLabelsServiceCoprocessor(MasterCoprocessorHost cpHost) {
-return checkCoprocessorWithService(
-cpHost.findCoprocessors(MasterCoprocessor.class),
-VisibilityLabelsService.Interface.class);
+return
checkCoprocessorWithService(cpHost.findCoprocessors(MasterCoprocessor.class),
+ VisibilityLabelsService.Interface.class);
}
/**
Review comment:
What happens when an old CP impl tries to go against hbase3?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
saintstack commented on a change in pull request #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394097610
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorRpcUtils.java
##
@@ -87,53 +89,47 @@ public static CoprocessorServiceRequest
getCoprocessorServiceRequest(
}
public static CoprocessorServiceRequest getCoprocessorServiceRequest(
- final Descriptors.MethodDescriptor method, final Message request, final
byte [] row,
- final byte [] regionName) {
-return CoprocessorServiceRequest.newBuilder().setCall(
-getCoprocessorServiceCall(method, request, row)).
- setRegion(RequestConverter.buildRegionSpecifier(REGION_NAME,
regionName)).build();
+final Descriptors.MethodDescriptor method, final Message request, final
byte[] row,
+final byte[] regionName) {
+return CoprocessorServiceRequest.newBuilder()
+ .setCall(getCoprocessorServiceCall(method, request, row))
+ .setRegion(RequestConverter.buildRegionSpecifier(REGION_NAME,
regionName)).build();
}
- private static CoprocessorServiceCall getCoprocessorServiceCall(
- final Descriptors.MethodDescriptor method, final Message request, final
byte [] row) {
+ private static CoprocessorServiceCall getCoprocessorServiceCall(final
MethodDescriptor method,
+final Message request, final byte[] row) {
return CoprocessorServiceCall.newBuilder()
-
.setRow(org.apache.hbase.thirdparty.com.google.protobuf.UnsafeByteOperations.unsafeWrap(row))
-.setServiceName(CoprocessorRpcUtils.getServiceName(method.getService()))
-.setMethodName(method.getName())
-// TODO! Come back here after! This is a double copy of the
request if I read
-// it right copying from non-shaded to shaded version!! FIX!
-
.setRequest(org.apache.hbase.thirdparty.com.google.protobuf.UnsafeByteOperations.
-unsafeWrap(request.toByteArray())).build();
+
.setRow(org.apache.hbase.thirdparty.com.google.protobuf.UnsafeByteOperations.unsafeWrap(row))
+ .setServiceName(CoprocessorRpcUtils.getServiceName(method.getService()))
+ .setMethodName(method.getName())
+ // TODO! Come back here after! This is a double copy of the
request if I read
+ // it right copying from non-shaded to shaded version!! FIX!
Review comment:
Did I write this comment?
In CPEP, there was copying from pb2.5 data structures to internal PB3 data
structures -- so we could maintain pb2.5 as public interface but this seems to
be something different.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
saintstack commented on a change in pull request #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394098204
##
File path: hbase-endpoint/pom.xml
##
@@ -47,24 +47,6 @@
true
-
-org.xolstice.maven.plugins
-protobuf-maven-plugin
-
-
-compile-protoc
-generate-sources
-
- compile
-
-
-
-
${basedir}/../hbase-protocol/src/main/protobuf
-
-
-
-
-
Review comment:
It doesn't have pb local anymore?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#discussion_r394098972 ## File path: hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorEndpoint.java ## @@ -20,22 +20,14 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; -import com.google.protobuf.RpcCallback; -import com.google.protobuf.RpcController; -import com.google.protobuf.Service; Review comment: Yeah, so client now has to have hbase-shaded-protobuf on its side and if we change internal pb version we could break the endpoint? Realistically, the pb3 should probably stay on-the-wire compat so should be concern till pb4 or until we decided we want our pbs to be schema v3 compat. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#discussion_r393907627 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AdminOverAsyncAdmin.java ## @@ -71,6 +65,13 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors.MethodDescriptor; +import org.apache.hbase.thirdparty.com.google.protobuf.Message; +import org.apache.hbase.thirdparty.com.google.protobuf.RpcCallback; +import org.apache.hbase.thirdparty.com.google.protobuf.RpcChannel; +import org.apache.hbase.thirdparty.com.google.protobuf.RpcController; +import org.apache.hbase.thirdparty.com.google.protobuf.ServiceException; Review comment: Ditto This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
saintstack commented on a change in pull request #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394097852
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/ClientTokenUtil.java
##
@@ -69,7 +70,7 @@ private static void injectFault() throws ServiceException {
AsyncConnection conn) {
CompletableFuture> future = new
CompletableFuture<>();
if (injectedException != null) {
- future.completeExceptionally(injectedException);
+
future.completeExceptionally(ProtobufUtil.handleRemoteException(injectedException));
Review comment:
Needed?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#discussion_r393908442 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTable.java ## @@ -35,6 +34,7 @@ import org.apache.yetus.audience.InterfaceAudience; import org.apache.hbase.thirdparty.com.google.common.base.Preconditions; +import org.apache.hbase.thirdparty.com.google.protobuf.RpcChannel; Review comment: Yeah, ditto. These are public classes. This stuff is used internally so should be fine just changing it... its just that hbase-shaded-protobuf needs to be on the CLASSPATH? I suppose it was anyways? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#discussion_r393907544 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java ## @@ -82,6 +77,12 @@ import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting; import org.apache.hbase.thirdparty.com.google.common.base.Throwables; +import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil; +import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos; +import org.apache.hadoop.hbase.shaded.protobuf.generated.MultiRowMutationProtos.MultiRowMutationService; +import org.apache.hadoop.hbase.shaded.protobuf.generated.MultiRowMutationProtos.MutateRowsRequest; +import org.apache.hadoop.hbase.shaded.protobuf.generated.MultiRowMutationProtos.MutateRowsResponse; Review comment: Was this an oversight on our part? These should have been using the shaded versions all along? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23993) Use loopback for zk standalone server in minizkcluster
[ https://issues.apache.org/jira/browse/HBASE-23993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23993. --- Fix Version/s: 2.3.0 3.0.0 Hadoop Flags: Reviewed Release Note: MiniZKCluster now puts up its standalone node listening on loopback/127.0.0.1 rather than "localhost". Resolution: Fixed > Use loopback for zk standalone server in minizkcluster > -- > > Key: HBASE-23993 > URL: https://issues.apache.org/jira/browse/HBASE-23993 > Project: HBase > Issue Type: Sub-task > Components: Zookeeper >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > Use loopback for minizkcluster. HBASE-23919 shows how sometimes unit tests > fail in setup because the minizkcluster won't come up. It looks like client > is trying to stat the server but though the server is trying to poll a socket > bound to 0.0.0.0, the server never notices the client pings. Using loopback, > I don't see these odd failures anymore. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1279: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t…
Apache-HBase commented on issue #1279: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t… URL: https://github.com/apache/hbase/pull/1279#issuecomment-600409298 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 59s | master passed | | +1 :green_heart: | checkstyle | 1m 21s | master passed | | -1 :x: | spotbugs | 2m 7s | hbase-server in master has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 26s | the patch passed | | -0 :warning: | checkstyle | 1m 17s | hbase-server: The patch generated 37 new + 408 unchanged - 9 fixed = 445 total (was 417) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 2s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 37m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1279 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 76249862803e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9190a6b59a | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/12/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack merged pull request #1291: HBASE-23993 Use loopback for zk standalone server in minizkcluster
saintstack merged pull request #1291: HBASE-23993 Use loopback for zk standalone server in minizkcluster URL: https://github.com/apache/hbase/pull/1291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1291: HBASE-23993 Use loopback for zk standalone server in minizkcluster
saintstack commented on issue #1291: HBASE-23993 Use loopback for zk standalone server in minizkcluster URL: https://github.com/apache/hbase/pull/1291#issuecomment-600402760 Shell tests pass now. The remaining timeout seems unrelated and I'm working on these tests that don't complete in a follow-up. Merging. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1291: HBASE-23993 Use loopback for zk standalone server in minizkcluster
Apache-HBase commented on issue #1291: HBASE-23993 Use loopback for zk standalone server in minizkcluster URL: https://github.com/apache/hbase/pull/1291#issuecomment-600390272 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 59s | branch-2 passed | | +1 :green_heart: | compile | 2m 28s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 39s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 37s | the patch passed | | +1 :green_heart: | compile | 2m 30s | the patch passed | | +1 :green_heart: | javac | 2m 30s | the patch passed | | +1 :green_heart: | shadedjars | 4m 55s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 40s | hbase-zookeeper in the patch passed. | | +1 :green_heart: | unit | 0m 25s | hbase-replication in the patch passed. | | -1 :x: | unit | 104m 24s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 3m 42s | hbase-shell in the patch passed. | | +1 :green_heart: | unit | 1m 54s | hbase-examples in the patch passed. | | | | 143m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1291 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 24139d1c8c87 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 292cadf847 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/testReport/ | | Max. process+thread count | 3765 (vs. ulimit of 1) | | modules | C: hbase-zookeeper hbase-replication hbase-server hbase-shell hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac…
Apache-HBase commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac… URL: https://github.com/apache/hbase/pull/1304#issuecomment-600389989 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | | +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 2m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1304/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1304 | | Optional Tests | dupname asflicense shellcheck shelldocs | | uname | Linux 632f22f1e4bd 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 292cadf847 | | Max. process+thread count | 43 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1304/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac…
Apache-HBase commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac… URL: https://github.com/apache/hbase/pull/1304#issuecomment-60038 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1304/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1304 | | Optional Tests | | | uname | Linux 7abcc6d3c17a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 292cadf847 | | Max. process+thread count | 48 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1304/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac…
Apache-HBase commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac… URL: https://github.com/apache/hbase/pull/1304#issuecomment-600389997 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1304/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1304 | | Optional Tests | | | uname | Linux 86e1d3ab75d9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 292cadf847 | | Max. process+thread count | 46 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1304/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac…
Apache-HBase commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac… URL: https://github.com/apache/hbase/pull/1304#issuecomment-600389539 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1304/1/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac…
Apache-HBase commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac… URL: https://github.com/apache/hbase/pull/1304#issuecomment-600389535 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1304/1/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac…
Apache-HBase commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac… URL: https://github.com/apache/hbase/pull/1304#issuecomment-600389538 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1304/1/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1291: HBASE-23993 Use loopback for zk standalone server in minizkcluster
Apache-HBase commented on issue #1291: HBASE-23993 Use loopback for zk standalone server in minizkcluster URL: https://github.com/apache/hbase/pull/1291#issuecomment-600389192 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 10s | branch-2 passed | | +1 :green_heart: | compile | 2m 51s | branch-2 passed | | -1 :x: | shadedjars | 0m 9s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 21s | hbase-examples in branch-2 failed. | | -0 :warning: | javadoc | 0m 15s | hbase-replication in branch-2 failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in branch-2 failed. | | -0 :warning: | javadoc | 0m 16s | hbase-zookeeper in branch-2 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 52s | the patch passed | | +1 :green_heart: | compile | 2m 48s | the patch passed | | +1 :green_heart: | javac | 2m 48s | the patch passed | | -1 :x: | shadedjars | 0m 9s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-zookeeper in the patch failed. | | -0 :warning: | javadoc | 0m 15s | hbase-replication in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 19s | hbase-examples in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 44s | hbase-zookeeper in the patch passed. | | +1 :green_heart: | unit | 0m 37s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 104m 56s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 3m 48s | hbase-shell in the patch passed. | | +1 :green_heart: | unit | 1m 42s | hbase-examples in the patch passed. | | | | 139m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1291 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 09faf4938846 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 292cadf847 | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-replication.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-zookeeper.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-zookeeper.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-replication.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/testReport/ | | Max. process+thread count | 3841 (vs. ulimit of 1) |
[GitHub] [hbase] Apache9 commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac…
Apache9 commented on issue #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac… URL: https://github.com/apache/hbase/pull/1304#issuecomment-600389141 Not sure what is the current versioning pattern for branch-1, so not sure how to set the fix versions for branch-1.x... @apurtell @busbey This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 opened a new pull request #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac…
Apache9 opened a new pull request #1304: HBASE-24009 Backport the personality changes in HBASE-23989 to all ac… URL: https://github.com/apache/hbase/pull/1304 …tive branches This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 closed pull request #1303: Hbase 24009
Apache9 closed pull request #1303: Hbase 24009 URL: https://github.com/apache/hbase/pull/1303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23989) Consider 2.10.0 in our support matrix
[ https://issues.apache.org/jira/browse/HBASE-23989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23989: -- Release Note: Add 2.10.0 in our support matrix, and it will be the lowest hadoop2 version supported by HBase-2.3+. Also add 2.10.0 support in the personality script, the pre commit check for 2.3+ will start to build and test with 2.10.0. > Consider 2.10.0 in our support matrix > - > > Key: HBASE-23989 > URL: https://issues.apache.org/jira/browse/HBASE-23989 > Project: HBase > Issue Type: Task > Components: build, documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 opened a new pull request #1303: Hbase 24009
Apache9 opened a new pull request #1303: Hbase 24009 URL: https://github.com/apache/hbase/pull/1303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23989) Consider 2.10.0 in our support matrix
[ https://issues.apache.org/jira/browse/HBASE-23989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23989. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~janh] for reviewing. > Consider 2.10.0 in our support matrix > - > > Key: HBASE-23989 > URL: https://issues.apache.org/jira/browse/HBASE-23989 > Project: HBase > Issue Type: Task > Components: build, documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24009) Backport the personality changes in HBASE-23989 to all active branches
Duo Zhang created HBASE-24009: - Summary: Backport the personality changes in HBASE-23989 to all active branches Key: HBASE-24009 URL: https://issues.apache.org/jira/browse/HBASE-24009 Project: HBase Issue Type: Sub-task Components: build Reporter: Duo Zhang Assignee: Duo Zhang Fix For: 2.3.0, 2.1.10, 2.2.5 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23989) Consider 2.10.0 in our support matrix
[ https://issues.apache.org/jira/browse/HBASE-23989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23989: -- Fix Version/s: (was: 2.3.0) > Consider 2.10.0 in our support matrix > - > > Key: HBASE-23989 > URL: https://issues.apache.org/jira/browse/HBASE-23989 > Project: HBase > Issue Type: Task > Components: build, documentation >Reporter: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23989) Consider 2.10.0 in our support matrix
[ https://issues.apache.org/jira/browse/HBASE-23989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-23989: - Assignee: Duo Zhang > Consider 2.10.0 in our support matrix > - > > Key: HBASE-23989 > URL: https://issues.apache.org/jira/browse/HBASE-23989 > Project: HBase > Issue Type: Task > Components: build, documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23989) Consider 2.10.0 in our support matrix
[ https://issues.apache.org/jira/browse/HBASE-23989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23989: -- Fix Version/s: 2.3.0 3.0.0 > Consider 2.10.0 in our support matrix > - > > Key: HBASE-23989 > URL: https://issues.apache.org/jira/browse/HBASE-23989 > Project: HBase > Issue Type: Task > Components: build, documentation >Reporter: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23989) Consider 2.10.0 in our support matrix
[ https://issues.apache.org/jira/browse/HBASE-23989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23989: -- Component/s: documentation build > Consider 2.10.0 in our support matrix > - > > Key: HBASE-23989 > URL: https://issues.apache.org/jira/browse/HBASE-23989 > Project: HBase > Issue Type: Task > Components: build, documentation >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #1290: HBASE-23989 Consider 2.10.0 in our support matrix
Apache9 merged pull request #1290: HBASE-23989 Consider 2.10.0 in our support matrix URL: https://github.com/apache/hbase/pull/1290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile
Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile URL: https://github.com/apache/hbase/pull/1298#issuecomment-600381184 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 54s | master passed | | +1 :green_heart: | compile | 4m 16s | master passed | | +1 :green_heart: | shadedjars | 6m 25s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | root in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 5s | the patch passed | | +1 :green_heart: | compile | 4m 17s | the patch passed | | +1 :green_heart: | javac | 4m 17s | the patch passed | | +1 :green_heart: | shadedjars | 6m 26s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 137m 23s | root in the patch passed. | | | | 176m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1298 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 029fea8d2615 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9804f73c66 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/testReport/ | | Max. process+thread count | 5783 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-23957) [flakey test] client.TestMultiParallel fails to read hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-23957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061279#comment-17061279
]
Huaxiang Sun edited comment on HBASE-23957 at 3/18/20, 1:16 AM:
Yeah, indeed! It is not the MR job.
TestAsyncClusterAdminApi, for an example, there is code to rewrite
hbase-site.xml, so if it is out of luck and the other tests step in during the
overwrite, it will fail.
A bit complicated as there are multiple places which overwrites hbase-site.xml,
working on a fix.
was (Author: huaxiangsun):
Yeah, indeed! It is not the MR job.
TestBulkLoadReplication, there is code to rewrite hbase-site.xml, so if it is
out of luck and the other tests step in during the overwrite, it will fail,
working on a fix.
> [flakey test] client.TestMultiParallel fails to read hbase-site.xml
> ---
>
> Key: HBASE-23957
> URL: https://issues.apache.org/jira/browse/HBASE-23957
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Nick Dimiduk
>Assignee: Hua Xiang
>Priority: Minor
>
> Saw this on a [PreCommit
> run|https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1258/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt].
> Log file says
> {noformat}
> 2020-03-09 22:48:26,295 FATAL [Time-limited test] conf.Configuration(2853):
> error parsing conf hbase-site.xml
> java.io.FileNotFoundException:
> /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1258@2/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-classes/hbase-site.xml
> (No such file or directory)
> at java.io.FileInputStream.open0(Native Method)
> at java.io.FileInputStream.open(FileInputStream.java:195)
> at java.io.FileInputStream.(FileInputStream.java:138)
> at java.io.FileInputStream.(FileInputStream.java:93)
> at
> sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90)
> at
> sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188)
> at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2672)
> at
> org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2746)
> at
> org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2706)
> at
> org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2579)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:1091)
> at
> org.apache.hadoop.conf.Configuration.getTrimmed(Configuration.java:1145)
> at
> org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2363)
> at
> org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2793)
> at
> org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2810)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:100)
> at
> org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2849)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2831)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:389)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:181)
> at org.apache.hadoop.hbase.fs.HFileSystem.(HFileSystem.java:85)
> at org.apache.hadoop.hbase.fs.HFileSystem.get(HFileSystem.java:465)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getTestFileSystem(HBaseTestingUtility.java:3180)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getNewDataTestDirOnTestFS(HBaseTestingUtility.java:507)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.setupDataTestDirOnTestFS(HBaseTestingUtility.java:496)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:469)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:483)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.createDirsAndSetProperties(HBaseTestingUtility.java:651)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:603)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:586)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1039)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1004)
> at
> org.apache.hadoop.hbase.client.TestMultiParallel.beforeClass(TestMultiParallel.java:96)
> {noformat}
> This stage ran on H9.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1302: HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust
Apache-HBase commented on issue #1302: HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust URL: https://github.com/apache/hbase/pull/1302#issuecomment-600374974 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 54s | master passed | | +1 :green_heart: | checkstyle | 0m 20s | master passed | | +1 :green_heart: | spotbugs | 0m 48s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 15s | the patch passed | | +1 :green_heart: | checkstyle | 0m 19s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 16m 15s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | spotbugs | 1m 4s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 38m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1302 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux b5310c596d39 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9804f73c66 | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1302: HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust
Apache-HBase commented on issue #1302: HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust URL: https://github.com/apache/hbase/pull/1302#issuecomment-600373542 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 45s | master passed | | +1 :green_heart: | compile | 0m 27s | master passed | | +1 :green_heart: | shadedjars | 5m 0s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 19s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 59s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 48s | the patch passed | | +1 :green_heart: | shadedjars | 6m 11s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 6m 29s | hbase-mapreduce in the patch passed. | | | | 33m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1302 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 87cc12047997 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9804f73c66 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/testReport/ | | Max. process+thread count | 4108 (vs. ulimit of 1) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1301: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
Apache-HBase commented on issue #1301: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal URL: https://github.com/apache/hbase/pull/1301#issuecomment-600372916 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 6s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | shadedjars | 5m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 28s | the patch passed | | +1 :green_heart: | compile | 1m 21s | the patch passed | | +1 :green_heart: | javac | 1m 21s | the patch passed | | -1 :x: | shadedjars | 6m 21s | patch has 10 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 53s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 100m 51s | hbase-server in the patch failed. | | | | 130m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1301 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 787f9c547833 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9804f73c66 | | Default Java | 1.8.0_232 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/testReport/ | | Max. process+thread count | 6594 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1302: HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust
Apache-HBase commented on issue #1302: HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust URL: https://github.com/apache/hbase/pull/1302#issuecomment-600371628 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 46s | master passed | | +1 :green_heart: | compile | 0m 33s | master passed | | -1 :x: | shadedjars | 0m 10s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 22s | hbase-mapreduce in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 28s | the patch passed | | +1 :green_heart: | compile | 0m 30s | the patch passed | | +1 :green_heart: | javac | 0m 30s | the patch passed | | -1 :x: | shadedjars | 0m 9s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 21s | hbase-mapreduce in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 28s | hbase-mapreduce in the patch passed. | | | | 24m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1302 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1765da2b18e7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9804f73c66 | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/testReport/ | | Max. process+thread count | 4325 (vs. ulimit of 1) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1302/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1301: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
Apache-HBase commented on issue #1301: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal URL: https://github.com/apache/hbase/pull/1301#issuecomment-600370935 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 56s | master passed | | +1 :green_heart: | compile | 1m 11s | master passed | | -1 :x: | shadedjars | 0m 9s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 21s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | -1 :x: | shadedjars | 0m 9s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 101m 14s | hbase-server in the patch passed. | | | | 121m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1301 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fa45c7f4b53a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9804f73c66 | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/testReport/ | | Max. process+thread count | 5770 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23957) [flakey test] client.TestMultiParallel fails to read hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-23957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061279#comment-17061279
]
Huaxiang Sun commented on HBASE-23957:
--
Yeah, indeed! It is not the MR job.
TestBulkLoadReplication, there is code to rewrite hbase-site.xml, so if it is
out of luck and the other tests step in during the overwrite, it will fail,
working on a fix.
> [flakey test] client.TestMultiParallel fails to read hbase-site.xml
> ---
>
> Key: HBASE-23957
> URL: https://issues.apache.org/jira/browse/HBASE-23957
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Nick Dimiduk
>Assignee: Hua Xiang
>Priority: Minor
>
> Saw this on a [PreCommit
> run|https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1258/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt].
> Log file says
> {noformat}
> 2020-03-09 22:48:26,295 FATAL [Time-limited test] conf.Configuration(2853):
> error parsing conf hbase-site.xml
> java.io.FileNotFoundException:
> /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1258@2/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-classes/hbase-site.xml
> (No such file or directory)
> at java.io.FileInputStream.open0(Native Method)
> at java.io.FileInputStream.open(FileInputStream.java:195)
> at java.io.FileInputStream.(FileInputStream.java:138)
> at java.io.FileInputStream.(FileInputStream.java:93)
> at
> sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90)
> at
> sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188)
> at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2672)
> at
> org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2746)
> at
> org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2706)
> at
> org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2579)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:1091)
> at
> org.apache.hadoop.conf.Configuration.getTrimmed(Configuration.java:1145)
> at
> org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2363)
> at
> org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2793)
> at
> org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2810)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:100)
> at
> org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2849)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2831)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:389)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:181)
> at org.apache.hadoop.hbase.fs.HFileSystem.(HFileSystem.java:85)
> at org.apache.hadoop.hbase.fs.HFileSystem.get(HFileSystem.java:465)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getTestFileSystem(HBaseTestingUtility.java:3180)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getNewDataTestDirOnTestFS(HBaseTestingUtility.java:507)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.setupDataTestDirOnTestFS(HBaseTestingUtility.java:496)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:469)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:483)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.createDirsAndSetProperties(HBaseTestingUtility.java:651)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:603)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:586)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1039)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1004)
> at
> org.apache.hadoop.hbase.client.TestMultiParallel.beforeClass(TestMultiParallel.java:96)
> {noformat}
> This stage ran on H9.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1291: HBASE-23993 Use loopback for zk standalone server in minizkcluster
Apache-HBase commented on issue #1291: HBASE-23993 Use loopback for zk standalone server in minizkcluster URL: https://github.com/apache/hbase/pull/1291#issuecomment-600368819 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 55s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 4s | branch-2 passed | | +1 :green_heart: | spotbugs | 3m 44s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 38s | the patch passed | | +1 :green_heart: | checkstyle | 1m 59s | the patch passed | | +1 :green_heart: | rubocop | 0m 6s | There were no new rubocop issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 13s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | spotbugs | 4m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 53s | The patch does not generate ASF License warnings. | | | | 51m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1291 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop | | uname | Linux b665e4285b60 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 292cadf847 | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-zookeeper hbase-replication hbase-server hbase-shell hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1291/6/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-23957) [flakey test] client.TestMultiParallel fails to read hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-23957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huaxiang Sun reassigned HBASE-23957:
Assignee: Hua Xiang
> [flakey test] client.TestMultiParallel fails to read hbase-site.xml
> ---
>
> Key: HBASE-23957
> URL: https://issues.apache.org/jira/browse/HBASE-23957
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Nick Dimiduk
>Assignee: Hua Xiang
>Priority: Minor
>
> Saw this on a [PreCommit
> run|https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1258/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt].
> Log file says
> {noformat}
> 2020-03-09 22:48:26,295 FATAL [Time-limited test] conf.Configuration(2853):
> error parsing conf hbase-site.xml
> java.io.FileNotFoundException:
> /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1258@2/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-classes/hbase-site.xml
> (No such file or directory)
> at java.io.FileInputStream.open0(Native Method)
> at java.io.FileInputStream.open(FileInputStream.java:195)
> at java.io.FileInputStream.(FileInputStream.java:138)
> at java.io.FileInputStream.(FileInputStream.java:93)
> at
> sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90)
> at
> sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188)
> at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2672)
> at
> org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2746)
> at
> org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2706)
> at
> org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2579)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:1091)
> at
> org.apache.hadoop.conf.Configuration.getTrimmed(Configuration.java:1145)
> at
> org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2363)
> at
> org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2793)
> at
> org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2810)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:100)
> at
> org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2849)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2831)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:389)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:181)
> at org.apache.hadoop.hbase.fs.HFileSystem.(HFileSystem.java:85)
> at org.apache.hadoop.hbase.fs.HFileSystem.get(HFileSystem.java:465)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getTestFileSystem(HBaseTestingUtility.java:3180)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getNewDataTestDirOnTestFS(HBaseTestingUtility.java:507)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.setupDataTestDirOnTestFS(HBaseTestingUtility.java:496)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:469)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:483)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.createDirsAndSetProperties(HBaseTestingUtility.java:651)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:603)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:586)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1039)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1004)
> at
> org.apache.hadoop.hbase.client.TestMultiParallel.beforeClass(TestMultiParallel.java:96)
> {noformat}
> This stage ran on H9.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] ndimiduk commented on a change in pull request #1302: HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust
ndimiduk commented on a change in pull request #1302: HBASE-23999 [flakey test]
TestTableOutputFormatConnectionExhaust
URL: https://github.com/apache/hbase/pull/1302#discussion_r394046422
##
File path:
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionTool.java
##
@@ -60,12 +57,6 @@
public void setUp() throws Exception {
this.testUtil.startMiniCluster();
testUtil.createTable(tableName, HBaseTestingUtility.fam1);
-String defaultFS =
testUtil.getMiniHBaseCluster().getConfiguration().get("fs.defaultFS");
-Configuration config = HBaseConfiguration.create();
-config.set("fs.defaultFS", defaultFS);
-String configPath = this.getClass().getClassLoader()
- .getResource("hbase-site.xml").getFile();
-config.writeXml(new FileOutputStream(new File(configPath)));
Review comment:
@wchevreuil can you comment as to why this test needed to write out it's
`hbase-site.xml`? Presumably it was done for a reason and it's not enough to
simply not write it out.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (HBASE-24008) Create branch-2.3 from branch-2 and increment branch-2 version
Nick Dimiduk created HBASE-24008: Summary: Create branch-2.3 from branch-2 and increment branch-2 version Key: HBASE-24008 URL: https://issues.apache.org/jira/browse/HBASE-24008 Project: HBase Issue Type: Task Reporter: Nick Dimiduk Assignee: Nick Dimiduk Per the summary. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] qiaoandxiang opened a new pull request #1302: HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust
qiaoandxiang opened a new pull request #1302: HBASE-23999 [flakey test] TestTableOutputFormatConnectionExhaust URL: https://github.com/apache/hbase/pull/1302 Do not overwrite the hbase-site.xml which is being used by other tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile
Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile URL: https://github.com/apache/hbase/pull/1298#issuecomment-600364196 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 46s | master passed | | +1 :green_heart: | compile | 3m 12s | master passed | | +1 :green_heart: | shadedjars | 5m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 47s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 23s | the patch passed | | +1 :green_heart: | compile | 3m 10s | the patch passed | | +1 :green_heart: | javac | 3m 10s | the patch passed | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 45s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 66m 23s | root in the patch failed. | | | | 102m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1298 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 191e2f0caee3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9804f73c66 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/testReport/ | | Max. process+thread count | 6063 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1297: HBASE-23998. Update license for jetty-client.
Apache-HBase commented on issue #1297: HBASE-23998. Update license for jetty-client. URL: https://github.com/apache/hbase/pull/1297#issuecomment-600356033 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 17s | master passed | | +1 :green_heart: | javadoc | 0m 12s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 55s | the patch passed | | +1 :green_heart: | javadoc | 0m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 11s | hbase-resource-bundle in the patch passed. | | | | 15m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1297 | | Optional Tests | javac javadoc unit | | uname | Linux f1e0b580f14e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9804f73c66 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/testReport/ | | Max. process+thread count | 62 (vs. ulimit of 1) | | modules | C: hbase-resource-bundle U: hbase-resource-bundle | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1297: HBASE-23998. Update license for jetty-client.
Apache-HBase commented on issue #1297: HBASE-23998. Update license for jetty-client. URL: https://github.com/apache/hbase/pull/1297#issuecomment-600355895 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 14s | master passed | | +1 :green_heart: | javadoc | 0m 14s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 14s | the patch passed | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 14s | hbase-resource-bundle in the patch passed. | | | | 14m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1297 | | Optional Tests | javac javadoc unit | | uname | Linux 70de729b5988 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9804f73c66 | | Default Java | 2020-01-14 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/testReport/ | | Max. process+thread count | 98 (vs. ulimit of 1) | | modules | C: hbase-resource-bundle U: hbase-resource-bundle | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1291: HBASE-23993 Use loopback for zk standalone server in minizkcluster
saintstack commented on issue #1291: HBASE-23993 Use loopback for zk standalone server in minizkcluster URL: https://github.com/apache/hbase/pull/1291#issuecomment-600355671 The shell failures were legit. For the other tests that are failing, OOME. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1301: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
Apache-HBase commented on issue #1301: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal URL: https://github.com/apache/hbase/pull/1301#issuecomment-600353458 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 29s | master passed | | +1 :green_heart: | checkstyle | 1m 15s | master passed | | -1 :x: | spotbugs | 2m 13s | hbase-server in master has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 34s | the patch passed | | -0 :warning: | checkstyle | 1m 17s | hbase-server: The patch generated 9 new + 1 unchanged - 0 fixed = 10 total (was 1) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 8s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 :x: | spotbugs | 2m 39s | hbase-server generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) | ||| _ Other Tests _ | | -1 :x: | asflicense | 0m 13s | The patch generated 1 ASF License warnings. | | | | 48m 0s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | Possible null pointer dereference of FanOutOneBlockAsyncDFSOutputSaslHelper$SaslNegotiateHandler$BuilderPayloadSetter.setPayloadMethod in org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper$SaslNegotiateHandler$BuilderPayloadSetter.setter(DataTransferProtos$DataTransferEncryptorMessageProto$Builder, byte[]) on exception path Dereferenced at FanOutOneBlockAsyncDFSOutputSaslHelper.java:FanOutOneBlockAsyncDFSOutputSaslHelper$SaslNegotiateHandler$BuilderPayloadSetter.setPayloadMethod in org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper$SaslNegotiateHandler$BuilderPayloadSetter.setter(DataTransferProtos$DataTransferEncryptorMessageProto$Builder, byte[]) on exception path Dereferenced at FanOutOneBlockAsyncDFSOutputSaslHelper.java:[line 381] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1301 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 1d8bc2f6f13b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9804f73c66 | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1301/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1297: HBASE-23998. Update license for jetty-client.
Apache-HBase commented on issue #1297: HBASE-23998. Update license for jetty-client. URL: https://github.com/apache/hbase/pull/1297#issuecomment-600353213 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 8s | The patch does not generate ASF License warnings. | | | | 2m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1297 | | Optional Tests | dupname asflicense xml | | uname | Linux 36d11bad3e59 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9804f73c66 | | Max. process+thread count | 41 (vs. ulimit of 1) | | modules | C: hbase-resource-bundle U: hbase-resource-bundle | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work started] (HBASE-23834) HBase fails to run on Hadoop 3.3.0/3.2.2/3.1.4 due to jetty version mismatch
[ https://issues.apache.org/jira/browse/HBASE-23834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23834 started by Wei-Chiu Chuang. --- > HBase fails to run on Hadoop 3.3.0/3.2.2/3.1.4 due to jetty version mismatch > > > Key: HBASE-23834 > URL: https://issues.apache.org/jira/browse/HBASE-23834 > Project: HBase > Issue Type: Bug >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > > HBase master branch is currently on Jetty 9.3, and latest Hadoop 3 > (unreleased branches trunk, branch-3.2 and branch-3.1) bumped Jetty to 9.4 to > address a vulnerability CVE-2017-9735. > (1) Jetty 9.3 and 9.4 are quite different (there are incompatible API > changes) and HBase won't start on the latest Hadoop 3. > (2) In any case, HBase should update its Jetty dependency to address the > vulnerability. > Fortunately for HBase, updating to Jetty 9.4 requires no code change other > than the maven version string. > More tests are needed to verify if HBase can run on older Hadoop versions if > its Jetty is updated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23833) The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
[
https://issues.apache.org/jira/browse/HBASE-23833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HBASE-23833:
Status: Patch Available (was: Open)
> The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
> --
>
> Key: HBASE-23833
> URL: https://issues.apache.org/jira/browse/HBASE-23833
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 3.0.0
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
>
> Hadoop trunk (3.3.0) shaded protobuf and moved it to hadoop-thirdparty. As
> the result, hbase asyncwal fails to compile because asyncwal uses the
> Hadoop's protobuf objects.
> The following command
> {code}
> mvn clean install -Dhadoop.profile=3.0 -Dhadoop.version=3.3.0-SNAPSHOT
> {code}
> fails with the following error:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile
> (default-compile) on project hbase-server: Compilation failure: Compilation
> failure:
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[361,44]
> cannot access org.apache.hadoop.thirdparty.protobuf.MessageOrBuilder
> [ERROR] class file for
> org.apache.hadoop.thirdparty.protobuf.MessageOrBuilder not found
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[362,14]
> cannot access org.apache.hadoop.thirdparty.protobuf.GeneratedMessageV3
> [ERROR] class file for
> org.apache.hadoop.thirdparty.protobuf.GeneratedMessageV3 not found
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[366,16]
> cannot access org.apache.hadoop.thirdparty.protobuf.ByteString
> [ERROR] class file for org.apache.hadoop.thirdparty.protobuf.ByteString not
> found
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[375,12]
> cannot find symbol
> [ERROR] symbol: method
> writeDelimitedTo(org.apache.hbase.thirdparty.io.netty.buffer.ByteBufOutputStream)
> [ERROR] location: variable proto of type
> org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.DataTransferEncryptorMessageProto
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[702,81]
> incompatible types:
> org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.DataTransferEncryptorMessageProto
> cannot be converted to com.google.protobuf.MessageLite
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[314,66]
> incompatible types:
> org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.BlockOpResponseProto
> cannot be converted to com.google.protobuf.MessageLite
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[330,81]
> cannot access org.apache.hadoop.thirdparty.protobuf.ProtocolMessageEnum
> [ERROR] class file for
> org.apache.hadoop.thirdparty.protobuf.ProtocolMessageEnum not found
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[380,10]
> cannot find symbol
> [ERROR] symbol: method
> writeDelimitedTo(org.apache.hbase.thirdparty.io.netty.buffer.ByteBufOutputStream)
> [ERROR] location: variable proto of type
> org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.OpWriteBlockProto
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[422,77]
> cannot access org.apache.hadoop.thirdparty.protobuf.Descriptors
> [ERROR] class file for org.apache.hadoop.thirdparty.protobuf.Descriptors
> not found
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutput.java:[323,64]
> incompatible types:
> org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.PipelineAckProto
> cannot be converted to com.google.protobuf.MessageLite
> [ERROR]
> /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/SyncReplicationWALProvider.java:[209,68]
> invalid method reference
> [ERROR] non-static method get() cannot be referenced from a static context
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1297: HBASE-23998. Update license for jetty-client.
Apache-HBase commented on issue #1297: HBASE-23998. Update license for jetty-client. URL: https://github.com/apache/hbase/pull/1297#issuecomment-600349186 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 12s | master passed | | +1 :green_heart: | checkstyle | 1m 14s | master passed | | -1 :x: | spotbugs | 2m 12s | hbase-server in master has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 46s | the patch passed | | -0 :warning: | checkstyle | 1m 12s | hbase-server: The patch generated 9 new + 1 unchanged - 0 fixed = 10 total (was 1) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 48s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 :x: | spotbugs | 2m 23s | hbase-server generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) | ||| _ Other Tests _ | | -1 :x: | asflicense | 0m 13s | The patch generated 1 ASF License warnings. | | | | 45m 32s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | Possible null pointer dereference of FanOutOneBlockAsyncDFSOutputSaslHelper$SaslNegotiateHandler$BuilderPayloadSetter.setPayloadMethod in org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper$SaslNegotiateHandler$BuilderPayloadSetter.setter(DataTransferProtos$DataTransferEncryptorMessageProto$Builder, byte[]) on exception path Dereferenced at FanOutOneBlockAsyncDFSOutputSaslHelper.java:FanOutOneBlockAsyncDFSOutputSaslHelper$SaslNegotiateHandler$BuilderPayloadSetter.setPayloadMethod in org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper$SaslNegotiateHandler$BuilderPayloadSetter.setter(DataTransferProtos$DataTransferEncryptorMessageProto$Builder, byte[]) on exception path Dereferenced at FanOutOneBlockAsyncDFSOutputSaslHelper.java:[line 381] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1297 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 4e813477b689 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9804f73c66 | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile
Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile URL: https://github.com/apache/hbase/pull/1298#issuecomment-600343838 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 18m 1s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 26m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1298 | | Optional Tests | dupname asflicense shellcheck shelldocs hadoopcheck xml | | uname | Linux 2228c2d8e469 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9804f73c66 | | Max. process+thread count | 63 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] jojochuang opened a new pull request #1301: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal
jojochuang opened a new pull request #1301: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal URL: https://github.com/apache/hbase/pull/1301 I've tried a few approaches. It turns out the quickest solution to this is with Java Reflection. (1) Create a ProtobufDecoder that is inspired by io.netty.handler.codec.protobuf.ProtobufDecoder. The original ProtobufDecoder has dependency on protobuf. Use reflection to access the shaded protobuf in HDFS when applicable. (2) Similarly, create a private class BuilderPayloadSetter that does ByteString.copyFrom() + DataTransferEncryptorMessageProto.Builder.setPayload(). Manually tested with Hadoop 3.1.2 and 3.3.0-SNAPSHOT (on top of HBASE-23833 and HBASE-23998) Please let me know if this is the acceptable approach. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23891) Add an option to Actions to filter out meta RS
[
https://issues.apache.org/jira/browse/HBASE-23891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061237#comment-17061237
]
Hudson commented on HBASE-23891:
Results for branch branch-2.2
[build #818 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/818/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/818//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/818//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/818//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add an option to Actions to filter out meta RS
> --
>
> Key: HBASE-23891
> URL: https://issues.apache.org/jira/browse/HBASE-23891
> Project: HBase
> Issue Type: Sub-task
> Components: integration tests
>Affects Versions: 3.0.0
>Reporter: Tamas Adami
>Assignee: Szabolcs Bukros
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
>
> Add an option to Actions to be able to filter meta server out.
> Some ITs rely on meta RS and have timeout errors if this RS is killed. (e.g.
> IntegrationTestTimeBoundedRequestsWithRegionReplicas)
> For the time being there is no option for removing meta server from server
> list to kill or configuring these actions properly.
> The following chaos monkey actions are affected:
> GracefulRollingRestartRsAction, RollingBatchSuspendResumeRsAction
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-23999) [flakey test] TestTableOutputFormatConnectionExhaust
[
https://issues.apache.org/jira/browse/HBASE-23999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huaxiang Sun reassigned HBASE-23999:
Assignee: Hua Xiang
> [flakey test] TestTableOutputFormatConnectionExhaust
>
>
> Key: HBASE-23999
> URL: https://issues.apache.org/jira/browse/HBASE-23999
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Hua Xiang
>Priority: Major
>
> Hit this during master startup sequence in the test.
> {noformat}
> 2020-03-16 23:40:37,298 ERROR [StoreOpener-1588230740-1]
> conf.Configuration(2980): error parsing conf hbase-site.xml
> com.ctc.wstx.exc.WstxEOFException: Unexpected EOF in prolog
> at [row,col,system-id]:
> [1,0,"file:/home/vagrant/repos/hbase/hbase-mapreduce/target/test-classes/hbase-site.xml"]
> at
> com.ctc.wstx.sr.StreamScanner.throwUnexpectedEOF(StreamScanner.java:687)
> at
> com.ctc.wstx.sr.BasicStreamReader.handleEOF(BasicStreamReader.java:2220)
> at
> com.ctc.wstx.sr.BasicStreamReader.nextFromProlog(BasicStreamReader.java:2126)
> at com.ctc.wstx.sr.BasicStreamReader.next(BasicStreamReader.java:1181)
> at
> org.apache.hadoop.conf.Configuration$Parser.parseNext(Configuration.java:3277)
> at
> org.apache.hadoop.conf.Configuration$Parser.parse(Configuration.java:3071)
> at
> org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2964)
> at
> org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2930)
> at
> org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2805)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:1199)
> at
> org.apache.hadoop.conf.Configuration.getTrimmed(Configuration.java:1253)
> at
> org.apache.hadoop.conf.Configuration.getBoolean(Configuration.java:1659)
> at
> org.apache.hadoop.hbase.HBaseConfiguration.checkDefaultsVersion(HBaseConfiguration.java:70)
> at
> org.apache.hadoop.hbase.HBaseConfiguration.addHbaseResources(HBaseConfiguration.java:84)
> at
> org.apache.hadoop.hbase.HBaseConfiguration.create(HBaseConfiguration.java:98)
> at org.apache.hadoop.hbase.io.crypto.Context.(Context.java:44)
> at
> org.apache.hadoop.hbase.io.crypto.Encryption$Context.(Encryption.java:64)
> at
> org.apache.hadoop.hbase.io.crypto.Encryption$Context.(Encryption.java:61)
> at org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:228)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:5890)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1096)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1093)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:834)
> 2020-03-16 23:40:37,301 ERROR [master/bionic:0:becomeActiveMaster]
> regionserver.HRegion(1137): Could not initialize all stores for the
> region=hbase:meta,,1.1588230740
> {noformat}
> Looking at the file under {{target/test-classes}}, it looks like this is a
> file written by YARN.
> {noformat}
>
> yarn.log-aggregation.file-formatsTFilefalseyarn-default.xml
> hbase.master.mob.ttl.cleaner.period86400falsehbase-default.xml
> dfs.namenode.resource.check.interval5000falsehdfs-default.xml
> mapreduce.jobhistory.client.thread-count10falsemapred-default.xml
> ...
> {noformat}
> My guess is that we have something in the MR framework unconfigured, it's
> writing these temporary job files to some default (like the first class path
> location or something??) and parallel test runs are stomping on each other.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile
Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile URL: https://github.com/apache/hbase/pull/1298#issuecomment-600336633 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile
Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile URL: https://github.com/apache/hbase/pull/1298#issuecomment-600336600 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile
Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile URL: https://github.com/apache/hbase/pull/1298#issuecomment-600336585 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/3/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23981) PBType which is marked as IA.Public references protobuf Message
[ https://issues.apache.org/jira/browse/HBASE-23981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061233#comment-17061233 ] Nick Dimiduk commented on HBASE-23981: -- Oh man, the old datatype stuff. I think this class should be in abase-examples, not in hbase-common. > PBType which is marked as IA.Public references protobuf Message > --- > > Key: HBASE-23981 > URL: https://issues.apache.org/jira/browse/HBASE-23981 > Project: HBase > Issue Type: Task >Reporter: Duo Zhang >Priority: Critical > > This is a very critical problem as we leak protobuf in our user facing public > API? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23971) protoc warns: "no protobuf syntax specified"
[
https://issues.apache.org/jira/browse/HBASE-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-23971.
---
Fix Version/s: 2.3.0
Resolution: Fixed
Merged the patch to branch-2 (not to branch-2.2). Thanks for the cleanup
[~wenfeiyi666]
> protoc warns: "no protobuf syntax specified"
>
>
> Key: HBASE-23971
> URL: https://issues.apache.org/jira/browse/HBASE-23971
> Project: HBase
> Issue Type: Task
> Components: Protobufs
>Reporter: Nick Dimiduk
>Assignee: wenfeiyi666
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
>
> This comes up in a couple places.
> {noformat}
> [INFO] --- protobuf-maven-plugin:0.6.1:compile (compile-protoc) @
> hbase-protocol-shaded ---
> [INFO] Compiling 37 proto file(s) to
> /Users/ndimiduk/repos/apache/hbase/hbase-protocol-shaded/target/generated-sources/protobuf/java
> [WARNING] PROTOC: [libprotobuf WARNING
> google/protobuf/compiler/parser.cc:546] No syntax specified for the proto
> file: RSGroupAdmin.proto. Please use 'syntax = "proto2";' or 'syntax =
> "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
> [libprotobuf WARNING google/protobuf/compiler/parser.cc:546] No syntax
> specified for the proto file: RSGroup.proto. Please use 'syntax = "proto2";'
> or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2
> syntax.)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile
Apache-HBase commented on issue #1298: HBASE-24002 shadedjars check does not propagate --hadoop-profile URL: https://github.com/apache/hbase/pull/1298#issuecomment-600335591 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 13s | master passed | | +1 :green_heart: | compile | 4m 22s | master passed | | -1 :x: | shadedjars | 0m 8s | branch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | root in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 0s | the patch passed | | +1 :green_heart: | compile | 4m 20s | the patch passed | | +1 :green_heart: | javac | 4m 20s | the patch passed | | -1 :x: | shadedjars | 0m 8s | patch has 7 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 19s | root in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 138m 44s | root in the patch failed. | | | | 166m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1298 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b109c7dcd5fb 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 60de4c2e31 | | Default Java | 2020-01-14 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/2/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/2/testReport/ | | Max. process+thread count | 5803 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1298/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23981) PBType which is marked as IA.Public references protobuf Message
[ https://issues.apache.org/jira/browse/HBASE-23981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061231#comment-17061231 ] Nick Dimiduk commented on HBASE-23981: -- Sounds like a critical problem to me. I don't think we want to expose even shaded protobuf classes to users. > PBType which is marked as IA.Public references protobuf Message > --- > > Key: HBASE-23981 > URL: https://issues.apache.org/jira/browse/HBASE-23981 > Project: HBase > Issue Type: Task >Reporter: Duo Zhang >Priority: Critical > > This is a very critical problem as we leak protobuf in our user facing public > API? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (HBASE-23971) protoc warns: "no protobuf syntax specified"
[
https://issues.apache.org/jira/browse/HBASE-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack reopened HBASE-23971:
---
Reopened to apply the branch-2 patch.
> protoc warns: "no protobuf syntax specified"
>
>
> Key: HBASE-23971
> URL: https://issues.apache.org/jira/browse/HBASE-23971
> Project: HBase
> Issue Type: Task
> Components: Protobufs
>Reporter: Nick Dimiduk
>Assignee: wenfeiyi666
>Priority: Minor
> Fix For: 3.0.0
>
>
> This comes up in a couple places.
> {noformat}
> [INFO] --- protobuf-maven-plugin:0.6.1:compile (compile-protoc) @
> hbase-protocol-shaded ---
> [INFO] Compiling 37 proto file(s) to
> /Users/ndimiduk/repos/apache/hbase/hbase-protocol-shaded/target/generated-sources/protobuf/java
> [WARNING] PROTOC: [libprotobuf WARNING
> google/protobuf/compiler/parser.cc:546] No syntax specified for the proto
> file: RSGroupAdmin.proto. Please use 'syntax = "proto2";' or 'syntax =
> "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
> [libprotobuf WARNING google/protobuf/compiler/parser.cc:546] No syntax
> specified for the proto file: RSGroup.proto. Please use 'syntax = "proto2";'
> or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2
> syntax.)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23829) Get `-PrunSmallTests` passing on JDK11
[
https://issues.apache.org/jira/browse/HBASE-23829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061224#comment-17061224
]
Nick Dimiduk commented on HBASE-23829:
--
[~stack] I filed HBASE-24005 to track documenting this thing.
> Get `-PrunSmallTests` passing on JDK11
> --
>
> Key: HBASE-23829
> URL: https://issues.apache.org/jira/browse/HBASE-23829
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Start with the small tests, shaking out issues identified by the harness. So
> far it seems like {{-Dhadoop.profile=3.0}} and
> {{-Dhadoop-three.version=3.3.0-SNAPSHOT}} maybe be required.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack commented on issue #1293: HBASE-23970 TestUsersOperationsWithSecureHadoop fails when an existing ticket is present
saintstack commented on issue #1293: HBASE-23970 TestUsersOperationsWithSecureHadoop fails when an existing ticket is present URL: https://github.com/apache/hbase/pull/1293#issuecomment-600331609 I removed the overcommit to TestUsersOperationsWithSecureHadoop with the below push on master commit 9804f73c66730c3a3413afb1338c6dfe0eecb0ab (HEAD -> m, origin/master, origin/HEAD) Author: stack Date: Tue Mar 17 15:27:28 2020 -0700 HBASE-23971 protoc warns: "no protobuf syntax specified" (#1278) Remove overcommit in TestUsersOperationsWithSecureHadoop (Noticed by ndimiduk) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23971) protoc warns: "no protobuf syntax specified"
[
https://issues.apache.org/jira/browse/HBASE-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061223#comment-17061223
]
Michael Stack commented on HBASE-23971:
---
I applied an addendum remove an accidental change to
TestUsersOperationsWithSecureHadoop noticed by [~ndimiduk]
> protoc warns: "no protobuf syntax specified"
>
>
> Key: HBASE-23971
> URL: https://issues.apache.org/jira/browse/HBASE-23971
> Project: HBase
> Issue Type: Task
> Components: Protobufs
>Reporter: Nick Dimiduk
>Assignee: wenfeiyi666
>Priority: Minor
> Fix For: 3.0.0
>
>
> This comes up in a couple places.
> {noformat}
> [INFO] --- protobuf-maven-plugin:0.6.1:compile (compile-protoc) @
> hbase-protocol-shaded ---
> [INFO] Compiling 37 proto file(s) to
> /Users/ndimiduk/repos/apache/hbase/hbase-protocol-shaded/target/generated-sources/protobuf/java
> [WARNING] PROTOC: [libprotobuf WARNING
> google/protobuf/compiler/parser.cc:546] No syntax specified for the proto
> file: RSGroupAdmin.proto. Please use 'syntax = "proto2";' or 'syntax =
> "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
> [libprotobuf WARNING google/protobuf/compiler/parser.cc:546] No syntax
> specified for the proto file: RSGroup.proto. Please use 'syntax = "proto2";'
> or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2
> syntax.)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack commented on issue #1293: HBASE-23970 TestUsersOperationsWithSecureHadoop fails when an existing ticket is present
saintstack commented on issue #1293: HBASE-23970 TestUsersOperationsWithSecureHadoop fails when an existing ticket is present URL: https://github.com/apache/hbase/pull/1293#issuecomment-600329870 @ndimiduk noticed that some of this patch got accidentally committed as part of https://github.com/apache/hbase/pull/1278/files Let me revert that piece. I had this issue myself today. Its a pain. Lets get a fix in. I like Nick's idea of confining deletion to test realm but not sure its possible; would be cool if it was. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1293: HBASE-23970 TestUsersOperationsWithSecureHadoop fails when an existing ticket is present
ndimiduk commented on a change in pull request #1293: HBASE-23970
TestUsersOperationsWithSecureHadoop fails when an existing ticket is present
URL: https://github.com/apache/hbase/pull/1293#discussion_r394002431
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestUsersOperationsWithSecureHadoop.java
##
@@ -65,11 +67,19 @@
private static String CLIENT_NAME;
@BeforeClass
- public static void destroyAndSetup() throws Exception {
-//destroy localhost kerberos users
-Process process = Runtime.getRuntime().exec(new String[]{"bash", "-c",
"kdestroy"});
-process.waitFor(2, TimeUnit.SECONDS);
Review comment:
This previous `waitFor` call doesn't check the return value. It's possible
the call failed but the test didn't notice.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1293: HBASE-23970 TestUsersOperationsWithSecureHadoop fails when an existing ticket is present
ndimiduk commented on a change in pull request #1293: HBASE-23970
TestUsersOperationsWithSecureHadoop fails when an existing ticket is present
URL: https://github.com/apache/hbase/pull/1293#discussion_r394002808
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestUsersOperationsWithSecureHadoop.java
##
@@ -65,11 +67,19 @@
private static String CLIENT_NAME;
@BeforeClass
- public static void destroyAndSetup() throws Exception {
-//destroy localhost kerberos users
-Process process = Runtime.getRuntime().exec(new String[]{"bash", "-c",
"kdestroy"});
-process.waitFor(2, TimeUnit.SECONDS);
-// setup mini kdc
+ public static void checkAndSetup() throws Exception {
+// check localhost kerberos users
+Process process = Runtime.getRuntime().exec(new String[]{"bash", "-c",
"klist"});
+boolean wait = process.waitFor(2, TimeUnit.SECONDS);
Review comment:
I think a simple `assertTrue` is sufficient for this case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Resolved] (HBASE-24004) Include hadoop version in Nightly report name
[ https://issues.apache.org/jira/browse/HBASE-24004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24004. -- Resolution: Fixed > Include hadoop version in Nightly report name > - > > Key: HBASE-24004 > URL: https://issues.apache.org/jira/browse/HBASE-24004 > Project: HBase > Issue Type: Task > Components: build >Affects Versions: 3.0.0, 2.3.0 >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Trivial > Fix For: 3.0.0, 2.3.0 > > > A minor thing I missed in HBASE-23876. Have this report name match the other > "JDKX, HadoopY" report names. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24004) Include hadoop version in Nightly report name
[ https://issues.apache.org/jira/browse/HBASE-24004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24004: - Fix Version/s: 2.3.0 > Include hadoop version in Nightly report name > - > > Key: HBASE-24004 > URL: https://issues.apache.org/jira/browse/HBASE-24004 > Project: HBase > Issue Type: Task > Components: build >Affects Versions: 3.0.0, 2.3.0 >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Trivial > Fix For: 3.0.0, 2.3.0 > > > A minor thing I missed in HBASE-23876. Have this report name match the other > "JDKX, HadoopY" report names. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ndimiduk opened a new pull request #1300: Backport "HBASE-24004 Include hadoop version in Nightly report name" to branch-2
ndimiduk opened a new pull request #1300: Backport "HBASE-24004 Include hadoop version in Nightly report name" to branch-2 URL: https://github.com/apache/hbase/pull/1300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22114) Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1
[
https://issues.apache.org/jira/browse/HBASE-22114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061213#comment-17061213
]
Hudson commented on HBASE-22114:
Results for branch HBASE-22114-branch-1
[build #106 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22114-branch-1/106/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22114-branch-1/106//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22114-branch-1/106//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22114-branch-1/106//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1
> ---
>
> Key: HBASE-22114
> URL: https://issues.apache.org/jira/browse/HBASE-22114
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 1.7.0
>
> Attachments: HBASE-22114-branch-1.patch, HBASE-22114-branch-1.patch,
> HBASE-22114-branch-1.patch
>
>
> HBASE-15560 introduces the TinyLFU cache policy for the blockcache.
> W-TinyLFU ([research paper|http://arxiv.org/pdf/1512.00727.pdf]) records the
> frequency in a counting sketch, ages periodically by halving the counters,
> and orders entries by SLRU. An entry is discarded by comparing the frequency
> of the new arrival (candidate) to the SLRU's victim, and keeping the one with
> the highest frequency. This allows the operations to be performed in O(1)
> time and, though the use of a compact sketch, a much larger history is
> retained beyond the current working set. In a variety of real world traces
> the policy had [near optimal hit
> rates|https://github.com/ben-manes/caffeine/wiki/Efficiency].
> The implementation of HBASE-15560 uses several Java 8 idioms, depends on JRE
> 8+ type Optional, and has dependencies on libraries compiled with Java 8+
> bytecode. It could be backported to branch-1 but must be made optional both
> at compile time and runtime, enabled by the 'build-with-jdk8' build profile.
> The TinyLFU policy must go into its own build module.
> The blockcache must be modified to load L1 implementation/policy dynamically
> at startup by reflection if the policy is "TinyLFU"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] ndimiduk merged pull request #1300: Backport "HBASE-24004 Include hadoop version in Nightly report name" to branch-2
ndimiduk merged pull request #1300: Backport "HBASE-24004 Include hadoop version in Nightly report name" to branch-2 URL: https://github.com/apache/hbase/pull/1300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24004) Include hadoop version in Nightly report name
[ https://issues.apache.org/jira/browse/HBASE-24004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24004: - Fix Version/s: 3.0.0 > Include hadoop version in Nightly report name > - > > Key: HBASE-24004 > URL: https://issues.apache.org/jira/browse/HBASE-24004 > Project: HBase > Issue Type: Task > Components: build >Affects Versions: 3.0.0, 2.3.0 >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Trivial > Fix For: 3.0.0 > > > A minor thing I missed in HBASE-23876. Have this report name match the other > "JDKX, HadoopY" report names. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ndimiduk merged pull request #1299: HBASE-24004 Include hadoop version in Nightly report name
ndimiduk merged pull request #1299: HBASE-24004 Include hadoop version in Nightly report name URL: https://github.com/apache/hbase/pull/1299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-24007) Get `-PrunLargeTests` passing on JDK11
Nick Dimiduk created HBASE-24007: Summary: Get `-PrunLargeTests` passing on JDK11 Key: HBASE-24007 URL: https://issues.apache.org/jira/browse/HBASE-24007 Project: HBase Issue Type: Sub-task Components: test Reporter: Nick Dimiduk Build on HBASE-23829 and HBASE-24006, now looking at large tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24006) Get `-PrunMediumTests` passing on JDK11
[
https://issues.apache.org/jira/browse/HBASE-24006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061211#comment-17061211
]
Nick Dimiduk commented on HBASE-24006:
--
I have a clean (local) build with {{-PrunMediumTests}} on branch-2 using the
flakey test exclude filter; no code changes necessary. Now to work through the
exclusions.
> Get `-PrunMediumTests` passing on JDK11
> ---
>
> Key: HBASE-24006
> URL: https://issues.apache.org/jira/browse/HBASE-24006
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Nick Dimiduk
>Priority: Major
>
> Build on HBASE-23829, now looking at medium tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-24006) Get `-PrunMediumTests` passing on JDK11
Nick Dimiduk created HBASE-24006: Summary: Get `-PrunMediumTests` passing on JDK11 Key: HBASE-24006 URL: https://issues.apache.org/jira/browse/HBASE-24006 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 3.0.0, 2.3.0 Reporter: Nick Dimiduk Build on HBASE-23829, now looking at medium tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
