[jira] [Commented] (HBASE-24167) [Flakey Tests] TestHRegionWithInMemoryFlush#testWritesWhileScanning gets stuck MVCC
[
https://issues.apache.org/jira/browse/HBASE-24167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083651#comment-17083651
]
Hudson commented on HBASE-24167:
Results for branch branch-2.2
[build #837 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/837/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/837//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/837//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/837//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] TestHRegionWithInMemoryFlush#testWritesWhileScanning gets
> stuck MVCC
> ---
>
> Key: HBASE-24167
> URL: https://issues.apache.org/jira/browse/HBASE-24167
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
> Attachments:
> 0001-HBASE-24167-Flakey-Tests-TestHRegionWithInMemoryFlus.patch
>
>
> I see this in recent nightly fails on branch-2, my experimental branch. It
> happened in the two builds last night. It was only test to fail. Both failed
> with:
> 2020-04-10 07:42:46,700 WARN [Time-limited test]
> regionserver.MultiVersionConcurrencyControl(228): STUCK:
> MultiVersionConcurrencyControl{readPoint=8684, writePoint=8686}
> I ran the test in my harness and it pushes up against heap limits for sure,
> especially after recent cut down in forked jvm size.
> For now, see if alleviating scope of testWritesWhileScanning just when called
> from this test helps w/ flakeyness. Probably worth a deep dive why we get
> into this state w/ in-memory compaction.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24175) [Flakey Tests] TestSecureExportSnapshot FileNotFoundException
[
https://issues.apache.org/jira/browse/HBASE-24175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083650#comment-17083650
]
Hudson commented on HBASE-24175:
Results for branch branch-2.2
[build #837 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/837/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/837//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/837//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/837//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] TestSecureExportSnapshot FileNotFoundException
> -
>
> Key: HBASE-24175
> URL: https://issues.apache.org/jira/browse/HBASE-24175
> Project: HBase
> Issue Type: Sub-task
> Components: flakies
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
> Attachments:
> 0001-HBASE-24175-Flakey-Tests-TestSecureExportSnapshot-Fi.patch
>
>
> Why we writing '/tmp' dir?
> {code}
> Error Message
> org.apache.hadoop.service.ServiceStateException:
> java.io.FileNotFoundException: File
> file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing
> does not exist
> Stacktrace
> org.apache.hadoop.yarn.exceptions.YarnRuntimeException:
> org.apache.hadoop.service.ServiceStateException:
> java.io.FileNotFoundException: File
> file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing
> does not exist
> at
> org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.setUpBeforeClass(TestSecureExportSnapshot.java:56)
> Caused by: org.apache.hadoop.service.ServiceStateException:
> java.io.FileNotFoundException: File
> file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing
> does not exist
> at
> org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.setUpBeforeClass(TestSecureExportSnapshot.java:56)
> Caused by: java.io.FileNotFoundException: File
> file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing
> does not exist
> at
> org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.setUpBeforeClass(TestSecureExportSnapshot.java:56)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] HorizonNet commented on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException
HorizonNet commented on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1465#issuecomment-613708694 Will this be covered in #1508? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1512: HBASE-24186: RegionMover ignores replicationId
HorizonNet commented on a change in pull request #1512: HBASE-24186: RegionMover ignores replicationId URL: https://github.com/apache/hbase/pull/1512#discussion_r408467753 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java ## @@ -755,7 +755,8 @@ private ServerName getServerNameForRegion(RegionInfo region) throws IOException return null; } HRegionLocation loc = - conn.getRegionLocator(region.getTable()).getRegionLocation(region.getStartKey(), true); + conn.getRegionLocator(region.getTable()).getRegionLocation(region.getStartKey(), Review comment: Is there already a test, which covers the old as well as the new behavior? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore
Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore URL: https://github.com/apache/hbase/pull/1513#issuecomment-613706607 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 13s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 53s | branch-2.3 passed | | +1 :green_heart: | compile | 1m 40s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 3s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | compile | 1m 41s | the patch passed | | +1 :green_heart: | javac | 1m 41s | the patch passed | | +1 :green_heart: | shadedjars | 6m 12s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 54s | hbase-common in the patch passed. | | -1 :x: | unit | 187m 34s | hbase-server in the patch failed. | | | | 220m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1513 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1c12fba3f61c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / a33e4d2168 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/testReport/ | | Max. process+thread count | 2722 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1440: HBASE-23113: Improve and add additional Netty configuration for RPC.
ndimiduk commented on issue #1440: HBASE-23113: Improve and add additional Netty configuration for RPC. URL: https://github.com/apache/hbase/pull/1440#issuecomment-613705682 Let's get the change to expose these configs into branch-2.3. We'll leave the default settings as they are until we have some proof that new defaults are doing some good. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer
Apache-HBase commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer URL: https://github.com/apache/hbase/pull/1514#issuecomment-613703542 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 34s | master passed | | +1 :green_heart: | checkstyle | 1m 6s | master passed | | +1 :green_heart: | spotbugs | 2m 2s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 16s | the patch passed | | +1 :green_heart: | checkstyle | 1m 5s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 42s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 31m 49s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1514 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux d8f55374dded 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4fc3527e46 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-24189) Regionserver recreates region folders in HDFS after replaying WAL with removed table entries
Andrey Elenskiy created HBASE-24189: --- Summary: Regionserver recreates region folders in HDFS after replaying WAL with removed table entries Key: HBASE-24189 URL: https://issues.apache.org/jira/browse/HBASE-24189 Project: HBase Issue Type: Bug Components: regionserver, wal Affects Versions: 2.2.4 Environment: * HDFS 3.1.3 * HBase 2.1.4 * OpenJDK 8 Reporter: Andrey Elenskiy Under the following scenario region directories in HDFS can be recreated with only recovered.edits in them: # Create table "test" # Put into "test" # Delete table "test" # Create table "test" again # Crash the regionserver to which the put has went to force the WAL replay # Region directory in old table is recreated in new table # hbase hbck returns inconsistency This appears to happen due to the fact that WALs are not cleaned up once a table is deleted and they still contain the edits from old table. I've tried wal_roll command on the regionserver before crashing it, but it doesn't seem to help as under some circumstances there are still WAL files around. The only solution that works consistently is to restart regionserver before creating the table at step 4 because that triggers log cleanup on startup: [https://github.com/apache/hbase/blob/f3ee9b8aa37dd30d34ff54cd39fb9b4b6d22e683/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java#L508|https://github.com/apache/hbase/blob/f3ee9b8aa37dd30d34ff54cd39fb9b4b6d22e683/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java#L508)] Truncating a table also would be a workaround by in our case it's a no-go as we create and delete tables in our tests which run back to back (create table in the beginning of the test and delete in the end of the test). A nice option in our case would be to provide hbase shell utility to force clean up of log files manually as I realize that it's not really viable to clean all of those up every time some table is removed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore
Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore URL: https://github.com/apache/hbase/pull/1513#issuecomment-613703376 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 57s | branch-2.3 passed | | +1 :green_heart: | compile | 1m 52s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 7m 34s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 22s | hbase-common in branch-2.3 failed. | | -0 :warning: | javadoc | 0m 50s | hbase-server in branch-2.3 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 22s | the patch passed | | +1 :green_heart: | compile | 1m 55s | the patch passed | | +1 :green_heart: | javac | 1m 55s | the patch passed | | +1 :green_heart: | shadedjars | 6m 16s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 1m 2s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 23s | hbase-common in the patch passed. | | -1 :x: | unit | 175m 10s | hbase-server in the patch failed. | | | | 211m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1513 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ed3e626e5954 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / a33e4d2168 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/testReport/ | | Max. process+thread count | 2846 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24087) Backport HBASE-8868 to branch-2.2
[ https://issues.apache.org/jira/browse/HBASE-24087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HBASE-24087: Fix Version/s: 2.2.5 Resolution: Fixed Status: Resolved (was: Patch Available) The PR is merged. Resolve this jira. > Backport HBASE-8868 to branch-2.2 > - > > Key: HBASE-24087 > URL: https://issues.apache.org/jira/browse/HBASE-24087 > Project: HBase > Issue Type: Task >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > Fix For: 2.2.5 > > > There's just a trivial conflict in import. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24124) hbase-filesystem to use guava from hbase-thirdparty
[
https://issues.apache.org/jira/browse/HBASE-24124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang resolved HBASE-24124.
-
Resolution: Fixed
Thanks the review from [~tamaas] and [~busbey]!
> hbase-filesystem to use guava from hbase-thirdparty
> ---
>
> Key: HBASE-24124
> URL: https://issues.apache.org/jira/browse/HBASE-24124
> Project: HBase
> Issue Type: Task
> Components: Filesystem Integration
>Affects Versions: 1.0.0-alpha1
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Fix For: 1.0.0-alpha2
>
>
> hbase-filesystem repo is on guava23.0:
> {noformat}
> $ grep -r "guava" .
> ./pom.xml:23.0
> ./hbase-oss/pom.xml: com.google.guava
> ./hbase-oss/pom.xml: guava
> ./hbase-oss/pom.xml: ${guava.version}
> ./hbase-oss/pom.xml:
[GitHub] [hbase] huaxiangsun opened a new pull request #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer
huaxiangsun opened a new pull request #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer URL: https://github.com/apache/hbase/pull/1514 Will put up a root cause analysis later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-filesystem] busbey closed pull request #12: HBASE-24124 hbase-filesystem to use guava from hbase-thirdparty
busbey closed pull request #12: HBASE-24124 hbase-filesystem to use guava from hbase-thirdparty URL: https://github.com/apache/hbase-filesystem/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1512: HBASE-24186: RegionMover ignores replicationId
Apache-HBase commented on issue #1512: HBASE-24186: RegionMover ignores replicationId URL: https://github.com/apache/hbase/pull/1512#issuecomment-613639219 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 1s | master passed | | +1 :green_heart: | compile | 1m 17s | master passed | | +1 :green_heart: | shadedjars | 6m 24s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 47s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 47s | the patch passed | | +1 :green_heart: | compile | 1m 16s | the patch passed | | +1 :green_heart: | javac | 1m 16s | the patch passed | | +1 :green_heart: | shadedjars | 6m 25s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 46s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 192m 1s | hbase-server in the patch passed. | | | | 221m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1512/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1512 | | JIRA Issue | HBASE-24186 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 091e9142d75b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1512/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1512/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1512/1/testReport/ | | Max. process+thread count | 2878 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1512/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24181) Add region info when log meessages in HRegion.
[
https://issues.apache.org/jira/browse/HBASE-24181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083555#comment-17083555
]
Hudson commented on HBASE-24181:
Results for branch branch-2.3
[build #33 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/33/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/33/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/33/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/33/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/33/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add region info when log meessages in HRegion.
> --
>
> Key: HBASE-24181
> URL: https://issues.apache.org/jira/browse/HBASE-24181
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 3.0.0
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
>
> Some log message do not have region info when log, need to add it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1511: HBASE-24139 : Balancer should avoid leaving idle region servers
Apache-HBase commented on issue #1511: HBASE-24139 : Balancer should avoid leaving idle region servers URL: https://github.com/apache/hbase/pull/1511#issuecomment-613633398 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 24s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 6m 0s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 47s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 26s | the patch passed | | +1 :green_heart: | compile | 1m 9s | the patch passed | | +1 :green_heart: | javac | 1m 9s | the patch passed | | +1 :green_heart: | shadedjars | 6m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 201m 14s | hbase-server in the patch failed. | | | | 228m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1511 | | JIRA Issue | HBASE-24139 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 575ecdcb8764 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/1/testReport/ | | Max. process+thread count | 2627 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24181) Add region info when log meessages in HRegion.
[
https://issues.apache.org/jira/browse/HBASE-24181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083544#comment-17083544
]
Hudson commented on HBASE-24181:
Results for branch branch-2
[build #2607 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2607/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2607/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2607/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2607/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2607/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add region info when log meessages in HRegion.
> --
>
> Key: HBASE-24181
> URL: https://issues.apache.org/jira/browse/HBASE-24181
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 3.0.0
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
>
> Some log message do not have region info when log, need to add it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24176) user_permission '.*' command failed to show all table permissions
[
https://issues.apache.org/jira/browse/HBASE-24176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083543#comment-17083543
]
Hudson commented on HBASE-24176:
Results for branch branch-2
[build #2607 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2607/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2607/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2607/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2607/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2607/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> user_permission '.*' command failed to show all table permissions
> --
>
> Key: HBASE-24176
> URL: https://issues.apache.org/jira/browse/HBASE-24176
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: song XinCun
>Assignee: song XinCun
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
>
> When we grant somebody global permission, then we use '.*' as the argument of
> user_permission to show all table permissions, the following exception
> occurred:
> {code:java}
> hbase(main):001:0> grant 'user3', 'RW'
> Took 0.4144 seconds
>
>
> hbase(main):002:0> user_permission
> User
> Namespace,Table,Family,Qualifier:Permission
>
> user2 ,,,: [Permission:
> actions=READ,WRITE]
>
> user3 ,,,: [Permission:
> actions=READ,WRITE]
>
> hbaseadmin ,,,: [Permission:
> actions=READ,WRITE,EXEC,CREATE,ADMIN]
>
> 3 row(s)
> Took 0.0445 seconds
>
>
> hbase(main):003:0> user_permission '.*'
> User
> Namespace,Table,Family,Qualifier:Permission
>
> user1 default,t1,,: [Permission:
> actions=READ,WRITE]
>
> hbaseadmin default,t1,,: [Permission:
> actions=READ,WRITE,EXEC,CREATE,ADMIN]
> ERROR: failed to coerce
> org.apache.hadoop.hbase.security.access.GlobalPermission to
> org.apache.hadoop.hbase.security.access.TablePermissionFor usage try 'help
> "user_permission"'Took 0.0940 seconds
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore
Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore URL: https://github.com/apache/hbase/pull/1513#issuecomment-613627995 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.3 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 49s | branch-2.3 passed | | +1 :green_heart: | checkstyle | 1m 37s | branch-2.3 passed | | +1 :green_heart: | spotbugs | 2m 47s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 30s | the patch passed | | +1 :green_heart: | checkstyle | 1m 37s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 12m 1s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 3m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 38m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1513 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml | | uname | Linux f8b13867e07b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / a33e4d2168 | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-24180) Edit test doc around forkcount and speeding up test runs
[ https://issues.apache.org/jira/browse/HBASE-24180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24180. --- Fix Version/s: 3.0.0 Hadoop Flags: Reviewed Resolution: Fixed Pushed on master branch. Thanks for review [~janh] > Edit test doc around forkcount and speeding up test runs > > > Key: HBASE-24180 > URL: https://issues.apache.org/jira/browse/HBASE-24180 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0 > > > Give the 'Running unit tests' section an edit. Fold in findings of late > around how to speed up tests, hardware limits and sizings, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
Apache-HBase commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1510#issuecomment-613608546 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 43s | branch-1 passed | | +1 :green_heart: | compile | 0m 40s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | compile | 0m 45s | branch-1 passed with JDK v1.7.0_252 | | +1 :green_heart: | checkstyle | 1m 39s | branch-1 passed | | +1 :green_heart: | shadedjars | 3m 10s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 40s | branch-1 passed with JDK v1.7.0_252 | | +0 :ok: | spotbugs | 3m 13s | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 :x: | findbugs | 3m 8s | hbase-server in branch-1 has 1 extant findbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 53s | the patch passed | | +1 :green_heart: | compile | 0m 40s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javac | 0m 40s | the patch passed | | +1 :green_heart: | compile | 0m 45s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | javac | 0m 45s | the patch passed | | +1 :green_heart: | checkstyle | 1m 32s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 2m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 5m 1s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 31s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 41s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | findbugs | 2m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 130m 26s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 171m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1510 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 049d69b6eb0d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1510/out/precommit/personality/provided.sh | | git revision | branch-1 / 7b12709 | | Default Java | 1.7.0_252 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/2/artifact/out/branch-findbugs-hbase-server-warnings.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/2/testReport/ | | Max. process+thread count | 4094 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/2/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1512: HBASE-24186: RegionMover ignores replicationId
Apache-HBase commented on issue #1512: HBASE-24186: RegionMover ignores replicationId URL: https://github.com/apache/hbase/pull/1512#issuecomment-613608426 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | master passed | | +1 :green_heart: | compile | 1m 6s | master passed | | +1 :green_heart: | shadedjars | 6m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 46s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 22s | the patch passed | | +1 :green_heart: | compile | 1m 12s | the patch passed | | +1 :green_heart: | javac | 1m 12s | the patch passed | | +1 :green_heart: | shadedjars | 6m 15s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 133m 1s | hbase-server in the patch passed. | | | | 161m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1512/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1512 | | JIRA Issue | HBASE-24186 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ff0535ecfe08 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1512/1/testReport/ | | Max. process+thread count | 4294 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1512/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1513: HBASE-24188 PR Hanger. Ignore
saintstack commented on issue #1513: HBASE-24188 PR Hanger. Ignore URL: https://github.com/apache/hbase/pull/1513#issuecomment-613607197 Nothing change to trip hbase-server builds to see if brings on OOME can't create native thread. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24072) Nightlies reporting OutOfMemoryError: unable to create new native thread
[
https://issues.apache.org/jira/browse/HBASE-24072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083492#comment-17083492
]
Michael Stack commented on HBASE-24072:
---
Ran my little TestPrintEnv which outputs ulimits seen inside container and it
seems to show right numbers...
{code}
core file size (blocks, -c) unlimited
data seg size (kbytes, -d) unlimited
scheduling priority (-e) 0
file size (blocks, -f) unlimited
pending signals (-i) 192962
max locked memory (kbytes, -l) 16384
max memory size (kbytes, -m) unlimited
open files (-n) 1048576
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority (-r) 0
stack size (kbytes, -s) 8192
cpu time (seconds, -t) unlimited
max user processes (-u) 12500
virtual memory (kbytes, -v) unlimited
file locks (-x) unlimited
{code}
> Nightlies reporting OutOfMemoryError: unable to create new native thread
>
>
> Key: HBASE-24072
> URL: https://issues.apache.org/jira/browse/HBASE-24072
> Project: HBase
> Issue Type: Task
> Components: test
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments:
> 0001-HBASE-24072-Nightlies-reporting-OutOfMemoryError-una.patch,
> print_ulimit.patch
>
>
> Seeing this kind of thing in nightly...
> {code}
> java.lang.RuntimeException: java.lang.OutOfMemoryError: unable to create new
> native thread
> at
> org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.beforeClass(TestMultithreadedTableMapper.java:83)
> Caused by: java.lang.OutOfMemoryError: unable to create new native thread
> at
> org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.beforeClass(TestMultithreadedTableMapper.java:83)
> {code}
> Chatting w/ Nick and Huaxiang, doing the math, we are likely oversubscribing
> our docker container. It is set to 20G (The hosts are 48G). Fork count is
> 0.5C on a 16 CPU machine which is 8 *2.8G our current forked jvm size. Add
> the maven 4G and we could be over the top.
> Play w/ downing the fork size (in earlier study we didn't seem to need this
> much RAM when running a fat long test). Let me also take th ms off the mvn
> allocation to see if that helps.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack commented on a change in pull request #1487: HBASE-23800 Add documentation about the CECPs changes
saintstack commented on a change in pull request #1487: HBASE-23800 Add
documentation about the CECPs changes
URL: https://github.com/apache/hbase/pull/1487#discussion_r408328092
##
File path: src/main/asciidoc/_chapters/protobuf.adoc
##
@@ -148,3 +148,67 @@ consider extending it also in
Going forward, we will provide a new module of common types for use
by CPEPs that will have the same guarantees against change as does our
public API. TODO.
+
+=== protobuf changes for hbase-3.0.0 (HBASE-23797)
+Since hadoop also shades protobuf and bumps the version to 3.x, there is no
+reason for us to stay on protobuf 2.5.0 any more.
+
+In 3.0.0, the hbase-protocol module has been purged, the CPEP implementation
+should use the protos in hbase-protocol-shaded module, and also make use of
+the shaded protobuf in hbase-thirdparty.
+
+Add this dependency to your pom:
+[source,xml]
+
+
+ org.apache.hbase.thirdparty
+ hbase-shaded-protobuf
+
+ ${hbase-thirdparty.version}
+ provided
+
+
+
+And typically you also need to add this plugin to your pom to make your
+generated protobuf code also use the shaded and relocated protobuf version
+in hbase-thirdparty.
Review comment:
Good. Point there? Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1511: HBASE-24139 : Balancer should avoid leaving idle region servers
Apache-HBase commented on issue #1511: HBASE-24139 : Balancer should avoid leaving idle region servers URL: https://github.com/apache/hbase/pull/1511#issuecomment-613589165 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 10s | master passed | | +1 :green_heart: | compile | 1m 3s | master passed | | +1 :green_heart: | shadedjars | 5m 25s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 52s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 5m 26s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 120m 50s | hbase-server in the patch failed. | | | | 145m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1511 | | JIRA Issue | HBASE-24139 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a38d695db11c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/1/testReport/ | | Max. process+thread count | 4197 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1487: HBASE-23800 Add documentation about the CECPs changes
saintstack commented on a change in pull request #1487: HBASE-23800 Add documentation about the CECPs changes URL: https://github.com/apache/hbase/pull/1487#discussion_r408327843 ## File path: src/main/asciidoc/_chapters/protobuf.adoc ## @@ -148,3 +148,67 @@ consider extending it also in Going forward, we will provide a new module of common types for use by CPEPs that will have the same guarantees against change as does our public API. TODO. + +=== protobuf changes for hbase-3.0.0 (HBASE-23797) +Since hadoop also shades protobuf and bumps the version to 3.x, there is no +reason for us to stay on protobuf 2.5.0 any more. + +In 3.0.0, the hbase-protocol module has been purged, the CPEP implementation +should use the protos in hbase-protocol-shaded module, and also make use of +the shaded protobuf in hbase-thirdparty. Review comment: Yeah. Don't think it noted anywhere else. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1487: HBASE-23800 Add documentation about the CECPs changes
saintstack commented on a change in pull request #1487: HBASE-23800 Add documentation about the CECPs changes URL: https://github.com/apache/hbase/pull/1487#discussion_r408327561 ## File path: src/main/asciidoc/_chapters/protobuf.adoc ## @@ -148,3 +148,67 @@ consider extending it also in Going forward, we will provide a new module of common types for use by CPEPs that will have the same guarantees against change as does our public API. TODO. + +=== protobuf changes for hbase-3.0.0 (HBASE-23797) +Since hadoop also shades protobuf and bumps the version to 3.x, there is no Review comment: k. Would be good to say in doc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1487: HBASE-23800 Add documentation about the CECPs changes
saintstack commented on a change in pull request #1487: HBASE-23800 Add documentation about the CECPs changes URL: https://github.com/apache/hbase/pull/1487#discussion_r408327295 ## File path: src/main/asciidoc/_chapters/cp.adoc ## @@ -193,6 +209,12 @@ link:https://issues.apache.org/jira/browse/HBASE-5448[HBASE-5448]). To upgrade y HBase cluster from 0.94 or earlier to 0.96 or later, you need to reimplement your coprocessor. +In HBase 2.0.0, we make use of a shaded version of protobuf 3.x, but still keep the +protobuf for coprocessor on 2.5.0. In 3.0.0, we removed all dependencies on non-shaded +protobuf so you need to reimplement your coprocessor to make use of the shaded protobuf +version provided in hbase-thirdparty. Please see the <> section for Review comment: I was asking what the audience for protos is. If used by CPEP, then they are not Private. LimitedPrivate for CPEPs? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack merged pull request #1505: HBASE-24180 Edit test doc around forkcount and speeding up test runs
saintstack merged pull request #1505: HBASE-24180 Edit test doc around forkcount and speeding up test runs URL: https://github.com/apache/hbase/pull/1505 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1512: HBASE-24186: RegionMover ignores replicationId
virajjasani commented on issue #1512: HBASE-24186: RegionMover ignores replicationId URL: https://github.com/apache/hbase/pull/1512#issuecomment-613567036 Pending QA This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore
Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore URL: https://github.com/apache/hbase/pull/1513#issuecomment-613559833 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 56s | branch-2.3 passed | | +1 :green_heart: | checkstyle | 0m 28s | branch-2.3 passed | | +1 :green_heart: | spotbugs | 0m 57s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 15s | the patch passed | | +1 :green_heart: | checkstyle | 0m 26s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 34s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 1m 1s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 36m 49s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1513 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 761c9bbffd43 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / a33e4d2168 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1511: HBASE-24139 : Balancer should avoid leaving idle region servers
virajjasani commented on a change in pull request #1511: HBASE-24139 : Balancer
should avoid leaving idle region servers
URL: https://github.com/apache/hbase/pull/1511#discussion_r408284020
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##
@@ -310,6 +310,19 @@ protected synchronized boolean
areSomeRegionReplicasColocated(Cluster c) {
return false;
}
+ private synchronized boolean areThereIdleRegions(Cluster c){
Review comment:
Also, `idleRegionsExist()` might be better name
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1511: HBASE-24139 : Balancer should avoid leaving idle region servers
virajjasani commented on a change in pull request #1511: HBASE-24139 : Balancer
should avoid leaving idle region servers
URL: https://github.com/apache/hbase/pull/1511#discussion_r408283480
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##
@@ -310,6 +310,19 @@ protected synchronized boolean
areSomeRegionReplicasColocated(Cluster c) {
return false;
}
+ private synchronized boolean areThereIdleRegions(Cluster c){
Review comment:
How about putting this method in `BaseLoadBalancer` as `protected final` ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore
Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore URL: https://github.com/apache/hbase/pull/1513#issuecomment-613553480 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 44s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 19s | branch-2.3 passed | | +1 :green_heart: | compile | 0m 24s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 14s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 19s | hbase-common in branch-2.3 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | the patch passed | | +1 :green_heart: | compile | 0m 27s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | +1 :green_heart: | shadedjars | 5m 10s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-common in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 42s | hbase-common in the patch passed. | | | | 24m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1513 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2b6fd72f065e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / a33e4d2168 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/1/testReport/ | | Max. process+thread count | 384 (vs. ulimit of 12500) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1505: HBASE-24180 Edit test doc around forkcount and speeding up test runs
Apache-HBase commented on issue #1505: HBASE-24180 Edit test doc around forkcount and speeding up test runs URL: https://github.com/apache/hbase/pull/1505#issuecomment-613552102 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 5s | master passed | | +0 :ok: | refguide | 5m 28s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 43s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 5m 33s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 18s | The patch does not generate ASF License warnings. | | | | 22m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1505/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1505 | | Optional Tests | dupname asflicense refguide | | uname | Linux 6aaddfe0a76d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1505/2/artifact/yetus-general-check/output/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1505/2/artifact/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 65 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1505/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore
Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore URL: https://github.com/apache/hbase/pull/1513#issuecomment-613552505 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 5s | branch-2.3 passed | | +1 :green_heart: | compile | 0m 23s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 4m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 42s | the patch passed | | +1 :green_heart: | compile | 0m 24s | the patch passed | | +1 :green_heart: | javac | 0m 24s | the patch passed | | +1 :green_heart: | shadedjars | 4m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 21s | hbase-common in the patch passed. | | | | 23m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1513 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3ed1825c4507 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / a33e4d2168 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/1/testReport/ | | Max. process+thread count | 234 (vs. ulimit of 12500) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1509: HBASE-24182 log when the region is set to closing status
Apache-HBase commented on issue #1509: HBASE-24182 log when the region is set to closing status URL: https://github.com/apache/hbase/pull/1509#issuecomment-613551412 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 35s | master passed | | +1 :green_heart: | compile | 1m 9s | master passed | | +1 :green_heart: | shadedjars | 6m 6s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 26s | the patch passed | | +1 :green_heart: | compile | 1m 8s | the patch passed | | +1 :green_heart: | javac | 1m 8s | the patch passed | | +1 :green_heart: | shadedjars | 6m 36s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 48s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 192m 22s | hbase-server in the patch passed. | | | | 220m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1509/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1509 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux df0821cd3e6c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1509/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1509/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1509/1/testReport/ | | Max. process+thread count | 3178 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1509/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1505: HBASE-24180 Edit test doc around forkcount and speeding up test runs
Apache-HBase commented on issue #1505: HBASE-24180 Edit test doc around forkcount and speeding up test runs URL: https://github.com/apache/hbase/pull/1505#issuecomment-613542043 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1505/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1505 | | Optional Tests | | | uname | Linux fa43e63ed12c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | Max. process+thread count | 54 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1505/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1505: HBASE-24180 Edit test doc around forkcount and speeding up test runs
Apache-HBase commented on issue #1505: HBASE-24180 Edit test doc around forkcount and speeding up test runs URL: https://github.com/apache/hbase/pull/1505#issuecomment-613541400 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1505/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1505 | | Optional Tests | | | uname | Linux 9c2278580479 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | Max. process+thread count | 47 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1505/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1512: HBASE-24186: RegionMover ignores replicationId
Apache-HBase commented on issue #1512: HBASE-24186: RegionMover ignores replicationId URL: https://github.com/apache/hbase/pull/1512#issuecomment-613540796 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 31s | master passed | | +1 :green_heart: | checkstyle | 1m 6s | master passed | | +1 :green_heart: | spotbugs | 2m 0s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 14s | the patch passed | | +1 :green_heart: | checkstyle | 1m 3s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 34s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 9s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 31m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1512/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1512 | | JIRA Issue | HBASE-24186 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 94bcf908994b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1512/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1505: HBASE-24180 Edit test doc around forkcount and speeding up test runs
saintstack commented on issue #1505: HBASE-24180 Edit test doc around forkcount and speeding up test runs URL: https://github.com/apache/hbase/pull/1505#issuecomment-613539971 Thanks for the review @HorizonNet Pushed new version addressing comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1505: HBASE-24180 Edit test doc around forkcount and speeding up test runs
saintstack commented on a change in pull request #1505: HBASE-24180 Edit test doc around forkcount and speeding up test runs URL: https://github.com/apache/hbase/pull/1505#discussion_r408264103 ## File path: src/main/asciidoc/_chapters/developer.adoc ## @@ -1364,17 +1404,13 @@ sudo mount -t tmpfs -o size=2048M tmpfs /ram2G You can then use it to run all HBase tests on 2.0 with the command: Review comment: Thats dumb. Thanks for fingering it. I didn't read what was there just blindly changing structure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack opened a new pull request #1513: HBASE-24188 PR Hanger. Ignore
saintstack opened a new pull request #1513: HBASE-24188 PR Hanger. Ignore URL: https://github.com/apache/hbase/pull/1513 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-24188) PR Hanger. Ignore
Michael Stack created HBASE-24188: - Summary: PR Hanger. Ignore Key: HBASE-24188 URL: https://issues.apache.org/jira/browse/HBASE-24188 Project: HBase Issue Type: Bug Reporter: Michael Stack -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1511: HBASE-24139
Apache-HBase commented on issue #1511: HBASE-24139 URL: https://github.com/apache/hbase/pull/1511#issuecomment-613529918 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 37s | master passed | | +1 :green_heart: | checkstyle | 1m 7s | master passed | | +1 :green_heart: | spotbugs | 1m 59s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 11s | the patch passed | | -0 :warning: | checkstyle | 1m 5s | hbase-server: The patch generated 3 new + 26 unchanged - 0 fixed = 29 total (was 26) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 42s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 31m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1511 | | JIRA Issue | HBASE-24139 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 4113a7c1217d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1511/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] BukrosSzabolcs opened a new pull request #1512: HBASE-24186: RegionMover ignores replicationId
BukrosSzabolcs opened a new pull request #1512: HBASE-24186: RegionMover ignores replicationId URL: https://github.com/apache/hbase/pull/1512 add replicationId to RegionMover logic This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24139) Balancer should avoid leaving idle region servers
[
https://issues.apache.org/jira/browse/HBASE-24139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083350#comment-17083350
]
Beata Sudi commented on HBASE-24139:
You can find the PR here: [https://github.com/apache/hbase/pull/1511]
> Balancer should avoid leaving idle region servers
> -
>
> Key: HBASE-24139
> URL: https://issues.apache.org/jira/browse/HBASE-24139
> Project: HBase
> Issue Type: Improvement
> Components: Balancer, Operability
>Reporter: Sean Busbey
>Assignee: Beata Sudi
>Priority: Critical
> Labels: beginner
>
> After HBASE-15529 the StochasticLoadBalancer makes the decision to run based
> on its internal cost functions rather than the simple region count skew of
> BaseLoadBalancer.
> Given the default weights for those cost functions, the default minimum cost
> to indicate a need to rebalance, and a regions per region server density of
> ~90 we are not very responsive to adding additional region servers for
> non-trivial cluster sizes:
> * For clusters ~10 nodes, the defaults think a single RS at 0 regions means
> we need to balance
> * For clusters >20 nodes, the defaults will not consider a single RS at 0
> regions to mean we need to balance. 2 RS at 0 will cause it to balance.
> * For clusters ~100 nodes, having 6 RS with no regions will still not meet
> the threshold to cause a balance.
> Note that this is the decision to look at balancer plans at all. The
> calculation is severely dominated by the region count skew (it has weight 500
> and all other weights are ~105), so barring a very significant change in all
> other cost functions this condition will persist indefinitely.
> Two possible approaches:
> * add a new cost function that's essentially "don't have RS with 0 regions"
> that an operator can tune
> * add a short circuit condition for the {{needsBalance}} method that checks
> for empty RS similar to the check we do for colocated region replicas
> For those currently hitting this an easy work around is to set
> {{hbase.master.balancer.stochastic.minCostNeedBalance}} to {{0.01}}. This
> will mean that a single RS having 0 regions will cause the balancer to run
> for clusters of up to ~90 region servers. It's essentially the same as the
> default slop of 0.01 used by the BaseLoadBalancer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24139) Balancer should avoid leaving idle region servers
[
https://issues.apache.org/jira/browse/HBASE-24139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083345#comment-17083345
]
Sean Busbey commented on HBASE-24139:
-
{quote}
bq. Given the other caveats against using "balancer per table" maybe we could
expressly only do the short circuit when we are not doing per-table?
what about changing the new rule like: "don't have RS with 0 regions if there
is any RS with more than 1 regions"
this would be compatible also with "balancer per table"
{quote}
yeah that would work and isn't terribly complicated.
{quote}
bq. I am inclined to take the approach of adding a short circuit to needsBalance
is there any benefit for the user to fine-tune the weight of this rule? If not,
then I think the simpler approach (adding short circuit) is preferable.
Maybe there is a case, when the user first want to add 5 new RS to the cluster,
but doesn't want to re-balance 5 times. But I think in this case he should
disable the loadbalancer before before adding the new nodes then re-enable it
in the end.
{quote}
that's essentially the same line of reasoning I found myself following.
{quote}
Sean Busbey I attempted a try at this, can you have a look at it? I'm still
trying to figure out how to test it, but it would be nice to hear your opinion.
{quote}
That's great! I'd be happy to take a look, can you post a link to the PR here?
> Balancer should avoid leaving idle region servers
> -
>
> Key: HBASE-24139
> URL: https://issues.apache.org/jira/browse/HBASE-24139
> Project: HBase
> Issue Type: Improvement
> Components: Balancer, Operability
>Reporter: Sean Busbey
>Assignee: Beata Sudi
>Priority: Critical
> Labels: beginner
>
> After HBASE-15529 the StochasticLoadBalancer makes the decision to run based
> on its internal cost functions rather than the simple region count skew of
> BaseLoadBalancer.
> Given the default weights for those cost functions, the default minimum cost
> to indicate a need to rebalance, and a regions per region server density of
> ~90 we are not very responsive to adding additional region servers for
> non-trivial cluster sizes:
> * For clusters ~10 nodes, the defaults think a single RS at 0 regions means
> we need to balance
> * For clusters >20 nodes, the defaults will not consider a single RS at 0
> regions to mean we need to balance. 2 RS at 0 will cause it to balance.
> * For clusters ~100 nodes, having 6 RS with no regions will still not meet
> the threshold to cause a balance.
> Note that this is the decision to look at balancer plans at all. The
> calculation is severely dominated by the region count skew (it has weight 500
> and all other weights are ~105), so barring a very significant change in all
> other cost functions this condition will persist indefinitely.
> Two possible approaches:
> * add a new cost function that's essentially "don't have RS with 0 regions"
> that an operator can tune
> * add a short circuit condition for the {{needsBalance}} method that checks
> for empty RS similar to the check we do for colocated region replicas
> For those currently hitting this an easy work around is to set
> {{hbase.master.balancer.stochastic.minCostNeedBalance}} to {{0.01}}. This
> will mean that a single RS having 0 regions will cause the balancer to run
> for clusters of up to ~90 region servers. It's essentially the same as the
> default slop of 0.01 used by the BaseLoadBalancer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1509: HBASE-24182 log when the region is set to closing status
Apache-HBase commented on issue #1509: HBASE-24182 log when the region is set to closing status URL: https://github.com/apache/hbase/pull/1509#issuecomment-613508631 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 42s | master passed | | +1 :green_heart: | compile | 0m 59s | master passed | | +1 :green_heart: | shadedjars | 5m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 4m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 122m 20s | hbase-server in the patch passed. | | | | 144m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1509/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1509 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2985a1df9dd9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1509/1/testReport/ | | Max. process+thread count | 4393 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1509/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24139) Balancer should avoid leaving idle region servers
[
https://issues.apache.org/jira/browse/HBASE-24139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083340#comment-17083340
]
Beata Sudi commented on HBASE-24139:
Hi!
[~busbey] I attempted a try at this, can you have a look at it? I'm still
trying to figure out how to test it, but it would be nice to hear your opinion.
> Balancer should avoid leaving idle region servers
> -
>
> Key: HBASE-24139
> URL: https://issues.apache.org/jira/browse/HBASE-24139
> Project: HBase
> Issue Type: Improvement
> Components: Balancer, Operability
>Reporter: Sean Busbey
>Assignee: Beata Sudi
>Priority: Critical
> Labels: beginner
>
> After HBASE-15529 the StochasticLoadBalancer makes the decision to run based
> on its internal cost functions rather than the simple region count skew of
> BaseLoadBalancer.
> Given the default weights for those cost functions, the default minimum cost
> to indicate a need to rebalance, and a regions per region server density of
> ~90 we are not very responsive to adding additional region servers for
> non-trivial cluster sizes:
> * For clusters ~10 nodes, the defaults think a single RS at 0 regions means
> we need to balance
> * For clusters >20 nodes, the defaults will not consider a single RS at 0
> regions to mean we need to balance. 2 RS at 0 will cause it to balance.
> * For clusters ~100 nodes, having 6 RS with no regions will still not meet
> the threshold to cause a balance.
> Note that this is the decision to look at balancer plans at all. The
> calculation is severely dominated by the region count skew (it has weight 500
> and all other weights are ~105), so barring a very significant change in all
> other cost functions this condition will persist indefinitely.
> Two possible approaches:
> * add a new cost function that's essentially "don't have RS with 0 regions"
> that an operator can tune
> * add a short circuit condition for the {{needsBalance}} method that checks
> for empty RS similar to the check we do for colocated region replicas
> For those currently hitting this an easy work around is to set
> {{hbase.master.balancer.stochastic.minCostNeedBalance}} to {{0.01}}. This
> will mean that a single RS having 0 regions will cause the balancer to run
> for clusters of up to ~90 region servers. It's essentially the same as the
> default slop of 0.01 used by the BaseLoadBalancer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on issue #1507: HBASE-24151 The master server aborted for IllegalThreadStateException
virajjasani commented on issue #1507: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1507#issuecomment-613508043 Thanks @G302 Can you create PR for master? We can let QA run once and I will commit this to master and all branch-2s together. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bea0113 opened a new pull request #1511: Hbase 24139
bea0113 opened a new pull request #1511: Hbase 24139 URL: https://github.com/apache/hbase/pull/1511 Balancer should avoid leaving idle region servers This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1495: HBASE-24170 Remove hadoop-2.0 profile
busbey commented on a change in pull request #1495: HBASE-24170 Remove
hadoop-2.0 profile
URL: https://github.com/apache/hbase/pull/1495#discussion_r408217641
##
File path: dev-support/hbase-personality.sh
##
@@ -589,13 +589,17 @@ function hadoopcheck_rebuild
else
hbase_hadoop2_versions="2.8.5 2.9.2 2.10.0"
fi
- else
-yetus_info "Setting Hadoop 2 versions to test based on
branch-2.3+/master/feature branch rules."
+ elif [[ "${PATCH_BRANCH}" = branch-2.* ]]; then
+yetus_info "Setting Hadoop 2 versions to test based on branch-2.3+ rules."
if [[ "${QUICK_HADOOPCHECK}" == "true" ]]; then
hbase_hadoop2_versions="2.10.0"
else
hbase_hadoop2_versions="2.10.0"
fi
+ else
+yetus_info "Setting Hadoop 2 versions to test based on master/feature
branch rules."
+# we do not support hadoop 2 for hbase 3.x any more
Review comment:
put this in the info message to make clear we're skipping Hadoop 2 because
hbase 3+ won't use it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1495: HBASE-24170 Remove hadoop-2.0 profile
busbey commented on a change in pull request #1495: HBASE-24170 Remove hadoop-2.0 profile URL: https://github.com/apache/hbase/pull/1495#discussion_r408219579 ## File path: pom.xml ## @@ -2632,393 +2595,11 @@ -
[jira] [Assigned] (HBASE-24187) Document usage of hbase.regionserver.fair.region.close.lock
[ https://issues.apache.org/jira/browse/HBASE-24187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lokesh Khurana reassigned HBASE-24187: -- Assignee: Lokesh Khurana > Document usage of hbase.regionserver.fair.region.close.lock > --- > > Key: HBASE-24187 > URL: https://issues.apache.org/jira/browse/HBASE-24187 > Project: HBase > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Lokesh Khurana >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24187) Document usage of hbase.regionserver.fair.region.close.lock
Viraj Jasani created HBASE-24187: Summary: Document usage of hbase.regionserver.fair.region.close.lock Key: HBASE-24187 URL: https://issues.apache.org/jira/browse/HBASE-24187 Project: HBase Issue Type: Task Reporter: Viraj Jasani -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24186) RegionMover ignores replicationId
Szabolcs Bukros created HBASE-24186: --- Summary: RegionMover ignores replicationId Key: HBASE-24186 URL: https://issues.apache.org/jira/browse/HBASE-24186 Project: HBase Issue Type: Bug Components: read replicas Affects Versions: master Reporter: Szabolcs Bukros Assignee: Szabolcs Bukros When RegionMover looks up which rs hosts a region, it does this based on startRowKey. When read replication is enabled this might not return the expected region's data and this can prevent the moving of these regions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (HBASE-24072) Nightlies reporting OutOfMemoryError: unable to create new native thread
[
https://issues.apache.org/jira/browse/HBASE-24072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack reopened HBASE-24072:
---
Reopening. Just as I closed this because we hadn't seen this failure in tests
in a while, last night branch-2.3 failed with this.
The ulimit-a shows that the host had 3 as its ulimit -u. The checkout had
HBASE-24126 Up the container nproc uplimit from 1 to 12500 (#1504) in it
too.
Reopening to see why on branch-2.3 we got this and to figure if general problem
still.
> Nightlies reporting OutOfMemoryError: unable to create new native thread
>
>
> Key: HBASE-24072
> URL: https://issues.apache.org/jira/browse/HBASE-24072
> Project: HBase
> Issue Type: Task
> Components: test
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments:
> 0001-HBASE-24072-Nightlies-reporting-OutOfMemoryError-una.patch,
> print_ulimit.patch
>
>
> Seeing this kind of thing in nightly...
> {code}
> java.lang.RuntimeException: java.lang.OutOfMemoryError: unable to create new
> native thread
> at
> org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.beforeClass(TestMultithreadedTableMapper.java:83)
> Caused by: java.lang.OutOfMemoryError: unable to create new native thread
> at
> org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.beforeClass(TestMultithreadedTableMapper.java:83)
> {code}
> Chatting w/ Nick and Huaxiang, doing the math, we are likely oversubscribing
> our docker container. It is set to 20G (The hosts are 48G). Fork count is
> 0.5C on a 16 CPU machine which is 8 *2.8G our current forked jvm size. Add
> the maven 4G and we could be over the top.
> Play w/ downing the fork size (in earlier study we didn't seem to need this
> much RAM when running a fat long test). Let me also take th ms off the mvn
> allocation to see if that helps.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase-operator-tools] richardantal commented on a change in pull request #55: HBASE-24039
richardantal commented on a change in pull request #55: HBASE-24039
URL:
https://github.com/apache/hbase-operator-tools/pull/55#discussion_r408158545
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##
@@ -133,6 +143,19 @@ void checkHBCKSupport(ClusterConnection connection,
String cmd, String ... suppo
}
}
+ void checkFunctionSupported(ClusterConnection connection, String cmd) throws
IOException {
+if (skipCheck) {
+ LOG.info("Skipped {} command version check; 'skip' set", cmd);
+ return;
+}
+List methods =
Arrays.asList(connection.getHbck().getClass().getDeclaredMethods());
+List finalCmds = functionNameMap.getOrDefault(cmd,
Collections.singletonList(cmd));
+boolean supported = methods.stream().anyMatch(method ->
finalCmds.contains(method.getName()));
+if (!supported) {
+ throw new UnsupportedOperationException("Unsupported command" + cmd);
Review comment:
I think it is not that easy to remove the version check completely, as we
talked about it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
Apache-HBase commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1510#issuecomment-613459613 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 6s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 42s | branch-1 passed | | +1 :green_heart: | compile | 0m 39s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | compile | 0m 45s | branch-1 passed with JDK v1.7.0_252 | | +1 :green_heart: | checkstyle | 1m 37s | branch-1 passed | | +1 :green_heart: | shadedjars | 2m 51s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 45s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 41s | branch-1 passed with JDK v1.7.0_252 | | +0 :ok: | spotbugs | 2m 49s | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 :x: | findbugs | 2m 46s | hbase-server in branch-1 has 1 extant findbugs warnings. | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 8s | root in the patch failed. | | -1 :x: | compile | 0m 30s | hbase-server in the patch failed with JDK v1.8.0_242. | | -1 :x: | javac | 0m 30s | hbase-server in the patch failed with JDK v1.8.0_242. | | -1 :x: | compile | 0m 36s | hbase-server in the patch failed with JDK v1.7.0_252. | | -1 :x: | javac | 0m 36s | hbase-server in the patch failed with JDK v1.7.0_252. | | -1 :x: | checkstyle | 1m 29s | hbase-server: The patch generated 3 new + 21 unchanged - 0 fixed = 24 total (was 21) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | shadedjars | 1m 47s | patch has 14 errors when building our shaded downstream artifacts. | | -1 :x: | hadoopcheck | 1m 4s | The patch causes 14 errors with Hadoop v2.8.5. | | -1 :x: | hadoopcheck | 3m 4s | The patch causes 14 errors with Hadoop v2.9.2. | | +1 :green_heart: | javadoc | 0m 29s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 39s | the patch passed with JDK v1.7.0_252 | | -1 :x: | findbugs | 0m 34s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 39s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | | | | 38m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1510 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8b31d40044b4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1510/out/precommit/personality/provided.sh | | git revision | branch-1 / 7b12709 | | Default Java | 1.7.0_252 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/branch-findbugs-hbase-server-warnings.html | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-compile-hbase-server-jdk1.8.0_242.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-compile-hbase-server-jdk1.8.0_242.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-compile-hbase-server-jdk1.7.0_252.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1510/1/artifact/out/patch-compile-hbase-server-jdk1.7.0_252.txt | | checkstyle |
[GitHub] [hbase-operator-tools] richardantal commented on a change in pull request #55: HBASE-24039
richardantal commented on a change in pull request #55: HBASE-24039
URL:
https://github.com/apache/hbase-operator-tools/pull/55#discussion_r408157150
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##
@@ -133,6 +143,19 @@ void checkHBCKSupport(ClusterConnection connection,
String cmd, String ... suppo
}
}
+ void checkFunctionSupported(ClusterConnection connection, String cmd) throws
IOException {
+if (skipCheck) {
+ LOG.info("Skipped {} command version check; 'skip' set", cmd);
+ return;
+}
+List methods =
Arrays.asList(connection.getHbck().getClass().getDeclaredMethods());
+List finalCmds = functionNameMap.getOrDefault(cmd,
Collections.singletonList(cmd));
+boolean supported = methods.stream().anyMatch(method ->
finalCmds.contains(method.getName()));
+if (!supported) {
+ throw new UnsupportedOperationException("Unsupported command" + cmd);
Review comment:
Thanks, I have changed the message.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] richardantal commented on a change in pull request #55: HBASE-24039
richardantal commented on a change in pull request #55: HBASE-24039
URL:
https://github.com/apache/hbase-operator-tools/pull/55#discussion_r408156087
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##
@@ -133,6 +143,19 @@ void checkHBCKSupport(ClusterConnection connection,
String cmd, String ... suppo
}
}
+ void checkFunctionSupported(ClusterConnection connection, String cmd) throws
IOException {
+if (skipCheck) {
+ LOG.info("Skipped {} command version check; 'skip' set", cmd);
+ return;
+}
+List methods =
Arrays.asList(connection.getHbck().getClass().getDeclaredMethods());
Review comment:
I am not an expert in this topic but I think it does not makes sense to run
hbck on personal computer to repair a remote HBase. The user should run hbck on
the same computer where the problem is. (using ssh for example.) This way the
program would get the jar with the correct version.
Anyway we can continue work on a follow up solution where we get methods
from the Master itself.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1509: HBASE-24182 log when the region is set to closing status
Apache-HBase commented on issue #1509: HBASE-24182 log when the region is set to closing status URL: https://github.com/apache/hbase/pull/1509#issuecomment-613444621 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 38s | master passed | | +1 :green_heart: | checkstyle | 1m 12s | master passed | | +1 :green_heart: | spotbugs | 2m 1s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 13s | the patch passed | | +1 :green_heart: | checkstyle | 1m 7s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 53s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 31m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1509/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1509 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 2dea3f432a35 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1509/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1487: HBASE-23800 Add documentation about the CECPs changes
Apache-HBase commented on issue #1487: HBASE-23800 Add documentation about the CECPs changes URL: https://github.com/apache/hbase/pull/1487#issuecomment-613440577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | master passed | | +0 :ok: | refguide | 5m 47s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 25s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 6m 50s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | | | | 23m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1487 | | Optional Tests | dupname asflicense refguide | | uname | Linux dd1cd3970177 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/3/artifact/yetus-general-check/output/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/3/artifact/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 65 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24134) Down forked JVM heap size from 2800m to 2200m for jdk8 and jdk11
[
https://issues.apache.org/jira/browse/HBASE-24134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083225#comment-17083225
]
Hudson commented on HBASE-24134:
Results for branch master
[build #1698 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Down forked JVM heap size from 2800m to 2200m for jdk8 and jdk11
>
>
> Key: HBASE-24134
> URL: https://issues.apache.org/jira/browse/HBASE-24134
> Project: HBase
> Issue Type: Sub-task
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Docker container we run tests in is hardcoded 20G. Our fork count is 0.25C
> currently. The jenkins machines are 16CPUs. 0.25C means 4CPUs so 4 forks
> running at any one time. Our current forked JVM heap size is 2800m if jdk8 or
> 3200m if jdk11. If we want to move our fork count to 0.5C, then that means 8
> forks possibly running at once: i.e. 8 * 2800 = 22.4G... i.e. too big for the
> container. This issue is about running w/ smaller forked jvm heap size. If
> 2200m then, its 19.6G which is cutting it close but might allow us sqeeze
> through (mvn takes 4G!). Lets see.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24150) Allow module tests run in parallel
[
https://issues.apache.org/jira/browse/HBASE-24150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083221#comment-17083221
]
Hudson commented on HBASE-24150:
Results for branch master
[build #1698 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Allow module tests run in parallel
> --
>
> Key: HBASE-24150
> URL: https://issues.apache.org/jira/browse/HBASE-24150
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Parent issue is about upping forkcount. This one is about mildly letting
> modules run tests in parallel. Parent wants forkcount to be 0.5C so we use
> half the processors. This is about keeping forkcount at 0.25C but allowing
> two modules to run their tests at same time when mvn figures it is possible.
> In a test on a local machine, using forkcount of 1.0C and -T == 1 -- default
> -- the full test suite took 1hr 15mins. With forkcount at 0.5 and T == 2,
> full suite took 53mins.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24132) Upgrade to Apache ZooKeeper 3.5.7
[
https://issues.apache.org/jira/browse/HBASE-24132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083222#comment-17083222
]
Hudson commented on HBASE-24132:
Results for branch master
[build #1698 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade to Apache ZooKeeper 3.5.7
> -
>
> Key: HBASE-24132
> URL: https://issues.apache.org/jira/browse/HBASE-24132
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.3
>Reporter: Jianfei Jiang
>Assignee: Jianfei Jiang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Apache ZooKeeper 3.5.7 has been released, HDFS and other projects have
> updated the dependent zookeeper verison. Perhaps Hbase may update as well.
> Some of the interfaces are changed in this zookeeper version .
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24158) [Flakey Tests] TestAsyncTableGetMultiThreaded
[
https://issues.apache.org/jira/browse/HBASE-24158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083220#comment-17083220
]
Hudson commented on HBASE-24158:
Results for branch master
[build #1698 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] TestAsyncTableGetMultiThreaded
> -
>
> Key: HBASE-24158
> URL: https://issues.apache.org/jira/browse/HBASE-24158
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments:
> 0001-HBASE-24158-Flakey-Tests-TestAsyncTableGetMultiThrea.patch
>
>
> I've already cut down the number of threads used by this test but it failed
> in nightly last night unable to close out its xml and locally it failed too
> in a run overnight. I ran it under harness and it seems well-behaved. It
> doesn't use much memory -- 700MB -- and thread counts are usual (~450). It
> does use near 100% CPU which is a little unusual. Otherwise, looks fine.
> Let me keep an eye on it. Could down the thread count more and use less
> processes... this makes it use less CPU. There does seems a bunch of overlap
> with tests done elsewhere.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24175) [Flakey Tests] TestSecureExportSnapshot FileNotFoundException
[
https://issues.apache.org/jira/browse/HBASE-24175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083218#comment-17083218
]
Hudson commented on HBASE-24175:
Results for branch master
[build #1698 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] TestSecureExportSnapshot FileNotFoundException
> -
>
> Key: HBASE-24175
> URL: https://issues.apache.org/jira/browse/HBASE-24175
> Project: HBase
> Issue Type: Sub-task
> Components: flakies
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
> Attachments:
> 0001-HBASE-24175-Flakey-Tests-TestSecureExportSnapshot-Fi.patch
>
>
> Why we writing '/tmp' dir?
> {code}
> Error Message
> org.apache.hadoop.service.ServiceStateException:
> java.io.FileNotFoundException: File
> file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing
> does not exist
> Stacktrace
> org.apache.hadoop.yarn.exceptions.YarnRuntimeException:
> org.apache.hadoop.service.ServiceStateException:
> java.io.FileNotFoundException: File
> file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing
> does not exist
> at
> org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.setUpBeforeClass(TestSecureExportSnapshot.java:56)
> Caused by: org.apache.hadoop.service.ServiceStateException:
> java.io.FileNotFoundException: File
> file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing
> does not exist
> at
> org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.setUpBeforeClass(TestSecureExportSnapshot.java:56)
> Caused by: java.io.FileNotFoundException: File
> file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing
> does not exist
> at
> org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.setUpBeforeClass(TestSecureExportSnapshot.java:56)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24167) [Flakey Tests] TestHRegionWithInMemoryFlush#testWritesWhileScanning gets stuck MVCC
[
https://issues.apache.org/jira/browse/HBASE-24167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083219#comment-17083219
]
Hudson commented on HBASE-24167:
Results for branch master
[build #1698 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] TestHRegionWithInMemoryFlush#testWritesWhileScanning gets
> stuck MVCC
> ---
>
> Key: HBASE-24167
> URL: https://issues.apache.org/jira/browse/HBASE-24167
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
> Attachments:
> 0001-HBASE-24167-Flakey-Tests-TestHRegionWithInMemoryFlus.patch
>
>
> I see this in recent nightly fails on branch-2, my experimental branch. It
> happened in the two builds last night. It was only test to fail. Both failed
> with:
> 2020-04-10 07:42:46,700 WARN [Time-limited test]
> regionserver.MultiVersionConcurrencyControl(228): STUCK:
> MultiVersionConcurrencyControl{readPoint=8684, writePoint=8686}
> I ran the test in my harness and it pushes up against heap limits for sure,
> especially after recent cut down in forked jvm size.
> For now, see if alleviating scope of testWritesWhileScanning just when called
> from this test helps w/ flakeyness. Probably worth a deep dive why we get
> into this state w/ in-memory compaction.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24126) Up the container nproc uplimit from 10000 to 12500
[
https://issues.apache.org/jira/browse/HBASE-24126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083223#comment-17083223
]
Hudson commented on HBASE-24126:
Results for branch master
[build #1698 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Up the container nproc uplimit from 1 to 12500
> --
>
> Key: HBASE-24126
> URL: https://issues.apache.org/jira/browse/HBASE-24126
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments:
> 0001-HBASE-24126-Up-the-container-nproc-uplimit-from-1000.patch
>
>
> Let me up the container nproc count from 1. If many tests running in
> parallel, container could breach the 1 limit: i.e. if a bunch of
> heavy-duty long tests run at same time (0.5C on a 16CPU machine means 8
> possible concurrents) and we spin up 1-2000 threads in each test, then could
> hit the 1 limit. Move up the limit some expecially after INFRA just upped
> our limit to 3.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24176) user_permission '.*' command failed to show all table permissions
[
https://issues.apache.org/jira/browse/HBASE-24176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083224#comment-17083224
]
Hudson commented on HBASE-24176:
Results for branch master
[build #1698 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> user_permission '.*' command failed to show all table permissions
> --
>
> Key: HBASE-24176
> URL: https://issues.apache.org/jira/browse/HBASE-24176
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: song XinCun
>Assignee: song XinCun
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
>
> When we grant somebody global permission, then we use '.*' as the argument of
> user_permission to show all table permissions, the following exception
> occurred:
> {code:java}
> hbase(main):001:0> grant 'user3', 'RW'
> Took 0.4144 seconds
>
>
> hbase(main):002:0> user_permission
> User
> Namespace,Table,Family,Qualifier:Permission
>
> user2 ,,,: [Permission:
> actions=READ,WRITE]
>
> user3 ,,,: [Permission:
> actions=READ,WRITE]
>
> hbaseadmin ,,,: [Permission:
> actions=READ,WRITE,EXEC,CREATE,ADMIN]
>
> 3 row(s)
> Took 0.0445 seconds
>
>
> hbase(main):003:0> user_permission '.*'
> User
> Namespace,Table,Family,Qualifier:Permission
>
> user1 default,t1,,: [Permission:
> actions=READ,WRITE]
>
> hbaseadmin default,t1,,: [Permission:
> actions=READ,WRITE,EXEC,CREATE,ADMIN]
> ERROR: failed to coerce
> org.apache.hadoop.hbase.security.access.GlobalPermission to
> org.apache.hadoop.hbase.security.access.TablePermissionFor usage try 'help
> "user_permission"'Took 0.0940 seconds
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] thangTang opened a new pull request #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
thangTang opened a new pull request #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1510 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1487: HBASE-23800 Add documentation about the CECPs changes
Apache-HBase commented on issue #1487: HBASE-23800 Add documentation about the CECPs changes URL: https://github.com/apache/hbase/pull/1487#issuecomment-613429219 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1487 | | Optional Tests | | | uname | Linux 1b7c2ed1049a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | Max. process+thread count | 41 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1487: HBASE-23800 Add documentation about the CECPs changes
Apache-HBase commented on issue #1487: HBASE-23800 Add documentation about the CECPs changes URL: https://github.com/apache/hbase/pull/1487#issuecomment-613428836 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1487 | | Optional Tests | | | uname | Linux aa1a67df58ea 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 92b30f2638 | | Max. process+thread count | 43 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Joseph295 opened a new pull request #1509: HBASE-24182 log when the region is set to closing status
Joseph295 opened a new pull request #1509: HBASE-24182 log when the region is set to closing status URL: https://github.com/apache/hbase/pull/1509 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-24185) Junit tests do not behave well with System.exit or Runtime.halt or JVM exits in general.
Mark Robert Miller created HBASE-24185: -- Summary: Junit tests do not behave well with System.exit or Runtime.halt or JVM exits in general. Key: HBASE-24185 URL: https://issues.apache.org/jira/browse/HBASE-24185 Project: HBase Issue Type: Test Components: test Reporter: Mark Robert Miller This ends up exiting the JVM and confusing / erroring out the test runner that manages that JVM as well as cutting off test output files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1508: HBASE-24151 The master server aborted for IllegalThreadStateException
Apache-HBase commented on issue #1508: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1508#issuecomment-613408101 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 44s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.2 Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 45s | branch-2.2 passed | | +1 :green_heart: | compile | 0m 33s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 0m 20s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 5m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | branch-2.2 passed | | +0 :ok: | spotbugs | 0m 56s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 0m 53s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 22s | the patch passed | | +1 :green_heart: | compile | 0m 36s | the patch passed | | +1 :green_heart: | javac | 0m 36s | the patch passed | | +1 :green_heart: | checkstyle | 0m 17s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 25s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 27m 53s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 19s | the patch passed | | +1 :green_heart: | findbugs | 0m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 6m 35s | hbase-rsgroup in the patch passed. | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 75m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1508/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1508 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b9b1b99bab4f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1508/out/precommit/personality/provided.sh | | git revision | branch-2.2 / 653fb90270 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1508/1/testReport/ | | Max. process+thread count | 4111 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1508/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException
Apache-HBase commented on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1465#issuecomment-613405427 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.2 Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 6s | branch-2.2 passed | | +1 :green_heart: | compile | 0m 31s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 0m 16s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 5m 30s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | branch-2.2 passed | | +0 :ok: | spotbugs | 1m 3s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 1m 0s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 19s | the patch passed | | +1 :green_heart: | compile | 0m 31s | the patch passed | | +1 :green_heart: | javac | 0m 31s | the patch passed | | +1 :green_heart: | checkstyle | 0m 15s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 52s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 25m 35s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | | +1 :green_heart: | findbugs | 0m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 38s | hbase-rsgroup in the patch passed. | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 65m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1465/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1465 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5b3a2bb9af89 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1465/out/precommit/personality/provided.sh | | git revision | branch-2.2 / 653fb90270 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1465/3/testReport/ | | Max. process+thread count | 4207 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1465/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24176) user_permission '.*' command failed to show all table permissions
[
https://issues.apache.org/jira/browse/HBASE-24176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083145#comment-17083145
]
Hudson commented on HBASE-24176:
Results for branch branch-2.3
[build #32 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/32/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/32/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/32/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/32/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/32/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> user_permission '.*' command failed to show all table permissions
> --
>
> Key: HBASE-24176
> URL: https://issues.apache.org/jira/browse/HBASE-24176
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: song XinCun
>Assignee: song XinCun
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
>
> When we grant somebody global permission, then we use '.*' as the argument of
> user_permission to show all table permissions, the following exception
> occurred:
> {code:java}
> hbase(main):001:0> grant 'user3', 'RW'
> Took 0.4144 seconds
>
>
> hbase(main):002:0> user_permission
> User
> Namespace,Table,Family,Qualifier:Permission
>
> user2 ,,,: [Permission:
> actions=READ,WRITE]
>
> user3 ,,,: [Permission:
> actions=READ,WRITE]
>
> hbaseadmin ,,,: [Permission:
> actions=READ,WRITE,EXEC,CREATE,ADMIN]
>
> 3 row(s)
> Took 0.0445 seconds
>
>
> hbase(main):003:0> user_permission '.*'
> User
> Namespace,Table,Family,Qualifier:Permission
>
> user1 default,t1,,: [Permission:
> actions=READ,WRITE]
>
> hbaseadmin default,t1,,: [Permission:
> actions=READ,WRITE,EXEC,CREATE,ADMIN]
> ERROR: failed to coerce
> org.apache.hadoop.hbase.security.access.GlobalPermission to
> org.apache.hadoop.hbase.security.access.TablePermissionFor usage try 'help
> "user_permission"'Took 0.0940 seconds
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-24181) Add region info when log meessages in HRegion.
[ https://issues.apache.org/jira/browse/HBASE-24181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin resolved HBASE-24181. --- Resolution: Fixed > Add region info when log meessages in HRegion. > -- > > Key: HBASE-24181 > URL: https://issues.apache.org/jira/browse/HBASE-24181 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 3.0.0 >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.5 > > > Some log message do not have region info when log, need to add it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24181) Add region info when log meessages in HRegion.
[ https://issues.apache.org/jira/browse/HBASE-24181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin updated HBASE-24181: -- Fix Version/s: 2.2.5 2.3.0 3.0.0 > Add region info when log meessages in HRegion. > -- > > Key: HBASE-24181 > URL: https://issues.apache.org/jira/browse/HBASE-24181 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 3.0.0 >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.5 > > > Some log message do not have region info when log, need to add it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24181) Add region info when log meessages in HRegion.
[ https://issues.apache.org/jira/browse/HBASE-24181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083142#comment-17083142 ] Lijin Bin commented on HBASE-24181: --- Pushed to branch-2.2+ > Add region info when log meessages in HRegion. > -- > > Key: HBASE-24181 > URL: https://issues.apache.org/jira/browse/HBASE-24181 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 3.0.0 >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Minor > > Some log message do not have region info when log, need to add it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] binlijin merged pull request #1506: HBASE-24181 Add region info when log meessages in HRegion.
binlijin merged pull request #1506: HBASE-24181 Add region info when log meessages in HRegion. URL: https://github.com/apache/hbase/pull/1506 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] binlijin commented on issue #1506: HBASE-24181 Add region info when log meessages in HRegion.
binlijin commented on issue #1506: HBASE-24181 Add region info when log meessages in HRegion. URL: https://github.com/apache/hbase/pull/1506#issuecomment-613389662 @HorizonNet @Reidd Thanks for the review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-24177) MetricsTable#updateFlushTime is wrong
[ https://issues.apache.org/jira/browse/HBASE-24177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan reassigned HBASE-24177: -- Assignee: Gaurav Kanade (was: ramkrishna.s.vasudevan) > MetricsTable#updateFlushTime is wrong > - > > Key: HBASE-24177 > URL: https://issues.apache.org/jira/browse/HBASE-24177 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 1.1.2 >Reporter: ramkrishna.s.vasudevan >Assignee: Gaurav Kanade >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.10 > > > MetricsRegionServer does an update on the MetricsRegionServerSource, > MetricsTable etc. > While doing updateFlushTime, the time taken for flush is rightly updated in > the RegionServerSource but at the MetricsTable level we update the > memstoresize instead of the time. > This applies from 1.1 version onwards. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1507: HBASE-24151 The master server aborted for IllegalThreadStateException
Apache-HBase commented on issue #1507: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1507#issuecomment-613382958 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 19s | branch-2.3 passed | | +1 :green_heart: | checkstyle | 0m 14s | branch-2.3 passed | | +1 :green_heart: | spotbugs | 0m 41s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | checkstyle | 0m 10s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 53s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 0m 48s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 30m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1507/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1507 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 3f0ca412b15d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 0444666ca7 | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1507/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1507: HBASE-24151 The master server aborted for IllegalThreadStateException
Apache-HBase commented on issue #1507: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1507#issuecomment-613383022 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 56s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 42s | branch-2.3 passed | | +1 :green_heart: | compile | 0m 27s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | the patch passed | | +1 :green_heart: | compile | 0m 28s | the patch passed | | +1 :green_heart: | javac | 0m 28s | the patch passed | | +1 :green_heart: | shadedjars | 5m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 4m 23s | hbase-rsgroup in the patch passed. | | | | 30m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1507/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1507 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0edcbbde4874 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 0444666ca7 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1507/1/testReport/ | | Max. process+thread count | 2500 (vs. ulimit of 12500) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1507/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1507: HBASE-24151 The master server aborted for IllegalThreadStateException
Apache-HBase commented on issue #1507: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1507#issuecomment-613382225 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 36s | branch-2.3 passed | | +1 :green_heart: | compile | 0m 29s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 6m 9s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 24s | hbase-rsgroup in branch-2.3 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 20s | the patch passed | | +1 :green_heart: | compile | 0m 27s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | +1 :green_heart: | shadedjars | 5m 50s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 22s | hbase-rsgroup in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 4m 4s | hbase-rsgroup in the patch passed. | | | | 29m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1507/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1507 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a7a1e465eb5f 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 0444666ca7 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1507/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rsgroup.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1507/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1507/1/testReport/ | | Max. process+thread count | 2605 (vs. ulimit of 12500) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1507/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException
Apache-HBase commented on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1465#issuecomment-613374459 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.2 Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 12s | branch-2.2 passed | | +1 :green_heart: | compile | 0m 30s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 0m 15s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 5m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | branch-2.2 passed | | +0 :ok: | spotbugs | 1m 5s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 1m 2s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 59s | the patch passed | | +1 :green_heart: | compile | 0m 34s | the patch passed | | +1 :green_heart: | javac | 0m 34s | the patch passed | | -1 :x: | checkstyle | 0m 15s | hbase-rsgroup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 25s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 27m 54s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | | +1 :green_heart: | findbugs | 1m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 58s | hbase-rsgroup in the patch passed. | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 72m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1465/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1465 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1a0a2f28228c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1465/out/precommit/personality/provided.sh | | git revision | branch-2.2 / 653fb90270 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1465/2/artifact/out/diff-checkstyle-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1465/2/testReport/ | | Max. process+thread count | 4245 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1465/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24151) [rsgroup] The master server aborted for IllegalThreadStateException
[
https://issues.apache.org/jira/browse/HBASE-24151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kangkang.guo updated HBASE-24151:
-
Affects Version/s: 2.3.0
> [rsgroup] The master server aborted for IllegalThreadStateException
>
>
> Key: HBASE-24151
> URL: https://issues.apache.org/jira/browse/HBASE-24151
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
>Affects Versions: 2.3.0, 2.1.7, 2.2.3
>Reporter: kangkang.guo
>Assignee: kangkang.guo
>Priority: Minor
>
> if
> 'hbase.master.loadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer'
> and
> 'hbase.rsgroup.grouploadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer',
> The master server will aborted for IllegalThreadStateException.
> {code:java}
> 2020-04-09 11:24:26,142 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster]
> master.HMaster: Failed to become active master
> java.lang.IllegalThreadStateException
> at java.lang.Thread.start(Thread.java:705)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.start(RSGroupInfoManagerImpl.java:172)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:417)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:430)
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:968)
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2275)
> at
> org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:584)
> at java.lang.Thread.run(Thread.java:745)
> 2020-04-09 11:24:26,144 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster]
> master.HMaster: Master server abort: loaded coprocessors are:
> [org.apache.hadoop.hbase.security.access.AccessController,
> org.apache.hadoop.hbase.quotas.MasterQuotasObserver,
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint]{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Gkkkk302 commented on a change in pull request #1465: HBASE-24151 The master server aborted for IllegalThreadStateException
G302 commented on a change in pull request #1465: HBASE-24151 The master
server aborted for IllegalThreadStateException
URL: https://github.com/apache/hbase/pull/1465#discussion_r408048986
##
File path:
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
##
@@ -356,6 +357,10 @@ public void initialize() throws HBaseIOException {
// Create the balancer
Class balancerKlass =
config.getClass(HBASE_RSGROUP_LOADBALANCER_CLASS,
StochasticLoadBalancer.class, LoadBalancer.class);
+if (balancerKlass.equals(this.getClass())) {
+ LOG.warn("The internal balancer of RSGroupBasedLoadBalancer cannot be
itself, falling back to the default LoadBalancer class");
Review comment:
@virajjasani Thanks for review, I resubmitted a PR for branch-2.2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Gkkkk302 opened a new pull request #1508: HBASE-24151 The master server aborted for IllegalThreadStateException
G302 opened a new pull request #1508: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1508 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Gkkkk302 opened a new pull request #1507: HBASE-24151 The master server aborted for IllegalThreadStateException
G302 opened a new pull request #1507: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1507 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-24184) listSnapshots returns empty when just use simple acl but not use authentication
tianhang tang created HBASE-24184: - Summary: listSnapshots returns empty when just use simple acl but not use authentication Key: HBASE-24184 URL: https://issues.apache.org/jira/browse/HBASE-24184 Project: HBase Issue Type: Bug Components: snapshots Reporter: tianhang tang Assignee: tianhang tang For the owner of snapshots(not global admin user), currently list_snapshots returns empty if i just use simple acls for authorization but not use authentication. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Gkkkk302 commented on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException
G302 commented on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1465#issuecomment-613334082 @saintstack Thank you for your comments.This patch should also apply to branch-2.3, I will submit a pr for branch-2.3, the master branch seems to have been repaired. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Gkkkk302 removed a comment on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException
G302 removed a comment on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1465#issuecomment-613332156 Thank you for your comments @saintstack.This patch should also apply to branch-2.3, I will submit a pr for branch-2.3, the master branch seems to have been repaired This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Gkkkk302 edited a comment on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException
G302 edited a comment on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1465#issuecomment-613332156 Thank you for your comments @saintstack.This patch should also apply to branch-2.3, I will submit a pr for branch-2.3, the master branch seems to have been repaired This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Gkkkk302 commented on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException
G302 commented on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1465#issuecomment-613332156 > Is this patch for branch-2.1 and branch-2.2 only @G302 ? What about branch-2.3 and master? Thank you. This patch should also apply to branch-2.3, I will submit a pr for branch-2.3, the master branch seems to have been repaired This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
