[GitHub] [hbase] nyl3532016 commented on a change in pull request #1627: HBASE-24221 Support bulkLoadHFile by family
nyl3532016 commented on a change in pull request #1627: URL: https://github.com/apache/hbase/pull/1627#discussion_r419058405 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/LoadIncrementalHFiles.java ## @@ -141,13 +141,15 @@ public final static String IGNORE_UNMATCHED_CF_CONF_KEY = BulkLoadHFiles.IGNORE_UNMATCHED_CF_CONF_KEY; public final static String ALWAYS_COPY_FILES = BulkLoadHFiles.ALWAYS_COPY_FILES; + public final static String BULK_LOAD_HFILES_BY_FAMILY = BulkLoadHFiles.BULK_LOAD_HFILES_BY_FAMILY; Review comment: yes,I amend it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-21507) Compaction failed when execute AbstractMultiFileWriter.beforeShipped() method
[ https://issues.apache.org/jira/browse/HBASE-21507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-21507: --- Priority: Critical (was: Major) > Compaction failed when execute AbstractMultiFileWriter.beforeShipped() method > - > > Key: HBASE-21507 > URL: https://issues.apache.org/jira/browse/HBASE-21507 > Project: HBase > Issue Type: Bug > Components: Compaction, regionserver >Affects Versions: 2.0.0 >Reporter: lixiaobao >Assignee: lixiaobao >Priority: Critical > Labels: DateTieredCompaction, compaction > Fix For: 3.0.0-alpha-1, 2.2.0, 2.1.2, 2.0.4 > > Attachments: HBASE-21506-v1.patch, hbase-21506.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > 2018-11-23 15:36:20,176 ERROR > [regionserver/ml42:16020-longCompactions-1542957876702] > regionserver.CompactSplit: Compaction failed > region=test_db_zero9,4071\x009223370493980145710\x001,1542958557994.3b1f0283a8d07a2469e5e87f87d827da., > storeName=cf, priority=59, startTime=1542958579969 > java.lang.NullPointerException > at > org.apache.hadoop.hbase.regionserver.AbstractMultiFileWriter.beforeShipped(AbstractMultiFileWriter.java:124) > at > org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:432) > at > org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:327) > at > org.apache.hadoop.hbase.regionserver.compactions.DateTieredCompactor.compact(DateTieredCompactor.java:64) > at > org.apache.hadoop.hbase.regionserver.DateTieredStoreEngine$DateTieredCompactionContext.compact(DateTieredStoreEngine.java:96) > at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1407) > at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2163) > at > org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:592) > at > org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:634) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21507) Compaction failed when execute AbstractMultiFileWriter.beforeShipped() method
[ https://issues.apache.org/jira/browse/HBASE-21507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-21507: --- Labels: DateTieredCompaction compaction (was: compaction) > Compaction failed when execute AbstractMultiFileWriter.beforeShipped() method > - > > Key: HBASE-21507 > URL: https://issues.apache.org/jira/browse/HBASE-21507 > Project: HBase > Issue Type: Bug > Components: Compaction, regionserver >Affects Versions: 2.0.0 >Reporter: lixiaobao >Assignee: lixiaobao >Priority: Major > Labels: DateTieredCompaction, compaction > Fix For: 3.0.0-alpha-1, 2.2.0, 2.1.2, 2.0.4 > > Attachments: HBASE-21506-v1.patch, hbase-21506.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > 2018-11-23 15:36:20,176 ERROR > [regionserver/ml42:16020-longCompactions-1542957876702] > regionserver.CompactSplit: Compaction failed > region=test_db_zero9,4071\x009223370493980145710\x001,1542958557994.3b1f0283a8d07a2469e5e87f87d827da., > storeName=cf, priority=59, startTime=1542958579969 > java.lang.NullPointerException > at > org.apache.hadoop.hbase.regionserver.AbstractMultiFileWriter.beforeShipped(AbstractMultiFileWriter.java:124) > at > org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:432) > at > org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:327) > at > org.apache.hadoop.hbase.regionserver.compactions.DateTieredCompactor.compact(DateTieredCompactor.java:64) > at > org.apache.hadoop.hbase.regionserver.DateTieredStoreEngine$DateTieredCompactionContext.compact(DateTieredStoreEngine.java:96) > at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1407) > at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2163) > at > org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:592) > at > org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:634) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24301) Update Apache POM to version 23
[
https://issues.apache.org/jira/browse/HBASE-24301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098166#comment-17098166
]
Hudson commented on HBASE-24301:
Results for branch branch-2.3
[build #63 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/63/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/63/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/63/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/63/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/63/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update Apache POM to version 23
> ---
>
> Key: HBASE-24301
> URL: https://issues.apache.org/jira/browse/HBASE-24301
> Project: HBase
> Issue Type: Task
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0, 2.4.0, 2.2.5
>
>
> The most recent version of the Apache parent POM is v23. We should update to
> this one. There should not be big changes, except that it updates the
> rat-plugin to the version we already have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1628: HBASE-24304 Separate a hbase-asyncfs module
Apache-HBase commented on pull request #1628: URL: https://github.com/apache/hbase/pull/1628#issuecomment-623039621 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 26s | master passed | | +1 :green_heart: | compile | 2m 14s | master passed | | +1 :green_heart: | shadedjars | 4m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 37s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | compile | 2m 17s | the patch passed | | +1 :green_heart: | javac | 2m 17s | the patch passed | | +1 :green_heart: | shadedjars | 5m 17s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 32s | hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | -0 :warning: | javadoc | 2m 3s | root generated 2 new + 87 unchanged - 0 fixed = 89 total (was 87) | ||| _ Other Tests _ | | -1 :x: | unit | 313m 56s | root in the patch failed. | | | | 349m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1628 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux bdf36aebdf0b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4f9eecbe61 | | Default Java | 1.8.0_232 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/testReport/ | | Max. process+thread count | 5912 (vs. ulimit of 12500) | | modules | C: hbase-asyncfs hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-endpoint hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24280) TestSecureRESTServer started failing in nightlies for Hadoop3
[
https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098156#comment-17098156
]
Sean Busbey commented on HBASE-24280:
-
activeByDefault does not work for almost anything folks want to do with it. We
should not use it in the project at all unless that use comes with a good
explanation for what it is doing. activeByDefault expressly is not good as a
way to set up "default" properties or plugin use.
What I suggested was a formalization of what we already have to do because of
downstream non-maven build tools. It is the maven best practice when you will
have multiple profiles to switch between some mutually exclusive set of options
(as we do with Hadoop major versions). A simplified explanation is that you
have to duplicate outside of the set of profiles whatever it is that is done by
the profile you consider to be the default.
Let me go make an example PR under a ticket that expressly says it is for that
purpose.
> TestSecureRESTServer started failing in nightlies for Hadoop3
> -
>
> Key: HBASE-24280
> URL: https://issues.apache.org/jira/browse/HBASE-24280
> Project: HBase
> Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Istvan Toth
>Priority: Major
> Fix For: 2.3.0
>
> Attachments: HBASE-24280.master.001.patch,
> TEST-org.apache.hadoop.hbase.rest.TestSecureRESTServer.xml
>
>
> [~ndimiduk] pointed out that, after this change went in, TestSecureRESTServer
> started failing with Hadoop3 on branch-2.3
> https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/56/
> Of course, I ran this with 1.8.0_241 and Maven 3.6.33 and it passed :) {{mvn
> clean package -Dtest=TestSecureRESTServer -Dhadoop.profile=3.0
> -DfailIfNoTests=false}}
> FYI [~stoty] in case you can repro a failure and want to dig in. Feel free to
> re-assign.
> It looks like we didn't have a nightly run of branch-2.2 due to docker
> container build issues. Will be interesting to see if it fails there. It did
> not fail the master nightly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1631: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
Apache-HBase commented on pull request #1631: URL: https://github.com/apache/hbase/pull/1631#issuecomment-623036197 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 54s | master passed | | +1 :green_heart: | compile | 1m 14s | master passed | | +1 :green_heart: | shadedjars | 5m 25s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 50s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 39s | the patch passed | | +1 :green_heart: | compile | 1m 12s | the patch passed | | +1 :green_heart: | javac | 1m 12s | the patch passed | | +1 :green_heart: | shadedjars | 5m 25s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 44s | hbase-zookeeper in the patch passed. | | +1 :green_heart: | unit | 189m 30s | hbase-server in the patch passed. | | | | 216m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1631 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5f4d9238af5c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4f9eecbe61 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/testReport/ | | Max. process+thread count | 3235 (vs. ulimit of 12500) | | modules | C: hbase-zookeeper hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24301) Update Apache POM to version 23
[
https://issues.apache.org/jira/browse/HBASE-24301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098146#comment-17098146
]
Hudson commented on HBASE-24301:
Results for branch branch-2
[build #2640 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2640/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2640/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2640/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2640/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2640/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update Apache POM to version 23
> ---
>
> Key: HBASE-24301
> URL: https://issues.apache.org/jira/browse/HBASE-24301
> Project: HBase
> Issue Type: Task
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0, 2.4.0, 2.2.5
>
>
> The most recent version of the Apache parent POM is v23. We should update to
> this one. There should not be big changes, except that it updates the
> rat-plugin to the version we already have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24199) Procedure related metrics is not consumed in the JMX metric
[
https://issues.apache.org/jira/browse/HBASE-24199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098145#comment-17098145
]
Hudson commented on HBASE-24199:
Results for branch branch-2
[build #2640 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2640/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2640/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2640/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2640/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2640/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Procedure related metrics is not consumed in the JMX metric
> ---
>
> Key: HBASE-24199
> URL: https://issues.apache.org/jira/browse/HBASE-24199
> Project: HBase
> Issue Type: Improvement
> Components: metrics
>Reporter: ramkrishna.s.vasudevan
>Assignee: Gaurav Kanade
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.5
>
> Attachments: screenshot_2.png
>
>
> We have ProcedureMetrics and that is being tracked for every procedure that
> we create for all the ops in the system.
> But when we check the UI, the UI does not display those information at all.
> It may be useful to know atleast in the case of ServerCrashProcedure exactly
> to know how much it has taken for the procedure to complete. Similarly other
> procedures also can be added to the UI.
> Currently checked in master code - but think it will apply to other branches
> also.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1631: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
Apache-HBase commented on pull request #1631: URL: https://github.com/apache/hbase/pull/1631#issuecomment-623032703 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 12s | master passed | | +1 :green_heart: | compile | 1m 41s | master passed | | +1 :green_heart: | shadedjars | 6m 39s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | hbase-zookeeper in master failed. | | -0 :warning: | javadoc | 0m 46s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 53s | the patch passed | | +1 :green_heart: | compile | 1m 40s | the patch passed | | +1 :green_heart: | javac | 1m 40s | the patch passed | | +1 :green_heart: | shadedjars | 6m 38s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 19s | hbase-zookeeper in the patch failed. | | -0 :warning: | javadoc | 0m 43s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 47s | hbase-zookeeper in the patch passed. | | -1 :x: | unit | 139m 27s | hbase-server in the patch failed. | | | | 173m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1631 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2572b95b8bab 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4f9eecbe61 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-zookeeper.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-zookeeper.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/testReport/ | | Max. process+thread count | 3971 (vs. ulimit of 12500) | | modules | C: hbase-zookeeper hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24307) [Flakey Tests] krb server for secure thrift tests throws BindException
Michael Stack created HBASE-24307:
-
Summary: [Flakey Tests] krb server for secure thrift tests throws
BindException
Key: HBASE-24307
URL: https://issues.apache.org/jira/browse/HBASE-24307
Project: HBase
Issue Type: Bug
Reporter: Michael Stack
Thought I'd put all the BindExceptions in thrift to sleep but just came across
this one putting up the *krb* server used by the secure thrift http tests.
There are two tests that use krb:
{code}
---
Test set: org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer
---
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.042 s <<<
FAILURE! - in org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer
org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer Time
elapsed: 0.017 s <<< ERROR!
org.apache.kerby.kerberos.kerb.KrbException: Failed to start KDC-Server
at
org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer.setUpBeforeClass(TestThriftSpnegoHttpFallbackServer.java:137)
Caused by: java.net.BindException: Address already in use (Bind failed)
at
org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer.setUpBeforeClass(TestThriftSpnegoHttpFallbackServer.java:137)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1628: HBASE-24304 Separate a hbase-asyncfs module
Apache-HBase commented on pull request #1628: URL: https://github.com/apache/hbase/pull/1628#issuecomment-623028041 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 9s | master passed | | +1 :green_heart: | compile | 2m 46s | master passed | | +1 :green_heart: | shadedjars | 5m 22s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 43s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 56s | hbase-thrift in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 16s | hbase-examples in master failed. | | -0 :warning: | javadoc | 0m 18s | root in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 3s | the patch passed | | +1 :green_heart: | compile | 2m 46s | the patch passed | | +1 :green_heart: | javac | 2m 46s | the patch passed | | +1 :green_heart: | shadedjars | 5m 31s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-asyncfs in the patch failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 22s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 59s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 21s | hbase-rest in the patch failed. | | -0 :warning: | javadoc | 0m 19s | hbase-examples in the patch failed. | | -0 :warning: | javadoc | 0m 20s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 176m 28s | root in the patch passed. | | | | 213m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1628 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e4aeeec85f71 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4f9eecbe61 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-P
[GitHub] [hbase] Apache-HBase commented on pull request #1631: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
Apache-HBase commented on pull request #1631: URL: https://github.com/apache/hbase/pull/1631#issuecomment-623022011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 52s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 57s | master passed | | +1 :green_heart: | checkstyle | 1m 24s | master passed | | +1 :green_heart: | spotbugs | 2m 43s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 41s | the patch passed | | +1 :green_heart: | checkstyle | 1m 29s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 39s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 27s | The patch does not generate ASF License warnings. | | | | 49m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1631 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux ec68adfa0214 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4f9eecbe61 | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-zookeeper hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1631/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24211) Create table is slow in large cluster when AccessController is enabled.
[
https://issues.apache.org/jira/browse/HBASE-24211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098109#comment-17098109
]
Mohammad Arshad commented on HBASE-24211:
-
The test case was failing because functionality was wrong.
In ZKUtil#getDataInternal method on thread interrupt we always abort the
server. But when this method is called through
ZKPermissionWatcher#nodeChildrenChanged we should not abort server as we
interrupted the thread to stop the processing. This interrupt is intentional.
Handled this scenario in latest PR https://github.com/apache/hbase/pull/1631
> Create table is slow in large cluster when AccessController is enabled.
> ---
>
> Key: HBASE-24211
> URL: https://issues.apache.org/jira/browse/HBASE-24211
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.6, master, 2.2.4
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0
>
>
> *Problem:*
> In HBase 1.3.x large, performance test, cluster (100 RS, 60k tables, 600k
> regions) a simple table creation takes around 150 seconds. The time taken
> varies but still takes lot of time.
> *Analysis:*
> 1. When HBase creates a table , it calls AssignmentManager#assign(final
> ServerName destination, final List regions)
> In AssignmentManager#assign，it calls asyncSetOfflineInZooKeeper(state, cb,
> destination), and waits in below code loop for 2 minutes.
> {code:java}
> if (useZKForAssignment) {
> // Wait until all unassigned nodes have been put up and watchers
> set.
> int total = states.size();
> for (int oldCounter = 0; !server.isStopped();) {
> int count = counter.get();
> if (oldCounter != count) {
> LOG.debug(destination.toString() + " unassigned znodes=" +
> count +
> " of total=" + total + "; oldCounter=" + oldCounter);
> oldCounter = count;
> }
> if (count >= total) break;
> Thread.sleep(5);
> }
> }
> {code}
> 2. asyncSetOfflineInZooKeeper creates a znode under
> /hbase/region-in-transition/ and calls exist to ensure that znode is created.
> This is simple operation should not take much time. Then where the time it
> taken!!!
> 3. ZooKeeper client API process watcher notification and async API response
> through a queue one by one.
> If there is a delay in any watcher/response processing by the client, in
> this case HBase, all other response processing is delayed. Then it appears as
> if API call has taken more time.
> Same thing happen in this issue.
> Watcher processing for znode creation under /hbase/acl took most of the time
> and delayed /hbase/region-in-transition/region znode creation processing.
> This is why wait in loop was too long.
> 4. Watcher processing for znode creation under hbase/acl/ calls
> ZKPermissionWatcher#nodeChildrenChanged, which internally calls
> ZKUtil.getChildDataAndWatchForNewChildren
> *which calls ZooKeeper's getData API, in this use case, 60k times which
> takes most of the time.*
> *Solutions:*
> Move getChildDataAndWatchForNewChildren call into the async code block in
> ZKPermissionWatcher#nodeChildrenChanged.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] arshadmohammad commented on pull request #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
arshadmohammad commented on pull request #1546: URL: https://github.com/apache/hbase/pull/1546#issuecomment-623013812 This PR changes were reverted back. Created new PR https://github.com/apache/hbase/pull/1631 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] arshadmohammad opened a new pull request #1631: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
arshadmohammad opened a new pull request #1631: URL: https://github.com/apache/hbase/pull/1631 HBASE-24211: Create table is slow in large cluster when AccessController is enabled. Previous PR for this issue is https://github.com/apache/hbase/pull/1546. Changes were merged and reverted back. Submitting few more changes on top of the previous changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1628: HBASE-24304 Separate a hbase-asyncfs module
Apache-HBase commented on pull request #1628: URL: https://github.com/apache/hbase/pull/1628#issuecomment-623011946 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 39s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 53s | master passed | | +1 :green_heart: | checkstyle | 2m 24s | master passed | | +1 :green_heart: | spotbugs | 15m 18s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 41s | the patch passed | | +1 :green_heart: | checkstyle | 2m 23s | root: The patch generated 0 new + 293 unchanged - 2 fixed = 293 total (was 295) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 14s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 12m 13s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 17m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 44s | The patch does not generate ASF License warnings. | | | | 70m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1628 | | Optional Tests | dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle | | uname | Linux eb8ea03858a8 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4f9eecbe61 | | Max. process+thread count | 122 (vs. ulimit of 12500) | | modules | C: hbase-asyncfs . hbase-endpoint hbase-examples hbase-mapreduce hbase-rest hbase-server hbase-shaded/hbase-shaded-testing-util hbase-testing-util hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1630: HBASE-24303 Undo core of parent TestSecureRESTServer change; use fix …
Apache-HBase commented on pull request #1630: URL: https://github.com/apache/hbase/pull/1630#issuecomment-623007087 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 3s | branch-2 passed | | +1 :green_heart: | compile | 0m 35s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 4s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-rest in branch-2 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 37s | the patch passed | | +1 :green_heart: | compile | 0m 30s | the patch passed | | +1 :green_heart: | javac | 0m 30s | the patch passed | | +1 :green_heart: | shadedjars | 6m 33s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 24s | hbase-rest in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 3m 6s | hbase-rest in the patch failed. | | | | 30m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1630/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1630 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ea4253cf4f1e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 13c4030cfc | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1630/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1630/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1630/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rest.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1630/1/testReport/ | | Max. process+thread count | 1676 (vs. ulimit of 12500) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1630/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1630: HBASE-24303 Undo core of parent TestSecureRESTServer change; use fix …
Apache-HBase commented on pull request #1630: URL: https://github.com/apache/hbase/pull/1630#issuecomment-623006725 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 17s | branch-2 passed | | +1 :green_heart: | compile | 0m 27s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 7s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 50s | the patch passed | | +1 :green_heart: | compile | 0m 27s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | +1 :green_heart: | shadedjars | 5m 3s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 4m 10s | hbase-rest in the patch passed. | | | | 27m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1630/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1630 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d5d631654162 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 13c4030cfc | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1630/1/testReport/ | | Max. process+thread count | 1948 (vs. ulimit of 12500) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1630/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1630: HBASE-24303 Undo core of parent TestSecureRESTServer change; use fix …
Apache-HBase commented on pull request #1630: URL: https://github.com/apache/hbase/pull/1630#issuecomment-623006183 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 12m 51s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 21m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1630/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1630 | | Optional Tests | dupname asflicense hadoopcheck xml | | uname | Linux 3db9aab7e044 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 13c4030cfc | | Max. process+thread count | 63 (vs. ulimit of 12500) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1630/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24300) TestRemoteBackup is broken
[ https://issues.apache.org/jira/browse/HBASE-24300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098083#comment-17098083 ] Michael Stack commented on HBASE-24300: --- Punt the backup feature? It has been abandoned as best as I can tell. > TestRemoteBackup is broken > -- > > Key: HBASE-24300 > URL: https://issues.apache.org/jira/browse/HBASE-24300 > Project: HBase > Issue Type: Bug > Components: backup&restore >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1 > > > It seems that the bulk load rpc request is timed out after 1 minute and fails > the test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1628: HBASE-24304 Separate a hbase-asyncfs module
Apache-HBase commented on pull request #1628: URL: https://github.com/apache/hbase/pull/1628#issuecomment-623003867 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 34s | master passed | | +1 :green_heart: | compile | 2m 26s | master passed | | +1 :green_heart: | shadedjars | 5m 27s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 30s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 42s | the patch passed | | +1 :green_heart: | compile | 2m 28s | the patch passed | | +1 :green_heart: | javac | 2m 28s | the patch passed | | +1 :green_heart: | shadedjars | 5m 36s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 34s | hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | -0 :warning: | javadoc | 2m 2s | root generated 2 new + 87 unchanged - 0 fixed = 89 total (was 87) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 353m 49s | root in the patch passed. | | | | 391m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1628 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b96d6f6c80cd 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4f9eecbe61 | | Default Java | 1.8.0_232 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/testReport/ | | Max. process+thread count | 4690 (vs. ulimit of 12500) | | modules | C: hbase-asyncfs hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-endpoint hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack opened a new pull request #1630: HBASE-24303 Undo core of parent TestSecureRESTServer change; use fix …
saintstack opened a new pull request #1630: URL: https://github.com/apache/hbase/pull/1630 …over in HBASE-24280 instead This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24199) Procedure related metrics is not consumed in the JMX metric
[ https://issues.apache.org/jira/browse/HBASE-24199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098078#comment-17098078 ] Michael Stack commented on HBASE-24199: --- Had to push addendum on branch-2.2, 2.3, and 2 because test answer different from master branch. > Procedure related metrics is not consumed in the JMX metric > --- > > Key: HBASE-24199 > URL: https://issues.apache.org/jira/browse/HBASE-24199 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: ramkrishna.s.vasudevan >Assignee: Gaurav Kanade >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.5 > > Attachments: screenshot_2.png > > > We have ProcedureMetrics and that is being tracked for every procedure that > we create for all the ops in the system. > But when we check the UI, the UI does not display those information at all. > It may be useful to know atleast in the case of ServerCrashProcedure exactly > to know how much it has taken for the procedure to complete. Similarly other > procedures also can be added to the UI. > Currently checked in master code - but think it will apply to other branches > also. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] wchevreuil commented on a change in pull request #1627: HBASE-24221 Support bulkLoadHFile by family
wchevreuil commented on a change in pull request #1627:
URL: https://github.com/apache/hbase/pull/1627#discussion_r418984035
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestLoadIncrementalHFiles.java
##
@@ -101,6 +101,7 @@ public static void setUpBeforeClass() throws Exception {
// change default behavior so that tag values are returned with normal rpcs
util.getConfiguration().set(HConstants.RPC_CODEC_CONF_KEY,
KeyValueCodecWithTags.class.getCanonicalName());
+
util.getConfiguration().setBoolean(BulkLoadHFiles.BULK_LOAD_HFILES_BY_FAMILY,
false);
Review comment:
Is this really needed? Isn't BULK_LOAD_HFILES_BY_FAMILY loaded as false
by default if not set on LoadIncrementalHFiles#195? Or perhaps you can move
this for a separate method that could be overridden by
TestLoadIncrementalHFilesByFamily to avoid duplicating whole setUpBeforeClass
in the child class?
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/LoadIncrementalHFiles.java
##
@@ -141,13 +141,15 @@
public final static String IGNORE_UNMATCHED_CF_CONF_KEY =
BulkLoadHFiles.IGNORE_UNMATCHED_CF_CONF_KEY;
public final static String ALWAYS_COPY_FILES =
BulkLoadHFiles.ALWAYS_COPY_FILES;
+ public final static String BULK_LOAD_HFILES_BY_FAMILY =
BulkLoadHFiles.BULK_LOAD_HFILES_BY_FAMILY;
Review comment:
nit: why not make BulkLoadHFiles.BULK_LOAD_HFILES_BY_FAMILY public, then
remove this variable here?
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestLoadIncrementalHFilesByFamily.java
##
@@ -0,0 +1,42 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to you under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.hadoop.hbase.tool;
+
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.codec.KeyValueCodecWithTags;
+import org.apache.hadoop.hbase.coprocessor.CoprocessorHost;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+
+public class TestLoadIncrementalHFilesByFamily extends
TestLoadIncrementalHFiles {
Review comment:
Does this test class actually make sense, without testing the specific
new logic added? I mean, even without the group by family feature this test
class will pass, so it's not shielding us from inadvertently changes on the new
feature.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24199) Procedure related metrics is not consumed in the JMX metric
[
https://issues.apache.org/jira/browse/HBASE-24199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098069#comment-17098069
]
Hudson commented on HBASE-24199:
Results for branch branch-2.2
[build #852 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/852/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/852//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/852//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/852//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Procedure related metrics is not consumed in the JMX metric
> ---
>
> Key: HBASE-24199
> URL: https://issues.apache.org/jira/browse/HBASE-24199
> Project: HBase
> Issue Type: Improvement
> Components: metrics
>Reporter: ramkrishna.s.vasudevan
>Assignee: Gaurav Kanade
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.5
>
> Attachments: screenshot_2.png
>
>
> We have ProcedureMetrics and that is being tracked for every procedure that
> we create for all the ops in the system.
> But when we check the UI, the UI does not display those information at all.
> It may be useful to know atleast in the case of ServerCrashProcedure exactly
> to know how much it has taken for the procedure to complete. Similarly other
> procedures also can be added to the UI.
> Currently checked in master code - but think it will apply to other branches
> also.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24288) Allow admin user to create table and do bulkLoad
[
https://issues.apache.org/jira/browse/HBASE-24288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098070#comment-17098070
]
Hudson commented on HBASE-24288:
Results for branch branch-2.2
[build #852 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/852/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/852//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/852//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/852//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Allow admin user to create table and do bulkLoad
>
>
> Key: HBASE-24288
> URL: https://issues.apache.org/jira/browse/HBASE-24288
> Project: HBase
> Issue Type: Bug
> Components: acl
>Affects Versions: 2.2.2
>Reporter: song XinCun
>Assignee: song XinCun
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.5
>
>
> Allow admin users who don't have CREATE privileges to create tables and do
> bulkload.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24301) Update Apache POM to version 23
[
https://issues.apache.org/jira/browse/HBASE-24301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098071#comment-17098071
]
Hudson commented on HBASE-24301:
Results for branch branch-2.2
[build #852 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/852/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/852//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/852//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/852//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update Apache POM to version 23
> ---
>
> Key: HBASE-24301
> URL: https://issues.apache.org/jira/browse/HBASE-24301
> Project: HBase
> Issue Type: Task
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0, 2.4.0, 2.2.5
>
>
> The most recent version of the Apache parent POM is v23. We should update to
> this one. There should not be big changes, except that it updates the
> rat-plugin to the version we already have.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1629: HBASE-24250 CatalogJanitor resubmits GCMultipleMergedRegionsProcedure…
Apache-HBase commented on pull request #1629: URL: https://github.com/apache/hbase/pull/1629#issuecomment-622993688 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 58s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 5m 26s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 43s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 5m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 190m 57s | hbase-server in the patch failed. | | | | 215m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1629/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1629 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7d8839f5b6df 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4f9eecbe61 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1629/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1629/1/testReport/ | | Max. process+thread count | 3277 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1629/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1629: HBASE-24250 CatalogJanitor resubmits GCMultipleMergedRegionsProcedure…
Apache-HBase commented on pull request #1629: URL: https://github.com/apache/hbase/pull/1629#issuecomment-622987844 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 41s | master passed | | +1 :green_heart: | compile | 1m 27s | master passed | | +1 :green_heart: | shadedjars | 7m 13s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 54s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 22s | the patch passed | | +1 :green_heart: | compile | 1m 25s | the patch passed | | +1 :green_heart: | javac | 1m 25s | the patch passed | | +1 :green_heart: | shadedjars | 7m 9s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 52s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 137m 26s | hbase-server in the patch failed. | | | | 170m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1629/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1629 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1ad8d168287e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4f9eecbe61 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1629/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1629/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1629/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1629/1/testReport/ | | Max. process+thread count | 4495 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1629/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24286) HMaster won't become healthy after after cloning or creating a new cluster pointing at the same file system
[
https://issues.apache.org/jira/browse/HBASE-24286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098028#comment-17098028
]
Anoop Sam John commented on HBASE-24286:
On the new cluster the regions will get online by doing crash recovery of RSs
in the old cluster. In 2.x this depends on either the availability of the WAL
dir of the RS in the old cluster or the SCP entry already got added into the
MasterProcWAL file of the old cluster. Said that we need the old cluster's WAL
dir also. If u can backup the old cluster's WAL directory also and restore
into the new cluster and then start the HBase, all will be ok. I believe the
WAL dir is backed by HDFS.
> HMaster won't become healthy after after cloning or creating a new cluster
> pointing at the same file system
> ---
>
> Key: HBASE-24286
> URL: https://issues.apache.org/jira/browse/HBASE-24286
> Project: HBase
> Issue Type: Bug
> Components: master, Region Assignment
>Affects Versions: 2.2.3
>Reporter: Jack Ye
>Priority: Major
>
> h1. How to reproduce:
> # user starts an HBase cluster on top of a file system
> # user performs some operations and shuts down the cluster, all the data are
> still persisted in the file system
> # user creates a new HBase cluster using a different set of servers on top
> of the same file system with the same root directory
> # HMaster cannot initialize
> h1. Root cause:
> During HMaster initialization phase, the following happens:
> # HMaster waits for namespace table online
> # AssignmentManager gets all namespace table regions info
> # region servers of namespace table are already dead, online check fails
> # HMaster waits for namespace regions online, keep retrying for 1000 times
> which means forever
> Code waiting for namespace table to be online:
> https://github.com/apache/hbase/blob/rel/2.2.3/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1102
> h1. Stack trace (running on S3):
> 2020-04-23 08:15:57,185 WARN [master/ip-10-12-13-14:16000:becomeActiveMaster]
> master.HMaster:
> hbase:namespace,,1587628169070.d34b65b91a52644ed3e77c5fbb065c2b. is NOT
> online; state=\{d34b65b91a52644ed3e77c5fbb065c2b state=OPEN,
> ts=1587629742129, server=ip-10-12-13-14.ec2.internal,16020,1587628031614};
> ServerCrashProcedures=false. Master startup cannot progress, in
> holding-pattern until region onlined.
> where ip-10-12-13-14.ec2.internal is the old region server hosting the region
> of hbase:namespace.
> h1. Discussion for the fix
> We see there is a fix for this at branch-3:
> https://issues.apache.org/jira/browse/HBASE-21154. Before we provide a patch,
> we would like to know from the community if we should backport this change to
> branch-2, or if we should just perform a fix with minimum code change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1628: HBASE-24304 Separate a hbase-asyncfs module
Apache-HBase commented on pull request #1628: URL: https://github.com/apache/hbase/pull/1628#issuecomment-622980717 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 48s | master passed | | +1 :green_heart: | compile | 2m 37s | master passed | | +1 :green_heart: | shadedjars | 5m 7s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 38s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 18s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 49s | hbase-thrift in master failed. | | -0 :warning: | javadoc | 0m 19s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 17s | hbase-examples in master failed. | | -0 :warning: | javadoc | 0m 17s | root in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 54s | the patch passed | | +1 :green_heart: | compile | 2m 41s | the patch passed | | +1 :green_heart: | javac | 2m 41s | the patch passed | | +1 :green_heart: | shadedjars | 5m 20s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-asyncfs in the patch failed. | | -0 :warning: | javadoc | 0m 38s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 19s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 49s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 18s | hbase-rest in the patch failed. | | -0 :warning: | javadoc | 0m 17s | hbase-examples in the patch failed. | | -0 :warning: | javadoc | 0m 17s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 172m 46s | root in the patch passed. | | | | 207m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1628 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 792d52ec97bf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4f9eecbe61 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-P
[GitHub] [hbase] Apache-HBase commented on pull request #1629: HBASE-24250 CatalogJanitor resubmits GCMultipleMergedRegionsProcedure…
Apache-HBase commented on pull request #1629: URL: https://github.com/apache/hbase/pull/1629#issuecomment-622968754 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 43s | master passed | | +1 :green_heart: | checkstyle | 1m 8s | master passed | | +1 :green_heart: | spotbugs | 2m 1s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | +1 :green_heart: | checkstyle | 1m 5s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 16s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 32m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1629/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1629 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 124d8ed191ce 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4f9eecbe61 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1629/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-24250) CatalogJanitor resubmits GCMultipleMergedRegionsProcedure for the same region
[ https://issues.apache.org/jira/browse/HBASE-24250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097802#comment-17097802 ] niuyulin edited comment on HBASE-24250 at 5/2/20, 2:36 PM: --- [~huaxiangsun] Maybe you forget add the Procedures Last round generate into ongoingMergeProcedures? you cannot sure it finish in last round. it can work, but when GCMultipleMergedRegionsProcedure finish or failed exit, you must clean the Procedure in ongoingMergeProcedures was (Author: niuyulin): [~huaxiangsun] Maybe you forget add the Procedures Last round generate into ongoingMergeProcedures, you cannot sure it finish in last round. it can work, but when GCMultipleMergedRegionsProcedure finish or failed exit, you must clean the Procedure in ongoingMergeProcedures > CatalogJanitor resubmits GCMultipleMergedRegionsProcedure for the same region > - > > Key: HBASE-24250 > URL: https://issues.apache.org/jira/browse/HBASE-24250 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 2.2.4 > Environment: hdfs 3.1.3 with erasure coding > hbase 2.2.4 >Reporter: Andrey Elenskiy >Assignee: niuyulin >Priority: Major > > If a lot of regions were merged (due to change of region sizes, for example), > there can be a long backlog of procedures to clean up the merged regions. If > going through this backlog is slower than the CatalogJanitor's scan interval, > it will end resubmitting GCMultipleMergedRegionsProcedure for the same > regions over and over again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24250) CatalogJanitor resubmits GCMultipleMergedRegionsProcedure for the same region
[ https://issues.apache.org/jira/browse/HBASE-24250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097990#comment-17097990 ] niuyulin commented on HBASE-24250: -- [~huaxiangsun] , I submit PR [https://github.com/apache/hbase/pull/1629] I do it in a simple way, could you help review it > CatalogJanitor resubmits GCMultipleMergedRegionsProcedure for the same region > - > > Key: HBASE-24250 > URL: https://issues.apache.org/jira/browse/HBASE-24250 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 2.2.4 > Environment: hdfs 3.1.3 with erasure coding > hbase 2.2.4 >Reporter: Andrey Elenskiy >Assignee: niuyulin >Priority: Major > > If a lot of regions were merged (due to change of region sizes, for example), > there can be a long backlog of procedures to clean up the merged regions. If > going through this backlog is slower than the CatalogJanitor's scan interval, > it will end resubmitting GCMultipleMergedRegionsProcedure for the same > regions over and over again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-24250) CatalogJanitor resubmits GCMultipleMergedRegionsProcedure for the same region
[ https://issues.apache.org/jira/browse/HBASE-24250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097802#comment-17097802 ] niuyulin edited comment on HBASE-24250 at 5/2/20, 2:35 PM: --- [~huaxiangsun] Maybe you forget add the Procedures Last round generate into ongoingMergeProcedures, you cannot sure it finish in last round. it can work, but when GCMultipleMergedRegionsProcedure finish or failed exit, you must clean the Procedure in ongoingMergeProcedures was (Author: niuyulin): [~huaxiangsun] Maybe you forget add the Procedures Last round generate into ongoingMergeProcedures, you cannot sure it finish in last round. I can work, but when GCMultipleMergedRegionsProcedure finish or failed exit, you must clean the Procedure in ongoingMergeProcedures > CatalogJanitor resubmits GCMultipleMergedRegionsProcedure for the same region > - > > Key: HBASE-24250 > URL: https://issues.apache.org/jira/browse/HBASE-24250 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 2.2.4 > Environment: hdfs 3.1.3 with erasure coding > hbase 2.2.4 >Reporter: Andrey Elenskiy >Assignee: niuyulin >Priority: Major > > If a lot of regions were merged (due to change of region sizes, for example), > there can be a long backlog of procedures to clean up the merged regions. If > going through this backlog is slower than the CatalogJanitor's scan interval, > it will end resubmitting GCMultipleMergedRegionsProcedure for the same > regions over and over again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] nyl3532016 opened a new pull request #1629: HBASE-24250 CatalogJanitor resubmits GCMultipleMergedRegionsProcedure…
nyl3532016 opened a new pull request #1629: URL: https://github.com/apache/hbase/pull/1629 … for the same region This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1628: HBASE-24304 Separate a hbase-asyncfs module
Apache-HBase commented on pull request #1628: URL: https://github.com/apache/hbase/pull/1628#issuecomment-622960751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 38s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 49s | master passed | | +1 :green_heart: | checkstyle | 2m 20s | master passed | | +1 :green_heart: | spotbugs | 15m 24s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 41s | the patch passed | | -0 :warning: | checkstyle | 2m 20s | root: The patch generated 6 new + 292 unchanged - 3 fixed = 298 total (was 295) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 14s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 12m 4s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 17m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 42s | The patch does not generate ASF License warnings. | | | | 69m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1628 | | Optional Tests | dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle | | uname | Linux 4ab6c69a3983 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4f9eecbe61 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | Max. process+thread count | 122 (vs. ulimit of 12500) | | modules | C: hbase-asyncfs . hbase-endpoint hbase-examples hbase-mapreduce hbase-rest hbase-server hbase-shaded/hbase-shaded-testing-util hbase-testing-util hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-19577) Move off log4j1 as our logging backend.
[ https://issues.apache.org/jira/browse/HBASE-19577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097982#comment-17097982 ] Duo Zhang commented on HBASE-19577: --- Let me have a try. > Move off log4j1 as our logging backend. > --- > > Key: HBASE-19577 > URL: https://issues.apache.org/jira/browse/HBASE-19577 > Project: HBase > Issue Type: Sub-task > Components: logging >Reporter: Michael Stack >Assignee: Duo Zhang >Priority: Major > > See HBASE-10092 for discussion. We have inserted slf4j as our frontend. Need > to swap out the 5-year-old log4j1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-19577) Move off log4j1 as our logging backend.
[ https://issues.apache.org/jira/browse/HBASE-19577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-19577 started by Duo Zhang. - > Move off log4j1 as our logging backend. > --- > > Key: HBASE-19577 > URL: https://issues.apache.org/jira/browse/HBASE-19577 > Project: HBase > Issue Type: Sub-task > Components: logging >Reporter: Michael Stack >Assignee: Duo Zhang >Priority: Major > > See HBASE-10092 for discussion. We have inserted slf4j as our frontend. Need > to swap out the 5-year-old log4j1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-19577) Move off log4j1 as our logging backend.
[ https://issues.apache.org/jira/browse/HBASE-19577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-19577: - Assignee: Duo Zhang > Move off log4j1 as our logging backend. > --- > > Key: HBASE-19577 > URL: https://issues.apache.org/jira/browse/HBASE-19577 > Project: HBase > Issue Type: Sub-task > Components: logging >Reporter: Michael Stack >Assignee: Duo Zhang >Priority: Major > > See HBASE-10092 for discussion. We have inserted slf4j as our frontend. Need > to swap out the 5-year-old log4j1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24277) TestZooKeeper is flaky
[ https://issues.apache.org/jira/browse/HBASE-24277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24277. --- Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed The flaky dashboard is good. Resolve. > TestZooKeeper is flaky > -- > > Key: HBASE-24277 > URL: https://issues.apache.org/jira/browse/HBASE-24277 > Project: HBase > Issue Type: Bug > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1 > > > After checking the code, the problem is that, when creating table during > master shutdown, it is easy to hit MasterStoppedException or other strange > exceptions which make the creation fail. > In general I think this should be a test issue, need to learn why we do not > have the problem on branch-2.x. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on pull request #1628: HBASE-24304 Separate a hbase-asyncfs module
Apache9 commented on pull request #1628: URL: https://github.com/apache/hbase/pull/1628#issuecomment-622959580 The javadoc issues are not introduced by this patch, and if we change the link target to shaded protobuf, there will be a new checkstyle warning for line length, so keep it as is... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24288) Allow admin user to create table and do bulkLoad
[
https://issues.apache.org/jira/browse/HBASE-24288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097976#comment-17097976
]
Hudson commented on HBASE-24288:
Results for branch branch-2.3
[build #62 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Allow admin user to create table and do bulkLoad
>
>
> Key: HBASE-24288
> URL: https://issues.apache.org/jira/browse/HBASE-24288
> Project: HBase
> Issue Type: Bug
> Components: acl
>Affects Versions: 2.2.2
>Reporter: song XinCun
>Assignee: song XinCun
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.5
>
>
> Allow admin users who don't have CREATE privileges to create tables and do
> bulkload.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24199) Procedure related metrics is not consumed in the JMX metric
[
https://issues.apache.org/jira/browse/HBASE-24199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097975#comment-17097975
]
Hudson commented on HBASE-24199:
Results for branch branch-2.3
[build #62 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Procedure related metrics is not consumed in the JMX metric
> ---
>
> Key: HBASE-24199
> URL: https://issues.apache.org/jira/browse/HBASE-24199
> Project: HBase
> Issue Type: Improvement
> Components: metrics
>Reporter: ramkrishna.s.vasudevan
>Assignee: Gaurav Kanade
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.5
>
> Attachments: screenshot_2.png
>
>
> We have ProcedureMetrics and that is being tracked for every procedure that
> we create for all the ops in the system.
> But when we check the UI, the UI does not display those information at all.
> It may be useful to know atleast in the case of ServerCrashProcedure exactly
> to know how much it has taken for the procedure to complete. Similarly other
> procedures also can be added to the UI.
> Currently checked in master code - but think it will apply to other branches
> also.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24294) [Flakey Tests] TestThriftHttpServer BindException
[
https://issues.apache.org/jira/browse/HBASE-24294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097974#comment-17097974
]
Hudson commented on HBASE-24294:
Results for branch branch-2.3
[build #62 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/62/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] TestThriftHttpServer BindException
> -
>
> Key: HBASE-24294
> URL: https://issues.apache.org/jira/browse/HBASE-24294
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Came across this last night:
> {code}
> Expected: (an instance of org.apache.thrift.transport.TTransportException and
> exception with message a string containing "HTTP Response code: 431")
> but: an instance of org.apache.thrift.transport.TTransportException
> is a
> java.lang.Exception
> Stacktrace was: java.lang.Exception: java.net.BindException: Address already
> in use
> at
> org.apache.hadoop.hbase.thrift.TestThriftHttpServer.stopHttpServerThread(TestThriftHttpServer.java:253)
> at
> org.apache.hadoop.hbase.thrift.TestThriftHttpServer.runThriftServer(TestThriftHttpServer.java:183)
> at
> org.apache.hadoop.hbase.thrift.TestThriftHttpServer.testRunThriftServerWithHeaderBufferLength(TestThriftHttpServer.java:147)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24199) Procedure related metrics is not consumed in the JMX metric
[
https://issues.apache.org/jira/browse/HBASE-24199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097967#comment-17097967
]
Hudson commented on HBASE-24199:
Results for branch master
[build #1715 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1475//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Procedure related metrics is not consumed in the JMX metric
> ---
>
> Key: HBASE-24199
> URL: https://issues.apache.org/jira/browse/HBASE-24199
> Project: HBase
> Issue Type: Improvement
> Components: metrics
>Reporter: ramkrishna.s.vasudevan
>Assignee: Gaurav Kanade
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.5
>
> Attachments: screenshot_2.png
>
>
> We have ProcedureMetrics and that is being tracked for every procedure that
> we create for all the ops in the system.
> But when we check the UI, the UI does not display those information at all.
> It may be useful to know atleast in the case of ServerCrashProcedure exactly
> to know how much it has taken for the procedure to complete. Similarly other
> procedures also can be added to the UI.
> Currently checked in master code - but think it will apply to other branches
> also.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24277) TestZooKeeper is flaky
[
https://issues.apache.org/jira/browse/HBASE-24277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097965#comment-17097965
]
Hudson commented on HBASE-24277:
Results for branch master
[build #1715 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1475//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestZooKeeper is flaky
> --
>
> Key: HBASE-24277
> URL: https://issues.apache.org/jira/browse/HBASE-24277
> Project: HBase
> Issue Type: Bug
> Components: test, Zookeeper
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> After checking the code, the problem is that, when creating table during
> master shutdown, it is easy to hit MasterStoppedException or other strange
> exceptions which make the creation fail.
> In general I think this should be a test issue, need to learn why we do not
> have the problem on branch-2.x.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24300) TestRemoteBackup is broken
[
https://issues.apache.org/jira/browse/HBASE-24300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097970#comment-17097970
]
Hudson commented on HBASE-24300:
Results for branch master
[build #1715 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1475//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestRemoteBackup is broken
> --
>
> Key: HBASE-24300
> URL: https://issues.apache.org/jira/browse/HBASE-24300
> Project: HBase
> Issue Type: Bug
> Components: backup&restore
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
>
> It seems that the bulk load rpc request is timed out after 1 minute and fails
> the test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24288) Allow admin user to create table and do bulkLoad
[
https://issues.apache.org/jira/browse/HBASE-24288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097968#comment-17097968
]
Hudson commented on HBASE-24288:
Results for branch master
[build #1715 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1475//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Allow admin user to create table and do bulkLoad
>
>
> Key: HBASE-24288
> URL: https://issues.apache.org/jira/browse/HBASE-24288
> Project: HBase
> Issue Type: Bug
> Components: acl
>Affects Versions: 2.2.2
>Reporter: song XinCun
>Assignee: song XinCun
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.5
>
>
> Allow admin users who don't have CREATE privileges to create tables and do
> bulkload.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24280) TestSecureRESTServer started failing in nightlies for Hadoop3
[
https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097969#comment-17097969
]
Hudson commented on HBASE-24280:
Results for branch master
[build #1715 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1475//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestSecureRESTServer started failing in nightlies for Hadoop3
> -
>
> Key: HBASE-24280
> URL: https://issues.apache.org/jira/browse/HBASE-24280
> Project: HBase
> Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Istvan Toth
>Priority: Major
> Fix For: 2.3.0
>
> Attachments: HBASE-24280.master.001.patch,
> TEST-org.apache.hadoop.hbase.rest.TestSecureRESTServer.xml
>
>
> [~ndimiduk] pointed out that, after this change went in, TestSecureRESTServer
> started failing with Hadoop3 on branch-2.3
> https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/56/
> Of course, I ran this with 1.8.0_241 and Maven 3.6.33 and it passed :) {{mvn
> clean package -Dtest=TestSecureRESTServer -Dhadoop.profile=3.0
> -DfailIfNoTests=false}}
> FYI [~stoty] in case you can repro a failure and want to dig in. Feel free to
> re-assign.
> It looks like we didn't have a nightly run of branch-2.2 due to docker
> container build issues. Will be interesting to see if it fails there. It did
> not fail the master nightly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24294) [Flakey Tests] TestThriftHttpServer BindException
[
https://issues.apache.org/jira/browse/HBASE-24294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097966#comment-17097966
]
Hudson commented on HBASE-24294:
Results for branch master
[build #1715 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1475//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1715/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] TestThriftHttpServer BindException
> -
>
> Key: HBASE-24294
> URL: https://issues.apache.org/jira/browse/HBASE-24294
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Came across this last night:
> {code}
> Expected: (an instance of org.apache.thrift.transport.TTransportException and
> exception with message a string containing "HTTP Response code: 431")
> but: an instance of org.apache.thrift.transport.TTransportException
> is a
> java.lang.Exception
> Stacktrace was: java.lang.Exception: java.net.BindException: Address already
> in use
> at
> org.apache.hadoop.hbase.thrift.TestThriftHttpServer.stopHttpServerThread(TestThriftHttpServer.java:253)
> at
> org.apache.hadoop.hbase.thrift.TestThriftHttpServer.runThriftServer(TestThriftHttpServer.java:183)
> at
> org.apache.hadoop.hbase.thrift.TestThriftHttpServer.testRunThriftServerWithHeaderBufferLength(TestThriftHttpServer.java:147)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-24306) Make getServerName(String, int, long) private
Jan Hentschel created HBASE-24306:
-
Summary: Make getServerName(String, int, long) private
Key: HBASE-24306
URL: https://issues.apache.org/jira/browse/HBASE-24306
Project: HBase
Issue Type: Sub-task
Affects Versions: 3.0.0-alpha-1
Reporter: Jan Hentschel
Assignee: Jan Hentschel
{{getServerName(String, int, long)}} was marked deprecated in 2.0.0 with the
option to make it private in 3.0.0. It should be made sure that it is marked as
private in 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (HBASE-24306) Make getServerName(String, int, long) private
[
https://issues.apache.org/jira/browse/HBASE-24306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-24306 started by Jan Hentschel.
-
> Make getServerName(String, int, long) private
> -
>
> Key: HBASE-24306
> URL: https://issues.apache.org/jira/browse/HBASE-24306
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0-alpha-1
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> {{getServerName(String, int, long)}} was marked deprecated in 2.0.0 with the
> option to make it private in 3.0.0. It should be made sure that it is marked
> as private in 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-24305) Handle deprecations in ServerName
Jan Hentschel created HBASE-24305:
-
Summary: Handle deprecations in ServerName
Key: HBASE-24305
URL: https://issues.apache.org/jira/browse/HBASE-24305
Project: HBase
Issue Type: Task
Affects Versions: 3.0.0-alpha-1
Reporter: Jan Hentschel
Umbrella ticket for handling the deprecations of {{ServerName}} for version
3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] brfrn169 commented on pull request #1320: HBASE-8458 Support for batch version of checkAndPut() and checkAndDel…
brfrn169 commented on pull request #1320: URL: https://github.com/apache/hbase/pull/1320#issuecomment-622954492 Closing this. Will create another PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Issue Comment Deleted] (HBASE-8458) Support for batch version of checkAndPut() and checkAndDelete()
[ https://issues.apache.org/jira/browse/HBASE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-8458: Comment: was deleted (was: I fixed the conflicts in the PR. [~zhangduo] [~stack] Could you please review the PR when you get a chance? https://github.com/apache/hbase/pull/1320) > Support for batch version of checkAndPut() and checkAndDelete() > --- > > Key: HBASE-8458 > URL: https://issues.apache.org/jira/browse/HBASE-8458 > Project: HBase > Issue Type: New Feature > Components: Client, regionserver >Reporter: Hari Mankude >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > > The use case is that the user has multiple threads loading hundreds of keys > into a hbase table. Occasionally there are collisions in the keys being > uploaded by different threads. So for correctness, it is required to do > checkAndPut() instead of a put(). However, doing a checkAndPut() rpc for > every key update is non optimal. It would be good to have a batch version of > checkAndPut() similar to batch put(). The client can partition the keys on > region boundaries. > The jira is NOT looking for any type of cross-row locking or multi-row > atomicity with checkAndPut() > Batch version of checkAndDelete() is a similar requirement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (HBASE-8458) Support for batch version of checkAndPut() and checkAndDelete()
[ https://issues.apache.org/jira/browse/HBASE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-8458: Comment: was deleted (was: Ping [~zhangduo] [~stack]. Could you please review the PR when you get a chance? https://github.com/apache/hbase/pull/1320 The review points of the change are as follows: - The change has Protocol Buffers level changes. I moved MultiRequest#condition to RegionAction and MultiResponse#processed to RegionActionResult as mentioend in the follwoing comment. https://issues.apache.org/jira/browse/HBASE-8458?focusedCommentId=17064155&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17064155 - Introduce CheckAndMutate class that is instantiated by builder classes. - Add new 2 checkAndMutate methods with a single CheckAndMutate object and multiple CheckAndMutate objects. - Deprecated the old checkAndMutate methods. Thanks.) > Support for batch version of checkAndPut() and checkAndDelete() > --- > > Key: HBASE-8458 > URL: https://issues.apache.org/jira/browse/HBASE-8458 > Project: HBase > Issue Type: New Feature > Components: Client, regionserver >Reporter: Hari Mankude >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > > The use case is that the user has multiple threads loading hundreds of keys > into a hbase table. Occasionally there are collisions in the keys being > uploaded by different threads. So for correctness, it is required to do > checkAndPut() instead of a put(). However, doing a checkAndPut() rpc for > every key update is non optimal. It would be good to have a batch version of > checkAndPut() similar to batch put(). The client can partition the keys on > region boundaries. > The jira is NOT looking for any type of cross-row locking or multi-row > atomicity with checkAndPut() > Batch version of checkAndDelete() is a similar requirement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r418959287 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/CompactionThroughputControllerFactory.java ## @@ -33,10 +36,16 @@ public static final String HBASE_THROUGHPUT_CONTROLLER_KEY = "hbase.regionserver.throughput.controller"; + public static String currentControllerClassName = Review comment: > Why static? And do we really need to store the class name here? Why not just call the getClass method on the controller instance? Thanks , I think call the getClass is better This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24301) Update Apache POM to version 23
[ https://issues.apache.org/jira/browse/HBASE-24301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-24301: -- Fix Version/s: 2.2.5 2.4.0 1.7.0 2.3.0 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-1+. Thanks [~stack] & [~zhangduo] for the review. > Update Apache POM to version 23 > --- > > Key: HBASE-24301 > URL: https://issues.apache.org/jira/browse/HBASE-24301 > Project: HBase > Issue Type: Task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0, 2.4.0, 2.2.5 > > > The most recent version of the Apache parent POM is v23. We should update to > this one. There should not be big changes, except that it updates the > rat-plugin to the version we already have. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1628: HBASE-24304 Separate a hbase-asyncfs module
Apache-HBase commented on pull request #1628: URL: https://github.com/apache/hbase/pull/1628#issuecomment-622948953 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 39s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 49s | master passed | | +1 :green_heart: | checkstyle | 2m 23s | master passed | | +1 :green_heart: | spotbugs | 15m 16s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 47s | the patch passed | | -0 :warning: | checkstyle | 2m 22s | root: The patch generated 5 new + 293 unchanged - 2 fixed = 298 total (was 295) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 15s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 12m 22s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 17m 19s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 46s | The patch does not generate ASF License warnings. | | | | 71m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1628 | | Optional Tests | dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle | | uname | Linux 3bbc3315 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b4a0508381 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | Max. process+thread count | 122 (vs. ulimit of 12500) | | modules | C: hbase-asyncfs . hbase-endpoint hbase-examples hbase-mapreduce hbase-rest hbase-server hbase-shaded/hbase-shaded-testing-util hbase-testing-util hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1627: HBASE-24221 Support bulkLoadHFile by family
Apache-HBase commented on pull request #1627: URL: https://github.com/apache/hbase/pull/1627#issuecomment-622946295 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 6s | branch-2 passed | | +1 :green_heart: | compile | 0m 59s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 58s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 36s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 4m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 186m 28s | hbase-server in the patch passed. | | | | 209m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1627/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1627 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 63fb91aee6a4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / da92a12bf5 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1627/1/testReport/ | | Max. process+thread count | 2749 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1627/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1628: HBASE-24304 Separate a hbase-asyncfs module
Apache-HBase commented on pull request #1628: URL: https://github.com/apache/hbase/pull/1628#issuecomment-622945419 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 43s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 11s | master passed | | +1 :green_heart: | compile | 2m 44s | master passed | | +1 :green_heart: | shadedjars | 5m 26s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | root in master failed. | | -0 :warning: | javadoc | 0m 18s | hbase-examples in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 51s | hbase-thrift in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 8s | the patch passed | | +1 :green_heart: | compile | 2m 51s | the patch passed | | +1 :green_heart: | javac | 2m 51s | the patch passed | | +1 :green_heart: | shadedjars | 5m 44s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-asyncfs in the patch failed. | | -0 :warning: | javadoc | 0m 18s | root in the patch failed. | | -0 :warning: | javadoc | 0m 19s | hbase-examples in the patch failed. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 19s | hbase-rest in the patch failed. | | -0 :warning: | javadoc | 0m 42s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 1m 3s | hbase-thrift in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 5m 7s | root in the patch failed. | | | | 41m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1628 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 288f16c800ab 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b4a0508381 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-P
[GitHub] [hbase] Apache-HBase commented on pull request #1628: HBASE-24304 Separate a hbase-asyncfs module
Apache-HBase commented on pull request #1628: URL: https://github.com/apache/hbase/pull/1628#issuecomment-622945311 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 44s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 38s | master passed | | +1 :green_heart: | compile | 2m 14s | master passed | | +1 :green_heart: | shadedjars | 4m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 42s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 26s | the patch passed | | +1 :green_heart: | compile | 2m 24s | the patch passed | | +1 :green_heart: | javac | 2m 24s | the patch passed | | +1 :green_heart: | shadedjars | 5m 14s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 2m 1s | root generated 2 new + 87 unchanged - 0 fixed = 89 total (was 87) | | -0 :warning: | javadoc | 0m 37s | hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | ||| _ Other Tests _ | | -1 :x: | unit | 5m 36s | root in the patch failed. | | | | 41m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1628 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b5bf7ee18e70 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b4a0508381 | | Default Java | 1.8.0_232 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/testReport/ | | Max. process+thread count | 670 (vs. ulimit of 12500) | | modules | C: hbase-asyncfs . hbase-endpoint hbase-examples hbase-mapreduce hbase-rest hbase-server hbase-shaded/hbase-shaded-testing-util hbase-testing-util hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1628/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController
Apache9 commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r418952304 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/CompactionThroughputControllerFactory.java ## @@ -33,10 +36,16 @@ public static final String HBASE_THROUGHPUT_CONTROLLER_KEY = "hbase.regionserver.throughput.controller"; + public static String currentControllerClassName = Review comment: Why static? And do we really need to store the class name here? Why not just call the getClass method on the controller instance? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-23996) Many split related metrics were present RS side but after split is moved to Master, these metrics are lost.
[ https://issues.apache.org/jira/browse/HBASE-23996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097942#comment-17097942 ] Sanjeet Nishad commented on HBASE-23996: Hi I have attached a patch so that these split metrics will be present master side under sub = procedure JMX. Please have a look. Will attach a screenshot of JMX soon. ping [~pankajkumar] > Many split related metrics were present RS side but after split is moved to > Master, these metrics are lost. > --- > > Key: HBASE-23996 > URL: https://issues.apache.org/jira/browse/HBASE-23996 > Project: HBase > Issue Type: Improvement > Components: metrics >Affects Versions: 2.2.3 >Reporter: Sanjeet Nishad >Assignee: Sanjeet Nishad >Priority: Minor > Attachments: HBASE-23996.001.patch > > > Many of the split related metrics like following are present RS side : > "SplitTime_num_ops": 0, > "SplitTime_min": 0, > "SplitTime_max": 0, > "SplitTime_mean": 0, > "SplitTime_25th_percentile": 0, > "SplitTime_median": 0, > "SplitTime_75th_percentile": 0, > "SplitTime_90th_percentile": 0, > "SplitTime_95th_percentile": 0, > "SplitTime_98th_percentile": 0, > "SplitTime_99th_percentile": 0, > "SplitTime_99.9th_percentile": 0, > Value of these will always be 0 since Split is happening Master side and > there is no Metrics update. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on pull request #1601: [DRAFT] Make HedgedRpcChannel real async
Apache9 commented on pull request #1601: URL: https://github.com/apache/hbase/pull/1601#issuecomment-622943925 BTW, implementing hedged read in rpc framework, it to use a special channel(HedgedRpcChannel) here to wrap multiple RpcChannels, as the RpcChannel provide a callMethod method to do asynchronous call. But for the protobuf stub, it also has the ability to do asynchronous call(BlockingInterface vs. Interface, newBlockingStub vs. newStub), so wrapping on the stub can also solve the hedged read problem, and this is exactly what we have done for implementing the read replicas feature. So to be honest, I do not see the necessity to change the wrapping layer from stub to rpc channel... Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-23996) Many split related metrics were present RS side but after split is moved to Master, these metrics are lost.
[ https://issues.apache.org/jira/browse/HBASE-23996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjeet Nishad updated HBASE-23996: --- Attachment: HBASE-23996.001.patch Status: Patch Available (was: Open) > Many split related metrics were present RS side but after split is moved to > Master, these metrics are lost. > --- > > Key: HBASE-23996 > URL: https://issues.apache.org/jira/browse/HBASE-23996 > Project: HBase > Issue Type: Improvement > Components: metrics >Affects Versions: 2.2.3 >Reporter: Sanjeet Nishad >Assignee: Sanjeet Nishad >Priority: Minor > Attachments: HBASE-23996.001.patch > > > Many of the split related metrics like following are present RS side : > "SplitTime_num_ops": 0, > "SplitTime_min": 0, > "SplitTime_max": 0, > "SplitTime_mean": 0, > "SplitTime_25th_percentile": 0, > "SplitTime_median": 0, > "SplitTime_75th_percentile": 0, > "SplitTime_90th_percentile": 0, > "SplitTime_95th_percentile": 0, > "SplitTime_98th_percentile": 0, > "SplitTime_99th_percentile": 0, > "SplitTime_99.9th_percentile": 0, > Value of these will always be 0 since Split is happening Master side and > there is no Metrics update. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on pull request #1593: HBASE-24265 Remove hedged rpc call support, implement the logic in MaterRegistry …
Apache9 commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-622941710 Ping @ndimiduk and @saintstack , what do you guys think? I've replied on #1601 , at least the current implementation does not make sense to me, there is no reason that why we can only support NettyRpcClient. FWIW, I do not see any advantages on moving the logic from AsyncRpcRetryingCaller down to the rpc framework, except that the MasterRegistry can make use of it, but implementing the logic in MasterRegistry only requires a very small amount of code piece, and can do better error handling than implementing in the rpc framework, so I do not think it worths. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #1601: [DRAFT] Make HedgedRpcChannel real async
Apache9 commented on pull request #1601: URL: https://github.com/apache/hbase/pull/1601#issuecomment-622940693 In general, for the implementation for HedgedRpcChannel, I think a better solution is to wrap several RpcChannels as the callMethod method is asynchronous. > // ** WARN ** This is a blocking call if the underlying connection for the rpc client is // a blocking implementation (ex: BlockingRpcConnection). That essentially serializes all // the write calls. Handling blocking connection means that this should be run in a separate // thread and hence more code complexity. Is it ok to handle only non-blocking connections? The comment in code is incorrect, even for BlockingRpcConnection, the callMethod is still asynchronous... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request #1628: HBASE-24304 Separate a hbase-asyncfs module
Apache9 opened a new pull request #1628: URL: https://github.com/apache/hbase/pull/1628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24304) Separate a hbase-asyncfs module
Duo Zhang created HBASE-24304: - Summary: Separate a hbase-asyncfs module Key: HBASE-24304 URL: https://issues.apache.org/jira/browse/HBASE-24304 Project: HBase Issue Type: Improvement Components: build, pom Reporter: Duo Zhang Assignee: Duo Zhang To hold the async fs related class for WAL implementation as the hbase-server module is too big. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-24304) Separate a hbase-asyncfs module
[ https://issues.apache.org/jira/browse/HBASE-24304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24304 started by Duo Zhang. - > Separate a hbase-asyncfs module > --- > > Key: HBASE-24304 > URL: https://issues.apache.org/jira/browse/HBASE-24304 > Project: HBase > Issue Type: Improvement > Components: build, pom >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > > To hold the async fs related class for WAL implementation as the hbase-server > module is too big. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24304) Separate a hbase-asyncfs module
[ https://issues.apache.org/jira/browse/HBASE-24304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24304: -- Fix Version/s: 2.3.0 3.0.0-alpha-1 > Separate a hbase-asyncfs module > --- > > Key: HBASE-24304 > URL: https://issues.apache.org/jira/browse/HBASE-24304 > Project: HBase > Issue Type: Improvement > Components: build, pom >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > > To hold the async fs related class for WAL implementation as the hbase-server > module is too big. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1623: HBASE-24302 Add an "ignoreTimestamps" option (defaulted to false) to …
Apache-HBase commented on pull request #1623: URL: https://github.com/apache/hbase/pull/1623#issuecomment-622939405 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 55s | master passed | | +1 :green_heart: | compile | 0m 34s | master passed | | +1 :green_heart: | shadedjars | 6m 36s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 27s | the patch passed | | +1 :green_heart: | compile | 0m 28s | the patch passed | | +1 :green_heart: | javac | 0m 28s | the patch passed | | +1 :green_heart: | shadedjars | 6m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 15m 28s | hbase-mapreduce in the patch passed. | | | | 41m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1623/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1623 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 128761ffa6cd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b4a0508381 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1623/2/testReport/ | | Max. process+thread count | 5943 (vs. ulimit of 12500) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1623/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1627: HBASE-24221 Support bulkLoadHFile by family
Apache-HBase commented on pull request #1627: URL: https://github.com/apache/hbase/pull/1627#issuecomment-622939358 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 6s | branch-2 passed | | +1 :green_heart: | compile | 1m 4s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 11s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 51s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | +1 :green_heart: | shadedjars | 5m 12s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 123m 35s | hbase-server in the patch passed. | | | | 151m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1627/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1627 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0f4d6e0858ef 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / da92a12bf5 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1627/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1627/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1627/1/testReport/ | | Max. process+thread count | 4106 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1627/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1623: HBASE-24302 Add an "ignoreTimestamps" option (defaulted to false) to …
Apache-HBase commented on pull request #1623: URL: https://github.com/apache/hbase/pull/1623#issuecomment-622939006 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 52s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 3s | master passed | | +1 :green_heart: | checkstyle | 0m 23s | master passed | | +1 :green_heart: | spotbugs | 0m 56s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 26s | the patch passed | | -0 :warning: | checkstyle | 0m 22s | hbase-mapreduce: The patch generated 1 new + 4 unchanged - 1 fixed = 5 total (was 5) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 51s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 1m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 38m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1623/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1623 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 8bb14b7300dc 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b4a0508381 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1623/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1623/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1623: HBASE-24302 Add an "ignoreTimestamps" option (defaulted to false) to …
Apache-HBase commented on pull request #1623: URL: https://github.com/apache/hbase/pull/1623#issuecomment-622938576 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 6s | master passed | | +1 :green_heart: | compile | 0m 27s | master passed | | +1 :green_heart: | shadedjars | 5m 10s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 23s | hbase-mapreduce in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | the patch passed | | +1 :green_heart: | compile | 0m 27s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | +1 :green_heart: | shadedjars | 5m 13s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 12m 53s | hbase-mapreduce in the patch passed. | | | | 34m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1623/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1623 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2ce02fcee0aa 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b4a0508381 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1623/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1623/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1623/2/testReport/ | | Max. process+thread count | 5691 (vs. ulimit of 12500) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1623/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on pull request #1623: HBASE-24302 Add an "ignoreTimestamps" option (defaulted to false) to …
wchevreuil commented on pull request #1623: URL: https://github.com/apache/hbase/pull/1623#issuecomment-622935210 I realised I had forgotten to add the new option description on _HashTable_ instructions print. Had added it on the last commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on pull request #1623: HBASE-24302 Add an "ignoreTimestamps" option (defaulted to false) to …
wchevreuil commented on pull request #1623: URL: https://github.com/apache/hbase/pull/1623#issuecomment-622935062 > Should also come with an update to https://hbase.apache.org/book.html#hashtable.synctable Was planning to do that on a separate _docs_ jira. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1627: HBASE-24221 Support bulkLoadHFile by family
Apache-HBase commented on pull request #1627: URL: https://github.com/apache/hbase/pull/1627#issuecomment-622926639 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 4s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 20s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 16s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 35s | the patch passed | | +1 :green_heart: | checkstyle | 1m 15s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 20s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 50s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 38m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1627/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1627 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux f633d8e28e7d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / da92a12bf5 | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1627/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] nyl3532016 opened a new pull request #1627: HBASE-24221 Support bulkLoadHFile by family
nyl3532016 opened a new pull request #1627: URL: https://github.com/apache/hbase/pull/1627 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on a change in pull request #1623: HBASE-24302 Add an "ignoreTimestamps" option (defaulted to false) to …
wchevreuil commented on a change in pull request #1623:
URL: https://github.com/apache/hbase/pull/1623#discussion_r418933398
##
File path:
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestSyncTable.java
##
@@ -463,26 +490,28 @@ private void writeTestData(TableName sourceTableName,
TableName targetTableName)
int numRows = 100;
int sourceRegions = 10;
int targetRegions = 6;
+if (ArrayUtils.isEmpty(timestamps)) {
Review comment:
Decided to use varargs so that I didn't need to change other existing
methods already calling writeTestData.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24280) TestSecureRESTServer started failing in nightlies for Hadoop3
[
https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097851#comment-17097851
]
Duo Zhang commented on HBASE-24280:
---
[~busbey] The maven profile is a magic. I tried to remove the 'hadoop.profile'
activation when removing the hadoop 2.x support for master, but activeByDefault
did not work for me...
In general, I do not like to treat master and branch-2.x differently but if no
one can find a better (workable) solution, let's apply
https://github.com/apache/hbase/pull/1609 first...
> TestSecureRESTServer started failing in nightlies for Hadoop3
> -
>
> Key: HBASE-24280
> URL: https://issues.apache.org/jira/browse/HBASE-24280
> Project: HBase
> Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Istvan Toth
>Priority: Major
> Fix For: 2.3.0
>
> Attachments: HBASE-24280.master.001.patch,
> TEST-org.apache.hadoop.hbase.rest.TestSecureRESTServer.xml
>
>
> [~ndimiduk] pointed out that, after this change went in, TestSecureRESTServer
> started failing with Hadoop3 on branch-2.3
> https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/56/
> Of course, I ran this with 1.8.0_241 and Maven 3.6.33 and it passed :) {{mvn
> clean package -Dtest=TestSecureRESTServer -Dhadoop.profile=3.0
> -DfailIfNoTests=false}}
> FYI [~stoty] in case you can repro a failure and want to dig in. Feel free to
> re-assign.
> It looks like we didn't have a nightly run of branch-2.2 due to docker
> container build issues. Will be interesting to see if it fails there. It did
> not fail the master nightly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master
Apache9 commented on pull request #1609: URL: https://github.com/apache/hbase/pull/1609#issuecomment-622775512 Be lated +1. Thanks @joshelser for taking care of this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24300) TestRemoteBackup is broken
[ https://issues.apache.org/jira/browse/HBASE-24300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24300: -- Fix Version/s: 3.0.0-alpha-1 > TestRemoteBackup is broken > -- > > Key: HBASE-24300 > URL: https://issues.apache.org/jira/browse/HBASE-24300 > Project: HBase > Issue Type: Bug > Components: backup&restore >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1 > > > It seems that the bulk load rpc request is timed out after 1 minute and fails > the test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on pull request #1621: HBASE-24300 TestRemoteBackup is broken
Apache9 commented on pull request #1621: URL: https://github.com/apache/hbase/pull/1621#issuecomment-622771098 > I think it was me that set down the RPC count as part of culling resource usage across tests. Sorry if I broke this one. Thanks for fixing. Never mind sir. I think the final way to fix this is to implement the async rpc server :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
