[
https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098156#comment-17098156
]
Sean Busbey commented on HBASE-24280:
-------------------------------------
activeByDefault does not work for almost anything folks want to do with it. We
should not use it in the project at all unless that use comes with a good
explanation for what it is doing. activeByDefault expressly is not good as a
way to set up "default" properties or plugin use.
What I suggested was a formalization of what we already have to do because of
downstream non-maven build tools. It is the maven best practice when you will
have multiple profiles to switch between some mutually exclusive set of options
(as we do with Hadoop major versions). A simplified explanation is that you
have to duplicate outside of the set of profiles whatever it is that is done by
the profile you consider to be the default.
Let me go make an example PR under a ticket that expressly says it is for that
purpose.
> TestSecureRESTServer started failing in nightlies for Hadoop3
> -------------------------------------------------------------
>
> Key: HBASE-24280
> URL: https://issues.apache.org/jira/browse/HBASE-24280
> Project: HBase
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Istvan Toth
> Priority: Major
> Fix For: 2.3.0
>
> Attachments: HBASE-24280.master.001.patch,
> TEST-org.apache.hadoop.hbase.rest.TestSecureRESTServer.xml
>
>
> [~ndimiduk] pointed out that, after this change went in, TestSecureRESTServer
> started failing with Hadoop3 on branch-2.3
> https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/56/
> Of course, I ran this with 1.8.0_241 and Maven 3.6.33 and it passed :) {{mvn
> clean package -Dtest=TestSecureRESTServer -Dhadoop.profile=3.0
> -DfailIfNoTests=false}}
> FYI [~stoty] in case you can repro a failure and want to dig in. Feel free to
> re-assign.
> It looks like we didn't have a nightly run of branch-2.2 due to docker
> container build issues. Will be interesting to see if it fails there. It did
> not fail the master nightly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
