[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Apache-HBase commented on pull request #2202: URL: https://github.com/apache/hbase/pull/2202#issuecomment-678942484 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 57s | master passed | | +1 :green_heart: | compile | 2m 57s | master passed | | +1 :green_heart: | shadedjars | 6m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 56s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 53s | the patch passed | | +1 :green_heart: | compile | 3m 0s | the patch passed | | +1 :green_heart: | javac | 3m 0s | the patch passed | | +1 :green_heart: | shadedjars | 5m 58s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 56s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 47s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 7s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 201m 35s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 5m 12s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 8m 32s | hbase-shell in the patch passed. | | | | 256m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2202 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5093b4b89147 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9f62a82334 | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/testReport/ | | Max. process+thread count | 3740 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24760) Refactor RSGroup fallback
[ https://issues.apache.org/jira/browse/HBASE-24760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin updated HBASE-24760: Summary: Refactor RSGroup fallback (was: Allow system tables fallback to any rs groups) > Refactor RSGroup fallback > - > > Key: HBASE-24760 > URL: https://issues.apache.org/jira/browse/HBASE-24760 > Project: HBase > Issue Type: New Feature > Components: rsgroup >Affects Versions: 3.0.0-alpha-1 >Reporter: Sun Xin >Assignee: Sun Xin >Priority: Major > Fix For: 3.0.0-alpha-1 > > > In HBASE-22738 we allow tables fallback to specific rs groups, If there is no > online servers in the table's rsgroup. > -But for system tables, if there is no specified fallback rsgroup or the > servers in the fallback rsgroup all went down, It is necessary to allow > system tables fallback to any rsgroup in order to keey available at all > times.- > For Availability, refactor design of rsgroup fallback, finally only > introduced one config property `hbase.rsgroup.fallback.enable`, allow all > table, whether or not system tables, fallback to the default rsgroup first, > then fallback to any group if no online servers in default rsgroup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24760) Allow system tables fallback to any rs groups
[ https://issues.apache.org/jira/browse/HBASE-24760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin updated HBASE-24760: Description: In HBASE-22738 we allow tables fallback to specific rs groups, If there is no online servers in the table's rsgroup. -But for system tables, if there is no specified fallback rsgroup or the servers in the fallback rsgroup all went down, It is necessary to allow system tables fallback to any rsgroup in order to keey available at all times.- For Availability, refactor design of rsgroup fallback, finally only introduced one config property `hbase.rsgroup.fallback.enable`, allow all table, whether or not system tables, fallback to the default rsgroup first, then fallback to any group if no online servers in default rsgroup. was: In HBASE-22738 we allow tables fallback to specific rs groups, If there is no online servers in the table's rsgroup. But for system tables, if there is no specified fallback rsgroup or the servers in the fallback rsgroup all went down, It is necessary to allow system tables fallback to any rsgroup in order to keey available at all times. > Allow system tables fallback to any rs groups > - > > Key: HBASE-24760 > URL: https://issues.apache.org/jira/browse/HBASE-24760 > Project: HBase > Issue Type: New Feature > Components: rsgroup >Affects Versions: 3.0.0-alpha-1 >Reporter: Sun Xin >Assignee: Sun Xin >Priority: Major > Fix For: 3.0.0-alpha-1 > > > In HBASE-22738 we allow tables fallback to specific rs groups, If there is no > online servers in the table's rsgroup. > -But for system tables, if there is no specified fallback rsgroup or the > servers in the fallback rsgroup all went down, It is necessary to allow > system tables fallback to any rsgroup in order to keey available at all > times.- > For Availability, refactor design of rsgroup fallback, finally only > introduced one config property `hbase.rsgroup.fallback.enable`, allow all > table, whether or not system tables, fallback to the default rsgroup first, > then fallback to any group if no online servers in default rsgroup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…
Apache-HBase commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-678930173 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 43s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 5m 35s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | shadedjars | 5m 39s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 143m 31s | hbase-server in the patch passed. | | | | 168m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2249/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2249 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cee724a5c025 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c3a58bfe49 | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2249/5/testReport/ | | Max. process+thread count | 4521 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2249/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24940) runCatalogJanitor() API should return -1 to indicate already running status
Mohammad Arshad created HBASE-24940: --- Summary: runCatalogJanitor() API should return -1 to indicate already running status Key: HBASE-24940 URL: https://issues.apache.org/jira/browse/HBASE-24940 Project: HBase Issue Type: Improvement Affects Versions: 2.2.3 Reporter: Mohammad Arshad Assignee: Mohammad Arshad runCleanerChore() API returns false if hbck chore is already running. This is quite helpful in many cases. runCatalogJanitor() API is not indicating whether scan is already running. Also it is not doing anything in case scan is already running. I think we should return -1 to indicate already running status. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…
Apache-HBase commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-678926302 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 30s | master passed | | +1 :green_heart: | compile | 1m 6s | master passed | | +1 :green_heart: | shadedjars | 5m 48s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 13s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | +1 :green_heart: | shadedjars | 5m 48s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 130m 54s | hbase-server in the patch passed. | | | | 158m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2249/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2249 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5977afff271e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c3a58bfe49 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2249/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2249/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2249/5/testReport/ | | Max. process+thread count | 3919 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2249/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2130: HBASE-24765: Dynamic master discovery
Apache-HBase commented on pull request #2130: URL: https://github.com/apache/hbase/pull/2130#issuecomment-678919771 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 38s | master passed | | +1 :green_heart: | checkstyle | 1m 57s | master passed | | +1 :green_heart: | spotbugs | 6m 34s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 24s | the patch passed | | -0 :warning: | checkstyle | 0m 26s | hbase-client: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | -0 :warning: | checkstyle | 0m 13s | hbase-zookeeper: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | -0 :warning: | checkstyle | 1m 6s | hbase-server: The patch generated 4 new + 106 unchanged - 1 fixed = 110 total (was 107) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 9s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 2m 19s | the patch passed | | +1 :green_heart: | spotbugs | 7m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. | | | | 48m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2130/10/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2130 | | JIRA Issue | HBASE-24765 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux 7699366d90a2 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2874f00a2f | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2130/10/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2130/10/artifact/yetus-general-check/output/diff-checkstyle-hbase-zookeeper.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2130/10/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2130/10/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Apache-HBase commented on pull request #2202: URL: https://github.com/apache/hbase/pull/2202#issuecomment-678916178 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 1s | master passed | | +1 :green_heart: | compile | 3m 27s | master passed | | +1 :green_heart: | shadedjars | 5m 48s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 52s | hbase-thrift in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 1s | the patch passed | | +1 :green_heart: | compile | 3m 28s | the patch passed | | +1 :green_heart: | javac | 3m 28s | the patch passed | | +1 :green_heart: | shadedjars | 5m 44s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 50s | hbase-thrift in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 58s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. | | -1 :x: | unit | 136m 31s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 4m 50s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 7m 10s | hbase-shell in the patch passed. | | | | 186m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2202 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux bee7b347c44f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9f62a82334 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/testReport/ | | Max. process+thread count | 4268 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe
[GitHub] [hbase] Apache-HBase commented on pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table and splitParent region
Apache-HBase commented on pull request #2292: URL: https://github.com/apache/hbase/pull/2292#issuecomment-678908460 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 25s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 5m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | the patch passed | | +1 :green_heart: | compile | 0m 54s | the patch passed | | +1 :green_heart: | javac | 0m 54s | the patch passed | | +1 :green_heart: | shadedjars | 5m 32s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 145m 29s | hbase-server in the patch passed. | | | | 175m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2292 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b15bbc044008 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9f62a82334 | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/4/testReport/ | | Max. process+thread count | 4193 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on pull request #2130: HBASE-24765: Dynamic master discovery
bharathv commented on pull request #2130: URL: https://github.com/apache/hbase/pull/2130#issuecomment-678906608 @Apache9 / @virajjasani Any more comments or is this good to go? This has been open for a while, would like to get it in asap unless you have any comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table and splitParent region
Apache-HBase commented on pull request #2292: URL: https://github.com/apache/hbase/pull/2292#issuecomment-678902691 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 3s | master passed | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | shadedjars | 5m 51s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 57s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 5m 47s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 129m 39s | hbase-server in the patch passed. | | | | 155m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2292 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3e67e65634ae 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9f62a82334 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/4/testReport/ | | Max. process+thread count | 3855 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2222: HBASE-23834 HBase fails to run on Hadoop 3.3.0/3.2.2/3.1.4 due to jet…
Apache-HBase commented on pull request #: URL: https://github.com/apache/hbase/pull/#issuecomment-678896031 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 39s | master passed | | +1 :green_heart: | checkstyle | 1m 59s | master passed | | +1 :green_heart: | spotbugs | 12m 53s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | checkstyle | 1m 59s | root: The patch generated 0 new + 123 unchanged - 3 fixed = 123 total (was 126) | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 13s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 15s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 13m 45s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 2m 28s | The patch does not generate ASF License warnings. | | | | 62m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-/9/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/ | | Optional Tests | dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle shellcheck shelldocs | | uname | Linux 9798ea66512f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c3a58bfe49 | | Max. process+thread count | 137 (vs. ulimit of 12500) | | modules | C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-it hbase-rest hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-/9/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24916) Region hole contains wrong regions pair when hole is created by first region deletion
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182944#comment-17182944 ] Mohammad Arshad commented on HBASE-24916: - Suppose a cluster with two tables t1 and t2. Table t1 with regions r1, r2, r3 and table t2 with regions s1,s2,s3 When a region hole is created by deleting s3 then hole has the region pair as But when a region hole is created by deleting s1 then hole has the region pair as . Here both regions belong to different tables This seems wrong. This hole's region pair should be > Region hole contains wrong regions pair when hole is created by first region > deletion > - > > Key: HBASE-24916 > URL: https://issues.apache.org/jira/browse/HBASE-24916 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Assignee: Mohammad Arshad >Priority: Major > > HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in > meta and start key is empty > for hole, it reports two region where hole is present. > Scenario where first region is missing for eg: in below scenario r1 is > missing in meta > start key end key region > empty 10 r1 > 10 20 r2 > 20 30 r2 > 30 empty r3 > > In our test hbck report contains two region where first region belongs to > different table and second region is r2. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…
Apache-HBase commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-678893961 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 1s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 55s | master passed | | +1 :green_heart: | checkstyle | 1m 6s | master passed | | +1 :green_heart: | spotbugs | 2m 7s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 36s | the patch passed | | +1 :green_heart: | checkstyle | 1m 3s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 35s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 37m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2249/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2249 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 1eac382800c5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c3a58bfe49 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2249/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24916) Region hole contains wrong regions pair when hole is created by first region deletion
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182939#comment-17182939 ] Mohammad Arshad commented on HBASE-24916: - I think hole was created directly by deleting the region from meta. Hole was not created by any problematic hbck2 command. When a region hole is created by deleting last region of a table then hole has the region pair as But when a region hole is created by deleting the first region then hole has the region pair as . This seems wrong. This hole region pair should be > Region hole contains wrong regions pair when hole is created by first region > deletion > - > > Key: HBASE-24916 > URL: https://issues.apache.org/jira/browse/HBASE-24916 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Assignee: Mohammad Arshad >Priority: Major > > HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in > meta and start key is empty > for hole, it reports two region where hole is present. > Scenario where first region is missing for eg: in below scenario r1 is > missing in meta > start key end key region > empty 10 r1 > 10 20 r2 > 20 30 r2 > 30 empty r3 > > In our test hbck report contains two region where first region belongs to > different table and second region is r2. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24916) Region hole contains wrong regions pair when hole is created by first region deletion
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad updated HBASE-24916: Summary: Region hole contains wrong regions pair when hole is created by first region deletion (was: HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in meta and start key is empty) > Region hole contains wrong regions pair when hole is created by first region > deletion > - > > Key: HBASE-24916 > URL: https://issues.apache.org/jira/browse/HBASE-24916 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Assignee: Mohammad Arshad >Priority: Major > > HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in > meta and start key is empty > for hole, it reports two region where hole is present. > Scenario where first region is missing for eg: in below scenario r1 is > missing in meta > start key end key region > empty 10 r1 > 10 20 r2 > 20 30 r2 > 30 empty r3 > > In our test hbck report contains two region where first region belongs to > different table and second region is r2. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2298: HBASE-14847 Add FIFO compaction section to HBase book
Apache-HBase commented on pull request #2298: URL: https://github.com/apache/hbase/pull/2298#issuecomment-678891278 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | master passed | | +0 :ok: | refguide | 4m 48s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 35s | the patch passed | | -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +0 :ok: | refguide | 5m 2s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 19m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2298/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2298 | | Optional Tests | dupname asflicense refguide | | uname | Linux e25ebdc5e58d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c3a58bfe49 | | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2298/1/artifact/yetus-general-check/output/branch-site/book.html | | whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2298/1/artifact/yetus-general-check/output/whitespace-eol.txt | | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2298/1/artifact/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 79 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2298/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24928) balanceRSGroup should skip generating balance plan for disabled table and splitParent region
[
https://issues.apache.org/jira/browse/HBASE-24928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182936#comment-17182936
]
Guanghao Zhang commented on HBASE-24928:
Can you prepare a PR for branch-2? The master patch cannot apply to branch-2
directly. Thanks.
> balanceRSGroup should skip generating balance plan for disabled table and
> splitParent region
>
>
> Key: HBASE-24928
> URL: https://issues.apache.org/jira/browse/HBASE-24928
> Project: HBase
> Issue Type: Improvement
> Components: Balancer
>Reporter: niuyulin
>Assignee: niuyulin
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
>
> now ,we generate balance plan for disabled tables, which is useless
> {code:java}
> 2020-08-20,20:47:54,702 WARN
> [RpcServer.default.RWQ.Fifo.read.handler=310,queue=6,port=22500]
> org.apache.hadoop.hbase.master.HMaster: Failed balance plan:
> hri=aa325467924edc865ab2ef6d82f9e2a7,
> source=tj1-hadoop-staging-st02.kscn,22600,1572403947348, destination=, just
> skip it
> org.apache.hadoop.hbase.client.DoNotRetryRegionException: Unexpected state
> for rit=CLOSED, location=tj1-hadoop-staging-st02.kscn,22600,1572403947348,
> table=galaxysds:sds_staging_258z, region=aa325467924edc865ab2ef6d82f9e2a7
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.preTransitCheck(AssignmentManager.java:580)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.createMoveRegionProcedure(AssignmentManager.java:635)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.moveAsync(AssignmentManager.java:652)
> at
> org.apache.hadoop.hbase.master.HMaster.executeRegionPlansWithThrottling(HMaster.java:1776)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.balanceRSGroup(RSGroupAdminServer.java:486)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint$RSGroupAdminServiceImpl.balanceRSGroup(RSGroupAdminEndpoint.java:293)
> at
> org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos$RSGroupAdminService.callMethod(RSGroupAdminProtos.java:13890)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:908)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:135)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2298: HBASE-14847 Add FIFO compaction section to HBase book
Apache-HBase commented on pull request #2298: URL: https://github.com/apache/hbase/pull/2298#issuecomment-678889691 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m 14s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 11m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2298/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2298 | | Optional Tests | | | uname | Linux a273202c4099 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2874f00a2f | | Max. process+thread count | 45 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2298/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] infraio merged pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table and splitParent region
infraio merged pull request #2292: URL: https://github.com/apache/hbase/pull/2292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2298: HBASE-14847 Add FIFO compaction section to HBase book
Apache-HBase commented on pull request #2298: URL: https://github.com/apache/hbase/pull/2298#issuecomment-67020 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2298/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2298 | | Optional Tests | | | uname | Linux edb37183c0b6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c3a58bfe49 | | Max. process+thread count | 41 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2298/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] HurSungYun opened a new pull request #2298: HBASE-14847 Add FIFO compaction section to HBase book
HurSungYun opened a new pull request #2298: URL: https://github.com/apache/hbase/pull/2298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24906) Enlarge the wait time in TestReplicationEndpoint/TestMetaWithReplicasBasic
[ https://issues.apache.org/jira/browse/HBASE-24906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24906: --- Summary: Enlarge the wait time in TestReplicationEndpoint/TestMetaWithReplicasBasic (was: Enlarge the wait time in TestReplicationEndpoint#testInterClusterReplication) > Enlarge the wait time in TestReplicationEndpoint/TestMetaWithReplicasBasic > -- > > Key: HBASE-24906 > URL: https://issues.apache.org/jira/browse/HBASE-24906 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > > Failed many times. But the failed reason are different. The replicated > entries number are different. So it means the replication is work and it need > more time to replicate all 2500 entries. > h3. Error Message > Waiting timed out after [30,000] msec Failed to replicate all edits, expected > = 2500 replicated = 2499 > > h3. Error Message > Waiting timed out after [30,000] msec Failed to replicate all edits, expected > = 2500 replicated = 2481 > > h3. Error Message > Waiting timed out after [30,000] msec Failed to replicate all edits, expected > = 2500 replicated = 2491 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24906) Enlarge the wait time in TestReplicationEndpoint/TestMetaWithReplicasBasic
[ https://issues.apache.org/jira/browse/HBASE-24906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24906. Fix Version/s: 2.2.6 Resolution: Fixed > Enlarge the wait time in TestReplicationEndpoint/TestMetaWithReplicasBasic > -- > > Key: HBASE-24906 > URL: https://issues.apache.org/jira/browse/HBASE-24906 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 2.2.6 > > > Failed many times. But the failed reason are different. The replicated > entries number are different. So it means the replication is work and it need > more time to replicate all 2500 entries. > h3. Error Message > Waiting timed out after [30,000] msec Failed to replicate all edits, expected > = 2500 replicated = 2499 > > h3. Error Message > Waiting timed out after [30,000] msec Failed to replicate all edits, expected > = 2500 replicated = 2481 > > h3. Error Message > Waiting timed out after [30,000] msec Failed to replicate all edits, expected > = 2500 replicated = 2491 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24904) Speed up some unit tests
[ https://issues.apache.org/jira/browse/HBASE-24904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24904. Fix Version/s: 2.2.6 Resolution: Fixed > Speed up some unit tests > > > Key: HBASE-24904 > URL: https://issues.apache.org/jira/browse/HBASE-24904 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 2.2.6 > > > See > [https://ci-hadoop.apache.org/job/HBase/job/HBase-Flaky-Tests/job/branch-2.2/42/testReport/org.apache.hadoop.hbase.client/TestAsyncTableAdminApi/] > [https://ci-hadoop.apache.org/job/HBase/job/HBase-Flaky-Tests/job/branch-2.2/61/testReport/junit/org.apache.hadoop.hbase.client/TestSnapshotTemporaryDirectoryWithRegionReplicas//] > > These ut are flaky because they take too much time which more than 780 > seconds. > > Split TestAsyncTableAdminApi/TestAdminShell/TestLoadIncrementalHFiles > > Reduce region numbers in > TestSnapshotTemporaryDirectoryWithRegionReplicas/TestRegionReplicaFailover/TestSCP* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24783) [hbase-thirdparty] Release 3.4.0
[ https://issues.apache.org/jira/browse/HBASE-24783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24783. --- Resolution: Fixed > [hbase-thirdparty] Release 3.4.0 > > > Key: HBASE-24783 > URL: https://issues.apache.org/jira/browse/HBASE-24783 > Project: HBase > Issue Type: Umbrella >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2202: HBASE-24822 Add a command to support archive the earliest log file ma…
Apache-HBase commented on pull request #2202: URL: https://github.com/apache/hbase/pull/2202#issuecomment-678885710 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 49s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 27s | master passed | | +1 :green_heart: | checkstyle | 2m 55s | master passed | | +1 :green_heart: | spotbugs | 7m 25s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 20s | the patch passed | | -0 :warning: | checkstyle | 1m 5s | hbase-server: The patch generated 1 new + 68 unchanged - 0 fixed = 69 total (was 68) | | -0 :warning: | rubocop | 0m 12s | The patch generated 3 new + 372 unchanged - 0 fixed = 375 total (was 372) | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 4s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 2m 52s | the patch passed | | +1 :green_heart: | spotbugs | 8m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 2s | The patch does not generate ASF License warnings. | | | | 55m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2202 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop | | uname | Linux 7c66e055fe3d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9f62a82334 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2202/7/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-24787) [hbase-thirdparty] Set version as 3.4.1-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-24787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24787. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~zghao] for reviewing. > [hbase-thirdparty] Set version as 3.4.1-SNAPSHOT > > > Key: HBASE-24787 > URL: https://issues.apache.org/jira/browse/HBASE-24787 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: thirdparty-3.5.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24905) [hbase-thirdparty] Remove dev_files
[ https://issues.apache.org/jira/browse/HBASE-24905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24905. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~zghao] for reviewing. > [hbase-thirdparty] Remove dev_files > --- > > Key: HBASE-24905 > URL: https://issues.apache.org/jira/browse/HBASE-24905 > Project: HBase > Issue Type: Task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: thirdparty-3.5.0 > > > It only contains a make_rc.sh script, but now we use the create-release > scripts from the main repo, so it is useless now. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-thirdparty] Apache9 merged pull request #35: HBASE-24787 [hbase-thirdparty] Set version as 3.4.1-SNAPSHOT
Apache9 merged pull request #35: URL: https://github.com/apache/hbase-thirdparty/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-thirdparty] Apache9 merged pull request #33: HBASE-24905 [hbase-thirdparty] Remove dev_files
Apache9 merged pull request #33: URL: https://github.com/apache/hbase-thirdparty/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24933) EOL 1.3.x release line
[ https://issues.apache.org/jira/browse/HBASE-24933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182922#comment-17182922 ] Duo Zhang commented on HBASE-24933: --- Will keep this issue open a week to see if we miss something. > EOL 1.3.x release line > -- > > Key: HBASE-24933 > URL: https://issues.apache.org/jira/browse/HBASE-24933 > Project: HBase > Issue Type: Umbrella >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24935) Remove 1.3.6 from download page
[ https://issues.apache.org/jira/browse/HBASE-24935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24935. --- Release Note: Removed 1.3.6 from download page as it is EOL. Resolution: Fixed Merged to master. Thanks [~vjasani] for reviewing. > Remove 1.3.6 from download page > --- > > Key: HBASE-24935 > URL: https://issues.apache.org/jira/browse/HBASE-24935 > Project: HBase > Issue Type: Sub-task > Components: website >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24938) Use asf-ci credentials in pre commit jenkins job
[ https://issues.apache.org/jira/browse/HBASE-24938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24938. --- Resolution: Fixed Fixed by using asf-ci for HBase-PreCommit-GitHub-PR. > Use asf-ci credentials in pre commit jenkins job > > > Key: HBASE-24938 > URL: https://issues.apache.org/jira/browse/HBASE-24938 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > So we can set the build status for PR. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #2295: HBASE-24935 Remove 1.3.6 from download page
Apache9 merged pull request #2295: URL: https://github.com/apache/hbase/pull/2295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 closed pull request #2297: test asf-ci
Apache9 closed pull request #2297: URL: https://github.com/apache/hbase/pull/2297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24938) Use asf-ci credentials in pre commit jenkins job
[ https://issues.apache.org/jira/browse/HBASE-24938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182919#comment-17182919 ] Duo Zhang commented on HBASE-24938: --- Seems we do not need to change any scripts, the build status is set by the jenkins job itself, not by yetus, so just use the asf-ci credentials for the jenkins job is enough. See this one. https://github.com/apache/hbase/pull/2297 Let me resolve this issue. > Use asf-ci credentials in pre commit jenkins job > > > Key: HBASE-24938 > URL: https://issues.apache.org/jira/browse/HBASE-24938 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > So we can set the build status for PR. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24938) Use asf-ci credentials in pre commit jenkins job
[ https://issues.apache.org/jira/browse/HBASE-24938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24938: -- Component/s: (was: scripts) (was: build) > Use asf-ci credentials in pre commit jenkins job > > > Key: HBASE-24938 > URL: https://issues.apache.org/jira/browse/HBASE-24938 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > So we can set the build status for PR. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24939) Invalid addFsRegionsMissingInMeta -d
Bo Cui created HBASE-24939: -- Summary: Invalid addFsRegionsMissingInMeta -d Key: HBASE-24939 URL: https://issues.apache.org/jira/browse/HBASE-24939 Project: HBase Issue Type: Bug Components: hbck2 Affects Versions: 2.2.3, 3.0.0-alpha-1 Reporter: Bo Cui [https://github.com/apache/hbase-operator-tools/blob/87878aada3354514050f5a2df11f27b317efd42d/hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java#L436] -d is invalid. addFsRegionsMissingInMeta does not use -d -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table and splitParent region
Apache-HBase commented on pull request #2292: URL: https://github.com/apache/hbase/pull/2292#issuecomment-678877705 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 25s | master passed | | +1 :green_heart: | checkstyle | 1m 1s | master passed | | +1 :green_heart: | spotbugs | 1m 55s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 19s | the patch passed | | +1 :green_heart: | checkstyle | 1m 3s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 9s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 37m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2292 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux e0f86f578665 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9f62a82334 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] nyl3532016 commented on a change in pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table and splitParent region
nyl3532016 commented on a change in pull request #2292:
URL: https://github.com/apache/hbase/pull/2292#discussion_r475308663
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##
@@ -1064,19 +1065,34 @@ private boolean isTableInGroup(TableName tableName,
String groupName,
return rit;
}
- private Map>>
getRSGroupAssignmentsByTable(
- String groupName) throws IOException {
+ /**
+ * This is an EXPENSIVE clone. Cloning though is the safest thing to do.
+ * Can't let out original since it can change and at least the load balancer
+ * wants to iterate this exported list.
Review comment:
I have added this comment
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] ddupg commented on a change in pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…
ddupg commented on a change in pull request #2249:
URL: https://github.com/apache/hbase/pull/2249#discussion_r475307894
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRefreshRecoveredReplication.java
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.replication.regionserver;
+
+import java.io.IOException;
+import java.util.Optional;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.replication.TestReplicationBase;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.ReplicationTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.JVMClusterUtil.RegionServerThread;
+import org.junit.After;
+import org.junit.AfterClass;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import
org.apache.hbase.thirdparty.org.apache.commons.collections4.CollectionUtils;
+
+/**
+ * Testcase for HBASE-24871.
+ */
+@Category({ ReplicationTests.class, MediumTests.class })
+public class TestRefreshRecoveredReplication extends TestReplicationBase {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestRefreshRecoveredReplication.class);
+
+ private static final Logger LOG =
LoggerFactory.getLogger(TestRefreshRecoveredReplication.class);
+
+ private static final int BATCH = 50;
+
+ @Rule
+ public TestName name = new TestName();
+
+ private TableName tablename;
+ private Table table1;
+ private Table table2;
+
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
+NUM_SLAVES1 = 2;
+// replicate slowly
+Configuration conf1 = UTIL1.getConfiguration();
+conf1.setInt(HConstants.REPLICATION_SOURCE_TOTAL_BUFFER_KEY, 100);
+TestReplicationBase.setUpBeforeClass();
+ }
+
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+TestReplicationBase.tearDownAfterClass();
+ }
+
+ @Before
+ public void setup() throws Exception {
+setUpBase();
+
+tablename = TableName.valueOf(name.getMethodName());
+TableDescriptor table = TableDescriptorBuilder.newBuilder(tablename)
+.setColumnFamily(ColumnFamilyDescriptorBuilder.newBuilder(famName)
+.setScope(HConstants.REPLICATION_SCOPE_GLOBAL).build())
+.build();
+
+UTIL1.getAdmin().createTable(table);
+UTIL2.getAdmin().createTable(table);
+UTIL1.waitTableAvailable(tablename);
+UTIL2.waitTableAvailable(tablename);
+table1 = UTIL1.getConnection().getTable(tablename);
+table2 = UTIL2.getConnection().getTable(tablename);
+ }
+
+ @After
+ public void teardown() throws Exception {
+tearDownBase();
+
+UTIL1.deleteTableIfAny(tablename);
+UTIL2.deleteTableIfAny(tablename);
+ }
+
+ @Test
+ public void testReplicationRefreshSource() throws Exception {
+// put some data
+for (int i = 0; i < BATCH; i++) {
+ byte[] r = Bytes.toBytes(i);
+ table1.put(new Put(r).addColumn(famName, famName, r));
+}
+
+// kill rs holding table region
+Optional server =
UTIL1.getMiniHBaseCluster().getLiveRegionServerThreads()
+.stream()
+.filter(rst ->
CollectionUtils.isNotEmpty(rst.getRegionServer().getRegions(tablename)))
+.findAny();
+Assert.assertTrue(server.isP
[GitHub] [hbase] Apache-HBase commented on pull request #2297: test asf-ci
Apache-HBase commented on pull request #2297: URL: https://github.com/apache/hbase/pull/2297#issuecomment-678868001 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 46s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24938 Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 5m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2297/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2297 | | Optional Tests | | | uname | Linux 9dd38a709834 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24938 / 9acef13b01 | | Max. process+thread count | 52 (vs. ulimit of 12500) | | modules | C: U: | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2297/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2297: test asf-ci
Apache-HBase commented on pull request #2297: URL: https://github.com/apache/hbase/pull/2297#issuecomment-678867546 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24938 Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 3m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2297/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2297 | | Optional Tests | | | uname | Linux c75ee801b3aa 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24938 / 9acef13b01 | | Max. process+thread count | 55 (vs. ulimit of 12500) | | modules | C: U: | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2297/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request #2297: test asf-ci
Apache9 opened a new pull request #2297: URL: https://github.com/apache/hbase/pull/2297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24938) Use asf-ci credentials in pre commit jenkins job
Duo Zhang created HBASE-24938: - Summary: Use asf-ci credentials in pre commit jenkins job Key: HBASE-24938 URL: https://issues.apache.org/jira/browse/HBASE-24938 Project: HBase Issue Type: Improvement Components: build, scripts Reporter: Duo Zhang Assignee: Duo Zhang So we can set the build status for PR. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24932) Reduce the number of builds to keep for flaky find job
[ https://issues.apache.org/jira/browse/HBASE-24932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24932. --- Resolution: Later > Reduce the number of builds to keep for flaky find job > -- > > Key: HBASE-24932 > URL: https://issues.apache.org/jira/browse/HBASE-24932 > Project: HBase > Issue Type: Sub-task > Components: build, flakies, scripts >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 closed pull request #2296: HBASE-24932 Reduce the number of builds to keep for flaky find job
Apache9 closed pull request #2296: URL: https://github.com/apache/hbase/pull/2296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24932) Reduce the number of builds to keep for flaky find job
[
https://issues.apache.org/jira/browse/HBASE-24932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182889#comment-17182889
]
Duo Zhang commented on HBASE-24932:
---
{quote}
At first I thought we only would need the latest build of the flaky job finder.
But the more I think about it, if we don't keep any old flaky reports then
there's no way to find out how a branch has been doing for flaky failures over
time.
{quote}
Do we really care the history? For me, after a fix, usually I will check the
flaky list for several new builds and if there are no failures, I will assume
the problem has been fixed. I've never checked the history...
> Reduce the number of builds to keep for flaky find job
> --
>
> Key: HBASE-24932
> URL: https://issues.apache.org/jira/browse/HBASE-24932
> Project: HBase
> Issue Type: Sub-task
> Components: build, flakies, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24925) SCP reduce unnecessary get requests
[ https://issues.apache.org/jira/browse/HBASE-24925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24925: --- Description: SCP should reduce unnecessary Get request [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L520] during startup， the tableNam2State of tableStateManager is not loading tableState data form metaTable yet. if procThread num is 50 and hbase has 10K tables, in the worst case, the master needs to query meta table 500K times(50*10K. and the regions that all SCPs simultaneously check tableState belong to the same table ) i think master can reduce Get request, and AM#loadMeta can load regions and all tables through asynchronous threads. [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java#L1532] was: SCP should reduce unnecessary Get request [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L520] during startup， the tableNam2State of tableStateManager is not loading tableState data form metaTable yet. if procThread num is 50 and hbase has 10K tables, in the worst case, the master needs to query meta table 500K times(50*10K. and the regions that all SCPs simultaneously check tableState belong to the same table ) i think master can reduce Get request, and AM#loadMeta can load regions and all tables [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java#L1532] > SCP reduce unnecessary get requests > --- > > Key: HBASE-24925 > URL: https://issues.apache.org/jira/browse/HBASE-24925 > Project: HBase > Issue Type: Improvement > Components: MTTR >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Bo Cui >Priority: Major > > SCP should reduce unnecessary Get request > [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L520] > during startup， the tableNam2State of tableStateManager is not loading > tableState data form metaTable yet. if procThread num is 50 and hbase has > 10K tables, in the worst case, the master needs to query meta table 500K > times(50*10K. and the regions that all SCPs simultaneously check tableState > belong to the same table ) > > i think master can reduce Get request, and AM#loadMeta can load regions and > all tables through asynchronous threads. > [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java#L1532] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24937) table.rb use LocalDateTime to replace Instant
[
https://issues.apache.org/jira/browse/HBASE-24937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bo Cui updated HBASE-24937:
---
Affects Version/s: 3.0.0-alpha-1
2.2.3
> table.rb use LocalDateTime to replace Instant
> -
>
> Key: HBASE-24937
> URL: https://issues.apache.org/jira/browse/HBASE-24937
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1, 2.2.3
>Reporter: Bo Cui
>Priority: Minor
>
> https://github.com/apache/hbase/blob/9f62a82334574b135f8e220b024981df64fab811/hbase-shell/src/main/ruby/hbase/table.rb#L754
> we can use timeZone to improve readability.
> {code:java}
> return java.time.LocalDateTime.ofInstant(instant,
> java.time.ZoneId.systemDefault()).toString
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24937) table.rb use LocalDateTime to replace Instant
[
https://issues.apache.org/jira/browse/HBASE-24937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bo Cui updated HBASE-24937:
---
Component/s: shell
> table.rb use LocalDateTime to replace Instant
> -
>
> Key: HBASE-24937
> URL: https://issues.apache.org/jira/browse/HBASE-24937
> Project: HBase
> Issue Type: Improvement
> Components: shell
>Affects Versions: 3.0.0-alpha-1, 2.2.3
>Reporter: Bo Cui
>Priority: Minor
>
> https://github.com/apache/hbase/blob/9f62a82334574b135f8e220b024981df64fab811/hbase-shell/src/main/ruby/hbase/table.rb#L754
> we can use timeZone to improve readability.
> {code:java}
> return java.time.LocalDateTime.ofInstant(instant,
> java.time.ZoneId.systemDefault()).toString
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-24937) table.rb use LocalDateTime to replace Instant
Bo Cui created HBASE-24937:
--
Summary: table.rb use LocalDateTime to replace Instant
Key: HBASE-24937
URL: https://issues.apache.org/jira/browse/HBASE-24937
Project: HBase
Issue Type: Improvement
Reporter: Bo Cui
https://github.com/apache/hbase/blob/9f62a82334574b135f8e220b024981df64fab811/hbase-shell/src/main/ruby/hbase/table.rb#L754
we can use timeZone to improve readability.
{code:java}
return java.time.LocalDateTime.ofInstant(instant,
java.time.ZoneId.systemDefault()).toString
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24811) Use class access static field or method
[
https://issues.apache.org/jira/browse/HBASE-24811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182873#comment-17182873
]
Hudson commented on HBASE-24811:
Results for branch branch-2
[build #17 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/17/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/17/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/17/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/17/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/17/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/17//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Use class access static field or method
> ---
>
> Key: HBASE-24811
> URL: https://issues.apache.org/jira/browse/HBASE-24811
> Project: HBase
> Issue Type: Improvement
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2
>
>
> we should use class to access static field or method ,not instance
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24811) Use class access static field or method
[
https://issues.apache.org/jira/browse/HBASE-24811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182835#comment-17182835
]
Hudson commented on HBASE-24811:
Results for branch branch-2.3
[build #14 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/14/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/14/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/14/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/14/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/14/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Use class access static field or method
> ---
>
> Key: HBASE-24811
> URL: https://issues.apache.org/jira/browse/HBASE-24811
> Project: HBase
> Issue Type: Improvement
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2
>
>
> we should use class to access static field or method ,not instance
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table and splitParent region
virajjasani commented on a change in pull request #2292:
URL: https://github.com/apache/hbase/pull/2292#discussion_r475250504
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##
@@ -1064,19 +1065,34 @@ private boolean isTableInGroup(TableName tableName,
String groupName,
return rit;
}
- private Map>>
getRSGroupAssignmentsByTable(
- String groupName) throws IOException {
+ /**
+ * This is an EXPENSIVE clone. Cloning though is the safest thing to do.
+ * Can't let out original since it can change and at least the load balancer
+ * wants to iterate this exported list.
Review comment:
Maybe for these two lines, we can mention:
```
Load balancer should iterate over this list because cloned list will ignore
disabled table and split parent region cases.
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2293: HBASE-24931 Fix for Candidate generator getAction method ignoring 0th…
virajjasani commented on pull request #2293: URL: https://github.com/apache/hbase/pull/2293#issuecomment-678807715 @busbey would you like to take a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2296: HBASE-24932 Reduce the number of builds to keep for flaky find job
virajjasani commented on pull request #2296: URL: https://github.com/apache/hbase/pull/2296#issuecomment-678807402 I just saw Sean's comments over Jira reg holding on to this change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24811) Use class access static field or method
[
https://issues.apache.org/jira/browse/HBASE-24811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182790#comment-17182790
]
Hudson commented on HBASE-24811:
Results for branch master
[build #16 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/16/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/16/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/16/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/16/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/16//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Use class access static field or method
> ---
>
> Key: HBASE-24811
> URL: https://issues.apache.org/jira/browse/HBASE-24811
> Project: HBase
> Issue Type: Improvement
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2
>
>
> we should use class to access static field or method ,not instance
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24932) Reduce the number of builds to keep for flaky find job
[ https://issues.apache.org/jira/browse/HBASE-24932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182755#comment-17182755 ] Sean Busbey commented on HBASE-24932: - I'm getting more detail from infra on what space is being used. Something is amiss because a given job should have < 40KB of artifacts. With a retention of 30 builds and 6 branches that's less than 10MB. I think fixing this disconnect is a better use of time then eliminating the job history. > Reduce the number of builds to keep for flaky find job > -- > > Key: HBASE-24932 > URL: https://issues.apache.org/jira/browse/HBASE-24932 > Project: HBase > Issue Type: Sub-task > Components: build, flakies, scripts >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24936) review Jenkins build artifacts
[ https://issues.apache.org/jira/browse/HBASE-24936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182754#comment-17182754 ] Sean Busbey commented on HBASE-24936: - Example job on ci-hadoop for copying stuff to the nightly host: https://ci-hadoop.apache.org/job/infra-test-nightlies/configure > review Jenkins build artifacts > -- > > Key: HBASE-24936 > URL: https://issues.apache.org/jira/browse/HBASE-24936 > Project: HBase > Issue Type: Task >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > > Post move to the ci-hadoop build servers we are now the biggest user of > space. That is not a problem in and of itself, but the master node has run > out of disk space twice now. As of this snapshot we are using 125GB of > storage and the next largest project is only using 20GB. > https://paste.apache.org/kyrds > We should review our builds for any issues and come up with expectations for > what our steady-state disk usage should look like > * we are supposed to compress any test logs (usually this gets us 90-99% > space savings) > * we are supposed to clean up workspaces when jobs are done > * we are supposed to keep a fixed window of prior builds (either by days or > number of runs) > If all of our jobs are currently following these guidelines, another > possibility is to push the artifacts we need over to > [nightlies.a.o|https://nightlies.apache.org/authoring.html]. Barring that, we > should formally request asf infra set up [a plugin for storing artifact on > s3|https://plugins.jenkins.io/artifact-manager-s3/]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table and splitParent region
Apache-HBase commented on pull request #2292: URL: https://github.com/apache/hbase/pull/2292#issuecomment-678795804 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 25s | master passed | | +1 :green_heart: | compile | 0m 53s | master passed | | +1 :green_heart: | shadedjars | 5m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 24s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | shadedjars | 5m 32s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 145m 54s | hbase-server in the patch passed. | | | | 170m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2292 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 82be0c55d217 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9f62a82334 | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/3/testReport/ | | Max. process+thread count | 4586 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table and splitParent region
Apache-HBase commented on pull request #2292: URL: https://github.com/apache/hbase/pull/2292#issuecomment-678794364 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 15s | master passed | | +1 :green_heart: | compile | 1m 3s | master passed | | +1 :green_heart: | shadedjars | 5m 42s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 0s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 5m 48s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 131m 28s | hbase-server in the patch passed. | | | | 157m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2292 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f3eadd31a9a9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9f62a82334 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/3/testReport/ | | Max. process+thread count | 4055 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-24931) Candidate Generator helper getAction method ignoring 0th index region
[
https://issues.apache.org/jira/browse/HBASE-24931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182718#comment-17182718
]
Mallikarjun edited comment on HBASE-24931 at 8/23/20, 3:07 PM:
---
Broke some unit tests. Fixing them.
was (Author: rda3mon):
Broke some unit test cases. Fixing them.
> Candidate Generator helper getAction method ignoring 0th index region
> -
>
> Key: HBASE-24931
> URL: https://issues.apache.org/jira/browse/HBASE-24931
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Reporter: Mallikarjun
>Assignee: Mallikarjun
>Priority: Minor
>
> Balance Candidate generators such as `LocalityBasedCandidateGenerator`,
> `RegionReplicaCandidateGenerator`, `RegionReplicaRackCandidateGenerator`,
> etc uses helper method `getAction` to generate action is ignoring 0th index
> of `fromRegion` and `toRegion`.
> {code:java}
> protected BaseLoadBalancer.Cluster.Action getAction(int fromServer, int
> fromRegion,
> int toServer, int toRegion) {
> if (fromServer < 0 || toServer < 0) {
> return BaseLoadBalancer.Cluster.NullAction;
> }
> if (fromRegion > 0 && toRegion > 0) {
> return new BaseLoadBalancer.Cluster.SwapRegionsAction(fromServer,
> fromRegion,
> toServer, toRegion);
> } else if (fromRegion > 0) {
> return new BaseLoadBalancer.Cluster.MoveRegionAction(fromRegion,
> fromServer, toServer);
> } else if (toRegion > 0) {
> return new BaseLoadBalancer.Cluster.MoveRegionAction(toRegion, toServer,
> fromServer);
> } else {
> return BaseLoadBalancer.Cluster.NullAction;
> }
> }
> {code}
> Is this unintentional or there is some particular reason?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24931) Candidate Generator helper getAction method ignoring 0th index region
[
https://issues.apache.org/jira/browse/HBASE-24931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182718#comment-17182718
]
Mallikarjun commented on HBASE-24931:
-
Broke some test cases. Fixing them.
> Candidate Generator helper getAction method ignoring 0th index region
> -
>
> Key: HBASE-24931
> URL: https://issues.apache.org/jira/browse/HBASE-24931
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Reporter: Mallikarjun
>Assignee: Mallikarjun
>Priority: Minor
>
> Balance Candidate generators such as `LocalityBasedCandidateGenerator`,
> `RegionReplicaCandidateGenerator`, `RegionReplicaRackCandidateGenerator`,
> etc uses helper method `getAction` to generate action is ignoring 0th index
> of `fromRegion` and `toRegion`.
> {code:java}
> protected BaseLoadBalancer.Cluster.Action getAction(int fromServer, int
> fromRegion,
> int toServer, int toRegion) {
> if (fromServer < 0 || toServer < 0) {
> return BaseLoadBalancer.Cluster.NullAction;
> }
> if (fromRegion > 0 && toRegion > 0) {
> return new BaseLoadBalancer.Cluster.SwapRegionsAction(fromServer,
> fromRegion,
> toServer, toRegion);
> } else if (fromRegion > 0) {
> return new BaseLoadBalancer.Cluster.MoveRegionAction(fromRegion,
> fromServer, toServer);
> } else if (toRegion > 0) {
> return new BaseLoadBalancer.Cluster.MoveRegionAction(toRegion, toServer,
> fromServer);
> } else {
> return BaseLoadBalancer.Cluster.NullAction;
> }
> }
> {code}
> Is this unintentional or there is some particular reason?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HBASE-24931) Candidate Generator helper getAction method ignoring 0th index region
[
https://issues.apache.org/jira/browse/HBASE-24931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182718#comment-17182718
]
Mallikarjun edited comment on HBASE-24931 at 8/23/20, 3:06 PM:
---
Broke some unit test cases. Fixing them.
was (Author: rda3mon):
Broke some test cases. Fixing them.
> Candidate Generator helper getAction method ignoring 0th index region
> -
>
> Key: HBASE-24931
> URL: https://issues.apache.org/jira/browse/HBASE-24931
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Reporter: Mallikarjun
>Assignee: Mallikarjun
>Priority: Minor
>
> Balance Candidate generators such as `LocalityBasedCandidateGenerator`,
> `RegionReplicaCandidateGenerator`, `RegionReplicaRackCandidateGenerator`,
> etc uses helper method `getAction` to generate action is ignoring 0th index
> of `fromRegion` and `toRegion`.
> {code:java}
> protected BaseLoadBalancer.Cluster.Action getAction(int fromServer, int
> fromRegion,
> int toServer, int toRegion) {
> if (fromServer < 0 || toServer < 0) {
> return BaseLoadBalancer.Cluster.NullAction;
> }
> if (fromRegion > 0 && toRegion > 0) {
> return new BaseLoadBalancer.Cluster.SwapRegionsAction(fromServer,
> fromRegion,
> toServer, toRegion);
> } else if (fromRegion > 0) {
> return new BaseLoadBalancer.Cluster.MoveRegionAction(fromRegion,
> fromServer, toServer);
> } else if (toRegion > 0) {
> return new BaseLoadBalancer.Cluster.MoveRegionAction(toRegion, toServer,
> fromServer);
> } else {
> return BaseLoadBalancer.Cluster.NullAction;
> }
> }
> {code}
> Is this unintentional or there is some particular reason?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] brfrn169 commented on a change in pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate
brfrn169 commented on a change in pull request #2228:
URL: https://github.com/apache/hbase/pull/2228#discussion_r475229008
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##
@@ -742,36 +741,35 @@ private Result increment(final HRegion region, final
OperationQuota quota,
spaceQuota.getPolicyEnforcement(region).check(increment);
quota.addMutation(increment);
Result r = null;
-if (region.getCoprocessorHost() != null) {
- r = region.getCoprocessorHost().preIncrement(increment);
-}
-if (r == null) {
- boolean canProceed = startNonceOperation(mutation, nonceGroup);
- boolean success = false;
- try {
-long nonce = mutation.hasNonce() ? mutation.getNonce() :
HConstants.NO_NONCE;
-if (canProceed) {
- r = region.increment(increment, nonceGroup, nonce);
-} else {
+boolean canProceed = startNonceOperation(mutation, nonceGroup);
Review comment:
Thank you for taking a look at this! @Apache9
Let me clarify this.
The pseudo codes of before and after the change are as follows:
The pseudo code before the change:
```
r = preIncrement(increment)
if (r == null) {
canProceed = startNonceOperation()
if (canProceed) {
// Process increment...
r = ...
} else {
// Get the incremented cells...
r = ...
}
r = postIncrement(increment, r)
if (canProceed) {
endNonceOperation()
}
}
return r;
```
The pseudo code after the change:
```
canProceed = startNonceOperation()
if (canProceed) {
// The following logic is actually executed in HRegion.batchMutate()
r = preIncrement(increment)
if (r != null) {
// Process increment...
r = ...
r = postIncrement(increment, r)
}
} else {
r = preIncrement(increment)
if (r != null) {
// Get the incremented cells...
r = ...
r = postIncrement(increment, r)
}
}
if (canProceed) {
endNonceOperation()
}
return r
```
I think we can discuss two cases when we don't set any RegionObserver or not.
### The case when we don't set any RegionObserver (preIncrement() always
returns null)
The behavior of the code before the change when startNonceOperation()
returns true:
1. r = preIncrement(increment) -> This returns null
2. canProceed = startNonceOperation() -> This returns true
3. // Process increment...
4. r = postIncrement(increment, r)
5. endNonceOperation()
6. return r
The behavior of the code before the change when startNonceOperation()
returns false:
1. r = preIncrement(increment) -> This returns null
2. canProceed = startNonceOperation() -> This returns false
3. // Get the incremented cells...
4. r = postIncrement(increment, r)
5. return r
The behavior of the code after the change when startNonceOperation() returns
true:
1. canProceed = startNonceOperation() -> This returns true
2. r = preIncrement(increment) -> This returns null
3. // Process increment...
4. r = postIncrement(increment, r)
5. endNonceOperation()
6. return r
The behavior of the code after the change when startNonceOperation() returns
false:
1. canProceed = startNonceOperation() -> This returns false
2. r = preIncrement(increment) -> This returns null
3. // Get the incremented cells...
4. r = postIncrement(increment, r)
5. return r
I don't think the behaviors in this case are essentially changed.
### The case when we set RegionObserver with implementing preIncrement()
The behavior of the code before the change:
1. r = preIncrement(increment) -> This returns a non-null value
2. return r
The behavior of the code after the change when startNonceOperation() returns
true:
1. canProceed = startNonceOperation() -> This returns true
2. r = preIncrement(increment) -> This returns a non-null value
3. endNonceOperation()
4. return r
The behavior of the code after the change when startNonceOperation() returns
false:
1. canProceed = startNonceOperation() -> This returns false
2. r = preIncrement(increment) -> This returns a non-null value
3. return r
The behaviors in this case are a bit changed. After the change, we always
call startNonceOperation(). However, I don't think that affects the result
itself and when we don't set any RegionObserver, we always call
startNonceOperation(), too. So I don't think it's a big problem.
What do you think? Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apac
[jira] [Commented] (HBASE-24932) Reduce the number of builds to keep for flaky find job
[ https://issues.apache.org/jira/browse/HBASE-24932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182709#comment-17182709 ] Sean Busbey commented on HBASE-24932: - At first I thought we only would need the latest build of the flaky job finder. But the more I think about it, if we don't keep any old flaky reports then there's no way to find out how a branch has been doing for flaky failures over time. I'd rather see if there's a way we can bring down the per-build size or at least keep the report HMTL since that only appears to be ~30KB. > Reduce the number of builds to keep for flaky find job > -- > > Key: HBASE-24932 > URL: https://issues.apache.org/jira/browse/HBASE-24932 > Project: HBase > Issue Type: Sub-task > Components: build, flakies, scripts >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24931) Candidate Generator helper getAction method ignoring 0th index region
[
https://issues.apache.org/jira/browse/HBASE-24931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182708#comment-17182708
]
Mallikarjun commented on HBASE-24931:
-
To give more context: I noticed this bug while writing a custom Candidate
generator for reassigning those regions which had one of their favorednodes
dead. Cost Multiplier was on the higher side, and hence it was always balancing
while 1 region was never reassigned.
> Candidate Generator helper getAction method ignoring 0th index region
> -
>
> Key: HBASE-24931
> URL: https://issues.apache.org/jira/browse/HBASE-24931
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Reporter: Mallikarjun
>Assignee: Mallikarjun
>Priority: Minor
>
> Balance Candidate generators such as `LocalityBasedCandidateGenerator`,
> `RegionReplicaCandidateGenerator`, `RegionReplicaRackCandidateGenerator`,
> etc uses helper method `getAction` to generate action is ignoring 0th index
> of `fromRegion` and `toRegion`.
> {code:java}
> protected BaseLoadBalancer.Cluster.Action getAction(int fromServer, int
> fromRegion,
> int toServer, int toRegion) {
> if (fromServer < 0 || toServer < 0) {
> return BaseLoadBalancer.Cluster.NullAction;
> }
> if (fromRegion > 0 && toRegion > 0) {
> return new BaseLoadBalancer.Cluster.SwapRegionsAction(fromServer,
> fromRegion,
> toServer, toRegion);
> } else if (fromRegion > 0) {
> return new BaseLoadBalancer.Cluster.MoveRegionAction(fromRegion,
> fromServer, toServer);
> } else if (toRegion > 0) {
> return new BaseLoadBalancer.Cluster.MoveRegionAction(toRegion, toServer,
> fromServer);
> } else {
> return BaseLoadBalancer.Cluster.NullAction;
> }
> }
> {code}
> Is this unintentional or there is some particular reason?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] rda3mon commented on pull request #2293: HBASE-24931 Fix for Candidate generator getAction method ignoring 0th…
rda3mon commented on pull request #2293: URL: https://github.com/apache/hbase/pull/2293#issuecomment-678783527 Fixing broken tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24936) review Jenkins build artifacts
[ https://issues.apache.org/jira/browse/HBASE-24936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182706#comment-17182706 ] Sean Busbey commented on HBASE-24936: - wishlist: add a stage that can run on master and abort our builds that use a lot of space when freespace is low. that would let the lighter weight builds keep working. > review Jenkins build artifacts > -- > > Key: HBASE-24936 > URL: https://issues.apache.org/jira/browse/HBASE-24936 > Project: HBase > Issue Type: Task >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > > Post move to the ci-hadoop build servers we are now the biggest user of > space. That is not a problem in and of itself, but the master node has run > out of disk space twice now. As of this snapshot we are using 125GB of > storage and the next largest project is only using 20GB. > https://paste.apache.org/kyrds > We should review our builds for any issues and come up with expectations for > what our steady-state disk usage should look like > * we are supposed to compress any test logs (usually this gets us 90-99% > space savings) > * we are supposed to clean up workspaces when jobs are done > * we are supposed to keep a fixed window of prior builds (either by days or > number of runs) > If all of our jobs are currently following these guidelines, another > possibility is to push the artifacts we need over to > [nightlies.a.o|https://nightlies.apache.org/authoring.html]. Barring that, we > should formally request asf infra set up [a plugin for storing artifact on > s3|https://plugins.jenkins.io/artifact-manager-s3/]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-24932) Reduce the number of builds to keep for flaky find job
[ https://issues.apache.org/jira/browse/HBASE-24932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24932 started by Duo Zhang. - > Reduce the number of builds to keep for flaky find job > -- > > Key: HBASE-24932 > URL: https://issues.apache.org/jira/browse/HBASE-24932 > Project: HBase > Issue Type: Sub-task > Components: build, flakies, scripts >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23147) Branches-1 shaded artifact for mapreduce integration misses MainClass
[
https://issues.apache.org/jira/browse/HBASE-23147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-23147:
--
Fix Version/s: (was: 1.3.7)
> Branches-1 shaded artifact for mapreduce integration misses MainClass
> -
>
> Key: HBASE-23147
> URL: https://issues.apache.org/jira/browse/HBASE-23147
> Project: HBase
> Issue Type: Bug
> Components: Client, mapreduce
>Affects Versions: 1.5.0, 1.3.6, 1.4.11
>Reporter: Sean Busbey
>Priority: Major
> Labels: beginner
> Fix For: 1.7.0
>
>
> the shaded artifact we intend for folks to use when doing mapreduce stuff in
> branches-1 is {{hbase-shaded-server}}, but it fails to define the same
> {{MainClass}} for the jar as the {{hbase-server}} artifact. This prevents
> commands like this from working:
> {code}
> $ hadoop jar some/path/to/hbase-shaded-server-1.4.11-SNAPSHOT.jar importtsv
> -Dimporttsv.columns=HBASE_ROW_KEY,family1:column1,family1:column4,family1:column3
> test:example example/ -libjars $(hbase mapredcp)
> Exception in thread "main" java.lang.ClassNotFoundException: importtsv
> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:348)
> at org.apache.hadoop.util.RunJar.run(RunJar.java:232)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:153)
> {code}
> The {{hbase-shaded-server}} module pom should have the same maven-jar-plugin
> config for setting the main class as the {{hbase-server}} module.
> This is not an issue in branches-2+ because as a part of moving this stuff
> into a {{hbase-mapreduce}} and {{hbase-shaded-mapreduce}} (HBASE-18697) we
> corrected this gap on the shaded artifact.
> Work around by specifying the class manually
> {code}
> hadoop jar some/path/to/hbase-shaded-server-1.4.11-SNAPSHOT.jar
> org.apache.hadoop.hbase.mapreduce.Driver importtsv
> -Dimporttsv.columns=HBASE_ROW_KEY,family1:column1,family1:column4,family1:column3
> test:example example/ -libjars $(hbase mapredcp)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-21903) Backport major compaction tool HBASE-19528 from to 1.4
[ https://issues.apache.org/jira/browse/HBASE-21903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21903: -- Fix Version/s: (was: 1.3.7) > Backport major compaction tool HBASE-19528 from to 1.4 > -- > > Key: HBASE-21903 > URL: https://issues.apache.org/jira/browse/HBASE-21903 > Project: HBase > Issue Type: Task > Components: Client, Compaction, tooling >Affects Versions: 1.3.3, 1.4.9 >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan >Priority: Major > Fix For: 1.4.14 > > Attachments: HBASE-21903-branch-1.3-addendum.patch > > > Our internal deployments are based on branch-1.3. We will be using the major > compaction tool HBASE-19528 from [~churromorales] and the enhancements on top > of it HBASE-21883 on our 1.3 clusters. I would like to backport HBASE-19528 > to 1.3 and hence 1.4 as well. Since its a standalone tool without any other > dependency or code changes, I believe that should be ok. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21903) Backport major compaction tool HBASE-19528 from to 1.4
[ https://issues.apache.org/jira/browse/HBASE-21903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21903: -- Summary: Backport major compaction tool HBASE-19528 from to 1.4 (was: Backport major compaction tool HBASE-19528 from to 1.4 and 1.3) > Backport major compaction tool HBASE-19528 from to 1.4 > -- > > Key: HBASE-21903 > URL: https://issues.apache.org/jira/browse/HBASE-21903 > Project: HBase > Issue Type: Task > Components: Client, Compaction, tooling >Affects Versions: 1.3.3, 1.4.9 >Reporter: Thiruvel Thirumoolan >Assignee: Thiruvel Thirumoolan >Priority: Major > Fix For: 1.3.7, 1.4.14 > > Attachments: HBASE-21903-branch-1.3-addendum.patch > > > Our internal deployments are based on branch-1.3. We will be using the major > compaction tool HBASE-19528 from [~churromorales] and the enhancements on top > of it HBASE-21883 on our 1.3 clusters. I would like to backport HBASE-19528 > to 1.3 and hence 1.4 as well. Since its a standalone tool without any other > dependency or code changes, I believe that should be ok. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24934) Remove all jenkins files for 1.3.x
[ https://issues.apache.org/jira/browse/HBASE-24934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24934. --- Resolution: Fixed Merged to branch-1.3. > Remove all jenkins files for 1.3.x > -- > > Key: HBASE-24934 > URL: https://issues.apache.org/jira/browse/HBASE-24934 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 1.3.7 > > > So we will not build and test it any more. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #2294: HBASE-24934 Remove all jenkins files for 1.3.x
Apache9 merged pull request #2294: URL: https://github.com/apache/hbase/pull/2294 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24936) review Jenkins build artifacts
Sean Busbey created HBASE-24936: --- Summary: review Jenkins build artifacts Key: HBASE-24936 URL: https://issues.apache.org/jira/browse/HBASE-24936 Project: HBase Issue Type: Task Reporter: Sean Busbey Assignee: Sean Busbey Post move to the ci-hadoop build servers we are now the biggest user of space. That is not a problem in and of itself, but the master node has run out of disk space twice now. As of this snapshot we are using 125GB of storage and the next largest project is only using 20GB. https://paste.apache.org/kyrds We should review our builds for any issues and come up with expectations for what our steady-state disk usage should look like * we are supposed to compress any test logs (usually this gets us 90-99% space savings) * we are supposed to clean up workspaces when jobs are done * we are supposed to keep a fixed window of prior builds (either by days or number of runs) If all of our jobs are currently following these guidelines, another possibility is to push the artifacts we need over to [nightlies.a.o|https://nightlies.apache.org/authoring.html]. Barring that, we should formally request asf infra set up [a plugin for storing artifact on s3|https://plugins.jenkins.io/artifact-manager-s3/]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table and splitParent region
Apache-HBase commented on pull request #2292: URL: https://github.com/apache/hbase/pull/2292#issuecomment-678780018 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 47s | master passed | | +1 :green_heart: | checkstyle | 1m 6s | master passed | | +1 :green_heart: | spotbugs | 1m 58s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | +1 :green_heart: | checkstyle | 1m 5s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 14s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 33m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2292 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux ffc40136d02a 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9f62a82334 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2292/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] nyl3532016 commented on a change in pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table and splitParent region
nyl3532016 commented on a change in pull request #2292:
URL: https://github.com/apache/hbase/pull/2292#discussion_r475221641
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##
@@ -1064,19 +1065,34 @@ private boolean isTableInGroup(TableName tableName,
String groupName,
return rit;
}
- private Map>>
getRSGroupAssignmentsByTable(
- String groupName) throws IOException {
+ /**
+ * This is an EXPENSIVE clone. Cloning though is the safest thing to do.
+ * Can't let out original since it can change and at least the load balancer
+ * wants to iterate this exported list.
+ * This method is invoked by {@link #balanceRSGroup}
+ *
+ * @return A clone of current assignments for this group.
+ */
+ @VisibleForTesting
+ Map>>
getRSGroupAssignmentsByTable(
+TableStateManager tableStateManager, String groupName) throws IOException {
Map>> result =
Maps.newHashMap();
Set tablesInGroupCache = new HashSet<>();
-for (Map.Entry entry :
-masterServices.getAssignmentManager().getRegionStates()
-.getRegionAssignments().entrySet()) {
+for (Map.Entry entry :
masterServices.getAssignmentManager()
+ .getRegionStates().getRegionAssignments().entrySet()) {
RegionInfo region = entry.getKey();
TableName tn = region.getTable();
ServerName server = entry.getValue();
if (isTableInGroup(tn, groupName, tablesInGroupCache)) {
+if (tableStateManager
+ .isTableState(tn, TableState.State.DISABLED,
TableState.State.DISABLING)) {
+ continue;
+}
+if (region.isSplitParent()) {
+ continue;
+}
Review comment:
> This seems an additional check to what PR title talks about. Can you
please also add PR description reg this check?
Yes, I have amended the PR description
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-24928) balanceRSGroup should skip generating balance plan for disabled table and splitParent region
[
https://issues.apache.org/jira/browse/HBASE-24928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
niuyulin updated HBASE-24928:
-
Summary: balanceRSGroup should skip generating balance plan for disabled
table and splitParent region (was: balanceRSGroup should skip generating
balance plan for disabled table)
> balanceRSGroup should skip generating balance plan for disabled table and
> splitParent region
>
>
> Key: HBASE-24928
> URL: https://issues.apache.org/jira/browse/HBASE-24928
> Project: HBase
> Issue Type: Improvement
> Components: Balancer
>Reporter: niuyulin
>Assignee: niuyulin
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
>
> now ,we generate balance plan for disabled tables, which is useless
> {code:java}
> 2020-08-20,20:47:54,702 WARN
> [RpcServer.default.RWQ.Fifo.read.handler=310,queue=6,port=22500]
> org.apache.hadoop.hbase.master.HMaster: Failed balance plan:
> hri=aa325467924edc865ab2ef6d82f9e2a7,
> source=tj1-hadoop-staging-st02.kscn,22600,1572403947348, destination=, just
> skip it
> org.apache.hadoop.hbase.client.DoNotRetryRegionException: Unexpected state
> for rit=CLOSED, location=tj1-hadoop-staging-st02.kscn,22600,1572403947348,
> table=galaxysds:sds_staging_258z, region=aa325467924edc865ab2ef6d82f9e2a7
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.preTransitCheck(AssignmentManager.java:580)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.createMoveRegionProcedure(AssignmentManager.java:635)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.moveAsync(AssignmentManager.java:652)
> at
> org.apache.hadoop.hbase.master.HMaster.executeRegionPlansWithThrottling(HMaster.java:1776)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.balanceRSGroup(RSGroupAdminServer.java:486)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint$RSGroupAdminServiceImpl.balanceRSGroup(RSGroupAdminEndpoint.java:293)
> at
> org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos$RSGroupAdminService.callMethod(RSGroupAdminProtos.java:13890)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:908)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:135)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2295: HBASE-24935 Remove 1.3.6 from download page
Apache-HBase commented on pull request #2295: URL: https://github.com/apache/hbase/pull/2295#issuecomment-678774669 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 1s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | master passed | | +1 :green_heart: | mvnsite | 10m 12s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | +1 :green_heart: | mvnsite | 10m 6s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 31m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2295/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2295 | | Optional Tests | dupname asflicense mvnsite xml | | uname | Linux 29a4b0db91ec 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9f62a82334 | | Max. process+thread count | 89 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2295/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2296: HBASE-24932 Reduce the number of builds to keep for flaky find job
Apache-HBase commented on pull request #2296: URL: https://github.com/apache/hbase/pull/2296#issuecomment-678771998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 2m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2296/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2296 | | Optional Tests | dupname asflicense | | uname | Linux a1c66a60722c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9f62a82334 | | Max. process+thread count | 52 (vs. ulimit of 12500) | | modules | C: U: | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2296/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2296: HBASE-24932 Reduce the number of builds to keep for flaky find job
Apache-HBase commented on pull request #2296: URL: https://github.com/apache/hbase/pull/2296#issuecomment-678771977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #2296: HBASE-24932 Reduce the number of builds to keep for flaky find job
Apache9 commented on pull request #2296: URL: https://github.com/apache/hbase/pull/2296#issuecomment-678771741 As we only need on successful build, 5 builds is enough I think. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request #2296: HBASE-24932 Reduce the number of builds to keep for flaky find job
Apache9 opened a new pull request #2296: URL: https://github.com/apache/hbase/pull/2296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2295: HBASE-24935 Remove 1.3.6 from download page
Apache-HBase commented on pull request #2295: URL: https://github.com/apache/hbase/pull/2295#issuecomment-678771628 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2295/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2295 | | Optional Tests | | | uname | Linux ffe31a79555b 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9f62a82334 | | Max. process+thread count | 47 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2295/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2295: HBASE-24935 Remove 1.3.6 from download page
Apache-HBase commented on pull request #2295: URL: https://github.com/apache/hbase/pull/2295#issuecomment-678771548 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2295/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2295 | | Optional Tests | | | uname | Linux 8396812b49ad 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9f62a82334 | | Max. process+thread count | 50 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2295/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request #2295: HBASE-24935 Remove 1.3.6 from download page
Apache9 opened a new pull request #2295: URL: https://github.com/apache/hbase/pull/2295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24935) Remove 1.3.6 from download page
Duo Zhang created HBASE-24935: - Summary: Remove 1.3.6 from download page Key: HBASE-24935 URL: https://issues.apache.org/jira/browse/HBASE-24935 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang Assignee: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24935) Remove 1.3.6 from download page
[ https://issues.apache.org/jira/browse/HBASE-24935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24935: -- Component/s: website > Remove 1.3.6 from download page > --- > > Key: HBASE-24935 > URL: https://issues.apache.org/jira/browse/HBASE-24935 > Project: HBase > Issue Type: Sub-task > Components: website >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24935) Remove 1.3.6 from download page
[ https://issues.apache.org/jira/browse/HBASE-24935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24935: -- Fix Version/s: 3.0.0-alpha-1 > Remove 1.3.6 from download page > --- > > Key: HBASE-24935 > URL: https://issues.apache.org/jira/browse/HBASE-24935 > Project: HBase > Issue Type: Sub-task > Components: website >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24934) Remove all jenkins files for 1.3.x
[ https://issues.apache.org/jira/browse/HBASE-24934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24934: -- Fix Version/s: 1.3.7 > Remove all jenkins files for 1.3.x > -- > > Key: HBASE-24934 > URL: https://issues.apache.org/jira/browse/HBASE-24934 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 1.3.7 > > > So we will not build and test it any more. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 opened a new pull request #2294: HBASE-24934 Remove all jenkins files for 1.3.x
Apache9 opened a new pull request #2294: URL: https://github.com/apache/hbase/pull/2294 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24934) Remove all jenkins files for 1.3.x
Duo Zhang created HBASE-24934: - Summary: Remove all jenkins files for 1.3.x Key: HBASE-24934 URL: https://issues.apache.org/jira/browse/HBASE-24934 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang Assignee: Duo Zhang So we will not build and test it any more. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24933) EOL 1.3.x release line
Duo Zhang created HBASE-24933: - Summary: EOL 1.3.x release line Key: HBASE-24933 URL: https://issues.apache.org/jira/browse/HBASE-24933 Project: HBase Issue Type: Umbrella Reporter: Duo Zhang Assignee: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24930) Reduce the number builds to keep for our jenkins jobs
[ https://issues.apache.org/jira/browse/HBASE-24930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24930: -- Issue Type: Umbrella (was: Task) > Reduce the number builds to keep for our jenkins jobs > - > > Key: HBASE-24930 > URL: https://issues.apache.org/jira/browse/HBASE-24930 > Project: HBase > Issue Type: Umbrella > Components: build, scripts >Reporter: Duo Zhang >Priority: Major > > We eat too much space on the jenkins master node. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24932) Reduce the number of builds to keep for flaky find job
Duo Zhang created HBASE-24932: - Summary: Reduce the number of builds to keep for flaky find job Key: HBASE-24932 URL: https://issues.apache.org/jira/browse/HBASE-24932 Project: HBase Issue Type: Sub-task Components: build, flakies, scripts Reporter: Duo Zhang Assignee: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24811) Use class access static field or method
[ https://issues.apache.org/jira/browse/HBASE-24811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24811. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to branch-2.3+. Thanks [~chenyechao] for contributing. > Use class access static field or method > --- > > Key: HBASE-24811 > URL: https://issues.apache.org/jira/browse/HBASE-24811 > Project: HBase > Issue Type: Improvement >Reporter: Yechao Chen >Assignee: Yechao Chen >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2 > > > we should use class to access static field or method ,not instance -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24811) Use class access static field or method
[ https://issues.apache.org/jira/browse/HBASE-24811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24811: -- Fix Version/s: 2.3.2 2.4.0 3.0.0-alpha-1 > Use class access static field or method > --- > > Key: HBASE-24811 > URL: https://issues.apache.org/jira/browse/HBASE-24811 > Project: HBase > Issue Type: Improvement >Reporter: Yechao Chen >Assignee: Yechao Chen >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2 > > > we should use class to access static field or method ,not instance -- This message was sent by Atlassian Jira (v8.3.4#803005)
