[GitHub] [hbase] Apache-HBase commented on pull request #3843: HBASE-26450 Server configuration will overwrite HStore configuration …
Apache-HBase commented on pull request #3843: URL: https://github.com/apache/hbase/pull/3843#issuecomment-966877300 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 21s | master passed | | +1 :green_heart: | compile | 1m 19s | master passed | | +1 :green_heart: | shadedjars | 9m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 55s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 5s | the patch passed | | +1 :green_heart: | compile | 1m 19s | the patch passed | | +1 :green_heart: | javac | 1m 19s | the patch passed | | +1 :green_heart: | shadedjars | 9m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 209m 27s | hbase-server in the patch passed. | | | | 245m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3843 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1e76d6c5695d 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f24484d0bc | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/testReport/ | | Max. process+thread count | 2529 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3843: HBASE-26450 Server configuration will overwrite HStore configuration …
Apache-HBase commented on pull request #3843: URL: https://github.com/apache/hbase/pull/3843#issuecomment-966849869 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 59s | master passed | | +1 :green_heart: | compile | 1m 3s | master passed | | +1 :green_heart: | shadedjars | 8m 21s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 51s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 8m 15s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 147m 32s | hbase-server in the patch passed. | | | | 178m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3843 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 512f2c715a23 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f24484d0bc | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/testReport/ | | Max. process+thread count | 3753 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3843: HBASE-26450 Server configuration will overwrite HStore configuration …
Apache-HBase commented on pull request #3843: URL: https://github.com/apache/hbase/pull/3843#issuecomment-966800220 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 49s | master passed | | +1 :green_heart: | compile | 3m 14s | master passed | | +1 :green_heart: | checkstyle | 1m 3s | master passed | | +1 :green_heart: | spotbugs | 2m 3s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | the patch passed | | +1 :green_heart: | compile | 3m 11s | the patch passed | | +1 :green_heart: | javac | 3m 11s | the patch passed | | +1 :green_heart: | checkstyle | 1m 3s | hbase-server: The patch generated 0 new + 29 unchanged - 2 fixed = 29 total (was 31) | | -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | hadoopcheck | 19m 10s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 2m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 48m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3843 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux e47b6b71dc32 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f24484d0bc | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/artifact/yetus-general-check/output/whitespace-eol.txt | | Max. process+thread count | 95 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-26450) Server configuration will overwrite HStore configuration after using shell command 'update_config'
[ https://issues.apache.org/jira/browse/HBASE-26450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang resolved HBASE-26450. --- Resolution: Fixed > Server configuration will overwrite HStore configuration after using shell > command 'update_config' > -- > > Key: HBASE-26450 > URL: https://issues.apache.org/jira/browse/HBASE-26450 > Project: HBase > Issue Type: Bug > Components: Compaction, conf, regionserver >Affects Versions: 2.5.0, 3.0.0-alpha-2 >Reporter: Zhuoyue Huang >Assignee: Zhuoyue Huang >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-2 > > > When we tried to update the configuration of online servers with shell > commands, we found that the configuration of the server would overwrite the > configuration that originally belonged to HStore. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26450) Server configuration will overwrite HStore configuration after using shell command 'update_config'
[ https://issues.apache.org/jira/browse/HBASE-26450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442565#comment-17442565 ] Zhuoyue Huang commented on HBASE-26450: --- Merged to master and branch-2. [~zhangduo] [~zhaobaiqiang] Thanks for reviewing! > Server configuration will overwrite HStore configuration after using shell > command 'update_config' > -- > > Key: HBASE-26450 > URL: https://issues.apache.org/jira/browse/HBASE-26450 > Project: HBase > Issue Type: Bug > Components: Compaction, conf, regionserver >Affects Versions: 2.5.0, 3.0.0-alpha-2 >Reporter: Zhuoyue Huang >Assignee: Zhuoyue Huang >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-2 > > > When we tried to update the configuration of online servers with shell > commands, we found that the configuration of the server would overwrite the > configuration that originally belonged to HStore. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26450) Server configuration will overwrite HStore configuration after using shell command 'update_config'
[ https://issues.apache.org/jira/browse/HBASE-26450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-26450: -- Summary: Server configuration will overwrite HStore configuration after using shell command 'update_config' (was: Server configuration will overwrite HStore configuration after using shell command 'updateConfiguration') > Server configuration will overwrite HStore configuration after using shell > command 'update_config' > -- > > Key: HBASE-26450 > URL: https://issues.apache.org/jira/browse/HBASE-26450 > Project: HBase > Issue Type: Bug > Components: Compaction, conf, regionserver >Affects Versions: 2.5.0, 3.0.0-alpha-2 >Reporter: Zhuoyue Huang >Assignee: Zhuoyue Huang >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-2 > > > When we tried to update the configuration of online servers with shell > commands, we found that the configuration of the server would overwrite the > configuration that originally belonged to HStore. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26450) Server configuration will overwrite HStore configuration after using shell command 'updateConfiguration'
[ https://issues.apache.org/jira/browse/HBASE-26450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-26450: -- Summary: Server configuration will overwrite HStore configuration after using shell command 'updateConfiguration' (was: Server configuration will overwrite HStore configuration After using shell command 'updateConfiguration') > Server configuration will overwrite HStore configuration after using shell > command 'updateConfiguration' > > > Key: HBASE-26450 > URL: https://issues.apache.org/jira/browse/HBASE-26450 > Project: HBase > Issue Type: Bug > Components: Compaction, conf, regionserver >Affects Versions: 2.5.0, 3.0.0-alpha-2 >Reporter: Zhuoyue Huang >Assignee: Zhuoyue Huang >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-2 > > > When we tried to update the configuration of online servers with shell > commands, we found that the configuration of the server would overwrite the > configuration that originally belonged to HStore. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26438) Fix flaky test TestHStore.testCompactingMemStoreCellExceedInmemoryFlushSize
[
https://issues.apache.org/jira/browse/HBASE-26438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-26438:
-
Description:
{{TestHStore.testCompactingMemStoreCellExceedInmemoryFlushSize}} sometimes is
failed and the error stack is :
{code:java}
org.apache.hadoop.hbase.DroppedSnapshotException: Failed clearing memory after
6 attempts on region: table,,1636366699236.cc87b170ebf180005d5c4bf09d404b3d.
at
org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1788)
at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1595)
at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1563)
at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1528)
at
org.apache.hadoop.hbase.regionserver.TestHStore.tearDown(TestHStore.java:661)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.RunAfters.invokeMethod(RunAfters.java:46)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at
org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)
{code}
If I modify the test code to make the test method finished after waiting for in
memory compacting completed, the test would fail all the time with the same
error stack, and if the test method finished before the in memory compacting
start, the test would always success.
Why the test would fail after the in memory compacting completed is somewhat
subtle:
1. Because {{TestHStore}} only test {{HStore}} , so in following
{{TestHStore.init}} method the new store is created separately and does not
added to {{HRegion.stores}}，
{code:java}
private HStore init(String methodName, Configuration conf,
TableDescriptorBuilder builder,
ColumnFamilyDescriptor hcd, MyStoreHook hook, boolean switchToPread)
throws IOException {
initHRegion(methodName, conf, builder, hcd, hook, switchToPread);
if (hook == null) {
store = new HStore(region, hcd, conf, false);
} else {
store = new MyStore(region, hcd, conf, hook, switchToPread);
}
return store;
}
{code}
2.When cell is added to Store,{{HStore.add}} method would not increase
{{HRegion.memStoreSizing}}, {{HRegion.memStoreSizing}} is always 0, but when in
memory compaction, the cell is forced to copy to MSLAB by
{{CellChunkImmutableSegment.copyCellIntoMSLAB}} in following line 218 in
{{CellChunkImmutableSegment.reinitializeCellSet}} ,so the type of the cell is
changed from {{KeyValue}} to {{NoTagByteBufferChunkKeyValue}},which size
increased 4 byte and {{HRegion.memStoreSizing}} is 4 :
{code:java}
211 try {
212while ((curCell = segmentScanner.next()) != null) {
213 assert(curCell instanceof ExtendedCell);
214 if (((ExtendedCell)curCell).getChunkId() ==
ExtendedCell.CELL_NOT_BASED_ON_CHUNK) {
215// CellChunkMap assumes all cells are allocated on MSLAB.
216 // Therefore, cells which are not allocated on MSLAB initially,
217 // are copied into M
[GitHub] [hbase] GeorryHuang merged pull request #3843: HBASE-26450 Server configuration will overwrite HStore configuration …
GeorryHuang merged pull request #3843: URL: https://github.com/apache/hbase/pull/3843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] GeorryHuang commented on a change in pull request #3843: HBASE-26450 Server configuration will overwrite HStore configuration …
GeorryHuang commented on a change in pull request #3843:
URL: https://github.com/apache/hbase/pull/3843#discussion_r747949756
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##
@@ -2522,10 +2520,11 @@ protected OffPeakHours getOffPeakHours() {
@Override
public void onConfigurationChange(Configuration conf) {
-this.conf = StoreUtils.createStoreConfiguration(conf,
region.getTableDescriptor(),
+Configuration storeConf = StoreUtils.createStoreConfiguration(conf,
region.getTableDescriptor(),
getColumnFamilyDescriptor());
-this.storeEngine.compactionPolicy.setConf(conf);
-this.offPeakHours = OffPeakHours.getInstance(conf);
+this.conf = storeConf;
+this.storeEngine.compactionPolicy.setConf(storeConf);
Review comment:
Precisely!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-26384) Segment already flushed to hfile may still be remained in CompactingMemStore
[
https://issues.apache.org/jira/browse/HBASE-26384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442551#comment-17442551
]
Hudson commented on HBASE-26384:
Results for branch branch-2.4
[build #236 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/236/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/236/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/236/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/236/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/236/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Segment already flushed to hfile may still be remained in CompactingMemStore
> -
>
> Key: HBASE-26384
> URL: https://issues.apache.org/jira/browse/HBASE-26384
> Project: HBase
> Issue Type: Bug
> Components: in-memory-compaction
>Affects Versions: 3.0.0-alpha-1, 2.4.8
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Labels: branch-2
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.9
>
>
> When {{CompactingMemStore}} prepares flushing,
> {{CompactingMemStore.snapshot}} invokes following
> {{CompactingMemStore.pushPipelineToSnapshot}} method to get {{Snapshot}},
> following line 570 and line 575 uses {{CompactionPipeline#version}} to track
> whether the Segments in {{CompactionPipeline#pipeline}} has changed since it
> gets {{VersionedSegmentsList}} in line 570 before emptying
> {{CompactionPipeline#pipeline}} in line 575.
> {code:java}
> 565private void pushPipelineToSnapshot() {
> 566int iterationsCnt = 0;
> 567boolean done = false;
> 568while (!done) {
> 569 iterationsCnt++;
> 570 VersionedSegmentsList segments =
> pipeline.getVersionedList();
> 571 pushToSnapshot(segments.getStoreSegments());
> 572 // swap can return false in case the pipeline was updated
> by ongoing compaction
> 573 // and the version increase, the chance of it happenning is
> very low
> 574 // In Swap: don't close segments (they are in snapshot now)
> and don't update the region size
> 575done = pipeline.swap(segments, null, false, false);
> ...
> }
>{code}
> However, when {{CompactingMemStore#inMemoryCompaction}} executes
> {{CompactionPipeline#flattenOneSegment}}, it does not change
> {{CompactionPipeline#version}} , if there is an {{in memeory compaction}}
> which executes {{CompactingMemStore#flattenOneSegment}} between above line
> 570 and line 575, the {{CompactionPipeline#version}} not change, but the
> {{Segment}} in {{CompactionPipeline}} has changed. Because
> {{CompactionPipeline#version}} not change, {{pipeline.swap}} in above line
> 575 could think it is safe to invoke following
> {{CompactionPipeline#swapSuffix}} method to remove {{Segment}} in
> {{CompactionPipeline}} , but the {{Segment}} in {{CompactionPipeline}} has
> changed because of {{CompactingMemStore#flattenOneSegment}} , so the
> {{Segment}} not removed in following line 295 and still remaining in
> {{CompactionPipeline}}.
> {code:java}
> 293 private void swapSuffix(List suffix,
> ImmutableSegment segment,
> 294 boolean closeSegmentsInSuffix) {
> 295 pipeline.removeAll(suffix);
> 296 if(segment != null) pipeline.addLast(segment);
>
> {code}
> However {{CompactingMemStore.snapshot}} think it is successful and continues
> to flush the {{Segment}} got by {{CompactingMemStore.snapshot}} as normal,
> but the {{Segment}} with the same cells still be left in
> {{CompactingMemStore}}. Leaving {{Segment}} which already flushed in
> {{MemStore}} is dangerous: if a Major Compaction before the left {{Segment}}
> flushing, there may be data erroneous.
> My Fix in the PR is as following:
> # Increasing the {{CompactionPipeline#version}} in
> {{CompactingMemStore#flatt
[jira] [Commented] (HBASE-26337) Optimization for weighted random generators
[
https://issues.apache.org/jira/browse/HBASE-26337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442552#comment-17442552
]
Hudson commented on HBASE-26337:
Results for branch branch-2.4
[build #236 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/236/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/236/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/236/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/236/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/236/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Optimization for weighted random generators
> ---
>
> Key: HBASE-26337
> URL: https://issues.apache.org/jira/browse/HBASE-26337
> Project: HBase
> Issue Type: Improvement
> Components: Balancer
>Reporter: Clara Xiong
>Assignee: Clara Xiong
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.9
>
>
> Currently we use four move candidate generators and pick one randomly for
> every move with even probability, all with optimization associated with a
> certain group of cost functions. We can assign weight for the random picking
> of generators based on balancing pressure on each group.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #3844: HBASE-26413 Limit the total size of buffered region replication entries
Apache-HBase commented on pull request #3844: URL: https://github.com/apache/hbase/pull/3844#issuecomment-966586698 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-26233 Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 57s | HBASE-26233 passed | | +1 :green_heart: | compile | 1m 42s | HBASE-26233 passed | | +1 :green_heart: | shadedjars | 10m 49s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 1s | HBASE-26233 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 2s | the patch passed | | +1 :green_heart: | compile | 1m 49s | the patch passed | | +1 :green_heart: | javac | 1m 49s | the patch passed | | +1 :green_heart: | shadedjars | 11m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 7s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 238m 53s | hbase-server in the patch failed. | | | | 285m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3844/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3844 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 32dbca82f468 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-26233 / 8aded06d20 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3844/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3844/1/testReport/ | | Max. process+thread count | 3590 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3844/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3844: HBASE-26413 Limit the total size of buffered region replication entries
Apache-HBase commented on pull request #3844: URL: https://github.com/apache/hbase/pull/3844#issuecomment-966537395 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-26233 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 18s | HBASE-26233 passed | | +1 :green_heart: | compile | 1m 3s | HBASE-26233 passed | | +1 :green_heart: | shadedjars | 8m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | HBASE-26233 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 57s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | +1 :green_heart: | shadedjars | 8m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 163m 32s | hbase-server in the patch failed. | | | | 204m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3844/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3844 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 941b299db7f7 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-26233 / 8aded06d20 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3844/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3844/1/testReport/ | | Max. process+thread count | 3723 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3844/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-22172) Suppress Java 11 reflective access warnings
[
https://issues.apache.org/jira/browse/HBASE-22172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442343#comment-17442343
]
Nick Dimiduk commented on HBASE-22172:
--
[~supercharger5] we can upgrade our netty version (see the hbase-thirdparty
repo). We still have Hadoop's old version of netty on our class path as a
transitive dependency. Until they upgrade their version, we will have runtime
warnings.
> Suppress Java 11 reflective access warnings
> ---
>
> Key: HBASE-22172
> URL: https://issues.apache.org/jira/browse/HBASE-22172
> Project: HBase
> Issue Type: Sub-task
> Components: java, scripts
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Attachments: hbase-22172.master.001.patch
>
>
> While running a Java 8 compiled hbase on Java 11 system, I found the
> following warnings being thrown. I think we can add the "--add-opens" flag to
> HBASE_OPTS (if the jdk version is 11) to suppress this warning.
> {code:java}
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> (file:/Users/jatsakthi/test/HBASE_TEST_AREA/hbase-3.0.0-SNAPSHOT/lib/hbase-common-3.0.0-SNAPSHOT.jar)
> to method java.nio.Bits.unaligned()
> WARNING: Please consider reporting this to the maintainers of
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-22671) ByteBufferUtils#findCommonPrefix() can be safely changed to ArraysSupport#mismatch()
[
https://issues.apache.org/jira/browse/HBASE-22671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-22671:
-
Affects Version/s: 2.4.0
2.3.0
2.5.0
> ByteBufferUtils#findCommonPrefix() can be safely changed to
> ArraysSupport#mismatch()
>
>
> Key: HBASE-22671
> URL: https://issues.apache.org/jira/browse/HBASE-22671
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0, 2.5.0
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Minor
>
> Microbenchmarks reveal that finding the common prefix for encoders can safely
> be replaced with ArraysSupport#mismatch().
> the microbenchmark just compares Cells that are backed with array and BB.
> For a 27 bit common row prefix the existing BBUtils#findCommonPrefix
> {code}
> BenchmarkMode CntScoreError Units
> PrefixComparator.arrayBBCompare avgt 10 869.897 ± 9.429 ns/op
> PrefixComparator.arrayCompareavgt 10 302.074 ± 13.448 ns/op
> PrefixComparator.bbArrayCompare avgt 10 869.369 ± 5.368 ns/op
> PrefixComparator.bbCompare avgt 10 409.479 ± 1.587 ns/op
> {code}
> the same with ArraysSupport#mismatch() change gives this
> {code}
> BenchmarkMode CntScore Error Units
> PrefixComparator.arrayBBCompare avgt 10 311.946 ± 1.902 ns/op
> PrefixComparator.arrayCompareavgt 10 157.010 ± 4.482 ns/op
> PrefixComparator.bbArrayCompare avgt 10 311.568 ± 1.348 ns/op
> PrefixComparator.bbCompare avgt 10 92.540 ± 0.501 ns/op
> {code}
> How ever note that this comes in flushes/compaction and not during the read
> path.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-22671) ByteBufferUtils#findCommonPrefix() can be safely changed to ArraysSupport#mismatch()
[
https://issues.apache.org/jira/browse/HBASE-22671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-22671:
-
Parent: (was: HBASE-22972)
Issue Type: Improvement (was: Sub-task)
> ByteBufferUtils#findCommonPrefix() can be safely changed to
> ArraysSupport#mismatch()
>
>
> Key: HBASE-22671
> URL: https://issues.apache.org/jira/browse/HBASE-22671
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Minor
>
> Microbenchmarks reveal that finding the common prefix for encoders can safely
> be replaced with ArraysSupport#mismatch().
> the microbenchmark just compares Cells that are backed with array and BB.
> For a 27 bit common row prefix the existing BBUtils#findCommonPrefix
> {code}
> BenchmarkMode CntScoreError Units
> PrefixComparator.arrayBBCompare avgt 10 869.897 ± 9.429 ns/op
> PrefixComparator.arrayCompareavgt 10 302.074 ± 13.448 ns/op
> PrefixComparator.bbArrayCompare avgt 10 869.369 ± 5.368 ns/op
> PrefixComparator.bbCompare avgt 10 409.479 ± 1.587 ns/op
> {code}
> the same with ArraysSupport#mismatch() change gives this
> {code}
> BenchmarkMode CntScore Error Units
> PrefixComparator.arrayBBCompare avgt 10 311.946 ± 1.902 ns/op
> PrefixComparator.arrayCompareavgt 10 157.010 ± 4.482 ns/op
> PrefixComparator.bbArrayCompare avgt 10 311.568 ± 1.348 ns/op
> PrefixComparator.bbCompare avgt 10 92.540 ± 0.501 ns/op
> {code}
> How ever note that this comes in flushes/compaction and not during the read
> path.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-22671) ByteBufferUtils#findCommonPrefix() can be safely changed to ArraysSupport#mismatch()
[
https://issues.apache.org/jira/browse/HBASE-22671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-22671:
-
Component/s: Performance
> ByteBufferUtils#findCommonPrefix() can be safely changed to
> ArraysSupport#mismatch()
>
>
> Key: HBASE-22671
> URL: https://issues.apache.org/jira/browse/HBASE-22671
> Project: HBase
> Issue Type: Improvement
> Components: Performance
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0, 2.5.0
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Minor
>
> Microbenchmarks reveal that finding the common prefix for encoders can safely
> be replaced with ArraysSupport#mismatch().
> the microbenchmark just compares Cells that are backed with array and BB.
> For a 27 bit common row prefix the existing BBUtils#findCommonPrefix
> {code}
> BenchmarkMode CntScoreError Units
> PrefixComparator.arrayBBCompare avgt 10 869.897 ± 9.429 ns/op
> PrefixComparator.arrayCompareavgt 10 302.074 ± 13.448 ns/op
> PrefixComparator.bbArrayCompare avgt 10 869.369 ± 5.368 ns/op
> PrefixComparator.bbCompare avgt 10 409.479 ± 1.587 ns/op
> {code}
> the same with ArraysSupport#mismatch() change gives this
> {code}
> BenchmarkMode CntScore Error Units
> PrefixComparator.arrayBBCompare avgt 10 311.946 ± 1.902 ns/op
> PrefixComparator.arrayCompareavgt 10 157.010 ± 4.482 ns/op
> PrefixComparator.bbArrayCompare avgt 10 311.568 ± 1.348 ns/op
> PrefixComparator.bbCompare avgt 10 92.540 ± 0.501 ns/op
> {code}
> How ever note that this comes in flushes/compaction and not during the read
> path.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-22671) ByteBufferUtils#findCommonPrefix() can be safely changed to ArraysSupport#mismatch()
[
https://issues.apache.org/jira/browse/HBASE-22671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442341#comment-17442341
]
Nick Dimiduk commented on HBASE-22671:
--
How do you propose we access this class? {{ArraysSupport}} is a JDK-internal
class.
> ByteBufferUtils#findCommonPrefix() can be safely changed to
> ArraysSupport#mismatch()
>
>
> Key: HBASE-22671
> URL: https://issues.apache.org/jira/browse/HBASE-22671
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0-alpha-1
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Minor
>
> Microbenchmarks reveal that finding the common prefix for encoders can safely
> be replaced with ArraysSupport#mismatch().
> the microbenchmark just compares Cells that are backed with array and BB.
> For a 27 bit common row prefix the existing BBUtils#findCommonPrefix
> {code}
> BenchmarkMode CntScoreError Units
> PrefixComparator.arrayBBCompare avgt 10 869.897 ± 9.429 ns/op
> PrefixComparator.arrayCompareavgt 10 302.074 ± 13.448 ns/op
> PrefixComparator.bbArrayCompare avgt 10 869.369 ± 5.368 ns/op
> PrefixComparator.bbCompare avgt 10 409.479 ± 1.587 ns/op
> {code}
> the same with ArraysSupport#mismatch() change gives this
> {code}
> BenchmarkMode CntScore Error Units
> PrefixComparator.arrayBBCompare avgt 10 311.946 ± 1.902 ns/op
> PrefixComparator.arrayCompareavgt 10 157.010 ± 4.482 ns/op
> PrefixComparator.bbArrayCompare avgt 10 311.568 ± 1.348 ns/op
> PrefixComparator.bbCompare avgt 10 92.540 ± 0.501 ns/op
> {code}
> How ever note that this comes in flushes/compaction and not during the read
> path.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #3844: HBASE-26413 Limit the total size of buffered region replication entries
Apache-HBase commented on pull request #3844: URL: https://github.com/apache/hbase/pull/3844#issuecomment-966424932 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-26233 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 7s | HBASE-26233 passed | | +1 :green_heart: | compile | 3m 15s | HBASE-26233 passed | | +1 :green_heart: | checkstyle | 1m 7s | HBASE-26233 passed | | +1 :green_heart: | spotbugs | 2m 6s | HBASE-26233 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 51s | the patch passed | | +1 :green_heart: | compile | 3m 5s | the patch passed | | +1 :green_heart: | javac | 3m 5s | the patch passed | | -0 :warning: | checkstyle | 1m 7s | hbase-server: The patch generated 3 new + 163 unchanged - 3 fixed = 166 total (was 166) | | -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | hadoopcheck | 19m 38s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 2m 18s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 49m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3844/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3844 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7b116640009c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-26233 / 8aded06d20 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3844/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3844/1/artifact/yetus-general-check/output/whitespace-eol.txt | | Max. process+thread count | 95 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3844/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24224) Update GC config examples in hbase-env.sh for G1GC
[
https://issues.apache.org/jira/browse/HBASE-24224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-24224:
-
Parent: (was: HBASE-22972)
Issue Type: Task (was: Sub-task)
> Update GC config examples in hbase-env.sh for G1GC
> --
>
> Key: HBASE-24224
> URL: https://issues.apache.org/jira/browse/HBASE-24224
> Project: HBase
> Issue Type: Task
> Components: scripts
>Affects Versions: 3.0.0-alpha-1, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Clara Xiong
>Priority: Major
>
> Anywhere we changed the default collector to G1GC, we should also update
> {{hbase-env.sh}} to include GC configuration examples appropriate for that
> collector and JVM. This means, where we support both JDK8 and JDK11, we'll
> have two sections of examples, one for CMS and the other for G1.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-26436) check-aggregate-license error related to javadns after HADOOP-17317
[
https://issues.apache.org/jira/browse/HBASE-26436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26436:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
> check-aggregate-license error related to javadns after HADOOP-17317
> ---
>
> Key: HBASE-26436
> URL: https://issues.apache.org/jira/browse/HBASE-26436
> Project: HBase
> Issue Type: Bug
> Components: build, hadoop3
>Affects Versions: 3.0.0-alpha-1, 2.5.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-2
>
>
> This impacts any HBase branch compiling vs. Hadoop trunk (current
> 3.4.0-SNAPSHOT), which includes HADOOP-17317. Build fails with
> {noformat}
> [INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (check-aggregate-license) @
> hbase-shaded-client ---
>
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed
> with message:
>
> License errors detected, for more detail find ERROR in
>
>
>
> /Users/ndimiduk/repos/apache/hbase/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE
> {noformat}
> The aggregated license file contains this entry,
> {noformat}
> --
> This product includes dnsjava licensed under the BSD-2-Clause.
> ERROR: Please check this License for acceptability here:
> https://www.apache.org/legal/resolved
> If it is okay, then update the list named 'non_aggregate_fine' in the
> LICENSE.vm file.
> If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> dnsjava
> dnsjava
> 3.4.0
> maven central search
> g:dnsjava AND a:dnsjava AND v:3.4.0
> project website
> https://github.com/dnsjava/dnsjava
> project source
> https://github.com/dnsjava/dnsjava
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-26436) check-aggregate-license error related to javadns after HADOOP-17317
[
https://issues.apache.org/jira/browse/HBASE-26436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26436:
-
Fix Version/s: 2.5.0
3.0.0-alpha-2
> check-aggregate-license error related to javadns after HADOOP-17317
> ---
>
> Key: HBASE-26436
> URL: https://issues.apache.org/jira/browse/HBASE-26436
> Project: HBase
> Issue Type: Bug
> Components: build, hadoop3
>Affects Versions: 3.0.0-alpha-1, 2.5.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-2
>
>
> This impacts any HBase branch compiling vs. Hadoop trunk (current
> 3.4.0-SNAPSHOT), which includes HADOOP-17317. Build fails with
> {noformat}
> [INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (check-aggregate-license) @
> hbase-shaded-client ---
>
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed
> with message:
>
> License errors detected, for more detail find ERROR in
>
>
>
> /Users/ndimiduk/repos/apache/hbase/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE
> {noformat}
> The aggregated license file contains this entry,
> {noformat}
> --
> This product includes dnsjava licensed under the BSD-2-Clause.
> ERROR: Please check this License for acceptability here:
> https://www.apache.org/legal/resolved
> If it is okay, then update the list named 'non_aggregate_fine' in the
> LICENSE.vm file.
> If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> dnsjava
> dnsjava
> 3.4.0
> maven central search
> g:dnsjava AND a:dnsjava AND v:3.4.0
> project website
> https://github.com/dnsjava/dnsjava
> project source
> https://github.com/dnsjava/dnsjava
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] ndimiduk merged pull request #3837: Backport "HBASE-26436 check-aggregate-license error related to javadns after HADOOP-17317" to branch-2
ndimiduk merged pull request #3837: URL: https://github.com/apache/hbase/pull/3837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk merged pull request #3836: HBASE-26436 check-aggregate-license error related to javadns after HADOOP-17317
ndimiduk merged pull request #3836: URL: https://github.com/apache/hbase/pull/3836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3837: Backport "HBASE-26436 check-aggregate-license error related to javadns after HADOOP-17317" to branch-2
Apache-HBase commented on pull request #3837: URL: https://github.com/apache/hbase/pull/3837#issuecomment-966404203 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 10s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 25s | branch-2 passed | | +1 :green_heart: | javadoc | 0m 17s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 58s | the patch passed | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 14s | hbase-resource-bundle in the patch passed. | | | | 16m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3837/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3837 | | Optional Tests | javac javadoc unit | | uname | Linux affb13d517d8 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f90882aa86 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3837/2/testReport/ | | Max. process+thread count | 77 (vs. ulimit of 12500) | | modules | C: hbase-resource-bundle U: hbase-resource-bundle | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3837/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3836: HBASE-26436 check-aggregate-license error related to javadns after HADOOP-17317
Apache-HBase commented on pull request #3836: URL: https://github.com/apache/hbase/pull/3836#issuecomment-966404247 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 40s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 18m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3836/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3836 | | Optional Tests | dupname asflicense javac xml | | uname | Linux 50d7bfa25179 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / cb3ecf65fd | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 65 (vs. ulimit of 3) | | modules | C: hbase-resource-bundle U: hbase-resource-bundle | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3836/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3836: HBASE-26436 check-aggregate-license error related to javadns after HADOOP-17317
Apache-HBase commented on pull request #3836: URL: https://github.com/apache/hbase/pull/3836#issuecomment-966402152 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 31s | master passed | | +1 :green_heart: | javadoc | 0m 17s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 18s | the patch passed | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 16s | hbase-resource-bundle in the patch passed. | | | | 15m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3836/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3836 | | Optional Tests | javac javadoc unit | | uname | Linux 996827514b9d 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / cb3ecf65fd | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3836/3/testReport/ | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-resource-bundle U: hbase-resource-bundle | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3836/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3837: Backport "HBASE-26436 check-aggregate-license error related to javadns after HADOOP-17317" to branch-2
Apache-HBase commented on pull request #3837: URL: https://github.com/apache/hbase/pull/3837#issuecomment-966401681 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 1s | branch-2 passed | | +1 :green_heart: | javadoc | 0m 16s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 32s | the patch passed | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 14s | hbase-resource-bundle in the patch passed. | | | | 12m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3837/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3837 | | Optional Tests | javac javadoc unit | | uname | Linux 4ffe6a22350f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f90882aa86 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3837/2/testReport/ | | Max. process+thread count | 78 (vs. ulimit of 12500) | | modules | C: hbase-resource-bundle U: hbase-resource-bundle | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3837/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3836: HBASE-26436 check-aggregate-license error related to javadns after HADOOP-17317
Apache-HBase commented on pull request #3836: URL: https://github.com/apache/hbase/pull/3836#issuecomment-966401340 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 36s | master passed | | +1 :green_heart: | javadoc | 0m 14s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 17s | the patch passed | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 14s | hbase-resource-bundle in the patch passed. | | | | 14m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3836/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3836 | | Optional Tests | javac javadoc unit | | uname | Linux 8aac6d1adf19 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / cb3ecf65fd | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3836/3/testReport/ | | Max. process+thread count | 65 (vs. ulimit of 3) | | modules | C: hbase-resource-bundle U: hbase-resource-bundle | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3836/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3837: Backport "HBASE-26436 check-aggregate-license error related to javadns after HADOOP-17317" to branch-2
Apache-HBase commented on pull request #3837: URL: https://github.com/apache/hbase/pull/3837#issuecomment-966400712 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 1s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 27s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 0s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 11m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3837/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3837 | | Optional Tests | dupname asflicense javac xml | | uname | Linux 974d48daf91b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f90882aa86 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 78 (vs. ulimit of 12500) | | modules | C: hbase-resource-bundle U: hbase-resource-bundle | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3837/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-filesystem] wchevreuil commented on a change in pull request #29: HBASE-26437 Clean up the znodes for the src after a rename.
wchevreuil commented on a change in pull request #29:
URL: https://github.com/apache/hbase-filesystem/pull/29#discussion_r747565792
##
File path:
hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/TreeLockManager.java
##
@@ -488,7 +488,18 @@ public void close() throws IOException {
try {
writeUnlock(src);
} finally {
- writeUnlock(dst);
+ try {
+writeUnlock(dst);
+ } finally {
+// Tricky... HBossContract tests tough things like
+// `rename("/", "/somethingelse")`
+// This means we grabbed write locks on
+/// (src)
+///somethingelse (dst)
+// Thus, we can't safely delete the znodes for src as it may
+// then also affect the (held) lock on the dst.
+recursiveDelete(src);
Review comment:
I think it's ok to delete it. The only con is that anyone trying to
access it again would then recreate the znode in writeLock()/readLock().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3843: HBASE-26450 Server configuration will overwrite HStore configuration …
Apache-HBase commented on pull request #3843: URL: https://github.com/apache/hbase/pull/3843#issuecomment-966359078 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 31s | master passed | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | shadedjars | 9m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 17s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | +1 :green_heart: | shadedjars | 9m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 212m 24s | hbase-server in the patch passed. | | | | 245m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3843 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c0fad6347f9f 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / cb3ecf65fd | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/testReport/ | | Max. process+thread count | 2549 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #3843: HBASE-26450 Server configuration will overwrite HStore configuration …
Apache9 commented on a change in pull request #3843:
URL: https://github.com/apache/hbase/pull/3843#discussion_r747551342
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##
@@ -2522,10 +2520,11 @@ protected OffPeakHours getOffPeakHours() {
@Override
public void onConfigurationChange(Configuration conf) {
-this.conf = StoreUtils.createStoreConfiguration(conf,
region.getTableDescriptor(),
+Configuration storeConf = StoreUtils.createStoreConfiguration(conf,
region.getTableDescriptor(),
getColumnFamilyDescriptor());
-this.storeEngine.compactionPolicy.setConf(conf);
-this.offPeakHours = OffPeakHours.getInstance(conf);
+this.conf = storeConf;
+this.storeEngine.compactionPolicy.setConf(storeConf);
Review comment:
OK, so the problem is here, the 'conf' here is the conf from the
parameter, not 'this.conf'...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-26439) improve upgrading doc
[
https://issues.apache.org/jira/browse/HBASE-26439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442282#comment-17442282
]
Hudson commented on HBASE-26439:
Results for branch master
[build #440 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/440/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/440/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/440/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/440/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> improve upgrading doc
> -
>
> Key: HBASE-26439
> URL: https://issues.apache.org/jira/browse/HBASE-26439
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Affects Versions: 2.4.8
>Reporter: guo
>Assignee: guo
>Priority: Minor
> Fix For: 3.0.0-alpha-2
>
>
> improve upgrading doc
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26414) Tracing INSTRUMENTATION_NAME is incorrect
[
https://issues.apache.org/jira/browse/HBASE-26414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442281#comment-17442281
]
Hudson commented on HBASE-26414:
Results for branch master
[build #440 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/440/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/440/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/440/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/440/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Tracing INSTRUMENTATION_NAME is incorrect
> -
>
> Key: HBASE-26414
> URL: https://issues.apache.org/jira/browse/HBASE-26414
> Project: HBase
> Issue Type: Bug
> Components: tracing
>Affects Versions: 2.5.0, 3.0.0-alpha-2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Blocker
> Fix For: 2.5.0, 3.0.0-alpha-2
>
>
> I believe the value we use for {{TraceUtil#INSTRUMENTATION_NAME}},
> {{"io.opentelemetry.contrib.hbase"}}, is incorrect. According to the java
> docs,
> {noformat}
>* @param instrumentationName The name of the instrumentation library, not
> the name of the
>* instrument*ed* library (e.g., "io.opentelemetry.contrib.mongodb").
> Must not be null.
> {noformat}
> This namespace appears to be reserved for implementations shipped by the otel
> project, found under
> https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation
> I don't have a suggestion for a suitable name at this time. Will report back.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26426) Remove 'Review Board' section from the site
[
https://issues.apache.org/jira/browse/HBASE-26426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442280#comment-17442280
]
Hudson commented on HBASE-26426:
Results for branch master
[build #440 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/440/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/440/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/440/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/440/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove 'Review Board' section from the site
> ---
>
> Key: HBASE-26426
> URL: https://issues.apache.org/jira/browse/HBASE-26426
> Project: HBase
> Issue Type: Task
> Components: website
>Reporter: Nick Dimiduk
>Assignee: Jan Hentschel
>Priority: Major
> Fix For: 3.0.0-alpha-2
>
>
> Under the "Apache HBase Project" menu we have a link off to Review Board. We
> have settled on Github for code review, so we should drop that link.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #3843: HBASE-26450 Server configuration will overwrite HStore configuration …
Apache-HBase commented on pull request #3843: URL: https://github.com/apache/hbase/pull/3843#issuecomment-966304030 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 45s | master passed | | +1 :green_heart: | compile | 1m 15s | master passed | | +1 :green_heart: | shadedjars | 8m 28s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 28s | the patch passed | | +1 :green_heart: | compile | 1m 13s | the patch passed | | +1 :green_heart: | javac | 1m 13s | the patch passed | | +1 :green_heart: | shadedjars | 8m 18s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 139m 47s | hbase-server in the patch passed. | | | | 172m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3843 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e3ff91c515c1 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / cb3ecf65fd | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/testReport/ | | Max. process+thread count | 3488 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-26451) Hbase Export/Import via MapReduce job
Christos Dosis created HBASE-26451:
--
Summary: Hbase Export/Import via MapReduce job
Key: HBASE-26451
URL: https://issues.apache.org/jira/browse/HBASE-26451
Project: HBase
Issue Type: Bug
Components: backup&restore
Affects Versions: 2.0.1
Reporter: Christos Dosis
Hi Hbase support team,
While using the MapReduce job with export/import commands we have the below
behaviour.
{+}Step1{+}: I have a hbase table(tsdb) with 3 rows. and export the table like
below:
/opt/hbase/bin/hbase org.apache.hadoop.hbase.mapreduce.Export tsdb
file:///opt/hbase/backup/tsdb
{+}Step2{+}: Then I delete 1 row.
{+}Step3{+}: Then I import tsdb table from the exported data from Step 1.
/opt/hbase/bin/hbase org.apache.hadoop.hbase.mapreduce.Import tsdb
file:///opt/hbase/backup/tsdb
There are still only 2 rows in the table. Is this a valid behaviour?
Br,
Chris
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #3841: HBASE-26446 CellCounter should report serialized cell size counts too
Apache-HBase commented on pull request #3841: URL: https://github.com/apache/hbase/pull/3841#issuecomment-966241875 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 28s | master passed | | +1 :green_heart: | compile | 0m 40s | master passed | | +1 :green_heart: | shadedjars | 10m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 32s | the patch passed | | +1 :green_heart: | compile | 0m 36s | the patch passed | | +1 :green_heart: | javac | 0m 36s | the patch passed | | +1 :green_heart: | shadedjars | 9m 57s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 17m 55s | hbase-mapreduce in the patch passed. | | | | 53m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3841/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3841 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2ce5feb6d103 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / cb3ecf65fd | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3841/2/testReport/ | | Max. process+thread count | 2499 (vs. ulimit of 3) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3841/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3841: HBASE-26446 CellCounter should report serialized cell size counts too
Apache-HBase commented on pull request #3841: URL: https://github.com/apache/hbase/pull/3841#issuecomment-966241509 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 11s | master passed | | +1 :green_heart: | compile | 0m 54s | master passed | | +1 :green_heart: | checkstyle | 0m 22s | master passed | | +1 :green_heart: | spotbugs | 0m 50s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 10s | the patch passed | | +1 :green_heart: | compile | 0m 52s | the patch passed | | +1 :green_heart: | javac | 0m 52s | the patch passed | | -0 :warning: | checkstyle | 0m 21s | hbase-mapreduce: The patch generated 1 new + 4 unchanged - 2 fixed = 5 total (was 6) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 26m 17s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 1m 1s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 53m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3841/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3841 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2edebc97db42 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / cb3ecf65fd | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3841/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3841/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3841: HBASE-26446 CellCounter should report serialized cell size counts too
Apache-HBase commented on pull request #3841: URL: https://github.com/apache/hbase/pull/3841#issuecomment-966235834 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 13s | master passed | | +1 :green_heart: | compile | 0m 28s | master passed | | +1 :green_heart: | shadedjars | 8m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 52s | the patch passed | | +1 :green_heart: | compile | 0m 28s | the patch passed | | +1 :green_heart: | javac | 0m 28s | the patch passed | | +1 :green_heart: | shadedjars | 8m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 19s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 11m 26s | hbase-mapreduce in the patch passed. | | | | 43m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3841/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3841 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d0685319463c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / cb3ecf65fd | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3841/2/testReport/ | | Max. process+thread count | 3687 (vs. ulimit of 3) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3841/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3843: HBASE-26450 Server configuration will overwrite HStore configuration …
Apache-HBase commented on pull request #3843: URL: https://github.com/apache/hbase/pull/3843#issuecomment-966226300 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 9s | master passed | | +1 :green_heart: | compile | 3m 15s | master passed | | +1 :green_heart: | checkstyle | 1m 5s | master passed | | +1 :green_heart: | spotbugs | 2m 6s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | the patch passed | | +1 :green_heart: | compile | 3m 12s | the patch passed | | +1 :green_heart: | javac | 3m 12s | the patch passed | | +1 :green_heart: | checkstyle | 1m 3s | hbase-server: The patch generated 0 new + 29 unchanged - 2 fixed = 29 total (was 31) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 40s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 2m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 49m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3843 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux c01573cf5a63 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / cb3ecf65fd | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] GeorryHuang opened a new pull request #3843: HBASE-26450 Server configuration will overwrite HStore configuration …
GeorryHuang opened a new pull request #3843: URL: https://github.com/apache/hbase/pull/3843 …After using shell command 'updateConfiguration' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-26450) Server configuration will overwrite HStore configuration After using shell command 'updateConfiguration'
[ https://issues.apache.org/jira/browse/HBASE-26450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang reassigned HBASE-26450: - Assignee: Zhuoyue Huang > Server configuration will overwrite HStore configuration After using shell > command 'updateConfiguration' > > > Key: HBASE-26450 > URL: https://issues.apache.org/jira/browse/HBASE-26450 > Project: HBase > Issue Type: Bug > Components: Compaction, conf, regionserver >Affects Versions: 2.5.0, 3.0.0-alpha-2 >Reporter: Zhuoyue Huang >Assignee: Zhuoyue Huang >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-2 > > > When we tried to update the configuration of online servers with shell > commands, we found that the configuration of the server would overwrite the > configuration that originally belonged to HStore. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26450) Server configuration will overwrite HStore configuration After using shell command 'updateConfiguration'
[ https://issues.apache.org/jira/browse/HBASE-26450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-26450: -- Summary: Server configuration will overwrite HStore configuration After using shell command 'updateConfiguration' (was: Server configuration will overwrite HStore configuration After using shell command'updateConfiguration') > Server configuration will overwrite HStore configuration After using shell > command 'updateConfiguration' > > > Key: HBASE-26450 > URL: https://issues.apache.org/jira/browse/HBASE-26450 > Project: HBase > Issue Type: Bug > Components: Compaction, conf, regionserver >Affects Versions: 2.5.0, 3.0.0-alpha-2 >Reporter: Zhuoyue Huang >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-2 > > > When we tried to update the configuration of online servers with shell > commands, we found that the configuration of the server would overwrite the > configuration that originally belonged to HStore. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (HBASE-26450) Server configuration will overwrite HStore configuration After using shell command'updateConfiguration'
Zhuoyue Huang created HBASE-26450: - Summary: Server configuration will overwrite HStore configuration After using shell command'updateConfiguration' Key: HBASE-26450 URL: https://issues.apache.org/jira/browse/HBASE-26450 Project: HBase Issue Type: Bug Components: Compaction, conf, regionserver Affects Versions: 2.5.0, 3.0.0-alpha-2 Reporter: Zhuoyue Huang Fix For: 2.5.0, 3.0.0-alpha-2 When we tried to update the configuration of online servers with shell commands, we found that the configuration of the server would overwrite the configuration that originally belonged to HStore. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #3842: HBASE-26421 Use HFileLink file to replace entire file‘s reference whe…
Apache-HBase commented on pull request #3842: URL: https://github.com/apache/hbase/pull/3842#issuecomment-966113529 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 18s | master passed | | +1 :green_heart: | compile | 1m 31s | master passed | | +1 :green_heart: | shadedjars | 8m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 3s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 57s | the patch passed | | +1 :green_heart: | compile | 1m 27s | the patch passed | | +1 :green_heart: | javac | 1m 27s | the patch passed | | +1 :green_heart: | shadedjars | 8m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 54s | hbase-common in the patch passed. | | -1 :x: | unit | 161m 49s | hbase-server in the patch failed. | | | | 198m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3842 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cbcb8b91cda1 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / cb3ecf65fd | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/1/testReport/ | | Max. process+thread count | 3716 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3842/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
